[{"id":3188198,"web_url":"http://patchwork.ozlabs.org/comment/3188198/","msgid":"","list_archive_url":null,"date":"2023-09-26T20:26:40","subject":"Re: [PATCH v2 7/8] hw/core/loader: gunzip(): initialize z_stream","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On Tue, 26 Sept 2023 at 21:16, Vladimir Sementsov-Ogievskiy\n wrote:\n>\n> Coverity signals that variable as being used uninitialized. And really,\n> when work with external APIs that's better to zero out the structure,\n> where we set some fields by hand.\n>\n> Signed-off-by: Vladimir Sementsov-Ogievskiy \n> ---\nReviewed-by: Peter Maydell \n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=p2W3vnMB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4RwB9y1Qngz1ynX\n\tfor ; Wed, 27 Sep 2023 06:27:18 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1qlEe6-0000l6-RP; Tue, 26 Sep 2023 16:27:02 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1qlEe5-0000kf-NZ\n for qemu-devel@nongnu.org; Tue, 26 Sep 2023 16:27:01 -0400","from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1qlEe3-0006Fd-Mx\n for qemu-devel@nongnu.org; Tue, 26 Sep 2023 16:27:01 -0400","by mail-lf1-x12e.google.com with SMTP id\n 2adb3069b0e04-50307759b65so15823394e87.0\n for ; Tue, 26 Sep 2023 13:26:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1695760018; x=1696364818; darn=nongnu.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=C/E5AmMRSLS2jKC/m61fTD4kLqWPKnSKi5Qv4Qsak9s=;\n b=p2W3vnMBU+i8PDx1op7Obpyfk8py7d1NiVo0WC75vKOKm0/fLwdyeDiVpz1LSm8GJe\n kOE0PS7IYsEFW/AptVShCc0axPekqZi+hOV+13ZTbwETMPJtgUsxjo7j7Krql99sZSkp\n jveRyOq/qOUpIZkJ/ZyoGZcfM2rx4tu29u/Y63kplb+eEbfprM2uUXDctxDzjqLWahpA\n zllD96intVh2NCH7hlmd7D/qi03T3UimYDvdyfIiDjN1qfD8RpmkGfTH6a/A0Er2YZ6g\n kaW54bzuF9bFoj4Un2mw2WVqmFVvsLtrCl+pgJzo33U7Kw/rhAXICrxoqxXFOhJ0pGC6\n Cu4g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1695760018; x=1696364818;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=C/E5AmMRSLS2jKC/m61fTD4kLqWPKnSKi5Qv4Qsak9s=;\n b=SDI1nbPWtYj9cXbylQcZIHKnMyeDbaH+00v961U+Hk1vmVwOJyt7D6Y5tLEdSo+XkW\n DIMCQlaW9LiSC069a+UiNyI15lyavLnGbmGjhC5sUPNFFhfaf+5gpcKLR/f62WZqhR1y\n dYZZYk3OJEzXL+7OBhrFhZojINS6W6/0NmHfVCtAgQkVg0JfbQhOAt1eHIiOcugXatdt\n Ii+kt6IOjNU+Mw2H8HFw/Co8OnhDR/JoMw0NVeD1bdUos/fnqbzrhz5niL156+e91XSS\n HMW2wgFqfqVbG6i7JRG7LijW4rXMCvNrlzXQD+pMk2k7yJpuoPUIe6Dx8XQ1py6tDMiI\n cUHA==","X-Gm-Message-State":"AOJu0Yz9oVKo1HyM39Vwh6PEZ369dGd0Uec8NB0dQxxAq2sGeQLeGN31\n DOJEgP9O/0XvAFn9Ig4XFTN+147Jc24vLLGJOLCuGg==","X-Google-Smtp-Source":"\n AGHT+IFcWp1tsqF9GNVvp0s8Btkp+exyUKSdt5VEb6zNz8WlQ887UPrPgucdwwxfCxt48i/rdWpaY+3KbU4fQXxdehw=","X-Received":"by 2002:a19:4f43:0:b0:502:f469:d4d5 with SMTP id\n a3-20020a194f43000000b00502f469d4d5mr8027520lfk.19.1695760017942; Tue, 26 Sep\n 2023 13:26:57 -0700 (PDT)","MIME-Version":"1.0","References":"<20230926201532.221152-1-vsementsov@yandex-team.ru>\n <20230926201532.221152-8-vsementsov@yandex-team.ru>","In-Reply-To":"<20230926201532.221152-8-vsementsov@yandex-team.ru>","From":"Peter Maydell ","Date":"Tue, 26 Sep 2023 21:26:40 +0100","Message-ID":"\n ","Subject":"Re: [PATCH v2 7/8] hw/core/loader: gunzip(): initialize z_stream","To":"Vladimir Sementsov-Ogievskiy ","Cc":"qemu-devel@nongnu.org, pbonzini@redhat.com, yc-core@yandex-team.ru,\n davydov-max@yandex-team.ru,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Thomas Huth ,\n Richard Henderson ,\n Emilio Cota ","Content-Type":"text/plain; charset=\"UTF-8\"","Received-SPF":"pass client-ip=2a00:1450:4864:20::12e;\n envelope-from=peter.maydell@linaro.org; helo=mail-lf1-x12e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]