[{"id":3188195,"web_url":"http://patchwork.ozlabs.org/comment/3188195/","msgid":"","list_archive_url":null,"date":"2023-09-26T20:26:04","subject":"Re: [PATCH v2 4/8] mc146818rtc: rtc_set_time(): initialize tm to\n zeroes","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On Tue, 26 Sept 2023 at 21:15, Vladimir Sementsov-Ogievskiy\n wrote:\n>\n> set_time() function doesn't set all the fields, so it's better to\n> initialize tm structure. And Coverity will be happier about it.\n>\n> Signed-off-by: Vladimir Sementsov-Ogievskiy \n> ---\n> hw/rtc/mc146818rtc.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n\nReviewed-by: Peter Maydell \n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=guSYXa6M;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4RwB986B3Tz1ynX\n\tfor ; Wed, 27 Sep 2023 06:26:36 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1qlEdc-0008Du-BV; Tue, 26 Sep 2023 16:26:32 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1qlEdW-0008AP-Ce\n for qemu-devel@nongnu.org; Tue, 26 Sep 2023 16:26:27 -0400","from mail-ed1-x532.google.com ([2a00:1450:4864:20::532])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1qlEdU-0005lS-Sa\n for qemu-devel@nongnu.org; Tue, 26 Sep 2023 16:26:26 -0400","by mail-ed1-x532.google.com with SMTP id\n 4fb4d7f45d1cf-5334d78c5f6so11010624a12.2\n for ; Tue, 26 Sep 2023 13:26:24 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1695759983; x=1696364783; darn=nongnu.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=XVK+pCP/Y2f69DiIvXasyz7c++tXlqJ7J7gV9eUHJrA=;\n b=guSYXa6MpLSFx3j/x76atGD+CKQbOHnZDbZsRIoEv1ZxsnQI92lyfKc6sTcQZ/qA6O\n DKr4UpJArt8uUZky1BaeaGzz98rGnUcaHnTCcawhBHG3LTOl184syJ8g26qSfJ0U44hI\n ts/5x/iUbDXfQDJYlkbB8vvRNatMOoNPwHA0sot7E+3zm+Av8Y0pEbj40KHm0fjjwmED\n PZSnQiGxAes9IXs2NhAXF4ulEMhTIRE705TyR2p0unMnai4pc+mHJpY/mRqYleqRQ5JY\n +dZV6MJtIDjVRNGzyd7Nr1A0sAlB0R4+3uaMre/cq8EZCZq8xNVIWlQNKfLQGgP4FaZ2\n Gmpg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1695759983; x=1696364783;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=XVK+pCP/Y2f69DiIvXasyz7c++tXlqJ7J7gV9eUHJrA=;\n b=eW8sMpUIg6aABr2wppaSkYLOMRciIZ3PxanXg3sSAP7l3XjUyn7pzR01LKWoKQkZqP\n f7o4GBDSsEXyzViQc1IcouURVJ5mm+VVtl0WQ2Cx0KLfxgnSO/U9iCtcO/JMi7IF3Jjm\n grC2tK2E9LX2y9rW4w9oiAWnbwVEQnnyK+D+rE/3c5W9mg+e/Mgk6GI0Z3w4R/sdVjiK\n m/eURgFwqytlCggbH069pMFvuFAyxm9oiNs221vYX8tOED0creXB2EwAKjIuwGQoSMto\n 4R2m+pgDIwc1YE4aE72ukP3Emtsg9Y/uUzGphMJC2Y+hInW43epBikcmpg5FiB9r+dzJ\n sH2Q==","X-Gm-Message-State":"AOJu0YyZg41imAIdH3CwdIxMuuAVVJi0/FBuKKv+xFtJq+9kvkytEDuT\n U3kH1iMWQJry3TFXePddRvB3rlJoKQCN2xek89Ljbw==","X-Google-Smtp-Source":"\n AGHT+IGE8csGr8Oxz2Q8txHVU5m/PugM/et3axI5QpmbiUWI1FLQYJRN4LhlwOJE5uVdpa/WiSyOinwGcIEyMgS9j3w=","X-Received":"by 2002:aa7:c98b:0:b0:530:74ed:fc85 with SMTP id\n c11-20020aa7c98b000000b0053074edfc85mr128936edt.3.1695759982843; Tue, 26 Sep\n 2023 13:26:22 -0700 (PDT)","MIME-Version":"1.0","References":"<20230926201532.221152-1-vsementsov@yandex-team.ru>\n <20230926201532.221152-5-vsementsov@yandex-team.ru>","In-Reply-To":"<20230926201532.221152-5-vsementsov@yandex-team.ru>","From":"Peter Maydell ","Date":"Tue, 26 Sep 2023 21:26:04 +0100","Message-ID":"\n ","Subject":"Re: [PATCH v2 4/8] mc146818rtc: rtc_set_time(): initialize tm to\n zeroes","To":"Vladimir Sementsov-Ogievskiy ","Cc":"qemu-devel@nongnu.org, pbonzini@redhat.com, yc-core@yandex-team.ru,\n davydov-max@yandex-team.ru, \"Michael S. Tsirkin\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Received-SPF":"pass client-ip=2a00:1450:4864:20::532;\n envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x532.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]