[{"id":3188209,"web_url":"http://patchwork.ozlabs.org/comment/3188209/","msgid":"<20230926204135.GA409047@fedora>","list_archive_url":null,"date":"2023-09-26T20:41:35","subject":"Re: [PATCH v2 6/8] block/nvme: nvme_process_completion() fix bound\n for cid","submitter":{"id":17227,"url":"http://patchwork.ozlabs.org/api/people/17227/","name":"Stefan Hajnoczi","email":"stefanha@redhat.com"},"content":"On Tue, Sep 26, 2023 at 11:15:30PM +0300, Vladimir Sementsov-Ogievskiy wrote:\n> NVMeQueuePair::reqs has length NVME_NUM_REQS, which less than\n> NVME_QUEUE_SIZE by 1.\n> \n> Fixes: 1086e95da17050 (\"block/nvme: switch to a NVMeRequest freelist\")\n> Signed-off-by: Vladimir Sementsov-Ogievskiy \n> ---\n> \n> Cc: stefanha@redhat.com\n> Cc: alex.chen@huawei.com\n> Cc: euler.robot@huawei.com\n> \n> Note, that there was similar patch in the past:\n> https://patchew.org/QEMU/20201208144452.91172-1-alex.chen@huawei.com/\n> I still think, that using NVME_NUM_REQS is better here.\n> \n> block/nvme.c | 7 ++++---\n> 1 file changed, 4 insertions(+), 3 deletions(-)\n\nReviewed-by: Stefan Hajnoczi ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=PXcmX9+K;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4RwBWK5NzZz1ynX\n\tfor ; Wed, 27 Sep 2023 06:42:21 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1qlEsN-0007u0-2o; Tue, 26 Sep 2023 16:41:47 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1qlEsL-0007th-R3\n for qemu-devel@nongnu.org; Tue, 26 Sep 2023 16:41:45 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1qlEsJ-00030K-Sz\n for qemu-devel@nongnu.org; Tue, 26 Sep 2023 16:41:45 -0400","from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-517-O-Fn9wkDMiWyJ85e4If5yg-1; Tue, 26 Sep 2023 16:41:39 -0400","from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com\n [10.11.54.6])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2B9BC800045;\n Tue, 26 Sep 2023 20:41:38 +0000 (UTC)","from localhost (unknown [10.39.192.46])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 64F0B2156702;\n Tue, 26 Sep 2023 20:41:37 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1695760903;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=i/biLNNzqaH6G/kJm5JZ0C6gIrsItYoU4jKbt/w5d4o=;\n b=PXcmX9+KiNo9q8NA/6j+BlqhBfkSVcSYDJnwYtxfPVmzfVm8K2Qjv0DI0gIV3ZOwIlW992\n l18rp689AkNcrsHVw7PetMyv8kUfca61EClBnnUcQQ2xYCUpd9PL4D2fU9kxVH1kTEth0k\n bwPeu0OP9n7qxfwaunTzie4FBrL4sac=","X-MC-Unique":"O-Fn9wkDMiWyJ85e4If5yg-1","Date":"Tue, 26 Sep 2023 16:41:35 -0400","From":"Stefan Hajnoczi ","To":"Vladimir Sementsov-Ogievskiy ","Cc":"qemu-devel@nongnu.org, pbonzini@redhat.com, peter.maydell@linaro.org,\n yc-core@yandex-team.ru, davydov-max@yandex-team.ru, alex.chen@huawei.com,\n euler.robot@huawei.com, Fam Zheng , Philippe\n\t=?iso-8859-1?q?Mathieu-Daud=E9?= ,\n Kevin Wolf , Hanna Reitz ,\n \"open list:NVMe Block Driver\" ","Subject":"Re: [PATCH v2 6/8] block/nvme: nvme_process_completion() fix bound\n for cid","Message-ID":"<20230926204135.GA409047@fedora>","References":"<20230926201532.221152-1-vsementsov@yandex-team.ru>\n <20230926201532.221152-7-vsementsov@yandex-team.ru>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n protocol=\"application/pgp-signature\"; boundary=\"QfvlyoqgmMJ8pnDb\"","Content-Disposition":"inline","In-Reply-To":"<20230926201532.221152-7-vsementsov@yandex-team.ru>","X-Scanned-By":"MIMEDefang 3.1 on 10.11.54.6","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=stefanha@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]