[{"id":3188205,"web_url":"http://patchwork.ozlabs.org/comment/3188205/","msgid":"<169576062741.534473.12201606598910537660.robh@kernel.org>","list_archive_url":null,"date":"2023-09-26T20:37:07","subject":"Re: [PATCH 1/2] dt-bindings: reset: Add Infineon SLB9670 TPM reset\n driver","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring","email":"robh@kernel.org"},"content":"On Tue, 26 Sep 2023 21:09:35 +0200, Lukas Wunner wrote:\n> A new reset driver is about to be added to perform the reset sequence of\n> the Infineon SLB9670 Trusted Platform Module.\n> \n> Document its device tree bindings.\n> \n> Signed-off-by: Lukas Wunner \n> ---\n> .../bindings/reset/infineon,slb9670-reset.yaml | 68 ++++++++++++++++++++++\n> 1 file changed, 68 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/reset/infineon,slb9670-reset.yaml\n> \n\nMy bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'\non your patch (DT_CHECKER_FLAGS is new in v5.13):\n\nyamllint warnings/errors:\n./Documentation/devicetree/bindings/reset/infineon,slb9670-reset.yaml:29:111: [warning] line too long (124 > 110 characters) (line-length)\n\ndtschema/dtc warnings/errors:\nDocumentation/devicetree/bindings/reset/infineon,slb9670-reset.example.dtb: /example-0/spi/tpm@0: failed to match any schema with compatible: ['infineon,slb9670']\n\ndoc reference errors (make refcheckdocs):\n\nSee https://patchwork.ozlabs.org/project/devicetree-bindings/patch/ae40859b82494d75e9ad7bf616b3264138ad1f6a.1695754856.git.lukas@wunner.de\n\nThe base for the series is generally the latest rc1. A different dependency\nshould be noted in *this* patch.\n\nIf you already ran 'make dt_binding_check' and didn't see the above\nerror(s), then make sure 'yamllint' is installed and dt-schema is up to\ndate:\n\npip3 install dtschema --upgrade\n\nPlease check and re-submit after running the above command yourself. Note\nthat DT_SCHEMA_FILES can be set to your schema file to speed up checking\nyour schema. However, it must be unset to test all examples with your schema.","headers":{"Return-Path":"\n ","X-Original-To":["incoming-dt@patchwork.ozlabs.org","devicetree@vger.kernel.org"],"Delivered-To":"patchwork-incoming-dt@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ZlgzqpD2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=permerror (SPF Permanent Error: More than 10 MX records returned)\n smtp.mailfrom=vger.kernel.org (client-ip=139.178.88.99;\n helo=sv.mirrors.kernel.org;\n envelope-from=devicetree+bounces-3580-incoming-dt=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from sv.mirrors.kernel.org (sv.mirrors.kernel.org [139.178.88.99])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4RwBPQ6SXBz1yp0\n\tfor ;\n Wed, 27 Sep 2023 06:37:14 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sv.mirrors.kernel.org (Postfix) with ESMTP id 20C3A282E3F\n\tfor ; Tue, 26 Sep 2023 20:37:13 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A5DF71C296;\n\tTue, 26 Sep 2023 20:37:11 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 82127125B4\n\tfor ; Tue, 26 Sep 2023 20:37:10 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 35521C433C7;\n\tTue, 26 Sep 2023 20:37:09 +0000 (UTC)","(nullmailer pid 534509 invoked by uid 1000);\n\tTue, 26 Sep 2023 20:37:07 -0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1695760630;\n\tbh=isiCWq7kNpAgGUuwdR4QUnntDfYvQNVLVhuiWQj6Pxk=;\n\th=From:To:Cc:In-Reply-To:References:Subject:Date:From;\n\tb=ZlgzqpD2NaRV6M7aQtH/FmuoImG9Wu/Qg1ut7Pfi5hU4yLrsK18SRl/1dw/FLIGqD\n\t EMyLo56YAYouj1iPurI0ZNYhFcL27H54KKlNaXtRfZ3fLFHSTutrpX19ZRSnnMeOjv\n\t yQ7MPp7cH3hzAOQAIWipgvfxX6enD+BmiXyfx2A5i9V7YwjtDRSVDpfvMGe76OHZwy\n\t V/Z8xhlCZMkhZDCr/iQLvkj6w40q/kBAnpXPgphov6Oau9jzFf3TPCTwuzsLVEnlXz\n\t ivHS9pwNsjdEabX2TuyWHZ1lgMBtIryueWEYOan4dUAxkUEXcxzW7sc55cHHaLRRyA\n\t OX6RukSEy762w==","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Precedence":"bulk","X-Mailing-List":"devicetree@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","From":"Rob Herring ","To":"Lukas Wunner ","Cc":"Rob Herring ,\n Lino Sanfilippo , linux-integrity@vger.kernel.org,\n Krzysztof Kozlowski ,\n devicetree@vger.kernel.org, Philipp Zabel ,\n Conor Dooley ","In-Reply-To":"\n ","References":"\n ","Message-Id":"<169576062741.534473.12201606598910537660.robh@kernel.org>","Subject":"Re: [PATCH 1/2] dt-bindings: reset: Add Infineon SLB9670 TPM reset\n driver","Date":"Tue, 26 Sep 2023 15:37:07 -0500"}},{"id":3188404,"web_url":"http://patchwork.ozlabs.org/comment/3188404/","msgid":"<20230927063116.GA6252@wunner.de>","list_archive_url":null,"date":"2023-09-27T06:31:16","subject":"Re: [PATCH 1/2] dt-bindings: reset: Add Infineon SLB9670 TPM reset\n driver","submitter":{"id":68499,"url":"http://patchwork.ozlabs.org/api/people/68499/","name":"Lukas Wunner","email":"lukas@wunner.de"},"content":"On Tue, Sep 26, 2023 at 03:37:07PM -0500, Rob Herring wrote:\n> On Tue, 26 Sep 2023 21:09:35 +0200, Lukas Wunner wrote:\n> > A new reset driver is about to be added to perform the reset sequence of\n> > the Infineon SLB9670 Trusted Platform Module.\n> > \n> > Document its device tree bindings.\n> \n> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'\n> on your patch (DT_CHECKER_FLAGS is new in v5.13):\n> \n> yamllint warnings/errors:\n> ./Documentation/devicetree/bindings/reset/infineon,slb9670-reset.yaml:29:111: [warning] line too long (124 > 110 characters) (line-length)\n\nThat's the following line:\n\n [1] https://www.infineon.com/dgdl/Infineon-SLB%209670VQ2.0-DataSheet-v01_04-EN.pdf?fileId=5546d4626fc1ce0b016fc78270350cd6\n\nI'm not sure what to do about it. Use an URL shortener?\n\nI did see the warning when running static checks before submission,\nbut it seemed like a false positive to me.\n\n\n> dtschema/dtc warnings/errors:\n> Documentation/devicetree/bindings/reset/infineon,slb9670-reset.example.dtb: /example-0/spi/tpm@0: failed to match any schema with compatible: ['infineon,slb9670']\n\nThe TPM DT bindings in Documentation/devicetree/bindings/security/tpm/\nhaven't been converted to YAML yet, hence the warning/error.\n\nIs it a prerequisite that I consolidate and convert them before\nthis patch is acceptable?\n\nThanks,\n\nLukas","headers":{"Return-Path":"\n ","X-Original-To":["incoming-dt@patchwork.ozlabs.org","devicetree@vger.kernel.org"],"Delivered-To":"patchwork-incoming-dt@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=permerror (SPF Permanent Error: More than 10 MX records returned)\n smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:45e3:2400::1;\n helo=sv.mirrors.kernel.org;\n envelope-from=devicetree+bounces-3654-incoming-dt=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","Received":["from sv.mirrors.kernel.org (sv.mirrors.kernel.org\n [IPv6:2604:1380:45e3:2400::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4RwRpQ0tBgz1yp8\n\tfor ;\n Wed, 27 Sep 2023 16:41:17 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sv.mirrors.kernel.org (Postfix) with ESMTP id 299062815D2\n\tfor ; Wed, 27 Sep 2023 06:41:16 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 9AB0214A9F;\n\tWed, 27 Sep 2023 06:41:14 +0000 (UTC)","from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net\n [23.128.96.19])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A2A914A89\n\tfor ; Wed, 27 Sep 2023 06:41:10 +0000 (UTC)","from bmailout3.hostsharing.net (bmailout3.hostsharing.net\n [IPv6:2a01:4f8:150:2161:1:b009:f23e:0])\n\tby lindbergh.monkeyblade.net (Postfix) with ESMTPS id A81EEFC;\n\tTue, 26 Sep 2023 23:41:08 -0700 (PDT)","from h08.hostsharing.net (h08.hostsharing.net\n [IPv6:2a01:37:1000::53df:5f1c:0])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256\n\t client-signature RSA-PSS (4096 bits) client-digest SHA256)\n\t(Client CN \"*.hostsharing.net\",\n Issuer \"RapidSSL Global TLS RSA4096 SHA256 2022 CA1\" (verified OK))\n\tby bmailout3.hostsharing.net (Postfix) with ESMTPS id 2957A100FBD1B;\n\tWed, 27 Sep 2023 08:31:17 +0200 (CEST)","by h08.hostsharing.net (Postfix, from userid 100393)\n\tid CBB53A3DDA; Wed, 27 Sep 2023 08:31:16 +0200 (CEST)"],"X-Greylist":"delayed 590 seconds by postgrey-1.37 at lindbergh.monkeyblade.net;\n Tue, 26 Sep 2023 23:41:08 PDT","Date":"Wed, 27 Sep 2023 08:31:16 +0200","From":"Lukas Wunner ","To":"Rob Herring ","Cc":"Rob Herring ,\n\tLino Sanfilippo ,\n\tlinux-integrity@vger.kernel.org,\n\tKrzysztof Kozlowski ,\n\tdevicetree@vger.kernel.org, Philipp Zabel ,\n\tConor Dooley ","Subject":"Re: [PATCH 1/2] dt-bindings: reset: Add Infineon SLB9670 TPM reset\n driver","Message-ID":"<20230927063116.GA6252@wunner.de>","References":"\n \n <169576062741.534473.12201606598910537660.robh@kernel.org>","Precedence":"bulk","X-Mailing-List":"devicetree@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<169576062741.534473.12201606598910537660.robh@kernel.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","X-Spam-Status":"No, score=-1.6 required=5.0 tests=BAYES_00,\n\tHEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,\n\tSPF_NONE autolearn=no autolearn_force=no version=3.4.6","X-Spam-Checker-Version":"SpamAssassin 3.4.6 (2021-04-09) on\n\tlindbergh.monkeyblade.net"}},{"id":3188472,"web_url":"http://patchwork.ozlabs.org/comment/3188472/","msgid":"","list_archive_url":null,"date":"2023-09-27T07:48:36","subject":"Re: [PATCH 1/2] dt-bindings: reset: Add Infineon SLB9670 TPM reset\n driver","submitter":{"id":83726,"url":"http://patchwork.ozlabs.org/api/people/83726/","name":"Krzysztof Kozlowski","email":"krzysztof.kozlowski@linaro.org"},"content":"On 26/09/2023 21:09, Lukas Wunner wrote:\n> A new reset driver is about to be added to perform the reset sequence of\n> the Infineon SLB9670 Trusted Platform Module.\n> \n> Document its device tree bindings.\n> \n> Signed-off-by: Lukas Wunner \n> ---\n> .../bindings/reset/infineon,slb9670-reset.yaml | 68 ++++++++++++++++++++++\n> 1 file changed, 68 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/reset/infineon,slb9670-reset.yaml\n> \n> diff --git a/Documentation/devicetree/bindings/reset/infineon,slb9670-reset.yaml b/Documentation/devicetree/bindings/reset/infineon,slb9670-reset.yaml\n> new file mode 100644\n> index 00000000..b1e23d47\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/reset/infineon,slb9670-reset.yaml\n> @@ -0,0 +1,68 @@\n> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)\n> +%YAML 1.2\n> +---\n> +$id: http://devicetree.org/schemas/reset/infineon,slb9670-reset.yaml#\n> +$schema: http://devicetree.org/meta-schemas/core.yaml#\n> +\n> +title: Infineon SLB9670 TPM Reset Driver\n\nSorry, bindings are for hardware, not for drivers.\n\n> +\n> +maintainers:\n> + - Lukas Wunner \n> +\n> +description: |\n> + The Infineon SLB9670 Trusted Platform Module requires a specific reset\n> + sequence on its RST# pin which is documented in sections 5.4 and 5.5 of\n> + the datasheet [1]. This driver performs the reset sequence using a GPIO.\n\nSorry, bindings are for hardware, not for drivers. I don't see the point\nfor this binding, especially that you refer to drivers. Why it cannot be\njust part of other device?\n\n\n> +\n> + The sequence with minimum wait intervals is as follows:\n> + deassert RST#\n> + wait at least 60 ms\n> + assert RST#\n> + wait at least 2 usecs\n> + deassert RST#\n> + wait at least 60 ms\n> + assert RST#\n> + wait at least 2 usecs\n> + deassert RST#\n> + wait at least 60 ms before issuing the first TPM command\n> +\n> + [1] https://www.infineon.com/dgdl/Infineon-SLB%209670VQ2.0-DataSheet-v01_04-EN.pdf?fileId=5546d4626fc1ce0b016fc78270350cd6\n> +\n> +properties:\n> + compatible:\n> + enum:\n> + - infineon,slb9670-reset\n> +\n> + reset-gpios:\n> + maxItems: 1\n> + description: Reference to the GPIO connected to the RST# pin.\n> +\n> + \"#reset-cells\":\n> + const: 0\n> +\n> +required:\n> + - compatible\n> + - reset-gpios\n> + - \"#reset-cells\"\n> +\n> +additionalProperties: false\n> +\n> +examples:\n> + - |\n> + #include \n> + tpm_reset: reset-controller {\n\nNo need for label.\n\n> + compatible = \"infineon,slb9670-reset\";\n> + #reset-cells = <0>;\n> + reset-gpios = <&gpio 0 GPIO_ACTIVE_LOW>;\n> + };\n> +\n> + spi {\n> + #address-cells = <1>;\n> + #size-cells = <0>;\n> +\n> + tpm@0 {\n> + compatible = \"infineon,slb9670\";\n\nDrop node, not related to the binding. We never keep consumers in\nbinding providers.\n\n> + reg = <0>;\n> + resets = <&tpm_reset>;\n> + };\n> + };\n\nBest regards,\nKrzysztof","headers":{"Return-Path":"\n ","X-Original-To":["incoming-dt@patchwork.ozlabs.org","devicetree@vger.kernel.org"],"Delivered-To":"patchwork-incoming-dt@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=QEOMM4QI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=permerror (SPF Permanent Error: More than 10 MX records returned)\n smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:40f1:3f00::1;\n helo=sy.mirrors.kernel.org;\n envelope-from=devicetree+bounces-3670-incoming-dt=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from sy.mirrors.kernel.org (sy.mirrors.kernel.org\n [IPv6:2604:1380:40f1:3f00::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4RwTJK33N2z1yp0\n\tfor ;\n Wed, 27 Sep 2023 17:48:48 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sy.mirrors.kernel.org (Postfix) with ESMTP id 78FF9B20B8F\n\tfor ; Wed, 27 Sep 2023 07:48:47 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 85C201C6BF;\n\tWed, 27 Sep 2023 07:48:44 +0000 (UTC)","from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net\n [23.128.96.19])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 70AB21C2BA\n\tfor ; Wed, 27 Sep 2023 07:48:42 +0000 (UTC)","from mail-ed1-x536.google.com (mail-ed1-x536.google.com\n [IPv6:2a00:1450:4864:20::536])\n\tby lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF8A01A5\n\tfor ; Wed, 27 Sep 2023 00:48:39 -0700 (PDT)","by mail-ed1-x536.google.com with SMTP id\n 4fb4d7f45d1cf-533e7d127d4so8173640a12.3\n for ;\n Wed, 27 Sep 2023 00:48:39 -0700 (PDT)","from [192.168.1.160] (host-87-4-82-94.retail.telecomitalia.it.\n [87.4.82.94])\n by smtp.gmail.com with ESMTPSA id\n v5-20020a1709064e8500b00993470682e5sm8792520eju.32.2023.09.27.00.48.36\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 27 Sep 2023 00:48:37 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1695800918; x=1696405718;\n darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:autocrypt:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:from:to:cc:subject:date:message-id:reply-to;\n bh=DDN8CaUWyyaMzzng4BvgyrNM8oRA8ZCWD7UDepNEACQ=;\n b=QEOMM4QIOAey5MCgE0qCsWB7p1P/qc5op7NC7K8Seha1miqErZpFNH1of123vYg7Ng\n Gyk+OOe0fcweliGoqCHfb7xvvjJNYU5Gz3U+oPMLbfrlW17OzlQ2INzNgF5XAeXQxUQQ\n YgIIKtVs71dao4w8p9FmGDDqRdOzN+qIV6HL2Sk9mOCu6HNGH7lmyUiy/R4CxkG7ef9I\n qwe5DWVZGgrsqAU8GaNzeSSCEOxgCwNpr36lB3n2k5zb6StK+BGm0CedM6FZV4aYgVZF\n wrzT5yOAN9M3HEiGvibBvzjYYFAMWDwS2wnU0oTZSD9aSZxb/3kdvTbSDRkplbDlMQIk\n Ao1A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1695800918; x=1696405718;\n h=content-transfer-encoding:in-reply-to:autocrypt:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=DDN8CaUWyyaMzzng4BvgyrNM8oRA8ZCWD7UDepNEACQ=;\n b=Q0DfL5W4EQ11+vURB1jBBLxEq6LWycfG1Qz2B/v85dQ3YiPH3rp/2poxn3ujcDwrqr\n fapzDxELXKZt6z0j/FIyMJ+DtzqLJRBGO28hCaI/bZAthZUfLRIaoSsjTS34mJwDdOjW\n 9R6T/FeKxItojqcNqyJ1LkFg9+64uH4Llh4E9HyXfSFgegu+NNnRr6N8RlUqwqYYx9R8\n mAAFpsNFztUIqf1pfgy3BgZj9aJot5WNKl2yEmcKfjBv98bnuY6NiCBWw1cyx/NeJkF9\n h3zt4K24zB0bKY7UIIUcsl9MK1+AWAnyc0Joe15ko1Qh1F9kFvyDB/sybdgUnMKveS0N\n 1Q5g==","X-Gm-Message-State":"AOJu0YzZbBtUMt52f8s2IdQjqBxq4UMq6MICFTMYcFc3o7AWYiPiRZnW\n\tvWJxR33tXfsEU86rmuMvuPssqw==","X-Google-Smtp-Source":"\n AGHT+IF/IKoQsRHW2/VOL3l42j/c3hARsN9XDT0ZghxoPnXf39fZNhCOMv8E5Mh5DvSOiC3lAUMu6Q==","X-Received":"by 2002:a17:906:291:b0:9ae:5ba3:9d8f with SMTP id\n 17-20020a170906029100b009ae5ba39d8fmr960815ejf.17.1695800918270;\n Wed, 27 Sep 2023 00:48:38 -0700 (PDT)","Message-ID":"","Date":"Wed, 27 Sep 2023 09:48:36 +0200","Precedence":"bulk","X-Mailing-List":"devicetree@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/2] dt-bindings: reset: Add Infineon SLB9670 TPM reset\n driver","To":"Lukas Wunner , Philipp Zabel ,\n Rob Herring ,\n Krzysztof Kozlowski ,\n Conor Dooley ","Cc":"Lino Sanfilippo ,\n linux-integrity@vger.kernel.org, devicetree@vger.kernel.org","References":"\n ","Content-Language":"en-US","From":"Krzysztof Kozlowski ","Autocrypt":"addr=krzysztof.kozlowski@linaro.org; keydata=\n xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79\n cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu\n JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH\n gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE\n J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj\n NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS\n BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU\n vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM\n Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD\n TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg\n S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE\n m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC\n HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO\n XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK\n mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh\n v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5\n cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf\n rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY\n qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR\n aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP\n gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5\n dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc\n NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0\n hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY\n oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92\n H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt\n yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd\n 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9\n 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/\n +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq\n FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy\n 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O\n DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna\n oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6\n 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ\n Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM\n qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u\n /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY\n qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU\n EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG\n KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq\n fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le\n D2GYIS41Kv4Isx2dEFh+/Q==","In-Reply-To":"\n ","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n\tSPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6","X-Spam-Checker-Version":"SpamAssassin 3.4.6 (2021-04-09) on\n\tlindbergh.monkeyblade.net"}},{"id":3188724,"web_url":"http://patchwork.ozlabs.org/comment/3188724/","msgid":"<20230927115300.GA1587935-robh@kernel.org>","list_archive_url":null,"date":"2023-09-27T11:53:00","subject":"Re: [PATCH 1/2] dt-bindings: reset: Add Infineon SLB9670 TPM reset\n driver","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring","email":"robh@kernel.org"},"content":"On Wed, Sep 27, 2023 at 08:31:16AM +0200, Lukas Wunner wrote:\n> On Tue, Sep 26, 2023 at 03:37:07PM -0500, Rob Herring wrote:\n> > On Tue, 26 Sep 2023 21:09:35 +0200, Lukas Wunner wrote:\n> > > A new reset driver is about to be added to perform the reset sequence of\n> > > the Infineon SLB9670 Trusted Platform Module.\n> > > \n> > > Document its device tree bindings.\n> > \n> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'\n> > on your patch (DT_CHECKER_FLAGS is new in v5.13):\n> > \n> > yamllint warnings/errors:\n> > ./Documentation/devicetree/bindings/reset/infineon,slb9670-reset.yaml:29:111: [warning] line too long (124 > 110 characters) (line-length)\n> \n> That's the following line:\n> \n> [1] https://www.infineon.com/dgdl/Infineon-SLB%209670VQ2.0-DataSheet-v01_04-EN.pdf?fileId=5546d4626fc1ce0b016fc78270350cd6\n> \n> I'm not sure what to do about it. Use an URL shortener?\n\nThe link doesn't even work for me.\n\n> I did see the warning when running static checks before submission,\n> but it seemed like a false positive to me.\n\nI suppose we could bump the limit by 1 as I think it is set to 110.\n\n> \n> > dtschema/dtc warnings/errors:\n> > Documentation/devicetree/bindings/reset/infineon,slb9670-reset.example.dtb: /example-0/spi/tpm@0: failed to match any schema with compatible: ['infineon,slb9670']\n> \n> The TPM DT bindings in Documentation/devicetree/bindings/security/tpm/\n> haven't been converted to YAML yet, hence the warning/error.\n\nYes, there's been multiple attempts. Everyone disappears when I say work \ntogether and consolidate the efforts.\n\n> Is it a prerequisite that I consolidate and convert them before\n> this patch is acceptable?\n\nYes. Can't have warnings.\n\nRob","headers":{"Return-Path":"\n ","X-Original-To":["incoming-dt@patchwork.ozlabs.org","devicetree@vger.kernel.org"],"Delivered-To":"patchwork-incoming-dt@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=qKJam3pB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=permerror (SPF Permanent Error: More than 10 MX records returned)\n smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:45e3:2400::1;\n helo=sv.mirrors.kernel.org;\n envelope-from=devicetree+bounces-3816-incoming-dt=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from sv.mirrors.kernel.org (sv.mirrors.kernel.org\n [IPv6:2604:1380:45e3:2400::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4RwZkC6zFxz1ynX\n\tfor ;\n Wed, 27 Sep 2023 21:53:07 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sv.mirrors.kernel.org (Postfix) with ESMTP id 0F65F2820DB\n\tfor ; Wed, 27 Sep 2023 11:53:06 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 0C40C1D68A;\n\tWed, 27 Sep 2023 11:53:04 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id D78E63FF5\n\tfor ; Wed, 27 Sep 2023 11:53:03 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 7B393C433C7;\n\tWed, 27 Sep 2023 11:53:02 +0000 (UTC)","(nullmailer pid 1595187 invoked by uid 1000);\n\tWed, 27 Sep 2023 11:53:00 -0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1695815583;\n\tbh=w7NOYvDlz9WwO8/lZ+B4+xWRuFiX5D0MM18h/+ZIoV8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qKJam3pBL23Re2oidE3bSNRNlZF5e8ZSoDSs7Cw1pLhO4rHGwsqd+KKBrKauUl14s\n\t SquphGJCtaUq2UKoqefo8+fRC8PafFUGr8g9cWJ7yI01YMLpLqGzhjzhqil2Cg7AZB\n\t Bse98S5TCJjHTmvujAYQXDWrwDr4VmLV3eRgBMS4vleoBf+E2Ehr1eFxJMVRFIG+Ol\n\t ycpU2Lr8e9bDPN627R9ym6FkXBRyh2X5rH1Sf4BVo8uv8AzS4wUFlMZyQOEp17PIQF\n\t PAbW5N853xcJynP0pn9/Lqi5lf+mgW57OPuHiH6/Qjd4TtGXYRqVxfNqq/k602tNpR\n\t QD6JQ+HtS7gog==","Date":"Wed, 27 Sep 2023 06:53:00 -0500","From":"Rob Herring ","To":"Lukas Wunner ","Cc":"Lino Sanfilippo ,\n linux-integrity@vger.kernel.org,\n Krzysztof Kozlowski ,\n devicetree@vger.kernel.org, Philipp Zabel ,\n Conor Dooley ","Subject":"Re: [PATCH 1/2] dt-bindings: reset: Add Infineon SLB9670 TPM reset\n driver","Message-ID":"<20230927115300.GA1587935-robh@kernel.org>","References":"\n \n <169576062741.534473.12201606598910537660.robh@kernel.org>\n <20230927063116.GA6252@wunner.de>","Precedence":"bulk","X-Mailing-List":"devicetree@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20230927063116.GA6252@wunner.de>"}},{"id":3220839,"web_url":"http://patchwork.ozlabs.org/comment/3220839/","msgid":"","list_archive_url":null,"date":"2023-11-21T23:33:58","subject":"Re: [PATCH 2/2] reset: Add Infineon SLB9670 TPM reset driver","submitter":{"id":84779,"url":"http://patchwork.ozlabs.org/api/people/84779/","name":"Francesco Dolcini","email":"francesco@dolcini.it"},"content":"Hello Lino, hello Lukas,\n\nOn Tue, Sep 26, 2023 at 09:09:36PM +0200, Lukas Wunner wrote:\n> From: Lino Sanfilippo \n> \n> Normally the platform firmware is responsible for taking a Trusted\n> Platform Module out of reset on boot and storing measurements into it.\n> \n> However if the platform firmware is incapable of doing that -- as is the\n> case on the Raspberry Pi -- then the onus is on the kernel to take the\n> TPM out of reset before trying to attach a driver to it.\n> \n> Provide a reset driver for such platforms.\n> \n> The Infineon SLB9670 TPM requires a specific reset sequence on its RST#\n> pin which is documented in sections 5.4 and 5.5 of the datasheet:\n> \n> https://www.infineon.com/dgdl/Infineon-SLB%209670VQ2.0-DataSheet-v01_04-EN.pdf?fileId=5546d4626fc1ce0b016fc78270350cd6\n> \n> The sequence with minimum wait intervals is as follows:\n> \n> deassert RST#\n> wait at least 60 ms\n> assert RST#\n> wait at least 2 usecs\n> deassert RST#\n> wait at least 60 ms\n> assert RST#\n> wait at least 2 usecs\n> deassert RST#\n> wait at least 60 ms before issuing the first TPM command\n\nAre you really sure that this change is required?\nI have seen the RST# Timing diagram in the datasheet, however I wonder\nif a reset is required at all during power-up, for example.\n\nNot to mention that I would have expected some firmware to implement\nsuch reset timing and I was not able to find any (I looked at\narm/arm64), if this is really required I the driver can work at all?\nWhich platform firmware implements such reset sequence?\n\nNot to mention that I was able to see the driver probe succeed in a\nsimilar setup to the one you are describing in the commit message\n(different board, arm64, but nothing done by the platform firmware).\n\nWhat am I missing?\n\nThanks,\nFrancesco","headers":{"Return-Path":"\n ","X-Original-To":["incoming-dt@patchwork.ozlabs.org","devicetree@vger.kernel.org"],"Delivered-To":"patchwork-incoming-dt@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2604:1380:45d1:ec00::1; helo=ny.mirrors.kernel.org;\n envelope-from=devicetree+bounces-17708-incoming-dt=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org; dkim=none"],"Received":["from ny.mirrors.kernel.org (ny.mirrors.kernel.org\n [IPv6:2604:1380:45d1:ec00::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4SZggv29GPz1yRw\n\tfor ;\n Wed, 22 Nov 2023 10:34:19 +1100 (AEDT)","from smtp.subspace.kernel.org (wormhole.subspace.kernel.org\n [52.25.139.140])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ny.mirrors.kernel.org (Postfix) with ESMTPS id 260951C20E03\n\tfor ; Tue, 21 Nov 2023 23:34:17 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 8979756750;\n\tTue, 21 Nov 2023 23:34:12 +0000 (UTC)","from mail11.truemail.it (mail11.truemail.it\n [IPv6:2001:4b7e:0:8::81])\n\tby lindbergh.monkeyblade.net (Postfix) with ESMTPS id 125CF98;\n\tTue, 21 Nov 2023 15:34:07 -0800 (PST)","from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it\n [93.49.2.63])\n\tby mail11.truemail.it (Postfix) with ESMTPA id BA818201F1;\n\tWed, 22 Nov 2023 00:34:04 +0100 (CET)"],"Date":"Wed, 22 Nov 2023 00:33:58 +0100","From":"Francesco Dolcini ","To":"Lukas Wunner ,\n\tLino Sanfilippo ","Cc":"Philipp Zabel ,\n\tRob Herring ,\n\tKrzysztof Kozlowski ,\n\tConor Dooley , linux-integrity@vger.kernel.org,\n\tdevicetree@vger.kernel.org","Subject":"Re: [PATCH 2/2] reset: Add Infineon SLB9670 TPM reset driver","Message-ID":"","References":"\n \n <75b775d0526e72f292e0546a306b37680714686c.1695754856.git.lukas@wunner.de>","Precedence":"bulk","X-Mailing-List":"devicetree@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"\n <75b775d0526e72f292e0546a306b37680714686c.1695754856.git.lukas@wunner.de>"}},{"id":3220958,"web_url":"http://patchwork.ozlabs.org/comment/3220958/","msgid":"","list_archive_url":null,"date":"2023-11-22T07:36:43","subject":"Re: [PATCH 2/2] reset: Add Infineon SLB9670 TPM reset driver","submitter":{"id":84779,"url":"http://patchwork.ozlabs.org/api/people/84779/","name":"Francesco Dolcini","email":"francesco@dolcini.it"},"content":"On Wed, Nov 22, 2023 at 12:34:09AM +0100, Francesco Dolcini wrote:\n> Not to mention that I would have expected some firmware to implement\n> such reset timing and I was not able to find any (I looked at\n> arm/arm64), if this is really required I the driver can work at all?\n ^^^ \n ...really required how the driver...\n\nFrancesco","headers":{"Return-Path":"\n ","X-Original-To":["incoming-dt@patchwork.ozlabs.org","devicetree@vger.kernel.org"],"Delivered-To":"patchwork-incoming-dt@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=139.178.88.99; helo=sv.mirrors.kernel.org;\n envelope-from=devicetree+bounces-17736-incoming-dt=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org; dkim=none"],"Received":["from sv.mirrors.kernel.org (sv.mirrors.kernel.org [139.178.88.99])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4SZtNx3G6Nz1yRg\n\tfor ;\n Wed, 22 Nov 2023 18:37:05 +1100 (AEDT)","from smtp.subspace.kernel.org (wormhole.subspace.kernel.org\n [52.25.139.140])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby sv.mirrors.kernel.org (Postfix) with ESMTPS id A9FBB281B6A\n\tfor ; Wed, 22 Nov 2023 07:37:03 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 1F7D51DFEA;\n\tWed, 22 Nov 2023 07:37:00 +0000 (UTC)","from mail11.truemail.it (mail11.truemail.it\n [IPv6:2001:4b7e:0:8::81])\n\tby lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9147318D;\n\tTue, 21 Nov 2023 23:36:49 -0800 (PST)","from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it\n [93.49.2.63])\n\tby mail11.truemail.it (Postfix) with ESMTPA id A1AFE1F8DC;\n\tWed, 22 Nov 2023 08:36:47 +0100 (CET)"],"Date":"Wed, 22 Nov 2023 08:36:43 +0100","From":"Francesco Dolcini ","To":"Francesco Dolcini ","Cc":"Lukas Wunner ,\n\tLino Sanfilippo ,\n\tPhilipp Zabel ,\n\tRob Herring ,\n\tKrzysztof Kozlowski ,\n\tConor Dooley , linux-integrity@vger.kernel.org,\n\tdevicetree@vger.kernel.org","Subject":"Re: [PATCH 2/2] reset: Add Infineon SLB9670 TPM reset driver","Message-ID":"","References":"\n \n <75b775d0526e72f292e0546a306b37680714686c.1695754856.git.lukas@wunner.de>\n ","Precedence":"bulk","X-Mailing-List":"devicetree@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":""}},{"id":3221147,"web_url":"http://patchwork.ozlabs.org/comment/3221147/","msgid":"<20231122112949.GA18812@wunner.de>","list_archive_url":null,"date":"2023-11-22T11:29:49","subject":"Re: [PATCH 2/2] reset: Add Infineon SLB9670 TPM reset driver","submitter":{"id":68499,"url":"http://patchwork.ozlabs.org/api/people/68499/","name":"Lukas Wunner","email":"lukas@wunner.de"},"content":"On Wed, Nov 22, 2023 at 12:33:58AM +0100, Francesco Dolcini wrote:\n> On Tue, Sep 26, 2023 at 09:09:36PM +0200, Lukas Wunner wrote:\n> > Normally the platform firmware is responsible for taking a Trusted\n> > Platform Module out of reset on boot and storing measurements into it.\n> > \n> > However if the platform firmware is incapable of doing that -- as is the\n> > case on the Raspberry Pi -- then the onus is on the kernel to take the\n> > TPM out of reset before trying to attach a driver to it.\n> > \n> > Provide a reset driver for such platforms.\n> > \n> > The Infineon SLB9670 TPM requires a specific reset sequence on its RST#\n> > pin which is documented in sections 5.4 and 5.5 of the datasheet:\n> \n> Are you really sure that this change is required?\n> I have seen the RST# Timing diagram in the datasheet, however I wonder\n> if a reset is required at all during power-up, for example.\n\nIf the RST# pin is not toggled at all upon a warm reset (reboot),\nthe TPM will remain in whatever state it was during the previous boot.\n\nAlso, the pin controller connected to RST# might be reset upon a reboot\n(think of a SoC internal pin controller setting all its registers to 0)\nand RST# might be asserted as a result. It is then necessary to take\nthe TPM out of reset.\n\n\n> Not to mention that I would have expected some firmware to implement\n> such reset timing and I was not able to find any (I looked at\n> arm/arm64), if this is really required I the driver can work at all?\n> Which platform firmware implements such reset sequence?\n\nI can't answer how a TPM is reset by firmware on arm/arm64, you'd have\nto ask an FAE at ARM. Normally I'd expect firmware in ROM do that so\nall subsequently executed code which is mutable (EFI, bootloader, kernel)\ncan be measured. Again, on simple platforms such as the Raspberry Pi\nthere's no support to reset a TPM in ROM.\n\n\n> Not to mention that I was able to see the driver probe succeed in a\n> similar setup to the one you are describing in the commit message\n> (different board, arm64, but nothing done by the platform firmware).\n\nHm, is the RST# pin even connected on that board?\n\nThanks,\n\nLukas","headers":{"Return-Path":"\n ","X-Original-To":["incoming-dt@patchwork.ozlabs.org","devicetree@vger.kernel.org"],"Delivered-To":"patchwork-incoming-dt@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2604:1380:45d1:ec00::1; helo=ny.mirrors.kernel.org;\n envelope-from=devicetree+bounces-17860-incoming-dt=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org; dkim=none"],"Received":["from ny.mirrors.kernel.org (ny.mirrors.kernel.org\n [IPv6:2604:1380:45d1:ec00::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4SZzYp0k7Hz1yRq\n\tfor ;\n Wed, 22 Nov 2023 22:30:05 +1100 (AEDT)","from smtp.subspace.kernel.org (wormhole.subspace.kernel.org\n [52.25.139.140])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ny.mirrors.kernel.org (Postfix) with ESMTPS id 45CA61C20953\n\tfor ; Wed, 22 Nov 2023 11:30:03 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 8927E54BDC;\n\tWed, 22 Nov 2023 11:29:59 +0000 (UTC)","from bmailout1.hostsharing.net (bmailout1.hostsharing.net\n [IPv6:2a01:37:1000::53df:5f64:0])\n\tby lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07C96110;\n\tWed, 22 Nov 2023 03:29:53 -0800 (PST)","from h08.hostsharing.net (h08.hostsharing.net\n [IPv6:2a01:37:1000::53df:5f1c:0])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256\n\t client-signature RSA-PSS (4096 bits) client-digest SHA256)\n\t(Client CN \"*.hostsharing.net\",\n Issuer \"RapidSSL Global TLS RSA4096 SHA256 2022 CA1\" (verified OK))\n\tby bmailout1.hostsharing.net (Postfix) with ESMTPS id 78B5830000D39;\n\tWed, 22 Nov 2023 12:29:49 +0100 (CET)","by h08.hostsharing.net (Postfix, from userid 100393)\n\tid 6D36237039; Wed, 22 Nov 2023 12:29:49 +0100 (CET)"],"Date":"Wed, 22 Nov 2023 12:29:49 +0100","From":"Lukas Wunner ","To":"Francesco Dolcini ","Cc":"Lino Sanfilippo ,\n\tPhilipp Zabel ,\n\tRob Herring ,\n\tKrzysztof Kozlowski ,\n\tConor Dooley , linux-integrity@vger.kernel.org,\n\tdevicetree@vger.kernel.org","Subject":"Re: [PATCH 2/2] reset: Add Infineon SLB9670 TPM reset driver","Message-ID":"<20231122112949.GA18812@wunner.de>","References":"\n \n <75b775d0526e72f292e0546a306b37680714686c.1695754856.git.lukas@wunner.de>\n ","Precedence":"bulk","X-Mailing-List":"devicetree@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.10.1 (2018-07-13)"}},{"id":3221309,"web_url":"http://patchwork.ozlabs.org/comment/3221309/","msgid":"","list_archive_url":null,"date":"2023-11-22T15:15:18","subject":"Re: [PATCH 2/2] reset: Add Infineon SLB9670 TPM reset driver","submitter":{"id":84779,"url":"http://patchwork.ozlabs.org/api/people/84779/","name":"Francesco Dolcini","email":"francesco@dolcini.it"},"content":"Hello Lukas,\n\nOn Wed, Nov 22, 2023 at 12:29:49PM +0100, Lukas Wunner wrote:\n> On Wed, Nov 22, 2023 at 12:33:58AM +0100, Francesco Dolcini wrote:\n> > On Tue, Sep 26, 2023 at 09:09:36PM +0200, Lukas Wunner wrote:\n> > > Normally the platform firmware is responsible for taking a Trusted\n> > > Platform Module out of reset on boot and storing measurements into it.\n> > > \n> > > However if the platform firmware is incapable of doing that -- as is the\n> > > case on the Raspberry Pi -- then the onus is on the kernel to take the\n> > > TPM out of reset before trying to attach a driver to it.\n> > > \n> > > Provide a reset driver for such platforms.\n> > > \n> > > The Infineon SLB9670 TPM requires a specific reset sequence on its RST#\n> > > pin which is documented in sections 5.4 and 5.5 of the datasheet:\n> > \n> > Are you really sure that this change is required?\n> > I have seen the RST# Timing diagram in the datasheet, however I wonder\n> > if a reset is required at all during power-up, for example.\n> \n> If the RST# pin is not toggled at all upon a warm reset (reboot),\n> the TPM will remain in whatever state it was during the previous boot.\n...\n> Also, the pin controller connected to RST# might be reset upon a reboot\n> (think of a SoC internal pin controller setting all its registers to 0)\n> and RST# might be asserted as a result. It is then necessary to take\n> the TPM out of reset.\n\nToggled at boot is different from what you are doing here.\n\n> > Not to mention that I was able to see the driver probe succeed in a\n> > similar setup to the one you are describing in the commit message\n> > (different board, arm64, but nothing done by the platform firmware).\n> \n> Hm, is the RST# pin even connected on that board?\n\nYes, it's connected and it is asserted/de-asserted (aka toggled) during\nstartup from the HW reset circuit. However this is not implementing the\nreset sequence you are implementing here.\n\nFrancesco","headers":{"Return-Path":"\n ","X-Original-To":["incoming-dt@patchwork.ozlabs.org","devicetree@vger.kernel.org"],"Delivered-To":"patchwork-incoming-dt@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=147.75.48.161; helo=sy.mirrors.kernel.org;\n envelope-from=devicetree+bounces-17980-incoming-dt=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org; dkim=none"],"Received":["from sy.mirrors.kernel.org (sy.mirrors.kernel.org [147.75.48.161])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4Sb4Z55L92z1yRw\n\tfor ;\n Thu, 23 Nov 2023 02:15:41 +1100 (AEDT)","from smtp.subspace.kernel.org (wormhole.subspace.kernel.org\n [52.25.139.140])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby sy.mirrors.kernel.org (Postfix) with ESMTPS id 02E12B21001\n\tfor ; Wed, 22 Nov 2023 15:15:41 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 3BA6114F69;\n\tWed, 22 Nov 2023 15:15:38 +0000 (UTC)","from mail11.truemail.it (mail11.truemail.it\n [IPv6:2001:4b7e:0:8::81])\n\tby lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBE1419E;\n\tWed, 22 Nov 2023 07:15:26 -0800 (PST)","from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it\n [93.49.2.63])\n\tby mail11.truemail.it (Postfix) with ESMTPA id 007CD20618;\n\tWed, 22 Nov 2023 16:15:22 +0100 (CET)"],"Date":"Wed, 22 Nov 2023 16:15:18 +0100","From":"Francesco Dolcini ","To":"Lukas Wunner ","Cc":"Francesco Dolcini ,\n\tLino Sanfilippo ,\n\tPhilipp Zabel ,\n\tRob Herring ,\n\tKrzysztof Kozlowski ,\n\tConor Dooley , linux-integrity@vger.kernel.org,\n\tdevicetree@vger.kernel.org","Subject":"Re: [PATCH 2/2] reset: Add Infineon SLB9670 TPM reset driver","Message-ID":"","References":"\n \n <75b775d0526e72f292e0546a306b37680714686c.1695754856.git.lukas@wunner.de>\n \n <20231122112949.GA18812@wunner.de>","Precedence":"bulk","X-Mailing-List":"devicetree@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20231122112949.GA18812@wunner.de>"}},{"id":3221769,"web_url":"http://patchwork.ozlabs.org/comment/3221769/","msgid":"<20231123085943.GA15463@wunner.de>","list_archive_url":null,"date":"2023-11-23T08:59:43","subject":"Re: [PATCH 2/2] reset: Add Infineon SLB9670 TPM reset driver","submitter":{"id":68499,"url":"http://patchwork.ozlabs.org/api/people/68499/","name":"Lukas Wunner","email":"lukas@wunner.de"},"content":"On Wed, Nov 22, 2023 at 04:15:18PM +0100, Francesco Dolcini wrote:\n> On Wed, Nov 22, 2023 at 12:29:49PM +0100, Lukas Wunner wrote:\n> > On Wed, Nov 22, 2023 at 12:33:58AM +0100, Francesco Dolcini wrote:\n> > > Not to mention that I was able to see the driver probe succeed in a\n> > > similar setup to the one you are describing in the commit message\n> > > (different board, arm64, but nothing done by the platform firmware).\n> > \n> > Hm, is the RST# pin even connected on that board?\n> \n> Yes, it's connected and it is asserted/de-asserted (aka toggled) during\n> startup from the HW reset circuit. However this is not implementing the\n> reset sequence you are implementing here.\n\nSection 4.5 of the datasheet seems to indicate that unless the sequence\nin Figure 3 is observed, the TPM may enter a defense mode against\ndictionary attacks \"from which a recovery is very complex or even not\npossible.\"\n\nSimply toggling the RST# pin might therefore not be sufficient to ensure\nthe TPM is operable.\n\nHere's the relevant section in the datasheet:\n\n \"The OPTIGA TPM SLB 9670 features a sophisticated protection mechanism\n against dictionary attacks on TPM-based authorization data. Basically,\n the device counts the number of failed authorization attempts in a\n counter which is located in the non-volatile memory. An attacker who\n has physical access to the device could try to cirumvent that mechanism\n by resetting the device after the authorization attempt but before the\n updated failure counter has been written into the NVM.\n\n Certain countermeasures have been added to the OPTIGA TPM SLB 9670.\n In certain time windows during power-on or warm boot of the device,\n such reset events might influence the dictionary attack counters and\n trigger other security mechanisms as well. In worst case, this might\n trigger special security defense modes from which a recovery is very\n complex or even not possible.\n\n To avoid that the OPTIGA TPM SLB 9670 reaches such a security defense\n state, the RST# signal must not be asserted in certain time windows.\n After the deassertion of the RST# signal, the system should wait for\n a minimum time of tRSTIN before asserting RST# again (see Figure 3\n and Table 11).\n\n TPM commands should only be started after tRSTIN has expired (see\n Figure 3 again). If a TPM command is running, RST# should not be\n asserted; otherwise, this might also trigger some security functions.\n When the TPM shall be reset, the command TPM2_Shutdown should be\n issued before the assertion of the RST# signal.\n\n https://www.infineon.com/dgdl/?fileId=5546d4626fc1ce0b016fc78270350cd6\n\nThanks,\n\nLukas","headers":{"Return-Path":"\n ","X-Original-To":["incoming-dt@patchwork.ozlabs.org","devicetree@vger.kernel.org"],"Delivered-To":"patchwork-incoming-dt@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2604:1380:40f1:3f00::1; helo=sy.mirrors.kernel.org;\n envelope-from=devicetree+bounces-18209-incoming-dt=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org; dkim=none"],"Received":["from sy.mirrors.kernel.org (sy.mirrors.kernel.org\n [IPv6:2604:1380:40f1:3f00::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4SbXB4101dz1yR8\n\tfor ;\n Thu, 23 Nov 2023 19:59:56 +1100 (AEDT)","from smtp.subspace.kernel.org (wormhole.subspace.kernel.org\n [52.25.139.140])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby sy.mirrors.kernel.org (Postfix) with ESMTPS id 913A3B20EC3\n\tfor ; Thu, 23 Nov 2023 08:59:55 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id AD0AE1CA86;\n\tThu, 23 Nov 2023 08:59:50 +0000 (UTC)","from bmailout1.hostsharing.net (bmailout1.hostsharing.net\n [IPv6:2a01:37:1000::53df:5f64:0])\n\tby lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E059109;\n\tThu, 23 Nov 2023 00:59:45 -0800 (PST)","from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256\n\t client-signature RSA-PSS (4096 bits) client-digest SHA256)\n\t(Client CN \"*.hostsharing.net\",\n Issuer \"RapidSSL Global TLS RSA4096 SHA256 2022 CA1\" (verified OK))\n\tby bmailout1.hostsharing.net (Postfix) with ESMTPS id C9D223000242C;\n\tThu, 23 Nov 2023 09:59:43 +0100 (CET)","by h08.hostsharing.net (Postfix, from userid 100393)\n\tid BB6373D6A3; Thu, 23 Nov 2023 09:59:43 +0100 (CET)"],"Date":"Thu, 23 Nov 2023 09:59:43 +0100","From":"Lukas Wunner ","To":"Francesco Dolcini ","Cc":"Lino Sanfilippo ,\n\tPhilipp Zabel ,\n\tRob Herring ,\n\tKrzysztof Kozlowski ,\n\tConor Dooley , linux-integrity@vger.kernel.org,\n\tdevicetree@vger.kernel.org","Subject":"Re: [PATCH 2/2] reset: Add Infineon SLB9670 TPM reset driver","Message-ID":"<20231123085943.GA15463@wunner.de>","References":"\n \n <75b775d0526e72f292e0546a306b37680714686c.1695754856.git.lukas@wunner.de>\n \n <20231122112949.GA18812@wunner.de>\n ","Precedence":"bulk","X-Mailing-List":"devicetree@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.10.1 (2018-07-13)"}},{"id":3235921,"web_url":"http://patchwork.ozlabs.org/comment/3235921/","msgid":"","list_archive_url":null,"date":"2023-12-18T17:34:00","subject":"Re: [PATCH 2/2] reset: Add Infineon SLB9670 TPM reset driver","submitter":{"id":84779,"url":"http://patchwork.ozlabs.org/api/people/84779/","name":"Francesco Dolcini","email":"francesco@dolcini.it"},"content":"Hello Lukas,\n\nOn Thu, Nov 23, 2023 at 09:59:43AM +0100, Lukas Wunner wrote:\n> On Wed, Nov 22, 2023 at 04:15:18PM +0100, Francesco Dolcini wrote:\n> > On Wed, Nov 22, 2023 at 12:29:49PM +0100, Lukas Wunner wrote:\n> > > On Wed, Nov 22, 2023 at 12:33:58AM +0100, Francesco Dolcini wrote:\n> > > > Not to mention that I was able to see the driver probe succeed in a\n> > > > similar setup to the one you are describing in the commit message\n> > > > (different board, arm64, but nothing done by the platform firmware).\n> > > \n> > > Hm, is the RST# pin even connected on that board?\n> > \n> > Yes, it's connected and it is asserted/de-asserted (aka toggled) during\n> > startup from the HW reset circuit. However this is not implementing the\n> > reset sequence you are implementing here.\n> \n> Section 4.5 of the datasheet seems to indicate that unless the sequence\n> in Figure 3 is observed, the TPM may enter a defense mode against\n> dictionary attacks \"from which a recovery is very complex or even not\n> possible.\"\n> \n> Simply toggling the RST# pin might therefore not be sufficient to ensure\n> the TPM is operable.\n\nI am trying to follow-up with infineon on this regard, do you already\nhave any insight from them maybe?\n\nMaybe this procedure is relevant only when the device is in \"security\ndefense state\"?\n\nFrancesco","headers":{"Return-Path":"\n ","X-Original-To":["incoming-dt@patchwork.ozlabs.org","devicetree@vger.kernel.org"],"Delivered-To":"patchwork-incoming-dt@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2604:1380:45d1:ec00::1; helo=ny.mirrors.kernel.org;\n envelope-from=devicetree+bounces-26706-incoming-dt=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=dolcini.it","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=dolcini.it"],"Received":["from ny.mirrors.kernel.org (ny.mirrors.kernel.org\n [IPv6:2604:1380:45d1:ec00::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4Sv6R933JYz23yx\n\tfor ;\n Tue, 19 Dec 2023 04:35:17 +1100 (AEDT)","from smtp.subspace.kernel.org (wormhole.subspace.kernel.org\n [52.25.139.140])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ny.mirrors.kernel.org (Postfix) with ESMTPS id 3B7EF1C25211\n\tfor ; Mon, 18 Dec 2023 17:35:15 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E586A5B1E6;\n\tMon, 18 Dec 2023 17:35:13 +0000 (UTC)","from mail11.truemail.it (mail11.truemail.it [217.194.8.81])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D835498B7;\n\tMon, 18 Dec 2023 17:35:08 +0000 (UTC)","from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it\n [93.49.2.63])\n\tby mail11.truemail.it (Postfix) with ESMTPA id CBCD029CDA;\n\tMon, 18 Dec 2023 18:35:00 +0100 (CET)"],"Date":"Mon, 18 Dec 2023 18:34:00 +0100","From":"Francesco Dolcini ","To":"Lukas Wunner ","Cc":"Francesco Dolcini ,\n\tLino Sanfilippo ,\n\tPhilipp Zabel ,\n\tRob Herring ,\n\tKrzysztof Kozlowski ,\n\tConor Dooley , linux-integrity@vger.kernel.org,\n\tdevicetree@vger.kernel.org","Subject":"Re: [PATCH 2/2] reset: Add Infineon SLB9670 TPM reset driver","Message-ID":"","References":"\n \n <75b775d0526e72f292e0546a306b37680714686c.1695754856.git.lukas@wunner.de>\n \n <20231122112949.GA18812@wunner.de>\n \n <20231123085943.GA15463@wunner.de>","Precedence":"bulk","X-Mailing-List":"devicetree@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20231123085943.GA15463@wunner.de>"}},{"id":3235933,"web_url":"http://patchwork.ozlabs.org/comment/3235933/","msgid":"<20231218175137.GA12115@wunner.de>","list_archive_url":null,"date":"2023-12-18T17:51:37","subject":"Re: [PATCH 2/2] reset: Add Infineon SLB9670 TPM reset driver","submitter":{"id":68499,"url":"http://patchwork.ozlabs.org/api/people/68499/","name":"Lukas Wunner","email":"lukas@wunner.de"},"content":"Hi Francesco,\n\nOn Mon, Dec 18, 2023 at 06:34:00PM +0100, Francesco Dolcini wrote:\n> On Thu, Nov 23, 2023 at 09:59:43AM +0100, Lukas Wunner wrote:\n> > On Wed, Nov 22, 2023 at 04:15:18PM +0100, Francesco Dolcini wrote:\n> > > On Wed, Nov 22, 2023 at 12:29:49PM +0100, Lukas Wunner wrote:\n> > > > On Wed, Nov 22, 2023 at 12:33:58AM +0100, Francesco Dolcini wrote:\n> > > > > Not to mention that I was able to see the driver probe succeed in a\n> > > > > similar setup to the one you are describing in the commit message\n> > > > > (different board, arm64, but nothing done by the platform firmware).\n> > > > \n> > > > Hm, is the RST# pin even connected on that board?\n> > > \n> > > Yes, it's connected and it is asserted/de-asserted (aka toggled) during\n> > > startup from the HW reset circuit. However this is not implementing the\n> > > reset sequence you are implementing here.\n> > \n> > Section 4.5 of the datasheet seems to indicate that unless the sequence\n> > in Figure 3 is observed, the TPM may enter a defense mode against\n> > dictionary attacks \"from which a recovery is very complex or even not\n> > possible.\"\n> > \n> > Simply toggling the RST# pin might therefore not be sufficient to ensure\n> > the TPM is operable.\n> \n> I am trying to follow-up with infineon on this regard, do you already\n> have any insight from them maybe?\n> \n> Maybe this procedure is relevant only when the device is in \"security\n> defense state\"?\n\nSorry, I honestly don't know. A colleague has talked to an FAE at an\nInfineon reseller but they couldn't give a definitive answer either.\nI'm very interested to hear whatever you learn from Infineon.\n\nThanks,\n\nLukas","headers":{"Return-Path":"\n ","X-Original-To":["incoming-dt@patchwork.ozlabs.org","devicetree@vger.kernel.org"],"Delivered-To":"patchwork-incoming-dt@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2604:1380:4601:e00::3; helo=am.mirrors.kernel.org;\n envelope-from=devicetree+bounces-26710-incoming-dt=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=wunner.de","smtp.subspace.kernel.org;\n spf=none smtp.mailfrom=h08.hostsharing.net"],"Received":["from am.mirrors.kernel.org (am.mirrors.kernel.org\n [IPv6:2604:1380:4601:e00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4Sv6qK3ccvz23yx\n\tfor ;\n Tue, 19 Dec 2023 04:52:45 +1100 (AEDT)","from smtp.subspace.kernel.org (wormhole.subspace.kernel.org\n [52.25.139.140])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby am.mirrors.kernel.org (Postfix) with ESMTPS id 0CCE71F253CC\n\tfor ; Mon, 18 Dec 2023 17:52:43 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 99BC072065;\n\tMon, 18 Dec 2023 17:51:49 +0000 (UTC)","from bmailout1.hostsharing.net (bmailout1.hostsharing.net\n [83.223.95.100])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id DEC7972061;\n\tMon, 18 Dec 2023 17:51:45 +0000 (UTC)","from h08.hostsharing.net (h08.hostsharing.net\n [IPv6:2a01:37:1000::53df:5f1c:0])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256\n\t client-signature RSA-PSS (4096 bits) client-digest SHA256)\n\t(Client CN \"*.hostsharing.net\",\n Issuer \"RapidSSL TLS RSA CA G1\" (verified OK))\n\tby bmailout1.hostsharing.net (Postfix) with ESMTPS id 257F330016C04;\n\tMon, 18 Dec 2023 18:51:38 +0100 (CET)","by h08.hostsharing.net (Postfix, from userid 100393)\n\tid EEB731FC00; Mon, 18 Dec 2023 18:51:37 +0100 (CET)"],"Date":"Mon, 18 Dec 2023 18:51:37 +0100","From":"Lukas Wunner ","To":"Francesco Dolcini ","Cc":"Lino Sanfilippo ,\n\tPhilipp Zabel ,\n\tRob Herring ,\n\tKrzysztof Kozlowski ,\n\tConor Dooley , linux-integrity@vger.kernel.org,\n\tdevicetree@vger.kernel.org","Subject":"Re: [PATCH 2/2] reset: Add Infineon SLB9670 TPM reset driver","Message-ID":"<20231218175137.GA12115@wunner.de>","References":"\n \n <75b775d0526e72f292e0546a306b37680714686c.1695754856.git.lukas@wunner.de>\n \n <20231122112949.GA18812@wunner.de>\n \n <20231123085943.GA15463@wunner.de>\n ","Precedence":"bulk","X-Mailing-List":"devicetree@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.10.1 (2018-07-13)"}},{"id":3237548,"web_url":"http://patchwork.ozlabs.org/comment/3237548/","msgid":"","list_archive_url":null,"date":"2023-12-21T10:09:57","subject":"Re: [PATCH 2/2] reset: Add Infineon SLB9670 TPM reset driver","submitter":{"id":68727,"url":"http://patchwork.ozlabs.org/api/people/68727/","name":"Alexander Steffen","email":"Alexander.Steffen@infineon.com"},"content":"On 18.12.2023 18:51, Lukas Wunner wrote:\n> Hi Francesco,\n> \n> On Mon, Dec 18, 2023 at 06:34:00PM +0100, Francesco Dolcini wrote:\n>> On Thu, Nov 23, 2023 at 09:59:43AM +0100, Lukas Wunner wrote:\n>>> On Wed, Nov 22, 2023 at 04:15:18PM +0100, Francesco Dolcini wrote:\n>>>> On Wed, Nov 22, 2023 at 12:29:49PM +0100, Lukas Wunner wrote:\n>>>>> On Wed, Nov 22, 2023 at 12:33:58AM +0100, Francesco Dolcini wrote:\n>>>>>> Not to mention that I was able to see the driver probe succeed in a\n>>>>>> similar setup to the one you are describing in the commit message\n>>>>>> (different board, arm64, but nothing done by the platform firmware).\n>>>>>\n>>>>> Hm, is the RST# pin even connected on that board?\n>>>>\n>>>> Yes, it's connected and it is asserted/de-asserted (aka toggled) during\n>>>> startup from the HW reset circuit. However this is not implementing the\n>>>> reset sequence you are implementing here.\n>>>\n>>> Section 4.5 of the datasheet seems to indicate that unless the sequence\n>>> in Figure 3 is observed, the TPM may enter a defense mode against\n>>> dictionary attacks \"from which a recovery is very complex or even not\n>>> possible.\"\n>>>\n>>> Simply toggling the RST# pin might therefore not be sufficient to ensure\n>>> the TPM is operable.\n>>\n>> I am trying to follow-up with infineon on this regard, do you already\n>> have any insight from them maybe?\n>>\n>> Maybe this procedure is relevant only when the device is in \"security\n>> defense state\"?\n> \n> Sorry, I honestly don't know. A colleague has talked to an FAE at an\n> Infineon reseller but they couldn't give a definitive answer either.\n> I'm very interested to hear whatever you learn from Infineon.\n\nInfineon is here :)\n\nI'm sorry, the document is a little confusing, we'll fix that in the \nfuture. What the document wants to say is this: Any time you assert \nRST#, the TPM will reset. But if you reset the TPM at certain points in \ntime, you will trigger some security functions. In general, as long as \nit only happens occasionally, this is not a problem (you can't avoid all \npower outages). Only if you happen to frequently issue resets (e.g. if \nyour reset pin is not a dedicated TPM reset pin but is also used for \nother things), then you should make sure to wait at least t_RSTIN \nbetween those resets (and avoid interrupting TPM command execution).\n\nSo in your case, you probably don't need to do anything special: Just \nassert RST# once and the TPM will reset. This should work with basically \nany TPM, so there is no need for a dedicated SLB9670 reset driver.\n\nAlexander","headers":{"Return-Path":"\n ","X-Original-To":["incoming-dt@patchwork.ozlabs.org","devicetree@vger.kernel.org"],"Delivered-To":"patchwork-incoming-dt@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=infineon.com header.i=@infineon.com header.a=rsa-sha256\n header.s=IFXMAIL header.b=k4kmueI8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2604:1380:45e3:2400::1; helo=sv.mirrors.kernel.org;\n envelope-from=devicetree+bounces-27662-incoming-dt=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=infineon.com header.i=@infineon.com\n header.b=\"k4kmueI8\"","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=infineon.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=infineon.com"],"Received":["from sv.mirrors.kernel.org (sv.mirrors.kernel.org\n [IPv6:2604:1380:45e3:2400::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4SwmS11539z1ypX\n\tfor ;\n Thu, 21 Dec 2023 21:11:45 +1100 (AEDT)","from smtp.subspace.kernel.org (wormhole.subspace.kernel.org\n [52.25.139.140])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby sv.mirrors.kernel.org (Postfix) with ESMTPS id 790A0288B2B\n\tfor ; Thu, 21 Dec 2023 10:11:43 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 1FBAF51C26;\n\tThu, 21 Dec 2023 10:11:18 +0000 (UTC)","from smtp14.infineon.com (smtp14.infineon.com [217.10.52.160])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A0ADA51039;\n\tThu, 21 Dec 2023 10:11:15 +0000 (UTC)","from unknown (HELO MUCSE822.infineon.com) ([172.23.29.53])\n by smtp14.infineon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Dec 2023 11:10:05 +0100","from MUCSE844.infineon.com (172.23.7.73) by MUCSE822.infineon.com\n (172.23.29.53) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 21 Dec\n 2023 11:10:03 +0100","from [10.160.230.42] (10.160.230.42) by MUCSE844.infineon.com\n (172.23.7.73) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 21 Dec\n 2023 11:10:03 +0100"],"DKIM-Signature":"v=1; a=rsa-sha256; c=simple/simple;\n d=infineon.com; i=@infineon.com; q=dns/txt; s=IFXMAIL;\n t=1703153477; x=1734689477;\n h=message-id:date:mime-version:subject:to:cc:references:\n from:in-reply-to:content-transfer-encoding;\n bh=5ZnwB0Mkp23zI0UrzDs+gOm1+x3wrtuME4pCko7xwcE=;\n b=k4kmueI80Twm2t1TUtYrY/PxUGECiW1HbniG+zMuDx7F+E47BkMqANea\n Luy4WPWBJs0mDq7db6Zxuh/u7/hT5ryBuU733tU9cwSD6GAllSTi1Hgr/\n Ben+rS7n+xcxrspjFfYM+ZoApDmoKg13557N9u0OEoAK5GdwEeWJQYeJA\n A=;","X-IronPort-AV":["E=McAfee;i=\"6600,9927,10930\"; a=\"38373642\"","E=Sophos;i=\"6.04,293,1695679200\";\n d=\"scan'208\";a=\"38373642\""],"Message-ID":"","Date":"Thu, 21 Dec 2023 11:09:57 +0100","Precedence":"bulk","X-Mailing-List":"devicetree@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 2/2] reset: Add Infineon SLB9670 TPM reset driver","To":"Lukas Wunner , Francesco Dolcini ","CC":"Lino Sanfilippo , Philipp Zabel\n\t, Rob Herring , \"Krzysztof\n Kozlowski\" , Conor Dooley\n\t, ,\n\t","References":"\n \n <75b775d0526e72f292e0546a306b37680714686c.1695754856.git.lukas@wunner.de>\n \n <20231122112949.GA18812@wunner.de>\n \n <20231123085943.GA15463@wunner.de>\n \n <20231218175137.GA12115@wunner.de>","From":"Alexander Steffen ","In-Reply-To":"<20231218175137.GA12115@wunner.de>","Content-Type":"text/plain; charset=\"UTF-8\"; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"MUCSE820.infineon.com (172.23.29.46) To\n MUCSE844.infineon.com (172.23.7.73)"}}]