[{"id":3188469,"web_url":"http://patchwork.ozlabs.org/comment/3188469/","msgid":"<20230927074355.GZ3208943@black.fi.intel.com>","list_archive_url":null,"date":"2023-09-27T07:43:55","subject":"Re: [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the\n absence of ACPI enumeration","submitter":{"id":14534,"url":"http://patchwork.ozlabs.org/api/people/14534/","name":"Mika Westerberg","email":"mika.westerberg@linux.intel.com"},"content":"On Tue, Sep 26, 2023 at 10:08:18PM +0300, Andy Shevchenko wrote:\n> This is to cater the need for non-ACPI system whereby\n> a platform device has to be created in order to bind\n> with the Denverton pinctrl platform driver.\n> \n> Signed-off-by: Andy Shevchenko \n\nAcked-by: Mika Westerberg ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=UblKG9qa;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2620:137:e000::1:20; helo=out1.vger.email;\n envelope-from=linux-gpio-owner@vger.kernel.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20])\n\tby legolas.ozlabs.org (Postfix) with ESMTP id 4RwTBr0r0tz1yp8\n\tfor ; Wed, 27 Sep 2023 17:44:04 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S230015AbjI0HoB (ORCPT );\n Wed, 27 Sep 2023 03:44:01 -0400","from lindbergh.monkeyblade.net ([23.128.96.19]:56540 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n with ESMTP id S230000AbjI0HoA (ORCPT\n ); Wed, 27 Sep 2023 03:44:00 -0400","from mgamail.intel.com (mgamail.intel.com [134.134.136.20])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B96710E;\n Wed, 27 Sep 2023 00:43:59 -0700 (PDT)","from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Sep 2023 00:43:58 -0700","from black.fi.intel.com ([10.237.72.28])\n by orsmga005.jf.intel.com with ESMTP; 27 Sep 2023 00:43:56 -0700","by black.fi.intel.com (Postfix, from userid 1001)\n id 6899B133D; Wed, 27 Sep 2023 10:43:55 +0300 (EEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1695800639; x=1727336639;\n h=date:from:to:cc:subject:message-id:references:\n mime-version:in-reply-to;\n bh=TkIhOBuEyWg5XuVB5v8CrmT/CVihxP0rBUx+tqvbtic=;\n b=UblKG9qaQvFFn2fa5f/yoYmkIXvkCi/Y6YoEj6hYn66B76HlDh8DsLpb\n GNNTpf+yBGEtdvryGJRl7eqrGG3P1rbYx6buE8yBqUYSwZIzwZXo2jv9h\n uiqziILBikLzXa5KZzm1dv/2ZjJ198CzFp9UAQ4hxI6zlOs6o/I+ZRq8N\n sKpEqacN0UZ8K7cizNcDW4b7X2zFb2QOzk7ID/fey70UXg5IXtFEpHno8\n ZmNeCxm0FaS+zIkug+4cDJbiGupY+AYOEN9SUVhy6wJEVn6PNHKy5Crsj\n WvSSU72o3Mf23AOt75ca9R6htqr/iuuOBbn/BFhuShm+DE1G7faThIsa8\n A==;","X-IronPort-AV":["E=McAfee;i=\"6600,9927,10845\"; a=\"372094021\"","E=Sophos;i=\"6.03,179,1694761200\";\n d=\"scan'208\";a=\"372094021\"","E=McAfee;i=\"6600,9927,10845\"; a=\"922686057\"","E=Sophos;i=\"6.03,179,1694761200\";\n d=\"scan'208\";a=\"922686057\""],"X-ExtLoop1":"1","Date":"Wed, 27 Sep 2023 10:43:55 +0300","From":"Mika Westerberg ","To":"Andy Shevchenko ","Cc":"linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,\n Andy Shevchenko ,\n Linus Walleij ,\n Takashi Iwai ","Subject":"Re: [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the\n absence of ACPI enumeration","Message-ID":"<20230927074355.GZ3208943@black.fi.intel.com>","References":"<20230926190818.931951-1-andriy.shevchenko@linux.intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230926190818.931951-1-andriy.shevchenko@linux.intel.com>","X-Spam-Status":"No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE\n autolearn=ham autolearn_force=no version=3.4.6","X-Spam-Checker-Version":"SpamAssassin 3.4.6 (2021-04-09) on\n lindbergh.monkeyblade.net","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":3188743,"web_url":"http://patchwork.ozlabs.org/comment/3188743/","msgid":"","list_archive_url":null,"date":"2023-09-27T12:19:10","subject":"Re: [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the\n absence of ACPI enumeration","submitter":{"id":8583,"url":"http://patchwork.ozlabs.org/api/people/8583/","name":"Andy Shevchenko","email":"andriy.shevchenko@linux.intel.com"},"content":"On Wed, Sep 27, 2023 at 10:43:55AM +0300, Mika Westerberg wrote:\n> On Tue, Sep 26, 2023 at 10:08:18PM +0300, Andy Shevchenko wrote:\n> > This is to cater the need for non-ACPI system whereby\n> > a platform device has to be created in order to bind\n> > with the Denverton pinctrl platform driver.\n> > \n> > Signed-off-by: Andy Shevchenko \n> \n> Acked-by: Mika Westerberg \n\nPushed to my review and testing queue, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=S+8wmEnb;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2620:137:e000::1:20; helo=out1.vger.email;\n envelope-from=linux-gpio-owner@vger.kernel.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20])\n\tby legolas.ozlabs.org (Postfix) with ESMTP id 4RwbJS0KM9z1ynX\n\tfor ; Wed, 27 Sep 2023 22:19:20 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S231565AbjI0MTR (ORCPT );\n Wed, 27 Sep 2023 08:19:17 -0400","from lindbergh.monkeyblade.net ([23.128.96.19]:47374 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n with ESMTP id S231545AbjI0MTR (ORCPT\n ); Wed, 27 Sep 2023 08:19:17 -0400","from mgamail.intel.com (mgamail.intel.com [192.55.52.115])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F399FC;\n Wed, 27 Sep 2023 05:19:16 -0700 (PDT)","from fmsmga007.fm.intel.com ([10.253.24.52])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Sep 2023 05:19:15 -0700","from smile.fi.intel.com ([10.237.72.54])\n by fmsmga007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Sep 2023 05:19:13 -0700","from andy by smile.fi.intel.com with local (Exim 4.97-RC0)\n (envelope-from )\n id 1qlTVX-00000000sex-1N2v;\n Wed, 27 Sep 2023 15:19:11 +0300"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1695817156; x=1727353156;\n h=date:from:to:cc:subject:message-id:references:\n mime-version:in-reply-to;\n bh=dQlnGg2+PmM8LyPFXpD+spP8XXKe98dRUKKao682eSU=;\n b=S+8wmEnbjrd1A0iNKPgZNekJQMD8adLtbA3zAdy/SY0pdYSO/1sRvXWD\n VQEX7JMvPsKob5yO2YsZgFgRcALV5YEbLaIgOJnbrO0OVoqXHEKSKBbfH\n FnxFCPttR7i+cylteB9TYQ+dG1SLfTgwoiL8KsaRf+9Sk41tWaQOsdkU1\n XLwvtdfvxDRfN7kzQ8qmCsS+nBufFMzzpfXovb+Vg6OLqhLyRFMkt0+gq\n KKgZmpVfYKWQZ0mSvEmnraRkNjlbu6fTytA7w/1zm/ps8Ubc4X8gPw/Fd\n wpvaB802+ubFADi935gmcGvKcDwKCOF+epStrcWJ19Hl1HPEVSo6e0Ipo\n w==;","X-IronPort-AV":["E=McAfee;i=\"6600,9927,10845\"; a=\"381711346\"","E=Sophos;i=\"6.03,181,1694761200\";\n d=\"scan'208\";a=\"381711346\"","E=McAfee;i=\"6600,9927,10845\"; a=\"752551892\"","E=Sophos;i=\"6.03,181,1694761200\";\n d=\"scan'208\";a=\"752551892\""],"X-ExtLoop1":"1","Date":"Wed, 27 Sep 2023 15:19:10 +0300","From":"Andy Shevchenko ","To":"Mika Westerberg ","Cc":"linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,\n Linus Walleij ,\n Takashi Iwai ","Subject":"Re: [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the\n absence of ACPI enumeration","Message-ID":"","References":"<20230926190818.931951-1-andriy.shevchenko@linux.intel.com>\n <20230927074355.GZ3208943@black.fi.intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20230927074355.GZ3208943@black.fi.intel.com>","Organization":"Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo","X-Spam-Status":"No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6","X-Spam-Checker-Version":"SpamAssassin 3.4.6 (2021-04-09) on\n lindbergh.monkeyblade.net","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":3192456,"web_url":"http://patchwork.ozlabs.org/comment/3192456/","msgid":"<76d1e643-9b81-4c23-8f46-73fe59913600@kernel.org>","list_archive_url":null,"date":"2023-10-04T08:18:01","subject":"Re: [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the\n absence of ACPI enumeration","submitter":{"id":68952,"url":"http://patchwork.ozlabs.org/api/people/68952/","name":"Krzysztof Kozlowski","email":"krzk@kernel.org"},"content":"On 26/09/2023 21:08, Andy Shevchenko wrote:\n> This is to cater the need for non-ACPI system whereby\n> a platform device has to be created in order to bind\n> with the Denverton pinctrl platform driver.\n> \n> Signed-off-by: Andy Shevchenko \n> ---\n> drivers/pinctrl/intel/pinctrl-denverton.c | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/drivers/pinctrl/intel/pinctrl-denverton.c b/drivers/pinctrl/intel/pinctrl-denverton.c\n> index 0c4694cfa594..a1a7242e0451 100644\n> --- a/drivers/pinctrl/intel/pinctrl-denverton.c\n> +++ b/drivers/pinctrl/intel/pinctrl-denverton.c\n> @@ -257,6 +257,11 @@ static const struct acpi_device_id dnv_pinctrl_acpi_match[] = {\n> };\n> MODULE_DEVICE_TABLE(acpi, dnv_pinctrl_acpi_match);\n> \n> +static const struct platform_device_id dnv_pinctrl_platform_ids[] = {\n> +\t{ \"denverton-pinctrl\", (kernel_ulong_t)&dnv_soc_data },\n> +\t{ }\n> +};\n> +\n> static struct platform_driver dnv_pinctrl_driver = {\n> \t.probe = intel_pinctrl_probe_by_hid,\n> \t.driver = {\n> @@ -264,6 +269,7 @@ static struct platform_driver dnv_pinctrl_driver = {\n> \t\t.acpi_match_table = dnv_pinctrl_acpi_match,\n> \t\t.pm = &dnv_pinctrl_pm_ops,\n> \t},\n> +\t.id_table = dnv_pinctrl_platform_ids,\n> };\n> \n> static int __init dnv_pinctrl_init(void)\n> @@ -281,4 +287,5 @@ module_exit(dnv_pinctrl_exit);\n> MODULE_AUTHOR(\"Mika Westerberg \");\n> MODULE_DESCRIPTION(\"Intel Denverton SoC pinctrl/GPIO driver\");\n> MODULE_LICENSE(\"GPL v2\");\n> +MODULE_ALIAS(\"platform:denverton-pinctrl\");\n\nWhy do you need the alias? It's the same as ID table. You most likely\nmiss MODULE_DEVICE_TABLE() or your table is just wrong.\n\nBest regards,\nKrzysztof","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=h+1ABKoh;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2620:137:e000::1:20; helo=out1.vger.email;\n envelope-from=linux-gpio-owner@vger.kernel.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20])\n\tby legolas.ozlabs.org (Postfix) with ESMTP id 4S0ncx4pD1z1yng\n\tfor ; Wed, 4 Oct 2023 19:18:09 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S232596AbjJDISL (ORCPT );\n Wed, 4 Oct 2023 04:18:11 -0400","from lindbergh.monkeyblade.net ([23.128.96.19]:54214 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n with ESMTP id S229712AbjJDISK (ORCPT\n ); Wed, 4 Oct 2023 04:18:10 -0400","from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21619A6;\n Wed, 4 Oct 2023 01:18:07 -0700 (PDT)","by smtp.kernel.org (Postfix) with ESMTPSA id D8864C433C7;\n Wed, 4 Oct 2023 08:18:04 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1696407486;\n bh=vQFPg6PA6WrMnXAY1PY7xlQzGKPRe88hSEWvcIqGGLE=;\n h=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n b=h+1ABKoh9sVQArHfErOER+r1zQroHl5optg7U+U/veYLL913BqEdKUPuk1K98ULmR\n Y3OWeV2g3kCfwrdFXzZ/i6zruJLfc2H7S3Q4m8oC7pqym5Ot3sqhI96P5ICGsq/HDv\n jYHBof86l57qaLWNPDia4Ub2MbOpPsZjZQPO4367US1/ArMRr4OXmEZBFZOq5Yr/pT\n NXxZjiOOfHekOeVXT6H5OCR+hF8nI64rYI1IwoiMA/3I1bfjvfiVN/kPJCUJQvXGFA\n r5w9+1otsSGFZMK+bnvFA3kVK9fgGwJKG9It+VQ4coRED44w7iYkQ4CK7mQzng9Y3O\n ZOyWiUYxdH4iw==","Message-ID":"<76d1e643-9b81-4c23-8f46-73fe59913600@kernel.org>","Date":"Wed, 4 Oct 2023 10:18:01 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the\n absence of ACPI enumeration","Content-Language":"en-US","To":"Andy Shevchenko ,\n linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org","Cc":"Mika Westerberg ,\n Andy Shevchenko ,\n Linus Walleij ,\n Takashi Iwai ","References":"<20230926190818.931951-1-andriy.shevchenko@linux.intel.com>","From":"Krzysztof Kozlowski ","Autocrypt":"addr=krzk@kernel.org; keydata=\n xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79\n cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu\n JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH\n gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE\n J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj\n NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS\n BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU\n vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM\n Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD\n TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg\n S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE\n FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307\n QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+\n gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP\n /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy\n iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk\n VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe\n 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe\n xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6\n eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq\n AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ\n MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3\n Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue\n MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei\n OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA\n GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA\n 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9\n YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt\n 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU\n BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/\n JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu\n 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB\n YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0\n Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4\n ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt\n vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS\n oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm\n lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5\n t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD\n uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo\n 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2\n 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0=","In-Reply-To":"<20230926190818.931951-1-andriy.shevchenko@linux.intel.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.6","X-Spam-Checker-Version":"SpamAssassin 3.4.6 (2021-04-09) on\n lindbergh.monkeyblade.net","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":3192786,"web_url":"http://patchwork.ozlabs.org/comment/3192786/","msgid":"","list_archive_url":null,"date":"2023-10-04T13:09:31","subject":"Re: [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the\n absence of ACPI enumeration","submitter":{"id":4675,"url":"http://patchwork.ozlabs.org/api/people/4675/","name":"Andy Shevchenko","email":"andy.shevchenko@gmail.com"},"content":"On Wed, Oct 4, 2023 at 11:18 AM Krzysztof Kozlowski wrote:\n> On 26/09/2023 21:08, Andy Shevchenko wrote:\n\n...\n\n> > +MODULE_ALIAS(\"platform:denverton-pinctrl\");\n>\n> Why do you need the alias? It's the same as ID table. You most likely\n> miss MODULE_DEVICE_TABLE() or your table is just wrong.\n\nThis is cargo cult from pinctrl-broxton.c. If we want to fix, we need\nto fix both.\nCare to send patches?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=Qa11NW/5;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2620:137:e000::1:20; helo=out1.vger.email;\n envelope-from=linux-gpio-owner@vger.kernel.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20])\n\tby legolas.ozlabs.org (Postfix) with ESMTP id 4S0w621YhHz1yph\n\tfor ; Thu, 5 Oct 2023 00:10:18 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S242435AbjJDNKR (ORCPT );\n Wed, 4 Oct 2023 09:10:17 -0400","from lindbergh.monkeyblade.net ([23.128.96.19]:48164 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n with ESMTP id S233003AbjJDNKO (ORCPT\n ); Wed, 4 Oct 2023 09:10:14 -0400","from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com\n [IPv6:2607:f8b0:4864:20::f2e])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5584398;\n Wed, 4 Oct 2023 06:10:09 -0700 (PDT)","by mail-qv1-xf2e.google.com with SMTP id\n 6a1803df08f44-65b0e623189so11624776d6.1;\n Wed, 04 Oct 2023 06:10:09 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1696425008; x=1697029808;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=asdaHQCAKRIWEz9CnctgMv3GKP9kjq8BnTwyAVU+fio=;\n b=Qa11NW/54TOKnk0Jb4tSizHMf7aNNA0o0PuMgZ2qrkYMVKuJSUxnIapluJ2oq58uhc\n eps7VunbTpGy8zazQqGu8fHWFGKo5dxBsN4a0GwPvnJ24tq8lw6pUdohurcvetulHtQC\n 2owF+0tlw6t1X2Fo6rNpCgn3W/Ud70YvAHQhv53J5rMZcWX5sFCSC7bo/EcoA5+/TOnZ\n x9InXb5s1w8wbRuBmqlQ8qZL7tU0QeQssNndNAmW3+BvnvNCDkzW4acsDw/dKO9Bf3zn\n jIMGQ2ZM0TfCzyw8OOL7PTNN3be5kwxZyJM51XTk9J1KOzFyzjJFxqZDpf9qaq4QGhfT\n Lnow==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1696425008; x=1697029808;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=asdaHQCAKRIWEz9CnctgMv3GKP9kjq8BnTwyAVU+fio=;\n b=bK3hLgwq/jZbmmPENs3/Lxka68YOtvrgqmzAl9dcAoJ8sUadx4NZ1n1YrGRQe5ROSP\n PAsz1m9T5dswJPV1VuQnOF965tTyoOdnknCU03u2Rm8RwE2VqbE/sjX7DwTTTnNQ4eJK\n oy4aKu3LIQ/Ph0SeqGL804eQa5sZONMB0AbQRz9KszdL8ohgwL9b4ghsOXSRWZu7QHGd\n PtyMxqtX8tWJiEkcYnvzkashNOoqnrJoBWRyhqKJI+FEyCG7CLOzPHP4wcgm1omfAn/B\n k43wvLf6qeY1mNY6YmCCbAbpUIntT94h2/M4jFwel6Do0Gj5ZHs4qVSh7LsV8dPN2jab\n uQxg==","X-Gm-Message-State":"AOJu0YzpjXuUQJNjtdAYRytE6dT6gtCyROllHOYniJs4GLK0wWGZ2f8p\n rPqKrU27YCYiGVxYjHVHK6d+oy+cuPrp0Dkf87eV6OFciYc=","X-Google-Smtp-Source":"\n AGHT+IFMgcbtnGHOGQEnTV0fNuWMb2syIVJ41wSGPv8NVZe/+CZBISZ9FUJKCjvlImsjAVhn8IdBiSZ3INKYtXwMX78=","X-Received":"by 2002:a05:6214:3381:b0:647:23b8:dac2 with SMTP id\n mv1-20020a056214338100b0064723b8dac2mr2261508qvb.58.1696425008344; Wed, 04\n Oct 2023 06:10:08 -0700 (PDT)","MIME-Version":"1.0","References":"<20230926190818.931951-1-andriy.shevchenko@linux.intel.com>\n <76d1e643-9b81-4c23-8f46-73fe59913600@kernel.org>","In-Reply-To":"<76d1e643-9b81-4c23-8f46-73fe59913600@kernel.org>","From":"Andy Shevchenko ","Date":"Wed, 4 Oct 2023 16:09:31 +0300","Message-ID":"\n ","Subject":"Re: [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the\n absence of ACPI enumeration","To":"Krzysztof Kozlowski ","Cc":"Andy Shevchenko ,\n linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,\n Mika Westerberg ,\n Andy Shevchenko ,\n Linus Walleij ,\n Takashi Iwai ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.6","X-Spam-Checker-Version":"SpamAssassin 3.4.6 (2021-04-09) on\n lindbergh.monkeyblade.net","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":3192799,"web_url":"http://patchwork.ozlabs.org/comment/3192799/","msgid":"","list_archive_url":null,"date":"2023-10-04T13:20:01","subject":"Re: [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the\n absence of ACPI enumeration","submitter":{"id":68952,"url":"http://patchwork.ozlabs.org/api/people/68952/","name":"Krzysztof Kozlowski","email":"krzk@kernel.org"},"content":"On 04/10/2023 15:09, Andy Shevchenko wrote:\n> On Wed, Oct 4, 2023 at 11:18 AM Krzysztof Kozlowski wrote:\n>> On 26/09/2023 21:08, Andy Shevchenko wrote:\n> \n> ...\n> \n>>> +MODULE_ALIAS(\"platform:denverton-pinctrl\");\n>>\n>> Why do you need the alias? It's the same as ID table. You most likely\n>> miss MODULE_DEVICE_TABLE() or your table is just wrong.\n> \n> This is cargo cult from pinctrl-broxton.c. If we want to fix, we need\n> to fix both.\n> Care to send patches?\n\nI don't understand how some other file affects this. Why do you exactly\nneed module alias here? Which use-case does not work without it (after\nadding proper MODULE_DEVICE_TABLE())?\n\nBest regards,\nKrzysztof","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=sMRvkTLz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2620:137:e000::1:20; helo=out1.vger.email;\n envelope-from=linux-gpio-owner@vger.kernel.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20])\n\tby legolas.ozlabs.org (Postfix) with ESMTP id 4S0wKS3J7bz1ypx\n\tfor ; Thu, 5 Oct 2023 00:20:12 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S233105AbjJDNUL (ORCPT );\n Wed, 4 Oct 2023 09:20:11 -0400","from lindbergh.monkeyblade.net ([23.128.96.19]:44474 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n with ESMTP id S242619AbjJDNUL (ORCPT\n ); Wed, 4 Oct 2023 09:20:11 -0400","from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDA9DC6;\n Wed, 4 Oct 2023 06:20:07 -0700 (PDT)","by smtp.kernel.org (Postfix) with ESMTPSA id 3AB9EC433C8;\n Wed, 4 Oct 2023 13:20:05 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1696425607;\n bh=Uc3NOTcxp+jJ5AbMaMdMtkI/XmkjuT7JikGjiL50+KY=;\n h=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n b=sMRvkTLzaMOKie1V5CI3w1UUGAMZRWddWMA8oivj3Rvy+CAjwgeoQZIZs6ma68SsA\n NIVc02N8b+CKTFfintSqdwApeLdsRPPYZdbPNe7WTaHGPJAY5RFOXBzDKHBMv3UOw5\n oNmOnC16HF2BfG8hxcSTPdkw/5h3hxjjplQ7GCUl3bhaWgwqDnJtpp6vP5+wxXjUA4\n q80MdhnBAKpRATVVWfWEuokXHu3523qqyWw6xSVAilYqsDHfm8jN+xvbgzAUIqodoj\n uWbQTsp3tJRb2BbEl26HimZC5FinU3y9t6OgaiMVauv6/TXpE30ROmnanQasZesWl6\n sXnM5l1QzKViA==","Message-ID":"","Date":"Wed, 4 Oct 2023 15:20:01 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the\n absence of ACPI enumeration","Content-Language":"en-US","To":"Andy Shevchenko ","Cc":"Andy Shevchenko ,\n linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,\n Mika Westerberg ,\n Andy Shevchenko ,\n Linus Walleij ,\n Takashi Iwai ","References":"<20230926190818.931951-1-andriy.shevchenko@linux.intel.com>\n <76d1e643-9b81-4c23-8f46-73fe59913600@kernel.org>\n ","From":"Krzysztof Kozlowski ","Autocrypt":"addr=krzk@kernel.org; keydata=\n xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79\n cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu\n JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH\n gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE\n J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj\n NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS\n BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU\n vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM\n Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD\n TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg\n S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE\n FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307\n QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+\n gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP\n /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy\n iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk\n VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe\n 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe\n xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6\n eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq\n AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ\n MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3\n Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue\n MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei\n OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA\n GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA\n 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9\n YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt\n 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU\n BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/\n JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu\n 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB\n YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0\n Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4\n ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt\n vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS\n oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm\n lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5\n t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD\n uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo\n 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2\n 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0=","In-Reply-To":"\n ","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.6","X-Spam-Checker-Version":"SpamAssassin 3.4.6 (2021-04-09) on\n lindbergh.monkeyblade.net","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":3193214,"web_url":"http://patchwork.ozlabs.org/comment/3193214/","msgid":"","list_archive_url":null,"date":"2023-10-04T19:42:08","subject":"Re: [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the\n absence of ACPI enumeration","submitter":{"id":4675,"url":"http://patchwork.ozlabs.org/api/people/4675/","name":"Andy Shevchenko","email":"andy.shevchenko@gmail.com"},"content":"On Wed, Oct 4, 2023 at 4:20 PM Krzysztof Kozlowski wrote:\n> On 04/10/2023 15:09, Andy Shevchenko wrote:\n> > On Wed, Oct 4, 2023 at 11:18 AM Krzysztof Kozlowski wrote:\n> >> On 26/09/2023 21:08, Andy Shevchenko wrote:\n\n...\n\n> >>> +MODULE_ALIAS(\"platform:denverton-pinctrl\");\n> >>\n> >> Why do you need the alias? It's the same as ID table. You most likely\n> >> miss MODULE_DEVICE_TABLE() or your table is just wrong.\n> >\n> > This is cargo cult from pinctrl-broxton.c. If we want to fix, we need\n> > to fix both.\n> > Care to send patches?\n>\n> I don't understand how some other file affects this. Why do you exactly\n> need module alias here? Which use-case does not work without it (after\n> adding proper MODULE_DEVICE_TABLE())?\n\nWe try to keep these drivers uniform. So, if something should be done\ndifferently, it should be done for all affected drivers.\nSince patch is applied, now we have two drivers to improve.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=dGYWCUvN;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2620:137:e000::1:20; helo=out1.vger.email;\n envelope-from=linux-gpio-owner@vger.kernel.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20])\n\tby legolas.ozlabs.org (Postfix) with ESMTP id 4S14pz45f6z1yqD\n\tfor ; Thu, 5 Oct 2023 06:42:51 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S233552AbjJDTmu (ORCPT );\n Wed, 4 Oct 2023 15:42:50 -0400","from lindbergh.monkeyblade.net ([23.128.96.19]:57494 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n with ESMTP id S243845AbjJDTmt (ORCPT\n ); Wed, 4 Oct 2023 15:42:49 -0400","from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com\n [IPv6:2607:f8b0:4864:20::72a])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49B54A9;\n Wed, 4 Oct 2023 12:42:46 -0700 (PDT)","by mail-qk1-x72a.google.com with SMTP id\n af79cd13be357-7741c2fae49so13041285a.0;\n Wed, 04 Oct 2023 12:42:46 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1696448565; x=1697053365;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=VNEUrx2f0EOsYSNLwljjtMrsuJmbZYcwoRJZYPUoB3Y=;\n b=dGYWCUvNp/T8+HspqGVG2u1DZEYcsHJ6xn0hkJDUL4IM8UtFA1tm9PQVNEqP0mEfk3\n KgY9foXPEUGUDvQBTBee/TS0mlUiBxicEtqaB00ex1jQci0P1S2x9Vtkegm4gHXlHGy7\n w1U0vlQxcV5hv7DHZGjQ4SUSdhGb6uzWaggdXJEFIrd7yHEuukD2DmOZDzr2sspBR1bn\n 0kSDC9cnj3rxxAuZFO1wqTxQW3PBNSQLKTI8iNmE7X5J48pmfj6uonrkMgYr7UVghGhy\n 6oxwqckiQMiFnLgh4clASzjHM1d9c/lDzndLZuW127gnY7ha8skaJR0W/nWAH3T9KVAv\n 2BDw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1696448565; x=1697053365;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=VNEUrx2f0EOsYSNLwljjtMrsuJmbZYcwoRJZYPUoB3Y=;\n b=p12KmS8D1GS0CSiDcBuaJQWbhAfr5VOqNidVB0oLh/tTnNZCBet0KrNtjnjZTrHA0S\n QlQnyl1kEtdoWj8vSb55VmPaCnjWRIwIHBeMMSspbwFQS8+T/XfTztMMrTPZgKyDUrgf\n sluAmM/ikT60tsImARELPRWMuUA0JV9wSYWTSma6it7H+uupJHs94vOcmCuwchrx8cln\n xtOm0zkDXGHp57tov2ql3o/coZsQv/PnhN1FlAc3WmGOqCP3FrfI33FgKCO47vTFSkp+\n IAUUR5p50gBWuajhZqY8e2/VHVNdv6lj3ofSF1MMLCxUZaxClI1EnwCxcUgoikVo8NCL\n 5/Kw==","X-Gm-Message-State":"AOJu0Yxt5zbpZt0CvU7BvP7D/ltwV7353WxHhYU+QouxJFTb/3wio0CR\n zPwAyD04tir4Bxew/oDr2gSWF5y7OL620U4pMdQ6rWO9PXo=","X-Google-Smtp-Source":"\n AGHT+IHzq0mBsVSOM/oReFyc7rW719H1KDBi3mMkvT3/axT9y1WEUjEQ4JUkJ//VnSO1fK16h3VjChV+UUtPths+0ok=","X-Received":"by 2002:a0c:aa08:0:b0:658:2037:718c with SMTP id\n d8-20020a0caa08000000b006582037718cmr2796522qvb.40.1696448565340; Wed, 04 Oct\n 2023 12:42:45 -0700 (PDT)","MIME-Version":"1.0","References":"<20230926190818.931951-1-andriy.shevchenko@linux.intel.com>\n <76d1e643-9b81-4c23-8f46-73fe59913600@kernel.org>\n \n ","In-Reply-To":"","From":"Andy Shevchenko ","Date":"Wed, 4 Oct 2023 22:42:08 +0300","Message-ID":"\n ","Subject":"Re: [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the\n absence of ACPI enumeration","To":"Krzysztof Kozlowski ","Cc":"Andy Shevchenko ,\n linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,\n Mika Westerberg ,\n Andy Shevchenko ,\n Linus Walleij ,\n Takashi Iwai ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.6","X-Spam-Checker-Version":"SpamAssassin 3.4.6 (2021-04-09) on\n lindbergh.monkeyblade.net","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":3193683,"web_url":"http://patchwork.ozlabs.org/comment/3193683/","msgid":"","list_archive_url":null,"date":"2023-10-05T08:42:34","subject":"Re: [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the\n absence of ACPI enumeration","submitter":{"id":4675,"url":"http://patchwork.ozlabs.org/api/people/4675/","name":"Andy Shevchenko","email":"andy.shevchenko@gmail.com"},"content":"On Thu, Oct 05, 2023 at 11:38:38AM +0300, Andy Shevchenko wrote:\n> On Thu, Oct 05, 2023 at 09:53:51AM +0200, Krzysztof Kozlowski wrote:\n> > On 04/10/2023 21:42, Andy Shevchenko wrote:\n> > > On Wed, Oct 4, 2023 at 4:20 PM Krzysztof Kozlowski wrote:\n> > >> On 04/10/2023 15:09, Andy Shevchenko wrote:\n> > >>> On Wed, Oct 4, 2023 at 11:18 AM Krzysztof Kozlowski wrote:\n> > >>>> On 26/09/2023 21:08, Andy Shevchenko wrote:\n\n...\n\n> > >>>>> +MODULE_ALIAS(\"platform:denverton-pinctrl\");\n> > >>>>\n> > >>>> Why do you need the alias? It's the same as ID table. You most likely\n> > >>>> miss MODULE_DEVICE_TABLE() or your table is just wrong.\n> > >>>\n> > >>> This is cargo cult from pinctrl-broxton.c. If we want to fix, we need\n> > >>> to fix both.\n> > >>> Care to send patches?\n> > >>\n> > >> I don't understand how some other file affects this. Why do you exactly\n> > >> need module alias here? Which use-case does not work without it (after\n> > >> adding proper MODULE_DEVICE_TABLE())?\n> > > \n> > > We try to keep these drivers uniform. So, if something should be done\n> > > differently, it should be done for all affected drivers.\n> > > Since patch is applied, now we have two drivers to improve.\n> > \n> > Awesome reason. So if you add accidentally bug to one driver, it should\n> > be copied to other file as well.\n> \n> I'm not sure where it's a bug, it works. The problem is implementation\n> and I believe Mika and certainly me agree with your points that\n> MODULE_DEVICE_TABLE() is a right way to go.\n\nThe initial implementation was done by 0c3013bbe1d8 (\"pinctrl/broxton:\nenable platform device in the absence of ACPI enumeration\"). It was\nACKed by the driver maintainer as this one. But again, we agree that\nyour way is better.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2620:137:e000::1:20; helo=out1.vger.email;\n envelope-from=linux-gpio-owner@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","Received":["from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20])\n\tby legolas.ozlabs.org (Postfix) with ESMTP id 4S1ZCC4tJPz1yng\n\tfor ; Fri, 6 Oct 2023 01:47:03 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S238717AbjJEOqa (ORCPT );\n Thu, 5 Oct 2023 10:46:30 -0400","from lindbergh.monkeyblade.net ([23.128.96.19]:53050 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n with ESMTP id S231547AbjJEOoJ (ORCPT\n ); Thu, 5 Oct 2023 10:44:09 -0400","from mgamail.intel.com (mgamail.intel.com [192.55.52.151])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5CE313B70;\n Thu, 5 Oct 2023 07:21:41 -0700 (PDT)","from orsmga003.jf.intel.com ([10.7.209.27])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 05 Oct 2023 01:42:39 -0700","from smile.fi.intel.com ([10.237.72.54])\n by orsmga003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 05 Oct 2023 01:42:37 -0700","from andy by smile.fi.intel.com with local (Exim 4.97-RC1)\n (envelope-from )\n id 1qoJwI-00000002yg3-2o0k;\n Thu, 05 Oct 2023 11:42:34 +0300"],"X-IronPort-AV":["E=McAfee;i=\"6600,9927,10853\"; a=\"363727183\"","E=Sophos;i=\"6.03,202,1694761200\";\n d=\"scan'208\";a=\"363727183\"","E=McAfee;i=\"6600,9927,10853\"; a=\"701588130\"","E=Sophos;i=\"6.03,202,1694761200\";\n d=\"scan'208\";a=\"701588130\""],"X-ExtLoop1":"1","Date":"Thu, 5 Oct 2023 11:42:34 +0300","From":"Andy Shevchenko ","To":"Krzysztof Kozlowski ","Cc":"linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,\n Mika Westerberg ,\n Linus Walleij ,\n Takashi Iwai ","Subject":"Re: [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the\n absence of ACPI enumeration","Message-ID":"","References":"<20230926190818.931951-1-andriy.shevchenko@linux.intel.com>\n <76d1e643-9b81-4c23-8f46-73fe59913600@kernel.org>\n \n \n \n \n ","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","Organization":"Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo","X-Spam-Status":"No, score=0.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED,\n FORGED_GMAIL_RCVD,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_SOFTFAIL autolearn=no\n autolearn_force=no version=3.4.6","X-Spam-Checker-Version":"SpamAssassin 3.4.6 (2021-04-09) on\n lindbergh.monkeyblade.net","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":3193754,"web_url":"http://patchwork.ozlabs.org/comment/3193754/","msgid":"","list_archive_url":null,"date":"2023-10-05T07:53:51","subject":"Re: [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the\n absence of ACPI enumeration","submitter":{"id":68952,"url":"http://patchwork.ozlabs.org/api/people/68952/","name":"Krzysztof Kozlowski","email":"krzk@kernel.org"},"content":"On 04/10/2023 21:42, Andy Shevchenko wrote:\n> On Wed, Oct 4, 2023 at 4:20 PM Krzysztof Kozlowski wrote:\n>> On 04/10/2023 15:09, Andy Shevchenko wrote:\n>>> On Wed, Oct 4, 2023 at 11:18 AM Krzysztof Kozlowski wrote:\n>>>> On 26/09/2023 21:08, Andy Shevchenko wrote:\n> \n> ...\n> \n>>>>> +MODULE_ALIAS(\"platform:denverton-pinctrl\");\n>>>>\n>>>> Why do you need the alias? It's the same as ID table. You most likely\n>>>> miss MODULE_DEVICE_TABLE() or your table is just wrong.\n>>>\n>>> This is cargo cult from pinctrl-broxton.c. If we want to fix, we need\n>>> to fix both.\n>>> Care to send patches?\n>>\n>> I don't understand how some other file affects this. Why do you exactly\n>> need module alias here? Which use-case does not work without it (after\n>> adding proper MODULE_DEVICE_TABLE())?\n> \n> We try to keep these drivers uniform. So, if something should be done\n> differently, it should be done for all affected drivers.\n> Since patch is applied, now we have two drivers to improve.\n\nAwesome reason. So if you add accidentally bug to one driver, it should\nbe copied to other file as well.\n\nBest regards,\nKrzysztof","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=QPd8bb/0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2620:137:e000::1:20; helo=out1.vger.email;\n envelope-from=linux-gpio-owner@vger.kernel.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20])\n\tby legolas.ozlabs.org (Postfix) with ESMTP id 4S1bnf4vcFz26jG\n\tfor ; Fri, 6 Oct 2023 02:58:30 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S234417AbjJEP6F (ORCPT );\n Thu, 5 Oct 2023 11:58:05 -0400","from lindbergh.monkeyblade.net ([23.128.96.19]:54490 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n with ESMTP id S234400AbjJEP4p (ORCPT\n ); Thu, 5 Oct 2023 11:56:45 -0400","from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BBE84ED3;\n Thu, 5 Oct 2023 06:52:31 -0700 (PDT)","by smtp.kernel.org (Postfix) with ESMTPSA id 5458CC43215;\n Thu, 5 Oct 2023 07:53:55 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1696492437;\n bh=QhTldfirf/+ut5QB+NUg+CvkpthitsP2LHqj5WMFcwk=;\n h=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n b=QPd8bb/05eAE1zpz+B7Kscn56nWYbS5BdYeRCItpuCOJnciQaKAoxbQ3yX0ZYz9X/\n 5F639Jil7K/92Em8WOdLBF5MmrPO+E8RVOd6RgiRscfMNX1WOhK5lvup0aLsdY1ja8\n a9y7WliPeYtlD5K0aLwulJM/RnQMBW6ckFJgRM4fy8NoWhZJZFYdFhvc3J523f8vqP\n YgS9wUhM66S0oWLH4Uw1dN/JOBoVywHf13YrJ327G0W7EB5klzFbFGBRltzIQNd89g\n SY/mjWA/EfFNQBkY+JrkzUv6YLuqsfk85A/WyTmSkBYky9CumWgr7sM62A8BIaigrI\n ZXneGe2JKgsLg==","Message-ID":"","Date":"Thu, 5 Oct 2023 09:53:51 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the\n absence of ACPI enumeration","Content-Language":"en-US","To":"Andy Shevchenko ","Cc":"Andy Shevchenko ,\n linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,\n Mika Westerberg ,\n Andy Shevchenko ,\n Linus Walleij ,\n Takashi Iwai ","References":"<20230926190818.931951-1-andriy.shevchenko@linux.intel.com>\n <76d1e643-9b81-4c23-8f46-73fe59913600@kernel.org>\n \n \n ","From":"Krzysztof Kozlowski ","Autocrypt":"addr=krzk@kernel.org; keydata=\n xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79\n cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu\n JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH\n gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE\n J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj\n NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS\n BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU\n vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM\n Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD\n TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg\n S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE\n FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307\n QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+\n gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP\n /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy\n iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk\n VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe\n 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe\n xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6\n eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq\n AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ\n MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3\n Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue\n MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei\n OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA\n GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA\n 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9\n YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt\n 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU\n BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/\n JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu\n 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB\n YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0\n Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4\n ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt\n vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS\n oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm\n lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5\n t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD\n uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo\n 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2\n 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0=","In-Reply-To":"\n ","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6","X-Spam-Checker-Version":"SpamAssassin 3.4.6 (2021-04-09) on\n lindbergh.monkeyblade.net","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":3193767,"web_url":"http://patchwork.ozlabs.org/comment/3193767/","msgid":"","list_archive_url":null,"date":"2023-10-05T08:38:37","subject":"Re: [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the\n absence of ACPI enumeration","submitter":{"id":4675,"url":"http://patchwork.ozlabs.org/api/people/4675/","name":"Andy Shevchenko","email":"andy.shevchenko@gmail.com"},"content":"On Thu, Oct 05, 2023 at 09:53:51AM +0200, Krzysztof Kozlowski wrote:\n> On 04/10/2023 21:42, Andy Shevchenko wrote:\n> > On Wed, Oct 4, 2023 at 4:20 PM Krzysztof Kozlowski wrote:\n> >> On 04/10/2023 15:09, Andy Shevchenko wrote:\n> >>> On Wed, Oct 4, 2023 at 11:18 AM Krzysztof Kozlowski wrote:\n> >>>> On 26/09/2023 21:08, Andy Shevchenko wrote:\n\n...\n\n> >>>>> +MODULE_ALIAS(\"platform:denverton-pinctrl\");\n> >>>>\n> >>>> Why do you need the alias? It's the same as ID table. You most likely\n> >>>> miss MODULE_DEVICE_TABLE() or your table is just wrong.\n> >>>\n> >>> This is cargo cult from pinctrl-broxton.c. If we want to fix, we need\n> >>> to fix both.\n> >>> Care to send patches?\n> >>\n> >> I don't understand how some other file affects this. Why do you exactly\n> >> need module alias here? Which use-case does not work without it (after\n> >> adding proper MODULE_DEVICE_TABLE())?\n> > \n> > We try to keep these drivers uniform. So, if something should be done\n> > differently, it should be done for all affected drivers.\n> > Since patch is applied, now we have two drivers to improve.\n> \n> Awesome reason. So if you add accidentally bug to one driver, it should\n> be copied to other file as well.\n\nI'm not sure where it's a bug, it works. The problem is implementation\nand I believe Mika and certainly me agree with your points that\nMODULE_DEVICE_TABLE() is a right way to go.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2620:137:e000::1:20; helo=out1.vger.email;\n envelope-from=linux-gpio-owner@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","Received":["from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20])\n\tby legolas.ozlabs.org (Postfix) with ESMTP id 4S1byM6T5mz1yq9\n\tfor ; Fri, 6 Oct 2023 03:06:03 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S237596AbjJEQFa (ORCPT );\n Thu, 5 Oct 2023 12:05:30 -0400","from lindbergh.monkeyblade.net ([23.128.96.19]:38792 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n with ESMTP id S237610AbjJEQEJ (ORCPT\n ); Thu, 5 Oct 2023 12:04:09 -0400","from mgamail.intel.com (mgamail.intel.com [134.134.136.100])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25D49B3D1E;\n Thu, 5 Oct 2023 07:28:42 -0700 (PDT)","from fmsmga003.fm.intel.com ([10.253.24.29])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 05 Oct 2023 01:38:43 -0700","from smile.fi.intel.com ([10.237.72.54])\n by FMSMGA003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 05 Oct 2023 01:38:41 -0700","from andy by smile.fi.intel.com with local (Exim 4.97-RC1)\n (envelope-from )\n id 1qoJsU-00000002ydG-0uwr;\n Thu, 05 Oct 2023 11:38:38 +0300"],"X-IronPort-AV":["E=McAfee;i=\"6600,9927,10853\"; a=\"449939152\"","E=Sophos;i=\"6.03,202,1694761200\";\n d=\"scan'208\";a=\"449939152\"","E=McAfee;i=\"6600,9927,10853\"; a=\"842305045\"","E=Sophos;i=\"6.03,202,1694761200\";\n d=\"scan'208\";a=\"842305045\""],"X-ExtLoop1":"1","Date":"Thu, 5 Oct 2023 11:38:37 +0300","From":"Andy Shevchenko ","To":"Krzysztof Kozlowski ","Cc":"linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,\n Mika Westerberg ,\n Linus Walleij ,\n Takashi Iwai ","Subject":"Re: [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the\n absence of ACPI enumeration","Message-ID":"","References":"<20230926190818.931951-1-andriy.shevchenko@linux.intel.com>\n <76d1e643-9b81-4c23-8f46-73fe59913600@kernel.org>\n \n \n \n ","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","Organization":"Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo","X-Spam-Status":"No,\n score=-1.6 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED,\n FORGED_GMAIL_RCVD,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED,RCVD_IN_DNSWL_MED,\n SPF_HELO_NONE,SPF_SOFTFAIL autolearn=no autolearn_force=no\n version=3.4.6","X-Spam-Checker-Version":"SpamAssassin 3.4.6 (2021-04-09) on\n lindbergh.monkeyblade.net","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}}]