[{"id":2936548,"web_url":"http://patchwork.ozlabs.org/comment/2936548/","msgid":"<726a5056-789a-b445-a2c6-879008ad270a@redhat.com>","list_archive_url":null,"date":"2022-07-21T09:25:59","subject":"Re: [PATCH v12 38/40] virtio_net: support rx queue resize","submitter":{"id":5225,"url":"http://patchwork.ozlabs.org/api/people/5225/","name":"Jason Wang","email":"jasowang@redhat.com"},"content":"在 2022/7/20 11:04, Xuan Zhuo 写道:\n> This patch implements the resize function of the rx queues.\n> Based on this function, it is possible to modify the ring num of the\n> queue.\n>\n> Signed-off-by: Xuan Zhuo \n> ---\n> drivers/net/virtio_net.c | 22 ++++++++++++++++++++++\n> 1 file changed, 22 insertions(+)\n>\n> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c\n> index fe4dc43c05a1..1115a8b59a08 100644\n> --- a/drivers/net/virtio_net.c\n> +++ b/drivers/net/virtio_net.c\n> @@ -278,6 +278,8 @@ struct padded_vnet_hdr {\n> \tchar padding[12];\n> };\n> \n> +static void virtnet_rq_free_unused_buf(struct virtqueue *vq, void *buf);\n> +\n> static bool is_xdp_frame(void *ptr)\n> {\n> \treturn (unsigned long)ptr & VIRTIO_XDP_FLAG;\n> @@ -1846,6 +1848,26 @@ static netdev_tx_t start_xmit(struct sk_buff *skb, struct net_device *dev)\n> \treturn NETDEV_TX_OK;\n> }\n> \n> +static int virtnet_rx_resize(struct virtnet_info *vi,\n> +\t\t\t struct receive_queue *rq, u32 ring_num)\n> +{\n> +\tint err, qindex;\n> +\n> +\tqindex = rq - vi->rq;\n> +\n> +\tnapi_disable(&rq->napi);\n\n\nWe need to disable refill work as well. So this series might need \nrebasing on top of\n\nhttps://lore.kernel.org/netdev/20220704074859.16912-1-jasowang@redhat.com/\n\nI will send a new version (probably tomorrow).\n\nThanks\n\n\n> +\n> +\terr = virtqueue_resize(rq->vq, ring_num, virtnet_rq_free_unused_buf);\n> +\tif (err)\n> +\t\tnetdev_err(vi->dev, \"resize rx fail: rx queue index: %d err: %d\\n\", qindex, err);\n> +\n> +\tif (!try_fill_recv(vi, rq, GFP_KERNEL))\n> +\t\tschedule_delayed_work(&vi->refill, 0);\n> +\n> +\tvirtnet_napi_enable(rq->vq, &rq->napi);\n> +\treturn err;\n> +}\n> +\n> /*\n> * Send command via the control virtqueue and check status. Commands\n> * supported by the hypervisor, as indicated by feature bits, should","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=uHu+cOnQ;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=bb7fqamy;\n\tdkim-atps=neutral","ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=)","relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4LpRyy241Nz9s09\n\tfor ; Thu, 21 Jul 2022 19:26:34 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oESRs-003Gge-Lo; Thu, 21 Jul 2022 09:26:24 +0000","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n\tby bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oESRp-003GcU-L6\n\tfor linux-um@lists.infradead.org; Thu, 21 Jul 2022 09:26:23 +0000","from mail-pg1-f200.google.com (mail-pg1-f200.google.com\n [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-607-20gCxiE9OI2iWw6DKFX48A-1; Thu, 21 Jul 2022 05:26:19 -0400","by mail-pg1-f200.google.com with SMTP id\n bd7-20020a656e07000000b00412a946da8eso667346pgb.20\n for ;\n Thu, 21 Jul 2022 02:26:19 -0700 (PDT)","from [10.72.12.47] ([209.132.188.80])\n by smtp.gmail.com with ESMTPSA id\n l28-20020a635b5c000000b0041a411823d4sm1036080pgm.22.2022.07.21.02.26.04\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 21 Jul 2022 02:26:17 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject:\n\tMIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=TJpw0gCdat/MwiEfmQNrzuZv5Ql2bYKgYNJi5oIRdmM=; b=uHu+cOnQYHeUfK\n\tLl/M93Cu3mC5HxvBS8BLfjxBqLG41Hia/n9yqOryMAy0rOJSIQfqdbSngN4CI53TJw391ZECu3r8/\n\tMEG2RyUMb27C7gXDe5CmdslDc47XAUPzdOT9gN8kThko+y3wgl+hT7F81tRDegHZTDvfKWuuQz+Fx\n\tQK63QlRDL2V44i7IUyj4IO4j3Xq9ked2+nddv+AwQc1jWwHjIMHgR37cgzHcHmFcdiDTqjy+AA8MU\n\t5bIOn11ypvBss8J2cOhT2Im0otXp8jShlKQbsmM0dcwH+wHJmZphad235OC3pn1EVJf4N5i7zvTMh\n\ttcaaFX2DDXG0pIr0Y+6Q==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1658395580;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=pxqVBZnZmkgOHYwiYGXPDu4uhyKliCc2cAcObS0C01w=;\n\tb=bb7fqamyHS9GFmq8uDAqWQwb3iJWNvxV9yoq01Smrxkx/x6QUiQDKZ7fHM9p+QCb82ouby\n\t9KFPRl6THFvmGU9gCQ2KedVChMpYy2Nu4mIVAfHqY9nBG1GCKzmM7QJ0CYeqFF12jIs6xj\n\tefsJ5tdAHnrnH7/6H1vKQ1QijtDM84k="],"X-MC-Unique":"20gCxiE9OI2iWw6DKFX48A-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:message-id:date:mime-version:user-agent:subject\n :content-language:to:cc:references:from:in-reply-to\n :content-transfer-encoding;\n bh=pxqVBZnZmkgOHYwiYGXPDu4uhyKliCc2cAcObS0C01w=;\n b=rHiAWRDEcSwD9c5e0LeSubYmvUnqsFWHsQEow6MsC1dsZ3Al/ZdRFe+0vZHxCc6oqY\n GfhciWNG+w8B+JLiozYDehN9oGsUScKJ0n/VNYmiLwPOBcBDEwce3AxePzmlInTZHV1x\n I5KPOFujQGyZLXcro/hOEnps3cZwt+/ZD6pqASPp3DJYGYPDWioNr+fheYwJZXm3iETe\n S20x7a5Y3vbfv6fuOAbFDLg28s+KpS3XfQG6X7pb0pytFF8HqYeCGGdbQ7Bbw3EbBVxn\n d8thxW53bZUwwRmtRm5FjuTxY5NV1EymbpbUPaK2g/c8Q1BekmT77xlX+VbFCXsMMzPS\n EOvQ==","X-Gm-Message-State":"AJIora9C/x/ag30/xbgWfBrpgGeIm4c0YMXgxEtezh7zCkOFvh0krjKP\n\tUObDPVxC3oCVDKn4b7J2q9BIk1iLtbHD19darRaxpMqkJrHKclONizU8gaqjFwXGERAlV6aXDjF\n\tl9PLnStgHOiM3gySX2pPd3bVY","X-Received":["by 2002:a17:90a:f481:b0:1f2:43c:a61 with SMTP id\n bx1-20020a17090af48100b001f2043c0a61mr10625063pjb.134.1658395578169;\n Thu, 21 Jul 2022 02:26:18 -0700 (PDT)","by 2002:a17:90a:f481:b0:1f2:43c:a61 with SMTP id\n bx1-20020a17090af48100b001f2043c0a61mr10625043pjb.134.1658395577872;\n Thu, 21 Jul 2022 02:26:17 -0700 (PDT)"],"X-Google-Smtp-Source":"\n AGRyM1sVEm7Oz/22bKmKW2lh3GmJtdU5mssFIrGu+0Tisk4DP+fMNvbSDHGVBHUYgonKpLqTeG+uag==","Message-ID":"<726a5056-789a-b445-a2c6-879008ad270a@redhat.com>","Date":"Thu, 21 Jul 2022 17:25:59 +0800","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)\n Gecko/20100101 Thunderbird/91.11.0","Subject":"Re: [PATCH v12 38/40] virtio_net: support rx queue resize","To":"Xuan Zhuo ,\n virtualization@lists.linux-foundation.org","Cc":"Richard Weinberger ,\n Anton Ivanov ,\n Johannes Berg ,\n \"Michael S. Tsirkin\" , \"David S. Miller\"\n , Eric Dumazet ,\n Jakub Kicinski , Paolo Abeni ,\n Hans de Goede , Mark Gross ,\n Vadim Pasternak ,\n Bjorn Andersson ,\n Mathieu Poirier ,\n Cornelia Huck , Halil Pasic ,\n Eric Farman , Heiko Carstens ,\n Vasily Gorbik , Alexander Gordeev\n , Christian Borntraeger ,\n Sven Schnelle , Alexei Starovoitov ,\n Daniel Borkmann ,\n Jesper Dangaard Brouer ,\n John Fastabend ,\n Vincent Whitchurch ,\n linux-um@lists.infradead.org, netdev@vger.kernel.org,\n platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org,\n linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org,\n kangjie.xu@linux.alibaba.com","References":"<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>\n <20220720030436.79520-39-xuanzhuo@linux.alibaba.com>","From":"Jason Wang ","In-Reply-To":"<20220720030436.79520-39-xuanzhuo@linux.alibaba.com>","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20220721_022621_783231_B0C1C413 ","X-CRM114-Status":"GOOD ( 18.76 )","X-Spam-Score":"-1.6 (-)","X-Spam-Report":"=?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?=\n\t=?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?=\n\t=?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?=\n\t=?unknown-8bit?q?ginal?=\n\t=?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?=\n\t=?unknown-8bit?q?bel?=\n\t=?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?=\n\t=?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?b?IENvbnRlbnQgcHJldmlldzogIOWcqCAyMDIyLzcvMjAgMTE6MDQsIFh1?=\n\t=?unknown-8bit?b?YW4gWmh1byDlhpnpgZM6ID4gVGhpcyBwYXRjaCBpbXBsZW1lbnRz?=\n\t=?unknown-8bit?q?_the_resize_function_of_the_rx_queues=2E_=3E_Based_on_this_?=\n\t=?unknown-8bit?q?function=2C_it_is_possible?=\n\t=?unknown-8bit?q?_to_modify_the_ring_num_of_the_=3E_queue=2E_=3E_=3E_Signed-?=\n\t=?unknown-8bit?q?off-by=3A_=5B=2E=2E=2E=5D_?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_Content_analysis_details=3A___=28-1=2E6_points=2C_5=2E0_re?=\n\t=?unknown-8bit?q?quired=29?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_pts_rule_name______________description?=\n\t=?unknown-8bit?q?_----_----------------------_------------------------------?=\n\t=?unknown-8bit?q?--------------------?=\n\t=?unknown-8bit?q?_-0=2E7_RCVD=5FIN=5FDNSWL=5FLOW______RBL=3A_Sender_listed_a?=\n\t=?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C?=\n\t=?unknown-8bit?q?_low_trust?=\n\t=?unknown-8bit?q?_=5B170=2E10=2E129=2E124_listed_in_list=2Ednswl=2Eorg=5D?=\n\t=?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?=\n\t=?unknown-8bit?q?ish_an_SPF_Record?=\n\t=?unknown-8bit?q?_0=2E0_SPF=5FNONE_______________SPF=3A_sender_does_not_publ?=\n\t=?unknown-8bit?q?ish_an_SPF_Record?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FAU__________Message_has_a_valid_DKIM?=\n\t=?unknown-8bit?q?_or_DK_signature_from?=\n\t=?unknown-8bit?q?_author=27s_domain?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?=\n\t=?unknown-8bit?q?alid_DKIM_or_DK_signature?=\n\t=?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?=\n\t=?unknown-8bit?q?gnature=2C_not_necessarily?=\n\t=?unknown-8bit?q?_valid?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FEF__________Message_has_a_valid_DKIM?=\n\t=?unknown-8bit?q?_or_DK_signature_from?=\n\t=?unknown-8bit?q?_envelope-from_domain?=\n\t=?unknown-8bit?q?_-0=2E5_NICE=5FREPLY=5FA___________Looks_like_a_legit_reply?=\n\t=?unknown-8bit?q?_=28A=29?=\n\t=?unknown-8bit?q?_-0=2E2_DKIMWL=5FWL=5FHIGH_________DKIMwl=2Eorg_-_High_trus?=\n\t=?unknown-8bit?q?t_sender?=","X-BeenThere":"linux-um@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Sender":"\"linux-um\" ","Errors-To":"linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":2938215,"web_url":"http://patchwork.ozlabs.org/comment/2938215/","msgid":"<1658731116.1695666-1-xuanzhuo@linux.alibaba.com>","list_archive_url":null,"date":"2022-07-25T06:38:36","subject":"Re: [PATCH v12 38/40] virtio_net: support rx queue resize","submitter":{"id":80519,"url":"http://patchwork.ozlabs.org/api/people/80519/","name":"Xuan Zhuo","email":"xuanzhuo@linux.alibaba.com"},"content":"On Thu, 21 Jul 2022 17:25:59 +0800, Jason Wang wrote:\n>\n> 在 2022/7/20 11:04, Xuan Zhuo 写道:\n> > This patch implements the resize function of the rx queues.\n> > Based on this function, it is possible to modify the ring num of the\n> > queue.\n> >\n> > Signed-off-by: Xuan Zhuo \n> > ---\n> > drivers/net/virtio_net.c | 22 ++++++++++++++++++++++\n> > 1 file changed, 22 insertions(+)\n> >\n> > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c\n> > index fe4dc43c05a1..1115a8b59a08 100644\n> > --- a/drivers/net/virtio_net.c\n> > +++ b/drivers/net/virtio_net.c\n> > @@ -278,6 +278,8 @@ struct padded_vnet_hdr {\n> > \tchar padding[12];\n> > };\n> >\n> > +static void virtnet_rq_free_unused_buf(struct virtqueue *vq, void *buf);\n> > +\n> > static bool is_xdp_frame(void *ptr)\n> > {\n> > \treturn (unsigned long)ptr & VIRTIO_XDP_FLAG;\n> > @@ -1846,6 +1848,26 @@ static netdev_tx_t start_xmit(struct sk_buff *skb, struct net_device *dev)\n> > \treturn NETDEV_TX_OK;\n> > }\n> >\n> > +static int virtnet_rx_resize(struct virtnet_info *vi,\n> > +\t\t\t struct receive_queue *rq, u32 ring_num)\n> > +{\n> > +\tint err, qindex;\n> > +\n> > +\tqindex = rq - vi->rq;\n> > +\n> > +\tnapi_disable(&rq->napi);\n>\n>\n> We need to disable refill work as well. So this series might need\n> rebasing on top of\n>\n> https://lore.kernel.org/netdev/20220704074859.16912-1-jasowang@redhat.com/\n\nI understand that your patch is used to solve the situation where dev is\ndestoryed but refill work is running.\n\nAnd is there such a possibility here? Or is there any other scenario that I'm\nnot expecting?\n\nThanks.\n\n\n>\n> I will send a new version (probably tomorrow).\n>\n> Thanks\n>\n>\n> > +\n> > +\terr = virtqueue_resize(rq->vq, ring_num, virtnet_rq_free_unused_buf);\n> > +\tif (err)\n> > +\t\tnetdev_err(vi->dev, \"resize rx fail: rx queue index: %d err: %d\\n\", qindex, err);\n> > +\n> > +\tif (!try_fill_recv(vi, rq, GFP_KERNEL))\n> > +\t\tschedule_delayed_work(&vi->refill, 0);\n> > +\n> > +\tvirtnet_napi_enable(rq->vq, &rq->napi);\n> > +\treturn err;\n> > +}\n> > +\n> > /*\n> > * Send command via the control virtqueue and check status. Commands\n> > * supported by the hypervisor, as indicated by feature bits, should\n>","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=yJDWpv7o;\n\tdkim-atps=neutral","ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4Lrr8z0chvz9sGH\n\tfor ; Mon, 25 Jul 2022 16:43:31 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oFroC-005cTw-Oc; Mon, 25 Jul 2022 06:43:16 +0000","from out30-42.freemail.mail.aliyun.com ([115.124.30.42])\n\tby bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oFro9-005cG2-KS\n\tfor linux-um@lists.infradead.org; Mon, 25 Jul 2022 06:43:15 +0000","from localhost(mailfrom:xuanzhuo@linux.alibaba.com\n fp:SMTPD_---0VKIBBAF_1658731375)\n by smtp.aliyun-inc.com;\n Mon, 25 Jul 2022 14:42:56 +0800"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help:\n\tList-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:\n\tFrom:Date:Subject:Message-ID:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=4P8k8Z9A3oT71c9dOlDNuz2WhC+jcnaDND0KRZRhfaI=; b=yJDWpv7oduNJTm\n\tnphCZwGvKQT8k51abVqDj5K0E5lMNWnT6wUldYCf+KadPhhqQUPKcw4Tu1cPQqM9nubf4W2MUdIba\n\tzq4CPsy4PK8BzCJ1oG+mHPk43PX1R8I207h+s6gDkAC+X4Suc3Bn6aydL3ko79UNlWJfYYqkCRtpm\n\toTXTNcD5AOTq2lU7iP7lxSN68kdyMjwKLl2bWLcmC9ZIiy0coB7d2waPKlneAo4Z+nAmNX0IcTeaE\n\tNGV8xkrmc7gfapjzQEZCwN0P/+IXmuIc/5HbeCMNx87+xdIJf5i4MuGDzaTJ5YtLS+jDtvMi/jS/M\n\tIbJxTgTxI33Yk5zeS7Tg==;","X-Alimail-AntiSpam":"\n AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=36;SR=0;TI=SMTPD_---0VKIBBAF_1658731375;","Message-ID":"<1658731116.1695666-1-xuanzhuo@linux.alibaba.com>","Subject":"Re: [PATCH v12 38/40] virtio_net: support rx queue resize","Date":"Mon, 25 Jul 2022 14:38:36 +0800","From":"Xuan Zhuo ","To":"Jason Wang ","Cc":"Richard Weinberger ,\n Anton Ivanov ,\n Johannes Berg ,\n \"Michael S. Tsirkin\" ,\n \"David S. Miller\" ,\n Eric Dumazet ,\n Jakub Kicinski ,\n Paolo Abeni ,\n Hans de Goede ,\n Mark Gross ,\n Vadim Pasternak ,\n Bjorn Andersson ,\n Mathieu Poirier ,\n Cornelia Huck ,\n Halil Pasic ,\n Eric Farman ,\n Heiko Carstens ,\n Vasily Gorbik ,\n Alexander Gordeev ,\n Christian Borntraeger ,\n Sven Schnelle ,\n Alexei Starovoitov ,\n Daniel Borkmann ,\n Jesper Dangaard Brouer ,\n John Fastabend ,\n Vincent Whitchurch ,\n linux-um@lists.infradead.org,\n netdev@vger.kernel.org,\n platform-driver-x86@vger.kernel.org,\n linux-remoteproc@vger.kernel.org,\n linux-s390@vger.kernel.org,\n kvm@vger.kernel.org,\n bpf@vger.kernel.org,\n kangjie.xu@linux.alibaba.com,\n virtualization@lists.linux-foundation.org","References":"<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>\n <20220720030436.79520-39-xuanzhuo@linux.alibaba.com>\n <726a5056-789a-b445-a2c6-879008ad270a@redhat.com>","In-Reply-To":"<726a5056-789a-b445-a2c6-879008ad270a@redhat.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20220724_234313_920479_52EAD9EB ","X-CRM114-Status":"GOOD ( 22.75 )","X-Spam-Score":"-8.0 (--------)","X-Spam-Report":"=?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?=\n\t=?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?=\n\t=?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?=\n\t=?unknown-8bit?q?ginal?=\n\t=?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?=\n\t=?unknown-8bit?q?bel?=\n\t=?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?=\n\t=?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_Content_preview=3A__On_Thu=2C_21_Jul_2022_17=3A25=3A59_+08?=\n\t=?unknown-8bit?q?00=2C_Jason_Wang_=3Cjasowang=40redhat=2Ecom=3E?=\n\t=?unknown-8bit?b?IHdyb3RlOiA+ID4g5ZyoIDIwMjIvNy8yMCAxMTowNCwgWHVhbiBaaHVv?=\n\t=?unknown-8bit?b?IOWGmemBkzogPiA+IFRoaXMgcGF0Y2ggaW1wbGVtZW50cw==?=\n\t=?unknown-8bit?q?_the_resize_function_of_the_rx_queues=2E_=3E_=3E_Based_on_t?=\n\t=?unknown-8bit?q?his_=5B=2E=2E=2E=5D_?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_Content_analysis_details=3A___=28-8=2E0_points=2C_5=2E0_re?=\n\t=?unknown-8bit?q?quired=29?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_pts_rule_name______________description?=\n\t=?unknown-8bit?q?_----_----------------------_------------------------------?=\n\t=?unknown-8bit?q?--------------------?=\n\t=?unknown-8bit?q?_-0=2E0_RCVD=5FIN=5FDNSWL=5FNONE_____RBL=3A_Sender_listed_a?=\n\t=?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C?=\n\t=?unknown-8bit?q?_no_trust?=\n\t=?unknown-8bit?q?_=5B115=2E124=2E30=2E42_listed_in_list=2Ednswl=2Eorg=5D?=\n\t=?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?=\n\t=?unknown-8bit?q?record?=\n\t=?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?=\n\t=?unknown-8bit?q?ish_an_SPF_Record?=\n\t=?unknown-8bit?q?_-7=2E5_USER=5FIN=5FDEF=5FSPF=5FWL_____From=3A_address_is_i?=\n\t=?unknown-8bit?q?n_the_default_SPF?=\n\t=?unknown-8bit?q?_white-list?=\n\t=?unknown-8bit?q?_-0=2E5_ENV=5FAND=5FHDR=5FSPF=5FMATCH__Env_and_Hdr_From_use?=\n\t=?unknown-8bit?q?d_in_default_SPF_WL?=\n\t=?unknown-8bit?q?_Match?=\n\t=?unknown-8bit?q?_0=2E0_UNPARSEABLE=5FRELAY______Informational=3A_message_ha?=\n\t=?unknown-8bit?q?s_unparseable_relay?=\n\t=?unknown-8bit?q?_lines?=","X-BeenThere":"linux-um@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-um\" ","Errors-To":"linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":2938221,"web_url":"http://patchwork.ozlabs.org/comment/2938221/","msgid":"","list_archive_url":null,"date":"2022-07-25T06:57:11","subject":"Re: [PATCH v12 38/40] virtio_net: support rx queue resize","submitter":{"id":5225,"url":"http://patchwork.ozlabs.org/api/people/5225/","name":"Jason Wang","email":"jasowang@redhat.com"},"content":"On Mon, Jul 25, 2022 at 2:43 PM Xuan Zhuo wrote:\n>\n> On Thu, 21 Jul 2022 17:25:59 +0800, Jason Wang wrote:\n> >\n> > 在 2022/7/20 11:04, Xuan Zhuo 写道:\n> > > This patch implements the resize function of the rx queues.\n> > > Based on this function, it is possible to modify the ring num of the\n> > > queue.\n> > >\n> > > Signed-off-by: Xuan Zhuo \n> > > ---\n> > > drivers/net/virtio_net.c | 22 ++++++++++++++++++++++\n> > > 1 file changed, 22 insertions(+)\n> > >\n> > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c\n> > > index fe4dc43c05a1..1115a8b59a08 100644\n> > > --- a/drivers/net/virtio_net.c\n> > > +++ b/drivers/net/virtio_net.c\n> > > @@ -278,6 +278,8 @@ struct padded_vnet_hdr {\n> > > char padding[12];\n> > > };\n> > >\n> > > +static void virtnet_rq_free_unused_buf(struct virtqueue *vq, void *buf);\n> > > +\n> > > static bool is_xdp_frame(void *ptr)\n> > > {\n> > > return (unsigned long)ptr & VIRTIO_XDP_FLAG;\n> > > @@ -1846,6 +1848,26 @@ static netdev_tx_t start_xmit(struct sk_buff *skb, struct net_device *dev)\n> > > return NETDEV_TX_OK;\n> > > }\n> > >\n> > > +static int virtnet_rx_resize(struct virtnet_info *vi,\n> > > + struct receive_queue *rq, u32 ring_num)\n> > > +{\n> > > + int err, qindex;\n> > > +\n> > > + qindex = rq - vi->rq;\n> > > +\n> > > + napi_disable(&rq->napi);\n> >\n> >\n> > We need to disable refill work as well. So this series might need\n> > rebasing on top of\n> >\n> > https://lore.kernel.org/netdev/20220704074859.16912-1-jasowang@redhat.com/\n>\n> I understand that your patch is used to solve the situation where dev is\n> destoryed but refill work is running.\n>\n> And is there such a possibility here?\n\nE.g the refill work runs in parallel with this function?\n\nThanks\n\n> Or is there any other scenario that I'm\n> not expecting?\n>\n> Thanks.\n>\n>\n> >\n> > I will send a new version (probably tomorrow).\n> >\n> > Thanks\n> >\n> >\n> > > +\n> > > + err = virtqueue_resize(rq->vq, ring_num, virtnet_rq_free_unused_buf);\n> > > + if (err)\n> > > + netdev_err(vi->dev, \"resize rx fail: rx queue index: %d err: %d\\n\", qindex, err);\n> > > +\n> > > + if (!try_fill_recv(vi, rq, GFP_KERNEL))\n> > > + schedule_delayed_work(&vi->refill, 0);\n> > > +\n> > > + virtnet_napi_enable(rq->vq, &rq->napi);\n> > > + return err;\n> > > +}\n> > > +\n> > > /*\n> > > * Send command via the control virtqueue and check status. Commands\n> > > * supported by the hypervisor, as indicated by feature bits, should\n> >\n>","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=OALeTTuK;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=RHesjQx/;\n\tdkim-atps=neutral","ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=)","relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4LrrTN73KHz9s2R\n\tfor ; Mon, 25 Jul 2022 16:57:44 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oFs22-005lSH-7M; Mon, 25 Jul 2022 06:57:34 +0000","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n\tby bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oFs1z-005lP6-3m\n\tfor linux-um@lists.infradead.org; Mon, 25 Jul 2022 06:57:32 +0000","from mail-lj1-f198.google.com (mail-lj1-f198.google.com\n [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-672-DUoF2BU_N_ySm3AZpV9l_g-1; Mon, 25 Jul 2022 02:57:23 -0400","by mail-lj1-f198.google.com with SMTP id\n w16-20020a2e9bd0000000b0025dffcab96eso778511ljj.16\n for ;\n Sun, 24 Jul 2022 23:57:23 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:\n\tIn-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=Cu5H4VzMOSy9MH9WuUGhMuf/FL7tO2De3HZB38HPvFg=; b=OALeTTuK1tCPFa\n\t/kVSnspbVVAiMXZlhMPKH2CnSl24XQYl8Roc07dtxk+mlrVvYfwfrB8vLdc2Mq2xEeLWhw0JnbNHh\n\tLyHOIC7LN7A4wX3FEgOEmP1JJmb6GqYrv19oA2Bp1uAv/Rx6LHGuRJ3dWy/1fjw9sskSzq+HoZ82H\n\tKSi/Sug4mvJwdaao/qvOmyJm1CSxKgtXG/KcKcrsDxgkKoC5TtuR6nlsj4sDkWkxIGh5wYTq1n4//\n\tmSC5E/m1Kqc5M2uoymja1ksJ9LE1hlxt0M95XNMLR3gn9btKG2llCs+EejSHBd9bCxAo83ZctdKPm\n\tH3TxJ8NGgABkGjEY4s7g==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1658732247;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=qmW1hBnXSgXOK1sS9gN4+759LGb0Ym1b2aF+Hz+Xy9U=;\n\tb=RHesjQx/S5SMS7a9qAS8dh7d/ZC9MVIoqcdwVuIK3Yjtn2OdwhxSApauyznKq8qJgscDQu\n\tTcjArzhoTgpOtsXCkk/mFzPzsUIuOzR3LJKuYuuEueirot4nQLa7ecH3zYmkCcizubcoQP\n\tw2sj2MBIsx29ZxZAJH3XnLtRcomm/jM="],"X-MC-Unique":"DUoF2BU_N_ySm3AZpV9l_g-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:mime-version:references:in-reply-to:from:date\n :message-id:subject:to:cc:content-transfer-encoding;\n bh=qmW1hBnXSgXOK1sS9gN4+759LGb0Ym1b2aF+Hz+Xy9U=;\n b=M6Bgw/UoMWCebOYBwwbQvQNBpJwKDdxT7AumEfM4vx9Zsh3ilHWz/VH88m41NcZE0C\n IBeuK1odTiqQG8ZQ2SZBd7QRziIWlaRQmFEI3P3yAKGgtnEvLEP3Fw+HC0Izc49eTf9m\n uoEYLxZH7fbZaPTvGA6xlAw3VPCq2Z9oLtdP/mcclwu0QSAnzUtdoH2ODutM8xwFIo0P\n OLevX6ML7CiUgvtsT1IPEozhc9wfS8WCOCTfVbXejvztEVVE96DpIFq/N7vGBKUCwhz8\n f4nenufz8+J+WpvyPf75w4qHXvR68F/8w+YbbK0LFO6XbiTbWRZgQCT8sFxoJ+bkigoJ\n hXSg==","X-Gm-Message-State":"AJIora92uvz2j7VoeeCtfoJUxIvLr0WDHpYt5XPtCKEo7JP19JC7TS4X\n\t/+kgQiiPRA+2Hsxi6qGYgVpj9c6glXG1+A7EZ30E/2EbLL9tEF9b+hIzIMYf3oZRuc4D0EEyTST\n\tf5Q3DiXexZ2nRg8siEJus7BQOy8H8qzSlC4nG/KYZ","X-Received":["by 2002:ac2:4205:0:b0:48a:95e6:395c with SMTP id\n y5-20020ac24205000000b0048a95e6395cmr365138lfh.238.1658732242404;\n Sun, 24 Jul 2022 23:57:22 -0700 (PDT)","by 2002:ac2:4205:0:b0:48a:95e6:395c with SMTP id\n y5-20020ac24205000000b0048a95e6395cmr365123lfh.238.1658732242186; Sun, 24 Jul\n 2022 23:57:22 -0700 (PDT)"],"X-Google-Smtp-Source":"\n AGRyM1unkGiIlKuXLUSHpJBWTVSAU4zhX72Do0K+zbnbWWScjjTYkm8xiqqQ6k0g8uFHQC6oNFJAAG44P+Vps9/gr6o=","MIME-Version":"1.0","References":"<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>\n <20220720030436.79520-39-xuanzhuo@linux.alibaba.com>\n <726a5056-789a-b445-a2c6-879008ad270a@redhat.com>\n <1658731116.1695666-1-xuanzhuo@linux.alibaba.com>","In-Reply-To":"<1658731116.1695666-1-xuanzhuo@linux.alibaba.com>","From":"Jason Wang ","Date":"Mon, 25 Jul 2022 14:57:11 +0800","Message-ID":"\n ","Subject":"Re: [PATCH v12 38/40] virtio_net: support rx queue resize","To":"Xuan Zhuo ","Cc":"Richard Weinberger ,\n Anton Ivanov ,\n\tJohannes Berg ,\n \"Michael S. Tsirkin\" ,\n\t\"David S. Miller\" , Eric Dumazet ,\n\tJakub Kicinski , Paolo Abeni ,\n Hans de Goede ,\n\tMark Gross , Vadim Pasternak ,\n\tBjorn Andersson ,\n Mathieu Poirier ,\n\tCornelia Huck , Halil Pasic ,\n\tEric Farman , Heiko Carstens ,\n\tVasily Gorbik ,\n Alexander Gordeev ,\n\tChristian Borntraeger ,\n Sven Schnelle ,\n\tAlexei Starovoitov , Daniel Borkmann ,\n\tJesper Dangaard Brouer ,\n John Fastabend ,\n\tVincent Whitchurch ,\n linux-um@lists.infradead.org,\n\tnetdev , platform-driver-x86@vger.kernel.org,\n\tlinux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org,\n\tkvm ,\n\t\"open list:XDP (eXpress Data Path)\" ,\n Kangjie Xu ,\n\tvirtualization ","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20220724_235731_298040_72E8009E ","X-CRM114-Status":"GOOD ( 27.29 )","X-Spam-Score":"-0.4 (/)","X-Spam-Report":"=?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?=\n\t=?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?=\n\t=?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?=\n\t=?unknown-8bit?q?ginal?=\n\t=?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?=\n\t=?unknown-8bit?q?bel?=\n\t=?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?=\n\t=?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_Content_preview=3A__On_Mon=2C_Jul_25=2C_2022_at_2=3A43_PM_?=\n\t=?unknown-8bit?q?Xuan_Zhuo_=3Cxuanzhuo=40linux=2Ealibaba=2Ecom=3E?=\n\t=?unknown-8bit?q?_wrote=3A_=3E_=3E_On_Thu=2C_21_Jul_2022_17=3A25=3A59_+0800?=\n\t=?unknown-8bit?q?=2C_Jason_Wang_=3Cjasowang=40redhat=2Ecom=3E?=\n\t=?unknown-8bit?b?IHdyb3RlOiA+ID4gPiA+IOWcqCAyMDIyLzcvMjAgMTE6MDQsIFh1YW4g?=\n\t=?unknown-8bit?b?Wmh1byDlhpkgWy4uLl0g?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_Content_analysis_details=3A___=28-0=2E4_points=2C_5=2E0_re?=\n\t=?unknown-8bit?q?quired=29?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_pts_rule_name______________description?=\n\t=?unknown-8bit?q?_----_----------------------_------------------------------?=\n\t=?unknown-8bit?q?--------------------?=\n\t=?unknown-8bit?q?_-0=2E0_RCVD=5FIN=5FDNSWL=5FNONE_____RBL=3A_Sender_listed_a?=\n\t=?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C?=\n\t=?unknown-8bit?q?_no_trust?=\n\t=?unknown-8bit?q?_=5B170=2E10=2E133=2E124_listed_in_list=2Ednswl=2Eorg=5D?=\n\t=?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?=\n\t=?unknown-8bit?q?ish_an_SPF_Record?=\n\t=?unknown-8bit?q?_0=2E0_SPF=5FNONE_______________SPF=3A_sender_does_not_publ?=\n\t=?unknown-8bit?q?ish_an_SPF_Record?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FAU__________Message_has_a_valid_DKIM?=\n\t=?unknown-8bit?q?_or_DK_signature_from?=\n\t=?unknown-8bit?q?_author=27s_domain?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?=\n\t=?unknown-8bit?q?alid_DKIM_or_DK_signature?=\n\t=?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?=\n\t=?unknown-8bit?q?gnature=2C_not_necessarily?=\n\t=?unknown-8bit?q?_valid?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FEF__________Message_has_a_valid_DKIM?=\n\t=?unknown-8bit?q?_or_DK_signature_from?=\n\t=?unknown-8bit?q?_envelope-from_domain?=\n\t=?unknown-8bit?q?_-0=2E2_DKIMWL=5FWL=5FHIGH_________DKIMwl=2Eorg_-_High_trus?=\n\t=?unknown-8bit?q?t_sender?=","X-BeenThere":"linux-um@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-um\" ","Errors-To":"linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":2938234,"web_url":"http://patchwork.ozlabs.org/comment/2938234/","msgid":"<1658733700.3892667-1-xuanzhuo@linux.alibaba.com>","list_archive_url":null,"date":"2022-07-25T07:21:40","subject":"Re: [PATCH v12 38/40] virtio_net: support rx queue resize","submitter":{"id":80519,"url":"http://patchwork.ozlabs.org/api/people/80519/","name":"Xuan Zhuo","email":"xuanzhuo@linux.alibaba.com"},"content":"On Mon, 25 Jul 2022 14:57:11 +0800, Jason Wang wrote:\n> On Mon, Jul 25, 2022 at 2:43 PM Xuan Zhuo wrote:\n> >\n> > On Thu, 21 Jul 2022 17:25:59 +0800, Jason Wang wrote:\n> > >\n> > > 在 2022/7/20 11:04, Xuan Zhuo 写道:\n> > > > This patch implements the resize function of the rx queues.\n> > > > Based on this function, it is possible to modify the ring num of the\n> > > > queue.\n> > > >\n> > > > Signed-off-by: Xuan Zhuo \n> > > > ---\n> > > > drivers/net/virtio_net.c | 22 ++++++++++++++++++++++\n> > > > 1 file changed, 22 insertions(+)\n> > > >\n> > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c\n> > > > index fe4dc43c05a1..1115a8b59a08 100644\n> > > > --- a/drivers/net/virtio_net.c\n> > > > +++ b/drivers/net/virtio_net.c\n> > > > @@ -278,6 +278,8 @@ struct padded_vnet_hdr {\n> > > > char padding[12];\n> > > > };\n> > > >\n> > > > +static void virtnet_rq_free_unused_buf(struct virtqueue *vq, void *buf);\n> > > > +\n> > > > static bool is_xdp_frame(void *ptr)\n> > > > {\n> > > > return (unsigned long)ptr & VIRTIO_XDP_FLAG;\n> > > > @@ -1846,6 +1848,26 @@ static netdev_tx_t start_xmit(struct sk_buff *skb, struct net_device *dev)\n> > > > return NETDEV_TX_OK;\n> > > > }\n> > > >\n> > > > +static int virtnet_rx_resize(struct virtnet_info *vi,\n> > > > + struct receive_queue *rq, u32 ring_num)\n> > > > +{\n> > > > + int err, qindex;\n> > > > +\n> > > > + qindex = rq - vi->rq;\n> > > > +\n> > > > + napi_disable(&rq->napi);\n> > >\n> > >\n> > > We need to disable refill work as well. So this series might need\n> > > rebasing on top of\n> > >\n> > > https://lore.kernel.org/netdev/20220704074859.16912-1-jasowang@redhat.com/\n> >\n> > I understand that your patch is used to solve the situation where dev is\n> > destoryed but refill work is running.\n> >\n> > And is there such a possibility here?\n>\n> E.g the refill work runs in parallel with this function?\n\nnapi_disable enables lock-like functionality. So I think it's safe.\n\nThanks.\n\n>\n> Thanks\n>\n> > Or is there any other scenario that I'm\n> > not expecting?\n> >\n> > Thanks.\n> >\n> >\n> > >\n> > > I will send a new version (probably tomorrow).\n> > >\n> > > Thanks\n> > >\n> > >\n> > > > +\n> > > > + err = virtqueue_resize(rq->vq, ring_num, virtnet_rq_free_unused_buf);\n> > > > + if (err)\n> > > > + netdev_err(vi->dev, \"resize rx fail: rx queue index: %d err: %d\\n\", qindex, err);\n> > > > +\n> > > > + if (!try_fill_recv(vi, rq, GFP_KERNEL))\n> > > > + schedule_delayed_work(&vi->refill, 0);\n> > > > +\n> > > > + virtnet_napi_enable(rq->vq, &rq->napi);\n> > > > + return err;\n> > > > +}\n> > > > +\n> > > > /*\n> > > > * Send command via the control virtqueue and check status. Commands\n> > > > * supported by the hypervisor, as indicated by feature bits, should\n> > >\n> >\n>","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=1aXNXZty;\n\tdkim-atps=neutral","ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4Lrs3W3MbHz9s2R\n\tfor ; Mon, 25 Jul 2022 17:23:51 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oFsRH-0063ny-2E; Mon, 25 Jul 2022 07:23:39 +0000","from out30-45.freemail.mail.aliyun.com ([115.124.30.45])\n\tby bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oFsRC-0063hg-4n\n\tfor linux-um@lists.infradead.org; Mon, 25 Jul 2022 07:23:37 +0000","from localhost(mailfrom:xuanzhuo@linux.alibaba.com\n fp:SMTPD_---0VKJTorY_1658733806)\n by smtp.aliyun-inc.com;\n Mon, 25 Jul 2022 15:23:27 +0800"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help:\n\tList-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:\n\tFrom:Date:Subject:Message-ID:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=fKpm2f93OHaTaLJFu2mmd9rRYHN/gu3nAOYWHIGSpXg=; b=1aXNXZtyhvTiAI\n\tftBc7dMqZ3IggcsFO9BUHwRgK/14RnqyFD6G7fTQyV73rrZUAI46y8Z2luHXIOWU73xMXjzCqroQ1\n\t0MLMx1X59aa2mpd9HUq1KKAFQRpusxVczxtQM19oLnj0wfpo4bsedemD4eM7gCttbDkJhwZhnMxN3\n\t5nceJY4gKfKt3KTX2+zf59gNhbS+HdgpHeb5x1s3/Jm052HrDx8yaEvhFTjSjNiSh9xoGzHN7Bfy5\n\t7CusKQOmaO44rvmCawx5kcFDU2Up7+LvIiHjl4FM/Su5OvCXcBL+4VspKCAY+P0ZCEx/Dds28WYST\n\t7FZ+OUc5sGNQJDmAHl6A==;","X-Alimail-AntiSpam":"\n AC=PASS;BC=-1|-1;BR=01201311R661e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=36;SR=0;TI=SMTPD_---0VKJTorY_1658733806;","Message-ID":"<1658733700.3892667-1-xuanzhuo@linux.alibaba.com>","Subject":"Re: [PATCH v12 38/40] virtio_net: support rx queue resize","Date":"Mon, 25 Jul 2022 15:21:40 +0800","From":"Xuan Zhuo ","To":"Jason Wang ","Cc":"Richard Weinberger ,\n Anton Ivanov ,\n Johannes Berg ,\n \"Michael S. Tsirkin\" ,\n \"David S. Miller\" ,\n Eric Dumazet ,\n Jakub Kicinski ,\n Paolo Abeni ,\n Hans de Goede ,\n Mark Gross ,\n Vadim Pasternak ,\n Bjorn Andersson ,\n Mathieu Poirier ,\n Cornelia Huck ,\n Halil Pasic ,\n Eric Farman ,\n Heiko Carstens ,\n Vasily Gorbik ,\n Alexander Gordeev ,\n Christian Borntraeger ,\n Sven Schnelle ,\n Alexei Starovoitov ,\n Daniel Borkmann ,\n Jesper Dangaard Brouer ,\n John Fastabend ,\n Vincent Whitchurch ,\n linux-um@lists.infradead.org,\n netdev ,\n platform-driver-x86@vger.kernel.org,\n linux-remoteproc@vger.kernel.org,\n linux-s390@vger.kernel.org,\n kvm ,\n \"open list:XDP (eXpress Data Path)\" ,\n Kangjie Xu ,\n virtualization ","References":"<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>\n <20220720030436.79520-39-xuanzhuo@linux.alibaba.com>\n <726a5056-789a-b445-a2c6-879008ad270a@redhat.com>\n <1658731116.1695666-1-xuanzhuo@linux.alibaba.com>\n ","In-Reply-To":"\n ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20220725_002334_392470_2E29E66D ","X-CRM114-Status":"GOOD ( 28.51 )","X-Spam-Score":"-8.0 (--------)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: On Mon, 25 Jul 2022 14:57:11 +0800,\n Jason Wang \n wrote: > On Mon, Jul 25,\n 2022 at 2:43 PM Xuan Zhuo \n wrote: > > > > On Thu, 21 Jul 2022 17:25:59 +0800, [...]\n Content analysis details: (-8.0 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,\n no trust\n [115.124.30.45 listed in list.dnswl.org]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -7.5 USER_IN_DEF_SPF_WL From: address is in the default SPF\n white-list\n -0.5 ENV_AND_HDR_SPF_MATCH Env and Hdr From used in default SPF WL\n Match\n 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n lines","X-BeenThere":"linux-um@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-um\" ","Errors-To":"linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":2938241,"web_url":"http://patchwork.ozlabs.org/comment/2938241/","msgid":"","list_archive_url":null,"date":"2022-07-25T07:28:55","subject":"Re: [PATCH v12 38/40] virtio_net: support rx queue resize","submitter":{"id":5225,"url":"http://patchwork.ozlabs.org/api/people/5225/","name":"Jason Wang","email":"jasowang@redhat.com"},"content":"On Mon, Jul 25, 2022 at 3:23 PM Xuan Zhuo wrote:\n>\n> On Mon, 25 Jul 2022 14:57:11 +0800, Jason Wang wrote:\n> > On Mon, Jul 25, 2022 at 2:43 PM Xuan Zhuo wrote:\n> > >\n> > > On Thu, 21 Jul 2022 17:25:59 +0800, Jason Wang wrote:\n> > > >\n> > > > 在 2022/7/20 11:04, Xuan Zhuo 写道:\n> > > > > This patch implements the resize function of the rx queues.\n> > > > > Based on this function, it is possible to modify the ring num of the\n> > > > > queue.\n> > > > >\n> > > > > Signed-off-by: Xuan Zhuo \n> > > > > ---\n> > > > > drivers/net/virtio_net.c | 22 ++++++++++++++++++++++\n> > > > > 1 file changed, 22 insertions(+)\n> > > > >\n> > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c\n> > > > > index fe4dc43c05a1..1115a8b59a08 100644\n> > > > > --- a/drivers/net/virtio_net.c\n> > > > > +++ b/drivers/net/virtio_net.c\n> > > > > @@ -278,6 +278,8 @@ struct padded_vnet_hdr {\n> > > > > char padding[12];\n> > > > > };\n> > > > >\n> > > > > +static void virtnet_rq_free_unused_buf(struct virtqueue *vq, void *buf);\n> > > > > +\n> > > > > static bool is_xdp_frame(void *ptr)\n> > > > > {\n> > > > > return (unsigned long)ptr & VIRTIO_XDP_FLAG;\n> > > > > @@ -1846,6 +1848,26 @@ static netdev_tx_t start_xmit(struct sk_buff *skb, struct net_device *dev)\n> > > > > return NETDEV_TX_OK;\n> > > > > }\n> > > > >\n> > > > > +static int virtnet_rx_resize(struct virtnet_info *vi,\n> > > > > + struct receive_queue *rq, u32 ring_num)\n> > > > > +{\n> > > > > + int err, qindex;\n> > > > > +\n> > > > > + qindex = rq - vi->rq;\n> > > > > +\n> > > > > + napi_disable(&rq->napi);\n> > > >\n> > > >\n> > > > We need to disable refill work as well. So this series might need\n> > > > rebasing on top of\n> > > >\n> > > > https://lore.kernel.org/netdev/20220704074859.16912-1-jasowang@redhat.com/\n> > >\n> > > I understand that your patch is used to solve the situation where dev is\n> > > destoryed but refill work is running.\n> > >\n> > > And is there such a possibility here?\n> >\n> > E.g the refill work runs in parallel with this function?\n>\n> napi_disable enables lock-like functionality. So I think it's safe.\n>\n\nOk, right, since there will be a napi_enable() soon afterwards.\n\nSo\n\nAcked-by: Jason Wang \n\nThanks\n\n> Thanks.\n>\n> >\n> > Thanks\n> >\n> > > Or is there any other scenario that I'm\n> > > not expecting?\n> > >\n> > > Thanks.\n> > >\n> > >\n> > > >\n> > > > I will send a new version (probably tomorrow).\n> > > >\n> > > > Thanks\n> > > >\n> > > >\n> > > > > +\n> > > > > + err = virtqueue_resize(rq->vq, ring_num, virtnet_rq_free_unused_buf);\n> > > > > + if (err)\n> > > > > + netdev_err(vi->dev, \"resize rx fail: rx queue index: %d err: %d\\n\", qindex, err);\n> > > > > +\n> > > > > + if (!try_fill_recv(vi, rq, GFP_KERNEL))\n> > > > > + schedule_delayed_work(&vi->refill, 0);\n> > > > > +\n> > > > > + virtnet_napi_enable(rq->vq, &rq->napi);\n> > > > > + return err;\n> > > > > +}\n> > > > > +\n> > > > > /*\n> > > > > * Send command via the control virtqueue and check status. Commands\n> > > > > * supported by the hypervisor, as indicated by feature bits, should\n> > > >\n> > >\n> >\n>","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=yOVrC+eT;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Gjv6jeTj;\n\tdkim-atps=neutral","ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=)","relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4Lrs9z433Vz9s2R\n\tfor ; Mon, 25 Jul 2022 17:29:27 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oFsWh-0067Bz-QD; Mon, 25 Jul 2022 07:29:15 +0000","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n\tby bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oFsWe-0067AU-T2\n\tfor linux-um@lists.infradead.org; Mon, 25 Jul 2022 07:29:14 +0000","from mail-lf1-f72.google.com (mail-lf1-f72.google.com\n [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-490-LS1cU2P3MbmjbtcphQJ5Tw-1; Mon, 25 Jul 2022 03:29:08 -0400","by mail-lf1-f72.google.com with SMTP id\n dt17-20020a0565122a9100b0048a878a2a56so480616lfb.6\n for ;\n Mon, 25 Jul 2022 00:29:08 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:\n\tIn-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=7TsYrpST92Hm2wr4z4sA9HrOuto9A1qewc4/yCOJUE0=; b=yOVrC+eTCp6P3m\n\tMbUIm889Jfdys9Dgf1fMUN209Sz8N54TEdpFTdJSerBZc2X/XTX7JITxefw3r0PyS+q0kw25DQUXa\n\tpgBnMAceoh9eR26fyTz9sGCxn1edwngTuNYDZK3qbaNbP2JNOjYd71HE0380u6u7ZqD8keY9z6gTW\n\tcLxVTOimmd1lciizu5gnD/3sWP910dYWpdnrjWhwpRUu6RMtGbQ6ZBnDnFWljvLGh2ArLukf+liQ8\n\tAgxk6jrIDvhGKbZsyEvdTq0EtMSKSMI15xqY/GrK3SYMZitSM+YvOW8TqWE6avya4+vk5/Hl8ICKR\n\tkDO/UkuLZVu+ixFHE/1Q==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1658734151;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=7V73Urf85bEAl0pJImVws1FSD2o2Nh9wuLCajEhv1dQ=;\n\tb=Gjv6jeTjD5uidh1vbHcCCmYQVVcCMY6V0dZ+3axcTLjuaUjTvJfNk8Hii8ZGnwrIKwiwMF\n\t0L/D1HGFsBeOFjS7r5oo6zsMN1H+PbuMpxnueSDoUiwuCMenqjJ6WjHrb5luB01Q/65N5L\n\t7kA5AMR6QFKk/7ZrfM1RCqYti2/Xikc="],"X-MC-Unique":"LS1cU2P3MbmjbtcphQJ5Tw-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:mime-version:references:in-reply-to:from:date\n :message-id:subject:to:cc:content-transfer-encoding;\n bh=7V73Urf85bEAl0pJImVws1FSD2o2Nh9wuLCajEhv1dQ=;\n b=Nzsea6JIO+/2gUOYmh8scaV7JtwWDXQlLUzO6a/MXvRXaInFSAUV2lNLmuMM2dATij\n P8Jlts3LqpuafKMx0EWYpmTnH+eVhvY7fJB9s6y8uY2u6B7hAYealUSwg4LivDubnToS\n Uab/oLkDSnmpBSP7ndsLE6uGufjR1TxKNzIBUvpzPJWtIg1E/42KzcJyaRIOd/7bGo/A\n Pqjn2oCfg58o06D4RQG86q+fCeHlen8mM+Fill2Ycs8cpL10tRiW5Bg437GUE6fppogn\n 9466sh41oCQsrUzbB7mDnLeKc+5GAsAEkSAMMKBDXltuH0zECwtK/goAn3AOYHxl/Gei\n 4ifw==","X-Gm-Message-State":"AJIora9v/FZQYioek/McFhqiDPzJ9dreylVT5QOapblY/hGnMSnoURJq\n\tvo49/RHFb9eF4/oFh+iUoj0VEP10mPAi4llKJbqq3EpaMNziv5BpVZIkFErSty8OzUnPZn7nIrL\n\t+bHWtEfHsSjLHBjuPnU7aVoQcPCVqzAqB3qFDwotM","X-Received":["by 2002:a05:6512:3f0e:b0:48a:5edd:99b2 with SMTP id\n y14-20020a0565123f0e00b0048a5edd99b2mr3893789lfa.124.1658734147169;\n Mon, 25 Jul 2022 00:29:07 -0700 (PDT)","by 2002:a05:6512:3f0e:b0:48a:5edd:99b2 with SMTP id\n y14-20020a0565123f0e00b0048a5edd99b2mr3893759lfa.124.1658734146714; Mon, 25\n Jul 2022 00:29:06 -0700 (PDT)"],"X-Google-Smtp-Source":"\n AGRyM1vSilpMwka+2TIjWzkO9OCXsrSScPIWOm9X8cfPvK1yqV+F7/YxylSd832Ayyg4Jn4Euf9+iYQrDan3aN009eg=","MIME-Version":"1.0","References":"<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>\n <20220720030436.79520-39-xuanzhuo@linux.alibaba.com>\n <726a5056-789a-b445-a2c6-879008ad270a@redhat.com>\n <1658731116.1695666-1-xuanzhuo@linux.alibaba.com>\n \n <1658733700.3892667-1-xuanzhuo@linux.alibaba.com>","In-Reply-To":"<1658733700.3892667-1-xuanzhuo@linux.alibaba.com>","From":"Jason Wang ","Date":"Mon, 25 Jul 2022 15:28:55 +0800","Message-ID":"\n ","Subject":"Re: [PATCH v12 38/40] virtio_net: support rx queue resize","To":"Xuan Zhuo ","Cc":"Richard Weinberger ,\n Anton Ivanov ,\n\tJohannes Berg ,\n \"Michael S. Tsirkin\" ,\n\t\"David S. Miller\" , Eric Dumazet ,\n\tJakub Kicinski , Paolo Abeni ,\n Hans de Goede ,\n\tMark Gross , Vadim Pasternak ,\n\tBjorn Andersson ,\n Mathieu Poirier ,\n\tCornelia Huck , Halil Pasic ,\n\tEric Farman , Heiko Carstens ,\n\tVasily Gorbik ,\n Alexander Gordeev ,\n\tChristian Borntraeger ,\n Sven Schnelle ,\n\tAlexei Starovoitov , Daniel Borkmann ,\n\tJesper Dangaard Brouer ,\n John Fastabend ,\n\tVincent Whitchurch ,\n linux-um@lists.infradead.org,\n\tnetdev , platform-driver-x86@vger.kernel.org,\n\tlinux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org,\n\tkvm ,\n\t\"open list:XDP (eXpress Data Path)\" ,\n Kangjie Xu ,\n\tvirtualization ","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20220725_002913_040725_CE8D9330 ","X-CRM114-Status":"GOOD ( 31.71 )","X-Spam-Score":"-0.4 (/)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: On Mon, Jul 25,\n 2022 at 3:23 PM Xuan Zhuo \n wrote: > > On Mon, 25 Jul 2022 14:57:11 +0800,\n Jason Wang \n wrote: > > On Mon, Jul 25, 2022 at 2:43 PM Xuan Z [...]\n Content analysis details: (-0.4 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,\n no trust\n [170.10.133.124 listed in list.dnswl.org]\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n 0.0 SPF_NONE SPF: sender does not publish an SPF Record\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily\n valid\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.2 DKIMWL_WL_HIGH DKIMwl.org - High trust sender","X-BeenThere":"linux-um@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-um\" ","Errors-To":"linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]