[{"id":2936529,"web_url":"http://patchwork.ozlabs.org/comment/2936529/","msgid":"","list_archive_url":null,"date":"2022-07-21T09:14:29","subject":"Re: [PATCH v12 26/40] virtio_ring: struct virtqueue introduce reset","submitter":{"id":5225,"url":"http://patchwork.ozlabs.org/api/people/5225/","name":"Jason Wang","email":"jasowang@redhat.com"},"content":"在 2022/7/20 11:04, Xuan Zhuo 写道:\n> Introduce a new member reset to the structure virtqueue to determine\n> whether the current vq is in the reset state. Subsequent patches will\n> use it.\n>\n> Signed-off-by: Xuan Zhuo \n\n\nAcked-by: Jason Wang \n\n\n> ---\n> drivers/virtio/virtio_ring.c | 2 ++\n> include/linux/virtio.h | 2 ++\n> 2 files changed, 4 insertions(+)\n>\n> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c\n> index bf666dad9904..8278b917ad64 100644\n> --- a/drivers/virtio/virtio_ring.c\n> +++ b/drivers/virtio/virtio_ring.c\n> @@ -2011,6 +2011,7 @@ static struct virtqueue *vring_create_virtqueue_packed(\n> \tvq->vq.vdev = vdev;\n> \tvq->vq.name = name;\n> \tvq->vq.index = index;\n> +\tvq->vq.reset = false;\n> \tvq->we_own_ring = true;\n> \tvq->notify = notify;\n> \tvq->weak_barriers = weak_barriers;\n> @@ -2490,6 +2491,7 @@ struct virtqueue *__vring_new_virtqueue(unsigned int index,\n> \tvq->vq.vdev = vdev;\n> \tvq->vq.name = name;\n> \tvq->vq.index = index;\n> +\tvq->vq.reset = false;\n> \tvq->we_own_ring = false;\n> \tvq->notify = notify;\n> \tvq->weak_barriers = weak_barriers;\n> diff --git a/include/linux/virtio.h b/include/linux/virtio.h\n> index d45ee82a4470..a3f73bb6733e 100644\n> --- a/include/linux/virtio.h\n> +++ b/include/linux/virtio.h\n> @@ -20,6 +20,7 @@\n> * @index: the zero-based ordinal number for this queue.\n> * @num_free: number of elements we expect to be able to fit.\n> * @num_max: the maximum number of elements supported by the device.\n> + * @reset: vq is in reset state or not.\n> *\n> * A note on @num_free: with indirect buffers, each buffer needs one\n> * element in the queue, otherwise a buffer will need one element per\n> @@ -34,6 +35,7 @@ struct virtqueue {\n> \tunsigned int num_free;\n> \tunsigned int num_max;\n> \tvoid *priv;\n> +\tbool reset;\n> };\n> \n> int virtqueue_add_outbuf(struct virtqueue *vq,","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=EUZ6fdVV;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ht9iHBb7;\n\tdkim-atps=neutral","ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=)","relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4LpRjW2MdZz9s09\n\tfor ; Thu, 21 Jul 2022 19:14:55 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oESGd-0035uk-JL; Thu, 21 Jul 2022 09:14:47 +0000","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n\tby bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oESGa-0035se-VP\n\tfor linux-um@lists.infradead.org; Thu, 21 Jul 2022 09:14:46 +0000","from mail-pj1-f71.google.com (mail-pj1-f71.google.com\n [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-665-LyPMPNoOMHGE6HcpGbmrvg-1; Thu, 21 Jul 2022 05:14:42 -0400","by mail-pj1-f71.google.com with SMTP id\n o13-20020a17090ab88d00b001f1ef2109aaso2565048pjr.2\n for ;\n Thu, 21 Jul 2022 02:14:42 -0700 (PDT)","from [10.72.12.47] ([209.132.188.80])\n by smtp.gmail.com with ESMTPSA id\n x8-20020a170902a38800b0016bebb0cb96sm1114154pla.266.2022.07.21.02.14.30\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 21 Jul 2022 02:14:40 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject:\n\tMIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=MJI4q22m/HDnvUS4FhDoTsSN6a/iJtWDwPPEeVRuksc=; b=EUZ6fdVVEMiwUH\n\t7vgflRJOAYtlagY7LebMIKN4OhVoZpilicoWyE/0mqvOQIzTk+38h6/V6udLzq+uvxHQI05xGLa97\n\txs3zSG0sM0q/UUwH9GIoKy6UqREKjqeYIdSvM8g9kMalsN1VjyTyQdMd8z2FBaADPx4xMxRu6Ex7k\n\tkgXusMgw2k0k4E02KqdfHHqs2wqCFYU9eiRxxQ/TG/PddYlymyw26Z4pQoBItv00E6B/KF1gOIxmk\n\t//+RNd3Nl0NUygdgc291uewZkwG5aoRYDd6IG8551vFeb+JYxHi1c7Xau8IG/LskwABppQlEoUbqK\n\tmKOjwJZ8IG0+0i+ofSag==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1658394884;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=Qsc4liwturFJYHAITq0jfAcGv5JnVY7R1RVgysjsWkI=;\n\tb=ht9iHBb7wDvinRuLOPw2KXXXxh1SIXRRqM2B7PFqaXNzr1c5fRrm04TN4CcHZYWBlIpXTe\n\tDTEykRgzTAXN6AIo0oQZ/tnH6hzvEE4veg0ATXLoqeEJ3OSTx32xskeYa6V95Fd3H0Cw51\n\td0qm8zB5x24eUFXubt0PkMvF/of06a8="],"X-MC-Unique":"LyPMPNoOMHGE6HcpGbmrvg-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:message-id:date:mime-version:user-agent:subject\n :content-language:to:cc:references:from:in-reply-to\n :content-transfer-encoding;\n bh=Qsc4liwturFJYHAITq0jfAcGv5JnVY7R1RVgysjsWkI=;\n b=jUkatF7spsy8vWkYBW3yEdlcOYdtQInVT3Is4IzPewXeKmuACtxWRpPNFWDZ4z4G3D\n xcUBlDGS8aR2xhu/3ZBRNENm4FRF0mYH8kH4HhtkKIqo+fDLQqus5xkLuv5tdfl8BtCX\n PMTgW69zDPG96QlsP8iDSXDmuuZyO4rNQTKD5SjFNqkFSOmGVeAiBJXV75om7NvuUYlh\n HET6P+S4ZLsIlCHCjZuU4eZ7Nl/PAkDFEV4LGUTHJd9LGW2OIhAydJadISDCTOUNYxx3\n 5YuthXuDBFAjY0ZDHIJjskDqfzkvI+61YNkMYskRTsEbS4wCcF4Sxlqv8oOHST0BuoGa\n U26w==","X-Gm-Message-State":"AJIora+jQDLJQAguwVnvEjd2MxyL29UzRrBiDBQuyw/NombwwCXQc9j+\n\t7JJqkX5LTHgKIgOionNZAlOsgGovgwtXKydK/bskrfVc0QTGyjWkIQy3oMrj/Hhl/sNhZEJDmK7\n\tGvAQEIBCbt/QON2GMPoatD6CP","X-Received":["by 2002:a17:902:f54e:b0:16c:5119:d4a8 with SMTP id\n h14-20020a170902f54e00b0016c5119d4a8mr41391808plf.22.1658394881768;\n Thu, 21 Jul 2022 02:14:41 -0700 (PDT)","by 2002:a17:902:f54e:b0:16c:5119:d4a8 with SMTP id\n h14-20020a170902f54e00b0016c5119d4a8mr41391753plf.22.1658394881472;\n Thu, 21 Jul 2022 02:14:41 -0700 (PDT)"],"X-Google-Smtp-Source":"\n AGRyM1vZasibIAHQ47D1+cg3lbZlHNL9q45E+5hv7aYoBqQJppes7C+ekD1lr5quAazlbWW4qs7GdA==","Message-ID":"","Date":"Thu, 21 Jul 2022 17:14:29 +0800","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)\n Gecko/20100101 Thunderbird/91.11.0","Subject":"Re: [PATCH v12 26/40] virtio_ring: struct virtqueue introduce reset","To":"Xuan Zhuo ,\n virtualization@lists.linux-foundation.org","Cc":"Richard Weinberger ,\n Anton Ivanov ,\n Johannes Berg ,\n \"Michael S. Tsirkin\" , \"David S. Miller\"\n , Eric Dumazet ,\n Jakub Kicinski , Paolo Abeni ,\n Hans de Goede , Mark Gross ,\n Vadim Pasternak ,\n Bjorn Andersson ,\n Mathieu Poirier ,\n Cornelia Huck , Halil Pasic ,\n Eric Farman , Heiko Carstens ,\n Vasily Gorbik , Alexander Gordeev\n , Christian Borntraeger ,\n Sven Schnelle , Alexei Starovoitov ,\n Daniel Borkmann ,\n Jesper Dangaard Brouer ,\n John Fastabend ,\n Vincent Whitchurch ,\n linux-um@lists.infradead.org, netdev@vger.kernel.org,\n platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org,\n linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org,\n kangjie.xu@linux.alibaba.com","References":"<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>\n <20220720030436.79520-27-xuanzhuo@linux.alibaba.com>","From":"Jason Wang ","In-Reply-To":"<20220720030436.79520-27-xuanzhuo@linux.alibaba.com>","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20220721_021445_107210_B711AD75 ","X-CRM114-Status":"GOOD ( 15.81 )","X-Spam-Score":"-1.6 (-)","X-Spam-Report":"=?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?=\n\t=?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?=\n\t=?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?=\n\t=?unknown-8bit?q?ginal?=\n\t=?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?=\n\t=?unknown-8bit?q?bel?=\n\t=?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?=\n\t=?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_Content_preview=3A__=E5=9C=A8_2022/7/20_11=3A04=2C_Xuan_Zh?=\n\t=?unknown-8bit?q?uo_=E5=86=99=E9=81=93=3A_=3E_Introduce_a_new_member?=\n\t=?unknown-8bit?q?_reset_to_the_structure_virtqueue_to_determine_=3E_whether_?=\n\t=?unknown-8bit?q?the_current_vq_is?=\n\t=?unknown-8bit?q?_in_the_reset_state=2E_Subsequent_patches_will_=3E_use_it?=\n\t=?unknown-8bit?q?=2E_=3E_=3E_Sign_=5B=2E=2E=2E=5D_?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_Content_analysis_details=3A___=28-1=2E6_points=2C_5=2E0_re?=\n\t=?unknown-8bit?q?quired=29?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_pts_rule_name______________description?=\n\t=?unknown-8bit?q?_----_----------------------_------------------------------?=\n\t=?unknown-8bit?q?--------------------?=\n\t=?unknown-8bit?q?_-0=2E7_RCVD=5FIN=5FDNSWL=5FLOW______RBL=3A_Sender_listed_a?=\n\t=?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C?=\n\t=?unknown-8bit?q?_low_trust?=\n\t=?unknown-8bit?q?_=5B170=2E10=2E129=2E124_listed_in_list=2Ednswl=2Eorg=5D?=\n\t=?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?=\n\t=?unknown-8bit?q?ish_an_SPF_Record?=\n\t=?unknown-8bit?q?_0=2E0_SPF=5FNONE_______________SPF=3A_sender_does_not_publ?=\n\t=?unknown-8bit?q?ish_an_SPF_Record?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FAU__________Message_has_a_valid_DKIM?=\n\t=?unknown-8bit?q?_or_DK_signature_from?=\n\t=?unknown-8bit?q?_author=27s_domain?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?=\n\t=?unknown-8bit?q?alid_DKIM_or_DK_signature?=\n\t=?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?=\n\t=?unknown-8bit?q?gnature=2C_not_necessarily?=\n\t=?unknown-8bit?q?_valid?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FEF__________Message_has_a_valid_DKIM?=\n\t=?unknown-8bit?q?_or_DK_signature_from?=\n\t=?unknown-8bit?q?_envelope-from_domain?=\n\t=?unknown-8bit?q?_-0=2E5_NICE=5FREPLY=5FA___________Looks_like_a_legit_reply?=\n\t=?unknown-8bit?q?_=28A=29?=\n\t=?unknown-8bit?q?_-0=2E2_DKIMWL=5FWL=5FHIGH_________DKIMwl=2Eorg_-_High_trus?=\n\t=?unknown-8bit?q?t_sender?=","X-BeenThere":"linux-um@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Sender":"\"linux-um\" ","Errors-To":"linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]