[{"id":2936528,"web_url":"http://patchwork.ozlabs.org/comment/2936528/","msgid":"","list_archive_url":null,"date":"2022-07-21T09:14:10","subject":"Re: [PATCH v12 24/40] virtio: allow to unbreak/break virtqueue\n individually","submitter":{"id":5225,"url":"http://patchwork.ozlabs.org/api/people/5225/","name":"Jason Wang","email":"jasowang@redhat.com"},"content":"在 2022/7/20 11:04, Xuan Zhuo 写道:\n> This patch allows the new introduced\n> __virtqueue_break()/__virtqueue_unbreak() to break/unbreak the\n> virtqueue.\n>\n> Signed-off-by: Xuan Zhuo \n\n\nAcked-by: Jason Wang \n\n\n> ---\n> drivers/virtio/virtio_ring.c | 24 ++++++++++++++++++++++++\n> include/linux/virtio.h | 3 +++\n> 2 files changed, 27 insertions(+)\n>\n> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c\n> index cf4379175163..bf666dad9904 100644\n> --- a/drivers/virtio/virtio_ring.c\n> +++ b/drivers/virtio/virtio_ring.c\n> @@ -2730,6 +2730,30 @@ unsigned int virtqueue_get_vring_size(struct virtqueue *_vq)\n> }\n> EXPORT_SYMBOL_GPL(virtqueue_get_vring_size);\n> \n> +/*\n> + * This function should only be called by the core, not directly by the driver.\n> + */\n> +void __virtqueue_break(struct virtqueue *_vq)\n> +{\n> +\tstruct vring_virtqueue *vq = to_vvq(_vq);\n> +\n> +\t/* Pairs with READ_ONCE() in virtqueue_is_broken(). */\n> +\tWRITE_ONCE(vq->broken, true);\n> +}\n> +EXPORT_SYMBOL_GPL(__virtqueue_break);\n> +\n> +/*\n> + * This function should only be called by the core, not directly by the driver.\n> + */\n> +void __virtqueue_unbreak(struct virtqueue *_vq)\n> +{\n> +\tstruct vring_virtqueue *vq = to_vvq(_vq);\n> +\n> +\t/* Pairs with READ_ONCE() in virtqueue_is_broken(). */\n> +\tWRITE_ONCE(vq->broken, false);\n> +}\n> +EXPORT_SYMBOL_GPL(__virtqueue_unbreak);\n> +\n> bool virtqueue_is_broken(struct virtqueue *_vq)\n> {\n> \tstruct vring_virtqueue *vq = to_vvq(_vq);\n> diff --git a/include/linux/virtio.h b/include/linux/virtio.h\n> index 62e31bca5602..d45ee82a4470 100644\n> --- a/include/linux/virtio.h\n> +++ b/include/linux/virtio.h\n> @@ -138,6 +138,9 @@ bool is_virtio_device(struct device *dev);\n> void virtio_break_device(struct virtio_device *dev);\n> void __virtio_unbreak_device(struct virtio_device *dev);\n> \n> +void __virtqueue_break(struct virtqueue *_vq);\n> +void __virtqueue_unbreak(struct virtqueue *_vq);\n> +\n> void virtio_config_changed(struct virtio_device *dev);\n> #ifdef CONFIG_PM_SLEEP\n> int virtio_device_freeze(struct virtio_device *dev);","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=s0NbfYDV;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=VEsIW9UG;\n\tdkim-atps=neutral","ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=)","relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4LpRj82fRcz9s09\n\tfor ; Thu, 21 Jul 2022 19:14:36 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oESGJ-0035d7-Ui; Thu, 21 Jul 2022 09:14:27 +0000","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n\tby bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oESGH-0035bI-Qr\n\tfor linux-um@lists.infradead.org; Thu, 21 Jul 2022 09:14:27 +0000","from mail-pj1-f70.google.com (mail-pj1-f70.google.com\n [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-237-BkBRhQhsM5CwSQc7LNc-zQ-1; Thu, 21 Jul 2022 05:14:23 -0400","by mail-pj1-f70.google.com with SMTP id\n mi13-20020a17090b4b4d00b001ef9759d26aso3010396pjb.0\n for ;\n Thu, 21 Jul 2022 02:14:23 -0700 (PDT)","from [10.72.12.47] ([209.132.188.80])\n by smtp.gmail.com with ESMTPSA id\n l4-20020a170903244400b0016c454598b5sm1116942pls.167.2022.07.21.02.14.11\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 21 Jul 2022 02:14:20 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject:\n\tMIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=BKQCQlUIg9Brftdtb9gaOn6Il4trrVssJWYZ8fj11z4=; b=s0NbfYDVgqCEj0\n\tRoSLvZF/StbrViwvfV3nCr1Hm4iyr15KE2mxtCkn/Z4aIOWIAvEnSqnt5o0dbSm4tAqAwo3culG1W\n\ttJcx/4iyQ8d3swa1Cl3RRmFUntG2qUxWZDgVXHLT5JubZm2l6fb10Jt4U45F7wUWWbns5mkudhWV3\n\ttu2mCiJm/vhq+Xr8kt8qlfIP8Ipmuw5bvw2Q/NF5pdLQi/ewQknfSsk335wzch3qRniDaJ8vSWVHi\n\tm8Z5YE7iz6dLYWj4AMaL72UirQKf3IN0MaKEIa6XQpieaYEXOAAD78rDqWG69814oU37MDG42I/nh\n\tTCfWlQsAmw0kUaaAFlyA==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1658394864;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=ppSpnW8bYqIzLlwJTJe7LMpqbChLBLEyuLzj0jwDOCg=;\n\tb=VEsIW9UG0RAFm0+Cpb6g4Up5yJk2fw5OXClI+Qq38VR8kXTeZtDqWJnab2lnGYSQJl/xMb\n\tNLXpSHIL3G28Z9+j7GCpjkaAKj0+ZhQ9wZYAQU3xijqLG6mUR48Ya3WQLV3cTwlD/nRjzf\n\towSAS0web1ILpP11FEs0eTtH4uZCCpQ="],"X-MC-Unique":"BkBRhQhsM5CwSQc7LNc-zQ-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:message-id:date:mime-version:user-agent:subject\n :content-language:to:cc:references:from:in-reply-to\n :content-transfer-encoding;\n bh=ppSpnW8bYqIzLlwJTJe7LMpqbChLBLEyuLzj0jwDOCg=;\n b=wrP4xNaEdrp4WB5NvHhL3H1GR7RDsgfdjEeO5ck2WgxmBl3/OjW+V4+hkptbWsvvec\n +9Sp1cIB5xH37znybbCilBpehPgod12Ufk0Qfy+kdPN+a9hvPZltIHQjvHKG18OZ1SGh\n ea3DDC348I3HguwRj3FGEr1x0zRaQrfV5BqFhzliF3FqOZis6eWzyF578JHnlyiMBPTF\n xlCfnrk2flZKxA3IdJKX+XSjmjsi69bEYV7TnEjNrd9V/qrlqqE1giFIGep6wVBMsYmS\n 6y/Pz+kRRprAOcqpGeNxr8KJi7H3PjLHXDfVVpIg4kcQM/boqqlp3QmyupciJHkpr9zp\n nHQw==","X-Gm-Message-State":"AJIora/UQeW5vUoAtD62AZT33LSkBW5KR4Juf8I5mpSemAkRfesNwSm8\n\thwumRv/w0woBbPZZlTpA7ntUkr1qtGva4lCQtQNz32yAHBQUGvyXZkQ1WTAJP+8PKQPtC0yaAAu\n\tbvSMQlWmOTB7Oz3gPVWjWI7v1","X-Received":["by 2002:a17:902:ab0e:b0:16d:e87:ce8d with SMTP id\n ik14-20020a170902ab0e00b0016d0e87ce8dmr12288653plb.53.1658394861560;\n Thu, 21 Jul 2022 02:14:21 -0700 (PDT)","by 2002:a17:902:ab0e:b0:16d:e87:ce8d with SMTP id\n ik14-20020a170902ab0e00b0016d0e87ce8dmr12288621plb.53.1658394861264;\n Thu, 21 Jul 2022 02:14:21 -0700 (PDT)"],"X-Google-Smtp-Source":"\n AGRyM1tdQQvXxoAsILo5kGUhAyFtFd7+hyXAVcy5eO+xsnDpHiLynC44NTrLJew4cMcMMUejlOtfhg==","Message-ID":"","Date":"Thu, 21 Jul 2022 17:14:10 +0800","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)\n Gecko/20100101 Thunderbird/91.11.0","Subject":"Re: [PATCH v12 24/40] virtio: allow to unbreak/break virtqueue\n individually","To":"Xuan Zhuo ,\n virtualization@lists.linux-foundation.org","Cc":"Richard Weinberger ,\n Anton Ivanov ,\n Johannes Berg ,\n \"Michael S. Tsirkin\" , \"David S. Miller\"\n , Eric Dumazet ,\n Jakub Kicinski , Paolo Abeni ,\n Hans de Goede , Mark Gross ,\n Vadim Pasternak ,\n Bjorn Andersson ,\n Mathieu Poirier ,\n Cornelia Huck , Halil Pasic ,\n Eric Farman , Heiko Carstens ,\n Vasily Gorbik , Alexander Gordeev\n , Christian Borntraeger ,\n Sven Schnelle , Alexei Starovoitov ,\n Daniel Borkmann ,\n Jesper Dangaard Brouer ,\n John Fastabend ,\n Vincent Whitchurch ,\n linux-um@lists.infradead.org, netdev@vger.kernel.org,\n platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org,\n linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org,\n kangjie.xu@linux.alibaba.com","References":"<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>\n <20220720030436.79520-25-xuanzhuo@linux.alibaba.com>","From":"Jason Wang ","In-Reply-To":"<20220720030436.79520-25-xuanzhuo@linux.alibaba.com>","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20220721_021425_965569_96188C49 ","X-CRM114-Status":"GOOD ( 16.62 )","X-Spam-Score":"-1.6 (-)","X-Spam-Report":"=?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?=\n\t=?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?=\n\t=?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?=\n\t=?unknown-8bit?q?ginal?=\n\t=?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?=\n\t=?unknown-8bit?q?bel?=\n\t=?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?=\n\t=?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?b?IENvbnRlbnQgcHJldmlldzogIOWcqCAyMDIyLzcvMjAgMTE6MDQsIFh1?=\n\t=?unknown-8bit?b?YW4gWmh1byDlhpnpgZM6ID4gVGhpcyBwYXRjaCBhbGxvd3M=?=\n\t=?unknown-8bit?q?_the_new_introduced_=3E_=5F=5Fvirtqueue=5Fbreak=28=29/=5F?=\n\t=?unknown-8bit?q?=5Fvirtqueue=5Funbreak=28=29_to_break/unbreak?=\n\t=?unknown-8bit?b?IHRoZSA+IHZpcnRxdWV1ZS4gPiA+IFNpZ25lZC1vZmYtYnk6IFh1YW4g?=\n\t=?unknown-8bit?b?Wmh1byA8eHVhbnpodW9AbGludXggWy4uLl0g?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_Content_analysis_details=3A___=28-1=2E6_points=2C_5=2E0_re?=\n\t=?unknown-8bit?q?quired=29?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_pts_rule_name______________description?=\n\t=?unknown-8bit?q?_----_----------------------_------------------------------?=\n\t=?unknown-8bit?q?--------------------?=\n\t=?unknown-8bit?q?_-0=2E7_RCVD=5FIN=5FDNSWL=5FLOW______RBL=3A_Sender_listed_a?=\n\t=?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C?=\n\t=?unknown-8bit?q?_low_trust?=\n\t=?unknown-8bit?q?_=5B170=2E10=2E129=2E124_listed_in_list=2Ednswl=2Eorg=5D?=\n\t=?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?=\n\t=?unknown-8bit?q?ish_an_SPF_Record?=\n\t=?unknown-8bit?q?_0=2E0_SPF=5FNONE_______________SPF=3A_sender_does_not_publ?=\n\t=?unknown-8bit?q?ish_an_SPF_Record?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FAU__________Message_has_a_valid_DKIM?=\n\t=?unknown-8bit?q?_or_DK_signature_from?=\n\t=?unknown-8bit?q?_author=27s_domain?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?=\n\t=?unknown-8bit?q?alid_DKIM_or_DK_signature?=\n\t=?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?=\n\t=?unknown-8bit?q?gnature=2C_not_necessarily?=\n\t=?unknown-8bit?q?_valid?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FEF__________Message_has_a_valid_DKIM?=\n\t=?unknown-8bit?q?_or_DK_signature_from?=\n\t=?unknown-8bit?q?_envelope-from_domain?=\n\t=?unknown-8bit?q?_-0=2E5_NICE=5FREPLY=5FA___________Looks_like_a_legit_reply?=\n\t=?unknown-8bit?q?_=28A=29?=\n\t=?unknown-8bit?q?_-0=2E2_DKIMWL=5FWL=5FHIGH_________DKIMwl=2Eorg_-_High_trus?=\n\t=?unknown-8bit?q?t_sender?=","X-BeenThere":"linux-um@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Sender":"\"linux-um\" ","Errors-To":"linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]