[{"id":2936532,"web_url":"http://patchwork.ozlabs.org/comment/2936532/","msgid":"<14c8469c-8609-78c6-308e-a00051634ce6@redhat.com>","list_archive_url":null,"date":"2022-07-21T09:15:34","subject":"Re: [PATCH v12 22/40] virtio_ring: introduce virtqueue_resize()","submitter":{"id":5225,"url":"http://patchwork.ozlabs.org/api/people/5225/","name":"Jason Wang","email":"jasowang@redhat.com"},"content":"在 2022/7/20 11:04, Xuan Zhuo 写道:\n> Introduce virtqueue_resize() to implement the resize of vring.\n> Based on these, the driver can dynamically adjust the size of the vring.\n> For example: ethtool -G.\n>\n> virtqueue_resize() implements resize based on the vq reset function. In\n> case of failure to allocate a new vring, it will give up resize and use\n> the original vring.\n>\n> During this process, if the re-enable reset vq fails, the vq can no\n> longer be used. Although the probability of this situation is not high.\n>\n> The parameter recycle is used to recycle the buffer that is no longer\n> used.\n>\n> Signed-off-by: Xuan Zhuo \n\n\nAcked-by: Jason Wang \n\n\n> ---\n> drivers/virtio/virtio_ring.c | 69 ++++++++++++++++++++++++++++++++++++\n> include/linux/virtio.h | 3 ++\n> 2 files changed, 72 insertions(+)\n>\n> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c\n> index b092914e9dcd..cf4379175163 100644\n> --- a/drivers/virtio/virtio_ring.c\n> +++ b/drivers/virtio/virtio_ring.c\n> @@ -2545,6 +2545,75 @@ struct virtqueue *vring_create_virtqueue(\n> }\n> EXPORT_SYMBOL_GPL(vring_create_virtqueue);\n> \n> +/**\n> + * virtqueue_resize - resize the vring of vq\n> + * @_vq: the struct virtqueue we're talking about.\n> + * @num: new ring num\n> + * @recycle: callback for recycle the useless buffer\n> + *\n> + * When it is really necessary to create a new vring, it will set the current vq\n> + * into the reset state. Then call the passed callback to recycle the buffer\n> + * that is no longer used. Only after the new vring is successfully created, the\n> + * old vring will be released.\n> + *\n> + * Caller must ensure we don't call this with other virtqueue operations\n> + * at the same time (except where noted).\n> + *\n> + * Returns zero or a negative error.\n> + * 0: success.\n> + * -ENOMEM: Failed to allocate a new ring, fall back to the original ring size.\n> + * vq can still work normally\n> + * -EBUSY: Failed to sync with device, vq may not work properly\n> + * -ENOENT: Transport or device not supported\n> + * -E2BIG/-EINVAL: num error\n> + * -EPERM: Operation not permitted\n> + *\n> + */\n> +int virtqueue_resize(struct virtqueue *_vq, u32 num,\n> +\t\t void (*recycle)(struct virtqueue *vq, void *buf))\n> +{\n> +\tstruct vring_virtqueue *vq = to_vvq(_vq);\n> +\tstruct virtio_device *vdev = vq->vq.vdev;\n> +\tvoid *buf;\n> +\tint err;\n> +\n> +\tif (!vq->we_own_ring)\n> +\t\treturn -EPERM;\n> +\n> +\tif (num > vq->vq.num_max)\n> +\t\treturn -E2BIG;\n> +\n> +\tif (!num)\n> +\t\treturn -EINVAL;\n> +\n> +\tif ((vq->packed_ring ? vq->packed.vring.num : vq->split.vring.num) == num)\n> +\t\treturn 0;\n> +\n> +\tif (!vdev->config->disable_vq_and_reset)\n> +\t\treturn -ENOENT;\n> +\n> +\tif (!vdev->config->enable_vq_after_reset)\n> +\t\treturn -ENOENT;\n> +\n> +\terr = vdev->config->disable_vq_and_reset(_vq);\n> +\tif (err)\n> +\t\treturn err;\n> +\n> +\twhile ((buf = virtqueue_detach_unused_buf(_vq)) != NULL)\n> +\t\trecycle(_vq, buf);\n> +\n> +\tif (vq->packed_ring)\n> +\t\terr = virtqueue_resize_packed(_vq, num);\n> +\telse\n> +\t\terr = virtqueue_resize_split(_vq, num);\n> +\n> +\tif (vdev->config->enable_vq_after_reset(_vq))\n> +\t\treturn -EBUSY;\n> +\n> +\treturn err;\n> +}\n> +EXPORT_SYMBOL_GPL(virtqueue_resize);\n> +\n> /* Only available for split ring */\n> struct virtqueue *vring_new_virtqueue(unsigned int index,\n> \t\t\t\t unsigned int num,\n> diff --git a/include/linux/virtio.h b/include/linux/virtio.h\n> index 129bde7521e3..62e31bca5602 100644\n> --- a/include/linux/virtio.h\n> +++ b/include/linux/virtio.h\n> @@ -91,6 +91,9 @@ dma_addr_t virtqueue_get_desc_addr(struct virtqueue *vq);\n> dma_addr_t virtqueue_get_avail_addr(struct virtqueue *vq);\n> dma_addr_t virtqueue_get_used_addr(struct virtqueue *vq);\n> \n> +int virtqueue_resize(struct virtqueue *vq, u32 num,\n> +\t\t void (*recycle)(struct virtqueue *vq, void *buf));\n> +\n> /**\n> * virtio_device - representation of a device using virtio\n> * @index: unique position on the virtio bus","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=3i79KGur;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=d/ehNjZ6;\n\tdkim-atps=neutral","ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=)","relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4LpRks2MHCz9s09\n\tfor ; Thu, 21 Jul 2022 19:16:05 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oESHk-0036ns-B5; Thu, 21 Jul 2022 09:15:56 +0000","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n\tby bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oESHh-0036lT-6Y\n\tfor linux-um@lists.infradead.org; Thu, 21 Jul 2022 09:15:54 +0000","from mail-pl1-f197.google.com (mail-pl1-f197.google.com\n [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-317-ruLljifMPv-OvmGXXra6Yg-1; Thu, 21 Jul 2022 05:15:51 -0400","by mail-pl1-f197.google.com with SMTP id\n c18-20020a170903235200b0016c37f6d48cso858899plh.19\n for ;\n Thu, 21 Jul 2022 02:15:51 -0700 (PDT)","from [10.72.12.47] ([209.132.188.80])\n by smtp.gmail.com with ESMTPSA id\n p4-20020a634204000000b0041239bf9be8sm1036316pga.1.2022.07.21.02.15.35\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 21 Jul 2022 02:15:48 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject:\n\tMIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=6av5+JjEE+PD0tmKJd1eocOrA8G8N8n4AFLwKbKfXIs=; b=3i79KGurEIQxwV\n\teNzKLQ5PsoQQ7YWB6wFAnlC4L3nD3M916sts0HPkv14mfZjBVuJv4DAb3ohrSSg5bmx/9CUe9y/y3\n\tXW1nAYjFMeilHxbAFvVZk3Fznkn7/2U1szfN7qGJL9so6X8Uri33wTSgYWpL+SCRnq0WuOGtNwL9y\n\tZTk5iXG4O5U7L1qw3dspMG8qFV14wT8QSxB4EiCfbxGCEG3U1ovlwbgSejBahe/2S9yiCOTfAiqpy\n\tE1NoTvuNJyzb9vyBQXeb5SqtNvBIbytzM+sYB27eYqhJIHL3NbInqnUNNq3Bd5HzUpPBK8ogmNTVK\n\tb2hZ+YFTs4QXbSLZ9m/A==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1658394952;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=Escg7n0ywUK4qdukC0pSCylFb7FUJQPzR61HHZ9/jsk=;\n\tb=d/ehNjZ64wAHF5E//3qcbIZXxYhLEFInZCHKb0GfqPnTsSOS5jw49d9WUIxU5efUmiE7dx\n\t1tzKZl51OPIUeCbb/hzECST5lS0/SQDz13CXJxiutN5GzUAwnUBZcRUwXNYX1KN48L9y4X\n\tfhVwBbJLWc3ITGWC/sFwQA/YexzwTCw="],"X-MC-Unique":"ruLljifMPv-OvmGXXra6Yg-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:message-id:date:mime-version:user-agent:subject\n :content-language:to:cc:references:from:in-reply-to\n :content-transfer-encoding;\n bh=Escg7n0ywUK4qdukC0pSCylFb7FUJQPzR61HHZ9/jsk=;\n b=NuFZqyZSRgSiYtH/v3qZEDCiCcBe+AWpGE20UF29jIORO3iKx2b3u1JSF5zKaw9LWE\n 1/Hip3IlexhsoS6P8MsU1m5NLqFFBL4VWsYQC9lOogO1cyb3hd6Cb+5iUDuSdex4sUes\n BFqzY5qAEB+mtkgtJ5T6DK2/Wvm29hflL1aRVfJ/CKoGDqkiyM60XkvV5HLBQlgODoKA\n UwThnvVLCu32B080bHdW6Vw/fV9O5OdX//HyyX45oWaIWThUtzlbjVXcmFhUipz3/LGE\n jFvq+K7aTYEmieeB8ldvfVEEaLxyrww3atQlEhDpKKhx4MnYfOONATFjLd7A5vFdgaVL\n n5fQ==","X-Gm-Message-State":"AJIora9qeY0nLUYuMLSVOVPLb2JSI/o+ox39fKbz3qiurU66lcMfcxIo\n\tr8Bg+KQv9XodpmEbynM4TlJJrqacfczNu+wQ7DUP0+WX9tOsUDLBlSmKXOSZPqAgGB7d8qrofdw\n\tIuHdmf9vU2Z8JEmAgrPjpKGd7","X-Received":["by 2002:a05:6a00:188e:b0:52a:b545:559f with SMTP id\n x14-20020a056a00188e00b0052ab545559fmr43170861pfh.18.1658394949131;\n Thu, 21 Jul 2022 02:15:49 -0700 (PDT)","by 2002:a05:6a00:188e:b0:52a:b545:559f with SMTP id\n x14-20020a056a00188e00b0052ab545559fmr43170831pfh.18.1658394948796;\n Thu, 21 Jul 2022 02:15:48 -0700 (PDT)"],"X-Google-Smtp-Source":"\n AGRyM1tse0avmLLaWWihH80dsCqYgwTb5M+a/h7oTDBCS5V2QWyEFXUICi4yWw1kN7K6oki4/v7zfQ==","Message-ID":"<14c8469c-8609-78c6-308e-a00051634ce6@redhat.com>","Date":"Thu, 21 Jul 2022 17:15:34 +0800","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)\n Gecko/20100101 Thunderbird/91.11.0","Subject":"Re: [PATCH v12 22/40] virtio_ring: introduce virtqueue_resize()","To":"Xuan Zhuo ,\n virtualization@lists.linux-foundation.org","Cc":"Richard Weinberger ,\n Anton Ivanov ,\n Johannes Berg ,\n \"Michael S. Tsirkin\" , \"David S. Miller\"\n , Eric Dumazet ,\n Jakub Kicinski , Paolo Abeni ,\n Hans de Goede , Mark Gross ,\n Vadim Pasternak ,\n Bjorn Andersson ,\n Mathieu Poirier ,\n Cornelia Huck , Halil Pasic ,\n Eric Farman , Heiko Carstens ,\n Vasily Gorbik , Alexander Gordeev\n , Christian Borntraeger ,\n Sven Schnelle , Alexei Starovoitov ,\n Daniel Borkmann ,\n Jesper Dangaard Brouer ,\n John Fastabend ,\n Vincent Whitchurch ,\n linux-um@lists.infradead.org, netdev@vger.kernel.org,\n platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org,\n linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org,\n kangjie.xu@linux.alibaba.com","References":"<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>\n <20220720030436.79520-23-xuanzhuo@linux.alibaba.com>","From":"Jason Wang ","In-Reply-To":"<20220720030436.79520-23-xuanzhuo@linux.alibaba.com>","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20220721_021553_354797_BB03C9E4 ","X-CRM114-Status":"GOOD ( 25.72 )","X-Spam-Score":"-1.6 (-)","X-Spam-Report":"=?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?=\n\t=?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?=\n\t=?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?=\n\t=?unknown-8bit?q?ginal?=\n\t=?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?=\n\t=?unknown-8bit?q?bel?=\n\t=?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?=\n\t=?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?b?IENvbnRlbnQgcHJldmlldzogIOWcqCAyMDIyLzcvMjAgMTE6MDQsIFh1?=\n\t=?unknown-8bit?b?YW4gWmh1byDlhpnpgZM6ID4gSW50cm9kdWNlIHZpcnRxdWV1ZV9yZXNp?=\n\t=?unknown-8bit?b?emUoKQ==?=\n\t=?unknown-8bit?q?_to_implement_the_resize_of_vring=2E_=3E_Based_on_these=2C_?=\n\t=?unknown-8bit?q?the_driver_can_dynamically?=\n\t=?unknown-8bit?q?_adjust_the_size_of_the_vring=2E_=3E_For_example=3A_ethtoo_?=\n\t=?unknown-8bit?q?=5B=2E=2E=2E=5D_?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_Content_analysis_details=3A___=28-1=2E6_points=2C_5=2E0_re?=\n\t=?unknown-8bit?q?quired=29?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_pts_rule_name______________description?=\n\t=?unknown-8bit?q?_----_----------------------_------------------------------?=\n\t=?unknown-8bit?q?--------------------?=\n\t=?unknown-8bit?q?_-0=2E7_RCVD=5FIN=5FDNSWL=5FLOW______RBL=3A_Sender_listed_a?=\n\t=?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C?=\n\t=?unknown-8bit?q?_low_trust?=\n\t=?unknown-8bit?q?_=5B170=2E10=2E129=2E124_listed_in_list=2Ednswl=2Eorg=5D?=\n\t=?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?=\n\t=?unknown-8bit?q?ish_an_SPF_Record?=\n\t=?unknown-8bit?q?_0=2E0_SPF=5FNONE_______________SPF=3A_sender_does_not_publ?=\n\t=?unknown-8bit?q?ish_an_SPF_Record?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FAU__________Message_has_a_valid_DKIM?=\n\t=?unknown-8bit?q?_or_DK_signature_from?=\n\t=?unknown-8bit?q?_author=27s_domain?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?=\n\t=?unknown-8bit?q?alid_DKIM_or_DK_signature?=\n\t=?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?=\n\t=?unknown-8bit?q?gnature=2C_not_necessarily?=\n\t=?unknown-8bit?q?_valid?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FEF__________Message_has_a_valid_DKIM?=\n\t=?unknown-8bit?q?_or_DK_signature_from?=\n\t=?unknown-8bit?q?_envelope-from_domain?=\n\t=?unknown-8bit?q?_-0=2E5_NICE=5FREPLY=5FA___________Looks_like_a_legit_reply?=\n\t=?unknown-8bit?q?_=28A=29?=\n\t=?unknown-8bit?q?_-0=2E2_DKIMWL=5FWL=5FHIGH_________DKIMwl=2Eorg_-_High_trus?=\n\t=?unknown-8bit?q?t_sender?=","X-BeenThere":"linux-um@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Sender":"\"linux-um\" ","Errors-To":"linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]