[{"id":2936416,"web_url":"http://patchwork.ozlabs.org/comment/2936416/","msgid":"","list_archive_url":null,"date":"2022-07-21T07:08:44","subject":"Re: [PATCH v12 07/40] virtio_ring: split: introduce\n vring_free_split()","submitter":{"id":5225,"url":"http://patchwork.ozlabs.org/api/people/5225/","name":"Jason Wang","email":"jasowang@redhat.com"},"content":"在 2022/7/20 11:04, Xuan Zhuo 写道:\n> Free the structure struct vring_vritqueue_split.\n>\n> Subsequent patches require it.\n>\n> Signed-off-by: Xuan Zhuo \n\n\nAcked-by: Jason Wang \n\n\n> ---\n> drivers/virtio/virtio_ring.c | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n>\n> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c\n> index 87ce17562b29..c94c5461e702 100644\n> --- a/drivers/virtio/virtio_ring.c\n> +++ b/drivers/virtio/virtio_ring.c\n> @@ -939,6 +939,17 @@ static void *virtqueue_detach_unused_buf_split(struct virtqueue *_vq)\n> \treturn NULL;\n> }\n> \n> +static void vring_free_split(struct vring_virtqueue_split *vring_split,\n> +\t\t\t struct virtio_device *vdev)\n> +{\n> +\tvring_free_queue(vdev, vring_split->queue_size_in_bytes,\n> +\t\t\t vring_split->vring.desc,\n> +\t\t\t vring_split->queue_dma_addr);\n> +\n> +\tkfree(vring_split->desc_state);\n> +\tkfree(vring_split->desc_extra);\n> +}\n> +\n> static struct virtqueue *vring_create_virtqueue_split(\n> \tunsigned int index,\n> \tunsigned int num,","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=UGyqUO9g;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Do7a/N7N;\n\tdkim-atps=neutral","ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=)","relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4LpNwR6z7Xz9s2R\n\tfor ; Thu, 21 Jul 2022 17:09:11 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oEQIv-001Uj1-FX; Thu, 21 Jul 2022 07:09:01 +0000","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n\tby bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oEQIt-001UgJ-2m\n\tfor linux-um@lists.infradead.org; Thu, 21 Jul 2022 07:09:00 +0000","from mail-pl1-f197.google.com (mail-pl1-f197.google.com\n [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-274-r4bsYKt-OmKFpEjF0F3Kgw-1; Thu, 21 Jul 2022 03:08:57 -0400","by mail-pl1-f197.google.com with SMTP id\n b10-20020a170902d50a00b0016c56d1f90fso696595plg.21\n for ;\n Thu, 21 Jul 2022 00:08:56 -0700 (PDT)","from [10.72.12.47] ([209.132.188.80])\n by smtp.gmail.com with ESMTPSA id\n 82-20020a621455000000b0052bae7b2af8sm862397pfu.201.2022.07.21.00.08.45\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 21 Jul 2022 00:08:54 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject:\n\tMIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=XtFUQgXUf8osM/rQNfYOI+ljvaOlCLlNsz+nOM/DmHg=; b=UGyqUO9geSXpQY\n\tKLWbEka2m7dYXlsIMBFwTNLvAO9ZLI5CJHS5qY/6ctfk3Mauxm3O8FwoxW7HvNhiRDgcYqnYZInCI\n\tr2hmjNkz0dwSRtIxsBsIvVbc1Y3s5HGevsMi6hFbd092g5xnXqMa7b85AuW40xQkAZd5ItaZpmcB/\n\ttSzr8he0Gk/PLV1Ilhwgz7OqLP6MoeO+F1qtvZ38Q4PxbJZeRFS97PAur56m6gr4SthX5vGQBDlvd\n\tn/wpmODpm9n6uWlRdP6Az9cgE0A110V6EairC1I3vjPqKFhulc/cvpjn++23skwTNddLL57L+qi2D\n\tlkr2gwGC3MOHqobGs2gA==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1658387338;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=20XB7X4uMFrdCQowchk09EqnsM7R3g6B8Dxeh2uQp8M=;\n\tb=Do7a/N7NIGRItx61IRnl6DoU+PQsIJQgkpKehBFhpIDGecdXcUMwMwdW+WX3ZT7AEdXyJH\n\tGDMeeHRu35q7/nzKVpBaGRc6uOF5HqEJYiXK2P2HStX8QCCpnzXzxlXiOC0nrdKNockDHt\n\txqndSTd/5vAc1MCuJko+kMB5h2s4oYE="],"X-MC-Unique":"r4bsYKt-OmKFpEjF0F3Kgw-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:message-id:date:mime-version:user-agent:subject\n :content-language:to:cc:references:from:in-reply-to\n :content-transfer-encoding;\n bh=20XB7X4uMFrdCQowchk09EqnsM7R3g6B8Dxeh2uQp8M=;\n b=U39r5tTH94UEX+A7zd44TiBZpxsO1Jkei5G1LTZviG7Vgk3Md1wN+HyO3Op0tm7V6N\n pqpokVxxGbArfK5fjkKh38FyKmwy0/lKdspvN6Xd5jg4nkQtsRqWnRFxiVKeL4QHssNL\n b+bpDljGMEj2dndRm3eBYXpYZKRWVQrf6IwBmZ5YAyvlAI3q26lyO+ArRGqkMdUnpAAN\n 7853OscXIQf/+0xkuQC3lftHWZlZvs0M41Il4OQjXvjA22WJyHzwC/7nn1FnD2EQxu+A\n ohVIKB8Qbd2GItHZXH8qBVP/vtsiNLuemr2Q9X6xzDdSDsTLmPjgcakwCh6x1h4qcayE\n rLZQ==","X-Gm-Message-State":"AJIora8i8vz6b3h9T5aG9wNRxohLgf0BPl5ITQDchNK9x9JqveRRSBTj\n\tUo/e1GCwEcKkPiqRBVefucXpqEP6+Vj/M1MMfwuH2m4IKcP4j2Fqkl/quQh/og+wrzVa1nSTdo9\n\twkrag4lFs819W2GDcquYv94dx","X-Received":["by 2002:a05:6a00:998:b0:52a:db4c:541b with SMTP id\n u24-20020a056a00099800b0052adb4c541bmr42860421pfg.35.1658387335771;\n Thu, 21 Jul 2022 00:08:55 -0700 (PDT)","by 2002:a05:6a00:998:b0:52a:db4c:541b with SMTP id\n u24-20020a056a00099800b0052adb4c541bmr42860380pfg.35.1658387335468;\n Thu, 21 Jul 2022 00:08:55 -0700 (PDT)"],"X-Google-Smtp-Source":"\n AGRyM1uJ7ogdlWO9wq9dujWOVNZNut2Pk1AGg7QtSX4Ep4NpLAUcMg6IEWg7tcD5uQIK4LSqmKQ0RA==","Message-ID":"","Date":"Thu, 21 Jul 2022 15:08:44 +0800","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)\n Gecko/20100101 Thunderbird/91.11.0","Subject":"Re: [PATCH v12 07/40] virtio_ring: split: introduce\n vring_free_split()","To":"Xuan Zhuo ,\n virtualization@lists.linux-foundation.org","Cc":"Richard Weinberger ,\n Anton Ivanov ,\n Johannes Berg ,\n \"Michael S. Tsirkin\" , \"David S. Miller\"\n , Eric Dumazet ,\n Jakub Kicinski , Paolo Abeni ,\n Hans de Goede , Mark Gross ,\n Vadim Pasternak ,\n Bjorn Andersson ,\n Mathieu Poirier ,\n Cornelia Huck , Halil Pasic ,\n Eric Farman , Heiko Carstens ,\n Vasily Gorbik , Alexander Gordeev\n , Christian Borntraeger ,\n Sven Schnelle , Alexei Starovoitov ,\n Daniel Borkmann ,\n Jesper Dangaard Brouer ,\n John Fastabend ,\n Vincent Whitchurch ,\n linux-um@lists.infradead.org, netdev@vger.kernel.org,\n platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org,\n linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org,\n kangjie.xu@linux.alibaba.com","References":"<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>\n <20220720030436.79520-8-xuanzhuo@linux.alibaba.com>","From":"Jason Wang ","In-Reply-To":"<20220720030436.79520-8-xuanzhuo@linux.alibaba.com>","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20220721_000859_220605_B9818F08 ","X-CRM114-Status":"GOOD ( 12.65 )","X-Spam-Score":"-0.9 (/)","X-Spam-Report":"=?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?=\n\t=?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?=\n\t=?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?=\n\t=?unknown-8bit?q?ginal?=\n\t=?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?=\n\t=?unknown-8bit?q?bel?=\n\t=?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?=\n\t=?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?b?IENvbnRlbnQgcHJldmlldzogIOWcqCAyMDIyLzcvMjAgMTE6MDQsIFh1?=\n\t=?unknown-8bit?b?YW4gWmh1byDlhpnpgZM6ID4gRnJlZSB0aGUgc3RydWN0dXJl?=\n\t=?unknown-8bit?q?_struct_vring=5Fvritqueue=5Fsplit=2E_=3E_=3E_Subsequent_pat?=\n\t=?unknown-8bit?q?ches_require_it=2E_=3E_=3E_Signed-off-by=3A?=\n\t=?unknown-8bit?q?_Xuan_Zhuo_=3Cxuanzhuo=40linux=2Ealibaba=2Ecom=3E_Acked-by?=\n\t=?unknown-8bit?q?=3A_Jason_Wang_=3Cjasowang=40redhat=2Ecom=3E?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_Content_analysis_details=3A___=28-0=2E9_points=2C_5=2E0_re?=\n\t=?unknown-8bit?q?quired=29?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_pts_rule_name______________description?=\n\t=?unknown-8bit?q?_----_----------------------_------------------------------?=\n\t=?unknown-8bit?q?--------------------?=\n\t=?unknown-8bit?q?_-0=2E0_RCVD=5FIN=5FDNSWL=5FNONE_____RBL=3A_Sender_listed_a?=\n\t=?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C?=\n\t=?unknown-8bit?q?_no_trust?=\n\t=?unknown-8bit?q?_=5B170=2E10=2E133=2E124_listed_in_list=2Ednswl=2Eorg=5D?=\n\t=?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?=\n\t=?unknown-8bit?q?ish_an_SPF_Record?=\n\t=?unknown-8bit?q?_0=2E0_SPF=5FNONE_______________SPF=3A_sender_does_not_publ?=\n\t=?unknown-8bit?q?ish_an_SPF_Record?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FAU__________Message_has_a_valid_DKIM?=\n\t=?unknown-8bit?q?_or_DK_signature_from?=\n\t=?unknown-8bit?q?_author=27s_domain?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?=\n\t=?unknown-8bit?q?alid_DKIM_or_DK_signature?=\n\t=?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?=\n\t=?unknown-8bit?q?gnature=2C_not_necessarily?=\n\t=?unknown-8bit?q?_valid?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FEF__________Message_has_a_valid_DKIM?=\n\t=?unknown-8bit?q?_or_DK_signature_from?=\n\t=?unknown-8bit?q?_envelope-from_domain?=\n\t=?unknown-8bit?q?_-0=2E5_NICE=5FREPLY=5FA___________Looks_like_a_legit_reply?=\n\t=?unknown-8bit?q?_=28A=29?=\n\t=?unknown-8bit?q?_-0=2E2_DKIMWL=5FWL=5FHIGH_________DKIMwl=2Eorg_-_High_trus?=\n\t=?unknown-8bit?q?t_sender?=","X-BeenThere":"linux-um@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Sender":"\"linux-um\" ","Errors-To":"linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]