[{"id":2912960,"web_url":"http://patchwork.ozlabs.org/comment/2912960/","msgid":"<20220614221658.GA2823453-robh@kernel.org>","list_archive_url":null,"date":"2022-06-14T22:16:58","subject":"Re: [PATCH v4 02/23] dt-bindings: ata: ahci-platform: Detach common\n AHCI bindings","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Fri, 10 Jun 2022 11:17:40 +0300, Serge Semin wrote:\n> In order to create a more sophisticated AHCI controller DT bindings let's\n> divide the already available generic AHCI platform YAML schema into the\n> platform part and a set of the common AHCI properties. The former part\n> will be used to evaluate the AHCI DT nodes mainly compatible with the\n> generic AHCI controller while the later schema will be used for more\n> thorough AHCI DT nodes description. For instance such YAML schemas design\n> will be useful for our DW AHCI SATA controller derivative with four clock\n> sources, two reset lines, one system controller reference and specific\n> max Rx/Tx DMA xfers size constraints.\n> \n> Note the phys and target-supply property requirement is preserved in the\n> generic AHCI platform bindings because some platforms can lack of the\n> explicitly specified PHYs or target device power regulators.\n> \n> Also note the SATA/AHCI ports properties have been moved to the\n> $defs-paragraph of the schemas. It's done in order to create the\n> extendable properties hierarchy such that particular AHCI-controller\n> could add vendor-specific port properties.\n> \n> Signed-off-by: Serge Semin \n> \n> ---\n> \n> Folks, I don't really see why the phys/target-supply requirement has been\n> added to the generic AHCI DT schema in the first place. Probably just to\n> imply some meaning for the sub-nodes definition. Anyway in one of the\n> further patches I am adding the DW AHCI SATA controller DT bindings which\n> won't require having these properties specified in the sub-nodes, but will\n> describe additional port-specific properties. That's why I get to keep the\n> constraints in the ahci-platform.yaml schema instead of moving them to the\n> common schema.\n> \n> Changelog v2:\n> - This is a new patch created after rebasing v1 onto the 5.18-rc3 kernel.\n> \n> Changelog v3:\n> - Replace Jens's email address with Damien's one in the list of the\n> schema maintainers. (@Damien)\n> \n> Changelog v4:\n> - Drop clocks, clock-names, resets, reset-names and power-domains\n> properties from the common schema. (@Rob)\n> - Create sata/ahci-port properties definition hierarchy so the sub-schemas\n> would inherit and extend the ports properties of the super-schema. (@Rob)\n> ---\n> .../devicetree/bindings/ata/ahci-common.yaml | 100 ++++++++++++++++++\n> .../bindings/ata/ahci-platform.yaml | 72 ++-----------\n> .../devicetree/bindings/ata/sata-common.yaml | 8 +-\n> 3 files changed, 115 insertions(+), 65 deletions(-)\n> create mode 100644 Documentation/devicetree/bindings/ata/ahci-common.yaml\n> \n\nReviewed-by: Rob Herring ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2620:137:e000::1:20; helo=out1.vger.email;\n envelope-from=linux-ide-owner@vger.kernel.org; receiver=)","Received":["from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20])\n\tby bilbo.ozlabs.org (Postfix) with ESMTP id 4LN2q52wG5z9vGM\n\tfor ; Wed, 15 Jun 2022 08:17:05 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S233937AbiFNWRE (ORCPT );\n Tue, 14 Jun 2022 18:17:04 -0400","from lindbergh.monkeyblade.net ([23.128.96.19]:41256 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n with ESMTP id S232077AbiFNWRC (ORCPT\n ); Tue, 14 Jun 2022 18:17:02 -0400","from mail-il1-f177.google.com (mail-il1-f177.google.com\n [209.85.166.177])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E0D7517E2;\n Tue, 14 Jun 2022 15:17:02 -0700 (PDT)","by mail-il1-f177.google.com with SMTP id p1so7591150ilj.9;\n Tue, 14 Jun 2022 15:17:02 -0700 (PDT)","from robh.at.kernel.org ([64.188.179.251])\n by smtp.gmail.com with ESMTPSA id\n p5-20020a92c605000000b002d546bec2f6sm6040067ilm.67.2022.06.14.15.16.59\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 14 Jun 2022 15:17:00 -0700 (PDT)","(nullmailer pid 2823549 invoked by uid 1000);\n Tue, 14 Jun 2022 22:16:58 -0000"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:date:from:to:cc:subject:message-id:references\n :mime-version:content-disposition:in-reply-to;\n bh=UadqYW9XwMxHXYGhli/peFzRH3z/O7G1v62bSzxhX9Y=;\n b=OLujiVbW4/rHh4wo2X5FhWpmBays16OLs3dM8uXJwAFryxd+wniqtKehfnFSSiWn0p\n YIVkYma/vffbXzwnu0aqrdMOEu9SBbo9mjbcUTxkA01wjH6qmlrb/DMlUvxkQbeePryD\n cWI1rvk5VVZoXmDs8j6+3mUTzJ30qfAFeXKWtVnjUeuX+xP0WY+17JzCpL+eHgYqIHZS\n U+v4EFxshudr5/i8EeIeZ8x8w96HnpQM6RthHjUroNQgTH3lzO+NzJarN6NEBP1F+Qcx\n fDuUErwH65jYVdm6HVzCWSr13SeZFrIyHGFs3iuHSPrScQDeKy7h7qPXXc/NT6+5hj6t\n 5erw==","X-Gm-Message-State":"AJIora84qTWvN6LDGNoh/af/7C4tl87q4AEphRtMeN66k2Oq5jpUQFi3\n KdNJZOHxALE9/Nk+M225Ug==","X-Google-Smtp-Source":"\n AGRyM1szWFI0pa+FR6vijKPpqNKE81D4UgslSOZVRfP4Pxc2uu+P4gdQEE5eMn66oYWa6KegHaoHhQ==","X-Received":"by 2002:a92:d706:0:b0:2d7:3543:75f with SMTP id\n m6-20020a92d706000000b002d73543075fmr4367063iln.146.1655245021379;\n Tue, 14 Jun 2022 15:17:01 -0700 (PDT)","Date":"Tue, 14 Jun 2022 16:16:58 -0600","From":"Rob Herring ","To":"Serge Semin ","Cc":"Alexey Malahov ,\n Serge Semin ,\n Linus Walleij ,\n linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,\n Hannes Reinecke ,\n Pavel Parkhomenko ,\n Jens Axboe ,\n Damien Le Moal ,\n devicetree@vger.kernel.org,\n Krzysztof Kozlowski ,\n Rob Herring ,\n Hans de Goede ","Subject":"Re: [PATCH v4 02/23] dt-bindings: ata: ahci-platform: Detach common\n AHCI bindings","Message-ID":"<20220614221658.GA2823453-robh@kernel.org>","References":"<20220610081801.11854-1-Sergey.Semin@baikalelectronics.ru>\n <20220610081801.11854-3-Sergey.Semin@baikalelectronics.ru>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220610081801.11854-3-Sergey.Semin@baikalelectronics.ru>","X-Spam-Status":"No, score=-1.2 required=5.0 tests=BAYES_00,\n FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,\n HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,\n SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no\n autolearn_force=no version=3.4.6","X-Spam-Checker-Version":"SpamAssassin 3.4.6 (2021-04-09) on\n lindbergh.monkeyblade.net","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ide@vger.kernel.org"}}]