[{"id":2821090,"web_url":"http://patchwork.ozlabs.org/comment/2821090/","msgid":"","list_archive_url":null,"date":"2022-01-13T15:24:27","subject":"Re: [PULL v2 21/36] backends: move dbus-vmstate1.xml to backends/","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On Tue, 21 Dec 2021 at 07:04, wrote:\n>\n> From: Marc-André Lureau \n>\n> Although not used by the backend itself, use a common location for\n> documentation and sharing purposes.\n>\n> Signed-off-by: Marc-André Lureau \n> Acked-by: Gerd Hoffmann \n> ---\n> {tests/qtest => backends}/dbus-vmstate1.xml | 0\n> tests/qtest/meson.build | 2 +-\n> 2 files changed, 1 insertion(+), 1 deletion(-)\n> rename {tests/qtest => backends}/dbus-vmstate1.xml (100%)\n>\n> diff --git a/tests/qtest/dbus-vmstate1.xml b/backends/dbus-vmstate1.xml\n> similarity index 100%\n> rename from tests/qtest/dbus-vmstate1.xml\n> rename to backends/dbus-vmstate1.xml\n> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build\n> index ebeac59b3f95..913e987409d5 100644\n> --- a/tests/qtest/meson.build\n> +++ b/tests/qtest/meson.build\n> @@ -98,7 +98,7 @@ if dbus_daemon.found() and config_host.has_key('GDBUS_CODEGEN')\n> #qtests_i386 += ['dbus-vmstate-test']\n> dbus_vmstate1 = custom_target('dbus-vmstate description',\n> output: ['dbus-vmstate1.h', 'dbus-vmstate1.c'],\n> - input: files('dbus-vmstate1.xml'),\n> + input: meson.source_root() / 'backends/dbus-vmstate1.xml',\n> command: [config_host['GDBUS_CODEGEN'],\n> '@INPUT@',\n> '--interface-prefix', 'org.qemu',\n\nThis use of meson.source_root() makes meson complain:\n\nWARNING: Project targeting '>=0.58.2' but tried to use feature\ndeprecated since '0.56.0': meson.source_root. use\nmeson.project_source_root() or meson.global_source_root() instead.\n[...]\nWARNING: Deprecated features used:\n * 0.56.0: {'meson.source_root'}\n\nI'm not sure which of the two suggested replacements is correct here,\nbut could you find out and send a patch, please ?\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["bilbo.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=t+Cax+NG;\n\tdkim-atps=neutral","ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4JZSvF3Cq0z9sP7\n\tfor ; Fri, 14 Jan 2022 02:26:16 +1100 (AEDT)","from localhost ([::1]:39332 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1n81zR-0000nL-GM\n\tfor incoming@patchwork.ozlabs.org; Thu, 13 Jan 2022 10:26:13 -0500","from eggs.gnu.org ([209.51.188.92]:53964)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1n81y1-0000my-Io\n for qemu-devel@nongnu.org; Thu, 13 Jan 2022 10:24:45 -0500","from [2a00:1450:4864:20::32d] (port=52747\n helo=mail-wm1-x32d.google.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1n81xw-0007Rv-4q\n for qemu-devel@nongnu.org; Thu, 13 Jan 2022 10:24:43 -0500","by mail-wm1-x32d.google.com with SMTP id v123so4128045wme.2\n for ; Thu, 13 Jan 2022 07:24:39 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n h=mime-version:references:in-reply-to:from:date:message-id:subject:to\n :cc:content-transfer-encoding;\n bh=m670muHTyTe4gL5bLaUiWvIx2626hBG/pkpJcqQMJ1g=;\n b=t+Cax+NGupYsQpIk3cqbVcVfSikOEYFM0YJlhjkcFI3O/e30cvLUQFhXpjDA547khI\n egtB+ZHBCLnkKMhwqexwgh+ptOgVUWsakrdV06gddgZcxyfXaOSsff2SR52PyCb6xARK\n Kjph7fcOzuwdg5bvUjubN4ks+2/ZeLv5plJ4FZssQ/Ono2ZJL70oCtIl701RwnnSOdxo\n X0xu/6heBqN+/P9hJpj0IR4y2U+Y/67K/YTnUGX5YI6pW8OcR2nkjO72bt9lzY7yQl3e\n DJdZr4R1HLsxbRot1kcT4jR3bPHSIy1BXEsa2cgt+kfodahX25uQkSgIeRTAiBYQcM0o\n P0lg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:mime-version:references:in-reply-to:from:date\n :message-id:subject:to:cc:content-transfer-encoding;\n bh=m670muHTyTe4gL5bLaUiWvIx2626hBG/pkpJcqQMJ1g=;\n b=a5JKGtTI680mSeHO416d/2qUGSsYCHWaSM0cdqYu5Q7iT9k6+R7dFqY3EURHfjHMwS\n hnEyYExUm/jdK03fmgll8xeF5Dmw82dSEAW/qxnMCGPinBzNcXxomnUMj1DS8JHXGfyx\n FOtaTN9mpCaf86pW9NXEzEq4imxr2MAerGum7NAN0vyZIC5EVaWzDwZts9Iu+GFqAdd8\n sZ/BZ98qRIoMr/9gzBjXxFtRdkNxVCyoMbuska7DuLcvzMmrYPqoTSDg6YEUEGCEvxfL\n 5vamgC343E4Aja17j5wrg8+LzOqi2C8eluAwwZyYa4GJpIoa9+3DlgG07Iuxi7d9Dw2P\n udIA==","X-Gm-Message-State":"AOAM530KBmHkWI/OeZZ0dkRqeSVZ4bcoiC6+2ShiZfD4X2YoYUW0QmEM\n P5D6gwruAs3Hn1vjpj/FFkyMU4VOaE2R3Qsp8p+/OQ==","X-Google-Smtp-Source":"\n ABdhPJxrTpixqENpdn8MhxzwzY05E3CDBX7M37ZtuTKdJI+XApGWH0nKvBinLJQD/RT0mU+WyzzdNGCWotB3bRmsV5c=","X-Received":"by 2002:a05:600c:28c8:: with SMTP id\n h8mr11492069wmd.37.1642087478694;\n Thu, 13 Jan 2022 07:24:38 -0800 (PST)","MIME-Version":"1.0","References":"<20211221065855.142578-1-marcandre.lureau@redhat.com>\n <20211221065855.142578-22-marcandre.lureau@redhat.com>","In-Reply-To":"<20211221065855.142578-22-marcandre.lureau@redhat.com>","From":"Peter Maydell ","Date":"Thu, 13 Jan 2022 15:24:27 +0000","Message-ID":"\n ","Subject":"Re: [PULL v2 21/36] backends: move dbus-vmstate1.xml to backends/","To":"marcandre.lureau@redhat.com","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Host-Lookup-Failed":"Reverse DNS lookup failed for 2a00:1450:4864:20::32d\n (failed)","Received-SPF":"pass client-ip=2a00:1450:4864:20::32d;\n envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32d.google.com","X-Spam_score_int":"-12","X-Spam_score":"-1.3","X-Spam_bar":"-","X-Spam_report":"(-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Paolo Bonzini , richard.henderson@linaro.org,\n qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "}}]