Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1553346/
{ "id": 1553346, "url": "http://patchwork.ozlabs.org/api/patches/1553346/", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/20211110100744.204072-1-sunil.pai.g@intel.com/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20211110100744.204072-1-sunil.pai.g@intel.com>", "list_archive_url": null, "date": "2021-11-10T10:07:44", "name": "[ovs-dev,v1] acinclude: Provide error info when linking fails with DPDK.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d00321ccd47eef1c60a4992429956c673944916d", "submitter": { "id": 78477, "url": "http://patchwork.ozlabs.org/api/people/78477/", "name": "Pai G, Sunil", "email": "sunil.pai.g@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/20211110100744.204072-1-sunil.pai.g@intel.com/mbox/", "series": [ { "id": 271324, "url": "http://patchwork.ozlabs.org/api/series/271324/", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=271324", "date": "2021-11-10T10:07:44", "name": "[ovs-dev,v1] acinclude: Provide error info when linking fails with DPDK.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/271324/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1553346/comments/", "check": "success", "checks": "http://patchwork.ozlabs.org/api/patches/1553346/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>)", "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4Hq0sf3dvwz9sCD\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 10 Nov 2021 21:08:04 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 1890D80F7A;\n\tWed, 10 Nov 2021 10:08:02 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n\tby localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ewLYkLGJwqUb; Wed, 10 Nov 2021 10:08:01 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp1.osuosl.org (Postfix) with ESMTPS id 4AE4580F64;\n\tWed, 10 Nov 2021 10:08:00 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 08872C0019;\n\tWed, 10 Nov 2021 10:08:00 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 88746C000E\n for <dev@openvswitch.org>; Wed, 10 Nov 2021 10:07:59 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 781594011D\n for <dev@openvswitch.org>; Wed, 10 Nov 2021 10:07:59 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id 2D5EWlX4Mp_q for <dev@openvswitch.org>;\n Wed, 10 Nov 2021 10:07:58 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by smtp4.osuosl.org (Postfix) with ESMTPS id D24044010F\n for <dev@openvswitch.org>; Wed, 10 Nov 2021 10:07:58 +0000 (UTC)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Nov 2021 02:07:58 -0800", "from silpixa00400896.ir.intel.com ([10.243.23.14])\n by orsmga005.jf.intel.com with ESMTP; 10 Nov 2021 02:07:57 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.8.0", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10163\"; a=\"293472651\"", "E=Sophos;i=\"5.87,223,1631602800\"; d=\"scan'208\";a=\"293472651\"", "E=Sophos;i=\"5.87,223,1631602800\"; d=\"scan'208\";a=\"669751815\"" ], "X-ExtLoop1": "1", "From": "Sunil Pai G <sunil.pai.g@intel.com>", "To": "dev@openvswitch.org", "Date": "Wed, 10 Nov 2021 10:07:44 +0000", "Message-Id": "<20211110100744.204072-1-sunil.pai.g@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Subject": "[ovs-dev] [PATCH v1] acinclude: Provide error info when linking\n\tfails with DPDK.", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "Currently the configure script provides no infomation but to update\nthe pkg-config path on failure to link with DPDK.\nFix this to provide more information to the user on failure.\n\nBefore:\nchecking whether linking with dpdk works... no\nconfigure: error: Could not find DPDK library in default search path,\nupdate PKG_CONFIG_PATH for pkg-config to find the .pc file in\nnon-standard location\n\nAfter:\nchecking whether linking with dpdk works... no\nconfigure: error: configure:27158: gcc -o conftest -include rte_config.h ...\n-Wl,--whole-archive -l:librte_bus_pci.a -l:my_lib.a ... -lunwind >&5\n/usr/bin/ld: cannot find -l:my_lib.a\n\nSigned-off-by: Sunil Pai G <sunil.pai.g@intel.com>\n---\n acinclude.m4 | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)", "diff": "diff --git a/acinclude.m4 b/acinclude.m4\nindex dba365ea1..1af277447 100644\n--- a/acinclude.m4\n+++ b/acinclude.m4\n@@ -475,7 +475,8 @@ AC_DEFUN([OVS_CHECK_DPDK], [\n # DPDK uses dlopen to load plugins.\n OVS_FIND_DEPENDENCY([dlopen], [dl], [libdl])\n \n- AC_MSG_CHECKING([whether linking with dpdk works])\n+ DPDK_STRING=\"whether linking with dpdk works\"\n+ AC_MSG_CHECKING([$DPDK_STRING])\n LIBS=\"$DPDK_LIB $LIBS\"\n AC_LINK_IFELSE(\n [AC_LANG_PROGRAM([#include <rte_config.h>\n@@ -485,10 +486,10 @@ AC_DEFUN([OVS_CHECK_DPDK], [\n [AC_MSG_RESULT([yes])\n DPDKLIB_FOUND=true],\n [AC_MSG_RESULT([no])\n+ # Fetch the cause of failure from config.log\n+ DPDK_LINK_ERROR=$(grep \"$DPDK_STRING\" -A2 config.log | tail -n2)\n AC_MSG_ERROR(m4_normalize([\n- Could not find DPDK library in default search path, update\n- PKG_CONFIG_PATH for pkg-config to find the .pc file in\n- non-standard location]))\n+ $DPDK_LINK_ERROR]))\n ])\n \n CFLAGS=\"$ovs_save_CFLAGS\"\n", "prefixes": [ "ovs-dev", "v1" ] }