Show a patch.

Update a patch.

Update a patch.

GET /api/patches/1528903/
Content-Type: application/json
Vary: Accept

    "id": 1528903,
    "url": "",
    "web_url": "",
    "project": {
        "id": 47,
        "url": "",
        "name": "Open vSwitch",
        "link_name": "openvswitch",
        "list_id": "",
        "list_email": "",
        "web_url": "",
        "scm_url": "",
        "webscm_url": "",
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    "msgid": "<>",
    "list_archive_url": null,
    "date": "2021-09-16T15:07:48",
    "name": "[ovs-dev] ovsdb-server: Log database transactions for user requested tables.",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": false,
    "hash": "9f6939658bac2890d037fecd0372939fb2a5ea9f",
    "submitter": {
        "id": 76591,
        "url": "",
        "name": "Dumitru Ceara",
        "email": ""
    "delegate": null,
    "mbox": "",
    "series": [
            "id": 262649,
            "url": "",
            "web_url": "",
            "date": "2021-09-16T15:07:48",
            "name": "[ovs-dev] ovsdb-server: Log database transactions for user requested tables.",
            "version": 1,
            "mbox": ""
    "comments": "",
    "check": "fail",
    "checks": "",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<>",
        "X-Original-To": [
        "Delivered-To": [
        "Authentication-Results": [
            ";\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.a=rsa-sha256\n header.s=mimecast20190719 header.b=DrQdAMWR;\n\tdkim-atps=neutral",
            ";\n spf=pass (sender SPF authorized)\n (client-ip=;;\n; receiver=<UNKNOWN>)",
            ";\n auth=pass smtp.auth=CUSA124A263"
        "Received": [
            "from ( [])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby (Postfix) with ESMTPS id 4H9L7K3TL4z9sR4\n\tfor <>; Fri, 17 Sep 2021 01:08:13 +1000 (AEST)",
            "from localhost (localhost [])\n\tby (Postfix) with ESMTP id 6A7A5613F2;\n\tThu, 16 Sep 2021 15:08:11 +0000 (UTC)",
            "from ([])\n\tby localhost ( []) (amavisd-new, port 10024)\n\twith ESMTP id Yp3gpAuimQFP; Thu, 16 Sep 2021 15:08:10 +0000 (UTC)",
            "from (\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby (Postfix) with ESMTPS id 7F7666062E;\n\tThu, 16 Sep 2021 15:08:09 +0000 (UTC)",
            "from (localhost [])\n\tby (Postfix) with ESMTP id 539A3C000F;\n\tThu, 16 Sep 2021 15:08:09 +0000 (UTC)",
            "from ( [])\n by (Postfix) with ESMTP id 22F17C000D\n for <>; Thu, 16 Sep 2021 15:08:08 +0000 (UTC)",
            "from localhost (localhost [])\n by (Postfix) with ESMTP id 0DF9D60638\n for <>; Thu, 16 Sep 2021 15:08:08 +0000 (UTC)",
            "from ([])\n by localhost ( []) (amavisd-new, port 10024)\n with ESMTP id DVC1R6qm-Rm9 for <>;\n Thu, 16 Sep 2021 15:08:06 +0000 (UTC)",
            "from\n ( [])\n by (Postfix) with ESMTPS id B7FA26062E\n for <>; Thu, 16 Sep 2021 15:08:06 +0000 (UTC)",
            "from (\n []) (Using TLS) by with ESMTP id\n us-mta-179-wsxeFwyDOFi7eK6G-dOYLg-1; Thu, 16 Sep 2021 11:08:04 -0400",
            "from (\n [])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by (Postfix) with ESMTPS id 25D3B91277;\n Thu, 16 Sep 2021 15:08:03 +0000 (UTC)",
            "from dceara.remote.csb (unknown [])\n by (Postfix) with ESMTP id 0398E61093;\n Thu, 16 Sep 2021 15:07:56 +0000 (UTC)"
        "X-Virus-Scanned": [
            "amavisd-new at",
            "amavisd-new at"
        "X-Greylist": "domain auto-whitelisted by SQLgrey-1.8.0",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;;\n s=mimecast20190719; t=1631804885;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=1VhCVaqnmeH4M99/fcr0DL7wA46YFIRJ3ekIXec27hA=;\n b=DrQdAMWRVOej4fv0W1yTWw40iu8Pwl3Z2Cg7LIZEdwfxRj3I7ULR46JUnLWkawzoFNMsWJ\n EvkZaPk9Mww8G+1dNmNhPeMXEMpopIxlj7sG8zVQSgKvuxcOINUbc3nggxHHfa2Iw9Z/HP\n 3ns94wDWJ/0AKw3Te7MMazY0JrbLmSM=",
        "X-MC-Unique": "wsxeFwyDOFi7eK6G-dOYLg-1",
        "From": "Dumitru Ceara <>",
        "To": "",
        "Date": "Thu, 16 Sep 2021 17:07:48 +0200",
        "Message-Id": "<>",
        "MIME-Version": "1.0",
        "X-Scanned-By": "MIMEDefang 2.79 on",
        "X-Mimecast-Spam-Score": "0",
        "X-Mimecast-Originator": "",
        "Cc": "",
        "Subject": "[ovs-dev] [PATCH] ovsdb-server: Log database transactions for user\n\trequested tables.",
        "X-BeenThere": "",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "<>",
        "List-Unsubscribe": "<>,\n <>",
        "List-Archive": "<>",
        "List-Post": "<>",
        "List-Help": "<>",
        "List-Subscribe": "<>,\n <>",
        "Content-Type": "text/plain; charset=\"us-ascii\"",
        "Content-Transfer-Encoding": "7bit",
        "Errors-To": "",
        "Sender": "\"dev\" <>"
    "content": "Add a new command, 'ovsdb-server/log-db-ops DB TABLE on|off', which\nallows the user to enable/disable transaction logging for specific\ndatabases and tables.\n\nBy default, logging is disabled.  Once enabled, logs are generated\nwith level INFO and are also rate limited.\n\nIf used with care, this command can be useful in analyzing production\ndeployment performance issues, allowing the user to pin point\nbottlenecks without the need to enable wider debug logs, e.g., jsonrpc.\n\nSigned-off-by: Dumitru Ceara <>\n---\nA sample use case is an ovn-kubernetes scaled deployment in which\nwe're interesting in reducing time to bring up PODs (represented by\nOVN logical switch ports).  In order to determine exactly where the\nbottleneck is when provisioning PODs (CMS/ovn-nbctl/client\nIDLs/ovsdb-server/ovn-controller/etc) we need timestamps of when\noperations happen at various places in the stack.\n\nWithout this patch the only option for tracking when transactions\nhappen in the Northbound database is to enable jsonrpc debug logs in\novsdb-server.  This generates a rather large amount of data.\n\nInstead, now, users would be able to just enable logging for the\nLogical_Switch_Port table getting more relevant and precise\ninformation.\n---\n NEWS                 |  4 ++++\n ovsdb/ovsdb-server.c | 38 +++++++++++++++++++++++++++++++++\n ovsdb/row.c          | 17 +++++++++++++++\n ovsdb/row.h          |  1 +\n ovsdb/table.c        |  7 ++++++\n ovsdb/table.h        |  3 +++\n ovsdb/transaction.c  | 51 ++++++++++++++++++++++++++++++++++++++++++++\n 7 files changed, 121 insertions(+)",
    "diff": "diff --git a/NEWS b/NEWS\nindex 1f2adf7180e0..392f8b340389 100644\n--- a/NEWS\n+++ b/NEWS\n@@ -8,6 +8,10 @@ Post-v2.16.0\n        by default.  'other_config:dpdk-socket-limit' can be set equal to\n        the 'other_config:dpdk-socket-mem' to preserve the legacy memory\n        limiting behavior.\n+   - OVSDB:\n+     * New unixctl command 'ovsdb-server/log-db-ops DB TABLE on|off\".\n+       If turned on, ovsdb-server will log (at level INFO and rate limited)\n+       all operations that are committed to table TABLE in the DB database.\n \n \n v2.16.0 - 16 Aug 2021\ndiff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c\nindex 0b3d2bb71432..c48645f7e255 100644\n--- a/ovsdb/ovsdb-server.c\n+++ b/ovsdb/ovsdb-server.c\n@@ -115,6 +115,7 @@ static unixctl_cb_func ovsdb_server_list_remotes;\n static unixctl_cb_func ovsdb_server_add_database;\n static unixctl_cb_func ovsdb_server_remove_database;\n static unixctl_cb_func ovsdb_server_list_databases;\n+static unixctl_cb_func ovsdb_server_log_db_ops;\n \n static void read_db(struct server_config *, struct db *);\n static struct ovsdb_error *open_db(struct server_config *,\n@@ -443,6 +444,8 @@ main(int argc, char *argv[])\n                              ovsdb_server_remove_database, &server_config);\n     unixctl_command_register(\"ovsdb-server/list-dbs\", \"\", 0, 0,\n                              ovsdb_server_list_databases, &all_dbs);\n+    unixctl_command_register(\"ovsdb-server/log-db-ops\", \"DB TABLE on|off\",\n+                             3, 3, ovsdb_server_log_db_ops, &all_dbs);\n     unixctl_command_register(\"ovsdb-server/perf-counters-show\", \"\", 0, 0,\n                              ovsdb_server_perf_counters_show, NULL);\n     unixctl_command_register(\"ovsdb-server/perf-counters-clear\", \"\", 0, 0,\n@@ -1769,6 +1772,41 @@ ovsdb_server_list_databases(struct unixctl_conn *conn, int argc OVS_UNUSED,\n     ds_destroy(&s);\n }\n \n+static void\n+ovsdb_server_log_db_ops(struct unixctl_conn *conn, int argc OVS_UNUSED,\n+                        const char *argv[], void *all_dbs_)\n+{\n+    struct shash *all_dbs = all_dbs_;\n+    const char *db_name = argv[1];\n+    const char *tbl_name = argv[2];\n+    const char *command = argv[3];\n+    bool log;\n+\n+    if (!strcmp(command, \"on\")) {\n+        log = true;\n+    } else if (!strcmp(command, \"off\")) {\n+        log = false;\n+    } else {\n+        unixctl_command_reply_error(conn, \"invalid argument\");\n+        return;\n+    }\n+\n+    struct db *db = shash_find_data(all_dbs, db_name);\n+    if (!db) {\n+        unixctl_command_reply_error(conn, \"no such database\");\n+        return;\n+    }\n+\n+    struct ovsdb_table *table = ovsdb_get_table(db->db, tbl_name);\n+    if (!table) {\n+        unixctl_command_reply_error(conn, \"no such table\");\n+        return;\n+    }\n+\n+    ovsdb_table_log_ops(table, log);\n+    unixctl_command_reply(conn, NULL);\n+}\n+\n static void\n ovsdb_server_get_sync_status(struct unixctl_conn *conn, int argc OVS_UNUSED,\n                              const char *argv[] OVS_UNUSED, void *config_)\ndiff --git a/ovsdb/row.c b/ovsdb/row.c\nindex 65a0546211c8..5e31716506bc 100644\n--- a/ovsdb/row.c\n+++ b/ovsdb/row.c\n@@ -278,6 +278,23 @@ ovsdb_row_to_json(const struct ovsdb_row *row,\n     }\n     return json;\n }\n+\n+void\n+ovsdb_row_to_string(const struct ovsdb_row *row, struct ds *out)\n+{\n+    struct shash_node *node;\n+\n+    SHASH_FOR_EACH (node, &row->table->schema->columns) {\n+        const struct ovsdb_column *column = node->data;\n+\n+        ds_put_format(out, \"%s:\", column->name);\n+        ovsdb_datum_to_string(&row->fields[column->index], &column->type, out);\n+        ds_put_cstr(out, \",\");\n+    }\n+    if (shash_count(&row->table->schema->columns)) {\n+        ds_chomp(out, ',');\n+    }\n+}\n \f\n void\n ovsdb_row_set_init(struct ovsdb_row_set *set)\ndiff --git a/ovsdb/row.h b/ovsdb/row.h\nindex 394ac8eb49b6..f22a08ecd197 100644\n--- a/ovsdb/row.h\n+++ b/ovsdb/row.h\n@@ -95,6 +95,7 @@ struct ovsdb_error *ovsdb_row_from_json(struct ovsdb_row *,\n     OVS_WARN_UNUSED_RESULT;\n struct json *ovsdb_row_to_json(const struct ovsdb_row *,\n                                const struct ovsdb_column_set *include);\n+void ovsdb_row_to_string(const struct ovsdb_row *, struct ds *);\n \n static inline const struct uuid *\n ovsdb_row_get_uuid(const struct ovsdb_row *row)\ndiff --git a/ovsdb/table.c b/ovsdb/table.c\nindex 455a3663fe89..b7b41d139914 100644\n--- a/ovsdb/table.c\n+++ b/ovsdb/table.c\n@@ -301,10 +301,17 @@ ovsdb_table_create(struct ovsdb_table_schema *ts)\n         hmap_init(&table->indexes[i]);\n     }\n     hmap_init(&table->rows);\n+    table->log = false;\n \n     return table;\n }\n \n+void\n+ovsdb_table_log_ops(struct ovsdb_table *table, bool enabled)\n+{\n+    table->log = enabled;\n+}\n+\n void\n ovsdb_table_destroy(struct ovsdb_table *table)\n {\ndiff --git a/ovsdb/table.h b/ovsdb/table.h\nindex ce69a5d130bf..be88b7a59279 100644\n--- a/ovsdb/table.h\n+++ b/ovsdb/table.h\n@@ -63,10 +63,13 @@ struct ovsdb_table {\n      * ovsdb_row\"s.  Each of the hmap_nodes in indexes[i] are at index 'i' at\n      * the end of struct ovsdb_row, following the 'fields' member. */\n     struct hmap *indexes;\n+\n+    bool log; /* True if logging is enabled for this table. */\n };\n \n struct ovsdb_table *ovsdb_table_create(struct ovsdb_table_schema *);\n void ovsdb_table_destroy(struct ovsdb_table *);\n+void ovsdb_table_log_ops(struct ovsdb_table *, bool);\n \n const struct ovsdb_row *ovsdb_table_get_row(const struct ovsdb_table *,\n                                             const struct uuid *);\ndiff --git a/ovsdb/transaction.c b/ovsdb/transaction.c\nindex 8ffefcf7c9d0..dc07e9c00a4b 100644\n--- a/ovsdb/transaction.c\n+++ b/ovsdb/transaction.c\n@@ -29,6 +29,7 @@\n #include \"openvswitch/vlog.h\"\n #include \"ovsdb-error.h\"\n #include \"ovsdb.h\"\n+#include \"ovs-thread.h\"\n #include \"row.h\"\n #include \"storage.h\"\n #include \"table.h\"\n@@ -95,6 +96,7 @@ struct ovsdb_txn_row {\n static struct ovsdb_error * OVS_WARN_UNUSED_RESULT\n delete_garbage_row(struct ovsdb_txn *txn, struct ovsdb_txn_row *r);\n static void ovsdb_txn_row_prefree(struct ovsdb_txn_row *);\n+static void ovsdb_txn_row_log(const struct ovsdb_txn_row *);\n static struct ovsdb_error * OVS_WARN_UNUSED_RESULT\n for_each_txn_row(struct ovsdb_txn *txn,\n                       struct ovsdb_error *(*)(struct ovsdb_txn *,\n@@ -104,6 +106,11 @@ for_each_txn_row(struct ovsdb_txn *txn,\n  * processed.  */\n static unsigned int serial;\n \n+/* Used by ovsdb_txn_row_log() to avoid reallocating dynamic strings\n+ * every time a row operation is logged.\n+ */\n+DEFINE_STATIC_PER_THREAD_DATA(struct ds, row_log_str, DS_EMPTY_INITIALIZER);\n+\n struct ovsdb_txn *\n ovsdb_txn_create(struct ovsdb *db)\n {\n@@ -422,6 +429,49 @@ update_ref_counts(struct ovsdb_txn *txn)\n     return for_each_txn_row(txn, check_ref_count);\n }\n \n+static void\n+ovsdb_txn_row_log(const struct ovsdb_txn_row *txn_row)\n+{\n+    static struct vlog_rate_limit rl_insert = VLOG_RATE_LIMIT_INIT(30, 60);\n+    static struct vlog_rate_limit rl_update = VLOG_RATE_LIMIT_INIT(30, 60);\n+    static struct vlog_rate_limit rl_delete = VLOG_RATE_LIMIT_INIT(30, 60);\n+\n+    if (!txn_row->table->log) {\n+        return;\n+    }\n+\n+    size_t n_columns = shash_count(&txn_row->table->schema->columns);\n+    struct ovsdb_row *log_row;\n+    const char *op = NULL;\n+\n+    if (!txn_row->old && txn_row->new) {\n+        if (!vlog_should_drop(&this_module, VLL_INFO, &rl_insert)) {\n+            log_row = txn_row->new;\n+            op = \"inserted\";\n+        }\n+    } else if (txn_row->old && txn_row->new\n+               && !bitmap_is_all_zeros(txn_row->changed, n_columns)) {\n+        if (!vlog_should_drop(&this_module, VLL_INFO, &rl_update)) {\n+            log_row = txn_row->new;\n+            op = \"updated\";\n+        }\n+    } else if (txn_row->old && !txn_row->new) {\n+        if (!vlog_should_drop(&this_module, VLL_INFO, &rl_delete)) {\n+            log_row = txn_row->old;\n+            op = \"deleted\";\n+        }\n+    }\n+\n+    if (op) {\n+        struct ds *ds = row_log_str_get();\n+        ds_clear(ds);\n+        ds_put_format(ds, \"table:%s,op:%s,\", txn_row->table->schema->name,\n+                      op);\n+        ovsdb_row_to_string(log_row, ds);\n+        VLOG_INFO(\"%s\", ds_cstr(ds));\n+    }\n+}\n+\n static struct ovsdb_error *\n ovsdb_txn_row_commit(struct ovsdb_txn *txn OVS_UNUSED,\n                      struct ovsdb_txn_row *txn_row)\n@@ -445,6 +495,7 @@ ovsdb_txn_row_commit(struct ovsdb_txn *txn OVS_UNUSED,\n         }\n     }\n \n+    ovsdb_txn_row_log(txn_row);\n     ovsdb_txn_row_prefree(txn_row);\n     if (txn_row->new) {\n         txn_row->new->n_refs = txn_row->n_refs;\n",
    "prefixes": [