[{"id":2661900,"web_url":"http://patchwork.ozlabs.org/comment/2661900/","msgid":"<20210406173836.GW2469518@zorba>","date":"2021-04-06T17:38:36","subject":"Re: [PATCH v4 19/20] mips: Convert to GENERIC_CMDLINE","submitter":{"id":67374,"url":"http://patchwork.ozlabs.org/api/people/67374/","name":"Daniel Walker (danielwa)","email":"danielwa@cisco.com"},"content":"On Fri, Apr 02, 2021 at 03:18:21PM +0000, Christophe Leroy wrote:\n> -config CMDLINE_BOOL\n> -\tbool \"Built-in kernel command line\"\n> -\thelp\n> -\t For most systems, it is firmware or second stage bootloader that\n> -\t by default specifies the kernel command line options. However,\n> -\t it might be necessary or advantageous to either override the\n> -\t default kernel command line or add a few extra options to it.\n> -\t For such cases, this option allows you to hardcode your own\n> -\t command line options directly into the kernel. For that, you\n> -\t should choose 'Y' here, and fill in the extra boot arguments\n> -\t in CONFIG_CMDLINE.\n> -\n> -\t The built-in options will be concatenated to the default command\n> -\t line if CMDLINE_OVERRIDE is set to 'N'. Otherwise, the default\n> -\t command line will be ignored and replaced by the built-in string.\n> -\n> -\t Most MIPS systems will normally expect 'N' here and rely upon\n> -\t the command line from the firmware or the second-stage bootloader.\n> -\n\n\nSee how you complained that I have CMDLINE_BOOL in my changed, and you think it\nshouldn't exist.\n\nYet here mips has it, and you just deleted it with no feature parity in your\nchanges for this.\n\nIn my changes I tried to maintain as much feature parity as I could with the\narchitectures. I did the same huge conversion a long time ago you've done here to be sure all\nplatforms have the features needed.\n\nDaniel","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=ggLx+4V4;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=ggLx+4V4;\n\tdkim-atps=neutral","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=cisco.com (client-ip=173.37.86.76; helo=rcdn-iport-5.cisco.com;\n envelope-from=danielwa@cisco.com; receiver=)","lists.ozlabs.org; dkim=pass (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=ggLx+4V4; dkim-atps=neutral"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4FFFBf6bNfz9s1l\n\tfor ; Wed, 7 Apr 2021 03:39:06 +1000 (AEST)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4FFFBf5YPqz3bpX\n\tfor ; Wed, 7 Apr 2021 03:39:06 +1000 (AEST)","from rcdn-iport-5.cisco.com (rcdn-iport-5.cisco.com [173.37.86.76])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4FFFBF3hJmz2xfh\n for ; Wed, 7 Apr 2021 03:38:43 +1000 (AEST)","from alln-core-12.cisco.com ([173.36.13.134])\n by rcdn-iport-5.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA;\n 06 Apr 2021 17:38:39 +0000","from zorba ([10.24.14.212])\n by alln-core-12.cisco.com (8.15.2/8.15.2) with ESMTPS id 136HcajD016593\n (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);\n Tue, 6 Apr 2021 17:38:37 GMT"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=cisco.com; i=@cisco.com; l=1449; q=dns/txt; s=iport;\n t=1617730725; x=1618940325;\n h=date:from:to:cc:subject:message-id:references:\n mime-version:in-reply-to;\n bh=wHC75exw7z/XvWxaqurh75hAcW+P/hc1Ce2AN8KLAVE=;\n b=ggLx+4V4bavJCH3/HSDXdJ0f031+ZXu/aK9m+Bu+07Ktzqdc7oGRwcmN\n MF3qiGkvDX0Rmhk0jcjFe6EcSQ1cKHIUFwx7d6ypoimEBsIo2Djh9lrDj\n 84Nti/hzxAyckgzcsesFxFsAG2+o6X7vvTa9GCgTuOTXBQUqYpCDm14Bk s=;","IronPort-HdrOrdr":"\n A9a23:d70PFKyAZuY1VAyfgTLAKrPwkb1zdoIgy1knxilNYDZeG/b2q+mFmvMH2RjozBsQQmgng9CcOK+GKEmskKJdy48XILukQU3aqHKlRbsSj7fK7jX8F0TFnNJ1+rxnd8FFZeHYLV8/tsri5Rn9LtBI+qjizImNpcPzi0hgVhtrbaYI1XYbNi++HldtTAdLQboVfaD82uN9qzCteWsaY62AbxFvY8H5q9LGj57gaxIdbiRG1CC1kTiq5LTmeiL34j4iVVp0rYsKwCzijxHz4LmlvrWdzBLRvlWjiah+qZ/G1sZJAtCKh4wuDgjUziysZIhnRtS5zVcInN0=","X-IronPort-Anti-Spam-Filtered":"true","X-IronPort-Anti-Spam-Result":"\n A0AGAAAsnGxg/4YNJK1aGgEBAQEBAQEBAQEDAQEBARIBAQEBAgIBAQEBQIE+BQEBAQELAYIqgU0BOY0XiTGQDYpcgXwLAQEBDQEBNAQBAYRQAoF2AiU0CQ4CAwEBDAEBBQEBAQIBBgRxE4VdhkUBBTo6BRALGC48GwaGDKtXdYE0gQGIH4FEIoEXAY1MJxyBSUKBE4MiPoo5BIJHghegOZwpgxWBJptHMhCkYS24EQIEBgUCFoFUOoFZMxoIGxWDJU8ZDo4rFo5HIQNnAgYKAQEDCYw0XQEB","X-IronPort-AV":"E=Sophos;i=\"5.82,201,1613433600\"; d=\"scan'208\";a=\"611888528\"","Date":"Tue, 6 Apr 2021 10:38:36 -0700","From":"Daniel Walker ","To":"Christophe Leroy ","Subject":"Re: [PATCH v4 19/20] mips: Convert to GENERIC_CMDLINE","Message-ID":"<20210406173836.GW2469518@zorba>","References":"\n ","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"\n ","X-Outbound-SMTP-Client":"10.24.14.212, [10.24.14.212]","X-Outbound-Node":"alln-core-12.cisco.com","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"linux-arch@vger.kernel.org, robh@kernel.org,\n microblaze ,\n daniel@gimpelevich.san-francisco.ca.us, arnd@kernel.org,\n linux-sh@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n linux-xtensa@linux-xtensa.org, x86@kernel.org, linux-kernel@vger.kernel.org,\n nios2 , linux-mips@vger.kernel.org,\n linux-mm@kvack.org,\n devicetree@vger.kernel.org, openrisc@lists.librecores.org,\n linux-hexagon@vger.kernel.org, sparclinux@vger.kernel.org,\n akpm@linux-foundation.org, will@kernel.org, linux-riscv@lists.infradead.org,\n linux-arm-kernel@lists.infradead.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2663568,"web_url":"http://patchwork.ozlabs.org/comment/2663568/","msgid":"<20210408190408.GA1724284@robh.at.kernel.org>","date":"2021-04-08T19:04:08","subject":"Re: [PATCH v4 19/20] mips: Convert to GENERIC_CMDLINE","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Tue, Apr 06, 2021 at 10:38:36AM -0700, Daniel Walker wrote:\n> On Fri, Apr 02, 2021 at 03:18:21PM +0000, Christophe Leroy wrote:\n> > -config CMDLINE_BOOL\n> > -\tbool \"Built-in kernel command line\"\n> > -\thelp\n> > -\t For most systems, it is firmware or second stage bootloader that\n> > -\t by default specifies the kernel command line options. However,\n> > -\t it might be necessary or advantageous to either override the\n> > -\t default kernel command line or add a few extra options to it.\n> > -\t For such cases, this option allows you to hardcode your own\n> > -\t command line options directly into the kernel. For that, you\n> > -\t should choose 'Y' here, and fill in the extra boot arguments\n> > -\t in CONFIG_CMDLINE.\n> > -\n> > -\t The built-in options will be concatenated to the default command\n> > -\t line if CMDLINE_OVERRIDE is set to 'N'. Otherwise, the default\n> > -\t command line will be ignored and replaced by the built-in string.\n> > -\n> > -\t Most MIPS systems will normally expect 'N' here and rely upon\n> > -\t the command line from the firmware or the second-stage bootloader.\n> > -\n> \n> \n> See how you complained that I have CMDLINE_BOOL in my changed, and you think it\n> shouldn't exist.\n> \n> Yet here mips has it, and you just deleted it with no feature parity in your\n> changes for this.\n\nAFAICT, CMDLINE_BOOL equates to a non-empty or empty CONFIG_CMDLINE. You \nseem to need it just because you have CMDLINE_PREPEND and \nCMDLINE_APPEND. If that's not it, what feature is missing? CMDLINE_BOOL \nis not a feature, but an implementation detail.\n\nRob","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=gmail.com (client-ip=209.85.167.171;\n helo=mail-oi1-f171.google.com; envelope-from=robherring2@gmail.com;\n receiver=)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4FGW0F17ypz9sW1\n\tfor ; Fri, 9 Apr 2021 05:04:29 +1000 (AEST)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4FGW0D6vW6z3bVJ\n\tfor ; Fri, 9 Apr 2021 05:04:28 +1000 (AEST)","from mail-oi1-f171.google.com (mail-oi1-f171.google.com\n [209.85.167.171])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4FGVzx4LsFz30JW\n for ; Fri, 9 Apr 2021 05:04:12 +1000 (AEST)","by mail-oi1-f171.google.com with SMTP id 25so1797348oiy.5\n for ; Thu, 08 Apr 2021 12:04:12 -0700 (PDT)","from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net.\n [24.155.109.49])\n by smtp.gmail.com with ESMTPSA id g9sm56746otk.6.2021.04.08.12.04.08\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 08 Apr 2021 12:04:09 -0700 (PDT)","(nullmailer pid 1795497 invoked by uid 1000);\n Thu, 08 Apr 2021 19:04:08 -0000"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:date:from:to:cc:subject:message-id:references\n :mime-version:content-disposition:in-reply-to;\n bh=DUrGxOBRGKnSQEqHR05dYQldYxqAXJweo2+bFsG+WpA=;\n b=dfv3xI9QpoXvWiHxiYFA/Ycy/Jon3jNI6yufxe+dV7xyPpWFzvCSKRTay0IfqVTa/P\n /wonzAxnLA5hJxSpZpRRBFzS11duUTvGabv2BZ08oQc0FJx2JOOmksRV8inwyj3CcF1L\n /zVtWMqWL81XRF3oY0PJCz+SMlbjMrVdJ65ySQSeCKy+8PE3dFY0gFhrUvQdfV4YFZMD\n +qzzIvKRNeKsaZnrm/c3JA1tHle01pCm6ntVW8Brz8BnNzkaUwMywvyq3cei8PkZcrk0\n oG0I793nfNkA3I5bw1f85HSxcWUEL2y/NJiKFhZDXm4DbUWMm413+02cBENBE/23DFMq\n REpQ==","X-Gm-Message-State":"AOAM530UUhAk/MPDWCdenL1OUAY8FQ6NOW7BZ7mS7JGD5nPqHfrh1FRo\n HEE7wgJYz6Yxpm7YMG1PAQ==","X-Google-Smtp-Source":"\n ABdhPJzc/ezUgVYn/c2gVo9JEsyTGvBA4ZkkApktnBVPpB6CFT0oT9dS88OzEW8tCbInDt8Gjv+2IA==","X-Received":"by 2002:a05:6808:138a:: with SMTP id\n c10mr7276133oiw.117.1617908650345;\n Thu, 08 Apr 2021 12:04:10 -0700 (PDT)","Date":"Thu, 8 Apr 2021 14:04:08 -0500","From":"Rob Herring ","To":"Daniel Walker ","Subject":"Re: [PATCH v4 19/20] mips: Convert to GENERIC_CMDLINE","Message-ID":"<20210408190408.GA1724284@robh.at.kernel.org>","References":"\n \n <20210406173836.GW2469518@zorba>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210406173836.GW2469518@zorba>","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"linux-arch@vger.kernel.org, arnd@kernel.org,\n microblaze ,\n daniel@gimpelevich.san-francisco.ca.us, devicetree@vger.kernel.org,\n linux-sh@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n linux-xtensa@linux-xtensa.org, x86@kernel.org, linux-kernel@vger.kernel.org,\n linux-mips@vger.kernel.org, linux-mm@kvack.org,\n openrisc@lists.librecores.org,\n nios2 , linux-hexagon@vger.kernel.org,\n sparclinux@vger.kernel.org, akpm@linux-foundation.org, will@kernel.org,\n linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2663806,"web_url":"http://patchwork.ozlabs.org/comment/2663806/","msgid":"<20210409012349.GG3981976@zorba>","date":"2021-04-09T01:23:49","subject":"Re: [PATCH v4 19/20] mips: Convert to GENERIC_CMDLINE","submitter":{"id":67374,"url":"http://patchwork.ozlabs.org/api/people/67374/","name":"Daniel Walker (danielwa)","email":"danielwa@cisco.com"},"content":"On Thu, Apr 08, 2021 at 02:04:08PM -0500, Rob Herring wrote:\n> On Tue, Apr 06, 2021 at 10:38:36AM -0700, Daniel Walker wrote:\n> > On Fri, Apr 02, 2021 at 03:18:21PM +0000, Christophe Leroy wrote:\n> > > -config CMDLINE_BOOL\n> > > -\tbool \"Built-in kernel command line\"\n> > > -\thelp\n> > > -\t For most systems, it is firmware or second stage bootloader that\n> > > -\t by default specifies the kernel command line options. However,\n> > > -\t it might be necessary or advantageous to either override the\n> > > -\t default kernel command line or add a few extra options to it.\n> > > -\t For such cases, this option allows you to hardcode your own\n> > > -\t command line options directly into the kernel. For that, you\n> > > -\t should choose 'Y' here, and fill in the extra boot arguments\n> > > -\t in CONFIG_CMDLINE.\n> > > -\n> > > -\t The built-in options will be concatenated to the default command\n> > > -\t line if CMDLINE_OVERRIDE is set to 'N'. Otherwise, the default\n> > > -\t command line will be ignored and replaced by the built-in string.\n> > > -\n> > > -\t Most MIPS systems will normally expect 'N' here and rely upon\n> > > -\t the command line from the firmware or the second-stage bootloader.\n> > > -\n> > \n> > \n> > See how you complained that I have CMDLINE_BOOL in my changed, and you think it\n> > shouldn't exist.\n> > \n> > Yet here mips has it, and you just deleted it with no feature parity in your\n> > changes for this.\n> \n> AFAICT, CMDLINE_BOOL equates to a non-empty or empty CONFIG_CMDLINE. You \n> seem to need it just because you have CMDLINE_PREPEND and \n> CMDLINE_APPEND. If that's not it, what feature is missing? CMDLINE_BOOL \n> is not a feature, but an implementation detail.\n\nNot true.\n\nIt makes it easier to turn it all off inside the Kconfig , so it's for usability\nand multiple architecture have it even with just CMDLINE as I was commenting\nhere.\n\nDaniel","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=SNxcqYFd;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=SNxcqYFd;\n\tdkim-atps=neutral","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=cisco.com (client-ip=173.37.142.93;\n helo=alln-iport-6.cisco.com;\n envelope-from=danielwa@cisco.com; receiver=)","lists.ozlabs.org; dkim=pass (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=SNxcqYFd; dkim-atps=neutral"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4FGgQj0jTpz9sW1\n\tfor ; Fri, 9 Apr 2021 11:24:29 +1000 (AEST)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4FGgQh6dPZz3bvl\n\tfor ; Fri, 9 Apr 2021 11:24:28 +1000 (AEST)","from alln-iport-6.cisco.com (alln-iport-6.cisco.com [173.37.142.93])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4FGgQG6pz3z301J\n for ; Fri, 9 Apr 2021 11:24:03 +1000 (AEST)","from alln-core-9.cisco.com ([173.36.13.129])\n by alln-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA;\n 09 Apr 2021 01:23:53 +0000","from zorba ([10.24.9.242])\n by alln-core-9.cisco.com (8.15.2/8.15.2) with ESMTPS id 1391Nnm8027721\n (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);\n Fri, 9 Apr 2021 01:23:51 GMT"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=cisco.com; i=@cisco.com; l=1925; q=dns/txt; s=iport;\n t=1617931447; x=1619141047;\n h=date:from:to:cc:subject:message-id:references:\n mime-version:in-reply-to;\n bh=WkzLqPqjAxF6Ch0t2FT084suyCe7GM/KMpezthHSR4s=;\n b=SNxcqYFdpHVXyIhEgk/QNXhAZt3Kb+NSgxqMG7RyojQFlXPbmCm2Tsdj\n /pT7shWCNeB3yfTpw3RoHrFvg7hPepelLMkn6KC/rD5B+gqq6xROSKJsT\n yGLUKTnJvlLvecMQtyv9AGRbXBp1XPP6Pmicj6USs4ZLVIQt0QUpMPQWD c=;","X-IPAS-Result":"\n A0ABAAAUrG9gmIENJK1aGgEBAQEBAQEBAQEDAQEBARIBAQEBAgIBAQEBQIE+BQEBAQELAYN3ATmNF4k1kA2KXIF8CwEBAQ0BATQEAQGEUAKBdwIlNAkOAgMBAQEDAgMBAQEBAQUBAQECAQYEFAEBAQEBAQEBaIVdhkUBAgM6OgUQCxIGLjwNDgaDBIMIqjx1gTSBAYgUgUQigRcBjUwnHIFJQoETgyI+ijkEgkeCNaAbikiRYYMVgSabRzIQpGEtszuEVgIEBgUCFoFUOIFbMxoIGxWDJU8ZDo44jlAhA2cCBgoBAQMJjDRdAQE","IronPort-HdrOrdr":"A9a23:QdBVtK4Vqwy1Ov3XkQPXwHXXdLJzesId70hD6mlaQ3VuHfCwvc\n aogfgdyFvYiCwJXmshhNCHP8C7MBbh3LRy5pQcOqrnYRn+tAKTXeNfxKbr3jGIIUfD38FH06\n MIScVDIf32SWN3lMPrpDS/euxQpOWv1ICNqaPgw2x2TQdsApsQjDtRLgqACEV5SE1nKPMCda\n a03cZMqzq+dXl/VK3SbUUtZOTNq8bGk5jre3c9ZyIP0hWEjj+j9dfBfSSw4xF2aV9y6IZn13\n TZmArk4ajmlPe3xnbnpgnuxqUTvsf9wd1eA8HJsOwpE3HHjwalY5kJYczkgAwI","X-IronPort-Anti-Spam-Filtered":"true","X-IronPort-AV":"E=Sophos;i=\"5.82,208,1613433600\"; d=\"scan'208\";a=\"717254170\"","Date":"Thu, 8 Apr 2021 18:23:49 -0700","From":"Daniel Walker ","To":"Rob Herring ","Subject":"Re: [PATCH v4 19/20] mips: Convert to GENERIC_CMDLINE","Message-ID":"<20210409012349.GG3981976@zorba>","References":"\n \n <20210406173836.GW2469518@zorba>\n <20210408190408.GA1724284@robh.at.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210408190408.GA1724284@robh.at.kernel.org>","X-Outbound-SMTP-Client":"10.24.9.242, [10.24.9.242]","X-Outbound-Node":"alln-core-9.cisco.com","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"linux-arch@vger.kernel.org, arnd@kernel.org,\n microblaze ,\n daniel@gimpelevich.san-francisco.ca.us, devicetree@vger.kernel.org,\n linux-sh@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n linux-xtensa@linux-xtensa.org, x86@kernel.org, linux-kernel@vger.kernel.org,\n linux-mips@vger.kernel.org, linux-mm@kvack.org,\n openrisc@lists.librecores.org,\n nios2 , linux-hexagon@vger.kernel.org,\n sparclinux@vger.kernel.org, akpm@linux-foundation.org, will@kernel.org,\n linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2669840,"web_url":"http://patchwork.ozlabs.org/comment/2669840/","msgid":"","date":"2021-04-20T16:05:44","subject":"Re: [PATCH v4 19/20] mips: Convert to GENERIC_CMDLINE","submitter":{"id":79086,"url":"http://patchwork.ozlabs.org/api/people/79086/","name":"Christophe Leroy","email":"christophe.leroy@csgroup.eu"},"content":"Le 09/04/2021 à 03:23, Daniel Walker a écrit :\n> On Thu, Apr 08, 2021 at 02:04:08PM -0500, Rob Herring wrote:\n>> On Tue, Apr 06, 2021 at 10:38:36AM -0700, Daniel Walker wrote:\n>>> On Fri, Apr 02, 2021 at 03:18:21PM +0000, Christophe Leroy wrote:\n>>>> -config CMDLINE_BOOL\n>>>> -\tbool \"Built-in kernel command line\"\n>>>> -\thelp\n>>>> -\t For most systems, it is firmware or second stage bootloader that\n>>>> -\t by default specifies the kernel command line options. However,\n>>>> -\t it might be necessary or advantageous to either override the\n>>>> -\t default kernel command line or add a few extra options to it.\n>>>> -\t For such cases, this option allows you to hardcode your own\n>>>> -\t command line options directly into the kernel. For that, you\n>>>> -\t should choose 'Y' here, and fill in the extra boot arguments\n>>>> -\t in CONFIG_CMDLINE.\n>>>> -\n>>>> -\t The built-in options will be concatenated to the default command\n>>>> -\t line if CMDLINE_OVERRIDE is set to 'N'. Otherwise, the default\n>>>> -\t command line will be ignored and replaced by the built-in string.\n>>>> -\n>>>> -\t Most MIPS systems will normally expect 'N' here and rely upon\n>>>> -\t the command line from the firmware or the second-stage bootloader.\n>>>> -\n>>>\n>>>\n>>> See how you complained that I have CMDLINE_BOOL in my changed, and you think it\n>>> shouldn't exist.\n>>>\n>>> Yet here mips has it, and you just deleted it with no feature parity in your\n>>> changes for this.\n>>\n>> AFAICT, CMDLINE_BOOL equates to a non-empty or empty CONFIG_CMDLINE. You\n>> seem to need it just because you have CMDLINE_PREPEND and\n>> CMDLINE_APPEND. If that's not it, what feature is missing? CMDLINE_BOOL\n>> is not a feature, but an implementation detail.\n> \n> Not true.\n> \n> It makes it easier to turn it all off inside the Kconfig , so it's for usability\n> and multiple architecture have it even with just CMDLINE as I was commenting\n> here.\n> \n\nAmong the 13 architectures having CONFIG_CMDLINE, todayb only 6 have a CONFIG_CMDLINE_BOOL in addition:\n\narch/arm/Kconfig:config CMDLINE\narch/arm64/Kconfig:config CMDLINE\narch/hexagon/Kconfig:config CMDLINE\narch/microblaze/Kconfig:config CMDLINE\narch/mips/Kconfig.debug:config CMDLINE\narch/nios2/Kconfig:config CMDLINE\narch/openrisc/Kconfig:config CMDLINE\narch/powerpc/Kconfig:config CMDLINE\narch/riscv/Kconfig:config CMDLINE\narch/sh/Kconfig:config CMDLINE\narch/sparc/Kconfig:config CMDLINE\narch/x86/Kconfig:config CMDLINE\narch/xtensa/Kconfig:config CMDLINE\n\narch/microblaze/Kconfig:config CMDLINE_BOOL\narch/mips/Kconfig.debug:config CMDLINE_BOOL\narch/nios2/Kconfig:config CMDLINE_BOOL\narch/sparc/Kconfig:config CMDLINE_BOOL\narch/x86/Kconfig:config CMDLINE_BOOL\narch/xtensa/Kconfig:config CMDLINE_BOOL\n\n\nIn the begining I hesitated about the CMDLINE_BOOL, at the end I decided to go the same way as what \nis done today in the kernel for initramfs with CONFIG_INITRAMFS_SOURCE.\n\nThe problem I see within adding CONFIG_CMDLINE_BOOL for every architecture which don't have it today \nis that when doing a \"make oldconfig\" on their custom configs, thousands of users will loose their \nCMDLINE without notice.\n\nWhen we do the other way round, removing CONFIG_CMDLINE_BOOL on the 6 architectures that have it \ntoday will have no impact on existing config.\n\nAlso, in order to avoid tons of #ifdefs in the code as mandated by Kernel Codying Style §21, we have \nto have CONFIG_CMDLINE defined at all time, so at the end CONFIG_CMDLINE_BOOL is really redundant \nwith an empty CONFIG_CMDLINE.\n\nUnlike you, the approach I took for my series is to minimise the impact on existing implementation \nand existing configurations as much as possible.\n\nI know you have a different approach where you break every existing config anyway.\n\nhttps://www.kernel.org/doc/html/latest/process/coding-style.html#conditional-compilation\n\nChristophe","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=csgroup.eu (client-ip=93.17.236.30; helo=pegase1.c-s.fr;\n envelope-from=christophe.leroy@csgroup.eu; receiver=)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4FPpSy50bkz9vDc\n\tfor ; Wed, 21 Apr 2021 02:06:10 +1000 (AEST)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4FPpSy4J3pz301W\n\tfor ; Wed, 21 Apr 2021 02:06:10 +1000 (AEST)","from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4FPpSf34DYz2xZn\n for ; Wed, 21 Apr 2021 02:05:50 +1000 (AEST)","from localhost (mailhub1-int [192.168.12.234])\n by localhost (Postfix) with ESMTP id 4FPpST5fYSz9tyMJ;\n Tue, 20 Apr 2021 18:05:45 +0200 (CEST)","from pegase1.c-s.fr ([192.168.12.234])\n by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024)\n with ESMTP id 6qTfVqAOsH66; Tue, 20 Apr 2021 18:05:45 +0200 (CEST)","from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192])\n by pegase1.c-s.fr (Postfix) with ESMTP id 4FPpST4Shgz9tyMF;\n Tue, 20 Apr 2021 18:05:45 +0200 (CEST)","from localhost (localhost [127.0.0.1])\n by messagerie.si.c-s.fr (Postfix) with ESMTP id 2B5AD8B807;\n Tue, 20 Apr 2021 18:05:47 +0200 (CEST)","from messagerie.si.c-s.fr ([127.0.0.1])\n by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023)\n with ESMTP id ZiEcE-0Tlz-R; Tue, 20 Apr 2021 18:05:47 +0200 (CEST)","from [192.168.4.90] (unknown [192.168.4.90])\n by messagerie.si.c-s.fr (Postfix) with ESMTP id 0267E8B7ED;\n Tue, 20 Apr 2021 18:05:45 +0200 (CEST)"],"X-Virus-Scanned":["Debian amavisd-new at c-s.fr","amavisd-new at c-s.fr"],"Subject":"Re: [PATCH v4 19/20] mips: Convert to GENERIC_CMDLINE","To":"Daniel Walker , Rob Herring ","References":"\n \n <20210406173836.GW2469518@zorba>\n <20210408190408.GA1724284@robh.at.kernel.org>\n <20210409012349.GG3981976@zorba>","From":"Christophe Leroy ","Message-ID":"","Date":"Tue, 20 Apr 2021 18:05:44 +0200","User-Agent":"Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101\n Thunderbird/78.9.1","MIME-Version":"1.0","In-Reply-To":"<20210409012349.GG3981976@zorba>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"fr","Content-Transfer-Encoding":"8bit","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"linux-arch@vger.kernel.org, arnd@kernel.org,\n microblaze ,\n daniel@gimpelevich.san-francisco.ca.us, devicetree@vger.kernel.org,\n linux-sh@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n linux-xtensa@linux-xtensa.org, x86@kernel.org, linux-kernel@vger.kernel.org,\n nios2 , linux-mips@vger.kernel.org,\n linux-mm@kvack.org,\n openrisc@lists.librecores.org, linux-hexagon@vger.kernel.org,\n sparclinux@vger.kernel.org, akpm@linux-foundation.org, will@kernel.org,\n linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}}]