[{"id":2660469,"web_url":"http://patchwork.ozlabs.org/comment/2660469/","msgid":"","date":"2021-04-02T15:36:12","subject":"Re: [PATCH v3 12/17] sh: Convert to GENERIC_CMDLINE","submitter":{"id":79086,"url":"http://patchwork.ozlabs.org/api/people/79086/","name":"Christophe Leroy","email":"christophe.leroy@csgroup.eu"},"content":"Le 26/03/2021 à 14:44, Christophe Leroy a écrit :\n> This converts the architecture to GENERIC_CMDLINE.\n> \n> Signed-off-by: Christophe Leroy \n> ---\n\n> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig\n> index e798e55915c2..fab84f62448c 100644\n> --- a/arch/sh/Kconfig\n> +++ b/arch/sh/Kconfig\n> @@ -16,6 +16,7 @@ config SUPERH\n> \tselect CPU_NO_EFFICIENT_FFS\n> \tselect DMA_DECLARE_COHERENT\n> \tselect GENERIC_ATOMIC64\n> +\tselect GENERIC_CMDLINE\n> \tselect GENERIC_CMOS_UPDATE if SH_SH03 || SH_DREAMCAST\n> \tselect GENERIC_IDLE_POLL_SETUP\n> \tselect GENERIC_IRQ_SHOW\n> @@ -742,35 +743,6 @@ config ROMIMAGE_MMCIF\n> \t first part of the romImage which in turn loads the rest the kernel\n> \t image to RAM using the MMCIF hardware block.\n> \n> -choice\n> -\tprompt \"Kernel command line\"\n> -\toptional\n> -\tdefault CMDLINE_OVERWRITE\n> -\thelp\n> -\t Setting this option allows the kernel command line arguments\n> -\t to be set.\n> -\n> -config CMDLINE_OVERWRITE\n> -\tbool \"Overwrite bootloader kernel arguments\"\n> -\thelp\n> -\t Given string will overwrite any arguments passed in by\n> -\t a bootloader.\n> -\n> -config CMDLINE_EXTEND\n> -\tbool \"Extend bootloader kernel arguments\"\n> -\thelp\n> -\t Given string will be concatenated with arguments passed in\n> -\t by a bootloader.\n> -\n> -endchoice\n> -\n> -config CMDLINE\n> -\tstring \"Kernel command line arguments string\"\n> -\tdepends on CMDLINE_OVERWRITE || CMDLINE_EXTEND\n> -\tdefault \"console=ttySC1,115200\"\n> -\n> -endmenu\n> -\n\nThat \"endmenu\" shall not be removed.\n\nFixed in v4,\n\nThanks to Rob L. for the report.\nChristophe\n\n> menu \"Bus options\"\n> \n> config SUPERHYWAY","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=csgroup.eu (client-ip=93.17.236.30; helo=pegase1.c-s.fr;\n envelope-from=christophe.leroy@csgroup.eu; receiver=)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4FBkg61nLyz9sRK\n\tfor ; Sat, 3 Apr 2021 02:36:34 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4FBkg55sNLz3dp2\n\tfor ; Sat, 3 Apr 2021 02:36:33 +1100 (AEDT)","from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4FBkfn4QRNz3bs7\n for ; Sat, 3 Apr 2021 02:36:17 +1100 (AEDT)","from localhost (mailhub1-int [192.168.12.234])\n by localhost (Postfix) with ESMTP id 4FBkfh6syMz9v2m9;\n Fri, 2 Apr 2021 17:36:12 +0200 (CEST)","from pegase1.c-s.fr ([192.168.12.234])\n by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024)\n with ESMTP id SsC2ob6kJi6G; Fri, 2 Apr 2021 17:36:12 +0200 (CEST)","from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192])\n by pegase1.c-s.fr (Postfix) with ESMTP id 4FBkfh5PDlz9v2m8;\n Fri, 2 Apr 2021 17:36:12 +0200 (CEST)","from localhost (localhost [127.0.0.1])\n by messagerie.si.c-s.fr (Postfix) with ESMTP id A97528BB77;\n Fri, 2 Apr 2021 17:36:14 +0200 (CEST)","from messagerie.si.c-s.fr ([127.0.0.1])\n by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023)\n with ESMTP id dzRgT34PMsr4; Fri, 2 Apr 2021 17:36:14 +0200 (CEST)","from [192.168.4.90] (unknown [192.168.4.90])\n by messagerie.si.c-s.fr (Postfix) with ESMTP id BA9038BB6F;\n Fri, 2 Apr 2021 17:36:13 +0200 (CEST)"],"X-Virus-Scanned":["Debian amavisd-new at c-s.fr","amavisd-new at c-s.fr"],"Subject":"Re: [PATCH v3 12/17] sh: Convert to GENERIC_CMDLINE","From":"Christophe Leroy ","To":"will@kernel.org, danielwa@cisco.com, robh@kernel.org,\n daniel@gimpelevich.san-francisco.ca.us","References":"\n <6b76649009943f2893fdfded22becd41db2fe1f7.1616765870.git.christophe.leroy@csgroup.eu>","Message-ID":"","Date":"Fri, 2 Apr 2021 17:36:12 +0200","User-Agent":"Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101\n Thunderbird/78.9.0","MIME-Version":"1.0","In-Reply-To":"\n <6b76649009943f2893fdfded22becd41db2fe1f7.1616765870.git.christophe.leroy@csgroup.eu>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"fr","Content-Transfer-Encoding":"8bit","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"linux-arch@vger.kernel.org, devicetree@vger.kernel.org,\n microblaze , linux-sh@vger.kernel.org,\n linux-hexagon@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org,\n linux-kernel@vger.kernel.org, nios2 ,\n linux-mips@vger.kernel.org, openrisc@lists.librecores.org,\n sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org,\n linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}}]