[{"id":2657102,"web_url":"http://patchwork.ozlabs.org/comment/2657102/","msgid":"","date":"2021-03-29T01:35:21","subject":"RE: [PATCH v3 09/17] nios2: Convert to GENERIC_CMDLINE","submitter":{"id":70464,"url":"http://patchwork.ozlabs.org/api/people/70464/","name":"Ley Foon Tan","email":"ley.foon.tan@intel.com"},"content":"> -----Original Message-----\n> From: Christophe Leroy \n> Sent: Friday, March 26, 2021 9:45 PM\n> To: will@kernel.org; danielwa@cisco.com; robh@kernel.org;\n> daniel@gimpelevich.san-francisco.ca.us\n> Cc: linux-arch@vger.kernel.org; devicetree@vger.kernel.org; linuxppc-\n> dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; linuxppc-\n> dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org; microblaze\n> ; linux-mips@vger.kernel.org; Tan, Ley Foon\n> ; openrisc@lists.librecores.org; linux-\n> hexagon@vger.kernel.org; linux-riscv@lists.infradead.org; x86@kernel.org;\n> linux-xtensa@linux-xtensa.org; linux-sh@vger.kernel.org;\n> sparclinux@vger.kernel.org\n> Subject: [PATCH v3 09/17] nios2: Convert to GENERIC_CMDLINE\n> \n> This converts the architecture to GENERIC_CMDLINE.\n> \n> Signed-off-by: Christophe Leroy \n> ---\n> arch/nios2/Kconfig | 24 +-----------------------\n> arch/nios2/kernel/setup.c | 13 ++++---------\n> 2 files changed, 5 insertions(+), 32 deletions(-)\n> \n> diff --git a/arch/nios2/Kconfig b/arch/nios2/Kconfig index\n> c24955c81c92..f66c97b15813 100644\n> --- a/arch/nios2/Kconfig\n> +++ b/arch/nios2/Kconfig\n> @@ -90,31 +90,9 @@ config NIOS2_ALIGNMENT_TRAP\n> \n> comment \"Boot options\"\n> \n> -config CMDLINE_BOOL\n> -\tbool \"Default bootloader kernel arguments\"\n> -\tdefault y\n> -\n> -config CMDLINE\n> -\tstring \"Default kernel command string\"\n> -\tdefault \"\"\n> -\tdepends on CMDLINE_BOOL\n> -\thelp\n> -\t On some platforms, there is currently no way for the boot loader to\n> -\t pass arguments to the kernel. For these platforms, you can supply\n> -\t some command-line options at build time by entering them here. In\n> -\t other cases you can specify kernel args so that you don't have\n> -\t to set them up in board prom initialization routines.\n> -\n> -config CMDLINE_FORCE\n> -\tbool \"Force default kernel command string\"\n> -\tdepends on CMDLINE_BOOL\n> -\thelp\n> -\t Set this to have arguments from the default kernel command string\n> -\t override those passed by the boot loader.\n> -\n> config NIOS2_CMDLINE_IGNORE_DTB\n> \tbool \"Ignore kernel command string from DTB\"\n> -\tdepends on CMDLINE_BOOL\n> +\tdepends on CMDLINE != \"\"\n> \tdepends on !CMDLINE_FORCE\n> \tdefault y\n> \thelp\n\nMissing \" select GENERIC_CMDLINE\" ?\n\n\n\n\n> diff --git a/arch/nios2/kernel/setup.c b/arch/nios2/kernel/setup.c index\n> d2f21957e99c..42464f457a6d 100644\n> --- a/arch/nios2/kernel/setup.c\n> +++ b/arch/nios2/kernel/setup.c\n> @@ -20,6 +20,7 @@\n> #include \n> #include \n> #include \n> +#include \n> \n> #include \n> #include \n> @@ -108,7 +109,7 @@ asmlinkage void __init nios2_boot_init(unsigned r4,\n> unsigned r5, unsigned r6,\n> \t\t\t\t unsigned r7)\n> {\n> \tunsigned dtb_passed = 0;\n> -\tchar cmdline_passed[COMMAND_LINE_SIZE] __maybe_unused =\n> { 0, };\n> +\tchar cmdline_passed[COMMAND_LINE_SIZE] = { 0, };\n> \n> #if defined(CONFIG_NIOS2_PASS_CMDLINE)\n> \tif (r4 == 0x534f494e) { /* r4 is magic NIOS */ @@ -127,14 +128,8 @@\n> asmlinkage void __init nios2_boot_init(unsigned r4, unsigned r5, unsigned r6,\n> \n> \tearly_init_devtree((void *)dtb_passed);\n> \n> -#ifndef CONFIG_CMDLINE_FORCE\n> -\tif (cmdline_passed[0])\n> -\t\tstrlcpy(boot_command_line, cmdline_passed,\n> COMMAND_LINE_SIZE);\n> -#ifdef CONFIG_NIOS2_CMDLINE_IGNORE_DTB\n> -\telse\n> -\t\tstrlcpy(boot_command_line, CONFIG_CMDLINE,\n> COMMAND_LINE_SIZE);\n> -#endif\n> -#endif\n> +\tif (cmdline_passed[0] ||\n> IS_ENABLED(CONFIG_NIOS2_CMDLINE_IGNORE_DTB))\n> +\t\tcmdline_build(boot_command_line, cmdline_passed,\n> COMMAND_LINE_SIZE);\n> \n> \tparse_early_param();\n> }\n> --\n> 2.25.0","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=intel.onmicrosoft.com header.i=@intel.onmicrosoft.com\n header.a=rsa-sha256 header.s=selector2-intel-onmicrosoft-com\n header.b=u/DX/kYh;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=intel.onmicrosoft.com header.i=@intel.onmicrosoft.com\n header.a=rsa-sha256 header.s=selector2-intel-onmicrosoft-com\n header.b=u/DX/kYh;\n\tdkim-atps=neutral","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=intel.com (client-ip=134.134.136.20; helo=mga02.intel.com;\n envelope-from=ley.foon.tan@intel.com; receiver=)","lists.ozlabs.org; dkim=pass (1024-bit key;\n unprotected) header.d=intel.onmicrosoft.com header.i=@intel.onmicrosoft.com\n header.a=rsa-sha256 header.s=selector2-intel-onmicrosoft-com\n header.b=u/DX/kYh; dkim-atps=neutral","csgroup.eu; dkim=none (message not signed)\n header.d=none;csgroup.eu; dmarc=none action=none header.from=intel.com;"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4F7wDK6ByLz9sRf\n\tfor ; Mon, 29 Mar 2021 12:37:05 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4F7wDK5P3Bz302V\n\tfor ; Mon, 29 Mar 2021 12:37:05 +1100 (AEDT)","from mga02.intel.com (mga02.intel.com [134.134.136.20])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4F7wCp668bz2yyP\n for ; Mon, 29 Mar 2021 12:36:38 +1100 (AEDT)","from fmsmga006.fm.intel.com ([10.253.24.20])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Mar 2021 18:35:24 -0700","from orsmsx606.amr.corp.intel.com ([10.22.229.19])\n by fmsmga006.fm.intel.com with ESMTP; 28 Mar 2021 18:35:23 -0700","from orsmsx609.amr.corp.intel.com (10.22.229.22) by\n ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2106.2; Sun, 28 Mar 2021 18:35:23 -0700","from orsedg603.ED.cps.intel.com (10.7.248.4) by\n orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2\n via Frontend Transport; Sun, 28 Mar 2021 18:35:23 -0700","from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169)\n by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.1.2106.2; Sun, 28 Mar 2021 18:35:23 -0700","from BY5PR11MB3893.namprd11.prod.outlook.com (2603:10b6:a03:183::26)\n by BYAPR11MB3253.namprd11.prod.outlook.com (2603:10b6:a03:77::31)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.26; Mon, 29 Mar\n 2021 01:35:22 +0000","from BY5PR11MB3893.namprd11.prod.outlook.com\n ([fe80::297b:a818:3bfb:f897]) by BY5PR11MB3893.namprd11.prod.outlook.com\n ([fe80::297b:a818:3bfb:f897%6]) with mapi id 15.20.3977.033; Mon, 29 Mar 2021\n 01:35:22 +0000"],"X-Greylist":"delayed 63 seconds by postgrey-1.36 at boromir;\n Mon, 29 Mar 2021 12:36:38 AEDT","IronPort-SDR":["\n lZO4rW1n6u3pH/cXVW1spuoS5Kyi/awdKy0B7xgO37F79G9UWbIYWwp86ZTMCeRqZAwzuT/ZqZ\n EbjrVNHi3BDg==","\n 3OnYc4reE3mBx0xx2TBrBEdlwziLi7HjDKDFWRUBHfunsKIJDM1QQWrb+BVf58G1M5KJOojGGq\n lI3XkuczvN6g=="],"X-IronPort-AV":["E=McAfee;i=\"6000,8403,9937\"; a=\"178589076\"","E=Sophos;i=\"5.81,285,1610438400\"; d=\"scan'208\";a=\"178589076\"","E=Sophos;i=\"5.81,285,1610438400\"; d=\"scan'208\";a=\"606193074\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=VbvUume1AMZG1bMZ0EK31cV+xchex/cexicm6ztwC/xZQYIxuWC3o4YUu7oHbxu/kHDEEmd/olcsjLAhiwq3Fhc6TViO/G1kPfyz5Ka+rVkb6thfa4HZO7qNvsKBMIss978mmIrc4tSSOumCgtDMARLObK9r89v7Y7S4wzaJEUZSqb3OShD+DrStEdzrbBZEj+PMEPmDSeefTN7NmVlB35fZzE8Fis/0D3kCeT4cxZqUWKkqnxZcyJOKx9xJS7SG7J2MdXygv01DECh8W77ogJXQxoLJm5pyK1NZZJw4cHPd/wKcGdDCQM81/PNEgrfHq0sR6UBUzPwlXx3giicIMQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=/ay8TMmJ++2GJdBf7EWjPTAnf1cCb7gNzJ19byz4mjw=;\n b=YVzKE4WosVRut8kCQTTj//0akhjfIfLdr3SC/zO8EYIzRo14v+nIzzwakYtF5jg9ud6s0tKOyeT+KBiDQqOxF76CRrHWZhZgjv4HgZ7KEqQYRv8ajy8r9UgSDnZdBOhKUh+PgN5oEG0snHNB4/gkXt8mtWFpoO6ymY6j280eW+qqQtp+nQTR5GdT6q+5yZYTbSWMtTs6zMVPTBfeduCwzYekECwGNRlRshEG3kKCZi+DoA6RfX7XLxxpP3XOYEPF0scVyw+I1+h+Y8VD+5/EYafnBHN07rS5Tu4ZS9TxV3ECAom+dKzfKLWC3keo8Nl8ESAfz3OpPj8ff6MbCssBIg==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;\n s=selector2-intel-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=/ay8TMmJ++2GJdBf7EWjPTAnf1cCb7gNzJ19byz4mjw=;\n b=u/DX/kYhvaEdHbMUGTBhNPannLaSs2aqRDefhuYJOx8lA/ZONkC9mEysKJnE+KwH2IjHkNftja78aAwafaR7E8gNsMHdrjIzHD3+J+lcX49p94nISQoVItvKvzdZBu7WyCxMsAZ6S5ZXkhnnag3f8xpqZNyQyU361husRYP8uwY=","From":"\"Tan, Ley Foon\" ","To":"Christophe Leroy , \"will@kernel.org\"\n , \"danielwa@cisco.com\" ,\n \"robh@kernel.org\" , \"daniel@gimpelevich.san-francisco.ca.us\"\n ","Subject":"RE: [PATCH v3 09/17] nios2: Convert to GENERIC_CMDLINE","Thread-Topic":"[PATCH v3 09/17] nios2: Convert to GENERIC_CMDLINE","Thread-Index":"AQHXIkY9EWGkIZwlLUepcXMICy4iU6qaMsdw","Date":"Mon, 29 Mar 2021 01:35:21 +0000","Message-ID":"\n ","References":"\n <85b1dc6339351cbc46d179e8fdb9dfc398e58303.1616765870.git.christophe.leroy@csgroup.eu>","In-Reply-To":"\n <85b1dc6339351cbc46d179e8fdb9dfc398e58303.1616765870.git.christophe.leroy@csgroup.eu>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","dlp-reaction":"no-action","dlp-version":"11.5.1.3","dlp-product":"dlpe-windows","authentication-results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=intel.onmicrosoft.com header.i=@intel.onmicrosoft.com\n header.a=rsa-sha256 header.s=selector2-intel-onmicrosoft-com\n header.b=u/DX/kYh;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=intel.onmicrosoft.com header.i=@intel.onmicrosoft.com\n header.a=rsa-sha256 header.s=selector2-intel-onmicrosoft-com\n header.b=u/DX/kYh;\n\tdkim-atps=neutral","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=intel.com (client-ip=134.134.136.20; helo=mga02.intel.com;\n envelope-from=ley.foon.tan@intel.com; receiver=)","lists.ozlabs.org; dkim=pass (1024-bit key;\n unprotected) header.d=intel.onmicrosoft.com header.i=@intel.onmicrosoft.com\n header.a=rsa-sha256 header.s=selector2-intel-onmicrosoft-com\n header.b=u/DX/kYh; dkim-atps=neutral","csgroup.eu; dkim=none (message not signed)\n header.d=none;csgroup.eu; dmarc=none action=none header.from=intel.com;"],"x-originating-ip":"[42.189.153.48]","x-ms-publictraffictype":"Email","x-ms-office365-filtering-correlation-id":"3136e626-5230-45dc-23e7-08d8f252eb33","x-ms-traffictypediagnostic":"BYAPR11MB3253:","x-microsoft-antispam-prvs":"\n ","x-ms-oob-tlc-oobclassifiers":"OLM:6430;","x-ms-exchange-senderadcheck":"1","x-microsoft-antispam":"BCL:0;","x-microsoft-antispam-message-info":"\n sp4Dol+Ce3nl3hU/fv/D/GUIKDOUypkeJE/zMbaTQm+QnbmSVuL0jjK/ZMXtf2p7SdDLd0pSfuuiImYjWC2pohxUpt1MyaTp/n5BOxXpfN/WBOGp7vCgEznkbRin7gx1gHK5syIi7vYCGx6bo5oW/nQregC+QI2Lc8qopP2qA9DfcDk3t/JvlXYMZq4TEgdN/mJvI6XjsorSmY5zyom8Avm/HFtuAaNjka1tiEhIxIcZtUHfq4l9WC7+J8KYLdl5+olfQCFc7XfDN1T1MZmR4UU/UjID50WgHr/PtQ8N6gYizCrfwNDixADhfDSQmwqUI7NDVT4gWSrBU2L7yDNup4v7Yen8cG9V88vMkCYCborUb5Qdlz75Vsvyu5KuZNQ2okqrZO6KQOXbl3Q128Z8hMeMGBYzb6U58EGDrj1E6cStukiiNcoI0lkl5pLZ+yN7XKJb0yPfvQAC0nSLee/lB67769TkYbOvzbF3t6xeeG6FaLrn+6Fj/1YuIOjE3EZWL50BepT7041SZs3mEYdPjSb4c6g89nDqa70MC1WmyfoN3C38OC8qu38D4qSZqlMzrMkf2AsBvH+HkXAXJLE7g/ve9C0e351D1SjDMD7041qURhXVi7FyjSKfVIDn/IS6p73+6cVBrCMoSjHQPrx7A941nQU7qd0TUDdLvhlRXmqOh3fDsFehe9OH42eV9GNu","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:BY5PR11MB3893.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(39860400002)(346002)(136003)(396003)(366004)(376002)(8936002)(38100700001)(316002)(83380400001)(54906003)(76116006)(66946007)(66446008)(5660300002)(8676002)(66556008)(64756008)(66476007)(7416002)(478600001)(4326008)(110136005)(53546011)(2906002)(55016002)(9686003)(52536014)(86362001)(71200400001)(26005)(33656002)(186003)(7696005)(6506007)(41533002);\n DIR:OUT; SFP:1102;","x-ms-exchange-antispam-messagedata":"\n qG30XGx1ArCsOPyfjuxDCzCGIxsdK9sVdtWTrycEB0bBZl1DAzQSe6MJaEOwfKwOr7ob9iSZmk4lSHK+dVaRvtzc1/vvfzbQuvGjjq8Acx2Uzjj4QOCsAMA46DobvsLMhKufv6PsBcV3FoHHUqhSWwUzakvMWneHFqoyBFMiM5DcQPkxEM+VeoArLPer2IGntmEqs8mNnmHIWABfd2uDS5oWEMD13fIoX9Schn07FRRHAotIRXTrVZaAFm1qOg8y4JPH/YtfoxlbbS1lgxPRBi4ny36JeHdFCW77OFP1D8ualSB0vBoDd2qIhw8PXL3tiYfAkmy0ET/r/MeWMvWtX0gjZFD2rckSu3fd/4yZ6d6P/njxZCCFWAyZl6DFrlJClVFIf2Lu1DP7hRNLwM4eQuz3fqzEHDed87LkZvDH5sav+GwpUUjw1RAbwi16nHC5xwxiL1uiYiamrbDrv/ra4h2lXmCmF/ykTzrhiYhxuYTgLsRxNJ5HZv7WzkEigvdq0QsCLlqyDgdkj+/0z/cLrVNeb80W2wSvn8REbgHtejy1n3/b3om8NSEe+R7xgkTseEnFIbhj+aFJe7qKZdmBkiY5do1zP2icP3vdavYhTj81JRCeI5R1Y13JoAJpEQnx/Cu9tdAQJx9fhM8luiyn6mV3ygmDJvjUTGSknoQWLBNjAO7C7lNzb0t0MHV6qNi45QV+YMyMBpBsuiMpAK0rEuaMuYOvSZZwWdMjwLjULKPtX65KFgs7u0H4QZG+lIyfESMcu5K4mKfOljfN4MHne8IAXdoQUU8SvOodGvEAnDT9H1PJetgxUfiC7oa04tEGtEt1KG7caia5+lQEMGpVKDQPNDi2d0OyKUjRJ+J1uth0georYToydJMdG0wIY4rb5xgBHXQJUFQfhTpHiTUAMD1fBoD9QkAyKkRiByUTj5AyqM4vWkUnO7K4+XZpwNVkLjomyGnfjOrMIfrLfAIysCBW3G6xwqnpWtPjgV9mcvUMDP9+JDlNMmaKQlEp+x9xQ/mpCxZu0BeG/6dE9aBUXXPxCI4MSTFbcnMKDa+snCvmFI+KMamONbGCJU6yudXQYXtJqOUIWiSTlokL9qu1xx/vgyDTMcL8u2ArLjpFJbp2ScplBcPTS2lWf5mcn0q83OUpHuGioRBeopGLkqtbHsweMOEpW5EDjXkz5U/gBcGfkI8J00xd41Yk5sgyWZfN1omxCwnXbq2CVn2RXoaeI9MP2NYS5GKpAuj4U4wm6Zsd0FbDXcF1H84zchNGCeIKFBgW6tI18NFXDiOExz+Ra5daCgTs2LyAEDCfdxMRJ2gtbbxgIAD8YK/c+DHzOsrf","x-ms-exchange-transport-forked":"True","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"BY5PR11MB3893.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 3136e626-5230-45dc-23e7-08d8f252eb33","X-MS-Exchange-CrossTenant-originalarrivaltime":"29 Mar 2021 01:35:21.8933 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n EORUlTAMEmVGyPJ9IXxT10ifW8qQlyWaELYLStNmnpr+Szh6mpMwUAPTHgqsnwEvoe/BmzqwOe5+1m1EIpQbUA==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BYAPR11MB3253","X-OriginatorOrg":"intel.com","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"\"linux-arch@vger.kernel.org\" ,\n \"devicetree@vger.kernel.org\" ,\n microblaze ,\n \"linux-xtensa@linux-xtensa.org\" ,\n \"linux-sh@vger.kernel.org\" ,\n \"linux-hexagon@vger.kernel.org\" ,\n \"x86@kernel.org\" ,\n \"linux-kernel@vger.kernel.org\" ,\n \"linux-mips@vger.kernel.org\" ,\n \"openrisc@lists.librecores.org\" ,\n \"sparclinux@vger.kernel.org\" ,\n \"linux-riscv@lists.infradead.org\" ,\n \"linuxppc-dev@lists.ozlabs.org\" ,\n \"linux-arm-kernel@lists.infradead.org\" ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2660465,"web_url":"http://patchwork.ozlabs.org/comment/2660465/","msgid":"<18f89697-5612-6a1a-ab9d-8842c1b943db@csgroup.eu>","date":"2021-04-02T15:33:59","subject":"Re: [PATCH v3 09/17] nios2: Convert to GENERIC_CMDLINE","submitter":{"id":79086,"url":"http://patchwork.ozlabs.org/api/people/79086/","name":"Christophe Leroy","email":"christophe.leroy@csgroup.eu"},"content":"Le 29/03/2021 à 03:35, Tan, Ley Foon a écrit :\n> \n> \n>> -----Original Message-----\n>> From: Christophe Leroy \n>> Sent: Friday, March 26, 2021 9:45 PM\n>> To: will@kernel.org; danielwa@cisco.com; robh@kernel.org;\n>> daniel@gimpelevich.san-francisco.ca.us\n>> Cc: linux-arch@vger.kernel.org; devicetree@vger.kernel.org; linuxppc-\n>> dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; linuxppc-\n>> dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org; microblaze\n>> ; linux-mips@vger.kernel.org; Tan, Ley Foon\n>> ; openrisc@lists.librecores.org; linux-\n>> hexagon@vger.kernel.org; linux-riscv@lists.infradead.org; x86@kernel.org;\n>> linux-xtensa@linux-xtensa.org; linux-sh@vger.kernel.org;\n>> sparclinux@vger.kernel.org\n>> Subject: [PATCH v3 09/17] nios2: Convert to GENERIC_CMDLINE\n>>\n>> This converts the architecture to GENERIC_CMDLINE.\n>>\n>> Signed-off-by: Christophe Leroy \n>> ---\n>> arch/nios2/Kconfig | 24 +-----------------------\n>> arch/nios2/kernel/setup.c | 13 ++++---------\n>> 2 files changed, 5 insertions(+), 32 deletions(-)\n>>\n>> diff --git a/arch/nios2/Kconfig b/arch/nios2/Kconfig index\n>> c24955c81c92..f66c97b15813 100644\n>> --- a/arch/nios2/Kconfig\n>> +++ b/arch/nios2/Kconfig\n>> @@ -90,31 +90,9 @@ config NIOS2_ALIGNMENT_TRAP\n>>\n>> comment \"Boot options\"\n>>\n>> -config CMDLINE_BOOL\n>> -\tbool \"Default bootloader kernel arguments\"\n>> -\tdefault y\n>> -\n>> -config CMDLINE\n>> -\tstring \"Default kernel command string\"\n>> -\tdefault \"\"\n>> -\tdepends on CMDLINE_BOOL\n>> -\thelp\n>> -\t On some platforms, there is currently no way for the boot loader to\n>> -\t pass arguments to the kernel. For these platforms, you can supply\n>> -\t some command-line options at build time by entering them here. In\n>> -\t other cases you can specify kernel args so that you don't have\n>> -\t to set them up in board prom initialization routines.\n>> -\n>> -config CMDLINE_FORCE\n>> -\tbool \"Force default kernel command string\"\n>> -\tdepends on CMDLINE_BOOL\n>> -\thelp\n>> -\t Set this to have arguments from the default kernel command string\n>> -\t override those passed by the boot loader.\n>> -\n>> config NIOS2_CMDLINE_IGNORE_DTB\n>> \tbool \"Ignore kernel command string from DTB\"\n>> -\tdepends on CMDLINE_BOOL\n>> +\tdepends on CMDLINE != \"\"\n>> \tdepends on !CMDLINE_FORCE\n>> \tdefault y\n>> \thelp\n> \n> Missing \" select GENERIC_CMDLINE\" ?\n\nAdded in v4\n\nThanks\nChristophe","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=csgroup.eu (client-ip=93.17.236.30; helo=pegase1.c-s.fr;\n envelope-from=christophe.leroy@csgroup.eu; receiver=)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4FBkcY00nHz9sRK\n\tfor ; Sat, 3 Apr 2021 02:34:20 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4FBkcX5wnqz3djt\n\tfor ; Sat, 3 Apr 2021 02:34:20 +1100 (AEDT)","from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4FBkcF3CwBz2yxx\n for ; Sat, 3 Apr 2021 02:34:04 +1100 (AEDT)","from localhost (mailhub1-int [192.168.12.234])\n by localhost (Postfix) with ESMTP id 4FBkc810p9z9v2m9;\n Fri, 2 Apr 2021 17:34:00 +0200 (CEST)","from pegase1.c-s.fr ([192.168.12.234])\n by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024)\n with ESMTP id E-R23ddmhdI0; Fri, 2 Apr 2021 17:34:00 +0200 (CEST)","from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192])\n by pegase1.c-s.fr (Postfix) with ESMTP id 4FBkc76Npnz9v2m8;\n Fri, 2 Apr 2021 17:33:59 +0200 (CEST)","from localhost (localhost [127.0.0.1])\n by messagerie.si.c-s.fr (Postfix) with ESMTP id CE3098BB77;\n Fri, 2 Apr 2021 17:34:01 +0200 (CEST)","from messagerie.si.c-s.fr ([127.0.0.1])\n by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023)\n with ESMTP id KbAlGNza6YEe; Fri, 2 Apr 2021 17:34:01 +0200 (CEST)","from [192.168.4.90] (unknown [192.168.4.90])\n by messagerie.si.c-s.fr (Postfix) with ESMTP id 9C1048BB6F;\n Fri, 2 Apr 2021 17:34:00 +0200 (CEST)"],"X-Virus-Scanned":["Debian amavisd-new at c-s.fr","amavisd-new at c-s.fr"],"Subject":"Re: [PATCH v3 09/17] nios2: Convert to GENERIC_CMDLINE","To":"\"Tan, Ley Foon\" ,\n \"will@kernel.org\" , \"danielwa@cisco.com\"\n , \"robh@kernel.org\" ,\n \"daniel@gimpelevich.san-francisco.ca.us\"\n ","References":"\n <85b1dc6339351cbc46d179e8fdb9dfc398e58303.1616765870.git.christophe.leroy@csgroup.eu>\n ","From":"Christophe Leroy ","Message-ID":"<18f89697-5612-6a1a-ab9d-8842c1b943db@csgroup.eu>","Date":"Fri, 2 Apr 2021 17:33:59 +0200","User-Agent":"Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101\n Thunderbird/78.9.0","MIME-Version":"1.0","In-Reply-To":"\n ","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"fr","Content-Transfer-Encoding":"8bit","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"\"linux-arch@vger.kernel.org\" ,\n \"devicetree@vger.kernel.org\" ,\n microblaze ,\n \"linux-xtensa@linux-xtensa.org\" ,\n \"linux-sh@vger.kernel.org\" ,\n \"linux-hexagon@vger.kernel.org\" ,\n \"x86@kernel.org\" ,\n \"linux-kernel@vger.kernel.org\" ,\n \"linux-mips@vger.kernel.org\" ,\n \"openrisc@lists.librecores.org\" ,\n \"sparclinux@vger.kernel.org\" ,\n \"linux-riscv@lists.infradead.org\" ,\n \"linuxppc-dev@lists.ozlabs.org\" ,\n \"linux-arm-kernel@lists.infradead.org\" ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}}]