[{"id":2656341,"web_url":"http://patchwork.ozlabs.org/comment/2656341/","msgid":"","date":"2021-03-26T15:47:04","subject":"Re: [PATCH v3 05/17] arm: Convert to GENERIC_CMDLINE","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Fri, Mar 26, 2021 at 7:44 AM Christophe Leroy\n wrote:\n>\n> This converts the architecture to GENERIC_CMDLINE.\n>\n> Signed-off-by: Christophe Leroy \n> ---\n> arch/arm/Kconfig | 38 +----------------------------------\n> arch/arm/kernel/atags_parse.c | 15 +++++---------\n> 2 files changed, 6 insertions(+), 47 deletions(-)\n>\n> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig\n> index 5da96f5df48f..67bc75f2da81 100644\n> --- a/arch/arm/Kconfig\n> +++ b/arch/arm/Kconfig\n> @@ -50,6 +50,7 @@ config ARM\n> select GENERIC_ARCH_TOPOLOGY if ARM_CPU_TOPOLOGY\n> select GENERIC_ATOMIC64 if CPU_V7M || CPU_V6 || !CPU_32v6K || !AEABI\n> select GENERIC_CLOCKEVENTS_BROADCAST if SMP\n> + select GENERIC_CMDLINE if ATAGS\n\nDon't we need this enabled for !ATAGS (i.e. DT boot)?\n\nCan we always enable GENERIC_CMDLINE for OF_EARLY_FLATTREE?\n\nRob","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=AcCDpzU7;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=AcCDpzU7;\n\tdkim-atps=neutral","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org;\n envelope-from=robh@kernel.org; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=AcCDpzU7;\n dkim-atps=neutral"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4F6RF84zjtz9sRf\n\tfor ; Sat, 27 Mar 2021 02:47:40 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4F6RF83sv3z3c4B\n\tfor ; Sat, 27 Mar 2021 02:47:40 +1100 (AEDT)","from mail.kernel.org (mail.kernel.org [198.145.29.99])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4F6RDn2zbjz3btB\n for ; Sat, 27 Mar 2021 02:47:21 +1100 (AEDT)","by mail.kernel.org (Postfix) with ESMTPSA id D7F3E61A1E\n for ; Fri, 26 Mar 2021 15:47:18 +0000 (UTC)","by mail-ed1-f45.google.com with SMTP id e7so6800801edu.10\n for ; Fri, 26 Mar 2021 08:47:18 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1616773639;\n bh=FOq/AGTP4gWQcAqm6gE3CbPMoPZd/s7+r0gDFMG3q6U=;\n h=References:In-Reply-To:From:Date:Subject:To:Cc:From;\n b=AcCDpzU7tp9iwdGG8gDfzEHT/oRIXsIga7wXxu53WqUJhT2ul2T9YDS65RNqPU2n3\n Xvn+RFssUybeWEZgEY2lh1i4UxjZPbwmKsgliPvp0IToMiB2a/WA5KR9z10HdDinOv\n UYM5sw/0IvqfBsKxROncwVaSX/vsAHxPYgALR1dSYHioveObkwXiHIvFx1Yj/tNdZJ\n KMRbv1ObJxkt+zXV5bOiWGyn/1VwvDn/9VCA4p517RmAt9EEHqYSMNig8Oj+y1Zu4e\n B4aIe1rurjyjKfoN2EcYkT1/pA82eHFw94cAgT8CIulbihfa0tOaUKwaviLlzc9Bb9\n p9VnLj0VX7D0A==","X-Gm-Message-State":"AOAM5336Iobs7JYlApBA/03UMz5e1UtUWI/dMIJc7dpPoM4VFRSUw5kY\n WtAbjsYRNkpVrjflFP6F96Fpnpy8jFAqrGTt0A==","X-Google-Smtp-Source":"\n ABdhPJyGMjMWznP/BbCajkt9nas+eMG/Qmwgar26pPUJYE7aEhO5sSz0Y/IOGFJNx4RiD0k/WjxUTeg0KAhhn6cQx0c=","X-Received":"by 2002:a05:6402:c88:: with SMTP id\n cm8mr15784199edb.62.1616773637523;\n Fri, 26 Mar 2021 08:47:17 -0700 (PDT)","MIME-Version":"1.0","References":"\n <7362e4f6a5f5b79e6ad3fd3cec3183a4a283f7fc.1616765870.git.christophe.leroy@csgroup.eu>","In-Reply-To":"\n <7362e4f6a5f5b79e6ad3fd3cec3183a4a283f7fc.1616765870.git.christophe.leroy@csgroup.eu>","From":"Rob Herring ","Date":"Fri, 26 Mar 2021 09:47:04 -0600","X-Gmail-Original-Message-ID":"\n ","Message-ID":"\n ","Subject":"Re: [PATCH v3 05/17] arm: Convert to GENERIC_CMDLINE","To":"Christophe Leroy ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"\"open list:GENERIC INCLUDE/ASM HEADER FILES\" ,\n devicetree@vger.kernel.org, microblaze ,\n Daniel Gimpelevich ,\n linux-xtensa@linux-xtensa.org, SH-Linux ,\n Will Deacon , X86 ML ,\n \"linux-kernel@vger.kernel.org\" ,\n nios2 ,\n \"open list:MIPS\" ,\n Openrisc , linux-hexagon@vger.kernel.org,\n sparclinux ,\n linux-riscv ,\n linuxppc-dev ,\n linux-arm-kernel ,\n Daniel Walker ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2656345,"web_url":"http://patchwork.ozlabs.org/comment/2656345/","msgid":"","date":"2021-03-26T15:49:58","subject":"Re: [PATCH v3 05/17] arm: Convert to GENERIC_CMDLINE","submitter":{"id":79086,"url":"http://patchwork.ozlabs.org/api/people/79086/","name":"Christophe Leroy","email":"christophe.leroy@csgroup.eu"},"content":"Le 26/03/2021 à 16:47, Rob Herring a écrit :\n> On Fri, Mar 26, 2021 at 7:44 AM Christophe Leroy\n> wrote:\n>>\n>> This converts the architecture to GENERIC_CMDLINE.\n>>\n>> Signed-off-by: Christophe Leroy \n>> ---\n>> arch/arm/Kconfig | 38 +----------------------------------\n>> arch/arm/kernel/atags_parse.c | 15 +++++---------\n>> 2 files changed, 6 insertions(+), 47 deletions(-)\n>>\n>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig\n>> index 5da96f5df48f..67bc75f2da81 100644\n>> --- a/arch/arm/Kconfig\n>> +++ b/arch/arm/Kconfig\n>> @@ -50,6 +50,7 @@ config ARM\n>> select GENERIC_ARCH_TOPOLOGY if ARM_CPU_TOPOLOGY\n>> select GENERIC_ATOMIC64 if CPU_V7M || CPU_V6 || !CPU_32v6K || !AEABI\n>> select GENERIC_CLOCKEVENTS_BROADCAST if SMP\n>> + select GENERIC_CMDLINE if ATAGS\n> \n> Don't we need this enabled for !ATAGS (i.e. DT boot)?\n> \n> Can we always enable GENERIC_CMDLINE for OF_EARLY_FLATTREE?\n> \n\nDon't know.\n\nToday ARM has:\n\nchoice\n\tprompt \"Kernel command line type\" if CMDLINE != \"\"\n\tdefault CMDLINE_FROM_BOOTLOADER\n\tdepends on ATAGS\n\n\n\nChristophe","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=csgroup.eu (client-ip=93.17.236.30; helo=pegase1.c-s.fr;\n envelope-from=christophe.leroy@csgroup.eu; receiver=)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4F6RJK3t3rz9sS8\n\tfor ; Sat, 27 Mar 2021 02:50:22 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4F6RJG3PNgz3c30\n\tfor ; Sat, 27 Mar 2021 02:50:22 +1100 (AEDT)","from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4F6RHy74y1z3bv7\n for ; Sat, 27 Mar 2021 02:50:03 +1100 (AEDT)","from localhost (mailhub1-int [192.168.12.234])\n by localhost (Postfix) with ESMTP id 4F6RHp3FcVz9v0N7;\n Fri, 26 Mar 2021 16:49:58 +0100 (CET)","from pegase1.c-s.fr ([192.168.12.234])\n by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024)\n with ESMTP id GMS7qKW9a4qh; Fri, 26 Mar 2021 16:49:58 +0100 (CET)","from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192])\n by pegase1.c-s.fr (Postfix) with ESMTP id 4F6RHp1M13z9v0N3;\n Fri, 26 Mar 2021 16:49:58 +0100 (CET)","from localhost (localhost [127.0.0.1])\n by messagerie.si.c-s.fr (Postfix) with ESMTP id C764C8B8D7;\n Fri, 26 Mar 2021 16:49:59 +0100 (CET)","from messagerie.si.c-s.fr ([127.0.0.1])\n by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023)\n with ESMTP id UQFsEfZGymR7; Fri, 26 Mar 2021 16:49:59 +0100 (CET)","from [192.168.4.90] (unknown [192.168.4.90])\n by messagerie.si.c-s.fr (Postfix) with ESMTP id CD5ED8B8C7;\n Fri, 26 Mar 2021 16:49:58 +0100 (CET)"],"X-Virus-Scanned":["Debian amavisd-new at c-s.fr","amavisd-new at c-s.fr"],"Subject":"Re: [PATCH v3 05/17] arm: Convert to GENERIC_CMDLINE","To":"Rob Herring ","References":"\n <7362e4f6a5f5b79e6ad3fd3cec3183a4a283f7fc.1616765870.git.christophe.leroy@csgroup.eu>\n ","From":"Christophe Leroy ","Message-ID":"","Date":"Fri, 26 Mar 2021 16:49:58 +0100","User-Agent":"Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101\n Thunderbird/78.9.0","MIME-Version":"1.0","In-Reply-To":"\n ","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"fr","Content-Transfer-Encoding":"8bit","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"\"open list:GENERIC INCLUDE/ASM HEADER FILES\" ,\n devicetree@vger.kernel.org, microblaze ,\n Daniel Gimpelevich ,\n linux-xtensa@linux-xtensa.org, SH-Linux ,\n Will Deacon , X86 ML ,\n \"linux-kernel@vger.kernel.org\" ,\n nios2 ,\n \"open list:MIPS\" ,\n Openrisc , linux-hexagon@vger.kernel.org,\n sparclinux ,\n linux-riscv ,\n linuxppc-dev ,\n linux-arm-kernel ,\n Daniel Walker ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2656455,"web_url":"http://patchwork.ozlabs.org/comment/2656455/","msgid":"","date":"2021-03-26T18:22:04","subject":"Re: [PATCH v3 05/17] arm: Convert to GENERIC_CMDLINE","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"+Nico who added the line in question.\n\nOn Fri, Mar 26, 2021 at 9:50 AM Christophe Leroy\n wrote:\n>\n>\n>\n> Le 26/03/2021 à 16:47, Rob Herring a écrit :\n> > On Fri, Mar 26, 2021 at 7:44 AM Christophe Leroy\n> > wrote:\n> >>\n> >> This converts the architecture to GENERIC_CMDLINE.\n> >>\n> >> Signed-off-by: Christophe Leroy \n> >> ---\n> >> arch/arm/Kconfig | 38 +----------------------------------\n> >> arch/arm/kernel/atags_parse.c | 15 +++++---------\n> >> 2 files changed, 6 insertions(+), 47 deletions(-)\n> >>\n> >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig\n> >> index 5da96f5df48f..67bc75f2da81 100644\n> >> --- a/arch/arm/Kconfig\n> >> +++ b/arch/arm/Kconfig\n> >> @@ -50,6 +50,7 @@ config ARM\n> >> select GENERIC_ARCH_TOPOLOGY if ARM_CPU_TOPOLOGY\n> >> select GENERIC_ATOMIC64 if CPU_V7M || CPU_V6 || !CPU_32v6K || !AEABI\n> >> select GENERIC_CLOCKEVENTS_BROADCAST if SMP\n> >> + select GENERIC_CMDLINE if ATAGS\n> >\n> > Don't we need this enabled for !ATAGS (i.e. DT boot)?\n> >\n> > Can we always enable GENERIC_CMDLINE for OF_EARLY_FLATTREE?\n> >\n>\n> Don't know.\n>\n> Today ARM has:\n>\n> choice\n> prompt \"Kernel command line type\" if CMDLINE != \"\"\n> default CMDLINE_FROM_BOOTLOADER\n> depends on ATAGS\n\nI think that's a mistake. In a DT only case (no ATAGS), we'll get\ndifferent behaviour (in fdt.c) depending if CONFIG_ATAGS is enabled or\nnot. Note that at the time (2012) the above was added, the DT code\nonly supported CONFIG_CMDLINE and CONFIG_CMDLINE_FORCE.\nCONFIG_CMDLINE_EXTEND was only added in 2016. And that has different\nbehavior for ATAGS vs. DT. In summary, it's a mess. We should drop the\ndepends either before this patch or just as part of this patch IMO.\nI'd go with the latter given CONFIG_ATAGS is default y and enabled for\ncommon configs. Without that, it looks like CONFIG_CMDLINE disappears\nfrom menuconfig for at91_dt_defconfig.\n\nAlso, I think this code should be refactored a bit to eliminate\ndefault_command_line. Instead, we should just save a pointer to the\nATAGS command line string, and then call cmdline_build here instead of\ndoing the extra copy:\n\n /* parse_early_param needs a boot_command_line */\n strlcpy(boot_command_line, from, COMMAND_LINE_SIZE);\n\nRob","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=FGNMBA2S;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=FGNMBA2S;\n\tdkim-atps=neutral","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org;\n envelope-from=robh@kernel.org; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=FGNMBA2S;\n dkim-atps=neutral"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4F6Vh14qMJz9sVS\n\tfor ; Sat, 27 Mar 2021 05:22:41 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4F6Vh13nfcz3c55\n\tfor ; Sat, 27 Mar 2021 05:22:41 +1100 (AEDT)","from mail.kernel.org (mail.kernel.org [198.145.29.99])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4F6Vgd3QjTz3btQ\n for ; Sat, 27 Mar 2021 05:22:21 +1100 (AEDT)","by mail.kernel.org (Postfix) with ESMTPSA id E215261A38\n for ; Fri, 26 Mar 2021 18:22:17 +0000 (UTC)","by mail-ed1-f49.google.com with SMTP id y6so7388196eds.1\n for ; Fri, 26 Mar 2021 11:22:17 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1616782938;\n bh=jLGR+NyehSUNZVl5kh+mHpluJzlAfSJXFMkJ5QFHPLQ=;\n h=References:In-Reply-To:From:Date:Subject:To:Cc:From;\n b=FGNMBA2S+sqoHCfdgN2xPFLdvY7w1ubfGycnYplAm5Xuh33eTfteivyAovekbWA9w\n yfld9bMxHjPtk6Hhklpu7oYZIbdFL1ljaGBXqC5JDt9yKBlTX7kAx1myFZ7wuAQTTU\n jVdlWWeH+3FguNaGmIau3X7NuPSKeRLNaH0udlAHqHLaTI2Nh59I0ILOAppKs8o8/D\n 19qHEC4fCaQI1gejM6rW9sLEbEJ8sx1EuiN8eQS9UBjNdK2v5TM+H9geJCe0fg2Uua\n hTXju+20flSq1dpCUtji3RjvYCP8L0pwpr+4Ldr1Bi1ZJpawqdb9WedZVTTF9eqZAI\n +O7oIbfohruuw==","X-Gm-Message-State":"AOAM530dOoxrKu1inJTyFFdBJsFpUkYfkTjy3Ka8Yo5/fVvjl9HEZpuK\n KUHlrOiLKqfJKw9M5RelDKExNtS44nEtB7yJXw==","X-Google-Smtp-Source":"\n ABdhPJzge00Chol2o+zcxsCiGngmRlWpn0gXJpTNd7PjgqCsH3Y9wanEoRXm0NadwDvEZ6TqBdnoQxNSvLg0UG9tpaw=","X-Received":"by 2002:a05:6402:c0f:: with SMTP id\n co15mr16452718edb.373.1616782936426;\n Fri, 26 Mar 2021 11:22:16 -0700 (PDT)","MIME-Version":"1.0","References":"\n <7362e4f6a5f5b79e6ad3fd3cec3183a4a283f7fc.1616765870.git.christophe.leroy@csgroup.eu>\n \n ","In-Reply-To":"","From":"Rob Herring ","Date":"Fri, 26 Mar 2021 12:22:04 -0600","X-Gmail-Original-Message-ID":"\n ","Message-ID":"\n ","Subject":"Re: [PATCH v3 05/17] arm: Convert to GENERIC_CMDLINE","To":"Christophe Leroy ,\n Nicolas Pitre ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"\"open list:GENERIC INCLUDE/ASM HEADER FILES\" ,\n devicetree@vger.kernel.org, microblaze ,\n Daniel Gimpelevich ,\n linux-xtensa@linux-xtensa.org, SH-Linux ,\n Will Deacon , X86 ML ,\n \"linux-kernel@vger.kernel.org\" ,\n nios2 ,\n \"open list:MIPS\" ,\n Openrisc , linux-hexagon@vger.kernel.org,\n sparclinux ,\n linux-riscv ,\n linuxppc-dev ,\n linux-arm-kernel ,\n Daniel Walker ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2660446,"web_url":"http://patchwork.ozlabs.org/comment/2660446/","msgid":"","date":"2021-04-02T15:19:02","subject":"Re: [PATCH v3 05/17] arm: Convert to GENERIC_CMDLINE","submitter":{"id":79086,"url":"http://patchwork.ozlabs.org/api/people/79086/","name":"Christophe Leroy","email":"christophe.leroy@csgroup.eu"},"content":"Le 26/03/2021 à 16:47, Rob Herring a écrit :\n> On Fri, Mar 26, 2021 at 7:44 AM Christophe Leroy\n> wrote:\n>>\n>> This converts the architecture to GENERIC_CMDLINE.\n>>\n>> Signed-off-by: Christophe Leroy \n>> ---\n>> arch/arm/Kconfig | 38 +----------------------------------\n>> arch/arm/kernel/atags_parse.c | 15 +++++---------\n>> 2 files changed, 6 insertions(+), 47 deletions(-)\n>>\n>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig\n>> index 5da96f5df48f..67bc75f2da81 100644\n>> --- a/arch/arm/Kconfig\n>> +++ b/arch/arm/Kconfig\n>> @@ -50,6 +50,7 @@ config ARM\n>> select GENERIC_ARCH_TOPOLOGY if ARM_CPU_TOPOLOGY\n>> select GENERIC_ATOMIC64 if CPU_V7M || CPU_V6 || !CPU_32v6K || !AEABI\n>> select GENERIC_CLOCKEVENTS_BROADCAST if SMP\n>> + select GENERIC_CMDLINE if ATAGS\n> \n> Don't we need this enabled for !ATAGS (i.e. DT boot)?\n> \n> Can we always enable GENERIC_CMDLINE for OF_EARLY_FLATTREE?\n> \n\nDone in v4","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=csgroup.eu (client-ip=93.17.236.30; helo=pegase1.c-s.fr;\n envelope-from=christophe.leroy@csgroup.eu; receiver=)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4FBkQv40mnz9sRf\n\tfor ; Sat, 3 Apr 2021 02:25:59 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4FBkQv3CJtz3dBl\n\tfor ; Sat, 3 Apr 2021 02:25:59 +1100 (AEDT)","from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4FBkGx2TNBz3c0Q\n for ; Sat, 3 Apr 2021 02:19:05 +1100 (AEDT)","from localhost (mailhub1-int [192.168.12.234])\n by localhost (Postfix) with ESMTP id 4FBkGs0CTbz9v2lt;\n Fri, 2 Apr 2021 17:19:01 +0200 (CEST)","from pegase1.c-s.fr ([192.168.12.234])\n by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024)\n with ESMTP id HHSKL_ERdXgd; Fri, 2 Apr 2021 17:19:00 +0200 (CEST)","from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192])\n by pegase1.c-s.fr (Postfix) with ESMTP id 4FBkGr6FdVz9v2ls;\n Fri, 2 Apr 2021 17:19:00 +0200 (CEST)","from localhost (localhost [127.0.0.1])\n by messagerie.si.c-s.fr (Postfix) with ESMTP id CCFD78BB79;\n Fri, 2 Apr 2021 17:19:02 +0200 (CEST)","from messagerie.si.c-s.fr ([127.0.0.1])\n by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023)\n with ESMTP id 9kCnw8bE6TtL; Fri, 2 Apr 2021 17:19:02 +0200 (CEST)","from [192.168.4.90] (unknown [192.168.4.90])\n by messagerie.si.c-s.fr (Postfix) with ESMTP id AD03A8BB7C;\n Fri, 2 Apr 2021 17:19:01 +0200 (CEST)"],"X-Virus-Scanned":["Debian amavisd-new at c-s.fr","amavisd-new at c-s.fr"],"Subject":"Re: [PATCH v3 05/17] arm: Convert to GENERIC_CMDLINE","To":"Rob Herring ","References":"\n <7362e4f6a5f5b79e6ad3fd3cec3183a4a283f7fc.1616765870.git.christophe.leroy@csgroup.eu>\n ","From":"Christophe Leroy ","Message-ID":"","Date":"Fri, 2 Apr 2021 17:19:02 +0200","User-Agent":"Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101\n Thunderbird/78.9.0","MIME-Version":"1.0","In-Reply-To":"\n ","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"fr","Content-Transfer-Encoding":"8bit","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"\"open list:GENERIC INCLUDE/ASM HEADER FILES\" ,\n devicetree@vger.kernel.org, microblaze ,\n Daniel Gimpelevich ,\n linux-xtensa@linux-xtensa.org, SH-Linux ,\n Will Deacon , X86 ML ,\n \"linux-kernel@vger.kernel.org\" ,\n nios2 ,\n \"open list:MIPS\" ,\n Openrisc , linux-hexagon@vger.kernel.org,\n sparclinux ,\n linux-riscv ,\n linuxppc-dev ,\n linux-arm-kernel ,\n Daniel Walker ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2660452,"web_url":"http://patchwork.ozlabs.org/comment/2660452/","msgid":"<84ca838c-d77b-0142-7f45-b8b95c03d81e@csgroup.eu>","date":"2021-04-02T15:24:05","subject":"Re: [PATCH v3 05/17] arm: Convert to GENERIC_CMDLINE","submitter":{"id":79086,"url":"http://patchwork.ozlabs.org/api/people/79086/","name":"Christophe Leroy","email":"christophe.leroy@csgroup.eu"},"content":"Le 26/03/2021 à 16:47, Rob Herring a écrit :\n> On Fri, Mar 26, 2021 at 7:44 AM Christophe Leroy\n> wrote:\n>>\n>> This converts the architecture to GENERIC_CMDLINE.\n>>\n>> Signed-off-by: Christophe Leroy \n>> ---\n>> arch/arm/Kconfig | 38 +----------------------------------\n>> arch/arm/kernel/atags_parse.c | 15 +++++---------\n>> 2 files changed, 6 insertions(+), 47 deletions(-)\n>>\n>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig\n>> index 5da96f5df48f..67bc75f2da81 100644\n>> --- a/arch/arm/Kconfig\n>> +++ b/arch/arm/Kconfig\n>> @@ -50,6 +50,7 @@ config ARM\n>> select GENERIC_ARCH_TOPOLOGY if ARM_CPU_TOPOLOGY\n>> select GENERIC_ATOMIC64 if CPU_V7M || CPU_V6 || !CPU_32v6K || !AEABI\n>> select GENERIC_CLOCKEVENTS_BROADCAST if SMP\n>> + select GENERIC_CMDLINE if ATAGS\n> \n> Don't we need this enabled for !ATAGS (i.e. DT boot)?\n> \n> Can we always enable GENERIC_CMDLINE for OF_EARLY_FLATTREE?\n> \n\nYes missed it in v3 after your comment on v2. Done in v4.","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=csgroup.eu (client-ip=93.17.236.30; helo=pegase1.c-s.fr;\n envelope-from=christophe.leroy@csgroup.eu; receiver=)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4FBkSQ3PQ5z9sWK\n\tfor ; Sat, 3 Apr 2021 02:27:18 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4FBkSQ2M9gz3gDb\n\tfor ; Sat, 3 Apr 2021 02:27:18 +1100 (AEDT)","from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4FBkNl6Fhqz3fT5\n for ; Sat, 3 Apr 2021 02:24:07 +1100 (AEDT)","from localhost (mailhub1-int [192.168.12.234])\n by localhost (Postfix) with ESMTP id 4FBkNg3qflz9v2lr;\n Fri, 2 Apr 2021 17:24:03 +0200 (CEST)","from pegase1.c-s.fr ([192.168.12.234])\n by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024)\n with ESMTP id p7d0djYUxLsL; Fri, 2 Apr 2021 17:24:03 +0200 (CEST)","from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192])\n by pegase1.c-s.fr (Postfix) with ESMTP id 4FBkNg2q0Cz9v2lh;\n Fri, 2 Apr 2021 17:24:03 +0200 (CEST)","from localhost (localhost [127.0.0.1])\n by messagerie.si.c-s.fr (Postfix) with ESMTP id 561DF8BB7C;\n Fri, 2 Apr 2021 17:24:05 +0200 (CEST)","from messagerie.si.c-s.fr ([127.0.0.1])\n by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023)\n with ESMTP id Zgwotd5lGVEn; Fri, 2 Apr 2021 17:24:05 +0200 (CEST)","from [192.168.4.90] (unknown [192.168.4.90])\n by messagerie.si.c-s.fr (Postfix) with ESMTP id 5C2EA8BB6F;\n Fri, 2 Apr 2021 17:24:04 +0200 (CEST)"],"X-Virus-Scanned":["Debian amavisd-new at c-s.fr","amavisd-new at c-s.fr"],"Subject":"Re: [PATCH v3 05/17] arm: Convert to GENERIC_CMDLINE","To":"Rob Herring ","References":"\n <7362e4f6a5f5b79e6ad3fd3cec3183a4a283f7fc.1616765870.git.christophe.leroy@csgroup.eu>\n ","From":"Christophe Leroy ","Message-ID":"<84ca838c-d77b-0142-7f45-b8b95c03d81e@csgroup.eu>","Date":"Fri, 2 Apr 2021 17:24:05 +0200","User-Agent":"Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101\n Thunderbird/78.9.0","MIME-Version":"1.0","In-Reply-To":"\n ","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"fr","Content-Transfer-Encoding":"8bit","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"\"open list:GENERIC INCLUDE/ASM HEADER FILES\" ,\n devicetree@vger.kernel.org, microblaze ,\n Daniel Gimpelevich ,\n linux-xtensa@linux-xtensa.org, SH-Linux ,\n Will Deacon , X86 ML ,\n \"linux-kernel@vger.kernel.org\" ,\n nios2 ,\n \"open list:MIPS\" ,\n Openrisc , linux-hexagon@vger.kernel.org,\n sparclinux ,\n linux-riscv ,\n linuxppc-dev ,\n linux-arm-kernel ,\n Daniel Walker ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}}]