[{"id":2644194,"web_url":"http://patchwork.ozlabs.org/comment/2644194/","msgid":"<5f865584-09c9-d21f-ffb7-23cf07cf058e@csgroup.eu>","date":"2021-03-09T07:47:09","subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","submitter":{"id":79086,"url":"http://patchwork.ozlabs.org/api/people/79086/","name":"Christophe Leroy","email":"christophe.leroy@csgroup.eu"},"content":"Le 09/03/2021 à 01:02, Daniel Walker a écrit :\n> This is a scripted mass convert of the config files to use\n> the new generic cmdline. There is a bit of a trim effect here.\n> It would seems that some of the config haven't been trimmed in\n> a while.\n\nIf you do that in a separate patch, you loose bisectability.\n\nI think it would have been better to do things in a different way, more or less like I did in my series:\n1/ Provide GENERIC cmdline at the same functionnality level as what is spread in the different \narchitectures\n2/ Convert architectures to the generic with least churn.\n3/ Add new features to the generic\n\n> \n> The bash script used to convert is as follows,\n> \n> if [[ -z \"$1\" || -z \"$2\" ]]; then\n> echo \"Two arguments are needed.\"\n> exit 1\n> fi\n> mkdir $1\n> cp $2 $1/.config\n> sed -i 's/CONFIG_CMDLINE=/CONFIG_CMDLINE_BOOL=y\\nCONFIG_CMDLINE_PREPEND=/g' $1/.config\n\nThis is not correct.\n\nBy default, on powerpc the provided command line is used only if the bootloader doesn't provide one.\n\nOtherwise:\n- the builtin command line is appended to the one provided by the bootloader if \nCONFIG_CMDLINE_EXTEND is selected\n- the builtin command line replaces to the one provided by the bootloader if CONFIG_CMDLINE_FORCE is \nselected\n\n\n> make ARCH=$1 O=$1 olddefconfig\n> make ARCH=$1 O=$1 savedefconfig\n> cp $1/defconfig $2\n> rm -Rf $1\n> \n> Cc: xe-linux-external@cisco.com\n> Signed-off-by: Daniel Walker \n> ---\n> arch/powerpc/configs/44x/fsp2_defconfig | 33 +++++++++----------\n> arch/powerpc/configs/44x/iss476-smp_defconfig | 25 +++++++-------\n> arch/powerpc/configs/44x/warp_defconfig | 17 +++++-----\n> arch/powerpc/configs/holly_defconfig | 13 ++++----\n> arch/powerpc/configs/mvme5100_defconfig | 23 ++++++-------\n> arch/powerpc/configs/skiroot_defconfig | 12 +++----\n> arch/powerpc/configs/storcenter_defconfig | 18 ++++------\n> 7 files changed, 66 insertions(+), 75 deletions(-)\n> \n> diff --git a/arch/powerpc/configs/44x/fsp2_defconfig b/arch/powerpc/configs/44x/fsp2_defconfig\n> index 30845ce0885a..4993db054589 100644\n> --- a/arch/powerpc/configs/44x/fsp2_defconfig\n> +++ b/arch/powerpc/configs/44x/fsp2_defconfig\n> @@ -1,8 +1,6 @@\n> -CONFIG_44x=y\n> # CONFIG_SWAP is not set\n> CONFIG_SYSVIPC=y\n> # CONFIG_CROSS_MEMORY_ATTACH is not set\n> -# CONFIG_FHANDLE is not set\n> CONFIG_NO_HZ=y\n> CONFIG_HIGH_RES_TIMERS=y\n> CONFIG_IKCONFIG=y\n> @@ -13,24 +11,25 @@ CONFIG_BLK_DEV_INITRD=y\n> # CONFIG_RD_XZ is not set\n> # CONFIG_RD_LZO is not set\n> # CONFIG_RD_LZ4 is not set\n> +# CONFIG_FHANDLE is not set\n> CONFIG_KALLSYMS_ALL=y\n> CONFIG_BPF_SYSCALL=y\n> CONFIG_EMBEDDED=y\n> CONFIG_PROFILING=y\n> -CONFIG_OPROFILE=y\n> -CONFIG_MODULES=y\n> -CONFIG_MODULE_UNLOAD=y\n> -# CONFIG_BLK_DEV_BSG is not set\n> +CONFIG_CMDLINE_BOOL=y\n> +CONFIG_CMDLINE_PREPEND=\"ip=on rw\"\n> +CONFIG_44x=y\n> CONFIG_PPC_47x=y\n> # CONFIG_EBONY is not set\n> CONFIG_FSP2=y\n> CONFIG_476FPE_ERR46=y\n> -CONFIG_SWIOTLB=y\n> CONFIG_KEXEC=y\n> CONFIG_CRASH_DUMP=y\n> -CONFIG_CMDLINE=\"ip=on rw\"\n> # CONFIG_SUSPEND is not set\n> -# CONFIG_PCI is not set\n> +CONFIG_OPROFILE=y\n> +CONFIG_MODULES=y\n> +CONFIG_MODULE_UNLOAD=y\n> +# CONFIG_BLK_DEV_BSG is not set\n> CONFIG_NET=y\n> CONFIG_PACKET=y\n> CONFIG_UNIX=y\n> @@ -47,14 +46,12 @@ CONFIG_MTD=y\n> CONFIG_MTD_BLOCK=y\n> CONFIG_MTD_JEDECPROBE=y\n> CONFIG_MTD_CFI_AMDSTD=y\n> -CONFIG_MTD_PHYSMAP_OF=y\n> CONFIG_BLK_DEV_RAM=y\n> CONFIG_BLK_DEV_RAM_SIZE=35000\n> # CONFIG_SCSI_PROC_FS is not set\n> CONFIG_BLK_DEV_SD=y\n> # CONFIG_SCSI_LOWLEVEL is not set\n> CONFIG_ATA=y\n> -# CONFIG_SATA_PMP is not set\n> # CONFIG_ATA_SFF is not set\n> CONFIG_NETDEVICES=y\n> CONFIG_BONDING=m\n> @@ -63,7 +60,6 @@ CONFIG_IBM_EMAC=m\n> # CONFIG_SERIO is not set\n> # CONFIG_VT is not set\n> # CONFIG_LEGACY_PTYS is not set\n> -# CONFIG_DEVMEM is not set\n> CONFIG_SERIAL_8250=y\n> CONFIG_SERIAL_8250_CONSOLE=y\n> CONFIG_SERIAL_8250_NR_UARTS=32\n> @@ -72,6 +68,7 @@ CONFIG_SERIAL_8250_EXTENDED=y\n> CONFIG_SERIAL_8250_SHARE_IRQ=y\n> CONFIG_SERIAL_OF_PLATFORM=y\n> # CONFIG_HW_RANDOM is not set\n> +# CONFIG_DEVMEM is not set\n> CONFIG_I2C=y\n> CONFIG_I2C_IBM_IIC=y\n> CONFIG_PTP_1588_CLOCK=y\n> @@ -107,6 +104,12 @@ CONFIG_NFS_V3_ACL=y\n> CONFIG_NFS_V4=y\n> CONFIG_ROOT_NFS=y\n> CONFIG_NLS_DEFAULT=\"n\"\n> +CONFIG_CRYPTO_CBC=y\n> +CONFIG_CRYPTO_ECB=y\n> +CONFIG_CRYPTO_PCBC=y\n> +CONFIG_CRYPTO_MD5=y\n> +CONFIG_CRYPTO_DES=y\n> +# CONFIG_CRYPTO_HW is not set\n> CONFIG_XZ_DEC=y\n> CONFIG_PRINTK_TIME=y\n> CONFIG_MESSAGE_LOGLEVEL_DEFAULT=3\n> @@ -114,9 +117,3 @@ CONFIG_DYNAMIC_DEBUG=y\n> CONFIG_DEBUG_INFO=y\n> CONFIG_MAGIC_SYSRQ=y\n> CONFIG_DETECT_HUNG_TASK=y\n> -CONFIG_CRYPTO_CBC=y\n> -CONFIG_CRYPTO_ECB=y\n> -CONFIG_CRYPTO_PCBC=y\n> -CONFIG_CRYPTO_MD5=y\n> -CONFIG_CRYPTO_DES=y\n> -# CONFIG_CRYPTO_HW is not set\n> diff --git a/arch/powerpc/configs/44x/iss476-smp_defconfig b/arch/powerpc/configs/44x/iss476-smp_defconfig\n> index 2c3834eebca3..b8d97061517a 100644\n> --- a/arch/powerpc/configs/44x/iss476-smp_defconfig\n> +++ b/arch/powerpc/configs/44x/iss476-smp_defconfig\n> @@ -1,5 +1,3 @@\n> -CONFIG_44x=y\n> -CONFIG_SMP=y\n> CONFIG_SYSVIPC=y\n> CONFIG_POSIX_MQUEUE=y\n> CONFIG_LOG_BUF_SHIFT=14\n> @@ -7,20 +5,22 @@ CONFIG_BLK_DEV_INITRD=y\n> CONFIG_EXPERT=y\n> CONFIG_KALLSYMS_ALL=y\n> CONFIG_PROFILING=y\n> -CONFIG_OPROFILE=y\n> -CONFIG_MODULES=y\n> -CONFIG_MODULE_UNLOAD=y\n> -# CONFIG_BLK_DEV_BSG is not set\n> +CONFIG_CMDLINE_BOOL=y\n> +CONFIG_CMDLINE_PREPEND=\"root=/dev/issblk0\"\n> +CONFIG_44x=y\n> +CONFIG_SMP=y\n> CONFIG_PPC_47x=y\n> # CONFIG_EBONY is not set\n> CONFIG_ISS4xx=y\n> CONFIG_HZ_100=y\n> CONFIG_MATH_EMULATION=y\n> CONFIG_IRQ_ALL_CPUS=y\n> -CONFIG_CMDLINE=\"root=/dev/issblk0\"\n> -# CONFIG_PCI is not set\n> CONFIG_ADVANCED_OPTIONS=y\n> CONFIG_DYNAMIC_MEMSTART=y\n> +CONFIG_OPROFILE=y\n> +CONFIG_MODULES=y\n> +CONFIG_MODULE_UNLOAD=y\n> +# CONFIG_BLK_DEV_BSG is not set\n> CONFIG_NET=y\n> CONFIG_PACKET=y\n> CONFIG_UNIX=y\n> @@ -34,7 +34,6 @@ CONFIG_MTD=y\n> CONFIG_MTD_BLOCK=y\n> CONFIG_MTD_JEDECPROBE=y\n> CONFIG_MTD_CFI_AMDSTD=y\n> -CONFIG_MTD_PHYSMAP_OF=y\n> CONFIG_BLK_DEV_RAM=y\n> CONFIG_BLK_DEV_RAM_SIZE=35000\n> # CONFIG_INPUT is not set\n> @@ -57,13 +56,13 @@ CONFIG_PROC_KCORE=y\n> CONFIG_TMPFS=y\n> CONFIG_CRAMFS=y\n> # CONFIG_NETWORK_FILESYSTEMS is not set\n> -CONFIG_DEBUG_INFO=y\n> -CONFIG_MAGIC_SYSRQ=y\n> -CONFIG_DETECT_HUNG_TASK=y\n> -CONFIG_PPC_EARLY_DEBUG=y\n> CONFIG_CRYPTO_CBC=y\n> CONFIG_CRYPTO_ECB=y\n> CONFIG_CRYPTO_PCBC=y\n> CONFIG_CRYPTO_MD5=y\n> CONFIG_CRYPTO_DES=y\n> # CONFIG_CRYPTO_HW is not set\n> +CONFIG_DEBUG_INFO=y\n> +CONFIG_MAGIC_SYSRQ=y\n> +CONFIG_DETECT_HUNG_TASK=y\n> +CONFIG_PPC_EARLY_DEBUG=y\n> diff --git a/arch/powerpc/configs/44x/warp_defconfig b/arch/powerpc/configs/44x/warp_defconfig\n> index 47252c2d7669..d2e4bbe1492c 100644\n> --- a/arch/powerpc/configs/44x/warp_defconfig\n> +++ b/arch/powerpc/configs/44x/warp_defconfig\n> @@ -1,4 +1,3 @@\n> -CONFIG_44x=y\n> CONFIG_LOCALVERSION=\"-pika\"\n> # CONFIG_LOCALVERSION_AUTO is not set\n> CONFIG_SYSVIPC=y\n> @@ -7,15 +6,16 @@ CONFIG_IKCONFIG_PROC=y\n> CONFIG_LOG_BUF_SHIFT=14\n> CONFIG_BLK_DEV_INITRD=y\n> CONFIG_EXPERT=y\n> -CONFIG_MODULES=y\n> -CONFIG_MODULE_UNLOAD=y\n> -# CONFIG_BLK_DEV_BSG is not set\n> +CONFIG_CMDLINE_BOOL=y\n> +CONFIG_CMDLINE_PREPEND=\"ip=on\"\n> +CONFIG_44x=y\n> # CONFIG_EBONY is not set\n> CONFIG_WARP=y\n> CONFIG_PPC4xx_GPIO=y\n> CONFIG_HZ_1000=y\n> -CONFIG_CMDLINE=\"ip=on\"\n> -# CONFIG_PCI is not set\n> +CONFIG_MODULES=y\n> +CONFIG_MODULE_UNLOAD=y\n> +# CONFIG_BLK_DEV_BSG is not set\n> CONFIG_NET=y\n> CONFIG_PACKET=y\n> CONFIG_UNIX=y\n> @@ -31,7 +31,6 @@ CONFIG_MTD_CMDLINE_PARTS=y\n> CONFIG_MTD_BLOCK=y\n> CONFIG_MTD_CFI=y\n> CONFIG_MTD_CFI_AMDSTD=y\n> -CONFIG_MTD_PHYSMAP_OF=y\n> CONFIG_MTD_RAW_NAND=y\n> CONFIG_MTD_NAND_NDFC=y\n> CONFIG_MTD_UBI=y\n> @@ -88,9 +87,9 @@ CONFIG_NLS_UTF8=y\n> CONFIG_CRC_CCITT=y\n> CONFIG_CRC_T10DIF=y\n> CONFIG_PRINTK_TIME=y\n> +# CONFIG_DEBUG_BUGVERBOSE is not set\n> CONFIG_DEBUG_INFO=y\n> -CONFIG_DEBUG_FS=y\n> CONFIG_MAGIC_SYSRQ=y\n> +CONFIG_DEBUG_FS=y\n> CONFIG_DETECT_HUNG_TASK=y\n> # CONFIG_SCHED_DEBUG is not set\n> -# CONFIG_DEBUG_BUGVERBOSE is not set\n> diff --git a/arch/powerpc/configs/holly_defconfig b/arch/powerpc/configs/holly_defconfig\n> index 271daff47d1d..98c0644e80b4 100644\n> --- a/arch/powerpc/configs/holly_defconfig\n> +++ b/arch/powerpc/configs/holly_defconfig\n> @@ -4,17 +4,18 @@ CONFIG_HIGH_RES_TIMERS=y\n> CONFIG_LOG_BUF_SHIFT=14\n> CONFIG_BLK_DEV_INITRD=y\n> CONFIG_EXPERT=y\n> -CONFIG_MODULES=y\n> -# CONFIG_BLK_DEV_BSG is not set\n> -CONFIG_PARTITION_ADVANCED=y\n> +CONFIG_CMDLINE_BOOL=y\n> +CONFIG_CMDLINE_PREPEND=\"console=ttyS0,115200\"\n> # CONFIG_PPC_CHRP is not set\n> # CONFIG_PPC_PMAC is not set\n> CONFIG_EMBEDDED6xx=y\n> CONFIG_PPC_HOLLY=y\n> CONFIG_GEN_RTC=y\n> -CONFIG_BINFMT_MISC=y\n> -CONFIG_CMDLINE=\"console=ttyS0,115200\"\n> # CONFIG_SECCOMP is not set\n> +CONFIG_MODULES=y\n> +# CONFIG_BLK_DEV_BSG is not set\n> +CONFIG_PARTITION_ADVANCED=y\n> +CONFIG_BINFMT_MISC=y\n> CONFIG_NET=y\n> CONFIG_PACKET=y\n> CONFIG_UNIX=y\n> @@ -53,8 +54,8 @@ CONFIG_PROC_KCORE=y\n> CONFIG_TMPFS=y\n> CONFIG_NFS_FS=y\n> CONFIG_ROOT_NFS=y\n> +# CONFIG_DEBUG_BUGVERBOSE is not set\n> CONFIG_MAGIC_SYSRQ=y\n> # CONFIG_SCHED_DEBUG is not set\n> -# CONFIG_DEBUG_BUGVERBOSE is not set\n> CONFIG_XMON=y\n> CONFIG_XMON_DEFAULT=y\n> diff --git a/arch/powerpc/configs/mvme5100_defconfig b/arch/powerpc/configs/mvme5100_defconfig\n> index 1fed6be95d53..884a3e0defde 100644\n> --- a/arch/powerpc/configs/mvme5100_defconfig\n> +++ b/arch/powerpc/configs/mvme5100_defconfig\n> @@ -11,16 +11,17 @@ CONFIG_LOG_BUF_SHIFT=14\n> # CONFIG_NET_NS is not set\n> CONFIG_CC_OPTIMIZE_FOR_SIZE=y\n> # CONFIG_COMPAT_BRK is not set\n> -CONFIG_MODULES=y\n> -CONFIG_MODULE_UNLOAD=y\n> -# CONFIG_BLK_DEV_BSG is not set\n> +CONFIG_CMDLINE_BOOL=y\n> +CONFIG_CMDLINE_PREPEND=\"console=ttyS0,9600 ip=dhcp root=/dev/nfs\"\n> # CONFIG_PPC_CHRP is not set\n> # CONFIG_PPC_PMAC is not set\n> CONFIG_EMBEDDED6xx=y\n> CONFIG_MVME5100=y\n> CONFIG_KVM_GUEST=y\n> CONFIG_HZ_100=y\n> -CONFIG_CMDLINE=\"console=ttyS0,9600 ip=dhcp root=/dev/nfs\"\n> +CONFIG_MODULES=y\n> +CONFIG_MODULE_UNLOAD=y\n> +# CONFIG_BLK_DEV_BSG is not set\n> # CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set\n> # CONFIG_COMPACTION is not set\n> CONFIG_NET=y\n> @@ -108,13 +109,6 @@ CONFIG_NLS_CODEPAGE_437=m\n> CONFIG_NLS_CODEPAGE_932=m\n> CONFIG_NLS_ISO8859_1=m\n> CONFIG_NLS_UTF8=m\n> -CONFIG_CRC_CCITT=m\n> -CONFIG_CRC_T10DIF=y\n> -CONFIG_XZ_DEC=y\n> -CONFIG_MAGIC_SYSRQ=y\n> -CONFIG_DEBUG_KERNEL=y\n> -CONFIG_DETECT_HUNG_TASK=y\n> -CONFIG_DEFAULT_HUNG_TASK_TIMEOUT=20\n> CONFIG_CRYPTO_CBC=y\n> CONFIG_CRYPTO_PCBC=m\n> CONFIG_CRYPTO_MD5=y\n> @@ -125,3 +119,10 @@ CONFIG_CRYPTO_DES=y\n> CONFIG_CRYPTO_SERPENT=m\n> CONFIG_CRYPTO_TWOFISH=m\n> CONFIG_CRYPTO_DEFLATE=m\n> +CONFIG_CRC_CCITT=m\n> +CONFIG_CRC_T10DIF=y\n> +CONFIG_XZ_DEC=y\n> +CONFIG_MAGIC_SYSRQ=y\n> +CONFIG_DEBUG_KERNEL=y\n> +CONFIG_DETECT_HUNG_TASK=y\n> +CONFIG_DEFAULT_HUNG_TASK_TIMEOUT=20\n> diff --git a/arch/powerpc/configs/skiroot_defconfig b/arch/powerpc/configs/skiroot_defconfig\n> index b806a5d3a695..5e11995508d7 100644\n> --- a/arch/powerpc/configs/skiroot_defconfig\n> +++ b/arch/powerpc/configs/skiroot_defconfig\n> @@ -26,6 +26,8 @@ CONFIG_PERF_EVENTS=y\n> # CONFIG_SLAB_MERGE_DEFAULT is not set\n> CONFIG_SLAB_FREELIST_RANDOM=y\n> CONFIG_SLAB_FREELIST_HARDENED=y\n> +CONFIG_CMDLINE_BOOL=y\n> +CONFIG_CMDLINE_PREPEND=\"console=tty0 console=hvc0 ipr.fast_reboot=1 quiet\"\n> CONFIG_PPC64=y\n> CONFIG_ALTIVEC=y\n> CONFIG_VSX=y\n> @@ -42,14 +44,11 @@ CONFIG_KEXEC=y\n> CONFIG_KEXEC_FILE=y\n> CONFIG_PRESERVE_FA_DUMP=y\n> CONFIG_IRQ_ALL_CPUS=y\n> -CONFIG_NUMA=y\n> CONFIG_PPC_64K_PAGES=y\n> CONFIG_SCHED_SMT=y\n> -CONFIG_CMDLINE=\"console=tty0 console=hvc0 ipr.fast_reboot=1 quiet\"\n> -# CONFIG_SECCOMP is not set\n> # CONFIG_PPC_MEM_KEYS is not set\n> CONFIG_JUMP_LABEL=y\n> -CONFIG_STRICT_KERNEL_RWX=y\n> +# CONFIG_SECCOMP is not set\n> CONFIG_MODULES=y\n> CONFIG_MODULE_UNLOAD=y\n> CONFIG_MODULE_SIG_FORCE=y\n> @@ -80,7 +79,6 @@ CONFIG_BLK_DEV_NVME=m\n> CONFIG_NVME_MULTIPATH=y\n> CONFIG_EEPROM_AT24=m\n> # CONFIG_CXL is not set\n> -# CONFIG_OCXL is not set\n> CONFIG_BLK_DEV_SD=m\n> CONFIG_BLK_DEV_SR=m\n> CONFIG_CHR_DEV_SG=m\n> @@ -199,7 +197,6 @@ CONFIG_PHYLIB=y\n> CONFIG_INPUT_EVDEV=y\n> CONFIG_INPUT_MISC=y\n> # CONFIG_SERIO_SERPORT is not set\n> -# CONFIG_DEVMEM is not set\n> CONFIG_SERIAL_8250=y\n> CONFIG_SERIAL_8250_CONSOLE=y\n> CONFIG_IPMI_HANDLER=y\n> @@ -207,9 +204,10 @@ CONFIG_IPMI_DEVICE_INTERFACE=y\n> CONFIG_IPMI_POWERNV=y\n> CONFIG_IPMI_WATCHDOG=y\n> CONFIG_HW_RANDOM=y\n> +# CONFIG_DEVMEM is not set\n> +# CONFIG_DEVPORT is not set\n> CONFIG_TCG_TPM=y\n> CONFIG_TCG_TIS_I2C_NUVOTON=y\n> -# CONFIG_DEVPORT is not set\n> CONFIG_I2C=y\n> # CONFIG_I2C_COMPAT is not set\n> CONFIG_I2C_CHARDEV=y\n> diff --git a/arch/powerpc/configs/storcenter_defconfig b/arch/powerpc/configs/storcenter_defconfig\n> index 47dcfaddc1ac..17a17b8ae160 100644\n> --- a/arch/powerpc/configs/storcenter_defconfig\n> +++ b/arch/powerpc/configs/storcenter_defconfig\n> @@ -2,18 +2,19 @@ CONFIG_SYSVIPC=y\n> CONFIG_LOG_BUF_SHIFT=14\n> CONFIG_EXPERT=y\n> # CONFIG_KALLSYMS is not set\n> -CONFIG_MODULES=y\n> -CONFIG_MODULE_UNLOAD=y\n> -# CONFIG_BLK_DEV_BSG is not set\n> -CONFIG_PARTITION_ADVANCED=y\n> +CONFIG_CMDLINE_BOOL=y\n> +CONFIG_CMDLINE_PREPEND=\"console=ttyS0,115200\"\n> # CONFIG_PPC_CHRP is not set\n> # CONFIG_PPC_PMAC is not set\n> CONFIG_EMBEDDED6xx=y\n> CONFIG_STORCENTER=y\n> CONFIG_HZ_100=y\n> -CONFIG_BINFMT_MISC=y\n> -CONFIG_CMDLINE=\"console=ttyS0,115200\"\n> # CONFIG_SECCOMP is not set\n> +CONFIG_MODULES=y\n> +CONFIG_MODULE_UNLOAD=y\n> +# CONFIG_BLK_DEV_BSG is not set\n> +CONFIG_PARTITION_ADVANCED=y\n> +CONFIG_BINFMT_MISC=y\n> CONFIG_NET=y\n> CONFIG_PACKET=m\n> CONFIG_UNIX=y\n> @@ -35,7 +36,6 @@ CONFIG_BLK_DEV_SD=y\n> CONFIG_BLK_DEV_SR=y\n> CONFIG_SCSI_SPI_ATTRS=y\n> CONFIG_ATA=y\n> -CONFIG_PATA_VIA=y\n> CONFIG_MD=y\n> CONFIG_BLK_DEV_MD=y\n> CONFIG_MD_LINEAR=y\n> @@ -44,16 +44,13 @@ CONFIG_MD_RAID1=y\n> CONFIG_MD_RAID456=y\n> CONFIG_NETDEVICES=y\n> CONFIG_DUMMY=m\n> -CONFIG_R8169=y\n> # CONFIG_INPUT is not set\n> # CONFIG_SERIO is not set\n> # CONFIG_VT is not set\n> CONFIG_SERIAL_8250=y\n> CONFIG_SERIAL_8250_CONSOLE=y\n> -# CONFIG_SERIAL_8250_PCI is not set\n> CONFIG_SERIAL_8250_NR_UARTS=2\n> CONFIG_SERIAL_8250_RUNTIME_UARTS=2\n> -CONFIG_NVRAM=y\n> CONFIG_I2C=y\n> CONFIG_I2C_CHARDEV=y\n> CONFIG_I2C_MPC=y\n> @@ -76,4 +73,3 @@ CONFIG_NLS_CODEPAGE_437=y\n> CONFIG_NLS_ISO8859_1=y\n> CONFIG_NLS_UTF8=y\n> CONFIG_CRC_T10DIF=y\n> -# CONFIG_ENABLE_MUST_CHECK is not set\n>","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=csgroup.eu (client-ip=93.17.236.30; helo=pegase1.c-s.fr;\n envelope-from=christophe.leroy@csgroup.eu; receiver=)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4DvnP249XTz9sW1\n\tfor ; Tue, 9 Mar 2021 18:47:34 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4DvnP23BSgz3cMW\n\tfor ; Tue, 9 Mar 2021 18:47:34 +1100 (AEDT)","from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4DvnNj3dqKz30JZ\n for ; Tue, 9 Mar 2021 18:47:14 +1100 (AEDT)","from localhost (mailhub1-int [192.168.12.234])\n by localhost (Postfix) with ESMTP id 4DvnNZ0vXgz9txlJ;\n Tue, 9 Mar 2021 08:47:10 +0100 (CET)","from pegase1.c-s.fr ([192.168.12.234])\n by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024)\n with ESMTP id 5l0ah_5c435U; Tue, 9 Mar 2021 08:47:10 +0100 (CET)","from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192])\n by pegase1.c-s.fr (Postfix) with ESMTP id 4DvnNY6kQjz9txlH;\n Tue, 9 Mar 2021 08:47:09 +0100 (CET)","from localhost (localhost [127.0.0.1])\n by messagerie.si.c-s.fr (Postfix) with ESMTP id 01CBC8B7CE;\n Tue, 9 Mar 2021 08:47:11 +0100 (CET)","from messagerie.si.c-s.fr ([127.0.0.1])\n by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023)\n with ESMTP id 8toqZCyn8RX2; Tue, 9 Mar 2021 08:47:10 +0100 (CET)","from [192.168.4.90] (unknown [192.168.4.90])\n by messagerie.si.c-s.fr (Postfix) with ESMTP id 13B6C8B773;\n Tue, 9 Mar 2021 08:47:10 +0100 (CET)"],"X-Virus-Scanned":["Debian amavisd-new at c-s.fr","amavisd-new at c-s.fr"],"Subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","To":"Daniel Walker , Will Deacon ,\n Rob Herring ,\n Daniel Gimpelevich ,\n Andrew Morton , x86@kernel.org,\n linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n xe-linux-external@cisco.com","References":"<20210309000247.2989531-4-danielwa@cisco.com>","From":"Christophe Leroy ","Message-ID":"<5f865584-09c9-d21f-ffb7-23cf07cf058e@csgroup.eu>","Date":"Tue, 9 Mar 2021 08:47:09 +0100","User-Agent":"Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101\n Thunderbird/78.8.0","MIME-Version":"1.0","In-Reply-To":"<20210309000247.2989531-4-danielwa@cisco.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"fr","Content-Transfer-Encoding":"8bit","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Paul Mackerras , linux-kernel@vger.kernel.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2644901,"web_url":"http://patchwork.ozlabs.org/comment/2644901/","msgid":"<20210309212944.GR109100@zorba>","date":"2021-03-09T21:29:44","subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","submitter":{"id":67374,"url":"http://patchwork.ozlabs.org/api/people/67374/","name":"Daniel Walker (danielwa)","email":"danielwa@cisco.com"},"content":"On Tue, Mar 09, 2021 at 08:47:09AM +0100, Christophe Leroy wrote:\n> \n> \n> Le 09/03/2021 à 01:02, Daniel Walker a écrit :\n> > This is a scripted mass convert of the config files to use\n> > the new generic cmdline. There is a bit of a trim effect here.\n> > It would seems that some of the config haven't been trimmed in\n> > a while.\n> \n> If you do that in a separate patch, you loose bisectability.\n> \n> I think it would have been better to do things in a different way, more or less like I did in my series:\n> 1/ Provide GENERIC cmdline at the same functionnality level as what is\n> spread in the different architectures\n> 2/ Convert architectures to the generic with least churn.\n> 3/ Add new features to the generic\n\nYou have to have the churn eventually, no matter how you do it. The only way you\ndon't have churn is if you never upgrade the feature set.\n\n\n> > \n> > The bash script used to convert is as follows,\n> > \n> > if [[ -z \"$1\" || -z \"$2\" ]]; then\n> > echo \"Two arguments are needed.\"\n> > exit 1\n> > fi\n> > mkdir $1\n> > cp $2 $1/.config\n> > sed -i 's/CONFIG_CMDLINE=/CONFIG_CMDLINE_BOOL=y\\nCONFIG_CMDLINE_PREPEND=/g' $1/.config\n> \n> This is not correct.\n> \n> By default, on powerpc the provided command line is used only if the bootloader doesn't provide one.\n> \n> Otherwise:\n> - the builtin command line is appended to the one provided by the bootloader\n> if CONFIG_CMDLINE_EXTEND is selected\n> - the builtin command line replaces to the one provided by the bootloader if\n> CONFIG_CMDLINE_FORCE is selected\n\nI think my changes maintain most of this due to the override of\nCONFIG_CMDLINE_PREPEND. This is an upgrade and the inflexibility in powerpc is\nan example of why these changes were created in the first place.\n\nFor example , say the default command line is \"root=/dev/issblk0\" from iss476\nplatform. And the bootloader adds \"root=/dev/sda1\"\n\nThe result is .\n\nThen you have,\n\nroot=/dev/issblk0 root=/dev/sda1\n\nand the bootloader has precedent over the default command line. So root= in the\nabove cases is defined by the bootloader.\n\nThe only issue would be if a person wants to override the default command line\nwith an unrelated bootloader command line. I don't know how many people do this,\nbut I doubt it's many. Can you think of any use cases like this?\n\nI would imagine there are many more people who have to entirely duplicate the\ndefault command line in the boot loader when they really just want to change a\nsingle part of it like the root= device or console device or speed.\n\nDaniel","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=l6Pe5NJC;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=l6Pe5NJC;\n\tdkim-atps=neutral","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=cisco.com (client-ip=173.37.86.73; helo=rcdn-iport-2.cisco.com;\n envelope-from=danielwa@cisco.com; receiver=)","lists.ozlabs.org; dkim=pass (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=l6Pe5NJC; dkim-atps=neutral"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4Dw7fL2Pyhz9sWL\n\tfor ; Wed, 10 Mar 2021 08:30:18 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4Dw7fL1F8vz3cQc\n\tfor ; Wed, 10 Mar 2021 08:30:18 +1100 (AEDT)","from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4Dw7dr6Yl1z30HT\n for ; Wed, 10 Mar 2021 08:29:51 +1100 (AEDT)","from alln-core-8.cisco.com ([173.36.13.141])\n by rcdn-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA;\n 09 Mar 2021 21:29:47 +0000","from zorba ([10.24.4.5])\n by alln-core-8.cisco.com (8.15.2/8.15.2) with ESMTPS id 129LTj55006364\n (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);\n Tue, 9 Mar 2021 21:29:46 GMT"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=cisco.com; i=@cisco.com; l=2621; q=dns/txt; s=iport;\n t=1615325393; x=1616534993;\n h=date:from:to:cc:subject:message-id:references:\n mime-version:content-transfer-encoding:in-reply-to;\n bh=P29McQ6d/QFxrQq1EYKN884pwFzgqSORJbOcG1OnGCA=;\n b=l6Pe5NJC0EM+wArX2XuF3SCAWSS1pvYGiO+o6/EwFlQ+NkBd8NrQdmfv\n 1Mx6J3gki7mHBW2rHjzR3hnpIVi1kq3cc3lmYWds10UDPUov4QPu4YlZ9\n JFoQ3DxBUvQNJYeAHItVw3Z66owqmOQw4qN0hXQy2ksZvR2PG0vEC3XkO w=;","X-IronPort-Anti-Spam-Filtered":"true","X-IronPort-Anti-Spam-Result":"\n A0BqAAC/50dg/40NJK1aHAEBAQEBAQcBARIBAQQEAQFAgTsHAQELAQGBdDWBTAE5jRaJPI9zilaBfAsBAQENAQE0BAEBgRSDNAMCAoF+AiU0CQ4CAwEBCwEBBQEBAQIBBgRxhW5DAQwBCAGFawEFMgFGEAsYLjwbBoYLrGd0gTSJEYFFFA6BFwGNQiYcgUlChCw+ihAiBIJGgRBLPXxXkSqMcJpwgRSDCYEfmnsxEKNitx8CBAYFAhaBVDqBVzMaCBsVgyVPGQ2OKxaORyADZwIGAQkBAQMJhiCEEIM4AQE","X-IronPort-AV":"E=Sophos;i=\"5.81,236,1610409600\"; d=\"scan'208\";a=\"874107942\"","Date":"Tue, 9 Mar 2021 13:29:44 -0800","From":"Daniel Walker ","To":"Christophe Leroy ","Subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","Message-ID":"<20210309212944.GR109100@zorba>","References":"<20210309000247.2989531-4-danielwa@cisco.com>\n <5f865584-09c9-d21f-ffb7-23cf07cf058e@csgroup.eu>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<5f865584-09c9-d21f-ffb7-23cf07cf058e@csgroup.eu>","X-Auto-Response-Suppress":"DR, OOF, AutoReply","X-Outbound-SMTP-Client":"10.24.4.5, [10.24.4.5]","X-Outbound-Node":"alln-core-8.cisco.com","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Rob Herring ,\n Daniel Gimpelevich ,\n linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-mips@vger.kernel.org,\n linux-kernel@vger.kernel.org, Paul Mackerras ,\n xe-linux-external@cisco.com, Andrew Morton ,\n Will Deacon ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2654787,"web_url":"http://patchwork.ozlabs.org/comment/2654787/","msgid":"","date":"2021-03-24T16:59:59","subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","submitter":{"id":79086,"url":"http://patchwork.ozlabs.org/api/people/79086/","name":"Christophe Leroy","email":"christophe.leroy@csgroup.eu"},"content":"Le 09/03/2021 à 22:29, Daniel Walker a écrit :\n> On Tue, Mar 09, 2021 at 08:47:09AM +0100, Christophe Leroy wrote:\n>>\n>>\n>> Le 09/03/2021 à 01:02, Daniel Walker a écrit :\n>>> This is a scripted mass convert of the config files to use\n>>> the new generic cmdline. There is a bit of a trim effect here.\n>>> It would seems that some of the config haven't been trimmed in\n>>> a while.\n>>\n>> If you do that in a separate patch, you loose bisectability.\n>>\n>> I think it would have been better to do things in a different way, more or less like I did in my series:\n>> 1/ Provide GENERIC cmdline at the same functionnality level as what is\n>> spread in the different architectures\n>> 2/ Convert architectures to the generic with least churn.\n>> 3/ Add new features to the generic\n> \n> You have to have the churn eventually, no matter how you do it. The only way you\n> don't have churn is if you never upgrade the feature set.\n> \n> \n>>>\n>>> The bash script used to convert is as follows,\n>>>\n>>> if [[ -z \"$1\" || -z \"$2\" ]]; then\n>>> echo \"Two arguments are needed.\"\n>>> exit 1\n>>> fi\n>>> mkdir $1\n>>> cp $2 $1/.config\n>>> sed -i 's/CONFIG_CMDLINE=/CONFIG_CMDLINE_BOOL=y\\nCONFIG_CMDLINE_PREPEND=/g' $1/.config\n>>\n>> This is not correct.\n>>\n>> By default, on powerpc the provided command line is used only if the bootloader doesn't provide one.\n>>\n>> Otherwise:\n>> - the builtin command line is appended to the one provided by the bootloader\n>> if CONFIG_CMDLINE_EXTEND is selected\n>> - the builtin command line replaces to the one provided by the bootloader if\n>> CONFIG_CMDLINE_FORCE is selected\n> \n> I think my changes maintain most of this due to the override of\n> CONFIG_CMDLINE_PREPEND. This is an upgrade and the inflexibility in powerpc is\n> an example of why these changes were created in the first place.\n\n\"inflexibility in powerpc\" : Can you elaborate ?\n\n> \n> For example , say the default command line is \"root=/dev/issblk0\" from iss476\n> platform. And the bootloader adds \"root=/dev/sda1\"\n> \n> The result is .\n\n\nI'm still having hard time understanding the benefit of having both and .\nCould you please provide a complete exemple from real life, ie what exactly the problem is and what \nit solves ?\n\n> \n> Then you have,\n> \n> root=/dev/issblk0 root=/dev/sda1\n> \n> and the bootloader has precedent over the default command line. So root= in the\n> above cases is defined by the bootloader.\n> \n> The only issue would be if a person wants to override the default command line\n> with an unrelated bootloader command line. I don't know how many people do this,\n> but I doubt it's many. Can you think of any use cases like this?\n> \n> I would imagine there are many more people who have to entirely duplicate the\n> default command line in the boot loader when they really just want to change a\n> single part of it like the root= device or console device or speed.\n> \n> Daniel\n> \n\nChristophe","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=csgroup.eu (client-ip=93.17.236.30; helo=pegase1.c-s.fr;\n envelope-from=christophe.leroy@csgroup.eu; receiver=)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4F5Dz92fwBz9sWj\n\tfor ; Thu, 25 Mar 2021 04:01:25 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4F5Dz91LQ7z3bs3\n\tfor ; Thu, 25 Mar 2021 04:01:25 +1100 (AEDT)","from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4F5Dyt0gmzz2yxP\n for ; Thu, 25 Mar 2021 04:01:05 +1100 (AEDT)","from localhost (mailhub1-int [192.168.12.234])\n by localhost (Postfix) with ESMTP id 4F5Dyg2yVdz9tyfd;\n Wed, 24 Mar 2021 18:00:59 +0100 (CET)","from pegase1.c-s.fr ([192.168.12.234])\n by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024)\n with ESMTP id hMuZCLVXRcCR; Wed, 24 Mar 2021 18:00:59 +0100 (CET)","from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192])\n by pegase1.c-s.fr (Postfix) with ESMTP id 4F5Dyg1vd9z9tyfc;\n Wed, 24 Mar 2021 18:00:59 +0100 (CET)","from localhost (localhost [127.0.0.1])\n by messagerie.si.c-s.fr (Postfix) with ESMTP id 765D78B82C;\n Wed, 24 Mar 2021 18:01:00 +0100 (CET)","from messagerie.si.c-s.fr ([127.0.0.1])\n by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023)\n with ESMTP id uqfRv-8BUINu; Wed, 24 Mar 2021 18:01:00 +0100 (CET)","from [192.168.4.90] (unknown [192.168.4.90])\n by messagerie.si.c-s.fr (Postfix) with ESMTP id 997938B82B;\n Wed, 24 Mar 2021 18:00:59 +0100 (CET)"],"X-Virus-Scanned":["Debian amavisd-new at c-s.fr","amavisd-new at c-s.fr"],"Subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","To":"Daniel Walker ","References":"<20210309000247.2989531-4-danielwa@cisco.com>\n <5f865584-09c9-d21f-ffb7-23cf07cf058e@csgroup.eu>\n <20210309212944.GR109100@zorba>","From":"Christophe Leroy ","Message-ID":"","Date":"Wed, 24 Mar 2021 17:59:59 +0100","User-Agent":"Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101\n Thunderbird/78.8.1","MIME-Version":"1.0","In-Reply-To":"<20210309212944.GR109100@zorba>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"fr","Content-Transfer-Encoding":"8bit","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Rob Herring ,\n Daniel Gimpelevich ,\n linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-mips@vger.kernel.org,\n linux-kernel@vger.kernel.org, Paul Mackerras ,\n xe-linux-external@cisco.com, Andrew Morton ,\n Will Deacon ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2654822,"web_url":"http://patchwork.ozlabs.org/comment/2654822/","msgid":"","date":"2021-03-24T17:32:30","subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Wed, Mar 24, 2021 at 11:01 AM Christophe Leroy\n wrote:\n>\n>\n>\n> Le 09/03/2021 à 22:29, Daniel Walker a écrit :\n> > On Tue, Mar 09, 2021 at 08:47:09AM +0100, Christophe Leroy wrote:\n> >>\n> >>\n> >> Le 09/03/2021 à 01:02, Daniel Walker a écrit :\n> >>> This is a scripted mass convert of the config files to use\n> >>> the new generic cmdline. There is a bit of a trim effect here.\n> >>> It would seems that some of the config haven't been trimmed in\n> >>> a while.\n> >>\n> >> If you do that in a separate patch, you loose bisectability.\n> >>\n> >> I think it would have been better to do things in a different way, more or less like I did in my series:\n> >> 1/ Provide GENERIC cmdline at the same functionnality level as what is\n> >> spread in the different architectures\n> >> 2/ Convert architectures to the generic with least churn.\n> >> 3/ Add new features to the generic\n> >\n> > You have to have the churn eventually, no matter how you do it. The only way you\n> > don't have churn is if you never upgrade the feature set.\n> >\n> >\n> >>>\n> >>> The bash script used to convert is as follows,\n> >>>\n> >>> if [[ -z \"$1\" || -z \"$2\" ]]; then\n> >>> echo \"Two arguments are needed.\"\n> >>> exit 1\n> >>> fi\n> >>> mkdir $1\n> >>> cp $2 $1/.config\n> >>> sed -i 's/CONFIG_CMDLINE=/CONFIG_CMDLINE_BOOL=y\\nCONFIG_CMDLINE_PREPEND=/g' $1/.config\n> >>\n> >> This is not correct.\n> >>\n> >> By default, on powerpc the provided command line is used only if the bootloader doesn't provide one.\n> >>\n> >> Otherwise:\n> >> - the builtin command line is appended to the one provided by the bootloader\n> >> if CONFIG_CMDLINE_EXTEND is selected\n> >> - the builtin command line replaces to the one provided by the bootloader if\n> >> CONFIG_CMDLINE_FORCE is selected\n> >\n> > I think my changes maintain most of this due to the override of\n> > CONFIG_CMDLINE_PREPEND. This is an upgrade and the inflexibility in powerpc is\n> > an example of why these changes were created in the first place.\n>\n> \"inflexibility in powerpc\" : Can you elaborate ?\n>\n> >\n> > For example , say the default command line is \"root=/dev/issblk0\" from iss476\n> > platform. And the bootloader adds \"root=/dev/sda1\"\n> >\n> > The result is .\n>\n>\n> I'm still having hard time understanding the benefit of having both and .\n> Could you please provide a complete exemple from real life, ie what exactly the problem is and what\n> it solves ?\n\nIt doesn't matter. We already have both cases and 'extend' has meant either one.\n\nWhat someone wants is policy and the kernel shouldn't be defining the policy.\n\nRob","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=T66PHbzA;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=T66PHbzA;\n\tdkim-atps=neutral","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org;\n envelope-from=robh@kernel.org; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=T66PHbzA;\n dkim-atps=neutral"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4F5Fgk5LqKz9sVb\n\tfor ; Thu, 25 Mar 2021 04:33:06 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4F5Fgk4RyZz3btK\n\tfor ; Thu, 25 Mar 2021 04:33:06 +1100 (AEDT)","from mail.kernel.org (mail.kernel.org [198.145.29.99])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4F5FgL1Slcz301y\n for ; Thu, 25 Mar 2021 04:32:46 +1100 (AEDT)","by mail.kernel.org (Postfix) with ESMTPSA id 3B08761A19\n for ; Wed, 24 Mar 2021 17:32:43 +0000 (UTC)","by mail-ed1-f43.google.com with SMTP id bx7so28559363edb.12\n for ; Wed, 24 Mar 2021 10:32:43 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1616607163;\n bh=vwFmLhIbpBit7slP5Tgq8iugG6lF7uxqcxCcj5anb1s=;\n h=References:In-Reply-To:From:Date:Subject:To:Cc:From;\n b=T66PHbzA4HZLyDpwGOkX+dflulPJCr9OD+q4niugzUsfMiI9RRAGz5n7CWXc2WtXR\n XbuhrFmqKLpIwxKmUJDvEVxs0mhwEIxcXsqNURnI1d7/3eFvgOm8abHDCM49/H3Bcf\n qvL2xptThHPDmYcaGptEqEHOkGjiA6p0x7zd8Yv9Vcd68HCUOSUZFJDQAGNgtHdf8Q\n rRu34o4uRbPglSg1LqlwqUB3wXov+O83CJ50wVik8yYYAo0m4PxVbBJR5qtZ7tTQ46\n E7J01J6cM1sxGhyKXm6t2MC4vKiuIMFxUa4kcLH4QmvCSF/wB32I2fLk7RvUSZZCGe\n Poh8Mv+K1J1hw==","X-Gm-Message-State":"AOAM532mQoR8aIhbjfI8Edk1PFJiDhrD3RENC1hVxSzklBFwyRr4PLmG\n JrzRwwNyo0lXOQjs3ncpfYPzxtX9lR/0+3ORKA==","X-Google-Smtp-Source":"\n ABdhPJy7YCVuRWwXQo13DaEdS0eUAv22DscISVepsqz2isMzM1EIDsAzWe5iU1QCiAYfFd5rzpKJR8h0mAzTPfMAUrg=","X-Received":"by 2002:aa7:d3d8:: with SMTP id o24mr4667708edr.165.1616607161795;\n Wed, 24 Mar 2021 10:32:41 -0700 (PDT)","MIME-Version":"1.0","References":"<20210309000247.2989531-4-danielwa@cisco.com>\n <5f865584-09c9-d21f-ffb7-23cf07cf058e@csgroup.eu>\n <20210309212944.GR109100@zorba>\n ","In-Reply-To":"","From":"Rob Herring ","Date":"Wed, 24 Mar 2021 11:32:30 -0600","X-Gmail-Original-Message-ID":"\n ","Message-ID":"\n ","Subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","To":"Christophe Leroy ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Daniel Gimpelevich ,\n linuxppc-dev , X86 ML ,\n \"open list:MIPS\" ,\n \"linux-kernel@vger.kernel.org\" ,\n Paul Mackerras , xe-linux-external@cisco.com,\n Andrew Morton , Will Deacon ,\n Daniel Walker ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2655293,"web_url":"http://patchwork.ozlabs.org/comment/2655293/","msgid":"<20fd7d44-8c39-48bc-25c3-990be9d9d911@csgroup.eu>","date":"2021-03-25T12:03:55","subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","submitter":{"id":79086,"url":"http://patchwork.ozlabs.org/api/people/79086/","name":"Christophe Leroy","email":"christophe.leroy@csgroup.eu"},"content":"Le 24/03/2021 à 18:32, Rob Herring a écrit :\n> On Wed, Mar 24, 2021 at 11:01 AM Christophe Leroy\n> wrote:\n>>\n>>\n>>\n>> Le 09/03/2021 à 22:29, Daniel Walker a écrit :\n>>> On Tue, Mar 09, 2021 at 08:47:09AM +0100, Christophe Leroy wrote:\n>>>>\n>>>>\n>>>> Le 09/03/2021 à 01:02, Daniel Walker a écrit :\n>>>>> This is a scripted mass convert of the config files to use\n>>>>> the new generic cmdline. There is a bit of a trim effect here.\n>>>>> It would seems that some of the config haven't been trimmed in\n>>>>> a while.\n>>>>\n>>>> If you do that in a separate patch, you loose bisectability.\n>>>>\n>>>> I think it would have been better to do things in a different way, more or less like I did in my series:\n>>>> 1/ Provide GENERIC cmdline at the same functionnality level as what is\n>>>> spread in the different architectures\n>>>> 2/ Convert architectures to the generic with least churn.\n>>>> 3/ Add new features to the generic\n>>>\n>>> You have to have the churn eventually, no matter how you do it. The only way you\n>>> don't have churn is if you never upgrade the feature set.\n>>>\n>>>\n>>>>>\n>>>>> The bash script used to convert is as follows,\n>>>>>\n>>>>> if [[ -z \"$1\" || -z \"$2\" ]]; then\n>>>>> echo \"Two arguments are needed.\"\n>>>>> exit 1\n>>>>> fi\n>>>>> mkdir $1\n>>>>> cp $2 $1/.config\n>>>>> sed -i 's/CONFIG_CMDLINE=/CONFIG_CMDLINE_BOOL=y\\nCONFIG_CMDLINE_PREPEND=/g' $1/.config\n>>>>\n>>>> This is not correct.\n>>>>\n>>>> By default, on powerpc the provided command line is used only if the bootloader doesn't provide one.\n>>>>\n>>>> Otherwise:\n>>>> - the builtin command line is appended to the one provided by the bootloader\n>>>> if CONFIG_CMDLINE_EXTEND is selected\n>>>> - the builtin command line replaces to the one provided by the bootloader if\n>>>> CONFIG_CMDLINE_FORCE is selected\n>>>\n>>> I think my changes maintain most of this due to the override of\n>>> CONFIG_CMDLINE_PREPEND. This is an upgrade and the inflexibility in powerpc is\n>>> an example of why these changes were created in the first place.\n>>\n>> \"inflexibility in powerpc\" : Can you elaborate ?\n>>\n>>>\n>>> For example , say the default command line is \"root=/dev/issblk0\" from iss476\n>>> platform. And the bootloader adds \"root=/dev/sda1\"\n>>>\n>>> The result is .\n>>\n>>\n>> I'm still having hard time understanding the benefit of having both and .\n>> Could you please provide a complete exemple from real life, ie what exactly the problem is and what\n>> it solves ?\n> \n> It doesn't matter. We already have both cases and 'extend' has meant either one.\n> \n> What someone wants is policy and the kernel shouldn't be defining the policy.\n> \n\nOk, so you agree we don't need to provide two CMDLINE, one to be appended and one to be prepended.\n\nLet's only provide once CMDLINE as of today, and ask the user to select whether he wants it appended \nor prepended or replacee. Then no need to change all existing config to rename CONFIG_CMDLINE into \neither of the new ones.\n\nThat's the main difference between my series and Daniel's series. So I'll finish taking Will's \ncomment into account and we'll send out a v3 soon.\n\nThanks\nChristophe","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=csgroup.eu (client-ip=93.17.236.30; helo=pegase1.c-s.fr;\n envelope-from=christophe.leroy@csgroup.eu; receiver=)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4F5kNc5vWbz9sX2\n\tfor ; Thu, 25 Mar 2021 23:06:40 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4F5kNc4pRzz301k\n\tfor ; Thu, 25 Mar 2021 23:06:40 +1100 (AEDT)","from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4F5kNK5sZ9z2yxd\n for ; Thu, 25 Mar 2021 23:06:22 +1100 (AEDT)","from localhost (mailhub1-int [192.168.12.234])\n by localhost (Postfix) with ESMTP id 4F5kNB1nf0z9v0GZ;\n Thu, 25 Mar 2021 13:06:18 +0100 (CET)","from pegase1.c-s.fr ([192.168.12.234])\n by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024)\n with ESMTP id JkNGHrWfVGIB; Thu, 25 Mar 2021 13:06:18 +0100 (CET)","from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192])\n by pegase1.c-s.fr (Postfix) with ESMTP id 4F5kNB0wKHz9v07g;\n Thu, 25 Mar 2021 13:06:18 +0100 (CET)","from localhost (localhost [127.0.0.1])\n by messagerie.si.c-s.fr (Postfix) with ESMTP id 7B0988B853;\n Thu, 25 Mar 2021 13:06:19 +0100 (CET)","from messagerie.si.c-s.fr ([127.0.0.1])\n by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023)\n with ESMTP id bAlm_IeUvyN3; Thu, 25 Mar 2021 13:06:19 +0100 (CET)","from [192.168.4.90] (unknown [192.168.4.90])\n by messagerie.si.c-s.fr (Postfix) with ESMTP id 9491B8B849;\n Thu, 25 Mar 2021 13:06:18 +0100 (CET)"],"X-Virus-Scanned":["Debian amavisd-new at c-s.fr","amavisd-new at c-s.fr"],"Subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","To":"Rob Herring ","References":"<20210309000247.2989531-4-danielwa@cisco.com>\n <5f865584-09c9-d21f-ffb7-23cf07cf058e@csgroup.eu>\n <20210309212944.GR109100@zorba>\n \n ","From":"Christophe Leroy ","Message-ID":"<20fd7d44-8c39-48bc-25c3-990be9d9d911@csgroup.eu>","Date":"Thu, 25 Mar 2021 13:03:55 +0100","User-Agent":"Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101\n Thunderbird/78.9.0","MIME-Version":"1.0","In-Reply-To":"\n ","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"fr","Content-Transfer-Encoding":"8bit","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Daniel Gimpelevich ,\n linuxppc-dev , X86 ML ,\n \"open list:MIPS\" ,\n \"linux-kernel@vger.kernel.org\" ,\n Paul Mackerras , xe-linux-external@cisco.com,\n Andrew Morton , Will Deacon ,\n Daniel Walker ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2655365,"web_url":"http://patchwork.ozlabs.org/comment/2655365/","msgid":"","date":"2021-03-25T13:45:41","subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Thu, Mar 25, 2021 at 6:06 AM Christophe Leroy\n wrote:\n>\n>\n>\n> Le 24/03/2021 à 18:32, Rob Herring a écrit :\n> > On Wed, Mar 24, 2021 at 11:01 AM Christophe Leroy\n> > wrote:\n> >>\n> >>\n> >>\n> >> Le 09/03/2021 à 22:29, Daniel Walker a écrit :\n> >>> On Tue, Mar 09, 2021 at 08:47:09AM +0100, Christophe Leroy wrote:\n> >>>>\n> >>>>\n> >>>> Le 09/03/2021 à 01:02, Daniel Walker a écrit :\n> >>>>> This is a scripted mass convert of the config files to use\n> >>>>> the new generic cmdline. There is a bit of a trim effect here.\n> >>>>> It would seems that some of the config haven't been trimmed in\n> >>>>> a while.\n> >>>>\n> >>>> If you do that in a separate patch, you loose bisectability.\n> >>>>\n> >>>> I think it would have been better to do things in a different way, more or less like I did in my series:\n> >>>> 1/ Provide GENERIC cmdline at the same functionnality level as what is\n> >>>> spread in the different architectures\n> >>>> 2/ Convert architectures to the generic with least churn.\n> >>>> 3/ Add new features to the generic\n> >>>\n> >>> You have to have the churn eventually, no matter how you do it. The only way you\n> >>> don't have churn is if you never upgrade the feature set.\n> >>>\n> >>>\n> >>>>>\n> >>>>> The bash script used to convert is as follows,\n> >>>>>\n> >>>>> if [[ -z \"$1\" || -z \"$2\" ]]; then\n> >>>>> echo \"Two arguments are needed.\"\n> >>>>> exit 1\n> >>>>> fi\n> >>>>> mkdir $1\n> >>>>> cp $2 $1/.config\n> >>>>> sed -i 's/CONFIG_CMDLINE=/CONFIG_CMDLINE_BOOL=y\\nCONFIG_CMDLINE_PREPEND=/g' $1/.config\n> >>>>\n> >>>> This is not correct.\n> >>>>\n> >>>> By default, on powerpc the provided command line is used only if the bootloader doesn't provide one.\n> >>>>\n> >>>> Otherwise:\n> >>>> - the builtin command line is appended to the one provided by the bootloader\n> >>>> if CONFIG_CMDLINE_EXTEND is selected\n> >>>> - the builtin command line replaces to the one provided by the bootloader if\n> >>>> CONFIG_CMDLINE_FORCE is selected\n> >>>\n> >>> I think my changes maintain most of this due to the override of\n> >>> CONFIG_CMDLINE_PREPEND. This is an upgrade and the inflexibility in powerpc is\n> >>> an example of why these changes were created in the first place.\n> >>\n> >> \"inflexibility in powerpc\" : Can you elaborate ?\n> >>\n> >>>\n> >>> For example , say the default command line is \"root=/dev/issblk0\" from iss476\n> >>> platform. And the bootloader adds \"root=/dev/sda1\"\n> >>>\n> >>> The result is .\n> >>\n> >>\n> >> I'm still having hard time understanding the benefit of having both and .\n> >> Could you please provide a complete exemple from real life, ie what exactly the problem is and what\n> >> it solves ?\n> >\n> > It doesn't matter. We already have both cases and 'extend' has meant either one.\n> >\n> > What someone wants is policy and the kernel shouldn't be defining the policy.\n> >\n>\n> Ok, so you agree we don't need to provide two CMDLINE, one to be appended and one to be prepended.\n\nWell, I wasn't thinking about that part of it, but yes as long as no\narch currently needs that.\n\n> Let's only provide once CMDLINE as of today, and ask the user to select whether he wants it appended\n> or prepended or replacee. Then no need to change all existing config to rename CONFIG_CMDLINE into\n> either of the new ones.\n>\n> That's the main difference between my series and Daniel's series. So I'll finish taking Will's\n> comment into account and we'll send out a v3 soon.\n\nGreat.\n\nRob","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=R92Bx0fq;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=R92Bx0fq;\n\tdkim-atps=neutral","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org;\n envelope-from=robh@kernel.org; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=R92Bx0fq;\n dkim-atps=neutral"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4F5mbb4XSgz9sVb\n\tfor ; Fri, 26 Mar 2021 00:46:19 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4F5mbb3VLfz3btr\n\tfor ; Fri, 26 Mar 2021 00:46:19 +1100 (AEDT)","from mail.kernel.org (mail.kernel.org [198.145.29.99])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4F5mbC1WsWz301Y\n for ; Fri, 26 Mar 2021 00:45:59 +1100 (AEDT)","by mail.kernel.org (Postfix) with ESMTPSA id AC38261A1E\n for ; Thu, 25 Mar 2021 13:45:56 +0000 (UTC)","by mail-ej1-f45.google.com with SMTP id w3so3015385ejc.4\n for ; Thu, 25 Mar 2021 06:45:56 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1616679957;\n bh=Wa6/rM9ja442iXJV64DujnU8oEP6I6Jf3CVDtM9/i+g=;\n h=References:In-Reply-To:From:Date:Subject:To:Cc:From;\n b=R92Bx0fqbzYkm8Er3iQNKVrTeQmKU6F6bj3hicyw3raObpYhvb1Q36/30NF+6Jls1\n r2qRxcrX5cZWBw41nb5fpAEdOsRCRz7lwltRpAxL5hDLahItz+E7A5oZSUsStWWjSO\n mUbAUu5h7IycV2aQau/SEyRKXAJWNEFHCDaDt2d/E6F9b2jPTxSwwi620R/eXr28xK\n ofxuAmNzm1wcohZoxMiPKZXvTahzlWDYLFVraXZzUnmUiEerLpmtUz/brzNbaB9Muk\n Jl41LObyMgGMcUR25NAEnSFk46QOmcoBLUKsR0CmoLYqNHF3wbsmd2pm7NrIxshYNz\n GDtyTXqXof6hg==","X-Gm-Message-State":"AOAM533MzGGSvU0TvsRTBgx73Tu9ac72OcUhOzWvU94RxnkbyGZlO9yO\n kI/vt6v/AH++anXADJmY31FC0jk9u2uzn+INNQ==","X-Google-Smtp-Source":"\n ABdhPJzrbmmUIm7f4YUAYsUZkVYauIE7ktUpFHMRo4/PQoiQ4okxsC+M9Sv9SxDungP1jD6RUs8DIYlDznCvrylYJ5Q=","X-Received":"by 2002:a17:906:7f84:: with SMTP id\n f4mr9338699ejr.525.1616679955249;\n Thu, 25 Mar 2021 06:45:55 -0700 (PDT)","MIME-Version":"1.0","References":"<20210309000247.2989531-4-danielwa@cisco.com>\n <5f865584-09c9-d21f-ffb7-23cf07cf058e@csgroup.eu>\n <20210309212944.GR109100@zorba>\n \n \n <20fd7d44-8c39-48bc-25c3-990be9d9d911@csgroup.eu>","In-Reply-To":"<20fd7d44-8c39-48bc-25c3-990be9d9d911@csgroup.eu>","From":"Rob Herring ","Date":"Thu, 25 Mar 2021 07:45:41 -0600","X-Gmail-Original-Message-ID":"\n ","Message-ID":"\n ","Subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","To":"Christophe Leroy ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Daniel Gimpelevich ,\n linuxppc-dev , X86 ML ,\n \"open list:MIPS\" ,\n \"linux-kernel@vger.kernel.org\" ,\n Paul Mackerras , xe-linux-external@cisco.com,\n Andrew Morton , Will Deacon ,\n Daniel Walker ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2655692,"web_url":"http://patchwork.ozlabs.org/comment/2655692/","msgid":"<20210325195653.GL109100@zorba>","date":"2021-03-25T19:56:53","subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","submitter":{"id":67374,"url":"http://patchwork.ozlabs.org/api/people/67374/","name":"Daniel Walker (danielwa)","email":"danielwa@cisco.com"},"content":"On Wed, Mar 24, 2021 at 05:59:59PM +0100, Christophe Leroy wrote:\n> > I think my changes maintain most of this due to the override of\n> > CONFIG_CMDLINE_PREPEND. This is an upgrade and the inflexibility in powerpc is\n> > an example of why these changes were created in the first place.\n> \n> \"inflexibility in powerpc\" : Can you elaborate ?\n \nthe prom environment.\n\n> > \n> > For example , say the default command line is \"root=/dev/issblk0\" from iss476\n> > platform. And the bootloader adds \"root=/dev/sda1\"\n> > \n> > The result is .\n> \n> \n> I'm still having hard time understanding the benefit of having both and .\n> Could you please provide a complete exemple from real life, ie what exactly\n> the problem is and what it solves ?\n \nSay the boot loader of an old product is released with a command line of\n\"root=/dev/sda\" and per the needs of the company or product the boot loader can\nnot be upgraded to change this command line. To change this behavior you would\nneed append or EXTEND.\n\nBelow I detail an example of PREPEND due to your list question.\n\n> > \n> > Then you have,\n> > \n> > root=/dev/issblk0 root=/dev/sda1\n> > \n> > and the bootloader has precedent over the default command line. So root= in the\n> > above cases is defined by the bootloader.\n\nA person could input a command line into a boot loader, and it would override\nthe PREPEND values.\n\nCan you imagine you have a default command line which makes root=/dev/issblk0 ,\nbut that doesn't work for you testing purpose. So you input into the boot loader\nroot=/dev/sda1 , since you have the default input in the bootloader OVERRIDEABLE\nyou can do this without re-compiling and just input the single root= command\ninto the bootloader.\n\nDaniel","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=jltPN19e;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=jltPN19e;\n\tdkim-atps=neutral","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=cisco.com (client-ip=173.37.142.92;\n helo=alln-iport-5.cisco.com;\n envelope-from=danielwa@cisco.com; receiver=)","lists.ozlabs.org; dkim=pass (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=jltPN19e; dkim-atps=neutral"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4F5wqq3JwJz9sS8\n\tfor ; Fri, 26 Mar 2021 06:57:27 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4F5wqq2WQWz3bwL\n\tfor ; Fri, 26 Mar 2021 06:57:27 +1100 (AEDT)","from alln-iport-5.cisco.com (alln-iport-5.cisco.com [173.37.142.92])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4F5wqQ3dwZz3bVc\n for ; Fri, 26 Mar 2021 06:57:03 +1100 (AEDT)","from alln-core-5.cisco.com ([173.36.13.138])\n by alln-iport-5.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA;\n 25 Mar 2021 19:56:56 +0000","from zorba ([10.24.0.17])\n by alln-core-5.cisco.com (8.15.2/8.15.2) with ESMTPS id 12PJurCb006095\n (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);\n Thu, 25 Mar 2021 19:56:55 GMT"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=cisco.com; i=@cisco.com; l=1794; q=dns/txt; s=iport;\n t=1616702226; x=1617911826;\n h=date:from:to:cc:subject:message-id:references:\n mime-version:in-reply-to;\n bh=pu2I9fiU+I/A1fLeU7DBkeJ7rBv/7jFx5HzFlCmOGBA=;\n b=jltPN19elXn857gaCpW9vlEcyWWjbVCv9Zh6dcT9bBu9ywTejjGjIs7r\n 0PoyVk4QTWzhOkGqanQxLxgjy0O8Ykyunh6lXntNYGOjVv1X0R87UJ1Dk\n DWZlblr3tCZk6cCyCtbFB8X5OEm3mkEyQB7tXpvgbtKyvJaRBg5URsmBp 4=;","X-IPAS-Result":"\n A0AjAACo6lxgmIoNJK1aGwEBAQEBAQEBBQEBARIBAQEDAwEBAUCBPgQBAQELAYN2ATmWPAOQB4pbgXwLAQEBDQEBNAQBAYRQAoF8AiU2Bw4CAwEBAQMCAwEBAQEFAQEBAgEGBBQBAQEBAQEBAYZDhkUBAgM6PxALGC48GwYsgleDCKspdYE0iRaBRBQOgRcBjUImHIFJQoQuPoQxhWMiBIJGF3mBCGcVBGI1kCxRjQuKQ5BIgRSDEIEimEiCaTEQgziKbZYbuBACBAYFAhaBWgExgVszGggbFTuCak8ZDY44jk8hA2cCBgoBAQMJhSqCQwEB","IronPort-HdrOrdr":"A9a23:EyzLJ6OQ0cmmLsBcT5r155DYdL4zR+YMi2QD/UoZc3NoW+afkN\n 2jm+le+B/vkTAKWGwhn9foAtjkfVr385lp7Y4NeYqzRQWOghrLEKhO5ZbvqgeLJwTQ7ehYvJ\n 0MT4FfD5nKAUF+nYLG5mCDYrId6f2m1IztuuvE1XdqSmhRGsJdxiN0EBySHEEzZCQuP/sEPa\n GR7MZGuDasEE5/Bq+GL0IIUOTZq9rAmIiOW347LiQ64wqDhy7A0tDHOiWfty1zbxp/hZ8/7G\n 6AqADi/6Olqf3+8APEznTe9Y4+oqqH9vJzQOqRl8MSNjLgziGvaYgJYcz6gBkF5Mey9V0tjN\n 7A5y0FAv02wXbQcmapyCGdvTXd7A==","X-IronPort-Anti-Spam-Filtered":"true","X-IronPort-AV":"E=Sophos;i=\"5.81,278,1610409600\"; d=\"scan'208\";a=\"686872034\"","Date":"Thu, 25 Mar 2021 12:56:53 -0700","From":"Daniel Walker ","To":"Christophe Leroy ","Subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","Message-ID":"<20210325195653.GL109100@zorba>","References":"<20210309000247.2989531-4-danielwa@cisco.com>\n <5f865584-09c9-d21f-ffb7-23cf07cf058e@csgroup.eu>\n <20210309212944.GR109100@zorba>\n ","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","X-Auto-Response-Suppress":"DR, OOF, AutoReply","X-Outbound-SMTP-Client":"10.24.0.17, [10.24.0.17]","X-Outbound-Node":"alln-core-5.cisco.com","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Rob Herring ,\n Daniel Gimpelevich ,\n linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-mips@vger.kernel.org,\n linux-kernel@vger.kernel.org, Paul Mackerras ,\n xe-linux-external@cisco.com, Andrew Morton ,\n Will Deacon ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2655694,"web_url":"http://patchwork.ozlabs.org/comment/2655694/","msgid":"<20210325195956.GM109100@zorba>","date":"2021-03-25T19:59:56","subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","submitter":{"id":67374,"url":"http://patchwork.ozlabs.org/api/people/67374/","name":"Daniel Walker (danielwa)","email":"danielwa@cisco.com"},"content":"On Thu, Mar 25, 2021 at 01:03:55PM +0100, Christophe Leroy wrote:\n> \n> Ok, so you agree we don't need to provide two CMDLINE, one to be appended and one to be prepended.\n> \n> Let's only provide once CMDLINE as of today, and ask the user to select\n> whether he wants it appended or prepended or replacee. Then no need to\n> change all existing config to rename CONFIG_CMDLINE into either of the new\n> ones.\n> \n> That's the main difference between my series and Daniel's series. So I'll\n> finish taking Will's comment into account and we'll send out a v3 soon.\n\nIt doesn't solve the needs of Cisco, I've stated many times your changes have\nlittle value. Please stop submitting them.\n\nDaniel","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=OC2vshVf;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=OC2vshVf;\n\tdkim-atps=neutral","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=cisco.com (client-ip=173.37.86.75; helo=rcdn-iport-4.cisco.com;\n envelope-from=danielwa@cisco.com; receiver=)","lists.ozlabs.org; dkim=pass (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=OC2vshVf; dkim-atps=neutral"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4F5wvG4SVYz9sVS\n\tfor ; Fri, 26 Mar 2021 07:00:26 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4F5wvG3KNqz3brM\n\tfor ; Fri, 26 Mar 2021 07:00:26 +1100 (AEDT)","from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4F5wtq55c8z303g\n for ; Fri, 26 Mar 2021 07:00:02 +1100 (AEDT)","from alln-core-10.cisco.com ([173.36.13.132])\n by rcdn-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA;\n 25 Mar 2021 19:59:59 +0000","from zorba ([10.24.0.17])\n by alln-core-10.cisco.com (8.15.2/8.15.2) with ESMTPS id 12PJxvYJ009948\n (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);\n Thu, 25 Mar 2021 19:59:58 GMT"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=cisco.com; i=@cisco.com; l=704; q=dns/txt; s=iport;\n t=1616702403; x=1617912003;\n h=date:from:to:cc:subject:message-id:references:\n mime-version:in-reply-to;\n bh=iWag3nlhZsh0PSEeVxiaq1tQo7jXl7/iI10UazG4Z0Q=;\n b=OC2vshVf7t1XhBQe4T03tmmmNafLLMIXCLOkgiTe56Nl2f0wq1sSkRmZ\n q/LDd0j08lc+t/50tZf9oin9FFVl0F4Qx6GNk6JEEsCHAzv870egIkkjq\n /xQRkVzGb9wmp/rh6N3VF7GuFSWvpIsDIU8KkGG9nkBs0zNRypQz2xU5b A=;","IronPort-HdrOrdr":"\n A9a23:ekwar6MSi0olHsBcT5r155DYdL4zR+YMi2QD/UoZc3NoW+afkN2jm+le+B/vkTAKWGwhn9foAtjkfVr385lp7Y4NeYqzRQWOghrLEKhO5ZbvqgeLJwTQ7ehYvJ0MT4FfD5nKAUF+nYLG5mCDYrId6f2m1IztuuvE1XdqSmhRGsJdxiN0EBySHEEzZCQuP/sEPaGR7MZGuDasEE5/Bq+GL0IIUOTZq9rAmIiOW347LiQ64wqDhy7A0tDHOiWfty1zbxp/hZ8/7G6AqADi/6Olqf3+8APEznTe9Y4+oqqH9vJzQOqRl8MSNjLgziGvaYgJYcz6gBkF5Mey9V0tjN7A5y0FAv02wXbQcmapyCGdvTXd7A==","X-IronPort-Anti-Spam-Filtered":"true","X-IronPort-Anti-Spam-Result":"\n A0AnAABg61xg/4QNJK1aGgEBAQEBAQEBAQEDAQEBARIBAQEBAgIBAQEBQIE+AwEBAQELAYIqgUwBOZY/kAeKWxSBaAsBAQENAQE0BAEBhFACgXwCJTYHDgIDAQELAQEFAQEBAgEGBHGFboZFAQU6PxALGBUZPBsGhgurKXWBNIkWgUQUDoEXAY1CJhyBSUKELj6DeYEGhRUiBIFlYYEQggRYFJErgkCKTJwfgxCBIpsxMRCDOIptlhu4EAIEBgUCFoFaATOBWTMaCBsVgyVPGQ2dByEDZwIGCgEBAwmHbQEB","X-IronPort-AV":"E=Sophos;i=\"5.81,278,1610409600\"; d=\"scan'208\";a=\"852860109\"","Date":"Thu, 25 Mar 2021 12:59:56 -0700","From":"Daniel Walker ","To":"Christophe Leroy ","Subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","Message-ID":"<20210325195956.GM109100@zorba>","References":"<20210309000247.2989531-4-danielwa@cisco.com>\n <5f865584-09c9-d21f-ffb7-23cf07cf058e@csgroup.eu>\n <20210309212944.GR109100@zorba>\n \n \n <20fd7d44-8c39-48bc-25c3-990be9d9d911@csgroup.eu>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20fd7d44-8c39-48bc-25c3-990be9d9d911@csgroup.eu>","X-Auto-Response-Suppress":"DR, OOF, AutoReply","X-Outbound-SMTP-Client":"10.24.0.17, [10.24.0.17]","X-Outbound-Node":"alln-core-10.cisco.com","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Rob Herring ,\n Daniel Gimpelevich ,\n linuxppc-dev , X86 ML ,\n \"open list:MIPS\" ,\n \"linux-kernel@vger.kernel.org\" ,\n Paul Mackerras , xe-linux-external@cisco.com,\n Andrew Morton , Will Deacon ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2655782,"web_url":"http://patchwork.ozlabs.org/comment/2655782/","msgid":"","date":"2021-03-25T23:29:44","subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Thu, Mar 25, 2021 at 2:00 PM Daniel Walker wrote:\n>\n> On Thu, Mar 25, 2021 at 01:03:55PM +0100, Christophe Leroy wrote:\n> >\n> > Ok, so you agree we don't need to provide two CMDLINE, one to be appended and one to be prepended.\n> >\n> > Let's only provide once CMDLINE as of today, and ask the user to select\n> > whether he wants it appended or prepended or replacee. Then no need to\n> > change all existing config to rename CONFIG_CMDLINE into either of the new\n> > ones.\n> >\n> > That's the main difference between my series and Daniel's series. So I'll\n> > finish taking Will's comment into account and we'll send out a v3 soon.\n>\n> It doesn't solve the needs of Cisco, I've stated many times your changes have\n> little value. Please stop submitting them.\n\nCan you please outline what those needs are which aren't met?\n\nRob","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ays7TH2U;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ays7TH2U;\n\tdkim-atps=neutral","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org;\n envelope-from=robh@kernel.org; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ays7TH2U;\n dkim-atps=neutral"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4F61YX6WZkz9sRN\n\tfor ; Fri, 26 Mar 2021 10:30:24 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4F61YX5YGqz3bx9\n\tfor ; Fri, 26 Mar 2021 10:30:24 +1100 (AEDT)","from mail.kernel.org (mail.kernel.org [198.145.29.99])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4F61Y44Mmkz2yhF\n for ; Fri, 26 Mar 2021 10:30:00 +1100 (AEDT)","by mail.kernel.org (Postfix) with ESMTPSA id 7C53961A42\n for ; Thu, 25 Mar 2021 23:29:57 +0000 (UTC)","by mail-ej1-f51.google.com with SMTP id ce10so5691208ejb.6\n for ; Thu, 25 Mar 2021 16:29:57 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1616714997;\n bh=1So/sDC1qFPREyegXHFcy7/VmRkzeq/fmOvYjRI/LkM=;\n h=References:In-Reply-To:From:Date:Subject:To:Cc:From;\n b=ays7TH2UlrPjYT2EhVKB9kfoPA5X87la04AArIOH/b/tNiVyioalV2c0dN8bICOoL\n 7VJtPJyCS9xna9DctRH8KPmi55ZNcoYl6ih9TRaL9tTERYwV06i8f7RN/lu6xMqld9\n e2l8Of2a/O3BXNaZZgjWqjkX0LVObsYgCGTtH+ZCr2VaXRrIItdTzF93vAGrcWB7z3\n Ewo07B3N41P6QiPOcmR96/pdF1SZpaj3tHf5XQrXzYYKBM0F01axjY0X5FWxjIwrJt\n cDmzFK//Fa80+AgrWa/Pscxi8j3sI2x8kQO05VvBQdTX/SWhTViEySY6kw5g9Bhi0R\n UVP/O02On5eaw==","X-Gm-Message-State":"AOAM530HEKL0ztrleJRqKmMUo3BA6beTvVGWUCd1eL6GfrpwiXlr2bzs\n KcxFT5rqFJVT5U4sjmUy0Hw9w8YXHdJpuaIdhA==","X-Google-Smtp-Source":"\n ABdhPJyp90At2ic5zxJIDhb11Bg7kKraVHtULioYfIts4QYqWxOJiucuvniDhV6Uc0L1MCJm0RL6y9lW3E+JgBiBtTE=","X-Received":"by 2002:a17:906:5e01:: with SMTP id\n n1mr12293198eju.359.1616714996020;\n Thu, 25 Mar 2021 16:29:56 -0700 (PDT)","MIME-Version":"1.0","References":"<20210309000247.2989531-4-danielwa@cisco.com>\n <5f865584-09c9-d21f-ffb7-23cf07cf058e@csgroup.eu>\n <20210309212944.GR109100@zorba>\n \n \n <20fd7d44-8c39-48bc-25c3-990be9d9d911@csgroup.eu>\n <20210325195956.GM109100@zorba>","In-Reply-To":"<20210325195956.GM109100@zorba>","From":"Rob Herring ","Date":"Thu, 25 Mar 2021 17:29:44 -0600","X-Gmail-Original-Message-ID":"\n ","Message-ID":"\n ","Subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","To":"Daniel Walker ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Daniel Gimpelevich ,\n linuxppc-dev , X86 ML ,\n \"open list:MIPS\" ,\n \"linux-kernel@vger.kernel.org\" ,\n Paul Mackerras , xe-linux-external@cisco.com,\n Andrew Morton , Will Deacon ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2657255,"web_url":"http://patchwork.ozlabs.org/comment/2657255/","msgid":"<20210329100750.GB3207@willie-the-truck>","date":"2021-03-29T10:07:51","subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","submitter":{"id":76918,"url":"http://patchwork.ozlabs.org/api/people/76918/","name":"Will Deacon","email":"will@kernel.org"},"content":"On Thu, Mar 25, 2021 at 12:59:56PM -0700, Daniel Walker wrote:\n> On Thu, Mar 25, 2021 at 01:03:55PM +0100, Christophe Leroy wrote:\n> > \n> > Ok, so you agree we don't need to provide two CMDLINE, one to be appended and one to be prepended.\n> > \n> > Let's only provide once CMDLINE as of today, and ask the user to select\n> > whether he wants it appended or prepended or replacee. Then no need to\n> > change all existing config to rename CONFIG_CMDLINE into either of the new\n> > ones.\n> > \n> > That's the main difference between my series and Daniel's series. So I'll\n> > finish taking Will's comment into account and we'll send out a v3 soon.\n> \n> It doesn't solve the needs of Cisco, I've stated many times your changes have\n> little value. Please stop submitting them.\n\nFWIW, they're useful for arm64 and I will gladly review the updated series.\n\nI don't think asking people to stop submitting patches is ever the right\nanswer. Please don't do that.\n\nWill","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=f9EhhMV0;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=f9EhhMV0;\n\tdkim-atps=neutral","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org;\n envelope-from=will@kernel.org; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=f9EhhMV0;\n dkim-atps=neutral"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4F87ZJ2xM5z9sRf\n\tfor ; Mon, 29 Mar 2021 21:08:24 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4F87ZJ1SFSz2y86\n\tfor ; Mon, 29 Mar 2021 21:08:24 +1100 (AEDT)","from mail.kernel.org (mail.kernel.org [198.145.29.99])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4F87Yx2j0qz2y0G\n for ; Mon, 29 Mar 2021 21:08:05 +1100 (AEDT)","by mail.kernel.org (Postfix) with ESMTPSA id 4C2D161585;\n Mon, 29 Mar 2021 10:07:54 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1617012476;\n bh=pMPh6eyELHUsFo1+GSOTU018GXuHnqwmLWfjowXKpSM=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=f9EhhMV0Q2/acyWJ/ZfxNWBKDPSPFcewP+yYd7grUMYR6ohYLn/GQbjkVRfpx6hy1\n qlz2kGTV6H9hIJ3P83OFCRWasmAPh0B4tg4uRiF/UiE/RSNCbR5Vp/lFYg26JDmhOc\n MWyUZuzkuVH70jdZJzCAyLBOqrXhFTb1bKdlZHGSYbFlC9bk2RUcV6QNHQmOXZOSfw\n MB8cWs05TS9x1iAejddICQs8gS82J+9FM1MYdvz//gI0U56nk09G1BsYCdMIXSnO7c\n KleBb0hQlKjIQJz/LgOJaH5ew9SHfhQgI3a4l184IRzCzZU/6ZjlfekxQPDfmmV3Jo\n EOvtS+AxR38PQ==","Date":"Mon, 29 Mar 2021 11:07:51 +0100","From":"Will Deacon ","To":"Daniel Walker ","Subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","Message-ID":"<20210329100750.GB3207@willie-the-truck>","References":"<20210309000247.2989531-4-danielwa@cisco.com>\n <5f865584-09c9-d21f-ffb7-23cf07cf058e@csgroup.eu>\n <20210309212944.GR109100@zorba>\n \n \n <20fd7d44-8c39-48bc-25c3-990be9d9d911@csgroup.eu>\n <20210325195956.GM109100@zorba>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210325195956.GM109100@zorba>","User-Agent":"Mutt/1.10.1 (2018-07-13)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Rob Herring ,\n Daniel Gimpelevich ,\n X86 ML , \"open list:MIPS\" ,\n \"linux-kernel@vger.kernel.org\" ,\n Paul Mackerras , xe-linux-external@cisco.com,\n Andrew Morton ,\n linuxppc-dev ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2658399,"web_url":"http://patchwork.ozlabs.org/comment/2658399/","msgid":"<20210330173254.GS109100@zorba>","date":"2021-03-30T17:32:54","subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","submitter":{"id":67374,"url":"http://patchwork.ozlabs.org/api/people/67374/","name":"Daniel Walker (danielwa)","email":"danielwa@cisco.com"},"content":"On Thu, Mar 25, 2021 at 05:29:44PM -0600, Rob Herring wrote:\n> On Thu, Mar 25, 2021 at 2:00 PM Daniel Walker wrote:\n> >\n> > On Thu, Mar 25, 2021 at 01:03:55PM +0100, Christophe Leroy wrote:\n> > >\n> > > Ok, so you agree we don't need to provide two CMDLINE, one to be appended and one to be prepended.\n> > >\n> > > Let's only provide once CMDLINE as of today, and ask the user to select\n> > > whether he wants it appended or prepended or replacee. Then no need to\n> > > change all existing config to rename CONFIG_CMDLINE into either of the new\n> > > ones.\n> > >\n> > > That's the main difference between my series and Daniel's series. So I'll\n> > > finish taking Will's comment into account and we'll send out a v3 soon.\n> >\n> > It doesn't solve the needs of Cisco, I've stated many times your changes have\n> > little value. Please stop submitting them.\n> \n> Can you please outline what those needs are which aren't met?\n\nappend AND prepend at the same time on all architectures. Christophe doesn't\nunderstand the need, and hence tries to minimize the feature set which is\nincompatible with Cisco needs and all the other out of tree users.\n\nDaniel","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=ddbImwex;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=ddbImwex;\n\tdkim-atps=neutral","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=cisco.com (client-ip=173.37.142.93;\n helo=alln-iport-6.cisco.com;\n envelope-from=danielwa@cisco.com; receiver=)","lists.ozlabs.org; dkim=pass (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=ddbImwex; dkim-atps=neutral"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4F8xPK2zMRz9sVS\n\tfor ; Wed, 31 Mar 2021 04:33:25 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4F8xPK1FGwz3c4w\n\tfor ; Wed, 31 Mar 2021 04:33:25 +1100 (AEDT)","from alln-iport-6.cisco.com (alln-iport-6.cisco.com [173.37.142.93])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4F8xNw3m00z2ywy\n for ; Wed, 31 Mar 2021 04:33:02 +1100 (AEDT)","from rcdn-core-4.cisco.com ([173.37.93.155])\n by alln-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA;\n 30 Mar 2021 17:32:59 +0000","from zorba ([10.24.8.123])\n by rcdn-core-4.cisco.com (8.15.2/8.15.2) with ESMTPS id 12UHWsUi019331\n (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);\n Tue, 30 Mar 2021 17:32:57 GMT"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=cisco.com; i=@cisco.com; l=1192; q=dns/txt; s=iport;\n t=1617125584; x=1618335184;\n h=date:from:to:cc:subject:message-id:references:\n mime-version:in-reply-to;\n bh=2LZfLmeECNVtSnr3Mh+CyIjZ9xFZqjH6FwYenu/bjCA=;\n b=ddbImwexNhKwMFYVfPwfW1qCbEiBihF/mY8cgqnKBgEjEa+ro6vqOdGQ\n t6LXbSrDSXPbm+U6z/4OrwlTkiLv/QqbvqbjRd93g7tX6AsbjrEgCg5rg\n xh3c/hseqIaUwayvjJKlpmYezaZLZ2Q4Nb2aSEXtXiEKA6ntSvHIOQiHH Y=;","X-IPAS-Result":"\n A0ASAAC4X2NgmJtdJa1aGgEBAQEBAQEBAQEDAQEBARIBAQEBAgIBAQEBQIE/AgEBAQELAYN2ATkxlhEDkAgWilmBaAsBAQENAQE0BAEBhFACgXoCJTcGDgIDAQEBAwIDAQEBAQEFAQEBAgEGBBQBAQEBAQEBAYZDhkUBAgM6PxALGBUZPBsGE4JwgwirJXWBNIkLgUQUDoEXAY1JJhyBSUKELj6DeYEGhRUiBIFlYYEQggRYFAKRKoJAikycIoMRgSObNjEQgziKb5YbuBICBAYFAhaBaiKBWzMaCBsVgyRQGQ2OOI5PIQMvOAIGCgEBAwmJHwEB","IronPort-HdrOrdr":"A9a23:DnBJjKzmbOdjEo60P+GWKrPxd+skLtp033Aq2lEZdDV+eKWj+P\n yGtvIdyBPylXI9WGs4n8qBJamHRhrnhPtIyKMWOqqvWxSjhXuwIOhZnOnf6hDpBiGWzIRg/I\n h6dawWMrDNJHh8yf33+QypV+snqeP3lJyAocf74zNTQRpxa6dmhj0JaTqzNkFtXgFJCd4YOf\n Onh/ZvnDardXQJYsnTPBBsNNTrnNHFmInrZhQLHXcciDWmty+i67LxDnGjsCs2bjUn+9sf2F\n mAuxDl4OGZv+ujzBjH2yvo841Og9f60LJ4dauxo/lQDCnwgQC1Y4kkfLuOsFkO0ZiSwWdvts\n XQqBE9OMk20VftRyWepBvg3BSI6kdJ10Pf","X-IronPort-Anti-Spam-Filtered":"true","X-IronPort-AV":"E=Sophos;i=\"5.81,291,1610409600\"; d=\"scan'208\";a=\"711698846\"","Date":"Tue, 30 Mar 2021 10:32:54 -0700","From":"Daniel Walker ","To":"Rob Herring ","Subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","Message-ID":"<20210330173254.GS109100@zorba>","References":"<20210309000247.2989531-4-danielwa@cisco.com>\n <5f865584-09c9-d21f-ffb7-23cf07cf058e@csgroup.eu>\n <20210309212944.GR109100@zorba>\n \n \n <20fd7d44-8c39-48bc-25c3-990be9d9d911@csgroup.eu>\n <20210325195956.GM109100@zorba>\n ","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"\n ","X-Auto-Response-Suppress":"DR, OOF, AutoReply","X-Outbound-SMTP-Client":"10.24.8.123, [10.24.8.123]","X-Outbound-Node":"rcdn-core-4.cisco.com","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Daniel Gimpelevich ,\n linuxppc-dev , X86 ML ,\n \"open list:MIPS\" ,\n \"linux-kernel@vger.kernel.org\" ,\n Paul Mackerras , xe-linux-external@cisco.com,\n Andrew Morton , Will Deacon ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2658402,"web_url":"http://patchwork.ozlabs.org/comment/2658402/","msgid":"<20210330173521.GT109100@zorba>","date":"2021-03-30T17:35:21","subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","submitter":{"id":67374,"url":"http://patchwork.ozlabs.org/api/people/67374/","name":"Daniel Walker (danielwa)","email":"danielwa@cisco.com"},"content":"On Mon, Mar 29, 2021 at 11:07:51AM +0100, Will Deacon wrote:\n> On Thu, Mar 25, 2021 at 12:59:56PM -0700, Daniel Walker wrote:\n> > On Thu, Mar 25, 2021 at 01:03:55PM +0100, Christophe Leroy wrote:\n> > > \n> > > Ok, so you agree we don't need to provide two CMDLINE, one to be appended and one to be prepended.\n> > > \n> > > Let's only provide once CMDLINE as of today, and ask the user to select\n> > > whether he wants it appended or prepended or replacee. Then no need to\n> > > change all existing config to rename CONFIG_CMDLINE into either of the new\n> > > ones.\n> > > \n> > > That's the main difference between my series and Daniel's series. So I'll\n> > > finish taking Will's comment into account and we'll send out a v3 soon.\n> > \n> > It doesn't solve the needs of Cisco, I've stated many times your changes have\n> > little value. Please stop submitting them.\n> \n> FWIW, they're useful for arm64 and I will gladly review the updated series.\n> \n> I don't think asking people to stop submitting patches is ever the right\n> answer. Please don't do that.\n\nWhy ? It's me nacking his series, is that not allowed anymore ?\n\nDaniel","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=Wg8jsGpr;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=Wg8jsGpr;\n\tdkim-atps=neutral","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=cisco.com (client-ip=173.37.142.88;\n helo=alln-iport-1.cisco.com;\n envelope-from=danielwa@cisco.com; receiver=)","lists.ozlabs.org; dkim=pass (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=Wg8jsGpr; dkim-atps=neutral"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4F8xS63YYZz9sXH\n\tfor ; Wed, 31 Mar 2021 04:35:50 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4F8xS62dKvz3brZ\n\tfor ; Wed, 31 Mar 2021 04:35:50 +1100 (AEDT)","from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4F8xRk4BMxz2yRZ\n for ; Wed, 31 Mar 2021 04:35:30 +1100 (AEDT)","from rcdn-core-2.cisco.com ([173.37.93.153])\n by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA;\n 30 Mar 2021 17:35:26 +0000","from zorba ([10.24.8.123])\n by rcdn-core-2.cisco.com (8.15.2/8.15.2) with ESMTPS id 12UHZMBO032401\n (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);\n Tue, 30 Mar 2021 17:35:24 GMT"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=cisco.com; i=@cisco.com; l=1151; q=dns/txt; s=iport;\n t=1617125730; x=1618335330;\n h=date:from:to:cc:subject:message-id:references:\n mime-version:in-reply-to;\n bh=0ijngtCeHVdaxTwLB1CJ9gXZHFg+3Ll7FC+tYt3/onQ=;\n b=Wg8jsGpreN635QrT9FnEk6LCY458kCJuqkJ22mS6FpN1vZGk1hhfLTdE\n f90QOrnUPZqD2pY53Tt1ZPiZ8mkN2oPR7M2MVr3sOWKd5Cmqcxun2kMS9\n BLARw026nUp5c7tzTJkc+XnMZYScXNZLb39w6eJ6FOEebv7lJZwZAfq6H 8=;","X-IPAS-Result":"\n A0AYAAAUYGNgmJldJa1aGwEBAQEBAQEBBQEBARIBAQEDAwEBAUCBPgQBAQELAYN2ATmWQQOQCBaKRRSBaAsBAQENAQE0BAEBhFACgXoCJTYHDgIDAQEBAwIDAQEBAQEFAQEBAgEGBBQBAQEBAQEBAYZDhkUBAgM6PxALGBUZPBsGgwODCKsndYE0iQuBRBQOgRcBjUkmHIFJQoESgxw+g3mBBoUVIgSBZWGBEIIEOR8UkSyCQIpMnCKDEYEjmzYxEIM4im+WG7gSAgQGBQIWgVoBMYFbMxoIGxWDJU8ZDY44jk8hA2cCBgoBAQMJiR8BAQ","IronPort-HdrOrdr":"A9a23:L439FKp7WPX8plUepRxP7I0aV5twL9V00zAX/kB9WHVpW+aT/v\n rAoN0w0xjohDENHFwhg8mHIqmcQXXanKQFhLU5F7GkQQXgpS+UPJhvhLGSoQHINiXi+odmv5\n tIXLN5DLTLYGRSrcG/2wWgFsZl/d/vytHNuc7771NACT5ncLth6QARMHf5LmRTSBNdDZQ0UL\n qwj/AnmxOadX4abtu2CxA+NoCpm/TxmJ3rehIADRI8gTPvsRqT9LX4HxKEty1xbxpzx94ZnV\n TtokjQ+rik98q20Abb0HXeq65LgcL7xsFYbfb87fQ9G3HLlhuiYphnVvmkuj04ydvfkWoCoZ\n 3rvwoqOdh15jfqWlyN5THp2wXmzV8Vmhnf9WM=","X-IronPort-Anti-Spam-Filtered":"true","X-IronPort-AV":"E=Sophos;i=\"5.81,291,1610409600\"; d=\"scan'208\";a=\"668294645\"","Date":"Tue, 30 Mar 2021 10:35:21 -0700","From":"Daniel Walker ","To":"Will Deacon ","Subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","Message-ID":"<20210330173521.GT109100@zorba>","References":"<20210309000247.2989531-4-danielwa@cisco.com>\n <5f865584-09c9-d21f-ffb7-23cf07cf058e@csgroup.eu>\n <20210309212944.GR109100@zorba>\n \n \n <20fd7d44-8c39-48bc-25c3-990be9d9d911@csgroup.eu>\n <20210325195956.GM109100@zorba>\n <20210329100750.GB3207@willie-the-truck>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210329100750.GB3207@willie-the-truck>","X-Auto-Response-Suppress":"DR, OOF, AutoReply","X-Outbound-SMTP-Client":"10.24.8.123, [10.24.8.123]","X-Outbound-Node":"rcdn-core-2.cisco.com","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Rob Herring ,\n Daniel Gimpelevich ,\n X86 ML , \"open list:MIPS\" ,\n \"linux-kernel@vger.kernel.org\" ,\n Paul Mackerras , xe-linux-external@cisco.com,\n Andrew Morton ,\n linuxppc-dev ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2658499,"web_url":"http://patchwork.ozlabs.org/comment/2658499/","msgid":"","date":"2021-03-30T20:13:04","subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Tue, Mar 30, 2021 at 12:33 PM Daniel Walker wrote:\n>\n> On Thu, Mar 25, 2021 at 05:29:44PM -0600, Rob Herring wrote:\n> > On Thu, Mar 25, 2021 at 2:00 PM Daniel Walker wrote:\n> > >\n> > > On Thu, Mar 25, 2021 at 01:03:55PM +0100, Christophe Leroy wrote:\n> > > >\n> > > > Ok, so you agree we don't need to provide two CMDLINE, one to be appended and one to be prepended.\n> > > >\n> > > > Let's only provide once CMDLINE as of today, and ask the user to select\n> > > > whether he wants it appended or prepended or replacee. Then no need to\n> > > > change all existing config to rename CONFIG_CMDLINE into either of the new\n> > > > ones.\n> > > >\n> > > > That's the main difference between my series and Daniel's series. So I'll\n> > > > finish taking Will's comment into account and we'll send out a v3 soon.\n> > >\n> > > It doesn't solve the needs of Cisco, I've stated many times your changes have\n> > > little value. Please stop submitting them.\n> >\n> > Can you please outline what those needs are which aren't met?\n>\n> append AND prepend at the same time on all architectures. Christophe doesn't\n> understand the need, and hence tries to minimize the feature set which is\n> incompatible with Cisco needs and all the other out of tree users.\n\nOkay, but that's never been a feature in upstream. For upstream, we\nrefactor first and add features 2nd. In this case, the difference is\nlargely the kconfig and it would be better to not change the options\ntwice, but that's not a blocker for taking the refactoring. You won't\nfind a maintainer that's going to take adding a feature over cleanups\nand unification.\n\nRob","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=oxcTEFt8;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=oxcTEFt8;\n\tdkim-atps=neutral","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org;\n envelope-from=robh@kernel.org; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=oxcTEFt8;\n dkim-atps=neutral"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4F90yC0lyKz9sWS\n\tfor ; Wed, 31 Mar 2021 07:13:39 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4F90yB6mCrz3bxd\n\tfor ; Wed, 31 Mar 2021 07:13:38 +1100 (AEDT)","from mail.kernel.org (mail.kernel.org [198.145.29.99])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4F90xp5Vy5z2y8Q\n for ; Wed, 31 Mar 2021 07:13:18 +1100 (AEDT)","by mail.kernel.org (Postfix) with ESMTPSA id 3E7F2619D0\n for ; Tue, 30 Mar 2021 20:13:16 +0000 (UTC)","by mail-qv1-f45.google.com with SMTP id by2so8818718qvb.11\n for ; Tue, 30 Mar 2021 13:13:16 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1617135196;\n bh=a0u6btj9eABWcxyPcMcImxEQD72LmDexfcRuz0Fotaw=;\n h=References:In-Reply-To:From:Date:Subject:To:Cc:From;\n b=oxcTEFt8SZA7Bx7749WETP1GMcz8oii+pSej4jE7fgG7WS52nFSAy0fAei47dgGTT\n q+Qb1Vck6k9rwb/VKFbpxYLCRwW8Zmp1NygRTYvTbkrtN8tcJTYHnYqP37zGDxtl3E\n fLVdYj+EF8UqAvR0aWxEGFZxJkFSDv4Byhn8kleGogmKDj7PTae42Z1E5/o+jWQsb1\n HYw1Fo55Tqy0SK39VzMpcr/2Pwo8JaJitq/88PjP/eTbN9nL6pj+wOZyP2ryfIX68I\n bA376/UXRBuXIyfqtJFeQh4VhT/oB3BGehfnYkXzNHHRLkOJra/md8EVxl2jTS73e4\n GEFqd0oC0lteg==","X-Gm-Message-State":"AOAM532r54RIukg/3Fdarc0YM1l0TvhqWqdzUkIK7fdlvM0wfxJ3DGgz\n sMaB0Rn7Rn5r3Tgp4fCxxuOZ5PNHgQz0WyagSQ==","X-Google-Smtp-Source":"\n ABdhPJw55amAUhZyFZAQITDAaWCWvjRQ4s0B/xEdY/mzymYT1/HSrfDlYWJbEwEmGzlU1vhNgrIIF8xwK9tMaYRV82Y=","X-Received":"by 2002:a05:6214:12a1:: with SMTP id\n w1mr32724714qvu.57.1617135195251;\n Tue, 30 Mar 2021 13:13:15 -0700 (PDT)","MIME-Version":"1.0","References":"<20210309000247.2989531-4-danielwa@cisco.com>\n <5f865584-09c9-d21f-ffb7-23cf07cf058e@csgroup.eu>\n <20210309212944.GR109100@zorba>\n \n \n <20fd7d44-8c39-48bc-25c3-990be9d9d911@csgroup.eu>\n <20210325195956.GM109100@zorba>\n \n <20210330173254.GS109100@zorba>","In-Reply-To":"<20210330173254.GS109100@zorba>","From":"Rob Herring ","Date":"Tue, 30 Mar 2021 15:13:04 -0500","X-Gmail-Original-Message-ID":"\n ","Message-ID":"\n ","Subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","To":"Daniel Walker ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Daniel Gimpelevich ,\n linuxppc-dev , X86 ML ,\n \"open list:MIPS\" ,\n \"linux-kernel@vger.kernel.org\" ,\n Paul Mackerras , xe-linux-external@cisco.com,\n Andrew Morton , Will Deacon ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2658642,"web_url":"http://patchwork.ozlabs.org/comment/2658642/","msgid":"<20210330233137.GB2469518@zorba>","date":"2021-03-30T23:31:37","subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","submitter":{"id":67374,"url":"http://patchwork.ozlabs.org/api/people/67374/","name":"Daniel Walker (danielwa)","email":"danielwa@cisco.com"},"content":"On Tue, Mar 30, 2021 at 03:13:04PM -0500, Rob Herring wrote:\n> On Tue, Mar 30, 2021 at 12:33 PM Daniel Walker wrote:\n> >\n> > On Thu, Mar 25, 2021 at 05:29:44PM -0600, Rob Herring wrote:\n> > > On Thu, Mar 25, 2021 at 2:00 PM Daniel Walker wrote:\n> > > >\n> > > > On Thu, Mar 25, 2021 at 01:03:55PM +0100, Christophe Leroy wrote:\n> > > > >\n> > > > > Ok, so you agree we don't need to provide two CMDLINE, one to be appended and one to be prepended.\n> > > > >\n> > > > > Let's only provide once CMDLINE as of today, and ask the user to select\n> > > > > whether he wants it appended or prepended or replacee. Then no need to\n> > > > > change all existing config to rename CONFIG_CMDLINE into either of the new\n> > > > > ones.\n> > > > >\n> > > > > That's the main difference between my series and Daniel's series. So I'll\n> > > > > finish taking Will's comment into account and we'll send out a v3 soon.\n> > > >\n> > > > It doesn't solve the needs of Cisco, I've stated many times your changes have\n> > > > little value. Please stop submitting them.\n> > >\n> > > Can you please outline what those needs are which aren't met?\n> >\n> > append AND prepend at the same time on all architectures. Christophe doesn't\n> > understand the need, and hence tries to minimize the feature set which is\n> > incompatible with Cisco needs and all the other out of tree users.\n> \n> Okay, but that's never been a feature in upstream. For upstream, we\n> refactor first and add features 2nd. In this case, the difference is\n> largely the kconfig and it would be better to not change the options\n> twice, but that's not a blocker for taking the refactoring. You won't\n> find a maintainer that's going to take adding a feature over cleanups\n> and unification.\n\nIt kind of is a feature in upstream, it's a matter of opinion. Some platform\nused append and some use prepend, and it's likely because the maintainers needed\none or the other for development.\n\nI'm not sure why you think I can't add the features in one go. It would be\nhorrid to take Christophe's changes, then have to do basically all the same work\na second time which is what Christophe's changes would force me to do.\n\nSay for example I implement this change only on one architecture. In that case\nthe maintainer would be accepting a feature enhancement , but there would be no\nstopping it. I shouldn't have to go two strokes on one architecture, but each\nchange I'm making is essentially a single architecture. They can go in all\ntogether or one at a time.\n\nDaniel","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=AHjsZv0R;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=AHjsZv0R;\n\tdkim-atps=neutral","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=cisco.com (client-ip=173.37.142.88;\n helo=alln-iport-1.cisco.com;\n envelope-from=danielwa@cisco.com; receiver=)","lists.ozlabs.org; dkim=pass (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=AHjsZv0R; dkim-atps=neutral"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4F95MF3kHqz9sXV\n\tfor ; Wed, 31 Mar 2021 10:32:09 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4F95MF2hWzz3bs7\n\tfor ; Wed, 31 Mar 2021 10:32:09 +1100 (AEDT)","from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4F95Lr1q4Bz2xxp\n for ; Wed, 31 Mar 2021 10:31:45 +1100 (AEDT)","from rcdn-core-5.cisco.com ([173.37.93.156])\n by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA;\n 30 Mar 2021 23:31:40 +0000","from zorba ([10.24.9.230])\n by rcdn-core-5.cisco.com (8.15.2/8.15.2) with ESMTPS id 12UNVcQt021992\n (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);\n Tue, 30 Mar 2021 23:31:39 GMT"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=cisco.com; i=@cisco.com; l=2587; q=dns/txt; s=iport;\n t=1617147108; x=1618356708;\n h=date:from:to:cc:subject:message-id:references:\n mime-version:in-reply-to;\n bh=20ZZL5t0OMdFzBeC8QVdex+kSd6hhKRqsatjmyKFFgA=;\n b=AHjsZv0ReDC94u2N9Ef+7zqWNKjnWTPyHHqBDoxcZNTg7EDmWsStYayr\n +XYMUV1wAWzO9BYvWj5ww0y7JIBnIdWvipawJfgZgAnvWtSnaWkAvtVbm\n QZpk/tSW+EOi1Cl1x2ZUoB1ZONXOqM3KsMFNFg+QMai49dnFsC7rOC38I I=;","X-IPAS-Result":"\n A0AUAABmtGNgmJxdJa1aGwEBAQEBAQEBBQEBARIBAQEDAwEBAUCBPgQBAQELAYN2ATkxlhEDkAgWikUUgWgLAQEBDQEBNAQBAYRQAoF6AiU2Bw4CAwEBAQMCAwEBAQEBBQEBAQIBBgQUAQEBAQEBAQGGQ4ZFAQU6PxALEgYVGTwNDgYTgnCDCKsVdYE0iQuBRBQOgRcBjUkmHIFJQoQuPoN5gQaDDIIJIgSBZVsGgRBagSpYFAItkH2CQIpMmw6BFIMRgSObNjEQgziKb5YbuBICBAYFAhaBWwongVszGggbFYMkUBkNjjiOTyEDLzgCBgoBAQMJjnkBAQ","IronPort-HdrOrdr":"A9a23:0OR3jKkQkEUngZc1jpNFK2fPV1rpDfN3imdD5ilNYBxZY6Wkvu\n ql9c516TbfjjENVHY83f2BIrCHW3PA9ZhziLNhWIuKdg/gpWeuMcVe/ZLvqgeQeRHW2+ZB2c\n 5bGZRWJ8b3CTFB4PrSwA79KNo4xcnCzabAv5a7815IbSVHL55t9B14DAHzKDwUeCBjCYAiHJ\n SRouprzgDARV0tYs62BmYIUoH4zrWhqLvcbRELHBIh4gWV5AnJ1JfBDxOa0h0COgkg/Z4e9w\n H+/zDR1+GKr+y8jiTRzXbU6I5b3OH808JZCNaX4/JlTQnEu0KPeJlrXaGEsXQTpuyigWxa6e\n XkklMHI9l57W/XcyWOhSbVnyPk0Doo9hbZuDmlvUc=","X-IronPort-Anti-Spam-Filtered":"true","X-IronPort-AV":"E=Sophos;i=\"5.81,291,1610409600\"; d=\"scan'208\";a=\"668463184\"","Date":"Tue, 30 Mar 2021 16:31:37 -0700","From":"Daniel Walker ","To":"Rob Herring ","Subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","Message-ID":"<20210330233137.GB2469518@zorba>","References":"<20210309000247.2989531-4-danielwa@cisco.com>\n <5f865584-09c9-d21f-ffb7-23cf07cf058e@csgroup.eu>\n <20210309212944.GR109100@zorba>\n \n \n <20fd7d44-8c39-48bc-25c3-990be9d9d911@csgroup.eu>\n <20210325195956.GM109100@zorba>\n \n <20210330173254.GS109100@zorba>\n ","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"\n ","X-Auto-Response-Suppress":"DR, OOF, AutoReply","X-Outbound-SMTP-Client":"10.24.9.230, [10.24.9.230]","X-Outbound-Node":"rcdn-core-5.cisco.com","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Daniel Gimpelevich ,\n linuxppc-dev , X86 ML ,\n \"open list:MIPS\" ,\n \"linux-kernel@vger.kernel.org\" ,\n Paul Mackerras , xe-linux-external@cisco.com,\n Andrew Morton , Will Deacon ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2659016,"web_url":"http://patchwork.ozlabs.org/comment/2659016/","msgid":"<20210331115218.GB7626@willie-the-truck>","date":"2021-03-31T11:52:19","subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","submitter":{"id":76918,"url":"http://patchwork.ozlabs.org/api/people/76918/","name":"Will Deacon","email":"will@kernel.org"},"content":"On Tue, Mar 30, 2021 at 10:35:21AM -0700, Daniel Walker wrote:\n> On Mon, Mar 29, 2021 at 11:07:51AM +0100, Will Deacon wrote:\n> > On Thu, Mar 25, 2021 at 12:59:56PM -0700, Daniel Walker wrote:\n> > > On Thu, Mar 25, 2021 at 01:03:55PM +0100, Christophe Leroy wrote:\n> > > > \n> > > > Ok, so you agree we don't need to provide two CMDLINE, one to be appended and one to be prepended.\n> > > > \n> > > > Let's only provide once CMDLINE as of today, and ask the user to select\n> > > > whether he wants it appended or prepended or replacee. Then no need to\n> > > > change all existing config to rename CONFIG_CMDLINE into either of the new\n> > > > ones.\n> > > > \n> > > > That's the main difference between my series and Daniel's series. So I'll\n> > > > finish taking Will's comment into account and we'll send out a v3 soon.\n> > > \n> > > It doesn't solve the needs of Cisco, I've stated many times your changes have\n> > > little value. Please stop submitting them.\n> > \n> > FWIW, they're useful for arm64 and I will gladly review the updated series.\n> > \n> > I don't think asking people to stop submitting patches is ever the right\n> > answer. Please don't do that.\n> \n> Why ? It's me nacking his series, is that not allowed anymore ?\n\nIf you're that way inclined then you can \"nack\" whatever you want, but\nplease allow the rest of us to continue reviewing the patches. You don't\nhave any basis on which to veto other people's contributions and so\ndemanding that somebody stops posting code is neither constructive nor\nmeaningful.\n\nWill","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=V81QxCaX;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=V81QxCaX;\n\tdkim-atps=neutral","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org;\n envelope-from=will@kernel.org; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=V81QxCaX;\n dkim-atps=neutral"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4F9Pnq1Zwxz9sPf\n\tfor ; Wed, 31 Mar 2021 22:52:47 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4F9Pnq0Z99z3bvd\n\tfor ; Wed, 31 Mar 2021 22:52:47 +1100 (AEDT)","from mail.kernel.org (mail.kernel.org [198.145.29.99])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4F9PnR3Lj8z301K\n for ; Wed, 31 Mar 2021 22:52:27 +1100 (AEDT)","by mail.kernel.org (Postfix) with ESMTPSA id AA0DA61983;\n Wed, 31 Mar 2021 11:52:22 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1617191545;\n bh=oYPoYBISW1U3nwgz67Ee8rLPsIXaiLi1AKK4azFtrDs=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=V81QxCaXo5BcqEzeHs7BvlqPDdaEyjYVePPvs3WuSN5I5bEH0xng7LgAfNS9RfWjH\n iQb661c3nrs6KSXN8KzZi+gsZXvqVwGfws61NxzyZ0PiolDJekDMKkN2Y5b63obGTD\n QfDIYE2lR9LIeqTaOSahYqZMycWBFJKGp9lA2IsXsHDpi/cB2soRcGp2zBuZeUMMca\n ltiOLrzkRGV5aQu6ZJFM9fIl1iUgXSLj+Nc93kBEkO4Dk9ZU9evLoNrLlMa2OLs+6x\n ORQGKSadN3jra5Itw8ipgu58ptTFpSTqDQHowhddnVIA9q60kt/sv2Gqa0WpqkXvWY\n FnRKu0K/+eWdg==","Date":"Wed, 31 Mar 2021 12:52:19 +0100","From":"Will Deacon ","To":"Daniel Walker ","Subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","Message-ID":"<20210331115218.GB7626@willie-the-truck>","References":"<20210309000247.2989531-4-danielwa@cisco.com>\n <5f865584-09c9-d21f-ffb7-23cf07cf058e@csgroup.eu>\n <20210309212944.GR109100@zorba>\n \n \n <20fd7d44-8c39-48bc-25c3-990be9d9d911@csgroup.eu>\n <20210325195956.GM109100@zorba>\n <20210329100750.GB3207@willie-the-truck>\n <20210330173521.GT109100@zorba>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210330173521.GT109100@zorba>","User-Agent":"Mutt/1.10.1 (2018-07-13)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Rob Herring ,\n Daniel Gimpelevich ,\n X86 ML , \"open list:MIPS\" ,\n \"linux-kernel@vger.kernel.org\" ,\n Paul Mackerras , xe-linux-external@cisco.com,\n Andrew Morton ,\n linuxppc-dev ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2659250,"web_url":"http://patchwork.ozlabs.org/comment/2659250/","msgid":"<20210331171408.GC2469518@zorba>","date":"2021-03-31T17:14:08","subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","submitter":{"id":67374,"url":"http://patchwork.ozlabs.org/api/people/67374/","name":"Daniel Walker (danielwa)","email":"danielwa@cisco.com"},"content":"On Wed, Mar 31, 2021 at 12:52:19PM +0100, Will Deacon wrote:\n> On Tue, Mar 30, 2021 at 10:35:21AM -0700, Daniel Walker wrote:\n> > On Mon, Mar 29, 2021 at 11:07:51AM +0100, Will Deacon wrote:\n> > > On Thu, Mar 25, 2021 at 12:59:56PM -0700, Daniel Walker wrote:\n> > > > On Thu, Mar 25, 2021 at 01:03:55PM +0100, Christophe Leroy wrote:\n> > > > > \n> > > > > Ok, so you agree we don't need to provide two CMDLINE, one to be appended and one to be prepended.\n> > > > > \n> > > > > Let's only provide once CMDLINE as of today, and ask the user to select\n> > > > > whether he wants it appended or prepended or replacee. Then no need to\n> > > > > change all existing config to rename CONFIG_CMDLINE into either of the new\n> > > > > ones.\n> > > > > \n> > > > > That's the main difference between my series and Daniel's series. So I'll\n> > > > > finish taking Will's comment into account and we'll send out a v3 soon.\n> > > > \n> > > > It doesn't solve the needs of Cisco, I've stated many times your changes have\n> > > > little value. Please stop submitting them.\n> > > \n> > > FWIW, they're useful for arm64 and I will gladly review the updated series.\n> > > \n> > > I don't think asking people to stop submitting patches is ever the right\n> > > answer. Please don't do that.\n> > \n> > Why ? It's me nacking his series, is that not allowed anymore ?\n> \n> If you're that way inclined then you can \"nack\" whatever you want, but\n> please allow the rest of us to continue reviewing the patches. You don't\n> have any basis on which to veto other people's contributions and so\n> demanding that somebody stops posting code is neither constructive nor\n> meaningful.\n\nI understand , but that's not what's happening. I've dealt with Christophe on\nthese changes repeatedly, and he's demonstrated he doesn't understand the feature set or\nthe motivation of the changes. I've tried to work with him in the past, but it\ndoesn't work unless he's giving me comments on my changes.\n\nHis changes don't solve Cisco problems, and likely never will regardless of\nfeedback. Maybe that could change, but I don't see that happening.\n\nDaniel","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=dixvG7wx;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=dixvG7wx;\n\tdkim-atps=neutral","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=cisco.com (client-ip=173.37.86.75; helo=rcdn-iport-4.cisco.com;\n envelope-from=danielwa@cisco.com; receiver=)","lists.ozlabs.org; dkim=pass (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=dixvG7wx; dkim-atps=neutral"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4F9XxC3Mjpz9sVq\n\tfor ; Thu, 1 Apr 2021 04:14:39 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4F9XxC27HPz3brl\n\tfor ; Thu, 1 Apr 2021 04:14:39 +1100 (AEDT)","from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4F9Xwp35dLz2yxN\n for ; Thu, 1 Apr 2021 04:14:15 +1100 (AEDT)","from rcdn-core-2.cisco.com ([173.37.93.153])\n by rcdn-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA;\n 31 Mar 2021 17:14:11 +0000","from zorba ([10.24.8.227])\n by rcdn-core-2.cisco.com (8.15.2/8.15.2) with ESMTPS id 12VHE8Ja029161\n (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);\n Wed, 31 Mar 2021 17:14:10 GMT"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=cisco.com; i=@cisco.com; l=2143; q=dns/txt; s=iport;\n t=1617210858; x=1618420458;\n h=date:from:to:cc:subject:message-id:references:\n mime-version:in-reply-to;\n bh=XBXiV/KZU9RAJFyY2sfCpxX3SMZ3qudvdd8J5wHAY+k=;\n b=dixvG7wxzaPyBmnFKJOZ7RrWY9iPHV89ozi/TQraf58Fujs9ciuCfOok\n thK1N3dMpQA8V/BBr+ujsEz4mc+aqMtWHdboooz0MpJwrrMBYLeudqLIK\n 6AoR3kKv2U9dhAa5c6yPoveAQq0HmcLM410BUdU9l+0TH7bursuk5zmNr k=;","IronPort-HdrOrdr":"\n A9a23:tSp+ZKM2+fmgyMBcT5r155DYdL4zR+YMi2QD/UoZc3NoW+afkN2jm+le+B/vkTAKWGwhn9foAtjkfVr385lp7Y4NeYqzRQWOghrLEKhO5ZbvqgeLJwTQ7ehYvJ0MT4FfD5nKAUF+nYLG5mCDYrId6f2m1IztuuvE1XdqSmhRGsJdxiN0EBySHEEzZCQuP/sEPaGR7MZGuDasEE5/Bq+GL0IIUOTZq9rAmIiOW347LiQ64wqDhy7A0tDHOiWfty1zbxp/hZ8/7G6AqADi/6Olqf3+8APEznTe9Y4+oqqH9vJzQOqRl8MSNjLgziGvaYgJYcz6gBkF5Mey9V0tjN7A5y0FAv02wXbQcmapyCGdvTXd7A==","X-IronPort-Anti-Spam-Filtered":"true","X-IronPort-Anti-Spam-Result":"\n A0DUAgB8rWRg/5ldJa1aGwEBAQEBAQEBBQEBARIBAQEDAwEBAUCBUIIrgUgEATmWRQOQCBaKWYFoCwEBAQ0BATQEAQGEUAKBewIlOBMCAwEBDAEBBQEBAQIBBgRxhW6GRQEFOj8QCxgVGTwbBoYMqnV1gTSJDoFEFA6BF41KJhyBSUKBEoMcPoN5gQaDDIIJIgSBZWEuYoIEOR8UL5EBgkCKUJwjgxGBI5s5MRCDOIpwliC4GwIEBgUCFoFrI4FZMxoIGxWDJU8ZDZ0IIQNnAgYKAQEDCY8JAQE","X-IronPort-AV":"E=Sophos;i=\"5.81,293,1610409600\"; d=\"scan'208\";a=\"855046290\"","Date":"Wed, 31 Mar 2021 10:14:08 -0700","From":"Daniel Walker ","To":"Will Deacon ","Subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","Message-ID":"<20210331171408.GC2469518@zorba>","References":"<20210309000247.2989531-4-danielwa@cisco.com>\n <5f865584-09c9-d21f-ffb7-23cf07cf058e@csgroup.eu>\n <20210309212944.GR109100@zorba>\n \n \n <20fd7d44-8c39-48bc-25c3-990be9d9d911@csgroup.eu>\n <20210325195956.GM109100@zorba>\n <20210329100750.GB3207@willie-the-truck>\n <20210330173521.GT109100@zorba>\n <20210331115218.GB7626@willie-the-truck>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210331115218.GB7626@willie-the-truck>","X-Auto-Response-Suppress":"DR, OOF, AutoReply","X-Outbound-SMTP-Client":"10.24.8.227, [10.24.8.227]","X-Outbound-Node":"rcdn-core-2.cisco.com","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Rob Herring ,\n Daniel Gimpelevich ,\n X86 ML , \"open list:MIPS\" ,\n \"linux-kernel@vger.kernel.org\" ,\n Paul Mackerras , xe-linux-external@cisco.com,\n Andrew Morton ,\n linuxppc-dev ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2660129,"web_url":"http://patchwork.ozlabs.org/comment/2660129/","msgid":"","date":"2021-04-01T20:08:04","subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Tue, Mar 30, 2021 at 6:31 PM Daniel Walker wrote:\n>\n> On Tue, Mar 30, 2021 at 03:13:04PM -0500, Rob Herring wrote:\n> > On Tue, Mar 30, 2021 at 12:33 PM Daniel Walker wrote:\n> > >\n> > > On Thu, Mar 25, 2021 at 05:29:44PM -0600, Rob Herring wrote:\n> > > > On Thu, Mar 25, 2021 at 2:00 PM Daniel Walker wrote:\n> > > > >\n> > > > > On Thu, Mar 25, 2021 at 01:03:55PM +0100, Christophe Leroy wrote:\n> > > > > >\n> > > > > > Ok, so you agree we don't need to provide two CMDLINE, one to be appended and one to be prepended.\n> > > > > >\n> > > > > > Let's only provide once CMDLINE as of today, and ask the user to select\n> > > > > > whether he wants it appended or prepended or replacee. Then no need to\n> > > > > > change all existing config to rename CONFIG_CMDLINE into either of the new\n> > > > > > ones.\n> > > > > >\n> > > > > > That's the main difference between my series and Daniel's series. So I'll\n> > > > > > finish taking Will's comment into account and we'll send out a v3 soon.\n> > > > >\n> > > > > It doesn't solve the needs of Cisco, I've stated many times your changes have\n> > > > > little value. Please stop submitting them.\n> > > >\n> > > > Can you please outline what those needs are which aren't met?\n> > >\n> > > append AND prepend at the same time on all architectures. Christophe doesn't\n> > > understand the need, and hence tries to minimize the feature set which is\n> > > incompatible with Cisco needs and all the other out of tree users.\n> >\n> > Okay, but that's never been a feature in upstream. For upstream, we\n> > refactor first and add features 2nd. In this case, the difference is\n> > largely the kconfig and it would be better to not change the options\n> > twice, but that's not a blocker for taking the refactoring. You won't\n> > find a maintainer that's going to take adding a feature over cleanups\n> > and unification.\n>\n> It kind of is a feature in upstream, it's a matter of opinion. Some platform\n> used append and some use prepend, and it's likely because the maintainers needed\n> one or the other for development.\n\nWhich arch/platform upstream does both prepend and append at the same time?\n\n> I'm not sure why you think I can't add the features in one go. It would be\n> horrid to take Christophe's changes, then have to do basically all the same work\n> a second time which is what Christophe's changes would force me to do.\n\nI didn't say it couldn't be done. In fact, I said it would be better\nall at once: \"it would be better to not change the options twice\"\n\nBut both of you ignoring comments and continuing to post competing\nseries is not going to get us there. TBC, I think Christophe's series\nis much closer to being in shape to merge upstream.\n\n> Say for example I implement this change only on one architecture. In that case\n> the maintainer would be accepting a feature enhancement , but there would be no\n> stopping it. I shouldn't have to go two strokes on one architecture, but each\n> change I'm making is essentially a single architecture. They can go in all\n> together or one at a time.\n\nFeatures do get implemented all the time on one arch. And then maybe a\n2nd and 3rd. At some point we decide no more copying, it needs to be\ncommon and refactored. We're at that point for cmdline handling IMO.\n\nRob","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ZkxjcrpV;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ZkxjcrpV;\n\tdkim-atps=neutral","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org;\n envelope-from=robh@kernel.org; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ZkxjcrpV;\n dkim-atps=neutral"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4FBDmk3WVHz9sV5\n\tfor ; Fri, 2 Apr 2021 07:09:42 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4FBDm82FqPz3bxy\n\tfor ; Fri, 2 Apr 2021 07:09:12 +1100 (AEDT)","from mail.kernel.org (mail.kernel.org [198.145.29.99])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4FBDlk3dk3z3bsW\n for ; Fri, 2 Apr 2021 07:08:50 +1100 (AEDT)","by mail.kernel.org (Postfix) with ESMTPSA id 41595610D0\n for ; Thu, 1 Apr 2021 20:08:17 +0000 (UTC)","by mail-ej1-f43.google.com with SMTP id hq27so4617790ejc.9\n for ; Thu, 01 Apr 2021 13:08:17 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1617307697;\n bh=leXRGFCaTe62iNXS9w44O42W8yxC/IB8Rcab5IVMEdo=;\n h=References:In-Reply-To:From:Date:Subject:To:Cc:From;\n b=ZkxjcrpVIoR0UEZPAPwcCGRNCr9cnaA8ap9gvRp4jG0hf1ImuQrB2wy7jdHBNp4J8\n +B6DTRenJaqRuVw182uynS3O32+RWy36NHQ4NVmOs0uERUsoS0z0YIuCVKtIezpQaf\n ar8zPs7y24q5Srof2D/yE6kT+20NEcXp6C2mI5SQ7X6r3aN/FP+ATmxolsyxP5MpYT\n 7NCJo48UM5HYxI/NGZmIbO5BI7lz6QHAEg6D/9PyVuj/nEJF3OsBF99i626YiF29DE\n grEk3QDd2ku4LB6wDx6iQIOep2wLfsf2NpExyi99i3NsqyYF/Nc2kd3WGauqNfXcpi\n sqcEd4bpv2hVA==","X-Gm-Message-State":"AOAM532qgKoEuikpKvL7oyn9DAHEdlTxWKhDONOg0PxT0R/p5Nu2iiVz\n JkiSzNYMJk5VXLkz6bP14CyRc7NnyZ+FaB/D7A==","X-Google-Smtp-Source":"\n ABdhPJwo4ozd5r/I3vDcht4+RN+4+j5bUHW3XwFV21OlpcnhU71wdknH6GNYfELodycCl347pJJo+2xFYHlBdNJZ9TM=","X-Received":"by 2002:a17:906:5e01:: with SMTP id\n n1mr10940420eju.359.1617307695709;\n Thu, 01 Apr 2021 13:08:15 -0700 (PDT)","MIME-Version":"1.0","References":"<20210309000247.2989531-4-danielwa@cisco.com>\n <5f865584-09c9-d21f-ffb7-23cf07cf058e@csgroup.eu>\n <20210309212944.GR109100@zorba>\n \n \n <20fd7d44-8c39-48bc-25c3-990be9d9d911@csgroup.eu>\n <20210325195956.GM109100@zorba>\n \n <20210330173254.GS109100@zorba>\n \n <20210330233137.GB2469518@zorba>","In-Reply-To":"<20210330233137.GB2469518@zorba>","From":"Rob Herring ","Date":"Thu, 1 Apr 2021 15:08:04 -0500","X-Gmail-Original-Message-ID":"\n ","Message-ID":"\n ","Subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","To":"Daniel Walker ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Daniel Gimpelevich ,\n linuxppc-dev , X86 ML ,\n \"open list:MIPS\" ,\n \"linux-kernel@vger.kernel.org\" ,\n Paul Mackerras , xe-linux-external@cisco.com,\n Andrew Morton , Will Deacon ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}},{"id":2661824,"web_url":"http://patchwork.ozlabs.org/comment/2661824/","msgid":"<20210406162942.GR2469518@zorba>","date":"2021-04-06T16:29:42","subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","submitter":{"id":67374,"url":"http://patchwork.ozlabs.org/api/people/67374/","name":"Daniel Walker (danielwa)","email":"danielwa@cisco.com"},"content":"On Thu, Apr 01, 2021 at 03:08:04PM -0500, Rob Herring wrote:\n> On Tue, Mar 30, 2021 at 6:31 PM Daniel Walker wrote:\n> >\n> > On Tue, Mar 30, 2021 at 03:13:04PM -0500, Rob Herring wrote:\n> > > On Tue, Mar 30, 2021 at 12:33 PM Daniel Walker wrote:\n> > > >\n> > > > On Thu, Mar 25, 2021 at 05:29:44PM -0600, Rob Herring wrote:\n> > > > > On Thu, Mar 25, 2021 at 2:00 PM Daniel Walker wrote:\n> > > > > >\n> > > > > > On Thu, Mar 25, 2021 at 01:03:55PM +0100, Christophe Leroy wrote:\n> > > > > > >\n> > > > > > > Ok, so you agree we don't need to provide two CMDLINE, one to be appended and one to be prepended.\n> > > > > > >\n> > > > > > > Let's only provide once CMDLINE as of today, and ask the user to select\n> > > > > > > whether he wants it appended or prepended or replacee. Then no need to\n> > > > > > > change all existing config to rename CONFIG_CMDLINE into either of the new\n> > > > > > > ones.\n> > > > > > >\n> > > > > > > That's the main difference between my series and Daniel's series. So I'll\n> > > > > > > finish taking Will's comment into account and we'll send out a v3 soon.\n> > > > > >\n> > > > > > It doesn't solve the needs of Cisco, I've stated many times your changes have\n> > > > > > little value. Please stop submitting them.\n> > > > >\n> > > > > Can you please outline what those needs are which aren't met?\n> > > >\n> > > > append AND prepend at the same time on all architectures. Christophe doesn't\n> > > > understand the need, and hence tries to minimize the feature set which is\n> > > > incompatible with Cisco needs and all the other out of tree users.\n> > >\n> > > Okay, but that's never been a feature in upstream. For upstream, we\n> > > refactor first and add features 2nd. In this case, the difference is\n> > > largely the kconfig and it would be better to not change the options\n> > > twice, but that's not a blocker for taking the refactoring. You won't\n> > > find a maintainer that's going to take adding a feature over cleanups\n> > > and unification.\n> >\n> > It kind of is a feature in upstream, it's a matter of opinion. Some platform\n> > used append and some use prepend, and it's likely because the maintainers needed\n> > one or the other for development.\n> \n> Which arch/platform upstream does both prepend and append at the same time?\n \nNone do it at the same time, however x86 and mips have switched between the two. \n\n> > I'm not sure why you think I can't add the features in one go. It would be\n> > horrid to take Christophe's changes, then have to do basically all the same work\n> > a second time which is what Christophe's changes would force me to do.\n> \n> I didn't say it couldn't be done. In fact, I said it would be better\n> all at once: \"it would be better to not change the options twice\"\n> \n> But both of you ignoring comments and continuing to post competing\n> series is not going to get us there. TBC, I think Christophe's series\n> is much closer to being in shape to merge upstream.\n \nI'm not the one ignoring comments .. I've taken a number of comments from\nChristophe, but he still submits his own series..\n\nChristophe series doesn't look good to me.. I suspect you like it cause it\ndeletes lines from of.\n\n> > Say for example I implement this change only on one architecture. In that case\n> > the maintainer would be accepting a feature enhancement , but there would be no\n> > stopping it. I shouldn't have to go two strokes on one architecture, but each\n> > change I'm making is essentially a single architecture. They can go in all\n> > together or one at a time.\n> \n> Features do get implemented all the time on one arch. And then maybe a\n> 2nd and 3rd. At some point we decide no more copying, it needs to be\n> common and refactored. We're at that point for cmdline handling IMO.\n\nI don't think it can be done with one series all at once ..\n\nDaniel","headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=APaR1zGP;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=APaR1zGP;\n\tdkim-atps=neutral","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=cisco.com (client-ip=173.37.86.78; helo=rcdn-iport-7.cisco.com;\n envelope-from=danielwa@cisco.com; receiver=)","lists.ozlabs.org; dkim=pass (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=APaR1zGP; dkim-atps=neutral"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4FFCgT5d83z9sRf\n\tfor ; Wed, 7 Apr 2021 02:30:29 +1000 (AEST)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4FFCgT4rFLz304L\n\tfor ; Wed, 7 Apr 2021 02:30:29 +1000 (AEST)","from rcdn-iport-7.cisco.com (rcdn-iport-7.cisco.com [173.37.86.78])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4FFCfw4Mqwz2y8B\n for ; Wed, 7 Apr 2021 02:29:57 +1000 (AEST)","from alln-core-11.cisco.com ([173.36.13.133])\n by rcdn-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA;\n 06 Apr 2021 16:29:52 +0000","from zorba ([10.24.14.212])\n by alln-core-11.cisco.com (8.15.2/8.15.2) with ESMTPS id 136GTgP5005585\n (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);\n Tue, 6 Apr 2021 16:29:44 GMT"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=cisco.com; i=@cisco.com; l=3941; q=dns/txt; s=iport;\n t=1617726601; x=1618936201;\n h=date:from:to:cc:subject:message-id:references:\n mime-version:in-reply-to;\n bh=wtAeIc7XsQsptor4RXWPj9Y8j7ZxS+JmY38g2U87X54=;\n b=APaR1zGPRda0qhyteg1WNYis3QLMMfNL3uFoE64HFBjMM9n4cp13nIIq\n 8Mu8GUhAuHA7zktJQ/uMcAG+DcX6jzi45nT5mC4xwhbW0eqt0ec0vv6KT\n 2SGSyTCCGpyzSYxdasPMhgxwlYttem3tnob039vR4EXBW8cfD+ul62t/j 0=;","IronPort-HdrOrdr":"\n A9a23:8kZ/JKy/HEtUs8XFn+v/KrPxd+skLtp033Aq2lEZdDV+eKWj+PyGtvIdyBPylXI9WGs4n8qBJamHRhrnhPtIyKMWOqqvWxSjhXuwIOhZnOnf6hDpBiGWzIRg/Ih6dawWMrDNJHh8yf33+QypV+snqeP3lJyAocf74zNTQRpxa6dmhj0JaTqzNkFtXgFJCd4YOfOnh/ZvnDardXQJYsnTPBBsNNTrnNHFmInrZhQLHXcciDWmty+i67LxDnGjsCs2bjUn+9sf2FmAuxDl4OGZv+ujzBjH2yvo841Og9f60LJ4dauxo/lQDCnwgQC1Y4kkfLuOsFkO0ZiSwWdvtsXQqBE9OMk20VftRyWepBvg3BSI6kdJ10Pf","X-IronPort-Anti-Spam-Filtered":"true","X-IronPort-Anti-Spam-Result":"\n A0AHAAD2i2xg/4UNJK1aGQEBAQEBAQEBAQEBAQEBAQEBARIBAQEBAQEBAQEBAQFAgT4EAQEBAQELAYIqgU0BOTGMZokvA5AMFopGFIFoCwEBAQ0BATQEAQGEUAKBdgIlNAkOAgMBAQwBAQUBAQECAQYEcROFXYZEAQEBAwE6PxALEgYVGTwNDgYThVghq011gTSBAYgdgUQUDoEXAY1MJxyBSUKENT6DeYEGhRYiBIFlWwaBEBs/Vi8lWBQCLZEGgkGKW5sVgRSDFYEmm0cyEIM9iniWLLg+AgQGBQIWgVQ6gVkzGggbFYMkUBkOjisWjkchAy84AgYKAQEDCY1EAQE","X-IronPort-AV":"E=Sophos;i=\"5.82,310,1613433600\"; d=\"scan'208\";a=\"867307959\"","Date":"Tue, 6 Apr 2021 09:29:42 -0700","From":"Daniel Walker ","To":"Rob Herring ","Subject":"Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline","Message-ID":"<20210406162942.GR2469518@zorba>","References":"<20210309212944.GR109100@zorba>\n \n \n <20fd7d44-8c39-48bc-25c3-990be9d9d911@csgroup.eu>\n <20210325195956.GM109100@zorba>\n \n <20210330173254.GS109100@zorba>\n \n <20210330233137.GB2469518@zorba>\n ","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"\n ","X-Auto-Response-Suppress":"DR, OOF, AutoReply","X-Outbound-SMTP-Client":"10.24.14.212, [10.24.14.212]","X-Outbound-Node":"alln-core-11.cisco.com","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Daniel Gimpelevich ,\n linuxppc-dev , X86 ML ,\n \"open list:MIPS\" ,\n \"linux-kernel@vger.kernel.org\" ,\n Paul Mackerras , xe-linux-external@cisco.com,\n Andrew Morton , Will Deacon ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "}}]