[{"id":2644770,"web_url":"http://patchwork.ozlabs.org/comment/2644770/","msgid":"<11f66e7f-a02a-42d3-5da9-085cc9e846c5@redhat.com>","list_archive_url":null,"date":"2021-03-09T16:51:19","subject":"Re: [PULL v2 03/19] roms/opensbi: Upgrade from v0.8 to v0.9","submitter":{"id":74995,"url":"http://patchwork.ozlabs.org/api/people/74995/","name":"Philippe Mathieu-Daudé","email":"philmd@redhat.com"},"content":"Hi Alistair,\n\nOn 3/4/21 3:46 PM, Alistair Francis wrote:\n> From: Bin Meng \n> \n> Upgrade OpenSBI from v0.8 to v0.9 and the pre-built bios images.\n\n> Signed-off-by: Bin Meng \n> Reviewed-by: Alistair Francis \n> Message-Id: 20210119234438.10132-1-bmeng.cn@gmail.com\n> Signed-off-by: Alistair Francis \n> ---\n> .../opensbi-riscv32-generic-fw_dynamic.bin | Bin 62144 -> 78680 bytes\n> .../opensbi-riscv32-generic-fw_dynamic.elf | Bin 558668 -> 727464 bytes\n> .../opensbi-riscv64-generic-fw_dynamic.bin | Bin 70792 -> 75096 bytes\n> .../opensbi-riscv64-generic-fw_dynamic.elf | Bin 620424 -> 781264 bytes\n> roms/opensbi | 2 +-\n> 5 files changed, 1 insertion(+), 1 deletion(-)\n\nFor pull-request you can use git-format-patch with --no-binary:\n\n --no-binary\n Do not output contents of changes in binary files,\n instead display a notice that those files changed.\n Patches generated using this option cannot be applied\n properly, but they are still useful for code review.\n\nI did the same mistake last year and this broke QEMU patchwork\ninstance. No sure it is still in use, so Cc'ing Stefan.\n\n> diff --git a/roms/opensbi b/roms/opensbi\n> index a98258d0b5..234ed8e427 160000\n> --- a/roms/opensbi\n> +++ b/roms/opensbi\n> @@ -1 +1 @@\n> -Subproject commit a98258d0b537a295f517bbc8d813007336731fa9\n> +Subproject commit 234ed8e427f4d92903123199f6590d144e0d9351\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=WVlNJf56;\n\tdkim-atps=neutral","relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4Dw46F70gJz9sRR\n\tfor ; Wed, 10 Mar 2021 05:50:45 +1100 (AEDT)","from localhost ([::1]:50698 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1lJhRK-0003lp-Ma\n\tfor incoming@patchwork.ozlabs.org; Tue, 09 Mar 2021 13:50:42 -0500","from eggs.gnu.org ([2001:470:142:3::10]:54872)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1lJfa1-0000CX-BN\n for qemu-devel@nongnu.org; Tue, 09 Mar 2021 11:51:33 -0500","from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:60362)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)\n (Exim 4.90_1) (envelope-from ) id 1lJfZz-0007Na-DE\n for qemu-devel@nongnu.org; Tue, 09 Mar 2021 11:51:33 -0500","from mail-ej1-f71.google.com (mail-ej1-f71.google.com\n [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-258-yuzw_lcGNdaPdo8PtN4lsw-1; Tue, 09 Mar 2021 11:51:28 -0500","by mail-ej1-f71.google.com with SMTP id gv58so5888292ejc.6\n for ; Tue, 09 Mar 2021 08:51:27 -0800 (PST)","from [192.168.1.36] (68.red-83-57-175.dynamicip.rima-tde.net.\n [83.57.175.68])\n by smtp.gmail.com with ESMTPSA id k9sm7195591edn.68.2021.03.09.08.51.25\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 09 Mar 2021 08:51:26 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1615308690;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=/0+ApRdvUstN2dmsPikElv94suiYNpEV6mKUaoBwApg=;\n b=WVlNJf56vXp4Cew3DbRI8lCOQL1VzAraMoUP76KYKThIDvhhuBF0ZT6UT552Bqa5NfH8hr\n IJAyAT5pEVSBV/Lz4lckWB8vIsMOjD5orE6RzRwXNNuYT2B/FUutgUJhYFhRgl3HnlQnBU\n bJURFr//WYloOBvahomy4ZqfvTpzT5w=","X-MC-Unique":"yuzw_lcGNdaPdo8PtN4lsw-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:subject:to:cc:references:from:message-id:date\n :user-agent:mime-version:in-reply-to:content-language\n :content-transfer-encoding;\n bh=/0+ApRdvUstN2dmsPikElv94suiYNpEV6mKUaoBwApg=;\n b=KoTGH+OIi164+FoomHGc5izEyFXuC+inKKrhAR3N1NN84nPojmvr0bl/lc5OzBW/Ql\n R6ttS09SRfM4Yfk5U1ShibQ97BSkz/uTj8MLLkWy9nAL5gXO+thupL4RGdZQUAj3T7Sx\n Y/+NUBlUcBs8MHIPEpbVCJAptarjdxBNXGxW6YRcqTSPltFfD0Qh4Wl4BXsLVk2AB7/a\n mhFwclLTMtLKgvqv1ANpRCzQw8m9lPpwcjlYCIzYFF6ZZXyhYMWADDH2ILFJBH29pnDp\n TOH9EqMFlOUAjBtSR995tIoNiprxkLo+bP8sQVO7suMm69mHWqRCd6uAspcL0b8gqCmv\n eG/w==","X-Gm-Message-State":"AOAM5331yumm6S3LuRhV/I9myqTMkzVnywR06oJ5NeavMp4g1pzRNMm8\n +Q1hDSGXM75EfZzlDQut5s9YX99EEp/AF2LMLOKB61WMKJH0MXVPS1vkXuvRjcXelPMUpNq/2S4\n j0sqCYnmsRFRXr+A=","X-Received":["by 2002:a17:906:3c18:: with SMTP id\n h24mr21094591ejg.435.1615308686950;\n Tue, 09 Mar 2021 08:51:26 -0800 (PST)","by 2002:a17:906:3c18:: with SMTP id\n h24mr21094564ejg.435.1615308686797;\n Tue, 09 Mar 2021 08:51:26 -0800 (PST)"],"X-Google-Smtp-Source":"\n ABdhPJzxOBm+Z6V9ueU4CDnPBUhhSuOPi14NKS0ArNcMRr6RgttVz+xPvdRSbzogsBKcIuqxaOUHqg==","Subject":"Re: [PULL v2 03/19] roms/opensbi: Upgrade from v0.8 to v0.9","To":"Alistair Francis , peter.maydell@linaro.org","References":"<20210304144651.310037-1-alistair.francis@wdc.com>\n <20210304144651.310037-4-alistair.francis@wdc.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"<11f66e7f-a02a-42d3-5da9-085cc9e846c5@redhat.com>","Date":"Tue, 9 Mar 2021 17:51:19 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n Thunderbird/78.7.0","MIME-Version":"1.0","In-Reply-To":"<20210304144651.310037-4-alistair.francis@wdc.com>","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-29","X-Spam_score":"-3.0","X-Spam_bar":"---","X-Spam_report":"(-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001,\n RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"alistair23@gmail.com, Bin Meng ,\n qemu-devel@nongnu.org, Stefan Hajnoczi ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "}},{"id":2646364,"web_url":"http://patchwork.ozlabs.org/comment/2646364/","msgid":"","list_archive_url":null,"date":"2021-03-11T15:48:44","subject":"Re: [PULL v2 03/19] roms/opensbi: Upgrade from v0.8 to v0.9","submitter":{"id":64571,"url":"http://patchwork.ozlabs.org/api/people/64571/","name":"Alistair Francis","email":"alistair23@gmail.com"},"content":"On Tue, Mar 9, 2021 at 11:51 AM Philippe Mathieu-Daudé\n wrote:\n>\n> Hi Alistair,\n>\n> On 3/4/21 3:46 PM, Alistair Francis wrote:\n> > From: Bin Meng \n> >\n> > Upgrade OpenSBI from v0.8 to v0.9 and the pre-built bios images.\n>\n> > Signed-off-by: Bin Meng \n> > Reviewed-by: Alistair Francis \n> > Message-Id: 20210119234438.10132-1-bmeng.cn@gmail.com\n> > Signed-off-by: Alistair Francis \n> > ---\n> > .../opensbi-riscv32-generic-fw_dynamic.bin | Bin 62144 -> 78680 bytes\n> > .../opensbi-riscv32-generic-fw_dynamic.elf | Bin 558668 -> 727464 bytes\n> > .../opensbi-riscv64-generic-fw_dynamic.bin | Bin 70792 -> 75096 bytes\n> > .../opensbi-riscv64-generic-fw_dynamic.elf | Bin 620424 -> 781264 bytes\n> > roms/opensbi | 2 +-\n> > 5 files changed, 1 insertion(+), 1 deletion(-)\n>\n> For pull-request you can use git-format-patch with --no-binary:\n>\n> --no-binary\n> Do not output contents of changes in binary files,\n> instead display a notice that those files changed.\n> Patches generated using this option cannot be applied\n> properly, but they are still useful for code review.\n\nThanks, I have updated my script (which is really Peter's script) to add that.\n\nAlistair\n\n>\n> I did the same mistake last year and this broke QEMU patchwork\n> instance. No sure it is still in use, so Cc'ing Stefan.\n>\n> > diff --git a/roms/opensbi b/roms/opensbi\n> > index a98258d0b5..234ed8e427 160000\n> > --- a/roms/opensbi\n> > +++ b/roms/opensbi\n> > @@ -1 +1 @@\n> > -Subproject commit a98258d0b537a295f517bbc8d813007336731fa9\n> > +Subproject commit 234ed8e427f4d92903123199f6590d144e0d9351\n> >\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20161025 header.b=HdTUmToQ;\n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4DxDDC4yRvz9sR4\n\tfor ; Fri, 12 Mar 2021 02:59:55 +1100 (AEDT)","from localhost ([::1]:40914 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1lKNj7-0006Og-M7\n\tfor incoming@patchwork.ozlabs.org; Thu, 11 Mar 2021 10:59:53 -0500","from eggs.gnu.org ([2001:470:142:3::10]:59318)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1lKNZk-00011q-JZ\n for qemu-devel@nongnu.org; Thu, 11 Mar 2021 10:50:13 -0500","from mail-io1-xd36.google.com ([2607:f8b0:4864:20::d36]:36415)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1lKNZg-0004QI-OC\n for qemu-devel@nongnu.org; Thu, 11 Mar 2021 10:50:09 -0500","by mail-io1-xd36.google.com with SMTP id n14so22428753iog.3\n for ; Thu, 11 Mar 2021 07:50:06 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=mime-version:references:in-reply-to:from:date:message-id:subject:to\n :cc:content-transfer-encoding;\n bh=bDutI6XlEP3cg3qSipkFBGtAW8knzvxoCM0psYNYfMU=;\n b=HdTUmToQ6XlKtxkq22henrRa4r0rbMQBFg1hQv635PNSZy8J81XysllITSLoel59xC\n K07VSyxWCMbTWDUFEHQ7XkYnwQ4xl2IijYooUt6/Qg8pz3yZVd4EzcFAhxq03+NnEgw+\n OLMIdatMObnHPDfwMaqjLLTxb5VY9RuGviNF+wvfVlAfayxPUhWvrZFJWtyY+tsxv6o3\n B48l50mEscWoYEsrbjXUOq6VlpgNKjI5t/V4BjSHPEzAOEuJvUt/rlfBM5xhQnhePrWC\n qD7XceJnMchSGLTbh/rNI/gvqYwtutZPeZqmwPzwfBSg+lkHU2r7Ei8uklu2OYmvkpCU\n w9Ww==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:mime-version:references:in-reply-to:from:date\n :message-id:subject:to:cc:content-transfer-encoding;\n bh=bDutI6XlEP3cg3qSipkFBGtAW8knzvxoCM0psYNYfMU=;\n b=AF9oPfzSPcxbtfFregIM2jVZpDi8NJqZpruS1wLLOG9eCbSXRyotK6bp06qlkaK1YU\n dhXwH7ycDH3DO8lJHpgIIpEafNL3rPizFtchlr+haeJ5kAo39DpabDB+VKL0Tg9iypq4\n AskPKNX9twEPwNn+MZduSq+ivZ6+jHWosCYGBmsHFlH93gZ+soAtHE7Gdsczxua9qxg9\n AVBXM0c/3g2re7bk5paiY2s0VBlhX7WRNvrTSWyT2eTHIjrRYBMP07ZVljLV8cAhLqdv\n 7vaIC2oK2bb0kglBTY1cJ9xjnmYFHXIoE+V21gT9njdGrIz/WFep6nnJOc9JhEEOM9dV\n kjEw==","X-Gm-Message-State":"AOAM532sZDq3H80AVEAFmgcLJh1kr30xJQz1AdkQCPbt68eC7vikoHyV\n pn6T0VMElIfD14WBLWWGTD4Md3h/ZjySMIiac1E=","X-Google-Smtp-Source":"\n ABdhPJz6SOBVDFGulKlpMYcNAHDOYAZUaVigrCb3pXf0uOxG+3lBBpSZRQQwMAPTcKuZIMk5dMS3lbmI3z/toZTFuK4=","X-Received":"by 2002:a02:11c9:: with SMTP id 192mr4251079jaf.135.1615477806254;\n Thu, 11 Mar 2021 07:50:06 -0800 (PST)","MIME-Version":"1.0","References":"<20210304144651.310037-1-alistair.francis@wdc.com>\n <20210304144651.310037-4-alistair.francis@wdc.com>\n <11f66e7f-a02a-42d3-5da9-085cc9e846c5@redhat.com>","In-Reply-To":"<11f66e7f-a02a-42d3-5da9-085cc9e846c5@redhat.com>","From":"Alistair Francis ","Date":"Thu, 11 Mar 2021 10:48:44 -0500","Message-ID":"\n ","Subject":"Re: [PULL v2 03/19] roms/opensbi: Upgrade from v0.8 to v0.9","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=2607:f8b0:4864:20::d36;\n envelope-from=alistair23@gmail.com; helo=mail-io1-xd36.google.com","X-Spam_score_int":"-7","X-Spam_score":"-0.8","X-Spam_bar":"/","X-Spam_report":"(-0.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Peter Maydell ,\n Bin Meng ,\n Alistair Francis ,\n \"qemu-devel@nongnu.org Developers\" ,\n Stefan Hajnoczi ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "}}]