[{"id":2591047,"web_url":"http://patchwork.ozlabs.org/comment/2591047/","msgid":"","list_archive_url":null,"date":"2020-12-02T15:51:49","subject":"Re: [PATCH v2 3/4] contrib/vhost-user-input: avoid g_return_val_if()\n input validation","submitter":{"id":6442,"url":"http://patchwork.ozlabs.org/api/people/6442/","name":"Marc-André Lureau","email":"marcandre.lureau@gmail.com"},"content":"On Wed, Dec 2, 2020 at 7:27 PM Stefan Hajnoczi wrote:\n\n> Do not validate input with g_return_val_if(). This API is intended for\n> checking programming errors and is compiled out with -DG_DISABLE_CHECKS.\n>\n> Use an explicit if statement for input validation so it cannot\n> accidentally be compiled out.\n>\n> Suggested-by: Markus Armbruster \n> Signed-off-by: Stefan Hajnoczi \n> ---\n> contrib/vhost-user-input/main.c | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n>\n> diff --git a/contrib/vhost-user-input/main.c\n> b/contrib/vhost-user-input/main.c\n> index 6020c6f33a..1d79c61200 100644\n> --- a/contrib/vhost-user-input/main.c\n> +++ b/contrib/vhost-user-input/main.c\n> @@ -212,7 +212,11 @@ static int vi_get_config(VuDev *dev, uint8_t *config,\n> uint32_t len)\n> {\n> VuInput *vi = container_of(dev, VuInput, dev.parent);\n>\n> - g_return_val_if_fail(len <= sizeof(*vi->sel_config), -1);\n> + if (len > sizeof(*vi->sel_config)) {\n> + g_critical(\"%s: len %u is larger than %zu\",\n> + __func__, len, sizeof(*vi->sel_config));\n> + return -1;\n>\n\ng_critical() already has __FILE__ __LINE__ and G_STRFUNC.\n\notherwise looks good:\nReviewed-by: Marc-André Lureau \n\n\n\n> + }\n>\n> if (vi->sel_config) {\n> memcpy(config, vi->sel_config, len);\n> --\n> 2.28.0\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=gmail.com","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20161025 header.b=FNbzuly/;\n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4CmNmX5Lzjz9sSf\n\tfor ; Thu, 3 Dec 2020 02:53:32 +1100 (AEDT)","from localhost ([::1]:46448 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1kkURe-00028b-PT\n\tfor incoming@patchwork.ozlabs.org; Wed, 02 Dec 2020 10:53:30 -0500","from eggs.gnu.org ([2001:470:142:3::10]:57962)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1kkUQG-00015M-Az; Wed, 02 Dec 2020 10:52:04 -0500","from mail-ej1-x643.google.com ([2a00:1450:4864:20::643]:38287)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1kkUQE-0007Tt-MP; Wed, 02 Dec 2020 10:52:04 -0500","by mail-ej1-x643.google.com with SMTP id a16so5081366ejj.5;\n Wed, 02 Dec 2020 07:52:01 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=mime-version:references:in-reply-to:from:date:message-id:subject:to\n :cc; bh=AbuIUg60f59Y70VOAgLclTFbtP0jHqU3DUyNKMiw50M=;\n b=FNbzuly/Sk1d5PAq0oCUBQQGJwZ+sF2Pha+v/a8e/TMF5DbTDinaCkPLMy+NIhb1GD\n i8L/LMnjcIlUjgIfGa5Y/Kf3UEvYaXR/9cSmL69DstksqAMjR6VB59OHHXHvIW/nJf2h\n E1EjR6487dCEezv9cfuwDYvLerJ2jM3l3ieENwL4HxdBnLUkHE1rvGiaA+zsXP+dO8MW\n OhDC4hIY6ft1klvGj2ZU4C1tbvMeVKqKHx8D5NMFNHrDNqSJ8IPVx68RaZhgyK8zKxiU\n 9H8i/PPPBuNS8HZenAmsWTs+sfVIjUQv3Qa6q7jM4m4RbLQR7t+/Yat4PRkUjEHjOXR1\n 4CTg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:mime-version:references:in-reply-to:from:date\n :message-id:subject:to:cc;\n bh=AbuIUg60f59Y70VOAgLclTFbtP0jHqU3DUyNKMiw50M=;\n b=kRH3v5gh4WNiGxjNfV6IHhCExmQYutjXmiVOI37Pd824joU6Ix+yI8n0fRo9Mi+NVa\n lBE48NJQU/p8A2d5JEzX4vmPKYFrffeBYjaornPpK8klg/l8bCzHbLIBHnr+lx7hgGJg\n ixQ8QdlOatKOhw4eEnlUK/VZsctCDKtSmthah29ql+0ZsgdKvbwGfMP1FYEMHP+1/Cpq\n HryrunOq+ezp9NRllKNsEZLWRV4lOywOXwBvB0sw7f/dGgZ6H/7sPWi6a5QUgInnQN11\n n0Wr++pE9OWF/qc637auEjcBO3yapRNdHeFkS8GNwww6dzHlOsFqHe/kS67Jq+qagFvQ\n DbKQ==","X-Gm-Message-State":"AOAM530l4wAEgpjTqTkPfDJh295FNU0TZ+MfTab2BAxs87yxZHo7MijT\n Ym3kJoJGXXp7CjbiPYYIlnUzNwv9kykiNQlPi88=","X-Google-Smtp-Source":"\n ABdhPJw3YkmDp74Nu/pdwR62wnTbPB5/0QUmTywhU0dFHsao7FnmqiPIs1VQPBpGA0LaQNrwaLV6wrU63q0SoZwmdlY=","X-Received":"by 2002:a17:906:aacd:: with SMTP id\n kt13mr334599ejb.527.1606924320967;\n Wed, 02 Dec 2020 07:52:00 -0800 (PST)","MIME-Version":"1.0","References":"<20201202152611.677753-1-stefanha@redhat.com>\n <20201202152611.677753-4-stefanha@redhat.com>","In-Reply-To":"<20201202152611.677753-4-stefanha@redhat.com>","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Wed, 2 Dec 2020 19:51:49 +0400","Message-ID":"\n ","Subject":"Re: [PATCH v2 3/4] contrib/vhost-user-input: avoid g_return_val_if()\n input validation","To":"Stefan Hajnoczi ","Content-Type":"multipart/alternative; boundary=\"00000000000055109105b57d390a\"","Received-SPF":"pass client-ip=2a00:1450:4864:20::643;\n envelope-from=marcandre.lureau@gmail.com; helo=mail-ej1-x643.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Kevin Wolf ,\n \"open list:Block layer core\" ,\n \"Michael S. Tsirkin\" , Markus Armbruster ,\n QEMU , Coiby Xu ,\n Raphael Norwitz ,\n Gerd Hoffmann , Max Reitz ,\n Stefano Garzarella ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "}},{"id":2591799,"web_url":"http://patchwork.ozlabs.org/comment/2591799/","msgid":"<20201203095214.GB689053@stefanha-x1.localdomain>","list_archive_url":null,"date":"2020-12-03T09:52:14","subject":"Re: [PATCH v2 3/4] contrib/vhost-user-input: avoid g_return_val_if()\n input validation","submitter":{"id":17227,"url":"http://patchwork.ozlabs.org/api/people/17227/","name":"Stefan Hajnoczi","email":"stefanha@redhat.com"},"content":"On Wed, Dec 02, 2020 at 07:51:49PM +0400, Marc-André Lureau wrote:\n> On Wed, Dec 2, 2020 at 7:27 PM Stefan Hajnoczi wrote:\n> \n> > Do not validate input with g_return_val_if(). This API is intended for\n> > checking programming errors and is compiled out with -DG_DISABLE_CHECKS.\n> >\n> > Use an explicit if statement for input validation so it cannot\n> > accidentally be compiled out.\n> >\n> > Suggested-by: Markus Armbruster \n> > Signed-off-by: Stefan Hajnoczi \n> > ---\n> > contrib/vhost-user-input/main.c | 6 +++++-\n> > 1 file changed, 5 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/contrib/vhost-user-input/main.c\n> > b/contrib/vhost-user-input/main.c\n> > index 6020c6f33a..1d79c61200 100644\n> > --- a/contrib/vhost-user-input/main.c\n> > +++ b/contrib/vhost-user-input/main.c\n> > @@ -212,7 +212,11 @@ static int vi_get_config(VuDev *dev, uint8_t *config,\n> > uint32_t len)\n> > {\n> > VuInput *vi = container_of(dev, VuInput, dev.parent);\n> >\n> > - g_return_val_if_fail(len <= sizeof(*vi->sel_config), -1);\n> > + if (len > sizeof(*vi->sel_config)) {\n> > + g_critical(\"%s: len %u is larger than %zu\",\n> > + __func__, len, sizeof(*vi->sel_config));\n> > + return -1;\n> >\n> \n> g_critical() already has __FILE__ __LINE__ and G_STRFUNC.\n\nWill fix.\n\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=redhat.com","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=DmhKpX38;\n\tdkim-atps=neutral","relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4Cmrk83Gm1z9sPB\n\tfor ; Thu, 3 Dec 2020 20:53:04 +1100 (AEDT)","from localhost ([::1]:52946 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1kklIM-0007gy-DS\n\tfor incoming@patchwork.ozlabs.org; Thu, 03 Dec 2020 04:53:02 -0500","from eggs.gnu.org ([2001:470:142:3::10]:59540)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1kklHv-0007YU-M6\n for qemu-devel@nongnu.org; Thu, 03 Dec 2020 04:52:37 -0500","from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:24979)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)\n (Exim 4.90_1) (envelope-from )\n id 1kklHr-00058A-8j\n for qemu-devel@nongnu.org; Thu, 03 Dec 2020 04:52:34 -0500","from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-425-G2Gla2RrP_y2ApFx6RNHUg-1; Thu, 03 Dec 2020 04:52:29 -0500","from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com\n [10.5.11.14])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EB663100C68B;\n Thu, 3 Dec 2020 09:52:15 +0000 (UTC)","from localhost (ovpn-115-46.ams2.redhat.com [10.36.115.46])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 8624A5D9D7;\n Thu, 3 Dec 2020 09:52:15 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1606989150;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=ypGNHbrp2fbovbGfvfo2LfnFtVDijM531tY5Ob2OkO0=;\n b=DmhKpX38gSHl6vBP6TX0cz8piZ4B+elA/OYmTCq2gk301AOMYXNM9rSIQ3eIIupkLGo9je\n Fs6qXRQtiuPQ+hdQJHsi4YmJnrS7fIuXA1ecN7BCuRss7CEwazpDQMJIW9DwUTu1dmDE8x\n 4ay0e4IpM21bL3LyJxEecoRIZybtWtY=","X-MC-Unique":"G2Gla2RrP_y2ApFx6RNHUg-1","Date":"Thu, 3 Dec 2020 09:52:14 +0000","From":"Stefan Hajnoczi ","To":"=?iso-8859-1?q?Marc-Andr=E9?= Lureau ","Subject":"Re: [PATCH v2 3/4] contrib/vhost-user-input: avoid g_return_val_if()\n input validation","Message-ID":"<20201203095214.GB689053@stefanha-x1.localdomain>","References":"<20201202152611.677753-1-stefanha@redhat.com>\n <20201202152611.677753-4-stefanha@redhat.com>\n ","MIME-Version":"1.0","In-Reply-To":"\n ","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"multipart/signed; micalg=pgp-sha256;\n protocol=\"application/pgp-signature\"; boundary=\"DKU6Jbt7q3WqK7+M\"","Content-Disposition":"inline","Received-SPF":"pass client-ip=216.205.24.124;\n envelope-from=stefanha@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-35","X-Spam_score":"-3.6","X-Spam_bar":"---","X-Spam_report":"(-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.495,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Kevin Wolf ,\n \"open list:Block layer core\" ,\n \"Michael S. Tsirkin\" , Markus Armbruster ,\n QEMU , Coiby Xu ,\n Raphael Norwitz ,\n Gerd Hoffmann , Max Reitz ,\n Stefano Garzarella ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "}}]