[{"id":2591046,"web_url":"http://patchwork.ozlabs.org/comment/2591046/","msgid":"","list_archive_url":null,"date":"2020-12-02T15:52:13","subject":"Re: [PATCH v2 4/4] block/export: avoid g_return_val_if() input\n validation","submitter":{"id":6442,"url":"http://patchwork.ozlabs.org/api/people/6442/","name":"Marc-André Lureau","email":"marcandre.lureau@gmail.com"},"content":"On Wed, Dec 2, 2020 at 7:27 PM Stefan Hajnoczi wrote:\n\n> Do not validate input with g_return_val_if(). This API is intended for\n> checking programming errors and is compiled out with -DG_DISABLE_CHECKS.\n>\n> Use an explicit if statement for input validation so it cannot\n> accidentally be compiled out.\n>\n> Suggested-by: Markus Armbruster \n> Signed-off-by: Stefan Hajnoczi \n>\n\nReviewed-by: Marc-André Lureau \n\n---\n> block/export/vhost-user-blk-server.c | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n>\n> diff --git a/block/export/vhost-user-blk-server.c\n> b/block/export/vhost-user-blk-server.c\n> index 62672d1cb9..bccbc98d57 100644\n> --- a/block/export/vhost-user-blk-server.c\n> +++ b/block/export/vhost-user-blk-server.c\n> @@ -267,7 +267,11 @@ vu_blk_get_config(VuDev *vu_dev, uint8_t *config,\n> uint32_t len)\n> VuServer *server = container_of(vu_dev, VuServer, vu_dev);\n> VuBlkExport *vexp = container_of(server, VuBlkExport, vu_server);\n>\n> - g_return_val_if_fail(len <= sizeof(struct virtio_blk_config), -1);\n> + if (len > sizeof(struct virtio_blk_config)) {\n> + error_report(\"Invalid get_config len %u, expected <= %zu\",\n> + len, sizeof(struct virtio_blk_config));\n> + return -1;\n> + }\n>\n> memcpy(config, &vexp->blkcfg, len);\n> return 0;\n> --\n> 2.28.0\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=gmail.com","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20161025 header.b=Dh6nY3LR;\n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4CmNm93tKDz9sRK\n\tfor ; Thu, 3 Dec 2020 02:53:13 +1100 (AEDT)","from localhost ([::1]:44958 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1kkURK-0001QM-Rt\n\tfor incoming@patchwork.ozlabs.org; Wed, 02 Dec 2020 10:53:10 -0500","from eggs.gnu.org ([2001:470:142:3::10]:58044)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1kkUQg-0001KU-77; Wed, 02 Dec 2020 10:52:31 -0500","from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]:36219)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1kkUQc-0007VG-QB; Wed, 02 Dec 2020 10:52:29 -0500","by mail-ed1-x542.google.com with SMTP id j14so4467829edy.3;\n Wed, 02 Dec 2020 07:52:26 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=mime-version:references:in-reply-to:from:date:message-id:subject:to\n :cc; bh=3XMQ4LwAvpJXzBdHEIj6fKRVovH0Phf+Lc07vTqMHzQ=;\n b=Dh6nY3LRDcSfNru6Ch/AoVAxuEEL/7ZpGKHvdadoWtmf3TWO/HCYu4g7ZFvfa1eQOz\n X4awLb3jdWf/4CdEvjvK5xzR8pvFWmpOZmENcz6m1avBBdyC1PIwhzLbdBP9/tjMdjUD\n aY+L6ThzKnoUxMFhe/yNFCOAvH7CC7PMAY5iOFfhjfHPVVMq1KaMMYTCjI0nSz/rnohH\n sW0+v9tsznCpnVK4wcAqz14gxA6yxs9NK49w0FceqKsZX2oxuaSBZoNst4b0yT+MFekm\n Ahkfx5UitmLFF4S5a4Sayq8fYdVEatpZQek252J+KjEtriRTPmZgf5NxaaRLHNWCmSeG\n 5k0w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:mime-version:references:in-reply-to:from:date\n :message-id:subject:to:cc;\n bh=3XMQ4LwAvpJXzBdHEIj6fKRVovH0Phf+Lc07vTqMHzQ=;\n b=GZRjJ9CqZkuebBAZM+YOSkREcjWKZaTGe87rNBz2YEXFOeGDv3AZgDZFJ2IK9DUt+R\n fNvzLHFY7bJNwqTa44MLy30J7nlQmSFmga6h1uAzxTytRHGWqYNbvO+nXhmut/SdCuvY\n vqSj2sRAWksdGxR6UKmXRHJ9nKAZUOZdTsViL2sa8BElDoCBwy8QPTmUfj7wWUFXFiaY\n z/eT8+q3fkVWdGlttDzPn/u7oYbeMRR2bcL03D8dY5wljAEuwnadD3a4NkurxXHhHPtV\n tneq2Sl3IRh0h43LgYVH8ygRUZXEpWEAv0Qd1t32RhKiBiTFIShv8S8IVSbfez3T/Anv\n Tcng==","X-Gm-Message-State":"AOAM533bCI6NnmnjsfYyAg574ybPiKWS2+uAb58CKb+9XHANpGGaTBBC\n cQZmPtYLrY1Kq5gNCUz/ZOfXjFuHLyf2ncv0AEI=","X-Google-Smtp-Source":"\n ABdhPJwSjoEMU3WZklDtJs58DGd3sxvnQgrqVnujADAGwp3osPZhdBlsm8zUX3g2BAVz9LilxkSBEN3EEiocNZbIWkg=","X-Received":"by 2002:a50:e846:: with SMTP id k6mr500259edn.245.1606924345159;\n Wed, 02 Dec 2020 07:52:25 -0800 (PST)","MIME-Version":"1.0","References":"<20201202152611.677753-1-stefanha@redhat.com>\n <20201202152611.677753-5-stefanha@redhat.com>","In-Reply-To":"<20201202152611.677753-5-stefanha@redhat.com>","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Wed, 2 Dec 2020 19:52:13 +0400","Message-ID":"\n ","Subject":"Re: [PATCH v2 4/4] block/export: avoid g_return_val_if() input\n validation","To":"Stefan Hajnoczi ","Content-Type":"multipart/alternative; boundary=\"000000000000c636ba05b57d3a86\"","Received-SPF":"pass client-ip=2a00:1450:4864:20::542;\n envelope-from=marcandre.lureau@gmail.com; helo=mail-ed1-x542.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Kevin Wolf ,\n \"open list:Block layer core\" ,\n \"Michael S. Tsirkin\" , Markus Armbruster ,\n QEMU , Coiby Xu ,\n Raphael Norwitz ,\n Gerd Hoffmann , Max Reitz ,\n Stefano Garzarella ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "}},{"id":2591064,"web_url":"http://patchwork.ozlabs.org/comment/2591064/","msgid":"<7d6db583-55c1-2043-8398-85b08ea3d3cf@redhat.com>","list_archive_url":null,"date":"2020-12-02T15:58:23","subject":"Re: [PATCH v2 4/4] block/export: avoid g_return_val_if() input\n validation","submitter":{"id":74995,"url":"http://patchwork.ozlabs.org/api/people/74995/","name":"Philippe Mathieu-Daudé","email":"philmd@redhat.com"},"content":"On 12/2/20 4:26 PM, Stefan Hajnoczi wrote:\n> Do not validate input with g_return_val_if(). This API is intended for\n> checking programming errors and is compiled out with -DG_DISABLE_CHECKS.\n> \n> Use an explicit if statement for input validation so it cannot\n> accidentally be compiled out.\n> \n> Suggested-by: Markus Armbruster \n> Signed-off-by: Stefan Hajnoczi \n> ---\n> block/export/vhost-user-blk-server.c | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=redhat.com","ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=WwlyFoKq;\n\tdkim-atps=neutral","relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4CmNtg5cj6z9sSf\n\tfor ; Thu, 3 Dec 2020 02:58:51 +1100 (AEDT)","from localhost ([::1]:57444 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1kkUWn-0007ej-Pb\n\tfor incoming@patchwork.ozlabs.org; Wed, 02 Dec 2020 10:58:49 -0500","from eggs.gnu.org ([2001:470:142:3::10]:59222)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1kkUWU-0007df-7A\n for qemu-devel@nongnu.org; Wed, 02 Dec 2020 10:58:30 -0500","from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:31165)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)\n (Exim 4.90_1) (envelope-from ) id 1kkUWS-00087e-Lt\n for qemu-devel@nongnu.org; Wed, 02 Dec 2020 10:58:29 -0500","from mail-ej1-f69.google.com (mail-ej1-f69.google.com\n [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-295-SN1gBTb0NF-7bl0aktooOw-1; Wed, 02 Dec 2020 10:58:26 -0500","by mail-ej1-f69.google.com with SMTP id f21so3316969ejf.11\n for ; Wed, 02 Dec 2020 07:58:26 -0800 (PST)","from [192.168.1.36] (111.red-88-21-205.staticip.rima-tde.net.\n [88.21.205.111])\n by smtp.gmail.com with ESMTPSA id p35sm242654edd.58.2020.12.02.07.58.23\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 02 Dec 2020 07:58:24 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1606924708;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=v038wf4ZStL7X4tAXbU9ekFHO98jMDSrYFCSONu18mc=;\n b=WwlyFoKqRh2imMYG9G5J3VT0StQ1Fjgxu9h/M09KkhUlt1wKXx+KMpJAfzuZGh1LafmV6P\n jJ7MqKlehHYrk6jE2S0HY0o0K0rKi9hnF0h6IvanS11Eq6ZalXEtQRv2bI6MJVNIu9GXu9\n KVMoqBpA+pvHPrXF7NmDeDVpLGK8CqQ=","X-MC-Unique":"SN1gBTb0NF-7bl0aktooOw-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:subject:to:cc:references:from:message-id:date\n :user-agent:mime-version:in-reply-to:content-language\n :content-transfer-encoding;\n bh=v038wf4ZStL7X4tAXbU9ekFHO98jMDSrYFCSONu18mc=;\n b=DtGccg7aMQGBlg94Jw69Vmd5bwE3R/g97Wxwhh1NqqgmYT4koN9S5BzsHa8kb05MEU\n 9Fbeik7EhaJ7jCnGbKr+MpDK7nbxC4M3PHXymm5YSGECrojG5zKhLkVpJD2ZA7zDKUDh\n DD0U3+dJ9hCl24IM12PkdLnV+zwY8EG07Qux7A9QPWu0cIB2MuO4jkFKhBUBtMyPabEq\n myEvc3ME/F1GgMkhvokplm6igvkEa99c8mqmtKXfNxxYLAS5lQb3iVB4NEjzIWNr8bfn\n s0A73yHfS0YQnRLL7tSeHwqPkajN9SE7DmGYJEQpnPWF2bn8b+4CYu3AO8hdUcYHsUMi\n aqvA==","X-Gm-Message-State":"AOAM530j3RXtP5aSMth6JmcUC83blfHUoYd6NKX47MKHB/vOZWUpUf5R\n U+RRxQelodkJo7foVHRL6uxXvNThhiySYE36h7cMoLopiJKflnUzcDZwJaUhfAxqLgJoK9rYTms\n nA89j6i5wVbMsKeQ=","X-Received":["by 2002:aa7:da53:: with SMTP id w19mr566755eds.190.1606924705455;\n Wed, 02 Dec 2020 07:58:25 -0800 (PST)","by 2002:aa7:da53:: with SMTP id w19mr566749eds.190.1606924705329;\n Wed, 02 Dec 2020 07:58:25 -0800 (PST)"],"X-Google-Smtp-Source":"\n ABdhPJyNZBU2f7h1DAjkcFBDoZopunRa9+gHNLzenwJ/eW4y0DynkcRRj7mh37gbNkXSVJhb2udVRQ==","Subject":"Re: [PATCH v2 4/4] block/export: avoid g_return_val_if() input\n validation","To":"Stefan Hajnoczi , qemu-devel@nongnu.org","References":"<20201202152611.677753-1-stefanha@redhat.com>\n <20201202152611.677753-5-stefanha@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"<7d6db583-55c1-2043-8398-85b08ea3d3cf@redhat.com>","Date":"Wed, 2 Dec 2020 16:58:23 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n Thunderbird/78.4.0","MIME-Version":"1.0","In-Reply-To":"<20201202152611.677753-5-stefanha@redhat.com>","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-35","X-Spam_score":"-3.6","X-Spam_bar":"---","X-Spam_report":"(-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.495,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001,\n RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Kevin Wolf , qemu-block@nongnu.org,\n \"Michael S. Tsirkin\" , Markus Armbruster ,\n Coiby Xu , Raphael Norwitz ,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Gerd Hoffmann ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Max Reitz , Stefano Garzarella ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "}}]