[{"id":2591041,"web_url":"http://patchwork.ozlabs.org/comment/2591041/","msgid":"","list_archive_url":null,"date":"2020-12-02T15:50:51","subject":"Re: [PATCH v2 2/4] contrib/vhost-user-gpu: avoid g_return_val_if()\n input validation","submitter":{"id":6442,"url":"http://patchwork.ozlabs.org/api/people/6442/","name":"Marc-André Lureau","email":"marcandre.lureau@gmail.com"},"content":"On Wed, Dec 2, 2020 at 7:27 PM Stefan Hajnoczi wrote:\n\n> Do not validate input with g_return_val_if(). This API is intended for\n> checking programming errors and is compiled out with -DG_DISABLE_CHECKS.\n>\n> Use an explicit if statement for input validation so it cannot\n> accidentally be compiled out.\n>\n> Suggested-by: Markus Armbruster \n> Signed-off-by: Stefan Hajnoczi \n> ---\n> contrib/vhost-user-gpu/vhost-user-gpu.c | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n>\n> diff --git a/contrib/vhost-user-gpu/vhost-user-gpu.c\n> b/contrib/vhost-user-gpu/vhost-user-gpu.c\n> index a019d0a9ac..534bad24d1 100644\n> --- a/contrib/vhost-user-gpu/vhost-user-gpu.c\n> +++ b/contrib/vhost-user-gpu/vhost-user-gpu.c\n> @@ -1044,7 +1044,11 @@ vg_get_config(VuDev *dev, uint8_t *config, uint32_t\n> len)\n> {\n> VuGpu *g = container_of(dev, VuGpu, dev.parent);\n>\n> - g_return_val_if_fail(len <= sizeof(struct virtio_gpu_config), -1);\n> + if (len > sizeof(struct virtio_gpu_config)) {\n> + g_critical(\"%s: len %u is larger than %zu\",\n> + __func__, len, sizeof(struct virtio_gpu_config));\n>\n\ng_critical() already has __FILE__ __LINE__ and G_STRFUNC.\n\notherwise looks good:\nReviewed-by: Marc-André Lureau \n\n+ return -1;\n> + }\n>\n> if (opt_virgl) {\n> g->virtio_config.num_capsets = vg_virgl_get_num_capsets();\n> --\n> 2.28.0\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=gmail.com","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20161025 header.b=n17eMVoM;\n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4CmNkF1BhDz9sRK\n\tfor ; Thu, 3 Dec 2020 02:51:33 +1100 (AEDT)","from localhost ([::1]:42824 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1kkUPj-00008I-75\n\tfor incoming@patchwork.ozlabs.org; Wed, 02 Dec 2020 10:51:31 -0500","from eggs.gnu.org ([2001:470:142:3::10]:57616)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1kkUPN-00005B-K5; Wed, 02 Dec 2020 10:51:09 -0500","from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]:35060)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1kkUPI-0007O1-NL; Wed, 02 Dec 2020 10:51:09 -0500","by mail-ed1-x541.google.com with SMTP id u19so4474010edx.2;\n Wed, 02 Dec 2020 07:51:03 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=mime-version:references:in-reply-to:from:date:message-id:subject:to\n :cc; bh=B+VvBTRRX116/kkvC/NyWwUjZRmmOORT/n5Inx8MSw4=;\n b=n17eMVoMbXOqULx/9BhhOTFcr/JojGA+gUeV9ij2lHFzvTJxHagvevaGbOWNRuw4BI\n vMy/UbXTu5UxWFg1l6qxmboCV17x4sNSoh/1qSLE+So7fhgbtv1AXrr59Fw5gFHlQcgE\n 1I17zcEKi3LZELj4WoG62JVeIyJoFAzd9F5y/FsGRsJAgZFZ2BJJvuc1xWownacvmFny\n V9nEwGNLmhpwrGQpzLjoOUM9Z26L2Sy+N7B0SUXSHcWVXQgvrFoxF2xcMVdVbhns2blh\n k9DmX6VOQZ+kYHF3zSSitv1irSMNIvzayFP0hqvqLJzAfjPmDeRo9oBQW0XAnpcDUf7U\n STQg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:mime-version:references:in-reply-to:from:date\n :message-id:subject:to:cc;\n bh=B+VvBTRRX116/kkvC/NyWwUjZRmmOORT/n5Inx8MSw4=;\n b=VZ53ynt2f2Q1rPQhBXdVpWbNr0GMwdghDABuzqeHvRmHfeK6yMNuFqLnga/C/OFUNk\n zFzTGk4mbj0Md3vSEBYTi5MPEUuCeLN/f3CI3U11yn6SSSSvHFKlVB7so34w+wqaZLu2\n bhZ/6QKlgSXOvNprvxaftn9byS4KvARdJrR/g6wjIw7rQS1HNXcofUmkQFGBhGw8COqr\n nicOF8C17pHZd3MuCXJ9MpuWH44akqN7lHsAV2QxVuwkk9LabOQi+2RZaC9pFYM61m44\n UfbkLARTLITZEG3w1g0lBmL3DhW1FIGa/Nl8/c0FsRK2CM3BWw4iG9oj5pdfDFPz2frK\n hqFA==","X-Gm-Message-State":"AOAM531fl2kdLhs/oM7LMaEN3XHcJlFpfyL8zrNQM/ZmZcHhZfTApqVj\n 7gKw7+v6Dqw6YnA5PH3hfMC7kKPnBYJky4ThRUw=","X-Google-Smtp-Source":"\n ABdhPJxGmWtJRCZVJOlKYu3QprggKvpW1lftIiLN6Y7DuHdQCxIUgRjWH/MU8r6ahzP50QVrNSbKiVPhgZOEi0Imvpo=","X-Received":"by 2002:a50:a6de:: with SMTP id f30mr558306edc.30.1606924263088;\n Wed, 02 Dec 2020 07:51:03 -0800 (PST)","MIME-Version":"1.0","References":"<20201202152611.677753-1-stefanha@redhat.com>\n <20201202152611.677753-3-stefanha@redhat.com>","In-Reply-To":"<20201202152611.677753-3-stefanha@redhat.com>","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Wed, 2 Dec 2020 19:50:51 +0400","Message-ID":"\n ","Subject":"Re: [PATCH v2 2/4] contrib/vhost-user-gpu: avoid g_return_val_if()\n input validation","To":"Stefan Hajnoczi ","Content-Type":"multipart/alternative; boundary=\"000000000000e1e6cf05b57d3526\"","Received-SPF":"pass client-ip=2a00:1450:4864:20::541;\n envelope-from=marcandre.lureau@gmail.com; helo=mail-ed1-x541.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Kevin Wolf ,\n \"open list:Block layer core\" ,\n \"Michael S. Tsirkin\" , Markus Armbruster ,\n QEMU , Coiby Xu ,\n Raphael Norwitz ,\n Gerd Hoffmann , Max Reitz ,\n Stefano Garzarella ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "}},{"id":2591803,"web_url":"http://patchwork.ozlabs.org/comment/2591803/","msgid":"<20201203095119.GA689053@stefanha-x1.localdomain>","list_archive_url":null,"date":"2020-12-03T09:51:19","subject":"Re: [PATCH v2 2/4] contrib/vhost-user-gpu: avoid g_return_val_if()\n input validation","submitter":{"id":17227,"url":"http://patchwork.ozlabs.org/api/people/17227/","name":"Stefan Hajnoczi","email":"stefanha@redhat.com"},"content":"On Wed, Dec 02, 2020 at 07:50:51PM +0400, Marc-André Lureau wrote:\n> On Wed, Dec 2, 2020 at 7:27 PM Stefan Hajnoczi wrote:\n> \n> > Do not validate input with g_return_val_if(). This API is intended for\n> > checking programming errors and is compiled out with -DG_DISABLE_CHECKS.\n> >\n> > Use an explicit if statement for input validation so it cannot\n> > accidentally be compiled out.\n> >\n> > Suggested-by: Markus Armbruster \n> > Signed-off-by: Stefan Hajnoczi \n> > ---\n> > contrib/vhost-user-gpu/vhost-user-gpu.c | 6 +++++-\n> > 1 file changed, 5 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/contrib/vhost-user-gpu/vhost-user-gpu.c\n> > b/contrib/vhost-user-gpu/vhost-user-gpu.c\n> > index a019d0a9ac..534bad24d1 100644\n> > --- a/contrib/vhost-user-gpu/vhost-user-gpu.c\n> > +++ b/contrib/vhost-user-gpu/vhost-user-gpu.c\n> > @@ -1044,7 +1044,11 @@ vg_get_config(VuDev *dev, uint8_t *config, uint32_t\n> > len)\n> > {\n> > VuGpu *g = container_of(dev, VuGpu, dev.parent);\n> >\n> > - g_return_val_if_fail(len <= sizeof(struct virtio_gpu_config), -1);\n> > + if (len > sizeof(struct virtio_gpu_config)) {\n> > + g_critical(\"%s: len %u is larger than %zu\",\n> > + __func__, len, sizeof(struct virtio_gpu_config));\n> >\n> \n> g_critical() already has __FILE__ __LINE__ and G_STRFUNC.\n\nI did this for consistency with the logging in this source file. The\nother g_critical() calls in the file also print __func__.\n\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=redhat.com","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=WlF2u14s;\n\tdkim-atps=neutral","relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4Cmrm46DPFz9sPB\n\tfor ; Thu, 3 Dec 2020 20:54:42 +1100 (AEDT)","from localhost ([::1]:56474 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1kklJw-0000nN-6F\n\tfor incoming@patchwork.ozlabs.org; Thu, 03 Dec 2020 04:54:40 -0500","from eggs.gnu.org ([2001:470:142:3::10]:59396)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1kklHV-00078B-2v\n for qemu-devel@nongnu.org; Thu, 03 Dec 2020 04:52:09 -0500","from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:28720)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)\n (Exim 4.90_1) (envelope-from )\n id 1kklHT-0004zt-Cd\n for qemu-devel@nongnu.org; Thu, 03 Dec 2020 04:52:08 -0500","from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-291-GLob8OtvNZKq-Fg--PZrmg-1; Thu, 03 Dec 2020 04:52:04 -0500","from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com\n [10.5.11.13])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5591F19057AF;\n Thu, 3 Dec 2020 09:52:03 +0000 (UTC)","from localhost (ovpn-115-46.ams2.redhat.com [10.36.115.46])\n by smtp.corp.redhat.com (Postfix) with ESMTP id B8AD160861;\n Thu, 3 Dec 2020 09:51:57 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1606989126;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=r+tgLvPZFKvKeCaWkDYatF/aX7SwLW8qof5R5bl6kN8=;\n b=WlF2u14stkpLTLrdKmyhRj7mQTXvYasKIGxAAX1Uq4cBjjlVOJbMz1bA0DItcOw6F52HBv\n XLNJ2B2BFfdwAPXpS8ktsUbfWTUiqYNo90i7pbJNw1joyKVC2OCmse17UX/UTRyGYQpPhE\n c4p2DG325cmpT7T0IoHfAh4HPqgprxQ=","X-MC-Unique":"GLob8OtvNZKq-Fg--PZrmg-1","Date":"Thu, 3 Dec 2020 09:51:19 +0000","From":"Stefan Hajnoczi ","To":"=?iso-8859-1?q?Marc-Andr=E9?= Lureau ","Subject":"Re: [PATCH v2 2/4] contrib/vhost-user-gpu: avoid g_return_val_if()\n input validation","Message-ID":"<20201203095119.GA689053@stefanha-x1.localdomain>","References":"<20201202152611.677753-1-stefanha@redhat.com>\n <20201202152611.677753-3-stefanha@redhat.com>\n ","MIME-Version":"1.0","In-Reply-To":"\n ","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"multipart/signed; micalg=pgp-sha256;\n protocol=\"application/pgp-signature\"; boundary=\"Nq2Wo0NMKNjxTN9z\"","Content-Disposition":"inline","Received-SPF":"pass client-ip=216.205.24.124;\n envelope-from=stefanha@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-35","X-Spam_score":"-3.6","X-Spam_bar":"---","X-Spam_report":"(-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.495,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Kevin Wolf ,\n \"open list:Block layer core\" ,\n \"Michael S. Tsirkin\" , Markus Armbruster ,\n QEMU , Coiby Xu ,\n Raphael Norwitz ,\n Gerd Hoffmann , Max Reitz ,\n Stefano Garzarella ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "}},{"id":2591830,"web_url":"http://patchwork.ozlabs.org/comment/2591830/","msgid":"","list_archive_url":null,"date":"2020-12-03T10:26:08","subject":"Re: [PATCH v2 2/4] contrib/vhost-user-gpu: avoid g_return_val_if()\n input validation","submitter":{"id":6442,"url":"http://patchwork.ozlabs.org/api/people/6442/","name":"Marc-André Lureau","email":"marcandre.lureau@gmail.com"},"content":"On Thu, Dec 3, 2020 at 1:52 PM Stefan Hajnoczi wrote:\n\n> On Wed, Dec 02, 2020 at 07:50:51PM +0400, Marc-André Lureau wrote:\n> > On Wed, Dec 2, 2020 at 7:27 PM Stefan Hajnoczi \n> wrote:\n> >\n> > > Do not validate input with g_return_val_if(). This API is intended for\n> > > checking programming errors and is compiled out with\n> -DG_DISABLE_CHECKS.\n> > >\n> > > Use an explicit if statement for input validation so it cannot\n> > > accidentally be compiled out.\n> > >\n> > > Suggested-by: Markus Armbruster \n> > > Signed-off-by: Stefan Hajnoczi \n> > > ---\n> > > contrib/vhost-user-gpu/vhost-user-gpu.c | 6 +++++-\n> > > 1 file changed, 5 insertions(+), 1 deletion(-)\n> > >\n> > > diff --git a/contrib/vhost-user-gpu/vhost-user-gpu.c\n> > > b/contrib/vhost-user-gpu/vhost-user-gpu.c\n> > > index a019d0a9ac..534bad24d1 100644\n> > > --- a/contrib/vhost-user-gpu/vhost-user-gpu.c\n> > > +++ b/contrib/vhost-user-gpu/vhost-user-gpu.c\n> > > @@ -1044,7 +1044,11 @@ vg_get_config(VuDev *dev, uint8_t *config,\n> uint32_t\n> > > len)\n> > > {\n> > > VuGpu *g = container_of(dev, VuGpu, dev.parent);\n> > >\n> > > - g_return_val_if_fail(len <= sizeof(struct virtio_gpu_config), -1);\n> > > + if (len > sizeof(struct virtio_gpu_config)) {\n> > > + g_critical(\"%s: len %u is larger than %zu\",\n> > > + __func__, len, sizeof(struct virtio_gpu_config));\n> > >\n> >\n> > g_critical() already has __FILE__ __LINE__ and G_STRFUNC.\n>\n> I did this for consistency with the logging in this source file. The\n> other g_critical() calls in the file also print __func__.\n>\n>\n>\nI see, nevermind then. I gave rb anyway","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=gmail.com","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20161025 header.b=BnQXo2xl;\n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4CmsVC0yC7z9sTL\n\tfor ; Thu, 3 Dec 2020 21:27:47 +1100 (AEDT)","from localhost ([::1]:33640 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1kklpv-0000q8-Jc\n\tfor incoming@patchwork.ozlabs.org; Thu, 03 Dec 2020 05:27:45 -0500","from eggs.gnu.org ([2001:470:142:3::10]:39204)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1kklog-0008Vg-Cq; Thu, 03 Dec 2020 05:26:26 -0500","from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]:35556)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1kkloc-0000HF-QP; Thu, 03 Dec 2020 05:26:24 -0500","by mail-ej1-x644.google.com with SMTP id f23so2700492ejk.2;\n Thu, 03 Dec 2020 02:26:21 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=mime-version:references:in-reply-to:from:date:message-id:subject:to\n :cc; bh=VB6Qld4l2Nhzm4LaKEal+oZp1RIezoto+6VcIpf2R7s=;\n b=BnQXo2xl9jMbGaewXAEMpaGqVLMDrhi9nTIimY0xbPhas2oLHvqA1bhjeER0mCrd4K\n DR86BorKIob3mRcAQFGE96Hni0BTKvjmTWX2UjY2aog5xq8NDHcjNStrSAU2QyavZ5xn\n HUMaL+U71WTlLKACDjilesy0V0EnGZtsuCGfu6fPW4ngpfQe7yJPPNDph9E9se19JtZT\n wdrNlBonQ9+W4mt5zK/FU/fn5wXECZkKVCaXA1UAnkBU5AiuqT+ODzfgxYxyNWI4mOLH\n u9l+hZl2OY1/Tb+VexlmaepqxuGVABlQnmd2UfKUd0B6trQwWRQr7M4Or16KfKPzu2uf\n SZ9Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:mime-version:references:in-reply-to:from:date\n :message-id:subject:to:cc;\n bh=VB6Qld4l2Nhzm4LaKEal+oZp1RIezoto+6VcIpf2R7s=;\n b=E79ezPD2EQ0y+LobLMGWym/BION2DmxteD6NIg49wA4pJu5JCL3ILHzWpK6r3GhXm5\n eQPuOrU+vQ+p7+WMQtRmxmIymPa9kL7mvdMk5fVgOB5Aj6fPwTLy77ZtC4a1X1MFvQsq\n D5yqBLlklZ47/2MOsnztp4kOq1HZtdb80FTbi+85msj2A5OvAxmEcqYRmAFjxwE7JiuR\n ccbM4nKipRHZ+Pbpfht4clZpKp+CRxU9S8ZR9FrTwVofhbKfV0FEB1hJLbHDYC+2vnll\n ox9KNVIjhuQWWdljGntADFDyWSbPKKV199OFJDdyJoG7N2i4pj1pUSM3+WTrxni5rif/\n Hj6w==","X-Gm-Message-State":"AOAM531fFDcvmOG9Ae385+7+71NbNkiuePpOd6K/TWTsmcPqxlK1qL56\n U1gFRF1Ik3oDOI5C/TuYn/IV6fppr/XkiIPXA5E=","X-Google-Smtp-Source":"\n ABdhPJzCt5jUjAU85eejuxsYOZXlWfFAVXIvml+Rk4JPJTsAvLZZbMgNuEWRUuKdNuEESS2gNJT+XHxr+m0H8EYGhhc=","X-Received":"by 2002:a17:906:aacd:: with SMTP id\n kt13mr1805305ejb.527.1606991180529;\n Thu, 03 Dec 2020 02:26:20 -0800 (PST)","MIME-Version":"1.0","References":"<20201202152611.677753-1-stefanha@redhat.com>\n <20201202152611.677753-3-stefanha@redhat.com>\n \n <20201203095119.GA689053@stefanha-x1.localdomain>","In-Reply-To":"<20201203095119.GA689053@stefanha-x1.localdomain>","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Thu, 3 Dec 2020 14:26:08 +0400","Message-ID":"\n ","Subject":"Re: [PATCH v2 2/4] contrib/vhost-user-gpu: avoid g_return_val_if()\n input validation","To":"Stefan Hajnoczi ","Content-Type":"multipart/alternative; boundary=\"0000000000007904ee05b58cca6c\"","Received-SPF":"pass client-ip=2a00:1450:4864:20::644;\n envelope-from=marcandre.lureau@gmail.com; helo=mail-ej1-x644.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Kevin Wolf ,\n \"open list:Block layer core\" ,\n \"Michael S. Tsirkin\" , Markus Armbruster ,\n QEMU , Coiby Xu ,\n Raphael Norwitz ,\n Gerd Hoffmann , Max Reitz ,\n Stefano Garzarella ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "}},{"id":2591894,"web_url":"http://patchwork.ozlabs.org/comment/2591894/","msgid":"<20201203113742.GG689053@stefanha-x1.localdomain>","list_archive_url":null,"date":"2020-12-03T11:37:42","subject":"Re: [PATCH v2 2/4] contrib/vhost-user-gpu: avoid g_return_val_if()\n input validation","submitter":{"id":17227,"url":"http://patchwork.ozlabs.org/api/people/17227/","name":"Stefan Hajnoczi","email":"stefanha@redhat.com"},"content":"On Thu, Dec 03, 2020 at 02:26:08PM +0400, Marc-André Lureau wrote:\n> On Thu, Dec 3, 2020 at 1:52 PM Stefan Hajnoczi wrote:\n> \n> > On Wed, Dec 02, 2020 at 07:50:51PM +0400, Marc-André Lureau wrote:\n> > > On Wed, Dec 2, 2020 at 7:27 PM Stefan Hajnoczi \n> > wrote:\n> > >\n> > > > Do not validate input with g_return_val_if(). This API is intended for\n> > > > checking programming errors and is compiled out with\n> > -DG_DISABLE_CHECKS.\n> > > >\n> > > > Use an explicit if statement for input validation so it cannot\n> > > > accidentally be compiled out.\n> > > >\n> > > > Suggested-by: Markus Armbruster \n> > > > Signed-off-by: Stefan Hajnoczi \n> > > > ---\n> > > > contrib/vhost-user-gpu/vhost-user-gpu.c | 6 +++++-\n> > > > 1 file changed, 5 insertions(+), 1 deletion(-)\n> > > >\n> > > > diff --git a/contrib/vhost-user-gpu/vhost-user-gpu.c\n> > > > b/contrib/vhost-user-gpu/vhost-user-gpu.c\n> > > > index a019d0a9ac..534bad24d1 100644\n> > > > --- a/contrib/vhost-user-gpu/vhost-user-gpu.c\n> > > > +++ b/contrib/vhost-user-gpu/vhost-user-gpu.c\n> > > > @@ -1044,7 +1044,11 @@ vg_get_config(VuDev *dev, uint8_t *config,\n> > uint32_t\n> > > > len)\n> > > > {\n> > > > VuGpu *g = container_of(dev, VuGpu, dev.parent);\n> > > >\n> > > > - g_return_val_if_fail(len <= sizeof(struct virtio_gpu_config), -1);\n> > > > + if (len > sizeof(struct virtio_gpu_config)) {\n> > > > + g_critical(\"%s: len %u is larger than %zu\",\n> > > > + __func__, len, sizeof(struct virtio_gpu_config));\n> > > >\n> > >\n> > > g_critical() already has __FILE__ __LINE__ and G_STRFUNC.\n> >\n> > I did this for consistency with the logging in this source file. The\n> > other g_critical() calls in the file also print __func__.\n> >\n> >\n> >\n> I see, nevermind then. I gave rb anyway\n\nThanks! I checked now and don't see the function name printed by\ng_critical() even though G_STRFUNC is captured in the header file:\n\n** (process:693258): CRITICAL **: 11:30:18.210: test\n\nMaybe only custom log handlers can display the function name?\n\nSo it seems the explicit __func__ approach is okay-ish :).\n\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=redhat.com","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=NCPFbYo5;\n\tdkim-atps=neutral","relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4Cmv4R41KVz9sVY\n\tfor ; Thu, 3 Dec 2020 22:39:03 +1100 (AEDT)","from localhost ([::1]:32934 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1kkmwv-0003os-I6\n\tfor incoming@patchwork.ozlabs.org; Thu, 03 Dec 2020 06:39:01 -0500","from eggs.gnu.org ([2001:470:142:3::10]:57656)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1kkmw1-0003o7-7E\n for qemu-devel@nongnu.org; Thu, 03 Dec 2020 06:38:05 -0500","from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:53691)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)\n (Exim 4.90_1) (envelope-from )\n id 1kkmvz-0008Hg-Mp\n for qemu-devel@nongnu.org; Thu, 03 Dec 2020 06:38:04 -0500","from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-525-83vS2OgKNby7xlHWW38QjQ-1; Thu, 03 Dec 2020 06:37:52 -0500","from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com\n [10.5.11.16])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B9688858192;\n Thu, 3 Dec 2020 11:37:50 +0000 (UTC)","from localhost (ovpn-115-46.ams2.redhat.com [10.36.115.46])\n by smtp.corp.redhat.com (Postfix) with ESMTP id CAFB95C1C2;\n Thu, 3 Dec 2020 11:37:43 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1606995483;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=eRHnNZO59wpdkbQMVn0kD+5Q8Up6dtzgDRjOgxQwgsw=;\n b=NCPFbYo5nQ+eHD5gVNgrJL3J4NHLlIDq36bi01WIjkG+sJQHmNJ3wWFJQKOix961nfgA/5\n xya9Au0wtbNbi3pjRQWWXDlMYgDLumqhFaDU3eyEfk+L2mFLQsR0agHaTgZQhiM1LpCutT\n pRJyioQQut5cTSxr75DARuEwg22m5NI=","X-MC-Unique":"83vS2OgKNby7xlHWW38QjQ-1","Date":"Thu, 3 Dec 2020 11:37:42 +0000","From":"Stefan Hajnoczi ","To":"=?iso-8859-1?q?Marc-Andr=E9?= Lureau ","Subject":"Re: [PATCH v2 2/4] contrib/vhost-user-gpu: avoid g_return_val_if()\n input validation","Message-ID":"<20201203113742.GG689053@stefanha-x1.localdomain>","References":"<20201202152611.677753-1-stefanha@redhat.com>\n <20201202152611.677753-3-stefanha@redhat.com>\n \n <20201203095119.GA689053@stefanha-x1.localdomain>\n ","MIME-Version":"1.0","In-Reply-To":"\n ","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"multipart/signed; micalg=pgp-sha256;\n protocol=\"application/pgp-signature\"; boundary=\"t4apE7yKrX2dGgJC\"","Content-Disposition":"inline","Received-SPF":"pass client-ip=216.205.24.124;\n envelope-from=stefanha@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-35","X-Spam_score":"-3.6","X-Spam_bar":"---","X-Spam_report":"(-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.495,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Kevin Wolf ,\n \"open list:Block layer core\" ,\n \"Michael S. Tsirkin\" , Markus Armbruster ,\n QEMU , Coiby Xu ,\n Raphael Norwitz ,\n Gerd Hoffmann , Max Reitz ,\n Stefano Garzarella ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "}}]