[{"id":2591037,"web_url":"http://patchwork.ozlabs.org/comment/2591037/","msgid":"","list_archive_url":null,"date":"2020-12-02T15:49:15","subject":"Re: [PATCH v2 1/4] contrib/vhost-user-blk: avoid g_return_val_if()\n input validation","submitter":{"id":6442,"url":"http://patchwork.ozlabs.org/api/people/6442/","name":"Marc-André Lureau","email":"marcandre.lureau@gmail.com"},"content":"On Wed, Dec 2, 2020 at 7:26 PM Stefan Hajnoczi wrote:\n\n> Do not validate input with g_return_val_if(). This API is intended for\n> checking programming errors and is compiled out with -DG_DISABLE_CHECKS.\n>\n> Use an explicit if statement for input validation so it cannot\n> accidentally be compiled out.\n>\n> Suggested-by: Markus Armbruster \n> Signed-off-by: Stefan Hajnoczi \n>\n\nReviewed-by: Marc-André Lureau \n\n---\n> contrib/vhost-user-blk/vhost-user-blk.c | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n>\n> diff --git a/contrib/vhost-user-blk/vhost-user-blk.c\n> b/contrib/vhost-user-blk/vhost-user-blk.c\n> index dc981bf945..60e3c9ed37 100644\n> --- a/contrib/vhost-user-blk/vhost-user-blk.c\n> +++ b/contrib/vhost-user-blk/vhost-user-blk.c\n> @@ -404,7 +404,11 @@ vub_get_config(VuDev *vu_dev, uint8_t *config,\n> uint32_t len)\n> VugDev *gdev;\n> VubDev *vdev_blk;\n>\n> - g_return_val_if_fail(len <= sizeof(struct virtio_blk_config), -1);\n> + if (len > sizeof(struct virtio_blk_config)) {\n> + fprintf(stderr, \"Invalid get_config len %u, expected <= %zu\\n\",\n> + len, sizeof(struct virtio_blk_config));\n> + return -1;\n> + }\n>\n> gdev = container_of(vu_dev, VugDev, parent);\n> vdev_blk = container_of(gdev, VubDev, parent);\n> --\n> 2.28.0\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=gmail.com","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20161025 header.b=X9v8rRaJ;\n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4CmNhm0Frsz9sRK\n\tfor ; Thu, 3 Dec 2020 02:50:14 +1100 (AEDT)","from localhost ([::1]:40654 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1kkUOP-0007SS-Pg\n\tfor incoming@patchwork.ozlabs.org; Wed, 02 Dec 2020 10:50:09 -0500","from eggs.gnu.org ([2001:470:142:3::10]:57086)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1kkUNn-0007Ru-Pl; Wed, 02 Dec 2020 10:49:31 -0500","from mail-ej1-x643.google.com ([2a00:1450:4864:20::643]:33490)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1kkUNk-00074d-UO; Wed, 02 Dec 2020 10:49:31 -0500","by mail-ej1-x643.google.com with SMTP id 7so5114095ejm.0;\n Wed, 02 Dec 2020 07:49:27 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=mime-version:references:in-reply-to:from:date:message-id:subject:to\n :cc; bh=FPyZK3RPJYro0MJgaw/JY+B2dR3rUNo58dZwN3bhadE=;\n b=X9v8rRaJ9cPhfw1p9I7ph5VXEXAiUN1wA4z5B8PTfVxRQByZzcZywOo/dsA9M4A8fr\n WgmjYHdOb3NRnn+P42VRA/Qhsul/xjMYaWAOqEQdvAJw3H1ROPyyAK75OwW9G4D8AJtT\n +CJNjfjlIVUhB/fi/6nu0hrHSnNBt4fCTVtIBgD7uT4nkNUAIeq1/O8SOKGZXIeY/She\n jB/c8vdBCGU0GmClmZLaqrEFyTa8AVw8TlT/UvmTrd/RE1Gp9gdXPGEiXnNwOYURnl9A\n V7xRM6h8Y7U37oo34OWu3gFS1zcEslW3kQr4bYR14MfxJhhgESypozb0AOj+eAMY7f7f\n 3U5w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:mime-version:references:in-reply-to:from:date\n :message-id:subject:to:cc;\n bh=FPyZK3RPJYro0MJgaw/JY+B2dR3rUNo58dZwN3bhadE=;\n b=EVbYUIE73ks9seiKdPQrWVBiFvFE8NcIxwikzg/bgpv7XyYZCzFGG/Xoa0s9VeWtBS\n I5lVdTZauOKUCV00kk/euDK2sOdf7wqcKuyVJbdHOmNF52Izys/9eNQkopKJYNBf+Ek5\n Xk1FDjZTylubxoIHlXIeC3fgQ7rTFkZKFAYGyZtjkFjBCeZvBdSvPYeNXkT/FtuARQJQ\n GF/xDzDXDEvVfrryxX37RL5AM4LPXgWNT/JwG4pKkRFPuMlVHNyLV9pyrWH5KoR7PHzm\n KZhCzTYgDwtKBKptcrk1cs8oyRbqpJOMTyUe0KttOT9Gr6s4zGFWWGbXPx3RMZpIy56o\n 6sKA==","X-Gm-Message-State":"AOAM531CemxSPGU11dVN6jAr4wKTnmI0QBU/nll0c0tw4d9TdKKDrx2U\n COCwPF3o2CQa5/1tzIX/oARQpVlr3ZHLxiXUR3M=","X-Google-Smtp-Source":"\n ABdhPJyHVweoE6cdHPnM6pze3MF5rEKtHux8bN3HhRDDjGYnKOwK2BOtq1AJM5iuyyNrk4lj938/rhxnR8pf3qP74AM=","X-Received":"by 2002:a17:906:385b:: with SMTP id\n w27mr369073ejc.109.1606924166822;\n Wed, 02 Dec 2020 07:49:26 -0800 (PST)","MIME-Version":"1.0","References":"<20201202152611.677753-1-stefanha@redhat.com>\n <20201202152611.677753-2-stefanha@redhat.com>","In-Reply-To":"<20201202152611.677753-2-stefanha@redhat.com>","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Wed, 2 Dec 2020 19:49:15 +0400","Message-ID":"\n ","Subject":"Re: [PATCH v2 1/4] contrib/vhost-user-blk: avoid g_return_val_if()\n input validation","To":"Stefan Hajnoczi ","Content-Type":"multipart/alternative; boundary=\"0000000000002501be05b57d3030\"","Received-SPF":"pass client-ip=2a00:1450:4864:20::643;\n envelope-from=marcandre.lureau@gmail.com; helo=mail-ej1-x643.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Kevin Wolf ,\n \"open list:Block layer core\" ,\n \"Michael S. Tsirkin\" , Markus Armbruster ,\n QEMU , Coiby Xu ,\n Raphael Norwitz ,\n Gerd Hoffmann , Max Reitz ,\n Stefano Garzarella ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "}},{"id":2591054,"web_url":"http://patchwork.ozlabs.org/comment/2591054/","msgid":"","list_archive_url":null,"date":"2020-12-02T15:54:02","subject":"Re: [PATCH v2 1/4] contrib/vhost-user-blk: avoid g_return_val_if()\n input validation","submitter":{"id":79077,"url":"http://patchwork.ozlabs.org/api/people/79077/","name":"Raphael Norwitz","email":"raphael.s.norwitz@gmail.com"},"content":"On Wed, Dec 2, 2020 at 10:27 AM Stefan Hajnoczi wrote:\n>\n> Do not validate input with g_return_val_if(). This API is intended for\n> checking programming errors and is compiled out with -DG_DISABLE_CHECKS.\n>\n> Use an explicit if statement for input validation so it cannot\n> accidentally be compiled out.\n>\n> Suggested-by: Markus Armbruster \n> Signed-off-by: Stefan Hajnoczi \n\nReviewed-by: Raphael Norwitz \n\n> ---\n> contrib/vhost-user-blk/vhost-user-blk.c | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n>\n> diff --git a/contrib/vhost-user-blk/vhost-user-blk.c b/contrib/vhost-user-blk/vhost-user-blk.c\n> index dc981bf945..60e3c9ed37 100644\n> --- a/contrib/vhost-user-blk/vhost-user-blk.c\n> +++ b/contrib/vhost-user-blk/vhost-user-blk.c\n> @@ -404,7 +404,11 @@ vub_get_config(VuDev *vu_dev, uint8_t *config, uint32_t len)\n> VugDev *gdev;\n> VubDev *vdev_blk;\n>\n> - g_return_val_if_fail(len <= sizeof(struct virtio_blk_config), -1);\n> + if (len > sizeof(struct virtio_blk_config)) {\n> + fprintf(stderr, \"Invalid get_config len %u, expected <= %zu\\n\",\n> + len, sizeof(struct virtio_blk_config));\n> + return -1;\n> + }\n>\n> gdev = container_of(vu_dev, VugDev, parent);\n> vdev_blk = container_of(gdev, VubDev, parent);\n> --\n> 2.28.0\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=gmail.com","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20161025 header.b=i0mNZ5/9;\n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4CmNqC5k1zz9sRK\n\tfor ; Thu, 3 Dec 2020 02:55:51 +1100 (AEDT)","from localhost ([::1]:50982 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1kkUTs-0004Vr-Sh\n\tfor incoming@patchwork.ozlabs.org; Wed, 02 Dec 2020 10:55:48 -0500","from eggs.gnu.org ([2001:470:142:3::10]:58378)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1kkUSQ-0003RU-Ik; Wed, 02 Dec 2020 10:54:18 -0500","from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]:41052)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1kkUSO-0007eR-PA; Wed, 02 Dec 2020 10:54:18 -0500","by mail-oi1-x243.google.com with SMTP id h3so2032702oie.8;\n Wed, 02 Dec 2020 07:54:13 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=mime-version:references:in-reply-to:from:date:message-id:subject:to\n :cc; bh=E/IhTDRmDq0oztEHfJSdNz9Iti+5+yrVTCm8k0V0yjM=;\n b=i0mNZ5/9l1L0hK8glqepawF60BRmPMhTc037fMrlO4Q2r4eLLsEuZW7jWaPnPUfcKk\n O6JAC6X348JrDBWYyzFnZGUlanKrS8/ymTIYGwG0HFJiUvo4JeweMb/ztmIX/m/OWE22\n cwn+h8aVkTy8UAsDxiy5x67BYZBH7OCFfPHZEtHVbVGHjxIf+/G6wgJ3tfIoq4F7zBJ1\n ChESTOYuoqwOG7BjOkQuxP8PtFMZkt6UwJ/y0SEKzrpzZ24wwVFIuPrKf1/N2G6Ea7FY\n X9wmQ52KgxgXQByhmO04M1jlVYPwihoH32hHgZ5yBIVIr5xGt/Pf1+JUkMoEyKyfYxpK\n oy3A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:mime-version:references:in-reply-to:from:date\n :message-id:subject:to:cc;\n bh=E/IhTDRmDq0oztEHfJSdNz9Iti+5+yrVTCm8k0V0yjM=;\n b=pOzlaHQcCGA3X2knn1KnFx0h5rwVev6wPCjDQvUCDkoMBpQlTj9iAQ96V1qBRIwng8\n Z4+A062l1VbloAygJDwDK7X41f5/ctqDHVX4YEaucV8XiAZzIVbd35LQGPpnLyVF3AXX\n yyM4FDgKAjFGndLpZAgHEWCAE5uTk8qim7SaxbgL+G8I9tieSx0mwexyc/lKfnae5g/F\n oHg9w/JSEk5dUmXVqQYUvWN3VOYMGe9JCFl4kWd3ylVBH7I0sKl0Iodrd2g52evTzbZY\n BaoV+HnGEOcv8GfQbfDlgk72uCqwpmKgsl3BfUnIk1/aEuRni/OpTGiZh2rk4fSD56nU\n DYqg==","X-Gm-Message-State":"AOAM530dhmyOD8hjVX4Jl8pGNQxhEnFzLD7nfUtlsXK76LjaYfCqObdl\n tNh09CIKaP+1PQV8YSo063DuHgtST9b3OlcKs/c=","X-Google-Smtp-Source":"\n ABdhPJxXWm7v2wlihU42EZc9l73xondCmwZUn8dxIvxQPFFwXVAt1MDZIIBr91UrV7if6gOPqlrmDwXsBiR8Tp8j2ic=","X-Received":"by 2002:aca:c492:: with SMTP id u140mr2013866oif.51.1606924452818;\n Wed, 02 Dec 2020 07:54:12 -0800 (PST)","MIME-Version":"1.0","References":"<20201202152611.677753-1-stefanha@redhat.com>\n <20201202152611.677753-2-stefanha@redhat.com>","In-Reply-To":"<20201202152611.677753-2-stefanha@redhat.com>","From":"Raphael Norwitz ","Date":"Wed, 2 Dec 2020 10:54:02 -0500","Message-ID":"\n ","Subject":"Re: [PATCH v2 1/4] contrib/vhost-user-blk: avoid g_return_val_if()\n input validation","To":"Stefan Hajnoczi ","Content-Type":"text/plain; charset=\"UTF-8\"","Received-SPF":"pass client-ip=2607:f8b0:4864:20::243;\n envelope-from=raphael.s.norwitz@gmail.com; helo=mail-oi1-x243.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Kevin Wolf , qemu-block@nongnu.org,\n \"Michael S. Tsirkin\" , Markus Armbruster ,\n Coiby Xu , QEMU ,\n Max Reitz ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Gerd Hoffmann ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Raphael Norwitz ,\n Stefano Garzarella ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "}},{"id":2591057,"web_url":"http://patchwork.ozlabs.org/comment/2591057/","msgid":"","list_archive_url":null,"date":"2020-12-02T15:55:25","subject":"Re: [PATCH v2 1/4] contrib/vhost-user-blk: avoid g_return_val_if()\n input validation","submitter":{"id":74995,"url":"http://patchwork.ozlabs.org/api/people/74995/","name":"Philippe Mathieu-Daudé","email":"philmd@redhat.com"},"content":"On 12/2/20 4:26 PM, Stefan Hajnoczi wrote:\n> Do not validate input with g_return_val_if(). This API is intended for\n> checking programming errors and is compiled out with -DG_DISABLE_CHECKS.\n> \n> Use an explicit if statement for input validation so it cannot\n> accidentally be compiled out.\n> \n> Suggested-by: Markus Armbruster \n> Signed-off-by: Stefan Hajnoczi \n> ---\n> contrib/vhost-user-blk/vhost-user-blk.c | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=redhat.com","ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=NtKHRRIa;\n\tdkim-atps=neutral","relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4CmNr82X88z9sRK\n\tfor ; Thu, 3 Dec 2020 02:56:40 +1100 (AEDT)","from localhost ([::1]:51986 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1kkUUg-0005Jt-CT\n\tfor incoming@patchwork.ozlabs.org; Wed, 02 Dec 2020 10:56:38 -0500","from eggs.gnu.org ([2001:470:142:3::10]:58626)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1kkUTf-000518-U3\n for qemu-devel@nongnu.org; Wed, 02 Dec 2020 10:55:36 -0500","from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:37176)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)\n (Exim 4.90_1) (envelope-from ) id 1kkUTd-0007mf-JY\n for qemu-devel@nongnu.org; Wed, 02 Dec 2020 10:55:35 -0500","from mail-ej1-f69.google.com (mail-ej1-f69.google.com\n [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-171-rxN6xfm6Njyg6QNgQeNhGA-1; Wed, 02 Dec 2020 10:55:29 -0500","by mail-ej1-f69.google.com with SMTP id q11so3129288ejd.0\n for ; Wed, 02 Dec 2020 07:55:29 -0800 (PST)","from [192.168.1.36] (111.red-88-21-205.staticip.rima-tde.net.\n [88.21.205.111])\n by smtp.gmail.com with ESMTPSA id m2sm252849edf.27.2020.12.02.07.55.26\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 02 Dec 2020 07:55:27 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1606924533;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=8MWOQChMievO9XmxOPfrvMQhvRndxaJMToOfsTpQHT8=;\n b=NtKHRRIaekS7wL85/hD8fNC66ZjYkQQNhDH8wobdKp0ZftiHAiXx/9Qy8/lXuSFnu7BS1K\n Od4UpwE8JEEzxJ0VFHFo7e/QqhR4DIFbu54oi4QBwe7nlEnCyb1Vp8NNspe8wSlrTVayub\n mCQTOUHdv510WG56l3hp9ywnWAtRDUs=","X-MC-Unique":"rxN6xfm6Njyg6QNgQeNhGA-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:subject:to:cc:references:from:message-id:date\n :user-agent:mime-version:in-reply-to:content-language\n :content-transfer-encoding;\n bh=8MWOQChMievO9XmxOPfrvMQhvRndxaJMToOfsTpQHT8=;\n b=C0tsxdBJup/kKRWhMqqA3rJ/nNed+2HdozxKiDaGP4u4MmXmM5XLqArdvVY0enD+K9\n BeVmd0ohZxOgf1p3jcVR8tGQhiZ9rJ0F7KEa83nC5WJCb8/kuf7tMPwuYuINLzVDfybh\n +lopf+4CYtBIo7Bd27XqToZljOOnsURuuWLemC22uSunlc3VqWMHh+bxtMnxK+oxBKuV\n EeBlBYd7mYdtZ8Ctbc/b9KgA8dW+6+sHxvaqC6YHfFLFKs/IsHXXRwkDhz4UUXHjq6Oy\n paDNhMqq9nWf74FuJikT/UYrnZGFbtDpFVjr0w49e05SLxJqk/zrfKa2KZHWxzAZjM4Z\n tYpA==","X-Gm-Message-State":"AOAM532DpHN18YUgg332h0Lgz6PEOIxRmaEFgCpKoeWNzmeL18c2sfGk\n a0Mjp0rkrJ/OfsJpMCj+QRRP6fSSS4MbwEPAQw79K0AoW4nfkmWe1rLIA2344i7N7qW/CykW9io\n WZ8ButDVk+vrYYDI=","X-Received":["by 2002:aa7:cc19:: with SMTP id q25mr518388edt.290.1606924528144;\n Wed, 02 Dec 2020 07:55:28 -0800 (PST)","by 2002:aa7:cc19:: with SMTP id q25mr518365edt.290.1606924527923;\n Wed, 02 Dec 2020 07:55:27 -0800 (PST)"],"X-Google-Smtp-Source":"\n ABdhPJw35Me4ypf82fRYfVH4qop5PIiPzQGkCQEly1ir5lGrYxpbkgf3dZ+Sgq9TiDv0FJvU6GrdAw==","Subject":"Re: [PATCH v2 1/4] contrib/vhost-user-blk: avoid g_return_val_if()\n input validation","To":"Stefan Hajnoczi , qemu-devel@nongnu.org","References":"<20201202152611.677753-1-stefanha@redhat.com>\n <20201202152611.677753-2-stefanha@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"","Date":"Wed, 2 Dec 2020 16:55:25 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n Thunderbird/78.4.0","MIME-Version":"1.0","In-Reply-To":"<20201202152611.677753-2-stefanha@redhat.com>","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-35","X-Spam_score":"-3.6","X-Spam_bar":"---","X-Spam_report":"(-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.495,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001,\n RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Kevin Wolf , qemu-block@nongnu.org,\n \"Michael S. Tsirkin\" , Markus Armbruster ,\n Coiby Xu , Raphael Norwitz ,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Gerd Hoffmann ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Max Reitz , Stefano Garzarella ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "}}]