[{"id":317544,"web_url":"http://patchwork.ozlabs.org/comment/317544/","msgid":"<4F168F44.7090104@linux.vnet.ibm.com>","list_archive_url":null,"date":"2012-01-18T09:22:12","subject":"Re: [Qemu-devel] [PATCH 1/6] trace: [tracetool] Do not rebuild\n\tevent list in backend code","submitter":{"id":5445,"url":"http://patchwork.ozlabs.org/api/people/5445/","name":"Harsh Prateek Bora","email":"harsh@linux.vnet.ibm.com"},"content":"On 01/11/2012 11:35 PM, Lluís Vilanova wrote:\n> Signed-off-by: Lluís Vilanova\n> ---\n> scripts/tracetool.py | 14 +++++++-------\n> 1 files changed, 7 insertions(+), 7 deletions(-)\n>\n> diff --git a/scripts/tracetool.py b/scripts/tracetool.py\n> index 6874f66..80e5684 100755\n> --- a/scripts/tracetool.py\n> +++ b/scripts/tracetool.py\n\n[.. snip ..]\n\n> @@ -510,14 +508,16 @@ class Event(object):\n>\n> # Generator that yields Event objects given a trace-events file object\n> def read_events(fobj):\n> + res = []\n> event_num = 0\n> for line in fobj:\n> if not line.strip():\n> continue\n> if line.lstrip().startswith('#'):\n> \t continue\n> -\tyield Event(event_num, line)\n> +\tres.append(Event(event_num, line))\n> \tevent_num += 1\n> + return res\n>\n\nHi Lluis,\nThis looks really nice. I can include your fixes while addressing other \nreview comments. Shall I fold your patches with mine or do you want to \nkeep them separate?\n\nregards,\nHarsh\n\n\n\n> backend = \"\"\n> output = \"\"\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Received":["from lists.gnu.org (lists.gnu.org [140.186.70.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id 3C3D71007D2\n\tfor ;\n\tWed, 18 Jan 2012 20:22:46 +1100 (EST)","from localhost ([::1]:53576 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1RnRj6-0003DX-CZ\n\tfor incoming@patchwork.ozlabs.org; Wed, 18 Jan 2012 04:22:40 -0500","from eggs.gnu.org ([140.186.70.92]:45811)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1RnRiv-0003DO-TF\n\tfor qemu-devel@nongnu.org; Wed, 18 Jan 2012 04:22:35 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1RnRip-0006pw-T4\n\tfor qemu-devel@nongnu.org; Wed, 18 Jan 2012 04:22:29 -0500","from e28smtp09.in.ibm.com ([122.248.162.9]:56279)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1RnRip-0006pG-7U\n\tfor qemu-devel@nongnu.org; Wed, 18 Jan 2012 04:22:23 -0500","from /spool/local\n\tby e28smtp09.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tWed, 18 Jan 2012 14:52:17 +0530","from d28relay01.in.ibm.com (9.184.220.58)\n\tby e28smtp09.in.ibm.com (192.168.1.139) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 18 Jan 2012 14:52:14 +0530","from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64])\n\tby d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id\n\tq0I9MDQ24464784\n\tfor ; Wed, 18 Jan 2012 14:52:13 +0530","from d28av02.in.ibm.com (loopback [127.0.0.1])\n\tby d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id\n\tq0I9MCep025788\n\tfor ; Wed, 18 Jan 2012 20:22:13 +1100","from harshbora.in.ibm.com ([9.124.35.107])\n\tby d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id\n\tq0I9MC3B025783; Wed, 18 Jan 2012 20:22:12 +1100"],"Message-ID":"<4F168F44.7090104@linux.vnet.ibm.com>","Date":"Wed, 18 Jan 2012 14:52:12 +0530","From":"Harsh Bora ","User-Agent":"Mozilla/5.0 (X11; U; Linux x86_64; en-US;\n\trv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Thunderbird/3.0.5","MIME-Version":"1.0","To":"=?UTF-8?B?TGx1w61zIFZpbGFub3Zh?= ","References":"<20120111180504.25198.76946.stgit@ginnungagap.bsc.es>","In-Reply-To":"<20120111180504.25198.76946.stgit@ginnungagap.bsc.es>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","x-cbid":"12011809-2674-0000-0000-0000030998E4","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"122.248.162.9","Cc":"aneesh.kumar@linux.vnet.ibm.com, qemu-devel@nongnu.org,\n\tstefanha@linux.vnet.ibm.com","Subject":"Re: [Qemu-devel] [PATCH 1/6] trace: [tracetool] Do not rebuild\n\tevent list in backend code","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.14","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":317595,"web_url":"http://patchwork.ozlabs.org/comment/317595/","msgid":"<8739bdcjzb.fsf@ginnungagap.bsc.es>","list_archive_url":null,"date":"2012-01-18T11:45:28","subject":"Re: [Qemu-devel] [PATCH 1/6] trace: [tracetool] Do not rebuild\n\tevent list in backend code","submitter":{"id":9099,"url":"http://patchwork.ozlabs.org/api/people/9099/","name":"Lluís Vilanova","email":"vilanova@ac.upc.edu"},"content":"Harsh Bora writes:\n\n> On 01/11/2012 11:35 PM, Lluís Vilanova wrote:\n>> Signed-off-by: Lluís Vilanova\n>> ---\n>> scripts/tracetool.py | 14 +++++++-------\n>> 1 files changed, 7 insertions(+), 7 deletions(-)\n>> \n>> diff --git a/scripts/tracetool.py b/scripts/tracetool.py\n>> index 6874f66..80e5684 100755\n>> --- a/scripts/tracetool.py\n>> +++ b/scripts/tracetool.py\n\n> [.. snip ..]\n\n>> @@ -510,14 +508,16 @@ class Event(object):\n>> \n>> # Generator that yields Event objects given a trace-events file object\n>> def read_events(fobj):\n>> + res = []\n>> event_num = 0\n>> for line in fobj:\n>> if not line.strip():\n>> continue\n>> if line.lstrip().startswith('#'):\n>> continue\n>> -\tyield Event(event_num, line)\n>> +\tres.append(Event(event_num, line))\n>> event_num += 1\n>> + return res\n>> \n\n> Hi Lluis,\n> This looks really nice. I can include your fixes while addressing other review\n> comments. Shall I fold your patches with mine or do you want to keep them\n> separate?\n\nWhatever works best for you.\n\n\nLluis","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Received":["from lists.gnu.org (lists.gnu.org [140.186.70.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id F1EEEB6EE7\n\tfor ;\n\tWed, 18 Jan 2012 22:45:59 +1100 (EST)","from localhost ([::1]:42677 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1RnTxk-0004rC-Uy\n\tfor incoming@patchwork.ozlabs.org; Wed, 18 Jan 2012 06:45:56 -0500","from eggs.gnu.org ([140.186.70.92]:35954)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1RnTxa-0004qv-GV\n\tfor qemu-devel@nongnu.org; Wed, 18 Jan 2012 06:45:52 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1RnTxU-0007ML-OL\n\tfor qemu-devel@nongnu.org; Wed, 18 Jan 2012 06:45:46 -0500","from gw.ac.upc.edu ([147.83.30.3]:43648)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1RnTxU-0007Lv-Da\n\tfor qemu-devel@nongnu.org; Wed, 18 Jan 2012 06:45:40 -0500","from localhost (unknown [10.8.0.14])\n\tby gw.ac.upc.edu (Postfix) with ESMTP id B166B6B0310;\n\tWed, 18 Jan 2012 12:45:33 +0100 (CET)"],"From":"=?utf-8?Q?Llu=C3=ADs_Vilanova?= ","To":"Harsh Bora ","References":"<20120111180504.25198.76946.stgit@ginnungagap.bsc.es>\n\t<4F168F44.7090104@linux.vnet.ibm.com>","Date":"Wed, 18 Jan 2012 12:45:28 +0100","In-Reply-To":"<4F168F44.7090104@linux.vnet.ibm.com> (Harsh Bora's message of\n\t\"Wed, 18 Jan 2012 14:52:12 +0530\")","Message-ID":"<8739bdcjzb.fsf@ginnungagap.bsc.es>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)","X-Received-From":"147.83.30.3","Cc":"aneesh.kumar@linux.vnet.ibm.com, qemu-devel@nongnu.org,\n\tstefanha@linux.vnet.ibm.com","Subject":"Re: [Qemu-devel] [PATCH 1/6] trace: [tracetool] Do not rebuild\n\tevent list in backend code","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.14","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":317600,"web_url":"http://patchwork.ozlabs.org/comment/317600/","msgid":"<87ehuxb4qc.fsf@ginnungagap.bsc.es>","list_archive_url":null,"date":"2012-01-18T12:00:11","subject":"Re: [Qemu-devel] [PATCH 1/6] trace: [tracetool] Do not rebuild\n\tevent list in backend code","submitter":{"id":9099,"url":"http://patchwork.ozlabs.org/api/people/9099/","name":"Lluís Vilanova","email":"vilanova@ac.upc.edu"},"content":"Lluís Vilanova writes:\n\n> Harsh Bora writes:\n\n>> Hi Lluis,\n>> This looks really nice. I can include your fixes while addressing other review\n>> comments. Shall I fold your patches with mine or do you want to keep them\n>> separate?\n\n> Whatever works best for you.\n\nBTW, I did some more changes, but didn't care to separate them into more\npatches, so maybe I'll send you a few more on the next version.\n\n\nLluis","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Received":["from lists.gnu.org (lists.gnu.org [140.186.70.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id 94B47B6EF3\n\tfor ;\n\tWed, 18 Jan 2012 23:00:43 +1100 (EST)","from localhost ([::1]:57799 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1RnUBz-0000vr-2Q\n\tfor incoming@patchwork.ozlabs.org; Wed, 18 Jan 2012 07:00:39 -0500","from eggs.gnu.org ([140.186.70.92]:41968)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1RnUBl-0000rW-Du\n\tfor qemu-devel@nongnu.org; Wed, 18 Jan 2012 07:00:33 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1RnUBf-0002ds-S5\n\tfor qemu-devel@nongnu.org; Wed, 18 Jan 2012 07:00:25 -0500","from gw.ac.upc.edu ([147.83.30.3]:51152)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1RnUBf-0002dg-LB\n\tfor qemu-devel@nongnu.org; Wed, 18 Jan 2012 07:00:19 -0500","from localhost (unknown [10.8.0.14])\n\tby gw.ac.upc.edu (Postfix) with ESMTP id A776A6B024D;\n\tWed, 18 Jan 2012 13:00:16 +0100 (CET)"],"From":"=?utf-8?Q?Llu=C3=ADs_Vilanova?= ","To":"Harsh Bora ","References":"<20120111180504.25198.76946.stgit@ginnungagap.bsc.es>\n\t<4F168F44.7090104@linux.vnet.ibm.com>\n\t<8739bdcjzb.fsf@ginnungagap.bsc.es>","Date":"Wed, 18 Jan 2012 13:00:11 +0100","In-Reply-To":"<8739bdcjzb.fsf@ginnungagap.bsc.es> (=?utf-8?Q?=22Llu=C3=ADs?=\n\tVilanova\"'s message of \"Wed, 18 Jan 2012 12:45:28 +0100\")","Message-ID":"<87ehuxb4qc.fsf@ginnungagap.bsc.es>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)","X-Received-From":"147.83.30.3","Cc":"aneesh.kumar@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com,\n\tqemu-devel@nongnu.org","Subject":"Re: [Qemu-devel] [PATCH 1/6] trace: [tracetool] Do not rebuild\n\tevent list in backend code","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.14","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]