[{"id":2456276,"web_url":"http://patchwork.ozlabs.org/comment/2456276/","msgid":"<9ae6be08-0012-a393-b893-00a68d242350@redhat.com>","list_archive_url":null,"date":"2020-06-10T19:37:27","subject":"Re: [PATCH v8 32/34] qcow2: Allow preallocation and backing files if\n extended_l2 is set","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 6/10/20 10:03 AM, Alberto Garcia wrote:\n> Traditional qcow2 images don't allow preallocation if a backing file\n> is set. This is because once a cluster is allocated there is no way to\n> tell that its data should be read from the backing file.\n> \n> Extended L2 entries have individual allocation bits for each\n> subcluster, and therefore it is perfectly possible to have an\n> allocated cluster with all its subclusters unallocated.\n> \n> Signed-off-by: Alberto Garcia \n> ---\n> block/qcow2.c | 7 ++++---\n> tests/qemu-iotests/206.out | 2 +-\n> 2 files changed, 5 insertions(+), 4 deletions(-)\n\nReviewed-by: Eric Blake ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","ozlabs.org;\n dmarc=fail (p=none dis=none) header.from=redhat.com","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Kt0SVs2+;\n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49hy2k21p5z9sRN\n\tfor ; Thu, 11 Jun 2020 05:38:20 +1000 (AEST)","from localhost ([::1]:55546 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1jj6YD-00013h-8Q\n\tfor incoming@patchwork.ozlabs.org; Wed, 10 Jun 2020 15:38:17 -0400","from eggs.gnu.org ([2001:470:142:3::10]:35400)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1jj6Xf-00012l-6u\n for qemu-devel@nongnu.org; Wed, 10 Jun 2020 15:37:43 -0400","from us-smtp-2.mimecast.com ([207.211.31.81]:39304\n helo=us-smtp-1.mimecast.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)\n (Exim 4.90_1) (envelope-from ) id 1jj6Xe-00049e-Jx\n for qemu-devel@nongnu.org; Wed, 10 Jun 2020 15:37:42 -0400","from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-9-owXnr2tgNeeE2phYxg1BKQ-1; Wed, 10 Jun 2020 15:37:34 -0400","from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com\n [10.5.11.22])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D9C241009615;\n Wed, 10 Jun 2020 19:37:32 +0000 (UTC)","from [10.3.113.22] (ovpn-113-22.phx2.redhat.com [10.3.113.22])\n by smtp.corp.redhat.com (Postfix) with ESMTPS id EC9C710013D0;\n Wed, 10 Jun 2020 19:37:31 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1591817861;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=fMxgD9A4wMxaAWV1dyowaaz+jh05wtRoN5Veaux+DrE=;\n b=Kt0SVs2+sxRaWaxrkE7xKbgva34s/6LeJMc9JM+rtW02R2MDkygDjRqo5q+lI428ExuYeb\n vTKILrCAdUCVT5HSwVS02qiDWaZ57JBJtmfpo9k3OuYgTdhSdx0ygbEYmWc83XKrdqoyDk\n YdyzF2ZWpuiuUOQq7NE9/zBJvfTELsI=","X-MC-Unique":"owXnr2tgNeeE2phYxg1BKQ-1","Subject":"Re: [PATCH v8 32/34] qcow2: Allow preallocation and backing files if\n extended_l2 is set","To":"Alberto Garcia , qemu-devel@nongnu.org","References":"\n <7720a7da26c206570bc5aa7ee6a9cd9124438778.1591801197.git.berto@igalia.com>","From":"Eric Blake ","Organization":"Red Hat, Inc.","Message-ID":"<9ae6be08-0012-a393-b893-00a68d242350@redhat.com>","Date":"Wed, 10 Jun 2020 14:37:27 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n Thunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"\n <7720a7da26c206570bc5aa7ee6a9cd9124438778.1591801197.git.berto@igalia.com>","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.84 on 10.5.11.22","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=207.211.31.81; envelope-from=eblake@redhat.com;\n helo=us-smtp-1.mimecast.com","X-detected-operating-system":"by eggs.gnu.org: First seen = 2020/06/10 15:37:41","X-ACL-Warn":"Detected OS = Linux 2.2.x-3.x [generic] [fuzzy]","X-Spam_score_int":"-30","X-Spam_score":"-3.1","X-Spam_bar":"---","X-Spam_report":"(-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Kevin Wolf , Derek Su ,\n Vladimir Sementsov-Ogievskiy ,\n qemu-block@nongnu.org,\n Max Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "}}]