[{"id":2408739,"web_url":"http://patchwork.ozlabs.org/comment/2408739/","msgid":"<20200416091438.GA2167633@dell>","list_archive_url":null,"date":"2020-04-16T09:14:38","subject":"Re: [PATCH v12 5/6] rtc: mt6397: Add support for the MediaTek MT6358\n RTC","submitter":{"id":12720,"url":"http://patchwork.ozlabs.org/api/people/12720/","name":"Lee Jones","email":"lee.jones@linaro.org"},"content":"On Wed, 08 Apr 2020, Hsin-Hsiung Wang wrote:\n\n> From: Ran Bi \n> \n> This add support for the MediaTek MT6358 RTC. Driver using\n> compatible data to store different RTC_WRTGR address offset.\n> This replace RTC_WRTGR to RTC_WRTGR_MT6323 in mt6323-poweroff\n> driver which only needed by armv7 CPU without ATF.\n> \n> Reviewed-by: Nicolas Boichat \n> Reviewed-by: Yingjoe Chen \n> Acked-by: Alexandre Belloni \n> Acked-by: Sebastian Reichel \n> Signed-off-by: Ran Bi \n> Signed-off-by: Hsin-Hsiung Wang \n\nPlease place these in chronological order. They should provide some\nhistory, rather than a unordered slab list of random sign-offs.\n\n> ---\n> drivers/power/reset/mt6323-poweroff.c | 2 +-\n> drivers/rtc/rtc-mt6397.c | 18 +++++++++++++++---\n> include/linux/mfd/mt6397/rtc.h | 9 ++++++++-\n> 3 files changed, 24 insertions(+), 5 deletions(-)\n\n[...]\n\n> diff --git a/include/linux/mfd/mt6397/rtc.h b/include/linux/mfd/mt6397/rtc.h\n> index 7dfb63b..6200f3b 100644\n> --- a/include/linux/mfd/mt6397/rtc.h\n> +++ b/include/linux/mfd/mt6397/rtc.h\n> @@ -18,7 +18,9 @@\n> #define RTC_BBPU_CBUSY BIT(6)\n> #define RTC_BBPU_KEY (0x43 << 8)\n> \n> -#define RTC_WRTGR 0x003c\n> +#define RTC_WRTGR_MT6358 0x3a\n> +#define RTC_WRTGR_MT6397 0x3c\n\nWhy remove the leading 00's?\n\nThese are now different to the other regs defined in this header.\n\n> +#define RTC_WRTGR_MT6323 RTC_WRTGR_MT6397\n> \n> #define RTC_IRQ_STA 0x0002\n\nLike here for instance --^\n\n> #define RTC_IRQ_STA_AL BIT(0)\n> @@ -65,6 +67,10 @@\n> #define MTK_RTC_POLL_DELAY_US 10\n> #define MTK_RTC_POLL_TIMEOUT (jiffies_to_usecs(HZ))\n> \n> +struct mtk_rtc_data {\n> +\tu32 wrtgr;\n> +};\n> +\n> struct mt6397_rtc {\n> \tstruct device *dev;\n> \tstruct rtc_device *rtc_dev;\n> @@ -74,6 +80,7 @@ struct mt6397_rtc {\n> \tstruct regmap *regmap;\n> \tint irq;\n> \tu32 addr_base;\n> +\tconst struct mtk_rtc_data *data;\n> };\n> \n> #endif /* _LINUX_MFD_MT6397_RTC_H_ */","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=23.128.96.18; helo=vger.kernel.org;\n envelope-from=linux-rtc-owner@vger.kernel.org; receiver=)","ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linaro.org","ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=h79u+RID;\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [23.128.96.18])\n\tby ozlabs.org (Postfix) with ESMTP id 492tnv1Mcbz9sRN\n\tfor ; Thu, 16 Apr 2020 19:14:11 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S2441405AbgDPJOE (ORCPT );\n Thu, 16 Apr 2020 05:14:04 -0400","from lindbergh.monkeyblade.net ([23.128.96.19]:44234 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-FAIL-OK-FAIL)\n by vger.kernel.org with ESMTP id S2503691AbgDPJNl (ORCPT\n ); Thu, 16 Apr 2020 05:13:41 -0400","from mail-wr1-x442.google.com (mail-wr1-x442.google.com\n [IPv6:2a00:1450:4864:20::442])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0779FC061A0C\n for ; Thu, 16 Apr 2020 02:13:40 -0700 (PDT)","by mail-wr1-x442.google.com with SMTP id a25so3983677wrd.0\n for ; Thu, 16 Apr 2020 02:13:39 -0700 (PDT)","from dell ([95.149.164.124])\n by smtp.gmail.com with ESMTPSA id\n b4sm21818100wrv.42.2020.04.16.02.13.37\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 16 Apr 2020 02:13:37 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google;\n h=date:from:to:cc:subject:message-id:references:mime-version\n :content-disposition:content-transfer-encoding:in-reply-to;\n bh=AyKKf2vu9ets5qQ05mKeEx+H3HJdeMhyf7LDU6EPmvg=;\n b=h79u+RID/Tw8EjEr7PzOeW67I5riBs6/JV027laFW3VtXjta4zpbT4owqSzSYadzXI\n UooqVXoXGL1A8oAByZdeXkLIJKTO01hEePh4C5fzehOrUdnbfQ1pEs9kiyqYoA/KX+JH\n 1qMRtfcJSHijAK2OGm7YZmCKbHczogdEeoL22Pw+vKfPbVBWs4ymX9eJohxZQNiYHrt4\n ev6JtRiaXOHosoQtEI6ZEvp9wcTaGhtxQIVftu4d8viJsibPKXtJvkzZsh+8sFdMla2G\n mZm9iRn+HrGu+Q6eydYFxopmA1r46j4zcJCjdDXVsTQRSFhEB8VLG7f5460IgaYT+mVk\n jnYA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:date:from:to:cc:subject:message-id:references\n :mime-version:content-disposition:content-transfer-encoding\n :in-reply-to;\n bh=AyKKf2vu9ets5qQ05mKeEx+H3HJdeMhyf7LDU6EPmvg=;\n b=U915G9cFq4bMbCq8efwZJJ8xwW5DFNA0HBAabWNbKNpeYlmZKxQdRDmuMPx6lAoyqa\n apC13Jt+3SjVnsEb1MN+GxE+OCpO7nutlHXt30KgclrEEHLzd1w6MmTtEhJP4slhXz9I\n xIqYC1iIHtt8TksoGB+X9UycowevkdyFmxSGOSiis8bEsbK5DvMpo0iXli7iNQlZ7+sA\n BQXH9ZB12liIsMJkQy5JkWrvDEEMdBuh2NyhGxfmWBI88iGFrVGTZ3DgBjMiumMX6Vij\n tndaiK2cYEQroBT3EUDNhe05ZdqV9t4VlVojb7MHcMbiVcuHjjdp+6tOKfrnoiM71OPx\n sX9A==","X-Gm-Message-State":"AGi0PuYuTnbwuPLUYcDP1GG8HF6jNnENSz9GLyVKeW+VtsrdGHPng+/d\n uktBCmXPW7SWqqLZAsNNf3O0Jg==","X-Google-Smtp-Source":"\n APiQypL6P5SXhhJYLq4NR+TEKXmQzYaSqAHnJaTlLyokBRKxP3wo+p/iZ1+/LSCv7ZJBVaCmcdxoSg==","X-Received":"by 2002:a5d:68cf:: with SMTP id p15mr4801408wrw.139.1587028418328;\n Thu, 16 Apr 2020 02:13:38 -0700 (PDT)","Date":"Thu, 16 Apr 2020 10:14:38 +0100","From":"Lee Jones ","To":"Hsin-Hsiung Wang ","Cc":"Rob Herring ,\n Matthias Brugger ,\n Alexandre Belloni ,\n Nicolas Boichat ,\n Mark Rutland ,\n Sean Wang ,\n Sebastian Reichel ,\n Eddie Huang ,\n Alessandro Zummo ,\n Kate Stewart ,\n Richard Fontana ,\n Frank Wunderlich ,\n Josef Friedl ,\n Thomas Gleixner ,\n Ran Bi , devicetree@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org,\n linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,\n linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org,\n srv_heupstream@mediatek.com","Subject":"Re: [PATCH v12 5/6] rtc: mt6397: Add support for the MediaTek MT6358\n RTC","Message-ID":"<20200416091438.GA2167633@dell>","References":"<1586333531-21641-1-git-send-email-hsin-hsiung.wang@mediatek.com>\n <1586333531-21641-6-git-send-email-hsin-hsiung.wang@mediatek.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<1586333531-21641-6-git-send-email-hsin-hsiung.wang@mediatek.com>","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"}},{"id":2409607,"web_url":"http://patchwork.ozlabs.org/comment/2409607/","msgid":"<1587112169.12875.2.camel@mhfsdcap03>","list_archive_url":null,"date":"2020-04-17T08:29:29","subject":"Re: [PATCH v12 5/6] rtc: mt6397: Add support for the MediaTek\n MT6358 RTC","submitter":{"id":76179,"url":"http://patchwork.ozlabs.org/api/people/76179/","name":"Ran Bi","email":"ran.bi@mediatek.com"},"content":"On Thu, 2020-04-16 at 10:14 +0100, Lee Jones wrote:\n> On Wed, 08 Apr 2020, Hsin-Hsiung Wang wrote:\n> \n> > From: Ran Bi \n> > \n> > This add support for the MediaTek MT6358 RTC. Driver using\n> > compatible data to store different RTC_WRTGR address offset.\n> > This replace RTC_WRTGR to RTC_WRTGR_MT6323 in mt6323-poweroff\n> > driver which only needed by armv7 CPU without ATF.\n> > \n> > Reviewed-by: Nicolas Boichat \n> > Reviewed-by: Yingjoe Chen \n> > Acked-by: Alexandre Belloni \n> > Acked-by: Sebastian Reichel \n> > Signed-off-by: Ran Bi \n> > Signed-off-by: Hsin-Hsiung Wang \n> \n> Please place these in chronological order. They should provide some\n> history, rather than a unordered slab list of random sign-offs.\n> \n\nI suppose that you mean the order should be like below, right?\nReviewed-by: Yingjoe Chen \nAcked-by: Sebastian Reichel \nAcked-by: Alexandre Belloni \nReviewed-by: Nicolas Boichat \nSigned-off-by: Hsin-Hsiung Wang \nSigned-off-by: Ran Bi \n\n> > ---\n> > drivers/power/reset/mt6323-poweroff.c | 2 +-\n> > drivers/rtc/rtc-mt6397.c | 18 +++++++++++++++---\n> > include/linux/mfd/mt6397/rtc.h | 9 ++++++++-\n> > 3 files changed, 24 insertions(+), 5 deletions(-)\n> \n> [...]\n> \n> > diff --git a/include/linux/mfd/mt6397/rtc.h b/include/linux/mfd/mt6397/rtc.h\n> > index 7dfb63b..6200f3b 100644\n> > --- a/include/linux/mfd/mt6397/rtc.h\n> > +++ b/include/linux/mfd/mt6397/rtc.h\n> > @@ -18,7 +18,9 @@\n> > #define RTC_BBPU_CBUSY BIT(6)\n> > #define RTC_BBPU_KEY (0x43 << 8)\n> > \n> > -#define RTC_WRTGR 0x003c\n> > +#define RTC_WRTGR_MT6358 0x3a\n> > +#define RTC_WRTGR_MT6397 0x3c\n> \n> Why remove the leading 00's?\n> \n> These are now different to the other regs defined in this header.\n> \n\nI will fix this at next patch.\n\n> > +#define RTC_WRTGR_MT6323 RTC_WRTGR_MT6397\n> > \n> > #define RTC_IRQ_STA 0x0002\n> \n> Like here for instance --^\n> \n> > #define RTC_IRQ_STA_AL BIT(0)\n> > @@ -65,6 +67,10 @@\n> > #define MTK_RTC_POLL_DELAY_US 10\n> > #define MTK_RTC_POLL_TIMEOUT (jiffies_to_usecs(HZ))\n> > \n> > +struct mtk_rtc_data {\n> > +\tu32 wrtgr;\n> > +};\n> > +\n> > struct mt6397_rtc {\n> > \tstruct device *dev;\n> > \tstruct rtc_device *rtc_dev;\n> > @@ -74,6 +80,7 @@ struct mt6397_rtc {\n> > \tstruct regmap *regmap;\n> > \tint irq;\n> > \tu32 addr_base;\n> > +\tconst struct mtk_rtc_data *data;\n> > };\n> > \n> > #endif /* _LINUX_MFD_MT6397_RTC_H_ */\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=23.128.96.18; helo=vger.kernel.org;\n envelope-from=linux-rtc-owner@vger.kernel.org; receiver=)","ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=mediatek.com","ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=mediatek.com header.i=@mediatek.com header.a=rsa-sha256\n header.s=dk header.b=jqxe+4/b;\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [23.128.96.18])\n\tby ozlabs.org (Postfix) with ESMTP id 493TtY42S3z9sSM\n\tfor ; Fri, 17 Apr 2020 18:35:17 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S1729812AbgDQIfO (ORCPT );\n Fri, 17 Apr 2020 04:35:14 -0400","from mailgw02.mediatek.com ([210.61.82.184]:45343 \"EHLO\n mailgw02.mediatek.com\" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org\n with ESMTP id S1729747AbgDQIfN (ORCPT\n ); Fri, 17 Apr 2020 04:35:13 -0400","from mtkcas08.mediatek.inc [(172.21.101.126)] by\n mailgw02.mediatek.com\n (envelope-from )\n (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS)\n with ESMTP id 1581973651; Fri, 17 Apr 2020 16:29:59 +0800","from MTKCAS36.mediatek.inc (172.27.4.186) by mtkmbs01n1.mediatek.inc\n (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 17 Apr\n 2020 16:29:57 +0800","from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc\n (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Fri, 17 Apr 2020 16:29:54 +0800"],"X-UUID":["d8d986a5e78941bebdc08bacc8008b68-20200417","d8d986a5e78941bebdc08bacc8008b68-20200417"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n d=mediatek.com; s=dk;\n h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID;\n bh=I69XZhCGCT6PHGSQl+2FE2AZcxuaF8LTOGfpLh230qU=;\n b=jqxe+4/bHncovWXXVhvU0o0AsCAmL08SKhpRxzft9v+YWGHN/hqpG3sa/ED5QB1DEXD8Fa0Ohs2H8CN1vFBRvAsDyLaVWgjTsP9ICb8I4SgTDZ79Id48q79qrOsA7x7tXpdY4KXhg1Oa+5xAkUI8ugCyReHEstiSE66a9v2a/7k=;","Message-ID":"<1587112169.12875.2.camel@mhfsdcap03>","Subject":"Re: [PATCH v12 5/6] rtc: mt6397: Add support for the MediaTek\n MT6358 RTC","From":"Ran Bi ","To":"Lee Jones ","CC":"Hsin-Hsiung Wang ,\n Rob Herring ,\n Matthias Brugger ,\n \"Alexandre Belloni\" ,\n Nicolas Boichat ,\n Mark Rutland ,\n Sean Wang ,\n Sebastian Reichel ,\n Eddie Huang ,\n Alessandro Zummo ,\n \"Kate Stewart\" ,\n Richard Fontana ,\n Frank Wunderlich ,\n \"Josef Friedl\" ,\n Thomas Gleixner ,\n ,\n ,\n ,\n , ,\n , ","Date":"Fri, 17 Apr 2020 16:29:29 +0800","In-Reply-To":"<20200416091438.GA2167633@dell>","References":"<1586333531-21641-1-git-send-email-hsin-hsiung.wang@mediatek.com>\n <1586333531-21641-6-git-send-email-hsin-hsiung.wang@mediatek.com>\n <20200416091438.GA2167633@dell>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.10.4-0ubuntu2 ","MIME-Version":"1.0","X-MTK":"N","Content-Transfer-Encoding":"base64","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"}},{"id":2409619,"web_url":"http://patchwork.ozlabs.org/comment/2409619/","msgid":"<1587113392.13323.3.camel@mhfsdcap03>","list_archive_url":null,"date":"2020-04-17T08:49:52","subject":"Re: [PATCH v12 5/6] rtc: mt6397: Add support for the MediaTek\n MT6358 RTC","submitter":{"id":76179,"url":"http://patchwork.ozlabs.org/api/people/76179/","name":"Ran Bi","email":"ran.bi@mediatek.com"},"content":"On Fri, 2020-04-17 at 16:29 +0800, Ran Bi wrote:\n> On Thu, 2020-04-16 at 10:14 +0100, Lee Jones wrote:\n> > On Wed, 08 Apr 2020, Hsin-Hsiung Wang wrote:\n> > \n> > > From: Ran Bi \n> > > \n> > > This add support for the MediaTek MT6358 RTC. Driver using\n> > > compatible data to store different RTC_WRTGR address offset.\n> > > This replace RTC_WRTGR to RTC_WRTGR_MT6323 in mt6323-poweroff\n> > > driver which only needed by armv7 CPU without ATF.\n> > > \n> > > Reviewed-by: Nicolas Boichat \n> > > Reviewed-by: Yingjoe Chen \n> > > Acked-by: Alexandre Belloni \n> > > Acked-by: Sebastian Reichel \n> > > Signed-off-by: Ran Bi \n> > > Signed-off-by: Hsin-Hsiung Wang \n> > \n> > Please place these in chronological order. They should provide some\n> > history, rather than a unordered slab list of random sign-offs.\n> > \n> \n> I suppose that you mean the order should be like below, right?\n> Reviewed-by: Yingjoe Chen \n> Acked-by: Sebastian Reichel \n> Acked-by: Alexandre Belloni \n> Reviewed-by: Nicolas Boichat \n> Signed-off-by: Hsin-Hsiung Wang \n> Signed-off-by: Ran Bi \n> \n\nCorrection, I think following is the correct chronological order:\nSigned-off-by: Ran Bi \nSigned-off-by: Hsin-Hsiung Wang \nReviewed-by: Nicolas Boichat \nAcked-by: Alexandre Belloni \nAcked-by: Sebastian Reichel \nReviewed-by: Yingjoe Chen \n\n> > > ---\n> > > drivers/power/reset/mt6323-poweroff.c | 2 +-\n> > > drivers/rtc/rtc-mt6397.c | 18 +++++++++++++++---\n> > > include/linux/mfd/mt6397/rtc.h | 9 ++++++++-\n> > > 3 files changed, 24 insertions(+), 5 deletions(-)\n> > \n> > [...]\n> > \n> > > diff --git a/include/linux/mfd/mt6397/rtc.h b/include/linux/mfd/mt6397/rtc.h\n> > > index 7dfb63b..6200f3b 100644\n> > > --- a/include/linux/mfd/mt6397/rtc.h\n> > > +++ b/include/linux/mfd/mt6397/rtc.h\n> > > @@ -18,7 +18,9 @@\n> > > #define RTC_BBPU_CBUSY BIT(6)\n> > > #define RTC_BBPU_KEY (0x43 << 8)\n> > > \n> > > -#define RTC_WRTGR 0x003c\n> > > +#define RTC_WRTGR_MT6358 0x3a\n> > > +#define RTC_WRTGR_MT6397 0x3c\n> > \n> > Why remove the leading 00's?\n> > \n> > These are now different to the other regs defined in this header.\n> > \n> \n> I will fix this at next patch.\n> \n> > > +#define RTC_WRTGR_MT6323 RTC_WRTGR_MT6397\n> > > \n> > > #define RTC_IRQ_STA 0x0002\n> > \n> > Like here for instance --^\n> > \n> > > #define RTC_IRQ_STA_AL BIT(0)\n> > > @@ -65,6 +67,10 @@\n> > > #define MTK_RTC_POLL_DELAY_US 10\n> > > #define MTK_RTC_POLL_TIMEOUT (jiffies_to_usecs(HZ))\n> > > \n> > > +struct mtk_rtc_data {\n> > > +\tu32 wrtgr;\n> > > +};\n> > > +\n> > > struct mt6397_rtc {\n> > > \tstruct device *dev;\n> > > \tstruct rtc_device *rtc_dev;\n> > > @@ -74,6 +80,7 @@ struct mt6397_rtc {\n> > > \tstruct regmap *regmap;\n> > > \tint irq;\n> > > \tu32 addr_base;\n> > > +\tconst struct mtk_rtc_data *data;\n> > > };\n> > > \n> > > #endif /* _LINUX_MFD_MT6397_RTC_H_ */\n> > \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=23.128.96.18; helo=vger.kernel.org;\n envelope-from=linux-rtc-owner@vger.kernel.org; receiver=)","ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=mediatek.com","ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=mediatek.com header.i=@mediatek.com header.a=rsa-sha256\n header.s=dk header.b=dWjdb0Qq;\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [23.128.96.18])\n\tby ozlabs.org (Postfix) with ESMTP id 493VDb63npz9sSY\n\tfor ; Fri, 17 Apr 2020 18:50:55 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S1729954AbgDQIu2 (ORCPT );\n Fri, 17 Apr 2020 04:50:28 -0400","from mailgw01.mediatek.com ([210.61.82.183]:50554 \"EHLO\n mailgw01.mediatek.com\" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org\n with ESMTP id S1729930AbgDQIu1 (ORCPT\n ); Fri, 17 Apr 2020 04:50:27 -0400","from mtkcas11.mediatek.inc [(172.21.101.40)] by\n mailgw01.mediatek.com\n (envelope-from )\n (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS)\n with ESMTP id 1460347295; Fri, 17 Apr 2020 16:50:21 +0800","from MTKCAS36.mediatek.inc (172.27.4.186) by mtkmbs05n1.mediatek.inc\n (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 17 Apr\n 2020 16:50:19 +0800","from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc\n (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Fri, 17 Apr 2020 16:50:16 +0800"],"X-UUID":["19c67206a4314b779958374de9d17d4c-20200417","19c67206a4314b779958374de9d17d4c-20200417"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n d=mediatek.com; s=dk;\n h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID;\n bh=CvLwXNbZt4YLZj84U8Z1qWNABI7ku9CPPMrN1RBYWo4=;\n b=dWjdb0Qq2FqWB9CgJutYv88Jk3cuRB6e7sGPsY1SmMa/L7HZ0B096+OwuUx1o+YirKE6alxIjAWXolVuUSYA3ZQ9EbzTXX5cjHVKXRwehlTq4cIHZTnxIyKBvdN2KghdETXHmmleq3bjuMUY6iPMfYLnbYUrZxvW2pQGWhyNoOU=;","Message-ID":"<1587113392.13323.3.camel@mhfsdcap03>","Subject":"Re: [PATCH v12 5/6] rtc: mt6397: Add support for the MediaTek\n MT6358 RTC","From":"Ran Bi ","To":"Lee Jones ","CC":"Hsin-Hsiung Wang ,\n Rob Herring ,\n Matthias Brugger ,\n \"Alexandre Belloni\" ,\n Nicolas Boichat ,\n Mark Rutland ,\n Sean Wang ,\n Sebastian Reichel ,\n Eddie Huang ,\n Alessandro Zummo ,\n \"Kate Stewart\" ,\n Richard Fontana ,\n Frank Wunderlich ,\n \"Josef Friedl\" ,\n Thomas Gleixner ,\n ,\n ,\n ,\n , ,\n , ","Date":"Fri, 17 Apr 2020 16:49:52 +0800","In-Reply-To":"<1587112169.12875.2.camel@mhfsdcap03>","References":"<1586333531-21641-1-git-send-email-hsin-hsiung.wang@mediatek.com>\n <1586333531-21641-6-git-send-email-hsin-hsiung.wang@mediatek.com>\n <20200416091438.GA2167633@dell> <1587112169.12875.2.camel@mhfsdcap03>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.10.4-0ubuntu2 ","MIME-Version":"1.0","X-MTK":"N","Content-Transfer-Encoding":"base64","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"}},{"id":2411126,"web_url":"http://patchwork.ozlabs.org/comment/2411126/","msgid":"<20200420073639.GL3737@dell>","list_archive_url":null,"date":"2020-04-20T07:36:39","subject":"Re: [PATCH v12 5/6] rtc: mt6397: Add support for the MediaTek MT6358\n RTC","submitter":{"id":12720,"url":"http://patchwork.ozlabs.org/api/people/12720/","name":"Lee Jones","email":"lee.jones@linaro.org"},"content":"On Fri, 17 Apr 2020, Ran Bi wrote:\n\n> On Thu, 2020-04-16 at 10:14 +0100, Lee Jones wrote:\n> > On Wed, 08 Apr 2020, Hsin-Hsiung Wang wrote:\n> > \n> > > From: Ran Bi \n> > > \n> > > This add support for the MediaTek MT6358 RTC. Driver using\n> > > compatible data to store different RTC_WRTGR address offset.\n> > > This replace RTC_WRTGR to RTC_WRTGR_MT6323 in mt6323-poweroff\n> > > driver which only needed by armv7 CPU without ATF.\n> > > \n> > > Reviewed-by: Nicolas Boichat \n> > > Reviewed-by: Yingjoe Chen \n> > > Acked-by: Alexandre Belloni \n> > > Acked-by: Sebastian Reichel \n> > > Signed-off-by: Ran Bi \n> > > Signed-off-by: Hsin-Hsiung Wang \n> > \n> > Please place these in chronological order. They should provide some\n> > history, rather than a unordered slab list of random sign-offs.\n> > \n> \n> I suppose that you mean the order should be like below, right?\n> Reviewed-by: Yingjoe Chen \n> Acked-by: Sebastian Reichel \n> Acked-by: Alexandre Belloni \n> Reviewed-by: Nicolas Boichat \n> Signed-off-by: Hsin-Hsiung Wang \n> Signed-off-by: Ran Bi \n\nThis would imply that it was reviewed before it was written, which\nwould subsequently imply time-travel, so I suggest not.\n\nAuthor(s)\nReview(s)/Acks(s)/Tested(s) /* ideally in the order they were received */\nSub-maintainer sign-off /* if applicable */\nMaintainer sign-off\n\n> > > ---\n> > > drivers/power/reset/mt6323-poweroff.c | 2 +-\n> > > drivers/rtc/rtc-mt6397.c | 18 +++++++++++++++---\n> > > include/linux/mfd/mt6397/rtc.h | 9 ++++++++-\n> > > 3 files changed, 24 insertions(+), 5 deletions(-)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=23.128.96.18; helo=vger.kernel.org;\n envelope-from=linux-rtc-owner@vger.kernel.org; receiver=)","ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linaro.org","ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=st0iZapP;\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [23.128.96.18])\n\tby ozlabs.org (Postfix) with ESMTP id 495JRj1Yxtz9sSw\n\tfor ; Mon, 20 Apr 2020 17:36:49 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S1726091AbgDTHgo (ORCPT );\n Mon, 20 Apr 2020 03:36:44 -0400","from lindbergh.monkeyblade.net ([23.128.96.19]:41972 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-FAIL-OK-FAIL)\n by vger.kernel.org with ESMTP id S1726039AbgDTHgn (ORCPT\n ); Mon, 20 Apr 2020 03:36:43 -0400","from mail-wm1-x342.google.com (mail-wm1-x342.google.com\n [IPv6:2a00:1450:4864:20::342])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F0B9C061A10\n for ; Mon, 20 Apr 2020 00:36:43 -0700 (PDT)","by mail-wm1-x342.google.com with SMTP id u127so9043776wmg.1\n for ; Mon, 20 Apr 2020 00:36:43 -0700 (PDT)","from dell ([95.149.164.107])\n by smtp.gmail.com with ESMTPSA id w18sm19085wrn.55.2020.04.20.00.36.40\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 20 Apr 2020 00:36:41 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google;\n h=date:from:to:cc:subject:message-id:references:mime-version\n :content-disposition:content-transfer-encoding:in-reply-to;\n bh=Mb0X0VbhAnhVtMeOXLuQ8HsuJ6uYYtL6iIOac3n0PJU=;\n b=st0iZapP+zDcsQ4UrQb7rcM/hsGHFlairhxjzCU+eWwjjuseXuqjJPI+WXPiBeW+Ul\n 493WUgOLbd3mEM16Cz06eaR8/6bMoVqw5mTtKi8z4TMnE1oxQVpLJVVt+gfkQ+awZtBz\n Llr3jJX2BwEJq6rwnMOXeZHh0HD0SCgTsSVh4nnX6ZlTuAdVem4zbngqA18U1cPELUZ/\n sp8zegHh6y8ehz3646WCK8B67qgzanSNH1hLnjoluhIns84gS4L6UP74qr+2o2ZskG3I\n UFiPAJ0w6uzb0ZGGR3YkpjjQ3s73dRbet54XvXOraKAVsFDH372JkVtKLsg+g+bV0NQf\n x8TQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:date:from:to:cc:subject:message-id:references\n :mime-version:content-disposition:content-transfer-encoding\n :in-reply-to;\n bh=Mb0X0VbhAnhVtMeOXLuQ8HsuJ6uYYtL6iIOac3n0PJU=;\n b=ptRDdj0GELQHFv5cASnmlrkZ+QXM6tUQQpnRXQ87qohdxi8Voo6R4i2BuztwgNN21X\n D9BTJJTxmlz67vADegSx2Ku99hxJ/PA3Xe/653xE0CAqAgWTNVUprC91ocK4hDXHpagu\n riuA55wlnFUBsB4W+++T40576frF1TdDAybH6yDnBIxc9xvUkENABx4osyTBspHOBUH4\n VIhEt00li6VzbGw2oS4vgQW543ecARCZOUJ3pKeUDpfVw4XXeLtCGQt2F2wYCXKTG0v1\n +62pukadtECUNMafLe3IjhaCSkfcl1ussZt/pq5QHeMzAn7am9Vu1r0w5vOL27EWBn2B\n VQtw==","X-Gm-Message-State":"AGi0PuZ5ZffjBJgtUfv6naxZx51ogMlhYECov0H6CAww6t3Bb6Oj9Tk4\n sdQNA9IdpeMfdwyzeYi501vSgQ==","X-Google-Smtp-Source":"\n APiQypJ25Kjm3y9Zgopg3qXJE7CUHbyrlxsvNzWf6js5QWhmpv4/KdDycmxZJtwyZTMEA2yfKfjtHw==","X-Received":"by 2002:a1c:40c4:: with SMTP id\n n187mr15810229wma.28.1587368201801;\n Mon, 20 Apr 2020 00:36:41 -0700 (PDT)","Date":"Mon, 20 Apr 2020 08:36:39 +0100","From":"Lee Jones ","To":"Ran Bi ","Cc":"Hsin-Hsiung Wang ,\n Rob Herring ,\n Matthias Brugger ,\n Alexandre Belloni ,\n Nicolas Boichat ,\n Mark Rutland ,\n Sean Wang ,\n Sebastian Reichel ,\n Eddie Huang ,\n Alessandro Zummo ,\n Kate Stewart ,\n Richard Fontana ,\n Frank Wunderlich ,\n Josef Friedl ,\n Thomas Gleixner ,\n devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,\n linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org,\n srv_heupstream@mediatek.com","Subject":"Re: [PATCH v12 5/6] rtc: mt6397: Add support for the MediaTek MT6358\n RTC","Message-ID":"<20200420073639.GL3737@dell>","References":"<1586333531-21641-1-git-send-email-hsin-hsiung.wang@mediatek.com>\n <1586333531-21641-6-git-send-email-hsin-hsiung.wang@mediatek.com>\n <20200416091438.GA2167633@dell>\n <1587112169.12875.2.camel@mhfsdcap03>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<1587112169.12875.2.camel@mhfsdcap03>","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"}},{"id":2411129,"web_url":"http://patchwork.ozlabs.org/comment/2411129/","msgid":"<20200420073716.GM3737@dell>","list_archive_url":null,"date":"2020-04-20T07:37:16","subject":"Re: [PATCH v12 5/6] rtc: mt6397: Add support for the MediaTek MT6358\n RTC","submitter":{"id":12720,"url":"http://patchwork.ozlabs.org/api/people/12720/","name":"Lee Jones","email":"lee.jones@linaro.org"},"content":"On Fri, 17 Apr 2020, Ran Bi wrote:\n\n> On Fri, 2020-04-17 at 16:29 +0800, Ran Bi wrote:\n> > On Thu, 2020-04-16 at 10:14 +0100, Lee Jones wrote:\n> > > On Wed, 08 Apr 2020, Hsin-Hsiung Wang wrote:\n> > > \n> > > > From: Ran Bi \n> > > > \n> > > > This add support for the MediaTek MT6358 RTC. Driver using\n> > > > compatible data to store different RTC_WRTGR address offset.\n> > > > This replace RTC_WRTGR to RTC_WRTGR_MT6323 in mt6323-poweroff\n> > > > driver which only needed by armv7 CPU without ATF.\n> > > > \n> > > > Reviewed-by: Nicolas Boichat \n> > > > Reviewed-by: Yingjoe Chen \n> > > > Acked-by: Alexandre Belloni \n> > > > Acked-by: Sebastian Reichel \n> > > > Signed-off-by: Ran Bi \n> > > > Signed-off-by: Hsin-Hsiung Wang \n> > > \n> > > Please place these in chronological order. They should provide some\n> > > history, rather than a unordered slab list of random sign-offs.\n> > > \n> > \n> > I suppose that you mean the order should be like below, right?\n> > Reviewed-by: Yingjoe Chen \n> > Acked-by: Sebastian Reichel \n> > Acked-by: Alexandre Belloni \n> > Reviewed-by: Nicolas Boichat \n> > Signed-off-by: Hsin-Hsiung Wang \n> > Signed-off-by: Ran Bi \n> > \n> \n> Correction, I think following is the correct chronological order:\n> Signed-off-by: Ran Bi \n> Signed-off-by: Hsin-Hsiung Wang \n> Reviewed-by: Nicolas Boichat \n> Acked-by: Alexandre Belloni \n> Acked-by: Sebastian Reichel \n> Reviewed-by: Yingjoe Chen \n\nThis looks better, yes.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=23.128.96.18; helo=vger.kernel.org;\n envelope-from=linux-rtc-owner@vger.kernel.org; receiver=)","ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linaro.org","ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=s9Ej0RPY;\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [23.128.96.18])\n\tby ozlabs.org (Postfix) with ESMTP id 495JSM3wwWz9sSw\n\tfor ; Mon, 20 Apr 2020 17:37:23 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S1726100AbgDTHhV (ORCPT );\n Mon, 20 Apr 2020 03:37:21 -0400","from lindbergh.monkeyblade.net ([23.128.96.19]:42068 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-FAIL-OK-FAIL)\n by vger.kernel.org with ESMTP id S1726006AbgDTHhV (ORCPT\n ); Mon, 20 Apr 2020 03:37:21 -0400","from mail-wm1-x344.google.com (mail-wm1-x344.google.com\n [IPv6:2a00:1450:4864:20::344])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED605C061A0C\n for ; Mon, 20 Apr 2020 00:37:19 -0700 (PDT)","by mail-wm1-x344.google.com with SMTP id 188so3671426wmc.2\n for ; Mon, 20 Apr 2020 00:37:19 -0700 (PDT)","from dell ([95.149.164.107])\n by smtp.gmail.com with ESMTPSA id y40sm43875wrd.20.2020.04.20.00.37.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 20 Apr 2020 00:37:18 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google;\n h=date:from:to:cc:subject:message-id:references:mime-version\n :content-disposition:content-transfer-encoding:in-reply-to;\n bh=x4d8njD2ChzZ2kuDWBQWJtIw3UQE6E7sHmhOoB5ezqs=;\n b=s9Ej0RPYb9lJkeS+N4KaZqRVDOm/SMTuNsIfiyVl/sCG8tzdLnNngYV+RVgyER1R3F\n VRzB6TNY6rn0cuPvz+jDOcsgEm6vB1iflYdPxH4S/bamY84eTcqa+4vtDy05GKDS4zS0\n Kmm16bHrfBNiQYXYskNt3fsMJzTC+pNl8kFLLFI9UFzWOxH8F7RfDCklTUfNpN0f2I44\n VR2D/sc2g96ROMto0j2Rr+t14rZ1StFnVNPpwNhsirhV/Pqwh8cGs84i9OzxMvWPinBI\n Lffym77ABv9sVKQAf5rNjW5F0P8/MHbhNn36a9zIpouhrv8SW+gc2OjC9ud+o76ZOm5t\n peAA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:date:from:to:cc:subject:message-id:references\n :mime-version:content-disposition:content-transfer-encoding\n :in-reply-to;\n bh=x4d8njD2ChzZ2kuDWBQWJtIw3UQE6E7sHmhOoB5ezqs=;\n b=AbgvPSCNvw9RSV/6XJfjEsaRzybYMCzAemR1Je2F3KebsIawJItCRjJwblQD7Kz+cD\n UVv9WU5r4W3KI5id5HR0vE5VR8xWdSA8jZyCayl89fMTmUNkxLLy8HVTQFfB9PmtXc5E\n QnMxt6kTzy93FCclxJF254KhpzmFnxhfhNv0WqGFXTEVCRzU57M+rPUxN44Nw6ZD+Qt4\n JrDjc0c8b9v9ZSX9wsnvUXRgfzIZIr1ARvM4UUMZ4vPkP+cRWpa11QNqkjAb0LNr+UjW\n gJzdZZuht/2YyWMRFkLq7UWUMEkeo8xZFNaUYPjAGcd6XB6KGu25ow6ebBeBPdAAj75B\n jbRQ==","X-Gm-Message-State":"AGi0PuZN44IgNwy/bWTeG6Os8VFIXGh3uIPFaBL1jQQpTKBlifLQKr/Z\n D2FHXK5dBWrj7BMO4rjdwlAKEg==","X-Google-Smtp-Source":"\n APiQypI3JmmCDHjcMn3A1vzcEpxgsLlbI4LO3mEsYg5l0mrqs5au0PNliOvfe+fdVwtahiKITEMREQ==","X-Received":"by 2002:a1c:6344:: with SMTP id x65mr16504650wmb.56.1587368238713;\n Mon, 20 Apr 2020 00:37:18 -0700 (PDT)","Date":"Mon, 20 Apr 2020 08:37:16 +0100","From":"Lee Jones ","To":"Ran Bi ","Cc":"Hsin-Hsiung Wang ,\n Rob Herring ,\n Matthias Brugger ,\n Alexandre Belloni ,\n Nicolas Boichat ,\n Mark Rutland ,\n Sean Wang ,\n Sebastian Reichel ,\n Eddie Huang ,\n Alessandro Zummo ,\n Kate Stewart ,\n Richard Fontana ,\n Frank Wunderlich ,\n Josef Friedl ,\n Thomas Gleixner ,\n devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,\n linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org,\n srv_heupstream@mediatek.com","Subject":"Re: [PATCH v12 5/6] rtc: mt6397: Add support for the MediaTek MT6358\n RTC","Message-ID":"<20200420073716.GM3737@dell>","References":"<1586333531-21641-1-git-send-email-hsin-hsiung.wang@mediatek.com>\n <1586333531-21641-6-git-send-email-hsin-hsiung.wang@mediatek.com>\n <20200416091438.GA2167633@dell>\n <1587112169.12875.2.camel@mhfsdcap03>\n <1587113392.13323.3.camel@mhfsdcap03>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<1587113392.13323.3.camel@mhfsdcap03>","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"}}]