[{"id":2408696,"web_url":"http://patchwork.ozlabs.org/comment/2408696/","msgid":"<20200416084910.GX2167633@dell>","list_archive_url":null,"date":"2020-04-16T08:49:10","subject":"Re: [PATCH v12 1/6] mfd: mt6397: Modify suspend/resume behavior","submitter":{"id":12720,"url":"http://patchwork.ozlabs.org/api/people/12720/","name":"Lee Jones","email":"lee.jones@linaro.org"},"content":"On Wed, 08 Apr 2020, Hsin-Hsiung Wang wrote:\n\n> Some pmics don't need backup interrupt settings, so we change to use\n> pm notifier for the pmics which are necessary to store settings.\n> \n> Signed-off-by: Hsin-Hsiung Wang \n> ---\n> drivers/mfd/mt6397-core.c | 30 ------------------------------\n> drivers/mfd/mt6397-irq.c | 35 ++++++++++++++++++++++++++++++++++-\n> include/linux/mfd/mt6397/core.h | 2 ++\n> 3 files changed, 36 insertions(+), 31 deletions(-)\n> \n> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c\n> index 0437c85..d2e70d8 100644\n> --- a/drivers/mfd/mt6397-core.c\n> +++ b/drivers/mfd/mt6397-core.c\n> @@ -100,35 +100,6 @@ static const struct mfd_cell mt6397_devs[] = {\n> \t}\n> };\n> \n> -#ifdef CONFIG_PM_SLEEP\n> -static int mt6397_irq_suspend(struct device *dev)\n> -{\n> -\tstruct mt6397_chip *chip = dev_get_drvdata(dev);\n> -\n> -\tregmap_write(chip->regmap, chip->int_con[0], chip->wake_mask[0]);\n> -\tregmap_write(chip->regmap, chip->int_con[1], chip->wake_mask[1]);\n> -\n> -\tenable_irq_wake(chip->irq);\n> -\n> -\treturn 0;\n> -}\n> -\n> -static int mt6397_irq_resume(struct device *dev)\n> -{\n> -\tstruct mt6397_chip *chip = dev_get_drvdata(dev);\n> -\n> -\tregmap_write(chip->regmap, chip->int_con[0], chip->irq_masks_cur[0]);\n> -\tregmap_write(chip->regmap, chip->int_con[1], chip->irq_masks_cur[1]);\n> -\n> -\tdisable_irq_wake(chip->irq);\n> -\n> -\treturn 0;\n> -}\n> -#endif\n> -\n> -static SIMPLE_DEV_PM_OPS(mt6397_pm_ops, mt6397_irq_suspend,\n> -\t\t\tmt6397_irq_resume);\n> -\n> struct chip_data {\n> \tu32 cid_addr;\n> \tu32 cid_shift;\n> @@ -238,7 +209,6 @@ static struct platform_driver mt6397_driver = {\n> \t.driver = {\n> \t\t.name = \"mt6397\",\n> \t\t.of_match_table = of_match_ptr(mt6397_of_match),\n> -\t\t.pm = &mt6397_pm_ops,\n> \t},\n> \t.id_table = mt6397_id,\n> };\n> diff --git a/drivers/mfd/mt6397-irq.c b/drivers/mfd/mt6397-irq.c\n> index b2d3ce1..2924919 100644\n> --- a/drivers/mfd/mt6397-irq.c\n> +++ b/drivers/mfd/mt6397-irq.c\n> @@ -9,6 +9,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> #include \n> #include \n> @@ -81,7 +82,7 @@ static struct irq_chip mt6397_irq_chip = {\n> static void mt6397_irq_handle_reg(struct mt6397_chip *mt6397, int reg,\n> \t\t\t\t int irqbase)\n> {\n> -\tunsigned int status;\n> +\tunsigned int status = 0;\n\nThis looks like an unrelated change, no?\n\n> \tint i, irq, ret;\n> \n> \tret = regmap_read(mt6397->regmap, reg, &status);\n> @@ -128,6 +129,36 @@ static const struct irq_domain_ops mt6397_irq_domain_ops = {\n> \t.map = mt6397_irq_domain_map,\n> };\n\nOther than that.\n\nFor my own reference:\n Acked-for-MFD-by: Lee Jones ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=23.128.96.18; helo=vger.kernel.org;\n envelope-from=linux-rtc-owner@vger.kernel.org; receiver=)","ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linaro.org","ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=qMyY08os;\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [23.128.96.18])\n\tby ozlabs.org (Postfix) with ESMTP id 492tHN0kp7z9sP7\n\tfor ; Thu, 16 Apr 2020 18:51:12 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S2502754AbgDPIvB (ORCPT );\n Thu, 16 Apr 2020 04:51:01 -0400","from lindbergh.monkeyblade.net ([23.128.96.19]:40278 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n with ESMTP id S2502926AbgDPIsR (ORCPT\n ); Thu, 16 Apr 2020 04:48:17 -0400","from mail-wr1-x444.google.com (mail-wr1-x444.google.com\n [IPv6:2a00:1450:4864:20::444])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 475DDC0610D5\n for ; Thu, 16 Apr 2020 01:48:12 -0700 (PDT)","by mail-wr1-x444.google.com with SMTP id d27so3886617wra.1\n for ; Thu, 16 Apr 2020 01:48:12 -0700 (PDT)","from dell ([95.149.164.124])\n by smtp.gmail.com with ESMTPSA id\n z15sm14429845wrs.47.2020.04.16.01.48.09\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 16 Apr 2020 01:48:10 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google;\n h=date:from:to:cc:subject:message-id:references:mime-version\n :content-disposition:content-transfer-encoding:in-reply-to;\n bh=gCC6rxpfNBHEEJoswTl2+v3GlY13e+wv1Apu4C5uUJ0=;\n b=qMyY08os0xXarDJEQ8j9nJU1G/4i1ajvSN1547JGWNAU4kptYy+l0ETyItzmwelvLC\n nCDep5Cl1t95mbiIhlCDcowJNJGFakofRU/UeiPQv049DorrDQDyvOhQ0iXlohLp8hin\n 3bAdw+39EFnaQiFiejH+534QfsSXNhMyYx4ZtJs1O8APzJpuT9KiZORIU2xx8m9me3GJ\n nRCzeSz6fhZnRuGUV65gJOj0k8DMrASVs1ffDMfO5wQ+4MKhMzyo1Hf7xWdNJii/ENzy\n uOrTcZOmWLeo1D6phvtKajqfSbjF0JkyzG19tN5chV4GtOZYui9witk4RNmc7L0KIuBW\n GEOQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:date:from:to:cc:subject:message-id:references\n :mime-version:content-disposition:content-transfer-encoding\n :in-reply-to;\n bh=gCC6rxpfNBHEEJoswTl2+v3GlY13e+wv1Apu4C5uUJ0=;\n b=fIIXgbuF8Ex9+p+FLDe5dNk8yx7PhMvFToMRqNTyPzT3/ETXdwK25+R3PZx963c3Zt\n lh9g5utZtA3tznaJNFEEjYrrbjDixV73q3FMunuIjpGGIYacTlF9gTTYZ17WuwzWXjx2\n jkP6OtCFp+lmyZwCee5fH7YDXqgJs1hBrFr8BbChrj2/YX/Iana4Gm95ADWyYnYFLuIo\n P2yis8tNTtdKvRCESFBO3KQXA4TWCERl6FZOPMny0Q9unFmlUNTr2Ob3wceUasAXTOnV\n 7tT3qZshdZkS70tyv/PJSA3WAOg/SGfZRo18WiqyRW11kQjHOJKIbEZrf3QTP6t9wMW3\n X+Xw==","X-Gm-Message-State":"AGi0PuYuUzmn69e4yZcQakpu9ExIOEsoJx5g4An46oGnVEVrLICjUOrp\n ivkOosAMkKya/F2hFWmGZOXo2Q==","X-Google-Smtp-Source":"\n APiQypLyhDVW4E+VOlBHWErivAdlGrtxixDqwonOAkbRNQamJnKVsV0vJKLtvSLryabLtX0HhH0tLg==","X-Received":"by 2002:a5d:4286:: with SMTP id k6mr21252278wrq.222.1587026890846;\n Thu, 16 Apr 2020 01:48:10 -0700 (PDT)","Date":"Thu, 16 Apr 2020 09:49:10 +0100","From":"Lee Jones ","To":"Hsin-Hsiung Wang ","Cc":"Rob Herring ,\n Matthias Brugger ,\n Alexandre Belloni ,\n Nicolas Boichat ,\n Mark Rutland ,\n Sean Wang ,\n Sebastian Reichel ,\n Eddie Huang ,\n Alessandro Zummo ,\n Kate Stewart ,\n Richard Fontana ,\n Frank Wunderlich ,\n Josef Friedl ,\n Thomas Gleixner ,\n Ran Bi , devicetree@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org,\n linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,\n linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org,\n srv_heupstream@mediatek.com","Subject":"Re: [PATCH v12 1/6] mfd: mt6397: Modify suspend/resume behavior","Message-ID":"<20200416084910.GX2167633@dell>","References":"<1586333531-21641-1-git-send-email-hsin-hsiung.wang@mediatek.com>\n <1586333531-21641-2-git-send-email-hsin-hsiung.wang@mediatek.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<1586333531-21641-2-git-send-email-hsin-hsiung.wang@mediatek.com>","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"}},{"id":2411352,"web_url":"http://patchwork.ozlabs.org/comment/2411352/","msgid":"<1587379959.6297.2.camel@mtksdaap41>","list_archive_url":null,"date":"2020-04-20T10:52:39","subject":"Re: [PATCH v12 1/6] mfd: mt6397: Modify suspend/resume behavior","submitter":{"id":74946,"url":"http://patchwork.ozlabs.org/api/people/74946/","name":"Hsin-Hsiung Wang","email":"hsin-hsiung.wang@mediatek.com"},"content":"Hi,\n\nOn Thu, 2020-04-16 at 09:49 +0100, Lee Jones wrote:\n> On Wed, 08 Apr 2020, Hsin-Hsiung Wang wrote:\n> \n> > Some pmics don't need backup interrupt settings, so we change to use\n> > pm notifier for the pmics which are necessary to store settings.\n> > \n> > Signed-off-by: Hsin-Hsiung Wang \n> > ---\n> > drivers/mfd/mt6397-core.c | 30 ------------------------------\n> > drivers/mfd/mt6397-irq.c | 35 ++++++++++++++++++++++++++++++++++-\n> > include/linux/mfd/mt6397/core.h | 2 ++\n> > 3 files changed, 36 insertions(+), 31 deletions(-)\n> > \n> > diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c\n> > index 0437c85..d2e70d8 100644\n> > --- a/drivers/mfd/mt6397-core.c\n> > +++ b/drivers/mfd/mt6397-core.c\n> > @@ -100,35 +100,6 @@ static const struct mfd_cell mt6397_devs[] = {\n> > \t}\n> > };\n> > \n> > -#ifdef CONFIG_PM_SLEEP\n> > -static int mt6397_irq_suspend(struct device *dev)\n> > -{\n> > -\tstruct mt6397_chip *chip = dev_get_drvdata(dev);\n> > -\n> > -\tregmap_write(chip->regmap, chip->int_con[0], chip->wake_mask[0]);\n> > -\tregmap_write(chip->regmap, chip->int_con[1], chip->wake_mask[1]);\n> > -\n> > -\tenable_irq_wake(chip->irq);\n> > -\n> > -\treturn 0;\n> > -}\n> > -\n> > -static int mt6397_irq_resume(struct device *dev)\n> > -{\n> > -\tstruct mt6397_chip *chip = dev_get_drvdata(dev);\n> > -\n> > -\tregmap_write(chip->regmap, chip->int_con[0], chip->irq_masks_cur[0]);\n> > -\tregmap_write(chip->regmap, chip->int_con[1], chip->irq_masks_cur[1]);\n> > -\n> > -\tdisable_irq_wake(chip->irq);\n> > -\n> > -\treturn 0;\n> > -}\n> > -#endif\n> > -\n> > -static SIMPLE_DEV_PM_OPS(mt6397_pm_ops, mt6397_irq_suspend,\n> > -\t\t\tmt6397_irq_resume);\n> > -\n> > struct chip_data {\n> > \tu32 cid_addr;\n> > \tu32 cid_shift;\n> > @@ -238,7 +209,6 @@ static struct platform_driver mt6397_driver = {\n> > \t.driver = {\n> > \t\t.name = \"mt6397\",\n> > \t\t.of_match_table = of_match_ptr(mt6397_of_match),\n> > -\t\t.pm = &mt6397_pm_ops,\n> > \t},\n> > \t.id_table = mt6397_id,\n> > };\n> > diff --git a/drivers/mfd/mt6397-irq.c b/drivers/mfd/mt6397-irq.c\n> > index b2d3ce1..2924919 100644\n> > --- a/drivers/mfd/mt6397-irq.c\n> > +++ b/drivers/mfd/mt6397-irq.c\n> > @@ -9,6 +9,7 @@\n> > #include \n> > #include \n> > #include \n> > +#include \n> > #include \n> > #include \n> > #include \n> > @@ -81,7 +82,7 @@ static struct irq_chip mt6397_irq_chip = {\n> > static void mt6397_irq_handle_reg(struct mt6397_chip *mt6397, int reg,\n> > \t\t\t\t int irqbase)\n> > {\n> > -\tunsigned int status;\n> > +\tunsigned int status = 0;\n> \n> This looks like an unrelated change, no?\n> \n\nIt is to fix the coverity defect.\n\n> > \tint i, irq, ret;\n> > \n> > \tret = regmap_read(mt6397->regmap, reg, &status);\n> > @@ -128,6 +129,36 @@ static const struct irq_domain_ops mt6397_irq_domain_ops = {\n> > \t.map = mt6397_irq_domain_map,\n> > };\n> \n> Other than that.\n> \n> For my own reference:\n> Acked-for-MFD-by: Lee Jones \n> \nThanks for your review. I will add it in the next version.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=23.128.96.18; helo=vger.kernel.org;\n envelope-from=linux-rtc-owner@vger.kernel.org; receiver=)","ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=mediatek.com","ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=mediatek.com header.i=@mediatek.com header.a=rsa-sha256\n header.s=dk header.b=MQEGkVTE;\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [23.128.96.18])\n\tby ozlabs.org (Postfix) with ESMTP id 495Nnv61jYz9sSd\n\tfor ; Mon, 20 Apr 2020 20:52:51 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S1725775AbgDTKws (ORCPT );\n Mon, 20 Apr 2020 06:52:48 -0400","from mailgw01.mediatek.com ([210.61.82.183]:18640 \"EHLO\n mailgw01.mediatek.com\" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org\n with ESMTP id S1725773AbgDTKws (ORCPT\n ); Mon, 20 Apr 2020 06:52:48 -0400","from mtkexhb01.mediatek.inc [(172.21.101.102)] by\n mailgw01.mediatek.com\n (envelope-from )\n (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS)\n with ESMTP id 2007460060; Mon, 20 Apr 2020 18:52:44 +0800","from MTKCAS06.mediatek.inc (172.21.101.30) by\n mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Mon, 20 Apr 2020 18:52:38 +0800","from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc\n (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Mon, 20 Apr 2020 18:52:37 +0800"],"X-UUID":["10f5262b28c749c5bcbed67e4ec0dd43-20200420","10f5262b28c749c5bcbed67e4ec0dd43-20200420"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n d=mediatek.com; s=dk;\n h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID;\n bh=5ZSYvBnifQattuM6WwNJ4dWYpkcL8v4PWiqKlXsfHC4=;\n b=MQEGkVTEJjor7u4n/2Ncwn0pFev7mIhXwkIn1iFmGxsdVQ+XfMW8QCKOgE413wlgZlHJD9/E/qlViXeL/UqqZjk17Kkox+fjXjzgAag0IXZAp4E9l8Nfg32vOzXyfOM59XvtcW1rnQ5gLi4ACDc+8HCFnvUdoHQtSvgCG286y1k=;","Message-ID":"<1587379959.6297.2.camel@mtksdaap41>","Subject":"Re: [PATCH v12 1/6] mfd: mt6397: Modify suspend/resume behavior","From":"Hsin-hsiung Wang ","To":"Lee Jones ","CC":"Mark Rutland ,\n Kate Stewart ,\n Alexandre Belloni ,\n ,\n \"Richard Fontana\" ,\n ,\n Nicolas Boichat ,\n , ,\n Frank Wunderlich ,\n Ran Bi ,\n Sean Wang ,\n \"Rob Herring\" ,\n ,\n \"Matthias Brugger\" ,\n Thomas Gleixner ,\n Eddie Huang ,\n ,\n Alessandro Zummo ,\n Josef Friedl ,\n , Sebastian Reichel ","Date":"Mon, 20 Apr 2020 18:52:39 +0800","In-Reply-To":"<20200416084910.GX2167633@dell>","References":"<1586333531-21641-1-git-send-email-hsin-hsiung.wang@mediatek.com>\n <1586333531-21641-2-git-send-email-hsin-hsiung.wang@mediatek.com>\n <20200416084910.GX2167633@dell>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.10.4-0ubuntu2 ","MIME-Version":"1.0","X-TM-SNTS-SMTP":"\n 665BB53A9B209DF474DE368E25DAC4D6E7703353C21B189088EF792896EB3DFD2000:8","X-MTK":"N","Content-Transfer-Encoding":"base64","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"}},{"id":2411371,"web_url":"http://patchwork.ozlabs.org/comment/2411371/","msgid":"<20200420111522.GB3612@dell>","list_archive_url":null,"date":"2020-04-20T11:15:22","subject":"Re: [PATCH v12 1/6] mfd: mt6397: Modify suspend/resume behavior","submitter":{"id":12720,"url":"http://patchwork.ozlabs.org/api/people/12720/","name":"Lee Jones","email":"lee.jones@linaro.org"},"content":"On Mon, 20 Apr 2020, Hsin-hsiung Wang wrote:\n\n> Hi,\n> \n> On Thu, 2020-04-16 at 09:49 +0100, Lee Jones wrote:\n> > On Wed, 08 Apr 2020, Hsin-Hsiung Wang wrote:\n> > \n> > > Some pmics don't need backup interrupt settings, so we change to use\n> > > pm notifier for the pmics which are necessary to store settings.\n> > > \n> > > Signed-off-by: Hsin-Hsiung Wang \n> > > ---\n> > > drivers/mfd/mt6397-core.c | 30 ------------------------------\n> > > drivers/mfd/mt6397-irq.c | 35 ++++++++++++++++++++++++++++++++++-\n> > > include/linux/mfd/mt6397/core.h | 2 ++\n> > > 3 files changed, 36 insertions(+), 31 deletions(-)\n> > > \n> > > diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c\n> > > index 0437c85..d2e70d8 100644\n> > > --- a/drivers/mfd/mt6397-core.c\n> > > +++ b/drivers/mfd/mt6397-core.c\n> > > @@ -100,35 +100,6 @@ static const struct mfd_cell mt6397_devs[] = {\n> > > \t}\n> > > };\n> > > \n> > > -#ifdef CONFIG_PM_SLEEP\n> > > -static int mt6397_irq_suspend(struct device *dev)\n> > > -{\n> > > -\tstruct mt6397_chip *chip = dev_get_drvdata(dev);\n> > > -\n> > > -\tregmap_write(chip->regmap, chip->int_con[0], chip->wake_mask[0]);\n> > > -\tregmap_write(chip->regmap, chip->int_con[1], chip->wake_mask[1]);\n> > > -\n> > > -\tenable_irq_wake(chip->irq);\n> > > -\n> > > -\treturn 0;\n> > > -}\n> > > -\n> > > -static int mt6397_irq_resume(struct device *dev)\n> > > -{\n> > > -\tstruct mt6397_chip *chip = dev_get_drvdata(dev);\n> > > -\n> > > -\tregmap_write(chip->regmap, chip->int_con[0], chip->irq_masks_cur[0]);\n> > > -\tregmap_write(chip->regmap, chip->int_con[1], chip->irq_masks_cur[1]);\n> > > -\n> > > -\tdisable_irq_wake(chip->irq);\n> > > -\n> > > -\treturn 0;\n> > > -}\n> > > -#endif\n> > > -\n> > > -static SIMPLE_DEV_PM_OPS(mt6397_pm_ops, mt6397_irq_suspend,\n> > > -\t\t\tmt6397_irq_resume);\n> > > -\n> > > struct chip_data {\n> > > \tu32 cid_addr;\n> > > \tu32 cid_shift;\n> > > @@ -238,7 +209,6 @@ static struct platform_driver mt6397_driver = {\n> > > \t.driver = {\n> > > \t\t.name = \"mt6397\",\n> > > \t\t.of_match_table = of_match_ptr(mt6397_of_match),\n> > > -\t\t.pm = &mt6397_pm_ops,\n> > > \t},\n> > > \t.id_table = mt6397_id,\n> > > };\n> > > diff --git a/drivers/mfd/mt6397-irq.c b/drivers/mfd/mt6397-irq.c\n> > > index b2d3ce1..2924919 100644\n> > > --- a/drivers/mfd/mt6397-irq.c\n> > > +++ b/drivers/mfd/mt6397-irq.c\n> > > @@ -9,6 +9,7 @@\n> > > #include \n> > > #include \n> > > #include \n> > > +#include \n> > > #include \n> > > #include \n> > > #include \n> > > @@ -81,7 +82,7 @@ static struct irq_chip mt6397_irq_chip = {\n> > > static void mt6397_irq_handle_reg(struct mt6397_chip *mt6397, int reg,\n> > > \t\t\t\t int irqbase)\n> > > {\n> > > -\tunsigned int status;\n> > > +\tunsigned int status = 0;\n> > \n> > This looks like an unrelated change, no?\n> > \n> \n> It is to fix the coverity defect.\n\nWhich isn't mentioned in the commit log and doesn't have anything to\ndo with this patch. Thus it should be in a separate patch, but I'm\nnot going to lose any sleep over it.\n\n> > > \tint i, irq, ret;\n> > > \n> > > \tret = regmap_read(mt6397->regmap, reg, &status);\n> > > @@ -128,6 +129,36 @@ static const struct irq_domain_ops mt6397_irq_domain_ops = {\n> > > \t.map = mt6397_irq_domain_map,\n> > > };\n> > \n> > Other than that.\n> > \n> > For my own reference:\n> > Acked-for-MFD-by: Lee Jones \n> > \n> Thanks for your review. I will add it in the next version.\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=23.128.96.18; helo=vger.kernel.org;\n envelope-from=linux-rtc-owner@vger.kernel.org; receiver=)","ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linaro.org","ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Z69BlBZc;\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [23.128.96.18])\n\tby ozlabs.org (Postfix) with ESMTP id 495PJ02nhqz9s71\n\tfor ; Mon, 20 Apr 2020 21:15:28 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S1725886AbgDTLP1 (ORCPT );\n Mon, 20 Apr 2020 07:15:27 -0400","from lindbergh.monkeyblade.net ([23.128.96.19]:47584 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-FAIL-OK-FAIL)\n by vger.kernel.org with ESMTP id S1725775AbgDTLP0 (ORCPT\n ); Mon, 20 Apr 2020 07:15:26 -0400","from mail-wr1-x442.google.com (mail-wr1-x442.google.com\n [IPv6:2a00:1450:4864:20::442])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D94AC061A41\n for ; Mon, 20 Apr 2020 04:15:26 -0700 (PDT)","by mail-wr1-x442.google.com with SMTP id j1so6199488wrt.1\n for ; Mon, 20 Apr 2020 04:15:26 -0700 (PDT)","from dell ([95.149.164.107])\n by smtp.gmail.com with ESMTPSA id\n q143sm969035wme.31.2020.04.20.04.15.23\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 20 Apr 2020 04:15:24 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google;\n h=date:from:to:cc:subject:message-id:references:mime-version\n :content-disposition:content-transfer-encoding:in-reply-to;\n bh=4uCgchzEKUbGCjVb5ErPQQvp7VtDEqWO3rkjRlf6Z0c=;\n b=Z69BlBZc3+yIjY+OiSNwt8bsyBI0gsYDwMfdiucsDa5C+MKP/wOJquAOhh0jY8LvP8\n DrypNHoQ8098wugctLVFMem6rV1KysE9rL4PQbw9dgV9IX4vzDo8vaR3IolrnwdZnlue\n oiYWMkYalyjVcjm2bEgoiKKZoPYWWSYOSW2mlfPKPx+R10IJHuVAXZKI+CMv1NXjZwBe\n 4ApmE0F3A3wQai4D9aDrDuXakAc3roQsOINa7eE95IHRnzDQ2WMpJIYitHW849I7SOu2\n /WgTnsClHrd3yTWNDwW+tMRpyK1PDxfZIy/Qi+no+uSblRgwH6XmDdXWWcVSG1+c8QGu\n WI1Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:date:from:to:cc:subject:message-id:references\n :mime-version:content-disposition:content-transfer-encoding\n :in-reply-to;\n bh=4uCgchzEKUbGCjVb5ErPQQvp7VtDEqWO3rkjRlf6Z0c=;\n b=OyqoweRJFuo2ngLBH2ggk6GAKvqeXiz9ay10/Y+FltXPDXSGbjKNh4m6v2TKWPjN4Y\n 3tbkw693cnz+Rt6CUIGj05P7p1Eo08lWW/TfnsqkWaBZx+Ks3GfRdnmvwNX7NoiAfEsX\n 6ZB+jnxKSlMNow1wufIQctHQBAHeiYrz7LIwfxa2d5tBK0YKP2GMX++rAx/dpDxgI3yv\n EgpHMn6bysv/3AVwiF+kjq97w/2iH7Z8nzoQVJCmZeV2th/cfZeCFbS/dMg38VJTQ0ol\n TBA2QEIRM9IEBJjyQ+hq+uNdXpwVFPpNa/4K3gMmk2ApJmOeR28py5AZHlQp0adYijLG\n gTag==","X-Gm-Message-State":"AGi0Puak8vYNjp3/nvsUyhXrM9Ks30aS7E1pnEbAVX7XrY6de3XoF8mz\n kTCkDQriRIza0KFMX3ms1M7eRQ==","X-Google-Smtp-Source":"\n APiQypJhmbeviPbiHBjSOOZlAdECJVyeKqJZLm8MMiKHA1YJPMBCV2InSlX2aY5iSqxkecD8aYWnaQ==","X-Received":"by 2002:a5d:5147:: with SMTP id u7mr17746146wrt.290.1587381324902;\n Mon, 20 Apr 2020 04:15:24 -0700 (PDT)","Date":"Mon, 20 Apr 2020 12:15:22 +0100","From":"Lee Jones ","To":"Hsin-hsiung Wang ","Cc":"Mark Rutland ,\n Kate Stewart ,\n Alexandre Belloni ,\n linux-kernel@vger.kernel.org,\n Richard Fontana ,\n linux-rtc@vger.kernel.org, Nicolas Boichat ,\n linux-pm@vger.kernel.org, devicetree@vger.kernel.org,\n Frank Wunderlich ,\n Ran Bi ,\n Sean Wang ,\n Rob Herring ,\n linux-mediatek@lists.infradead.org,\n Matthias Brugger ,\n Thomas Gleixner ,\n Eddie Huang ,\n linux-arm-kernel@lists.infradead.org,\n Alessandro Zummo ,\n Josef Friedl ,\n srv_heupstream@mediatek.com, Sebastian Reichel ","Subject":"Re: [PATCH v12 1/6] mfd: mt6397: Modify suspend/resume behavior","Message-ID":"<20200420111522.GB3612@dell>","References":"<1586333531-21641-1-git-send-email-hsin-hsiung.wang@mediatek.com>\n <1586333531-21641-2-git-send-email-hsin-hsiung.wang@mediatek.com>\n <20200416084910.GX2167633@dell>\n <1587379959.6297.2.camel@mtksdaap41>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<1587379959.6297.2.camel@mtksdaap41>","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"}},{"id":2411411,"web_url":"http://patchwork.ozlabs.org/comment/2411411/","msgid":"<1587383712.11642.0.camel@mtksdaap41>","list_archive_url":null,"date":"2020-04-20T11:55:12","subject":"Re: [PATCH v12 1/6] mfd: mt6397: Modify suspend/resume behavior","submitter":{"id":74946,"url":"http://patchwork.ozlabs.org/api/people/74946/","name":"Hsin-Hsiung Wang","email":"hsin-hsiung.wang@mediatek.com"},"content":"Hi,\n\nOn Mon, 2020-04-20 at 12:15 +0100, Lee Jones wrote:\n> On Mon, 20 Apr 2020, Hsin-hsiung Wang wrote:\n> \n> > Hi,\n> > \n> > On Thu, 2020-04-16 at 09:49 +0100, Lee Jones wrote:\n> > > On Wed, 08 Apr 2020, Hsin-Hsiung Wang wrote:\n> > > \n> > > > Some pmics don't need backup interrupt settings, so we change to use\n> > > > pm notifier for the pmics which are necessary to store settings.\n> > > > \n> > > > Signed-off-by: Hsin-Hsiung Wang \n> > > > ---\n> > > > drivers/mfd/mt6397-core.c | 30 ------------------------------\n> > > > drivers/mfd/mt6397-irq.c | 35 ++++++++++++++++++++++++++++++++++-\n> > > > include/linux/mfd/mt6397/core.h | 2 ++\n> > > > 3 files changed, 36 insertions(+), 31 deletions(-)\n> > > > \n> > > > diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c\n> > > > index 0437c85..d2e70d8 100644\n> > > > --- a/drivers/mfd/mt6397-core.c\n> > > > +++ b/drivers/mfd/mt6397-core.c\n> > > > @@ -100,35 +100,6 @@ static const struct mfd_cell mt6397_devs[] = {\n> > > > \t}\n> > > > };\n> > > > \n> > > > -#ifdef CONFIG_PM_SLEEP\n> > > > -static int mt6397_irq_suspend(struct device *dev)\n> > > > -{\n> > > > -\tstruct mt6397_chip *chip = dev_get_drvdata(dev);\n> > > > -\n> > > > -\tregmap_write(chip->regmap, chip->int_con[0], chip->wake_mask[0]);\n> > > > -\tregmap_write(chip->regmap, chip->int_con[1], chip->wake_mask[1]);\n> > > > -\n> > > > -\tenable_irq_wake(chip->irq);\n> > > > -\n> > > > -\treturn 0;\n> > > > -}\n> > > > -\n> > > > -static int mt6397_irq_resume(struct device *dev)\n> > > > -{\n> > > > -\tstruct mt6397_chip *chip = dev_get_drvdata(dev);\n> > > > -\n> > > > -\tregmap_write(chip->regmap, chip->int_con[0], chip->irq_masks_cur[0]);\n> > > > -\tregmap_write(chip->regmap, chip->int_con[1], chip->irq_masks_cur[1]);\n> > > > -\n> > > > -\tdisable_irq_wake(chip->irq);\n> > > > -\n> > > > -\treturn 0;\n> > > > -}\n> > > > -#endif\n> > > > -\n> > > > -static SIMPLE_DEV_PM_OPS(mt6397_pm_ops, mt6397_irq_suspend,\n> > > > -\t\t\tmt6397_irq_resume);\n> > > > -\n> > > > struct chip_data {\n> > > > \tu32 cid_addr;\n> > > > \tu32 cid_shift;\n> > > > @@ -238,7 +209,6 @@ static struct platform_driver mt6397_driver = {\n> > > > \t.driver = {\n> > > > \t\t.name = \"mt6397\",\n> > > > \t\t.of_match_table = of_match_ptr(mt6397_of_match),\n> > > > -\t\t.pm = &mt6397_pm_ops,\n> > > > \t},\n> > > > \t.id_table = mt6397_id,\n> > > > };\n> > > > diff --git a/drivers/mfd/mt6397-irq.c b/drivers/mfd/mt6397-irq.c\n> > > > index b2d3ce1..2924919 100644\n> > > > --- a/drivers/mfd/mt6397-irq.c\n> > > > +++ b/drivers/mfd/mt6397-irq.c\n> > > > @@ -9,6 +9,7 @@\n> > > > #include \n> > > > #include \n> > > > #include \n> > > > +#include \n> > > > #include \n> > > > #include \n> > > > #include \n> > > > @@ -81,7 +82,7 @@ static struct irq_chip mt6397_irq_chip = {\n> > > > static void mt6397_irq_handle_reg(struct mt6397_chip *mt6397, int reg,\n> > > > \t\t\t\t int irqbase)\n> > > > {\n> > > > -\tunsigned int status;\n> > > > +\tunsigned int status = 0;\n> > > \n> > > This looks like an unrelated change, no?\n> > > \n> > \n> > It is to fix the coverity defect.\n> \n> Which isn't mentioned in the commit log and doesn't have anything to\n> do with this patch. Thus it should be in a separate patch, but I'm\n> not going to lose any sleep over it.\n> \n\nCould I just add it to the commit message?\nThanks.\n\n> > > > \tint i, irq, ret;\n> > > > \n> > > > \tret = regmap_read(mt6397->regmap, reg, &status);\n> > > > @@ -128,6 +129,36 @@ static const struct irq_domain_ops mt6397_irq_domain_ops = {\n> > > > \t.map = mt6397_irq_domain_map,\n> > > > };\n> > > \n> > > Other than that.\n> > > \n> > > For my own reference:\n> > > Acked-for-MFD-by: Lee Jones \n> > > \n> > Thanks for your review. I will add it in the next version.\n> > \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=23.128.96.18; helo=vger.kernel.org;\n envelope-from=linux-rtc-owner@vger.kernel.org; receiver=)","ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=mediatek.com","ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=mediatek.com header.i=@mediatek.com header.a=rsa-sha256\n header.s=dk header.b=ukae1GDH;\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [23.128.96.18])\n\tby ozlabs.org (Postfix) with ESMTP id 495QB85F3Hz9sTC\n\tfor ; Mon, 20 Apr 2020 21:55:28 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S1726720AbgDTLz1 (ORCPT );\n Mon, 20 Apr 2020 07:55:27 -0400","from mailgw01.mediatek.com ([210.61.82.183]:50298 \"EHLO\n mailgw01.mediatek.com\" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org\n with ESMTP id S1726496AbgDTLz0 (ORCPT\n ); Mon, 20 Apr 2020 07:55:26 -0400","from mtkcas06.mediatek.inc [(172.21.101.30)] by\n mailgw01.mediatek.com\n (envelope-from )\n (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS)\n with ESMTP id 1819460659; Mon, 20 Apr 2020 19:55:20 +0800","from mtkcas07.mediatek.inc (172.21.101.84) by\n mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Mon, 20 Apr 2020 19:55:11 +0800","from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc\n (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Mon, 20 Apr 2020 19:55:11 +0800"],"X-UUID":["8cbfb7c460d0456ca6432414d944c442-20200420","8cbfb7c460d0456ca6432414d944c442-20200420"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n d=mediatek.com; s=dk;\n h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID;\n bh=G75ycipgYh3BzGzGfO3AsO2FJWOZiqx83AQbRPGl/w4=;\n b=ukae1GDHcJMmsq2JCdcQfACm1ErS6V0y9GxlzzhgRVsntqwu7/tMG6z1bbznV/WKGANPXmHMsO2fNaq/yhOVs1SyMJK1NRYHJfwr2zXOaWpAJYKI5o84NJmwxcdn7FDs9x2OsISvWOB2MN5F0sHnG+oQTbQXoDqhhromAMsEcKc=;","Message-ID":"<1587383712.11642.0.camel@mtksdaap41>","Subject":"Re: [PATCH v12 1/6] mfd: mt6397: Modify suspend/resume behavior","From":"Hsin-hsiung Wang ","To":"Lee Jones ","CC":"Mark Rutland ,\n Kate Stewart ,\n Alexandre Belloni ,\n ,\n \"Richard Fontana\" ,\n ,\n Nicolas Boichat ,\n , ,\n Frank Wunderlich ,\n Ran Bi ,\n Sean Wang ,\n \"Rob Herring\" ,\n ,\n \"Matthias Brugger\" ,\n Thomas Gleixner ,\n Eddie Huang ,\n ,\n Alessandro Zummo ,\n Josef Friedl ,\n , Sebastian Reichel ","Date":"Mon, 20 Apr 2020 19:55:12 +0800","In-Reply-To":"<20200420111522.GB3612@dell>","References":"<1586333531-21641-1-git-send-email-hsin-hsiung.wang@mediatek.com>\n <1586333531-21641-2-git-send-email-hsin-hsiung.wang@mediatek.com>\n <20200416084910.GX2167633@dell> <1587379959.6297.2.camel@mtksdaap41>\n <20200420111522.GB3612@dell>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.10.4-0ubuntu2 ","MIME-Version":"1.0","X-MTK":"N","Content-Transfer-Encoding":"base64","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"}}]