[{"id":2258389,"web_url":"http://patchwork.ozlabs.org/comment/2258389/","msgid":"<20190912145203.GS3431@localhost.localdomain>","list_archive_url":null,"date":"2019-09-12T14:52:03","subject":"Re: [PATCH v2 net 2/3] sctp: remove redundant assignment when call\n\tsctp_get_port_local","submitter":{"id":65333,"url":"http://patchwork.ozlabs.org/api/people/65333/","name":"Marcelo Ricardo Leitner","email":"marcelo.leitner@gmail.com"},"content":"On Thu, Sep 12, 2019 at 12:02:18PM +0800, Mao Wenan wrote:\n> There are more parentheses in if clause when call sctp_get_port_local\n> in sctp_do_bind, and redundant assignment to 'ret'. This patch is to\n> do cleanup.\n> \n> Signed-off-by: Mao Wenan \n> Acked-by: Neil Horman \n\nAcked-by: Marcelo Ricardo Leitner ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming-netdev@ozlabs.org","Delivered-To":"patchwork-incoming-netdev@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdmarc=pass (p=none dis=none) header.from=gmail.com","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"TKQgwHFv\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 46ThZ25PZ1z9sNk\n\tfor ;\n\tFri, 13 Sep 2019 00:52:10 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1732844AbfILOwH (ORCPT\n\t);\n\tThu, 12 Sep 2019 10:52:07 -0400","from mail-qk1-f196.google.com ([209.85.222.196]:33187 \"EHLO\n\tmail-qk1-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1732828AbfILOwH (ORCPT\n\t); Thu, 12 Sep 2019 10:52:07 -0400","by mail-qk1-f196.google.com with SMTP id x134so24761313qkb.0;\n\tThu, 12 Sep 2019 07:52:06 -0700 (PDT)","from localhost.localdomain\n\t([2001:1284:f016:e600:cd79:21fe:b069:7c04])\n\tby smtp.gmail.com with ESMTPSA id\n\ta4sm11662247qkf.91.2019.09.12.07.52.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 12 Sep 2019 07:52:05 -0700 (PDT)","by localhost.localdomain (Postfix, from userid 1000)\n\tid 322E6C0DAD; Thu, 12 Sep 2019 11:52:03 -0300 (-03)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=z4HQp7N624oJ0yhlnqhzRGFHkFho3LSPD+l62lmMuTU=;\n\tb=TKQgwHFvbeqR4PGRQJw7bYJ5lsVB1XDCd5XTAD///awMpCWVdslTN4QmcCPYLR+/3J\n\teYVeVThtkRkuJE/eRH7kmeH1wpnWbqb0yxfXePZo+ZutBOCS/VVVtbjP97W+02XysG5Q\n\tgINMLfhzEaLKILtA2Ch8RnEajYC+1XM8Lj6f6pKKR2OZuu04C5cFZmg1YN210BI6QHf6\n\tGwisLYxQ/GsUGuoP9nIsjU+D3XkOy7Oamlrf0fiLC31mIGhX56kZmj8J1MAEeDGTCAWu\n\tW0GaiuL+bv9gLg/5DwLfXLJ76Md8hnq9fXmVoN3R/foXhAgKK7C2guV4A7kSrefDIeSv\n\tUO1Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=z4HQp7N624oJ0yhlnqhzRGFHkFho3LSPD+l62lmMuTU=;\n\tb=O62onF1B+d8dS9f1KYzy0lMXWxFLLIzJpfEe4Ggdazz7RNncZsuMAXonp+h+VR18Y0\n\tpRGKlEkCKpfzloQWs31FYfgAbfi1BeyShUJ6+ZCTWy/tfNP1U2QHKk7ws7d7DU9qfGV/\n\tjV1HjjqejSbm16+Z7P3F466qjjh/XTS4BX/QgbdOh6DUPslTPXanypSF+q1YuEPQ0nyt\n\t3Br/XI1t3hJzLZuwuH5R/MCbNKMvO/eVhuAau3Rx8Nc6zPaDfOT2DhWzXtGxwRZeHUD8\n\tXZlRmaxz4zDz+N7EtYahMwjQb1XupVb+geodQ9fGzF/GFM4A0aYIWzupcueIZyNGrbhQ\n\tbHdw==","X-Gm-Message-State":"APjAAAWUlY25ohXPn8VcrQnnPClLv3NQM/HtDtF+FvaJ084KWO5TBMAw\n\tnPV6m5FyksuQ/zCNYVEU8DA=","X-Google-Smtp-Source":"APXvYqzAybPb42+If5M7wdu02AJv8jhm3orWyoi/nf38zkcPlKLB2bk/UHjLqATlDTtN1j+ixKaJ9w==","X-Received":"by 2002:a05:620a:15fc:: with SMTP id\n\tp28mr10347606qkm.487.1568299926291; \n\tThu, 12 Sep 2019 07:52:06 -0700 (PDT)","Date":"Thu, 12 Sep 2019 11:52:03 -0300","From":"Marcelo Ricardo Leitner ","To":"Mao Wenan ","Cc":"vyasevich@gmail.com, nhorman@tuxdriver.com, davem@davemloft.net,\n\tlinux-sctp@vger.kernel.org, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org","Subject":"Re: [PATCH v2 net 2/3] sctp: remove redundant assignment when call\n\tsctp_get_port_local","Message-ID":"<20190912145203.GS3431@localhost.localdomain>","References":"<7a450679-40ca-8a84-4cba-7a16f22ea3c0@huawei.com>\n\t<20190912040219.67517-1-maowenan@huawei.com>\n\t<20190912040219.67517-3-maowenan@huawei.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20190912040219.67517-3-maowenan@huawei.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]