[{"id":2258390,"web_url":"http://patchwork.ozlabs.org/comment/2258390/","msgid":"<20190912145218.GT3431@localhost.localdomain>","list_archive_url":null,"date":"2019-09-12T14:52:18","subject":"Re: [PATCH v2 net 3/3] sctp: destroy bucket if failed to bind addr","submitter":{"id":65333,"url":"http://patchwork.ozlabs.org/api/people/65333/","name":"Marcelo Ricardo Leitner","email":"marcelo.leitner@gmail.com"},"content":"On Thu, Sep 12, 2019 at 12:02:19PM +0800, Mao Wenan wrote:\n> There is one memory leak bug report:\n> BUG: memory leak\n> unreferenced object 0xffff8881dc4c5ec0 (size 40):\n> comm \"syz-executor.0\", pid 5673, jiffies 4298198457 (age 27.578s)\n> hex dump (first 32 bytes):\n> 02 00 00 00 81 88 ff ff 00 00 00 00 00 00 00 00 ................\n> f8 63 3d c1 81 88 ff ff 00 00 00 00 00 00 00 00 .c=.............\n> backtrace:\n> [<0000000072006339>] sctp_get_port_local+0x2a1/0xa00 [sctp]\n> [<00000000c7b379ec>] sctp_do_bind+0x176/0x2c0 [sctp]\n> [<000000005be274a2>] sctp_bind+0x5a/0x80 [sctp]\n> [<00000000b66b4044>] inet6_bind+0x59/0xd0 [ipv6]\n> [<00000000c68c7f42>] __sys_bind+0x120/0x1f0 net/socket.c:1647\n> [<000000004513635b>] __do_sys_bind net/socket.c:1658 [inline]\n> [<000000004513635b>] __se_sys_bind net/socket.c:1656 [inline]\n> [<000000004513635b>] __x64_sys_bind+0x3e/0x50 net/socket.c:1656\n> [<0000000061f2501e>] do_syscall_64+0x72/0x2e0 arch/x86/entry/common.c:296\n> [<0000000003d1e05e>] entry_SYSCALL_64_after_hwframe+0x49/0xbe\n> \n> This is because in sctp_do_bind, if sctp_get_port_local is to\n> create hash bucket successfully, and sctp_add_bind_addr failed\n> to bind address, e.g return -ENOMEM, so memory leak found, it\n> needs to destroy allocated bucket.\n> \n> Reported-by: Hulk Robot \n> Signed-off-by: Mao Wenan \n> Acked-by: Neil Horman \n\nAcked-by: Marcelo Ricardo Leitner ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming-netdev@ozlabs.org","Delivered-To":"patchwork-incoming-netdev@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdmarc=pass (p=none dis=none) header.from=gmail.com","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"GyqcPE4/\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 46ThZL1WdHz9sN1\n\tfor ;\n\tFri, 13 Sep 2019 00:52:26 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1732865AbfILOwX (ORCPT\n\t);\n\tThu, 12 Sep 2019 10:52:23 -0400","from mail-qk1-f195.google.com ([209.85.222.195]:37580 \"EHLO\n\tmail-qk1-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1732777AbfILOwW (ORCPT\n\t); Thu, 12 Sep 2019 10:52:22 -0400","by mail-qk1-f195.google.com with SMTP id u184so21855464qkd.4;\n\tThu, 12 Sep 2019 07:52:22 -0700 (PDT)","from localhost.localdomain\n\t([2001:1284:f016:e600:cd79:21fe:b069:7c04])\n\tby smtp.gmail.com with ESMTPSA id\n\tm19sm12221716qke.22.2019.09.12.07.52.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 12 Sep 2019 07:52:20 -0700 (PDT)","by localhost.localdomain (Postfix, from userid 1000)\n\tid 5B906C0DAD; Thu, 12 Sep 2019 11:52:18 -0300 (-03)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=4TYD+cMewnYL5z3ieEOxCFAZpD0FvyxKAgBZKpsQKLA=;\n\tb=GyqcPE4/EQBaVHpCqx2y3ZULViVFVL8tffo3OyPRfyuexXAahJ07HdkYnsrFM4+Cb4\n\tmvyCnZyx37tY7lxrXcZ+G6iXswOE12khIZ6PgJNpmrNcFd0mqeZhatW3hbubKYuDuNED\n\t9AqqRDHLKy/PvNSE7RvUFkEIwurppFR70hMCcanG1PbPfs2M5LNRgSH1MTTT3765f7Zt\n\tkQALaE1WvCoZkRSESWnB5HYlEIBDHqJ7OZ2b67QTo1HsxzckrBnS+GmwO4p1xkumgexT\n\t2DnZYC6XURzprpCttbU2uKTQ+joNI0HKRU0JimpA7mRFi9DksFfFtNgQb4fRNTXGRUsz\n\tXRtg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=4TYD+cMewnYL5z3ieEOxCFAZpD0FvyxKAgBZKpsQKLA=;\n\tb=f+ZtiHI5X8lgUYYQzXfj9kWJKYEMu6cEv/o6WTBudwWotEQOmvMk1J3heltKUr6HnS\n\tJmhlBTUjxxhXnY43PMPGN11Pb8dFaAbGwRj64cAAWdVSMeN5kCWfLcAz+dKyHcaOOczC\n\t/2++bq/CqZGcfpD7tzDzWXH+EKuyPYB418yJtMgBsw/U2Nyzb3f0mow7wFqdbMB2JA4F\n\tmO4pMkZX60KTFiXgbQyrud2mtYXcUl3YKmEvR6jMjWD4FuP5EmKO2iCgXIYGGO6Af1xi\n\tYSp48O4xm7wudfISzwIByilT8koHdSb+ayMdwjUIfph9ICfRICjqLMbSfHZxMK3T+vIw\n\tyYQQ==","X-Gm-Message-State":"APjAAAXZmiHHwf4wr+HXQAerSQT6c7MbO9lwd/6nzSH0vyuAfKD4UjwF\n\tbSCCS7cHHAzt/bIa0/EGLqM=","X-Google-Smtp-Source":"APXvYqxQjjKFbfTR+SpYcWqcPiDQhipECrd3HCTLf8/FABccUvYHLTIU8NhZGCKAE4FLtRF7Vcvv1Q==","X-Received":"by 2002:a37:6681:: with SMTP id\n\ta123mr39180452qkc.499.1568299941468; \n\tThu, 12 Sep 2019 07:52:21 -0700 (PDT)","Date":"Thu, 12 Sep 2019 11:52:18 -0300","From":"Marcelo Ricardo Leitner ","To":"Mao Wenan ","Cc":"vyasevich@gmail.com, nhorman@tuxdriver.com, davem@davemloft.net,\n\tlinux-sctp@vger.kernel.org, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,\n\tHulk Robot ","Subject":"Re: [PATCH v2 net 3/3] sctp: destroy bucket if failed to bind addr","Message-ID":"<20190912145218.GT3431@localhost.localdomain>","References":"<7a450679-40ca-8a84-4cba-7a16f22ea3c0@huawei.com>\n\t<20190912040219.67517-1-maowenan@huawei.com>\n\t<20190912040219.67517-4-maowenan@huawei.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20190912040219.67517-4-maowenan@huawei.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]