[{"id":2246989,"web_url":"http://patchwork.ozlabs.org/comment/2246989/","msgid":"<87mufv2oye.fsf@concordia.ellerman.id.au>","date":"2019-08-27T04:48:41","subject":"Re: [PATCH kernel v2 4/4] powerpc/powernv/ioda: Remove obsolete\n\tiommu_table_ops::exchange callbacks","submitter":{"id":46580,"url":"http://patchwork.ozlabs.org/api/people/46580/","name":"Michael Ellerman","email":"mpe@ellerman.id.au"},"content":"Alexey Kardashevskiy writes:\n> As now we have xchg_no_kill/tce_kill, these are not used anymore so\n> remove them.\n>\n> Signed-off-by: Alexey Kardashevskiy \n> ---\n> arch/powerpc/include/asm/iommu.h | 10 -----\n> arch/powerpc/kernel/iommu.c | 26 +-----------\n> arch/powerpc/platforms/powernv/pci-ioda.c | 50 -----------------------\n> 3 files changed, 1 insertion(+), 85 deletions(-)\n\nThis doesn't build:\n\narch/powerpc/platforms/pseries/iommu.c:652:3: error: 'struct iommu_table_ops' has no member named 'exchange'\n .exchange = tce_exchange_pseries,\n ^~~~~~~~\narch/powerpc/platforms/pseries/iommu.c:652:14: error: initialization of 'int (*)(struct iommu_table *, long int, long unsigned int *, enum dma_data_direction *, bool)' {aka 'int (*)(struct iommu_table *, long int, long unsigned int *, enum dma_data_direction *, _Bool)'} from incompatible pointer type 'int (*)(struct iommu_table *, long int, long unsigned int *, enum dma_data_direction *)' [-Werror=incompatible-pointer-types]\n .exchange = tce_exchange_pseries,\n ^~~~~~~~~~~~~~~~~~~~\n\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 46Hbyh4y1Nz9s00\n\tfor ;\n\tTue, 27 Aug 2019 14:50:04 +1000 (AEST)","from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 46Hbyh1WTgzDqrq\n\tfor ;\n\tTue, 27 Aug 2019 14:50:04 +1000 (AEST)","from ozlabs.org (bilbo.ozlabs.org [203.11.71.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 46Hbx60YhQzDqlS\n\tfor ;\n\tTue, 27 Aug 2019 14:48:42 +1000 (AEST)","from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mail.ozlabs.org (Postfix) with ESMTPSA id 46Hbx52WCgz9s00;\n\tTue, 27 Aug 2019 14:48:41 +1000 (AEST)"],"Authentication-Results":["ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=ellerman.id.au","lists.ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=ellerman.id.au"],"From":"Michael Ellerman ","To":"Alexey Kardashevskiy , linuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH kernel v2 4/4] powerpc/powernv/ioda: Remove obsolete\n\tiommu_table_ops::exchange callbacks","In-Reply-To":"<20190826061705.92048-5-aik@ozlabs.ru>","References":"<20190826061705.92048-1-aik@ozlabs.ru>\n\t<20190826061705.92048-5-aik@ozlabs.ru>","Date":"Tue, 27 Aug 2019 14:48:41 +1000","Message-ID":"<87mufv2oye.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kvm@vger.kernel.org, Alexey Kardashevskiy ,\n\tAlistair Popple , kvm-ppc@vger.kernel.org,\n\tAlex Williamson ,\n\tDavid Gibson ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]