[{"id":2196595,"web_url":"http://patchwork.ozlabs.org/comment/2196595/","msgid":"<20190618114815.GJ28892@ulmo>","list_archive_url":null,"date":"2019-06-18T11:48:15","subject":"Re: [PATCH V3 07/17] clk: tegra: save and restore CPU and System\n\tclocks context","submitter":{"id":26234,"url":"http://patchwork.ozlabs.org/api/people/26234/","name":"Thierry Reding","email":"thierry.reding@gmail.com"},"content":"On Tue, Jun 18, 2019 at 12:46:21AM -0700, Sowjanya Komatineni wrote:\n> During system suspend state, core power goes off and looses all the\n> CAR controller register settings.\n> \n> This patch creates APIs for saving and restoring the context of Tegra\n> CPUG, CPULP and SCLK.\n> \n> CPU and System clock context includes\n> - CPUG, CPULP, and SCLK burst policy settings for clock sourcea of all\n> their normal states.\n> - SCLK divisor and System clock rate for restoring SCLK, AHB and APB\n> rates on resume.\n> - OSC_DIV settings which are used as reference clock input to some PLLs.\n> - SPARE_REG and CLK_MASK settings.\n> \n> These APIs are used in Tegra210 clock driver during suspend and resume\n> operation.\n> \n> Signed-off-by: Sowjanya Komatineni \n> ---\n> drivers/clk/tegra/clk-tegra-super-gen4.c | 4 --\n> drivers/clk/tegra/clk.c | 80 ++++++++++++++++++++++++++++++++\n> drivers/clk/tegra/clk.h | 14 ++++++\n> 3 files changed, 94 insertions(+), 4 deletions(-)\n> \n> diff --git a/drivers/clk/tegra/clk-tegra-super-gen4.c b/drivers/clk/tegra/clk-tegra-super-gen4.c\n> index cdfe7c9697e1..ed69ec4d883e 100644\n> --- a/drivers/clk/tegra/clk-tegra-super-gen4.c\n> +++ b/drivers/clk/tegra/clk-tegra-super-gen4.c\n> @@ -19,10 +19,6 @@\n> #define PLLX_MISC2 0x514\n> #define PLLX_MISC3 0x518\n> \n> -#define CCLKG_BURST_POLICY 0x368\n> -#define CCLKLP_BURST_POLICY 0x370\n> -#define SCLK_BURST_POLICY 0x028\n> -#define SYSTEM_CLK_RATE 0x030\n> #define SCLK_DIVIDER 0x2c\n> \n> static DEFINE_SPINLOCK(sysrate_lock);\n> diff --git a/drivers/clk/tegra/clk.c b/drivers/clk/tegra/clk.c\n> index 573e3c967ae1..26690663157a 100644\n> --- a/drivers/clk/tegra/clk.c\n> +++ b/drivers/clk/tegra/clk.c\n> @@ -70,6 +70,12 @@ static struct clk **clks;\n> static int clk_num;\n> static struct clk_onecell_data clk_data;\n> \n> +static u32 cclkg_burst_policy_ctx[2];\n> +static u32 cclklp_burst_policy_ctx[2];\n> +static u32 sclk_burst_policy_ctx[2];\n> +static u32 sys_clk_divisor_ctx, system_rate_ctx;\n> +static u32 spare_ctx, misc_clk_enb_ctx, clk_arm_ctx;\n> +\n> /* Handlers for SoC-specific reset lines */\n> static int (*special_reset_assert)(unsigned long);\n> static int (*special_reset_deassert)(unsigned long);\n> @@ -199,6 +205,80 @@ const struct tegra_clk_periph_regs *get_reg_bank(int clkid)\n> \t}\n> }\n> \n> +void tegra_cclkg_burst_policy_save_context(void)\n> +{\n> +\tint i;\n\nThis here (and the same goes for the other functions below) can be\nunsigned int.\n\nOtherwise:\n\nAcked-by: Thierry Reding ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdmarc=pass (p=none dis=none) header.from=gmail.com","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"tv1hYFmi\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 45SmYf6jvpz9sN6\n\tfor ;\n\tTue, 18 Jun 2019 21:48:22 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1729678AbfFRLsV (ORCPT );\n\tTue, 18 Jun 2019 07:48:21 -0400","from mail-wm1-f65.google.com ([209.85.128.65]:39226 \"EHLO\n\tmail-wm1-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1729110AbfFRLsV (ORCPT\n\t); Tue, 18 Jun 2019 07:48:21 -0400","by mail-wm1-f65.google.com with SMTP id z23so2898821wma.4;\n\tTue, 18 Jun 2019 04:48:18 -0700 (PDT)","from localhost (p2E5BEF36.dip0.t-ipconnect.de. [46.91.239.54])\n\tby smtp.gmail.com with ESMTPSA id\n\tj32sm3867398wrj.43.2019.06.18.04.48.16\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tTue, 18 Jun 2019 04:48:16 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=aputY+jrLKzNvsn2gIWdwHDyDuWhnjMSp3SALQclCyg=;\n\tb=tv1hYFmiPEVC4QTm2Mn1WsE6YDsJraeWi5I/PzvR3xiW/Sg6p7sw4CTfdpSI//ZvvJ\n\tmKpf5o3KtQS82K1aPCjQ5eL262VllB2DAfWoxeh5zF0jdOnWqWLRCRh4DHmRoqTwpkVR\n\t0uDjS+lDTZt3obZSc64ev2ne/T4dB7nXftB6DtEtsVmFcoZ9Hi7py+uvdEB98VUnl8Ph\n\tARJmn4WAnzCt268B4TL5kDDLXOL/RtFyFhPydbUvwVE8QHCGP9PCrMz0Rkf6cSiQcWBf\n\tNTuxN4J6CkbSQPXMHMvq2J+IrXIP2gLtwyqwA8VVMuhtOt240u9Ula4POQeo0R0IKOPz\n\txKjw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=aputY+jrLKzNvsn2gIWdwHDyDuWhnjMSp3SALQclCyg=;\n\tb=rHBVY6XWKoKyiEOmpG7nDFEJ7hvuFG1e5QJj3bVcg+aqaoir9x5vqUiYUiFnKLXDca\n\ttMWIcuKAXjG4ZrRdIWxTKnkQ+vHJBz7wtK05cyIQ9PYGvNyRoxiq0MlMzdQZfSGIpkjz\n\t7lPFUkhzKiRm3rnJD3XfGmOSzsfJeKS7irrrtlWXcphvMG6i8nIn6U1H0LAltDchIkgv\n\taz+eckkZHEi/WN79Kg0gTHHb3Cq1vVTHEVnqFI7bLFwBxgfJvyo+8Ts1UOXNQArzu2MT\n\tfNJGyX8aVbqNBorgQYZmgatxdBOX9qPj55UGG7IzaV89wIB3SIUzMNn7BJBOQNMgbTp3\n\tN1FQ==","X-Gm-Message-State":"APjAAAWHDXkYt0j8Djz42Ngzuf+vwXdrIPys7NH0brJ36LETECn6tyhZ\n\tzU2awaILbAASh8kNvX/gDy4=","X-Google-Smtp-Source":"APXvYqyGM4Z8puL/PdvjJNLsnLMIRlD6Pf3Buukr3nVqDAzH/2VXj+M1dIeyU/ZlvW/KhuKKaoT/WA==","X-Received":"by 2002:a1c:b707:: with SMTP id h7mr3193707wmf.45.1560858496862; \n\tTue, 18 Jun 2019 04:48:16 -0700 (PDT)","Date":"Tue, 18 Jun 2019 13:48:15 +0200","From":"Thierry Reding ","To":"Sowjanya Komatineni ","Cc":"jonathanh@nvidia.com, tglx@linutronix.de, jason@lakedaemon.net,\n\tmarc.zyngier@arm.com, linus.walleij@linaro.org, stefan@agner.ch,\n\tmark.rutland@arm.com, pdeschrijver@nvidia.com, pgaikwad@nvidia.com,\n\tsboyd@kernel.org, linux-clk@vger.kernel.org,\n\tlinux-gpio@vger.kernel.org, jckuo@nvidia.com, josephl@nvidia.com,\n\ttalho@nvidia.com, linux-tegra@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, mperttunen@nvidia.com,\n\tspatra@nvidia.com, robh+dt@kernel.org, digetx@gmail.com,\n\tdevicetree@vger.kernel.org","Subject":"Re: [PATCH V3 07/17] clk: tegra: save and restore CPU and System\n\tclocks context","Message-ID":"<20190618114815.GJ28892@ulmo>","References":"<1560843991-24123-1-git-send-email-skomatineni@nvidia.com>\n\t<1560843991-24123-8-git-send-email-skomatineni@nvidia.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"KZLWU/9q3evlN4nQ\"","Content-Disposition":"inline","In-Reply-To":"<1560843991-24123-8-git-send-email-skomatineni@nvidia.com>","User-Agent":"Mutt/1.11.4 (2019-03-13)","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}}]