[{"id":2080960,"web_url":"http://patchwork.ozlabs.org/comment/2080960/","msgid":"<20190131092309.5jfyvo7hgq2ui3ok@wunner.de>","list_archive_url":null,"date":"2019-01-31T09:23:09","subject":"Re: [PATCH 09/28] thunderbolt: Cache adapter specific capability\n\toffset into struct port","submitter":{"id":68499,"url":"http://patchwork.ozlabs.org/api/people/68499/","name":"Lukas Wunner","email":"lukas@wunner.de"},"content":"On Tue, Jan 29, 2019 at 06:01:24PM +0300, Mika Westerberg wrote:\n> --- a/drivers/thunderbolt/tb.h\n> +++ b/drivers/thunderbolt/tb.h\n> @@ -124,6 +124,8 @@ struct tb_switch {\n> * @remote: Remote port (%NULL if not connected)\n> * @xdomain: Remote host (%NULL if not connected)\n> * @cap_phy: Offset, zero if not found\n> + * @cap_adap: Offset of the adapter specific capability. Negative if not\n> + *\t present.\n\nHm, could cap_adap be made zero in the non-presence case for consistency\nwith cap_phy?\n\nThanks,\n\nLukas","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming-netdev@ozlabs.org","Delivered-To":"patchwork-incoming-netdev@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=wunner.de"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 43qvsw6trTz9sDB\n\tfor ;\n\tThu, 31 Jan 2019 20:23:16 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1729169AbfAaJXL (ORCPT\n\t);\n\tThu, 31 Jan 2019 04:23:11 -0500","from bmailout1.hostsharing.net ([83.223.95.100]:48837 \"EHLO\n\tbmailout1.hostsharing.net\" rhost-flags-OK-OK-OK-OK) by\n\tvger.kernel.org with ESMTP id S1726440AbfAaJXL (ORCPT\n\t); Thu, 31 Jan 2019 04:23:11 -0500","from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (Client CN \"*.hostsharing.net\",\n\tIssuer \"COMODO RSA Domain Validation Secure Server CA\" (not\n\tverified))\n\tby bmailout1.hostsharing.net (Postfix) with ESMTPS id 62E1230000CDD; \n\tThu, 31 Jan 2019 10:23:09 +0100 (CET)","by h08.hostsharing.net (Postfix, from userid 100393)\n\tid 25B5710875; Thu, 31 Jan 2019 10:23:09 +0100 (CET)"],"Date":"Thu, 31 Jan 2019 10:23:09 +0100","From":"Lukas Wunner ","To":"Mika Westerberg ","Cc":"linux-kernel@vger.kernel.org, Michael Jamet ,\n\tYehezkel Bernat ,\n\tAndreas Noever ,\n\t\"David S . Miller\" ,\n\tAndy Shevchenko ,\n\tnetdev@vger.kernel.org","Subject":"Re: [PATCH 09/28] thunderbolt: Cache adapter specific capability\n\toffset into struct port","Message-ID":"<20190131092309.5jfyvo7hgq2ui3ok@wunner.de>","References":"<20190129150143.12681-1-mika.westerberg@linux.intel.com>\n\t<20190129150143.12681-10-mika.westerberg@linux.intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20190129150143.12681-10-mika.westerberg@linux.intel.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":2080971,"web_url":"http://patchwork.ozlabs.org/comment/2080971/","msgid":"<20190131093727.GX7875@lahna.fi.intel.com>","list_archive_url":null,"date":"2019-01-31T09:37:27","subject":"Re: [PATCH 09/28] thunderbolt: Cache adapter specific capability\n\toffset into struct port","submitter":{"id":14534,"url":"http://patchwork.ozlabs.org/api/people/14534/","name":"Mika Westerberg","email":"mika.westerberg@linux.intel.com"},"content":"On Thu, Jan 31, 2019 at 10:23:09AM +0100, Lukas Wunner wrote:\n> On Tue, Jan 29, 2019 at 06:01:24PM +0300, Mika Westerberg wrote:\n> > --- a/drivers/thunderbolt/tb.h\n> > +++ b/drivers/thunderbolt/tb.h\n> > @@ -124,6 +124,8 @@ struct tb_switch {\n> > * @remote: Remote port (%NULL if not connected)\n> > * @xdomain: Remote host (%NULL if not connected)\n> > * @cap_phy: Offset, zero if not found\n> > + * @cap_adap: Offset of the adapter specific capability. Negative if not\n> > + *\t present.\n> \n> Hm, could cap_adap be made zero in the non-presence case for consistency\n> with cap_phy?\n\nSure.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming-netdev@ozlabs.org","Delivered-To":"patchwork-incoming-netdev@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=linux.intel.com"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 43qwBQ4kS6z9sDB\n\tfor ;\n\tThu, 31 Jan 2019 20:37:34 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1731716AbfAaJhd (ORCPT\n\t);\n\tThu, 31 Jan 2019 04:37:33 -0500","from mga02.intel.com ([134.134.136.20]:8097 \"EHLO mga02.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1726440AbfAaJhc (ORCPT );\n\tThu, 31 Jan 2019 04:37:32 -0500","from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t31 Jan 2019 01:37:31 -0800","from lahna.fi.intel.com (HELO lahna) ([10.237.72.157])\n\tby FMSMGA003.fm.intel.com with SMTP; 31 Jan 2019 01:37:28 -0800","by lahna (sSMTP sendmail emulation);\n\tThu, 31 Jan 2019 11:37:27 +0200"],"X-Amp-Result":"UNSCANNABLE","X-Amp-File-Uploaded":"False","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.56,543,1539673200\"; d=\"scan'208\";a=\"130003963\"","Date":"Thu, 31 Jan 2019 11:37:27 +0200","From":"Mika Westerberg ","To":"Lukas Wunner ","Cc":"linux-kernel@vger.kernel.org, Michael Jamet ,\n\tYehezkel Bernat ,\n\tAndreas Noever ,\n\t\"David S . Miller\" ,\n\tAndy Shevchenko ,\n\tnetdev@vger.kernel.org","Subject":"Re: [PATCH 09/28] thunderbolt: Cache adapter specific capability\n\toffset into struct port","Message-ID":"<20190131093727.GX7875@lahna.fi.intel.com>","References":"<20190129150143.12681-1-mika.westerberg@linux.intel.com>\n\t<20190129150143.12681-10-mika.westerberg@linux.intel.com>\n\t<20190131092309.5jfyvo7hgq2ui3ok@wunner.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20190131092309.5jfyvo7hgq2ui3ok@wunner.de>","Organization":"Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo","User-Agent":"Mutt/1.10.1 (2018-07-13)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]