[{"id":1798473,"web_url":"http://patchwork.ozlabs.org/comment/1798473/","msgid":"<20171103091533.GE23381@w540>","list_archive_url":null,"date":"2017-11-03T09:15:33","subject":"Re: [PATCH RFT 0/5] i2c: sh_mobile: refactor HW init/deinit","submitter":{"id":70491,"url":"http://patchwork.ozlabs.org/api/people/70491/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Wolfram,\n\nOn Thu, Nov 02, 2017 at 01:47:26PM +0100, Wolfram Sang wrote:\n> When clearing the ICE bit, all registers fall back to their defaut value. That\n> allows for some simplifications in the code.\n>\n> Tested on a Renesas Lager board (R-Car H2) doing a bunch of consecutive\n> commands. No spurious interrupts have been observed and the signals look\n> exactly the same when visualized with sigrok.\n>\n> According to the docs, the ICE bit behaviour is the same since the beginning of\n> this driver (sh7722) for the migo-r board.\n>\n> jacopo: can you please test this series while you work on migo-r anyhow? Thank\n> you a ton for that!\n\nI have applied your series on top of my developments on Migo-R\n\n------------------------------------------------------------\n57d007c i2c: sh_mobile: shorten exit of xfer routine\n67dfa18 i2c: sh_mobile: use direct writes when accessing ICE bit\nf44a2df i2c: sh_mobile: manually \"inline\" two short functions\n5d656b6 i2c: sh_mobile: remove redundant deinitialization\n9d2b8cc i2c: sh_mobile: remove redundant initialization\ncac9723 arch: sh: migor: Use new CEU camera driver\n...\n------------------------------------------------------------\n\nAnd I can successfully probe the camera sensor\n\n------------------------------------------------------------\ni2c i2c-0: master_xfer[0] W, addr=0x21, len=1\ni2c i2c-0: master_xfer[1] R, addr=0x21, len=1\ni2c i2c-0: master_xfer[0] W, addr=0x21, len=1\ni2c i2c-0: master_xfer[1] R, addr=0x21, len=1\ni2c i2c-0: master_xfer[0] W, addr=0x21, len=1\ni2c i2c-0: master_xfer[1] R, addr=0x21, len=1\ni2c i2c-0: master_xfer[0] W, addr=0x21, len=1\ni2c i2c-0: master_xfer[1] R, addr=0x21, len=1\nov772x 0-0021: ov7725 Product ID 77:21 Manufacturer ID 7f:a2\n------------------------------------------------------------\n\nAs well as set format on it without noticeable errors\n\n------------------------------------------------------------\ni2c i2c-0: master_xfer[0] W, addr=0x21, len=1\ni2c i2c-0: master_xfer[1] R, addr=0x21, len=1\ni2c i2c-0: master_xfer[0] W, addr=0x21, len=2\ni2c i2c-0: master_xfer[0] W, addr=0x21, len=2\ni2c i2c-0: master_xfer[0] W, addr=0x21, len=2\ni2c i2c-0: master_xfer[0] W, addr=0x21, len=2\ni2c i2c-0: master_xfer[0] W, addr=0x21, len=2\ni2c i2c-0: master_xfer[0] W, addr=0x21, len=2\ni2c i2c-0: master_xfer[0] W, addr=0x21, len=2\ni2c i2c-0: master_xfer[0] W, addr=0x21, len=2\ni2c i2c-0: master_xfer[0] W, addr=0x21, len=2\ni2c i2c-0: master_xfer[0] W, addr=0x21, len=1\ni2c i2c-0: master_xfer[1] R, addr=0x21, len=1\ni2c i2c-0: master_xfer[0] W, addr=0x21, len=2\ni2c i2c-0: master_xfer[0] W, addr=0x21, len=2\n------------------------------------------------------------\n\nI cannot try capture, as I currently have issues with mmap on SH4 :(\n\nIf you want me to run some specific tests, let me know.\nOtherwise you can add my\n\nTested-by: Jacopo Mondi \n\nCheers!\n j\n>\n> Looking forward to other comments, as well...\n>\n>\n> Wolfram Sang (5):\n> i2c: sh_mobile: remove redundant initialization\n> i2c: sh_mobile: remove redundant deinitialization\n> i2c: sh_mobile: manually \"inline\" two short functions\n> i2c: sh_mobile: use direct writes when accessing ICE bit\n> i2c: sh_mobile: shorten exit of xfer routine\n>\n> drivers/i2c/busses/i2c-sh_mobile.c | 50 +++++++++-----------------------------\n> 1 file changed, 12 insertions(+), 38 deletions(-)\n>\n> --\n> 2.11.0\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ySxBh2DTPz9s9Y\n\tfor ;\n\tFri, 3 Nov 2017 20:15:40 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755420AbdKCJPi (ORCPT );\n\tFri, 3 Nov 2017 05:15:38 -0400","from relay4-d.mail.gandi.net ([217.70.183.196]:48635 \"EHLO\n\trelay4-d.mail.gandi.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754612AbdKCJPh (ORCPT\n\t); Fri, 3 Nov 2017 05:15:37 -0400","from w540 (unknown [IPv6:2001:b07:6442:1ac4:5c3:b1f5:91e5:1266])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id E6CDC17209C;\n\tFri, 3 Nov 2017 10:15:34 +0100 (CET)"],"Date":"Fri, 3 Nov 2017 10:15:33 +0100","From":"jacopo mondi ","To":"Wolfram Sang ","Cc":"linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org,\n\tYoshihiro Shimoda ","Subject":"Re: [PATCH RFT 0/5] i2c: sh_mobile: refactor HW init/deinit","Message-ID":"<20171103091533.GE23381@w540>","References":"<20171102124731.10484-1-wsa+renesas@sang-engineering.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20171102124731.10484-1-wsa+renesas@sang-engineering.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}},{"id":1810827,"web_url":"http://patchwork.ozlabs.org/comment/1810827/","msgid":"<20171127175637.fmorzefw3bqfi56r@ninjato>","list_archive_url":null,"date":"2017-11-27T17:56:37","subject":"Re: [PATCH RFT 0/5] i2c: sh_mobile: refactor HW init/deinit","submitter":{"id":22495,"url":"http://patchwork.ozlabs.org/api/people/22495/","name":"Wolfram Sang","email":"wsa@the-dreams.de"},"content":"On Thu, Nov 02, 2017 at 01:47:26PM +0100, Wolfram Sang wrote:\n> When clearing the ICE bit, all registers fall back to their defaut value. That\n> allows for some simplifications in the code.\n> \n> Tested on a Renesas Lager board (R-Car H2) doing a bunch of consecutive\n> commands. No spurious interrupts have been observed and the signals look\n> exactly the same when visualized with sigrok.\n> \n> According to the docs, the ICE bit behaviour is the same since the beginning of\n> this driver (sh7722) for the migo-r board.\n> \n> jacopo: can you please test this series while you work on migo-r anyhow? Thank\n> you a ton for that!\n> \n> Looking forward to other comments, as well...\n\nWhole series applied to i2c/for-next!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ylvcp1FRmz9ryQ\n\tfor ;\n\tTue, 28 Nov 2017 04:56:42 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753367AbdK0R4k (ORCPT );\n\tMon, 27 Nov 2017 12:56:40 -0500","from sauhun.de ([88.99.104.3]:47836 \"EHLO pokefinder.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1753255AbdK0R4k (ORCPT );\n\tMon, 27 Nov 2017 12:56:40 -0500","from localhost (p54B338DA.dip0.t-ipconnect.de [84.179.56.218])\n\tby pokefinder.org (Postfix) with ESMTPSA id ED0CD2C33B5;\n\tMon, 27 Nov 2017 18:56:38 +0100 (CET)"],"Date":"Mon, 27 Nov 2017 18:56:37 +0100","From":"Wolfram Sang ","To":"Wolfram Sang ","Cc":"linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org,\n\tYoshihiro Shimoda ,\n\tJacopo Mondi ","Subject":"Re: [PATCH RFT 0/5] i2c: sh_mobile: refactor HW init/deinit","Message-ID":"<20171127175637.fmorzefw3bqfi56r@ninjato>","References":"<20171102124731.10484-1-wsa+renesas@sang-engineering.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"q76gsqptxkvxqlb7\"","Content-Disposition":"inline","In-Reply-To":"<20171102124731.10484-1-wsa+renesas@sang-engineering.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}}]