[{"id":1805546,"web_url":"http://patchwork.ozlabs.org/comment/1805546/","msgid":"<87a7zmo81t.fsf@linkitivity.dja.id.au>","list_archive_url":null,"date":"2017-11-16T10:02:38","subject":"Re: [PATCH v2 0/9] Add support for Django 1.11","submitter":{"id":65792,"url":"http://patchwork.ozlabs.org/api/people/65792/","name":"Daniel Axtens","email":"dja@axtens.net"},"content":"Hi Stephen,\n\n> This is a sizable, albeit mostly trivial series focused on (a) adding support\n> for Django 1.11 to Patchwork. Previously this also contained a series of\n> patches aimed at resolving all 'DeprecationWarning's for the versions of Django\n> that we support, but these have since been merged separately.\n\nThe series, with the modifications in my other emails, is:\nTested-by: Daniel Axtens \n\nI haven't specifically examined the patches to the level I'm comfortable\nwith giving them Reviews, but I am confident that they work.\n\nEarlier you talked about a performance regression with 1.11 - did you\never find out anything about that? I have been looking at doing a proper\nperformance test suite, but haven't been able to carve out a chunk of\ntime to do it...\n\nRegards,\nDaniel","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","patchwork@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","patchwork@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ycxd93s9Vz9t62\n\tfor ;\n\tThu, 16 Nov 2017 21:02:53 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3ycxd92h6TzDqyR\n\tfor ;\n\tThu, 16 Nov 2017 21:02:53 +1100 (AEDT)","from mail-pf0-x229.google.com (mail-pf0-x229.google.com\n\t[IPv6:2607:f8b0:400e:c00::229])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3ycxd16Q8GzDqvq\n\tfor ;\n\tThu, 16 Nov 2017 21:02:44 +1100 (AEDT)","by mail-pf0-x229.google.com with SMTP id m88so12011300pfi.9\n\tfor ;\n\tThu, 16 Nov 2017 02:02:44 -0800 (PST)","from localhost (ppp121-45-207-150.bras1.cbr1.internode.on.net.\n\t[121.45.207.150]) by smtp.gmail.com with ESMTPSA id\n\t3sm2358310pfo.17.2017.11.16.02.02.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 16 Nov 2017 02:02:41 -0800 (PST)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"oyFdS2Ln\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"oyFdS2Ln\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=axtens.net\n\t(client-ip=2607:f8b0:400e:c00::229; helo=mail-pf0-x229.google.com;\n\tenvelope-from=dja@axtens.net; receiver=)","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"oyFdS2Ln\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google;\n\th=from:to:subject:in-reply-to:references:date:message-id:mime-version;\n\tbh=bcSU3zub35vMlHGvreJELAtSdtYPmuEfcVYuMrtiUow=;\n\tb=oyFdS2LnSXo7A7Xy7f0IJRmbCRu5SxfblOan3GoUCSB8N1/tgQ1tPoZFLWdfZwhTre\n\tgj+GuqmHkvuYqwCeVFfELAt12iqWYBpi6RcyzZlPj7fx0DnOKRQNRWapt+33CJfMJ3K9\n\tyQReHFY67E46+SC9t/BvQEhWpXxOpKyTTcRtU=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:subject:in-reply-to:references:date\n\t:message-id:mime-version;\n\tbh=bcSU3zub35vMlHGvreJELAtSdtYPmuEfcVYuMrtiUow=;\n\tb=CZTF+3I4LkrTkZ/UUX63wOvp/R3oFemtDUGKHK5mf0GA/76RaKdqV7lcCihKRnl5Vz\n\tXclTSjAkEUf9mjL6lGSiURy2pAxk87CYYr7e/+n7ABDSMU+T7KAORZEYMvixdiTMKnsG\n\t3l/wh4TJi9GUvPzO6/GwGMSV7R+I5CbKciqirVd+/N7aVT0NB+W4wTed62W410u1dcyB\n\tgldwJ3aLv9h0CAZKKiAR2w618qXAKHWSpxRwsaLAZP5EGcefqciSQobU4pMX1/Yx3sdY\n\t2QLvFNo+hiTsXzaUqfqpOOMZAgi0Rv//ThaS+1E33L/82fgQYcV65wFt9usJolZcT69N\n\tFqWA==","X-Gm-Message-State":"AJaThX63iufOWUc+lmkjg+oDdfFYm4P8IHFHZhQT42QJkiHsqiLaKpus\n\tu4HBaZTqkTfg+YPJQtv3p/EJ5/tjUio=","X-Google-Smtp-Source":"AGs4zMalt0KQwjqml0Ya6rgWUncmnI+crn0pJ5teH5BDVBd4bsAbrUZLXyAq+dIfwYGrXC5XrX48/Q==","X-Received":"by 10.101.100.24 with SMTP id a24mr1149704pgv.239.1510826561800; \n\tThu, 16 Nov 2017 02:02:41 -0800 (PST)","From":"Daniel Axtens ","To":"Stephen Finucane , patchwork@lists.ozlabs.org","Subject":"Re: [PATCH v2 0/9] Add support for Django 1.11","In-Reply-To":"<20171102102844.18931-1-stephen@that.guru>","References":"<20171102102844.18931-1-stephen@that.guru>","Date":"Thu, 16 Nov 2017 21:02:38 +1100","Message-ID":"<87a7zmo81t.fsf@linkitivity.dja.id.au>","MIME-Version":"1.0","X-BeenThere":"patchwork@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Patchwork development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Patchwork\"\n\t"}},{"id":1814862,"web_url":"http://patchwork.ozlabs.org/comment/1814862/","msgid":"<1512337037.8423.1.camel@that.guru>","list_archive_url":null,"date":"2017-12-03T21:37:17","subject":"Re: [PATCH v2 0/9] Add support for Django 1.11","submitter":{"id":69991,"url":"http://patchwork.ozlabs.org/api/people/69991/","name":"Stephen Finucane","email":"stephen@that.guru"},"content":"On Thu, 2017-11-16 at 21:02 +1100, Daniel Axtens wrote:\n> Hi Stephen,\n> \n> > This is a sizable, albeit mostly trivial series focused on (a)\n> > adding support\n> > for Django 1.11 to Patchwork. Previously this also contained a\n> > series of\n> > patches aimed at resolving all 'DeprecationWarning's for the\n> > versions of Django\n> > that we support, but these have since been merged separately.\n> \n> The series, with the modifications in my other emails, is:\n> Tested-by: Daniel Axtens \n\nThanks for the reviews, Daniel. This is all merged now.\n\n> I haven't specifically examined the patches to the level I'm\n> comfortable with giving them Reviews, but I am confident that they\n> work.\n> \n> Earlier you talked about a performance regression with 1.11 - did you\n> ever find out anything about that? I have been looking at doing a\n> proper performance test suite, but haven't been able to carve out a\n> chunk of time to do it...\n\nAye, this was the issue I pointed out with the '/api/events' endpoint.\nAs you've noted, this is unrelated to Django 1.11 and has to be\nresolved separately (I'm working on it).\n\nStephen","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","patchwork@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","patchwork@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yqhFy6Cv6z9s74\n\tfor ;\n\tMon, 4 Dec 2017 08:38:30 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3yqhFy1YWjzDwND\n\tfor ;\n\tMon, 4 Dec 2017 08:38:30 +1100 (AEDT)","from toucan.birch.relay.mailchannels.net\n\t(toucan.birch.relay.mailchannels.net [23.83.209.254])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3yqhFp6JQczDr8x\n\tfor ;\n\tMon, 4 Dec 2017 08:38:22 +1100 (AEDT)","from relay.mailchannels.net (localhost [127.0.0.1])\n\tby relay.mailchannels.net (Postfix) with ESMTP id 474E964104F;\n\tSun, 3 Dec 2017 21:38:19 +0000 (UTC)","from one.mxroute.com (unknown [100.96.20.19])\n\t(Authenticated sender: mxroute)\n\tby relay.mailchannels.net (Postfix) with ESMTPA id D812C640FD1;\n\tSun, 3 Dec 2017 21:38:18 +0000 (UTC)","from one.mxroute.com (one-outgoing.mxroute.com [172.17.81.127])\n\t(using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)\n\tby 0.0.0.0:2500 (trex/5.10.2); Sun, 03 Dec 2017 21:38:19 +0000"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"afWlaFDo\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"afWlaFDo\"; dkim-atps=neutral","ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=that.guru\n\t(client-ip=23.83.209.254; helo=toucan.birch.relay.mailchannels.net;\n\tenvelope-from=stephen@that.guru; receiver=)","lists.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"afWlaFDo\"; dkim-atps=neutral"],"X-Sender-Id":["mxroute|x-authuser|stephen@that.guru","mxroute|x-authuser|stephen@that.guru"],"X-MC-Relay":"Neutral","X-MailChannels-SenderId":"mxroute|x-authuser|stephen@that.guru","X-MailChannels-Auth-Id":"mxroute","X-Abaft-Blushing":"177dcba41473d4c1_1512337099116_3572339249","X-MC-Loop-Signature":"1512337099116:361296353","X-MC-Ingress-Time":"1512337099115","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=that.guru;\n\ts=default;\n\th=Content-Transfer-Encoding:Mime-Version:Content-Type:References:\n\tIn-Reply-To:Date:To:From:Subject:Message-ID:Sender:Reply-To:Cc:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=W4CUtaROV063dn5Uq+AzBNdtwvaSbxZsbntO4Qo02j8=;\n\tb=afWlaFDoh2AmK6ZBjI10gSpE/n\n\tJH7cuUqQBNUUCiQyQBKP5US5D3Tit0E8AJT6H+khFEUju8jgaHoq71r4+I9MY13AtvvRu9RemLeZn\n\thUblW0v4KoFgcgSI+sqKeb+cbIV2V3JaPbEMAhbKQwKVe6BnWPU0WwrbrkSePDh4CbwPaKhy4J55O\n\tkdiM9/jYXxdjtaxHIsvUuvLIerNQgomBlfgb4VKghrlYFb82ce6u2wO/92P9++eo07GaJaSwM9C2G\n\tX3L7c+evL1FbZ6Tx2ClRPCK4XvzAbTRYXJJb8TCzA9EhBmZ1hLQ354gYWY86Qcdk8JeoIA75+juuK\n\tACSIF/2g==;","Message-ID":"<1512337037.8423.1.camel@that.guru>","Subject":"Re: [PATCH v2 0/9] Add support for Django 1.11","From":"Stephen Finucane ","To":"Daniel Axtens , patchwork@lists.ozlabs.org","Date":"Sun, 03 Dec 2017 21:37:17 +0000","In-Reply-To":"<87a7zmo81t.fsf@linkitivity.dja.id.au>","References":"<20171102102844.18931-1-stephen@that.guru>\n\t<87a7zmo81t.fsf@linkitivity.dja.id.au>","X-Mailer":"Evolution 3.26.2 (3.26.2-1.fc27) ","Mime-Version":"1.0","X-AuthUser":"stephen@that.guru","X-BeenThere":"patchwork@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Patchwork development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Patchwork\"\n\t"}},{"id":1814883,"web_url":"http://patchwork.ozlabs.org/comment/1814883/","msgid":"<87k1y3fnrt.fsf@linkitivity.dja.id.au>","list_archive_url":null,"date":"2017-12-03T22:29:58","subject":"Re: [PATCH v2 0/9] Add support for Django 1.11","submitter":{"id":65792,"url":"http://patchwork.ozlabs.org/api/people/65792/","name":"Daniel Axtens","email":"dja@axtens.net"},"content":"Stephen Finucane writes:\n\n> On Thu, 2017-11-16 at 21:02 +1100, Daniel Axtens wrote:\n>> Hi Stephen,\n>> \n>> > This is a sizable, albeit mostly trivial series focused on (a)\n>> > adding support\n>> > for Django 1.11 to Patchwork. Previously this also contained a\n>> > series of\n>> > patches aimed at resolving all 'DeprecationWarning's for the\n>> > versions of Django\n>> > that we support, but these have since been merged separately.\n>> \n>> The series, with the modifications in my other emails, is:\n>> Tested-by: Daniel Axtens \n>\n> Thanks for the reviews, Daniel. This is all merged now.\n\nFantastic, thanks.\n>\n>> I haven't specifically examined the patches to the level I'm\n>> comfortable with giving them Reviews, but I am confident that they\n>> work.\n>> \n>> Earlier you talked about a performance regression with 1.11 - did you\n>> ever find out anything about that? I have been looking at doing a\n>> proper performance test suite, but haven't been able to carve out a\n>> chunk of time to do it...\n>\n> Aye, this was the issue I pointed out with the '/api/events' endpoint.\n> As you've noted, this is unrelated to Django 1.11 and has to be\n> resolved separately (I'm working on it).\n\nI have made some (so far incomplete) attempts centering around\ndenormalising the project field - moving it either completely out of\nsubmission and into patch/coverletter/comment or just duplicating it in\nthose three models. This also fixes the fact that we need a SQL join\njust to enumerate patches which is slow (and an OzLabs pain point) - but\nthe migrations are a paaaaaiiiiiin. Is that your approach or do you have\nother ideas?\n\nRegards,\nDaniel\n\n>\n> Stephen","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","patchwork@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","patchwork@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yqjPc2XmMz9s7g\n\tfor ;\n\tMon, 4 Dec 2017 09:30:12 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3yqjPc11KNzDwNT\n\tfor ;\n\tMon, 4 Dec 2017 09:30:12 +1100 (AEDT)","from mail-pg0-x235.google.com (mail-pg0-x235.google.com\n\t[IPv6:2607:f8b0:400e:c05::235])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3yqjPV0GMKzDrpV\n\tfor ;\n\tMon, 4 Dec 2017 09:30:04 +1100 (AEDT)","by mail-pg0-x235.google.com with SMTP id y6so6860699pgp.4\n\tfor ;\n\tSun, 03 Dec 2017 14:30:04 -0800 (PST)","from localhost (124-171-106-107.dyn.iinet.net.au.\n\t[124.171.106.107]) by smtp.gmail.com with ESMTPSA id\n\tl80sm21600228pfk.67.2017.12.03.14.30.00\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSun, 03 Dec 2017 14:30:01 -0800 (PST)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"MGyjniY/\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"MGyjniY/\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=axtens.net\n\t(client-ip=2607:f8b0:400e:c05::235; helo=mail-pg0-x235.google.com;\n\tenvelope-from=dja@axtens.net; receiver=)","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"MGyjniY/\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google;\n\th=from:to:subject:in-reply-to:references:date:message-id:mime-version;\n\tbh=dNeoXXlhJGsG4ip3f8h870a3YZmrbwysWmKGV3YLHDc=;\n\tb=MGyjniY/4WWjBJvpgk/PHydSb9DMKnPyGUb+VjupawGAtcgMN34dFYvosVkgk11r32\n\tfxq3QCA/gOGMPL6Cjt9nBqTwuUY47B9QgTyFvqbFD0G6El7sjCqC3lYt8wBEs4LWJTMo\n\tMPFHC7byhD3o74RFkHnVRSLgH3HtfYIrCaQhQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:subject:in-reply-to:references:date\n\t:message-id:mime-version;\n\tbh=dNeoXXlhJGsG4ip3f8h870a3YZmrbwysWmKGV3YLHDc=;\n\tb=gCsIihrt/HnDEuHxzgELR+OdH/XJ0SLfPQ8mb+HplXqD2HmMpGdDKQjIV1synbCsP3\n\tCPSQ2aja7RdPjXINBMPkI/7UD/4J2sUDV39kyQLL1DEnP/h9yzYa8G6QtPsPokIvrCSp\n\tbCRRJH5xmvCNIIr6MOl9DmxgO6ECw9LDUgq/ti4Ie3XX/LsCAG0hX61MsOH62DLfv1c+\n\tJjkx2L1JAELAna/Sy+UPzzn1rzoiqLAgnQ+YrepuUjvbdp9GAwkgrC8qH4BqeBK73A2I\n\tEXYF4t4Va/uJ3R2QoSYcfCtKlIEQs/Ehpn7RzjjeHynXffSbLbhTe7yaT2h8RruVtJ4o\n\tv8mA==","X-Gm-Message-State":"AJaThX5dYemeY8Cn/ogYX6DOi085cUvL+TB31A9/bHv4U+gIgTllu5pq\n\tAJWhBr/MaUBDAw23uCpimf6aoA==","X-Google-Smtp-Source":"AGs4zMYw+i8lyOgGq59l4ENS4VvkocKOfj1VsTE4Ae86Aokp5BYlCYTKxiiXFahn7nocAmIfvA6Y4w==","X-Received":"by 10.84.193.3 with SMTP id e3mr12550770pld.300.1512340202453;\n\tSun, 03 Dec 2017 14:30:02 -0800 (PST)","From":"Daniel Axtens ","To":"Stephen Finucane , patchwork@lists.ozlabs.org","Subject":"Re: [PATCH v2 0/9] Add support for Django 1.11","In-Reply-To":"<1512337037.8423.1.camel@that.guru>","References":"<20171102102844.18931-1-stephen@that.guru>\n\t<87a7zmo81t.fsf@linkitivity.dja.id.au>\n\t<1512337037.8423.1.camel@that.guru>","Date":"Mon, 04 Dec 2017 09:29:58 +1100","Message-ID":"<87k1y3fnrt.fsf@linkitivity.dja.id.au>","MIME-Version":"1.0","X-BeenThere":"patchwork@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Patchwork development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Patchwork\"\n\t"}},{"id":1814893,"web_url":"http://patchwork.ozlabs.org/comment/1814893/","msgid":"<1512341753.8423.16.camel@that.guru>","list_archive_url":null,"date":"2017-12-03T22:55:53","subject":"Re: [PATCH v2 0/9] Add support for Django 1.11","submitter":{"id":69991,"url":"http://patchwork.ozlabs.org/api/people/69991/","name":"Stephen Finucane","email":"stephen@that.guru"},"content":"On Mon, 2017-12-04 at 09:29 +1100, Daniel Axtens wrote:\n> Stephen Finucane writes:\n> \n> > On Thu, 2017-11-16 at 21:02 +1100, Daniel Axtens wrote:\n\n[snip]\n\n> > > I haven't specifically examined the patches to the level I'm\n> > > comfortable with giving them Reviews, but I am confident that\n> > > they work.\n> > > \n> > > Earlier you talked about a performance regression with 1.11 - did\n> > > you ever find out anything about that? I have been looking at\n> > > doing a proper performance test suite, but haven't been able to\n> > > carve out a chunk of time to do it...\n> > \n> > Aye, this was the issue I pointed out with the '/api/events'\n> > endpoint. As you've noted, this is unrelated to Django 1.11 and has\n> > to be resolved separately (I'm working on it).\n> \n> I have made some (so far incomplete) attempts centering around\n> denormalising the project field - moving it either completely out of\n> submission and into patch/coverletter/comment or just duplicating it\n> in those three models. This also fixes the fact that we need a SQL\n> join just to enumerate patches which is slow (and an OzLabs pain\n> point) - but the migrations are a paaaaaiiiiiin. Is that your\n> approach or do you have other ideas?\n\nNot quite. I've been focused on the 'Event' model mostly and getting\nrid of the most of the ForeignKeys contained therein. To do this, I'm\nreplacing the cover letter and patch foreign keys with a submission\nreference and storing a serialized JSON blob for things like\n'previous_delegate' (the payload) instead. This tightly binds us to the\nREST API representation and means we lose things the integrity\nconstraints that foreign keys provide. However, we only expose this\nstuff over that API and we don't generally delete anything so the\nconstraints don't give us much. As for migrations, I've got a feature\nto automatically delete (\"expire\") events after an interval (defaulting\nto 30 days). The main point of this is that events lose value the older\nthey are, but I figure if this run before the migration, it would limit\nthe amount of things we have to migrate.\n\nI haven't yet looked at removing the join for patches and cover\nletters, but have you thought of simply folding these in and using an\nenum-like field to indicate if it's a cover letter or patch? The\nmigration for that is also going to be tough and it's going to\ndenormalize things, but if the JOINs are a serious issue it might be\nthe only option we have.\n\nStephen","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","patchwork@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","patchwork@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yqjzd1YWhz9s4s\n\tfor ;\n\tMon, 4 Dec 2017 09:56:13 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3yqjzc6CSLzDwNG\n\tfor ;\n\tMon, 4 Dec 2017 09:56:12 +1100 (AEDT)","from nov-007-i571.relay.mailchannels.net\n\t(nov-007-i571.relay.mailchannels.net [46.232.183.125])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3yqjzV0hBMzDsJW\n\tfor ;\n\tMon, 4 Dec 2017 09:56:04 +1100 (AEDT)","from relay.mailchannels.net (localhost [127.0.0.1])\n\tby relay.mailchannels.net (Postfix) with ESMTP id 3802D2C09CC;\n\tSun, 3 Dec 2017 22:55:57 +0000 (UTC)","from one.mxroute.com (unknown [100.96.14.26])\n\t(Authenticated sender: mxroute)\n\tby relay.mailchannels.net (Postfix) with ESMTPA id CCF6D2C0891;\n\tSun, 3 Dec 2017 22:55:56 +0000 (UTC)","from one.mxroute.com (one-outgoing.mxroute.com [172.17.80.58])\n\t(using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)\n\tby 0.0.0.0:2500 (trex/5.10.2); Sun, 03 Dec 2017 22:55:57 +0000"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"OwnXHfiw\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"OwnXHfiw\"; dkim-atps=neutral","ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=that.guru\n\t(client-ip=46.232.183.125; helo=nov-007-i571.relay.mailchannels.net; \n\tenvelope-from=stephen@that.guru; receiver=)","lists.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"OwnXHfiw\"; dkim-atps=neutral"],"X-Sender-Id":["mxroute|x-authuser|stephen@that.guru","mxroute|x-authuser|stephen@that.guru"],"X-MC-Relay":"Neutral","X-MailChannels-SenderId":"mxroute|x-authuser|stephen@that.guru","X-MailChannels-Auth-Id":"mxroute","X-Zesty-Vacuous":"668c2e6e2ef4b52e_1512341757070_3910553992","X-MC-Loop-Signature":"1512341757070:719560897","X-MC-Ingress-Time":"1512341757070","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=that.guru;\n\ts=default;\n\th=Content-Transfer-Encoding:Mime-Version:Content-Type:References:\n\tIn-Reply-To:Date:To:From:Subject:Message-ID:Sender:Reply-To:Cc:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=Yd4rrOee7+YRiPS+kDjIuMrW77S8SKlE7ZrHZaeXVBw=;\n\tb=OwnXHfiwmjOngOjzKv+F676Ajd\n\tFhDNxeH/v/RhlUEttLGm8M2O2MYj2iEj0fdscUb2Q+xq9qpzZOEQ/Iq/s6wWste1lDTXx1wnrpFhf\n\tYXEyI6030TONh2C40jp8D4mSDAtu4+4NsMpKRq2NBTUxiisz5+ruqszHN4tiGGGVDSqjmCXMnD8VF\n\tP6WN4gIlWb6dNhfdmfcirjgWowlkK6JF4rmDhMUZ+kpffe3huCDa09NkVPMhXiz2sJ8eJcrE7alZA\n\tXpvu9+58zM7PBkzDiF+q3fbFP61jaLgzAUQbno0YBfhoqLIPiLFOlxiXSN+SBQLfaYNxeK/dUrJ49\n\tYUieAEYg==;","Message-ID":"<1512341753.8423.16.camel@that.guru>","Subject":"Re: [PATCH v2 0/9] Add support for Django 1.11","From":"Stephen Finucane ","To":"Daniel Axtens , patchwork@lists.ozlabs.org","Date":"Sun, 03 Dec 2017 22:55:53 +0000","In-Reply-To":"<87k1y3fnrt.fsf@linkitivity.dja.id.au>","References":"<20171102102844.18931-1-stephen@that.guru>\n\t<87a7zmo81t.fsf@linkitivity.dja.id.au>\n\t<1512337037.8423.1.camel@that.guru>\n\t<87k1y3fnrt.fsf@linkitivity.dja.id.au>","X-Mailer":"Evolution 3.26.2 (3.26.2-1.fc27) ","Mime-Version":"1.0","X-AuthUser":"stephen@that.guru","X-BeenThere":"patchwork@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Patchwork development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Patchwork\"\n\t"}}]