[{"id":1801468,"web_url":"http://patchwork.ozlabs.org/comment/1801468/","msgid":"<87r2t8j0nc.fsf@suse.com>","list_archive_url":null,"date":"2017-11-08T14:38:47","subject":"Re: [PATCH 00/19] cifs: remove rfc1002 header from all smb2 requests","submitter":{"id":72538,"url":"http://patchwork.ozlabs.org/api/people/72538/","name":"Aurélien Aptel","email":"aaptel@suse.com"},"content":"Hi Ronnie,\n\nThe patch looks good I think but I ran the xfstests test suite and after\napplying your patches on top of Steve's for-next the generic/089 test\nruns forever (10+ hours at full CPU usage after which I just hit ^C and\nthe program stopped) vs couple of seconds before. I'm not sure what's\ngoing on here but since sending SIGINT stops the program its probably\nnot a kernel deadlock.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yX87J6D6qz9s4q\n\tfor ;\n\tThu, 9 Nov 2017 01:38:52 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752603AbdKHOiv convert rfc822-to-8bit (ORCPT\n\t);\n\tWed, 8 Nov 2017 09:38:51 -0500","from smtp.nue.novell.com ([195.135.221.5]:56780 \"EHLO\n\tsmtp.nue.novell.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751839AbdKHOiu (ORCPT\n\t);\n\tWed, 8 Nov 2017 09:38:50 -0500","from localhost (nat.nue.novell.com [195.135.221.2])\n\tby smtp.nue.novell.com with ESMTP (TLS encrypted);\n\tWed, 08 Nov 2017 15:38:49 +0100"],"From":"=?utf-8?b?QXVyw6lsaWVu?= Aptel ","To":"Ronnie Sahlberg ,\n\tlinux-cifs ","Cc":"Steve French ","Subject":"Re: [PATCH 00/19] cifs: remove rfc1002 header from all smb2 requests","In-Reply-To":"<20171102070312.18903-1-lsahlber@redhat.com>","References":"<20171102070312.18903-1-lsahlber@redhat.com>","Date":"Wed, 08 Nov 2017 15:38:47 +0100","Message-ID":"<87r2t8j0nc.fsf@suse.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"8BIT","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1801505,"web_url":"http://patchwork.ozlabs.org/comment/1801505/","msgid":"<87o9ocixio.fsf@suse.com>","list_archive_url":null,"date":"2017-11-08T15:46:23","subject":"Re: [PATCH 00/19] cifs: remove rfc1002 header from all smb2 requests","submitter":{"id":72538,"url":"http://patchwork.ozlabs.org/api/people/72538/","name":"Aurélien Aptel","email":"aaptel@suse.com"},"content":"I've looked at a network trace: after the patches when doing a setinfo\non the same file, the netbios length is 1 byte bigger and thus probably\nwrong (server replies with a OBJECT_NAME_COLLISION error).","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yX9dJ1MbJz9s7c\n\tfor ;\n\tThu, 9 Nov 2017 02:46:28 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752637AbdKHPq1 convert rfc822-to-8bit (ORCPT\n\t);\n\tWed, 8 Nov 2017 10:46:27 -0500","from smtp.nue.novell.com ([195.135.221.5]:37173 \"EHLO\n\tsmtp.nue.novell.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752491AbdKHPq0 (ORCPT\n\t);\n\tWed, 8 Nov 2017 10:46:26 -0500","from localhost (charybdis-ext.suse.de [195.135.221.2])\n\tby smtp.nue.novell.com with ESMTP (TLS encrypted);\n\tWed, 08 Nov 2017 16:46:25 +0100"],"From":"=?utf-8?b?QXVyw6lsaWVu?= Aptel ","To":"Ronnie Sahlberg ,\n\tlinux-cifs ","Cc":"Steve French ","Subject":"Re: [PATCH 00/19] cifs: remove rfc1002 header from all smb2 requests","In-Reply-To":"<87r2t8j0nc.fsf@suse.com>","References":"<20171102070312.18903-1-lsahlber@redhat.com>\n\t<87r2t8j0nc.fsf@suse.com>","Date":"Wed, 08 Nov 2017 16:46:23 +0100","Message-ID":"<87o9ocixio.fsf@suse.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"8BIT","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1801820,"web_url":"http://patchwork.ozlabs.org/comment/1801820/","msgid":"","list_archive_url":null,"date":"2017-11-09T00:48:42","subject":"Re: [PATCH 00/19] cifs: remove rfc1002 header from all smb2 requests","submitter":{"id":6089,"url":"http://patchwork.ozlabs.org/api/people/6089/","name":"ronnie sahlberg","email":"ronniesahlberg@gmail.com"},"content":"Thanks.\n\nIt is the __u8 Buffer[1] in the structure that is causing it.\nI will resend after I fix it and audit all other Buffer[1] in the\nrequest structures.\n\nAny particular reason we don't use __u8 Buffer[0] instead?\n\n\n\nOn Thu, Nov 9, 2017 at 1:46 AM, Aurélien Aptel wrote:\n> I've looked at a network trace: after the patches when doing a setinfo\n> on the same file, the netbios length is 1 byte bigger and thus probably\n> wrong (server replies with a OBJECT_NAME_COLLISION error).\n>\n> --\n> Aurélien Aptel / SUSE Labs Samba Team\n> GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3\n> SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany\n> GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)\n> --\n> To unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"j4QHHt+b\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yXPg151KYz9sP9\n\tfor ;\n\tThu, 9 Nov 2017 11:48:45 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752349AbdKIAso (ORCPT );\n\tWed, 8 Nov 2017 19:48:44 -0500","from mail-qt0-f171.google.com ([209.85.216.171]:56757 \"EHLO\n\tmail-qt0-f171.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752182AbdKIAsn (ORCPT\n\t); Wed, 8 Nov 2017 19:48:43 -0500","by mail-qt0-f171.google.com with SMTP id z28so5715194qtz.13\n\tfor ;\n\tWed, 08 Nov 2017 16:48:43 -0800 (PST)","by 10.12.176.19 with HTTP; Wed, 8 Nov 2017 16:48:42 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=mVzbHyL81TnGJHwVee/N/wsZYl3CSCDcOSAfIZ8AhDE=;\n\tb=j4QHHt+bfU8VSH6R5UjQr8YJlOU9GqQP+/ZbGV53uZtkKzZhLFF8HM1KlZJ/CmAtvP\n\t2D5ai64Rtr1sf1HzVfnNpejATP96ZTyxjZB2P35RdenZZ9z4xdti+6sJuyiIQ3QjGURh\n\tiYd1Izlel621wwUyrnS3Hbh19yejBdVL7lX23jrsG/HB+BaV3E+2H36kMdU6l0mxLhyP\n\tOR4VqEz47KWdlravjOYIvW4p1IOIBF3JRWYlGQmZhXAlN/aQEn7NlPrrGG9MdB5toGVG\n\tFIlsIOPIWkxIpEvx734vEqE5N04SMGZ3Ms0U60+NXtqfIQ9LVI6uiwRUA3vXMLjz3bhi\n\tA9Cw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=mVzbHyL81TnGJHwVee/N/wsZYl3CSCDcOSAfIZ8AhDE=;\n\tb=IRx1rPGxUnZ5iPq+EMHMIipYOeeg3wG6A4MuFiwYYoiO33Z9Qc2TQ0lAVBXAp3gEZ6\n\tjoRGgw4qT/8D0Yw8xfA5lXht1nCbjuvTuIZOnIwTFJrBnnekvnLBX+rOUgyLTxwHBXqI\n\tIXeOgA6sAR8+OV090y5aVBrVeRkcogzysDCMADBJEzcLHm5tuaw8O6ynPgpAfmlzQnsZ\n\tyFjdZBAM5AqDrTehEYsqh5OZvLun131Dib2/IFuWBWe0T2e70jIvHiWmjS+Ph5hh4BhF\n\tfaHADFu5cpgdVzEum3hejupco5Aats8T2Q6CFgdB3CH8ws38Rdb1BkBVbuJHglGVXJtL\n\t9BIw==","X-Gm-Message-State":"AJaThX53V1X0iMm9ZkelFsM8inoNXeSyV4JdScgspxpI6mjT0lRVVmyH\n\tgLjIHfU392arruGGjcVOnUBdxSPWXeP76FUCYlY=","X-Google-Smtp-Source":"ABhQp+TT/MaOMzd59LeXLR7L627XLTJrFZX8QRU5wevV803I1CfjYVoe2rQ+qoFk/TsjOwIwLeHlXvvn1nDlL19G198=","X-Received":"by 10.237.33.186 with SMTP id l55mr4070300qtc.71.1510188523264; \n\tWed, 08 Nov 2017 16:48:43 -0800 (PST)","MIME-Version":"1.0","In-Reply-To":"<87o9ocixio.fsf@suse.com>","References":"<20171102070312.18903-1-lsahlber@redhat.com>\n\t<87r2t8j0nc.fsf@suse.com> <87o9ocixio.fsf@suse.com>","From":"ronnie sahlberg ","Date":"Thu, 9 Nov 2017 10:48:42 +1000","Message-ID":"","Subject":"Re: [PATCH 00/19] cifs: remove rfc1002 header from all smb2 requests","To":"=?utf-8?q?Aur=C3=A9lien_Aptel?= ","Cc":"Ronnie Sahlberg ,\n\tlinux-cifs ,\n\tSteve French ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1806054,"web_url":"http://patchwork.ozlabs.org/comment/1806054/","msgid":"","list_archive_url":null,"date":"2017-11-17T01:16:31","subject":"Re: [PATCH 00/19] cifs: remove rfc1002 header from all smb2 requests","submitter":{"id":72423,"url":"http://patchwork.ozlabs.org/api/people/72423/","name":"Pavel Shilovsky","email":"piastryyy@gmail.com"},"content":"2017-11-08 16:48 GMT-08:00 ronnie sahlberg :\n> Thanks.\n>\n> It is the __u8 Buffer[1] in the structure that is causing it.\n> I will resend after I fix it and audit all other Buffer[1] in the\n> request structures.\n>\n> Any particular reason we don't use __u8 Buffer[0] instead?\n>\n>\n>\n> On Thu, Nov 9, 2017 at 1:46 AM, Aurélien Aptel wrote:\n>> I've looked at a network trace: after the patches when doing a setinfo\n>> on the same file, the netbios length is 1 byte bigger and thus probably\n>> wrong (server replies with a OBJECT_NAME_COLLISION error).\n>>\n>> --\n>> Aurélien Aptel / SUSE Labs Samba Team\n>> GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3\n>> SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany\n>> GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)\n>> --\n>> To unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\n>> the body of a message to majordomo@vger.kernel.org\n>> More majordomo info at http://vger.kernel.org/majordomo-info.html\n> --\n> To unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n\nIt is because a buffer of size 1 is included in StructureSize field of\nPDUs, so we need to send at least 1 byte. Having it in the structure\npreventing us to allocate extra unused 1 byte e.g. for a READ request.\nWe can probably clean it as well.\n\n--\nBest regards,\nPavel Shilovsky\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"EEGNITfO\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ydKvR6cGdz9s3T\n\tfor ;\n\tFri, 17 Nov 2017 12:16:35 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753827AbdKQBQe (ORCPT );\n\tThu, 16 Nov 2017 20:16:34 -0500","from mail-lf0-f42.google.com ([209.85.215.42]:39224 \"EHLO\n\tmail-lf0-f42.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753565AbdKQBQe (ORCPT\n\t); Thu, 16 Nov 2017 20:16:34 -0500","by mail-lf0-f42.google.com with SMTP id w21so934588lfc.6\n\tfor ;\n\tThu, 16 Nov 2017 17:16:33 -0800 (PST)","by 10.25.28.6 with HTTP; Thu, 16 Nov 2017 17:16:31 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=yew+/CzfVIXXFMBpqqcoo9863e1tel33bQCgAvkZzPs=;\n\tb=EEGNITfO4TdeZaoDLYV4Lf0FE5IFSg+TKOwUw8KOtWbPmRezZam1wGKkpxEBm18Rxi\n\tCECBmBezWmoh75VPISy3BBx5IaPA+SwTPj6Bh41fTFzaF+WVwCbaUqIagbJ91u2Qvclb\n\toaC3oAjj1Hx5fZp2nT+OwtHD3iVPnwhVRXxXlKPFbCgW9FhgC9wligY+9EESYYEUiTaC\n\tp1+q7yuSvkSTN65kIyh16/RuPyjWpCX7AcFSwMMD2U25rF7RLdrwvl0GGuj8+gUo4URk\n\t6J4dAc+dhQ7kLMoc9kqwAjX9Nf5x5jducvgo9S5V0EAQFOe+rvukMT+V/MFc54OLIhke\n\t8Xfg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=yew+/CzfVIXXFMBpqqcoo9863e1tel33bQCgAvkZzPs=;\n\tb=rMjaJD5WJNQddFr9LJWuDrDxc5NXn4yDMivUqqNs0lAAA/9RjHJ1aDbWV0Vb1myKB2\n\tYPSLTdiqnG0IS8XAIdt4sM1Hk5tkz70QC+ALN9iNYhN8YYOwXUObMBsiTRG06Rtsa3zF\n\tNvlSTcwru6A/E8ljsM+hwO0tRxT34STW01IytSQj/UpZ81H6WFdwZ/jSVHEBC/r6Lquc\n\tJ56ghY5/WuV/i7rmqQT3W/5zefq4DQa7bKk79HnEf7inGDNQdzubo0T6118R3YYS4+dL\n\tf+5Rry+PTxGCYGZ97gOW0w6i9G7vgfXVxm44FBwsFik2BnBscw7kzcA6Sz/o9Gapy8EC\n\t7rTA==","X-Gm-Message-State":"AJaThX5z67GpOKu9OufOHADOSFqwqjofN4DrI1J/6GcGhR+Tv+/ZT9Z5\n\tnP3ZsBzrU9yB+kdvbxi0ywtyI/mCnDPcbv8jNg==","X-Google-Smtp-Source":"AGs4zMbQ/oIeq7Y5Ze12GH/gzICADiAFOO0i4PobnamcbbF69maItkdDCN8SRA+C2aqZAlngIbZkfqKQXzAqjEDBeAA=","X-Received":"by 10.25.42.8 with SMTP id f8mr22374lfl.161.1510881392590;\n\tThu, 16 Nov 2017 17:16:32 -0800 (PST)","MIME-Version":"1.0","In-Reply-To":"","References":"<20171102070312.18903-1-lsahlber@redhat.com>\n\t<87r2t8j0nc.fsf@suse.com> <87o9ocixio.fsf@suse.com>\n\t","From":"Pavel Shilovsky ","Date":"Thu, 16 Nov 2017 17:16:31 -0800","Message-ID":"","Subject":"Re: [PATCH 00/19] cifs: remove rfc1002 header from all smb2 requests","To":"ronnie sahlberg ","Cc":"=?utf-8?q?Aur=C3=A9lien_Aptel?= ,\n\tRonnie Sahlberg , linux-cifs\n\t, Steve French ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"}}]