[{"id":1795232,"web_url":"http://patchwork.ozlabs.org/comment/1795232/","msgid":"<1872710.P2f02irZl9@aspire.rjw.lan>","list_archive_url":null,"date":"2017-10-28T09:07:30","subject":"Re: [RFC PATCH v10 0/7] PCI: rockchip: Move PCIe WAKE# handling into\n\tpci core","submitter":{"id":26536,"url":"http://patchwork.ozlabs.org/api/people/26536/","name":"Rafael J. Wysocki","email":"rjw@rjwysocki.net"},"content":"On Friday, October 27, 2017 9:26:05 AM CEST Jeffy Chen wrote:\n> \n> Currently we are handling wake irq in mrvl wifi driver. Move it into\n> pci core.\n> \n> Tested on my chromebook bob(with cros 4.4 kernel and mrvl wifi).\n> \n> \n> Changes in v10:\n> Use device_set_wakeup_capable() instead of device_set_wakeup_enable(),\n> since dedicated wakeirq will be lost in device_set_wakeup_enable(false).\n> \n> Changes in v9:\n> Add section for PCI devices and rewrite the commit message.\n> Rewrite the commit message.\n> Fix check error in .cleanup().\n> Move dedicated wakeirq setup to setup() callback and use\n> device_set_wakeup_enable() to enable/disable.\n> \n> Changes in v8:\n> Add optional \"pci\", and rewrite commit message.\n> Rewrite the commit message.\n> Add pci-of.c and use platform_pm_ops to handle the PCIe WAKE# signal.\n> \n> Changes in v7:\n> Move PCIE_WAKE handling into pci core.\n> \n> Changes in v6:\n> Fix device_init_wake error handling, and add some comments.\n> \n> Changes in v5:\n> Move to pci.txt\n> Use \"wakeup\" instead of \"wake\"\n> Rebase.\n> \n> Changes in v3:\n> Fix error handling.\n> \n> Changes in v2:\n> Use dev_pm_set_dedicated_wake_irq.\n> \n> Jeffy Chen (7):\n> dt-bindings: PCI: Add definition of PCIe WAKE# irq and PCI irq\n> of/irq: Adjust of_pci_irq parsing for multiple interrupts\n> mwifiex: Disable wakeup irq handling for pcie\n> arm64: dts: rockchip: Move PCIe WAKE# irq to pcie driver for Gru\n> PCI: Make pci_platform_pm_ops's callbacks optional\n> PCI / PM: Move acpi wakeup code to pci core\n> PCI / PM: Add support for the PCIe WAKE# signal for OF\n\nOverall, I don't quite like the direction this is going into, but I need to\nhave a deeper look. Which may take some time, so please bear with me.\n\nThanks,\nRafael","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"dXVOTgco\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yPFJm1Y4Nz9t2v\n\tfor ;\n\tSat, 28 Oct 2017 20:07:57 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e8N5t-0008Fz-II; Sat, 28 Oct 2017 09:07:53 +0000","from cloudserver094114.home.net.pl ([79.96.170.134])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e8N5q-0008D2-FM; Sat, 28 Oct 2017 09:07:52 +0000","from cheops.hbnet.cz (62.168.35.125) (HELO aspire.rjw.lan)\n\tby serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer\n\t0.82) id e64a108ae5b6f28a; Sat, 28 Oct 2017 11:07:22 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=l5ZkNajFo6pqmMwL86ddsl17/URYaHekMOJkHdU4C0g=;\n\tb=dXVOTgcopQcUZ7\n\tQYR8i1MGk+2CQBhAn9uc8XAiqa0kPFdUeQz6ArXE5q4FfcMpUN8Y3IoIEM4B4uVuMXfCEG9TLqwpN\n\t2AoG9QH5t2fVJso6e2IXKo2pliTH7cLWq3Ut14uad90GM/vxoAb9Y3yN4530BNFlAMsr/8JtwnUPq\n\tpZgkloqo6O3dd8Oy2rjd9iFIgk92Yn36p5PvsgtGZSpqokodpUdgEVDJ0piXkjlB0xUT7kFB8Xojk\n\tO+GtrwV5RQGKI15SeTvJZC99YHO0JyRUdrhH0JBHLU0BSIGmWperBhucSkHO+PfzUo9NFQj+Qm3RT\n\tXWLz0+c28KZaS7jzZUiw==;","From":"\"Rafael J. Wysocki\" ","To":"Jeffy Chen ","Subject":"Re: [RFC PATCH v10 0/7] PCI: rockchip: Move PCIe WAKE# handling into\n\tpci core","Date":"Sat, 28 Oct 2017 11:07:30 +0200","Message-ID":"<1872710.P2f02irZl9@aspire.rjw.lan>","In-Reply-To":"<20171027072612.26565-1-jeffy.chen@rock-chips.com>","References":"<20171027072612.26565-1-jeffy.chen@rock-chips.com>","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171028_020750_711331_56A088A0 ","X-CRM114-Status":"GOOD ( 11.09 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Mark Rutland , Heiko Stuebner ,\n\ttony@atomide.com, linux-pci@vger.kernel.org, shawn.lin@rock-chips.com,\n\tWill Deacon ,\n\tAmitkumar Karwar , \n\tdianders@chromium.org, Klaus Goger ,\n\tFrank Rowand ,\n\tlinux-rockchip@lists.infradead.org, \n\tbriannorris@chromium.org, linux-acpi@vger.kernel.org,\n\tMatthias Kaehlcke ,\n\tlinux-arm-kernel@lists.infradead.org, \n\tCatalin Marinas , Len Brown ,\n\tdevicetree@vger.kernel.org, Xinming Hu ,\n\tlinux-pm@vger.kernel.org, Nishant Sarmukadam , \n\tRob Herring , bhelgaas@google.com,\n\tKalle Valo , Ganapathi Bhat ,\n\tnetdev@vger.kernel.org, linux-wireless@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, Caesar Wang ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1795591,"web_url":"http://patchwork.ozlabs.org/comment/1795591/","msgid":"<59F68B40.8050506@rock-chips.com>","list_archive_url":null,"date":"2017-10-30T02:15:28","subject":"Re: [RFC PATCH v10 0/7] PCI: rockchip: Move PCIe WAKE# handling into\n\tpci core","submitter":{"id":67754,"url":"http://patchwork.ozlabs.org/api/people/67754/","name":"Jeffy Chen","email":"jeffy.chen@rock-chips.com"},"content":"Hi Rafael,\n\nthanks for your reply.\n\nOn 10/28/2017 05:07 PM, Rafael J. Wysocki wrote:\n> Overall, I don't quite like the direction this is going into, but I need to\n> have a deeper look. Which may take some time, so please bear with me.\n>\nok, i'll wait for your comments, thanks :)\n\n> Thanks,\n> Rafael","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"abuT2MCE\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yQJ4z1mTTz9t3s\n\tfor ;\n\tMon, 30 Oct 2017 13:16:35 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e8zct-00006m-K6; Mon, 30 Oct 2017 02:16:31 +0000","from regular1.263xmail.com ([211.150.99.136])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e8zco-0008Ul-Ha; Mon, 30 Oct 2017 02:16:29 +0000","from jeffy.chen?rock-chips.com (unknown [192.168.167.174])\n\tby regular1.263xmail.com (Postfix) with ESMTP id ED5F6E8;\n\tMon, 30 Oct 2017 10:15:52 +0800 (CST)","from [172.16.22.86] (localhost [127.0.0.1])\n\tby smtp.263.net (Postfix) with ESMTPA id 3C6893DB;\n\tMon, 30 Oct 2017 10:15:30 +0800 (CST)","from [172.16.22.86] (unknown [103.29.142.67])\n\tby smtp.263.net (Postfix) whith ESMTP id 9303ED87K9;\n\tMon, 30 Oct 2017 10:15:46 +0800 (CST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:References:Subject:To:MIME-Version:From:\n\tDate:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=2Tnt2Jg5YFcBHJASb+2Dyy8ORqVrxIb5nijhjNVp44k=;\n\tb=abuT2MCEXZrK1d4R3dlnsG8q/\n\tG42BLKuxDFfCj7tDPDWjj2mvoK/yPfabNPkN1U2kLlIjSUA2NUeEodTL/MEfrRdrhhCUjs9cCQ7Mt\n\tvAjV0D2uuDoHffU8oHaYRkNYtn7qGgHW/6VbJPU8anrr5Esv7QQgF8AmoWqMrfzqnk40nHVWC7KPw\n\tylAg2k0X6SL5YfXQ1kwbHJXjqbvEjN9lX7HC2EJQ+W+ph9Yqk5616ZWbF13OlSdPBhX1mAANUnMdV\n\tZe5l4nFlE7XeTzbm795TRx3b2FSkn9Yh3qAoyUAvos6Lx+laRAaqKK7uKRuATRcu8ajlwYbj1n5bt\n\t4r6LJmkww==;","X-263anti-spam":"KSV:0;","X-MAIL-GRAY":"0","X-MAIL-DELIVERY":"1","X-KSVirus-check":"0","X-ABS-CHECKED":"4","X-RL-SENDER":"jeffy.chen@rock-chips.com","X-FST-TO":"rjw@rjwysocki.net","X-SENDER-IP":"103.29.142.67","X-LOGIN-NAME":"jeffy.chen@rock-chips.com","X-UNIQUE-TAG":"<1ed3aa002205860a65eabeefa0be8c27>","X-ATTACHMENT-NUM":"0","X-SENDER":"cjf@rock-chips.com","X-DNS-TYPE":"0","Message-ID":"<59F68B40.8050506@rock-chips.com>","Date":"Mon, 30 Oct 2017 10:15:28 +0800","From":"jeffy ","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:19.0) Gecko/20130126 Thunderbird/19.0","MIME-Version":"1.0","To":"\"Rafael J. Wysocki\" ","Subject":"Re: [RFC PATCH v10 0/7] PCI: rockchip: Move PCIe WAKE# handling into\n\tpci core","References":"<20171027072612.26565-1-jeffy.chen@rock-chips.com>\n\t<1872710.P2f02irZl9@aspire.rjw.lan>","In-Reply-To":"<1872710.P2f02irZl9@aspire.rjw.lan>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171029_191627_959954_A36B42CC ","X-CRM114-Status":"UNSURE ( 6.01 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [211.150.99.136 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Mark Rutland , Heiko Stuebner ,\n\ttony@atomide.com, linux-pci@vger.kernel.org, shawn.lin@rock-chips.com,\n\tWill Deacon ,\n\tAmitkumar Karwar , \n\tdianders@chromium.org, Klaus Goger ,\n\tFrank Rowand ,\n\tlinux-rockchip@lists.infradead.org, \n\tbriannorris@chromium.org, linux-acpi@vger.kernel.org,\n\tMatthias Kaehlcke ,\n\tlinux-arm-kernel@lists.infradead.org, \n\tCatalin Marinas , Len Brown ,\n\tdevicetree@vger.kernel.org, Xinming Hu ,\n\tlinux-pm@vger.kernel.org, Nishant Sarmukadam , \n\tRob Herring , bhelgaas@google.com,\n\tKalle Valo , Ganapathi Bhat ,\n\tnetdev@vger.kernel.org, linux-wireless@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, Caesar Wang ","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]