[{"id":1794976,"web_url":"http://patchwork.ozlabs.org/comment/1794976/","msgid":"","list_archive_url":null,"date":"2017-10-27T14:47:10","subject":"Re: [PATCH v3 0/2] refactor code and mark expected switch\n\tfall-throughs","submitter":{"id":69323,"url":"http://patchwork.ozlabs.org/api/people/69323/","name":"David Ranch","email":"linux-hams@trinnet.net"},"content":"Hello Gustavo,\n\nI appreciate you working on keeping up the kernel and maintaining some \nof the older feature areas like AX.25, Netrom, etc. Other than auditing \nyour code changes, can you tell me what you're changing? I've been \nattempting to find who / where does regression tests for the Linus \nkernel to potentially ADD test suites for this area. In the recent \npast, we have seen a lot of toxicity creep into the kernel because no \none is testing their changes and backing out this toxic code out of \nreleased Linux distributions takes a VERY long time.\n\nI'm willing to try and help here but I really would like to follow some \nteam's guidelines of how they would like tests to be created, supported, \netc. Be it in VMs, containers, specific automation languages, etc.\n\n--David\nKI6ZHD\n\n\n\n\nOn 10/26/2017 10:50 PM, Gustavo A. R. Silva wrote:\n> The aim of this patchset is firstly to refactor code in nr_route.c in order to make it\n> easier to read and maintain and, secondly, to mark some expected switch fall-throughs\n> in preparation to enabling -Wimplicit-fallthrough.\n>\n> I have to mention that I did not implement any unit test.\n> If someone has any suggestions on how I could test this piece of code\n> it'd be greatly appreciated.\n>\n> Thanks\n>\n> Changes in v2:\n> - Make use of the swap macro and remove inline keyword as suggested by\n> Walter Harms and Kevin Dawson.\n>\n> Changes in v3:\n> - Update subject for both patches.\n> - Add this cover letter as suggested by David Miller.\n>\n> Gustavo A. R. Silva (2):\n> net: netrom: nr_route: refactor code in nr_add_node\n> net: netrom: nr_route: mark expected switch fall-throughs\n>\n> net/netrom/nr_route.c | 62 ++++++++++++++++-----------------------------------\n> 1 file changed, 19 insertions(+), 43 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNnTd5hHyz9t3p\n\tfor ;\n\tSat, 28 Oct 2017 02:14:13 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751789AbdJ0POL (ORCPT );\n\tFri, 27 Oct 2017 11:14:11 -0400","from trinity.trinnet.net ([69.12.138.16]:63903 \"EHLO\n\ttrinity.trinnet.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751298AbdJ0POK (ORCPT\n\t); Fri, 27 Oct 2017 11:14:10 -0400","from trinity4.trinnet.net (trinity4.trinnet.net [192.168.0.11])\n\tby trinity.trinnet.net (Postfix) with ESMTP id 6273B9CD0412;\n\tFri, 27 Oct 2017 07:47:10 -0700 (PDT)"],"X-Greylist":"delayed 1619 seconds by postgrey-1.27 at vger.kernel.org;\n\tFri, 27 Oct 2017 11:14:10 EDT","Subject":"Re: [PATCH v3 0/2] refactor code and mark expected switch\n\tfall-throughs","To":"\"Gustavo A. R. Silva\" ,\n\tlinux-hams@vger.kernel.org, netdev@vger.kernel.org","References":"","Cc":"\"David S. Miller\" ,\n\tRalf Baechle ,\n\twalter harms , Kevin Dawson ,\n\t\"Bernard, f6bvp\" , Thomas Osterried ","From":"David Ranch ","Message-ID":"","Date":"Fri, 27 Oct 2017 07:47:10 -0700","User-Agent":"Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=windows-1252; format=flowed","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1795102,"web_url":"http://patchwork.ozlabs.org/comment/1795102/","msgid":"<20171027144853.Horde.ExzHfROE4gaCiHalihXFClP@gator4166.hostgator.com>","list_archive_url":null,"date":"2017-10-27T19:48:53","subject":"Re: [PATCH v3 0/2] refactor code and mark expected switch\n\tfall-throughs","submitter":{"id":71553,"url":"http://patchwork.ozlabs.org/api/people/71553/","name":"Gustavo A. R. Silva","email":"garsilva@embeddedor.com"},"content":"Hi David,\n\nQuoting David Ranch :\n\n> Hello Gustavo,\n>\n> I appreciate you working on keeping up the kernel and maintaining \n> some of the older feature areas like AX.25, Netrom, etc. Other than \n> auditing your code changes, can you tell me what you're changing? \n> I've been attempting to find who / where does regression tests for \n> the Linus kernel to potentially ADD test suites for this area. In \n> the recent past, we have seen a lot of toxicity creep into the \n> kernel because no one is testing their changes and backing out this \n> toxic code out of released Linux distributions takes a VERY long time.\n>\n\nHere you can see the patch I'm proposing to refactor some code:\nhttps://patchwork.kernel.org/patch/10029119/\n\nIt does not add any new functionality. It's just a small function that \nhelps to modularize and reduce the size of the code in the \nnr_add_node() function.\n\nThe function I'm proposing (re_sort_routes) re-sort the routes in \nquality order. It takes as arguments a pointer to the nr_node \nstructure which contains the routes within and the indexes of the \nroutes to re-sort.\n\nThis function also replaces a \"manual\" swap of the routes with a call \nto the swap macro.\n\nThanks\n--\nGustavo A. R. Silva\n\n> I'm willing to try and help here but I really would like to follow \n> some team's guidelines of how they would like tests to be created, \n> supported, etc. Be it in VMs, containers, specific automation \n> languages, etc.\n>\n> --David\n> KI6ZHD\n>\n>\n>\n>\n> On 10/26/2017 10:50 PM, Gustavo A. R. Silva wrote:\n>> The aim of this patchset is firstly to refactor code in nr_route.c \n>> in order to make it\n>> easier to read and maintain and, secondly, to mark some expected \n>> switch fall-throughs\n>> in preparation to enabling -Wimplicit-fallthrough.\n>>\n>> I have to mention that I did not implement any unit test.\n>> If someone has any suggestions on how I could test this piece of code\n>> it'd be greatly appreciated.\n>>\n>> Thanks\n>>\n>> Changes in v2:\n>> - Make use of the swap macro and remove inline keyword as suggested by\n>> Walter Harms and Kevin Dawson.\n>>\n>> Changes in v3:\n>> - Update subject for both patches.\n>> - Add this cover letter as suggested by David Miller.\n>>\n>> Gustavo A. R. Silva (2):\n>> net: netrom: nr_route: refactor code in nr_add_node\n>> net: netrom: nr_route: mark expected switch fall-throughs\n>>\n>> net/netrom/nr_route.c | 62 \n>> ++++++++++++++++-----------------------------------\n>> 1 file changed, 19 insertions(+), 43 deletions(-)\n>>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNw2y2VL6z9t31\n\tfor ;\n\tSat, 28 Oct 2017 07:10:02 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752358AbdJ0UKA (ORCPT );\n\tFri, 27 Oct 2017 16:10:00 -0400","from gateway20.websitewelcome.com ([192.185.59.4]:15124 \"EHLO\n\tgateway20.websitewelcome.com\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751760AbdJ0UJ7 (ORCPT\n\t); Fri, 27 Oct 2017 16:09:59 -0400","from cm10.websitewelcome.com (cm10.websitewelcome.com\n\t[100.42.49.4])\n\tby gateway20.websitewelcome.com (Postfix) with ESMTP id 5505B400D34AC\n\tfor ; Fri, 27 Oct 2017 14:48:54 -0500 (CDT)","from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP\n\tid 8Acge64aHpOTv8AcgetFbj; Fri, 27 Oct 2017 14:48:54 -0500","from gator4166.hostgator.com ([108.167.133.22]:13432)\n\tby gator4166.hostgator.com with esmtpsa\n\t(TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87)\n\t(envelope-from )\n\tid 1e8Acf-003CqJ-Oy; Fri, 27 Oct 2017 14:48:53 -0500","from 189.145.38.148 ([189.145.38.148]) by gator4166.hostgator.com\n\t(Horde Framework) with HTTPS; Fri, 27 Oct 2017 14:48:53 -0500"],"X-Greylist":"delayed 1265 seconds by postgrey-1.27 at vger.kernel.org;\n\tFri, 27 Oct 2017 16:09:59 EDT","Date":"Fri, 27 Oct 2017 14:48:53 -0500","Message-ID":"<20171027144853.Horde.ExzHfROE4gaCiHalihXFClP@gator4166.hostgator.com>","From":"\"Gustavo A. R. Silva\" ","To":"David Ranch ","Cc":"linux-hams@vger.kernel.org, netdev@vger.kernel.org,\n\t\"David S. Miller\" ,\n\tRalf Baechle ,\n\twalter harms , Kevin Dawson ,\n\t\"Bernard, f6bvp\" , Thomas Osterried ","Subject":"Re: [PATCH v3 0/2] refactor code and mark expected switch\n\tfall-throughs","References":"\n\t","In-Reply-To":"","User-Agent":"Horde Application Framework 5","Content-Type":"text/plain; charset=utf-8; format=flowed; DelSp=Yes","MIME-Version":"1.0","Content-Disposition":"inline","X-AntiAbuse":["This header was added to track abuse,\n\tplease include it with any abuse report","Primary Hostname - gator4166.hostgator.com","Original Domain - vger.kernel.org","Originator/Caller UID/GID - [47 12] / [47 12]","Sender Address Domain - embeddedor.com"],"X-BWhitelist":"no","X-Source-IP":"108.167.133.22","X-Source-L":"Yes","X-Exim-ID":"1e8Acf-003CqJ-Oy","X-Source":"","X-Source-Args":"","X-Source-Dir":"","X-Source-Sender":"gator4166.hostgator.com [108.167.133.22]:13432","X-Source-Auth":"garsilva@embeddedor.com","X-Email-Count":"11","X-Source-Cap":"Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20=","X-Local-Domain":"yes","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1795324,"web_url":"http://patchwork.ozlabs.org/comment/1795324/","msgid":"","list_archive_url":null,"date":"2017-10-28T17:53:24","subject":"Re: [PATCH v3 0/2] refactor code and mark expected switch\n\tfall-throughs","submitter":{"id":69323,"url":"http://patchwork.ozlabs.org/api/people/69323/","name":"David Ranch","email":"linux-hams@trinnet.net"},"content":"Hello Gustavo,\n\nThanks for the reply. I do appreciate the work but we've had other \npeople contribute to keep things up to date but previous minor patches \nbroke parts of the AX.25 stack in strange ways. The fixes weren't hard \nto repair or backout but due to the timing, various Linux distros based \ntheir releases on the broken kernel code and it's taken a LONG time to\nget things healthy for them. We need be able provide a test harness to \ndevelopers to unit test / regression test their proposed code ideally \nAHEAD of the commit but at least after the commit.\n\nI'm still failing to find any Linux groups that offer some sort of \nautomated build & test environment (Travis, Jenkins, etc) tracking \nvarious kernel branches, etc. It's gotta be out there (many of them in \nfact) but I'm struggling to find them.\n\nFor example, here is an excellent article about what *Intel* is doing \nfor their graphics drivers but I need something that the general \ncommunity can leverage for say various protocol stacks (TCP/IP, AX.25, \nwhatever):\n\n https://lwn.net/Articles/735468/\n\n From that article, it seems that maybe this could be a good place to start:\n\n https://01.org/lkp\n https://github.com/intel/lkp-tests\n\nLooks like a good start but is that what the majority of the Linux \nkernel folk use today? Is it the right group for non-scaled out unit \ntesting that I seek? I also think this email-centric approach might be \nan overly broad approach with WAY too much noise for various development \nareas.\n\nDoes anyone else have thoughts on this topic?\n\n--David\nKI6ZHD\n\n\nOn 10/27/2017 12:48 PM, Gustavo A. R. Silva wrote:\n> Hi David,\n>\n> Quoting David Ranch :\n>\n>> Hello Gustavo,\n>>\n>> I appreciate you working on keeping up the kernel and maintaining some\n>> of the older feature areas like AX.25, Netrom, etc. Other than\n>> auditing your code changes, can you tell me what you're changing? I've\n>> been attempting to find who / where does regression tests for the\n>> Linus kernel to potentially ADD test suites for this area. In the\n>> recent past, we have seen a lot of toxicity creep into the kernel\n>> because no one is testing their changes and backing out this toxic\n>> code out of released Linux distributions takes a VERY long time.\n>>\n>\n> Here you can see the patch I'm proposing to refactor some code:\n> https://patchwork.kernel.org/patch/10029119/\n>\n> It does not add any new functionality. It's just a small function that\n> helps to modularize and reduce the size of the code in the nr_add_node()\n> function.\n>\n> The function I'm proposing (re_sort_routes) re-sort the routes in\n> quality order. It takes as arguments a pointer to the nr_node structure\n> which contains the routes within and the indexes of the routes to re-sort.\n>\n> This function also replaces a \"manual\" swap of the routes with a call to\n> the swap macro.\n>\n> Thanks\n> --\n> Gustavo A. R. Silva\n>\n>> I'm willing to try and help here but I really would like to follow\n>> some team's guidelines of how they would like tests to be created,\n>> supported, etc. Be it in VMs, containers, specific automation\n>> languages, etc.\n>>\n>> --David\n>> KI6ZHD\n>>\n>>\n>>\n>>\n>> On 10/26/2017 10:50 PM, Gustavo A. R. Silva wrote:\n>>> The aim of this patchset is firstly to refactor code in nr_route.c in\n>>> order to make it\n>>> easier to read and maintain and, secondly, to mark some expected\n>>> switch fall-throughs\n>>> in preparation to enabling -Wimplicit-fallthrough.\n>>>\n>>> I have to mention that I did not implement any unit test.\n>>> If someone has any suggestions on how I could test this piece of code\n>>> it'd be greatly appreciated.\n>>>\n>>> Thanks\n>>>\n>>> Changes in v2:\n>>> - Make use of the swap macro and remove inline keyword as suggested by\n>>> Walter Harms and Kevin Dawson.\n>>>\n>>> Changes in v3:\n>>> - Update subject for both patches.\n>>> - Add this cover letter as suggested by David Miller.\n>>>\n>>> Gustavo A. R. Silva (2):\n>>> net: netrom: nr_route: refactor code in nr_add_node\n>>> net: netrom: nr_route: mark expected switch fall-throughs\n>>>\n>>> net/netrom/nr_route.c | 62\n>>> ++++++++++++++++-----------------------------------\n>>> 1 file changed, 19 insertions(+), 43 deletions(-)\n>>>\n>\n>\n>\n>\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yPSyx5Wwdz9t2x\n\tfor ;\n\tSun, 29 Oct 2017 04:53:29 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751746AbdJ1Rx1 (ORCPT );\n\tSat, 28 Oct 2017 13:53:27 -0400","from trinity.trinnet.net ([69.12.138.16]:62336 \"EHLO\n\ttrinity.trinnet.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751731AbdJ1Rx0 (ORCPT\n\t); Sat, 28 Oct 2017 13:53:26 -0400","from trinity4.trinnet.net (trinity4.trinnet.net [192.168.0.11])\n\tby trinity.trinnet.net (Postfix) with ESMTP id 16D609CD0412;\n\tSat, 28 Oct 2017 10:53:25 -0700 (PDT)"],"Subject":"Re: [PATCH v3 0/2] refactor code and mark expected switch\n\tfall-throughs","To":"\"Gustavo A. R. Silva\" ","References":"\n\t\n\t<20171027144853.Horde.ExzHfROE4gaCiHalihXFClP@gator4166.hostgator.com>","Cc":"linux-hams@vger.kernel.org, netdev@vger.kernel.org,\n\t\"David S. Miller\" ,\n\tRalf Baechle ,\n\twalter harms , Kevin Dawson ,\n\t\"Bernard, f6bvp\" , Thomas Osterried ","From":"David Ranch ","Message-ID":"","Date":"Sat, 28 Oct 2017 10:53:24 -0700","User-Agent":"Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<20171027144853.Horde.ExzHfROE4gaCiHalihXFClP@gator4166.hostgator.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1795359,"web_url":"http://patchwork.ozlabs.org/comment/1795359/","msgid":"<20171029.104541.1487088453362795756.davem@davemloft.net>","list_archive_url":null,"date":"2017-10-29T01:45:41","subject":"Re: [PATCH v3 0/2] refactor code and mark expected switch\n\tfall-throughs","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: David Ranch \nDate: Sat, 28 Oct 2017 10:53:24 -0700\n\n> Does anyone else have thoughts on this topic?\n\nI think you are making a mountain out of a mole hill.\n\nIf you care so much about this, set things up so that entities such as\nthe kbuild test robot run whatever tests you think are necessary.\n\nOtherwise, continually test the stack yourself and report any\nregressions here as fast as you can.\n\nIf soemone can't be bothered to verify or test someone's change in 2\nor 3 days, except in extreme circumstances, I absolutely refuse to\nburdon the submitter and let their patches rot in the queue.\n\nThat's unacceptable.\n\nThat's the proper way to deal with this, without unreasonably\nburdoning people who just want to keep the code across the tree modern\nand more up to date.\n\nThank you.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yPgS21tRbz9sNd\n\tfor ;\n\tSun, 29 Oct 2017 12:45:54 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751676AbdJ2Bpt (ORCPT );\n\tSat, 28 Oct 2017 21:45:49 -0400","from shards.monkeyblade.net ([184.105.139.130]:43198 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751216AbdJ2Bps (ORCPT\n\t); Sat, 28 Oct 2017 21:45:48 -0400","from localhost (unknown [106.252.28.196])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 34DF5123848B4;\n\tSat, 28 Oct 2017 18:45:43 -0700 (PDT)"],"Date":"Sun, 29 Oct 2017 10:45:41 +0900 (KST)","Message-Id":"<20171029.104541.1487088453362795756.davem@davemloft.net>","To":"linux-hams@trinnet.net","Cc":"garsilva@embeddedor.com, linux-hams@vger.kernel.org,\n\tnetdev@vger.kernel.org, ralf@linux-mips.org, wharms@bfs.de,\n\thal@kd.net.au, f6bvp@free.fr, thomas@osterried.de","Subject":"Re: [PATCH v3 0/2] refactor code and mark expected switch\n\tfall-throughs","From":"David Miller ","In-Reply-To":"","References":"\n\t<20171027144853.Horde.ExzHfROE4gaCiHalihXFClP@gator4166.hostgator.com>\n\t","X-Mailer":"Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Sat, 28 Oct 2017 18:45:47 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1795383,"web_url":"http://patchwork.ozlabs.org/comment/1795383/","msgid":"","list_archive_url":null,"date":"2017-10-29T04:15:45","subject":"Re: [PATCH v3 0/2] refactor code and mark expected switch\n\tfall-throughs","submitter":{"id":69323,"url":"http://patchwork.ozlabs.org/api/people/69323/","name":"David Ranch","email":"linux-hams@trinnet.net"},"content":"Hello David,\n\nThanks for the reply. I completely admit that there aren't many changes \ngoing into this section of code. Unfortunately, we've had some nasty \nbreaks that took quite a long while to get fixed.\n\nCan you point me in the direction of this kbuild test robot (URLs, etc) \nso I can better understand if it makes sense to add tests there? For \nexample, do you know if it's \"changed based\" so only certain tests will \nrun if given files are updated?\n\n--David\nKI6ZHD\n\n\nOn 10/28/2017 06:45 PM, David Miller wrote:\n> From: David Ranch \n> Date: Sat, 28 Oct 2017 10:53:24 -0700\n>\n>> Does anyone else have thoughts on this topic?\n>\n> I think you are making a mountain out of a mole hill.\n>\n> If you care so much about this, set things up so that entities such as\n> the kbuild test robot run whatever tests you think are necessary.\n>\n> Otherwise, continually test the stack yourself and report any\n> regressions here as fast as you can.\n>\n> If soemone can't be bothered to verify or test someone's change in 2\n> or 3 days, except in extreme circumstances, I absolutely refuse to\n> burdon the submitter and let their patches rot in the queue.\n>\n> That's unacceptable.\n>\n> That's the proper way to deal with this, without unreasonably\n> burdoning people who just want to keep the code across the tree modern\n> and more up to date.\n>\n> Thank you.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yPknP0Zlhz9t2v\n\tfor ;\n\tSun, 29 Oct 2017 15:16:09 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750916AbdJ2EPs (ORCPT );\n\tSun, 29 Oct 2017 00:15:48 -0400","from trinity.trinnet.net ([69.12.138.16]:61260 \"EHLO\n\ttrinity.trinnet.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750705AbdJ2EPr (ORCPT\n\t); Sun, 29 Oct 2017 00:15:47 -0400","from trinity4.trinnet.net (trinity4.trinnet.net [192.168.0.11])\n\tby trinity.trinnet.net (Postfix) with ESMTP id 14C089CD0435;\n\tSat, 28 Oct 2017 21:15:46 -0700 (PDT)"],"Subject":"Re: [PATCH v3 0/2] refactor code and mark expected switch\n\tfall-throughs","To":"David Miller ","References":"\n\t<20171027144853.Horde.ExzHfROE4gaCiHalihXFClP@gator4166.hostgator.com>\n\t\n\t<20171029.104541.1487088453362795756.davem@davemloft.net>","Cc":"garsilva@embeddedor.com, linux-hams@vger.kernel.org,\n\tnetdev@vger.kernel.org, ralf@linux-mips.org, wharms@bfs.de,\n\thal@kd.net.au, f6bvp@free.fr, thomas@osterried.de","From":"David Ranch ","Message-ID":"","Date":"Sat, 28 Oct 2017 21:15:45 -0700","User-Agent":"Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<20171029.104541.1487088453362795756.davem@davemloft.net>","Content-Type":"text/plain; charset=windows-1252; format=flowed","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1797212,"web_url":"http://patchwork.ozlabs.org/comment/1797212/","msgid":"<20171101.204658.787298649317439690.davem@davemloft.net>","list_archive_url":null,"date":"2017-11-01T11:46:58","subject":"Re: [PATCH v3 0/2] refactor code and mark expected switch\n\tfall-throughs","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: \"Gustavo A. R. Silva\" \nDate: Fri, 27 Oct 2017 00:50:57 -0500\n\n> The aim of this patchset is firstly to refactor code in nr_route.c in order to make it\n> easier to read and maintain and, secondly, to mark some expected switch fall-throughs\n> in preparation to enabling -Wimplicit-fallthrough.\n> \n> I have to mention that I did not implement any unit test.\n> If someone has any suggestions on how I could test this piece of code\n> it'd be greatly appreciated.\n\nSeries applied, thank you.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yRmfc28mwz9sP1\n\tfor ;\n\tWed, 1 Nov 2017 22:47:20 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754520AbdKALrG (ORCPT );\n\tWed, 1 Nov 2017 07:47:06 -0400","from shards.monkeyblade.net ([184.105.139.130]:52346 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753858AbdKALrF (ORCPT\n\t); Wed, 1 Nov 2017 07:47:05 -0400","from localhost (unknown [106.252.28.196])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 25B481363BC83;\n\tWed, 1 Nov 2017 04:47:01 -0700 (PDT)"],"Date":"Wed, 01 Nov 2017 20:46:58 +0900 (KST)","Message-Id":"<20171101.204658.787298649317439690.davem@davemloft.net>","To":"garsilva@embeddedor.com","Cc":"linux-hams@vger.kernel.org, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, ralf@linux-mips.org, wharms@bfs.de,\n\thal@kd.net.au","Subject":"Re: [PATCH v3 0/2] refactor code and mark expected switch\n\tfall-throughs","From":"David Miller ","In-Reply-To":"","References":"<20171022203942.Horde.vHHdAHmZbpcBFTJEP0yIy9k@gator4166.hostgator.com>\n\t","X-Mailer":"Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Wed, 01 Nov 2017 04:47:05 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1797389,"web_url":"http://patchwork.ozlabs.org/comment/1797389/","msgid":"<20171101123415.Horde.loz1BKI5e4PY4wt8KJqogy7@gator4166.hostgator.com>","list_archive_url":null,"date":"2017-11-01T17:34:15","subject":"Re: [PATCH v3 0/2] refactor code and mark expected switch\n\tfall-throughs","submitter":{"id":71553,"url":"http://patchwork.ozlabs.org/api/people/71553/","name":"Gustavo A. R. Silva","email":"garsilva@embeddedor.com"},"content":"Quoting David Miller :\n\n> From: \"Gustavo A. R. Silva\" \n> Date: Fri, 27 Oct 2017 00:50:57 -0500\n>\n>> The aim of this patchset is firstly to refactor code in nr_route.c \n>> in order to make it\n>> easier to read and maintain and, secondly, to mark some expected \n>> switch fall-throughs\n>> in preparation to enabling -Wimplicit-fallthrough.\n>>\n>> I have to mention that I did not implement any unit test.\n>> If someone has any suggestions on how I could test this piece of code\n>> it'd be greatly appreciated.\n>\n> Series applied, thank you.\n\nGlad to help.\n\nThanks\n--\nGustavo A. R. Silva","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yRwM26TlVz9sRW\n\tfor ;\n\tThu, 2 Nov 2017 04:34:22 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755013AbdKAReV (ORCPT );\n\tWed, 1 Nov 2017 13:34:21 -0400","from gateway31.websitewelcome.com ([192.185.144.97]:42332 \"EHLO\n\tgateway31.websitewelcome.com\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751653AbdKAReT (ORCPT\n\t); Wed, 1 Nov 2017 13:34:19 -0400","from cm17.websitewelcome.com (cm17.websitewelcome.com\n\t[100.42.49.20])\n\tby gateway31.websitewelcome.com (Postfix) with ESMTP id 6A028133B96\n\tfor ; Wed, 1 Nov 2017 12:34:16 -0500 (CDT)","from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP\n\tid 9wu8eYUfac72g9wu8eWryj; Wed, 01 Nov 2017 12:34:16 -0500","from gator4166.hostgator.com ([108.167.133.22]:34168)\n\tby gator4166.hostgator.com with esmtpsa\n\t(TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87)\n\t(envelope-from )\n\tid 1e9wu7-0049MR-Vm; Wed, 01 Nov 2017 12:34:16 -0500","from 189.145.38.148 ([189.145.38.148]) by gator4166.hostgator.com\n\t(Horde Framework) with HTTPS; Wed, 01 Nov 2017 12:34:15 -0500"],"Date":"Wed, 01 Nov 2017 12:34:15 -0500","Message-ID":"<20171101123415.Horde.loz1BKI5e4PY4wt8KJqogy7@gator4166.hostgator.com>","From":"\"Gustavo A. R. Silva\" ","To":"David Miller ","Cc":"linux-hams@vger.kernel.org, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, ralf@linux-mips.org, wharms@bfs.de,\n\thal@kd.net.au","Subject":"Re: [PATCH v3 0/2] refactor code and mark expected switch\n\tfall-throughs","References":"<20171022203942.Horde.vHHdAHmZbpcBFTJEP0yIy9k@gator4166.hostgator.com>\n\t\n\t<20171101.204658.787298649317439690.davem@davemloft.net>","In-Reply-To":"<20171101.204658.787298649317439690.davem@davemloft.net>","User-Agent":"Horde Application Framework 5","Content-Type":"text/plain; charset=utf-8; format=flowed; DelSp=Yes","MIME-Version":"1.0","Content-Disposition":"inline","X-AntiAbuse":["This header was added to track abuse,\n\tplease include it with any abuse report","Primary Hostname - gator4166.hostgator.com","Original Domain - vger.kernel.org","Originator/Caller UID/GID - [47 12] / [47 12]","Sender Address Domain - embeddedor.com"],"X-BWhitelist":"no","X-Source-IP":"108.167.133.22","X-Source-L":"Yes","X-Exim-ID":"1e9wu7-0049MR-Vm","X-Source":"","X-Source-Args":"","X-Source-Dir":"","X-Source-Sender":"gator4166.hostgator.com [108.167.133.22]:34168","X-Source-Auth":"garsilva@embeddedor.com","X-Email-Count":"8","X-Source-Cap":"Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20=","X-Local-Domain":"yes","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1801745,"web_url":"http://patchwork.ozlabs.org/comment/1801745/","msgid":"<8C2772CF-503A-4BA1-945B-4D4BCC5BA5FB@free.fr>","list_archive_url":null,"date":"2017-11-08T22:02:17","subject":"Re: [PATCH v3 0/2] refactor code and mark expected switch\n\tfall-throughs","submitter":{"id":614,"url":"http://patchwork.ozlabs.org/api/people/614/","name":"Bernard Pidoux","email":"f6bvp@free.fr"},"content":"Hi all,\nI just want to report that I applied the NetRom patch to most recent kernel. NetRom does not seem to be affected and connexion is doing well between my FPAC node f6bvp and f3kt.\n\n73 de Bernard f6bvp\n\nSent from my iPhone\n\n> Le 29 oct. 2017 à 05:15, David Ranch a écrit :\n> \n> \n> Hello David,\n> \n> Thanks for the reply. I completely admit that there aren't many changes going into this section of code. Unfortunately, we've had some nasty breaks that took quite a long while to get fixed.\n> \n> Can you point me in the direction of this kbuild test robot (URLs, etc) so I can better understand if it makes sense to add tests there? For example, do you know if it's \"changed based\" so only certain tests will run if given files are updated?\n> \n> --David\n> KI6ZHD\n> \n> \n>> On 10/28/2017 06:45 PM, David Miller wrote:\n>> From: David Ranch \n>> Date: Sat, 28 Oct 2017 10:53:24 -0700\n>> \n>>> Does anyone else have thoughts on this topic?\n>> \n>> I think you are making a mountain out of a mole hill.\n>> \n>> If you care so much about this, set things up so that entities such as\n>> the kbuild test robot run whatever tests you think are necessary.\n>> \n>> Otherwise, continually test the stack yourself and report any\n>> regressions here as fast as you can.\n>> \n>> If soemone can't be bothered to verify or test someone's change in 2\n>> or 3 days, except in extreme circumstances, I absolutely refuse to\n>> burdon the submitter and let their patches rot in the queue.\n>> \n>> That's unacceptable.\n>> \n>> That's the proper way to deal with this, without unreasonably\n>> burdoning people who just want to keep the code across the tree modern\n>> and more up to date.\n>> \n>> Thank you.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yXL8m2Sgsz9s5L\n\tfor ;\n\tThu, 9 Nov 2017 09:10:48 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752769AbdKHWKp convert rfc822-to-8bit (ORCPT\n\t);\n\tWed, 8 Nov 2017 17:10:45 -0500","from shiva144.upmc.fr ([134.157.0.144]:55308 \"EHLO\n\tshiva144.upmc.fr\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751245AbdKHWKo (ORCPT );\n\tWed, 8 Nov 2017 17:10:44 -0500","from shiva144.upmc.fr (localhost [127.0.0.1])\n\tby shiva144.upmc.fr (Postfix) with ESMTP id D3D7024EC8;\n\tWed, 8 Nov 2017 23:02:19 +0100 (CET)","from courriel.upmc.fr (courriel3.reseau.jussieu.fr [134.157.0.194])\n\tby shiva144.upmc.fr (Postfix) with ESMTP id C542624A3E;\n\tWed, 8 Nov 2017 23:02:19 +0100 (CET)","from [192.168.0.146] (lns-bzn-40-82-251-146-223.adsl.proxad.net\n\t[82.251.146.223]) (authentified, mech=PLAIN)\n\tby courriel.upmc.fr (8.14.5/jtpda-5.5pre1) with ESMTP id\n\tvA8M2HCj008477 (version=TLSv1/SSLv3\n\tcipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO)\n\t; Wed, 8 Nov 2017 23:02:17 +0100 (CET) (envelope-from f6bvp@free.fr)"],"X-Greylist":"delayed 503 seconds by postgrey-1.27 at vger.kernel.org;\n\tWed, 08 Nov 2017 17:10:44 EST","X-CIds":"courriel3","Content-Type":"text/plain;\n charset=gb2312","Mime-Version":"1.0 (1.0)","Subject":"Re: [PATCH v3 0/2] refactor code and mark expected switch\n\tfall-throughs","From":"f6bvp ","X-Mailer":"iPhone Mail (15A432)","In-Reply-To":"","Date":"Wed, 8 Nov 2017 23:02:17 +0100","Cc":"David Miller , garsilva@embeddedor.com,\n\tlinux-hams@vger.kernel.org, netdev@vger.kernel.org,\n\tralf@linux-mips.org, wharms@bfs.de, hal@kd.net.au, thomas@osterried.de","Content-Transfer-Encoding":"8BIT","Message-Id":"<8C2772CF-503A-4BA1-945B-4D4BCC5BA5FB@free.fr>","References":"\n\t<20171027144853.Horde.ExzHfROE4gaCiHalihXFClP@gator4166.hostgator.com>\n\t\n\t<20171029.104541.1487088453362795756.davem@davemloft.net>\n\t","To":"David Ranch ","X-Virus-Scanned":"ClamAV using ClamSMTP","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]