[{"id":1787872,"web_url":"http://patchwork.ozlabs.org/comment/1787872/","msgid":"<59E53637.8020502@gmail.com>","list_archive_url":null,"date":"2017-10-16T22:44:07","subject":"Re: [RESEND][PATCH 0/4] firmware: of: populate /firmware/ node\n\tduring init","submitter":{"id":64196,"url":"http://patchwork.ozlabs.org/api/people/64196/","name":"Frank Rowand","email":"frowand.list@gmail.com"},"content":"+ me\n\nOn 09/28/17 03:45, Sudeep Holla wrote:\n> Hi Rob, Arnd,\n> \n> There's a push to place all firmware related device node under\n> /firmware/ node. However all the associated drivers are dealing with\n> device creation in their own ways. For example, qcom_scm, optee and\n> meson-sm drivers deal with the node in their own way. The SCMI drivers\n> I am about to add also needs to do the same. This small series is to\n> make it generic so that all the users of /firmware/ node need not\n> repeat the same.\n> \n> There was concern that /firmware in DT is fit for /sys/firmware in sysfs.\n> IMO anything exposed to userspace from such firmware interface must\n> be in \"/sys/firmware\", but I don't see any issue with kernel handling\n> them as platform device/driver internally.\n> \n> Sudeep Holla (4):\n> of: platform: populate /firmware/ node from\n> of_platform_default_populate_init()\n> firmware: qcom_scm: drop redandant of_platform_populate\n> drivers: tee: rework optee_driver_{init,exit} to use platform device\n> firmware: meson-sm: rework meson_sm_init to use\n> module_platform_driver_probe\n> \n> drivers/firmware/meson/meson_sm.c | 21 ++++++-----\n> drivers/firmware/qcom_scm.c | 24 -------------\n> drivers/of/platform.c | 4 +++\n> drivers/tee/optee/core.c | 74 +++++++++++++--------------------------\n> 4 files changed, 41 insertions(+), 82 deletions(-)\n> \n> --\n> 2.7.4\n> \n> --\n> To unsubscribe from this list: send the line \"unsubscribe devicetree\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n> \n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"QY7UtXkH\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yGCzw3sc3z9sRn\n\tfor ;\n\tTue, 17 Oct 2017 09:44:12 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932361AbdJPWoK (ORCPT );\n\tMon, 16 Oct 2017 18:44:10 -0400","from mail-pf0-f194.google.com ([209.85.192.194]:52348 \"EHLO\n\tmail-pf0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932321AbdJPWoK (ORCPT\n\t); Mon, 16 Oct 2017 18:44:10 -0400","by mail-pf0-f194.google.com with SMTP id e64so16854121pfk.9;\n\tMon, 16 Oct 2017 15:44:09 -0700 (PDT)","from [192.168.1.46] (c-73-93-215-6.hsd1.ca.comcast.net.\n\t[73.93.215.6]) by smtp.gmail.com with ESMTPSA id\n\tc26sm16361290pfl.115.2017.10.16.15.44.07\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 16 Oct 2017 15:44:08 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:references:cc:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=tkzMHHTKjb3njQw5Y77JsYQ/KgLkGVQHvBB823aM4h4=;\n\tb=QY7UtXkHf2i4q95rUQOGTVdBxFJ1V3bG9KQCGeFN4Q5RKLU+Ma5JYFdB7sSYSlSaH3\n\tyFgIbQYH2KhZRr0qRHx2LyGMJXgdycGBz9wJM6NwuGKVHsTpanKgkCIdyDgRqAoWVY4C\n\tGX7ByqHEWCIj4PpZN53A3ae5uJc6J23QGRTMqNZPXMujoQ9zygZw3Kj2eZOY806CbHEu\n\tYEusHabQTQJkUmeY9qqZfAdhyDtbkIJn1PVhJOwlxv6a+Q2SOqWVtVhD/wwjZEvgrf3N\n\tQ96OSFoeNBzhHJqN/+MsATh4omdKcZmyfqJrDxw1pv2hnkmp9J9d2Du+r/ggpNwDmmf0\n\tS+mQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:cc:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=tkzMHHTKjb3njQw5Y77JsYQ/KgLkGVQHvBB823aM4h4=;\n\tb=dd/aFfJckTjENhQU5rRIp7FLK/rjDERUKslb4rIlDR8guUos4nKM3qaE+wBr2KNJk6\n\tb5zoV84QVQ9aEtfOta0kjOQbGR7pZT3nuNVMnj0BW0ZK3k+yjmHxgkp8L9K+XVlXYcRL\n\tRvGS6gkjq5UbiAMhY7i7UOIRFZwHVuyyTFkRD2UzQdpxwydf5Tj5oe9+8Sgc7Z+IoJMe\n\tqqemQND+QQOQJVTBzYLj1Zz1T4KTrn8RMybhImwAewloQuqFMhSU+0ADqNdTVnKNXywG\n\tbC/x9rdJLE9UM8gzevus5OmsEAIwfXxr0kTYQ0vrB/mDkGjPO1wGWzLbGdfUkDLo6iJe\n\tALVA==","X-Gm-Message-State":"AMCzsaXHPsOY0cm+mghENwtBZ1rOdQMFdgkFfsH5N1XxSXsyO8q6kprU\n\tDCpF54Ow1wMlfJBF+EzEius=","X-Google-Smtp-Source":"AOwi7QD5kiZMujss9vkk3532ibaYXVZcb/JiE7l8x+YdHzgW4Dy4zLZAJgztSxf/001Z0rcjf7dyWQ==","X-Received":"by 10.84.225.145 with SMTP id u17mr10009320plj.309.1508193849255;\n\tMon, 16 Oct 2017 15:44:09 -0700 (PDT)","Subject":"Re: [RESEND][PATCH 0/4] firmware: of: populate /firmware/ node\n\tduring init","To":"Sudeep Holla , linux-arm-kernel@lists.infradead.org","References":"<1506595562-10592-1-git-send-email-sudeep.holla@arm.com>","Cc":"linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,\n\tRob Herring , Frank Rowand ","From":"Frank Rowand ","Message-ID":"<59E53637.8020502@gmail.com>","Date":"Mon, 16 Oct 2017 15:44:07 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101\n\tThunderbird/38.4.0","MIME-Version":"1.0","In-Reply-To":"<1506595562-10592-1-git-send-email-sudeep.holla@arm.com>","Content-Type":"text/plain; charset=windows-1252","Content-Transfer-Encoding":"7bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1787874,"web_url":"http://patchwork.ozlabs.org/comment/1787874/","msgid":"<59E53651.5070704@gmail.com>","list_archive_url":null,"date":"2017-10-16T22:44:33","subject":"Re: [RESEND][PATCH 1/4] of: platform: populate /firmware/ node from\n\tof_platform_default_populate_init()","submitter":{"id":64196,"url":"http://patchwork.ozlabs.org/api/people/64196/","name":"Frank Rowand","email":"frowand.list@gmail.com"},"content":"+ me\n\nOn 09/28/17 03:45, Sudeep Holla wrote:\n> Since \"/firmware\" does not have its own \"compatible\" property as it's\n> just collection of nodes representing firmware interface, it's sub-nodes\n> are not populated during system initialization.\n> \n> Currently different firmware drivers search the /firmware/ node and\n> populate the sub-node devices selectively. Instead we can populate\n> the /firmware/ node during init to avoid more drivers continuing to\n> populate the devices selectively.\n> \n> To generalize the solution this patch populates the /firmware/ node\n> explicitly from of_platform_default_populate_init().\n> \n> Cc: Arnd Bergmann \n> Cc: Rob Herring \n> Signed-off-by: Sudeep Holla \n> ---\n> drivers/of/platform.c | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/drivers/of/platform.c b/drivers/of/platform.c\n> index ac15d0e3d27d..3a213a6aee89 100644\n> --- a/drivers/of/platform.c\n> +++ b/drivers/of/platform.c\n> @@ -515,6 +515,10 @@ static int __init of_platform_default_populate_init(void)\n> \t\t\tof_platform_device_create(node, NULL, NULL);\n> \t}\n> \n> +\tnode = of_find_node_by_path(\"/firmware\");\n> +\tif (node)\n> +\t\tof_platform_populate(node, NULL, NULL, NULL);\n> +\n> \t/* Populate everything else. */\n> \tof_platform_default_populate(NULL, NULL, NULL);\n> \n> \n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"B1IhE+sl\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yGD0Q5bb9z9sRq\n\tfor ;\n\tTue, 17 Oct 2017 09:44:38 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932600AbdJPWoh (ORCPT );\n\tMon, 16 Oct 2017 18:44:37 -0400","from mail-pf0-f194.google.com ([209.85.192.194]:44853 \"EHLO\n\tmail-pf0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932321AbdJPWog (ORCPT\n\t); Mon, 16 Oct 2017 18:44:36 -0400","by mail-pf0-f194.google.com with SMTP id x7so16886142pfa.1;\n\tMon, 16 Oct 2017 15:44:35 -0700 (PDT)","from [192.168.1.46] (c-73-93-215-6.hsd1.ca.comcast.net.\n\t[73.93.215.6]) by smtp.gmail.com with ESMTPSA id\n\tj6sm17077983pfk.159.2017.10.16.15.44.34\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 16 Oct 2017 15:44:35 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:references:cc:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=JdfvMIQImkaDHgdl3l2w9wyapyccS0UkjyYSfTCFPxA=;\n\tb=B1IhE+slV3A/FTRAtSdIPz3OhNWrHa/wmyMB+s3YACXH4u0u5/F8iUtK3HXJukUDWb\n\tW6aVkKT1yti07AoJQIK0vldWkp9jQcKKf0aVd0ivwpLkgheUlggzI+cZXkykuISqRNR4\n\tZMuX/16HfgAhMvW3+NBG690AVimX0mpQNxsLxIUDXr7vBWgktSriiRxmh5lcM6HX+AU+\n\t+5jghimMrVWJRgthjsrh6THlXX9y+0+pdGXhNGBSsG3NPUn8ZJgT4IbaMs7YRcmwOave\n\tRqb40bYiqaNZ1VHrp2VcHUM25lqrD7i3FqY8u59RKqYVLv1XKEcNtLEwcXgv37sgP8SY\n\tI2bA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:cc:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=JdfvMIQImkaDHgdl3l2w9wyapyccS0UkjyYSfTCFPxA=;\n\tb=BAH2DQDmqO7kLQ0jphRzSvBddHkU9u9ixqVjR7AyR9pdvwsd43PcycV41EE638aGp0\n\tVD0twGTUHnKVdv+fx8D0YWfLjc3U89b4NMnwiA164KklHw3aphvGbldyq37vWbdMoaeV\n\tKuaUp4TRgxXJmrW/wPXneKd6xh+hGg+L/qDMF8LIRiLpwaL171Lb0cI8kenv0N1TCsx/\n\tcR4Dr6AhfwIZItZyiNJWhSEL+QhD5Re+VQzhk4v++SnZEPCLxTkNfV5uDiEAtIqhneVw\n\tzOO4aw4vJnjhzdA9/xOzMmGZQ+2BxX9qkQbZffKBqkdJuqdhL79vr7iuvCffDUBW2Mqt\n\ta4vA==","X-Gm-Message-State":"AMCzsaVQn1kMWqGtcpSRphRCQoJF9Uaxw/7xNx/Fajq76Mv2vN+cEnLy\n\tTBneqJAgZ5D4lGLxNASw+3o=","X-Google-Smtp-Source":"AOwi7QDgv688kVPHYjaaGnxi81j2CL3tFaFivZY6Qy0jejJ5g4dlPD0J59MWxJEQMw3gatXhywPcAA==","X-Received":"by 10.98.71.194 with SMTP id p63mr9969616pfi.26.1508193875632;\n\tMon, 16 Oct 2017 15:44:35 -0700 (PDT)","Subject":"Re: [RESEND][PATCH 1/4] of: platform: populate /firmware/ node from\n\tof_platform_default_populate_init()","To":"Sudeep Holla , linux-arm-kernel@lists.infradead.org","References":"<1506595562-10592-1-git-send-email-sudeep.holla@arm.com>\n\t<1506595562-10592-2-git-send-email-sudeep.holla@arm.com>","Cc":"Rob Herring , Arnd Bergmann ,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tRob Herring , Frank Rowand ","From":"Frank Rowand ","Message-ID":"<59E53651.5070704@gmail.com>","Date":"Mon, 16 Oct 2017 15:44:33 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101\n\tThunderbird/38.4.0","MIME-Version":"1.0","In-Reply-To":"<1506595562-10592-2-git-send-email-sudeep.holla@arm.com>","Content-Type":"text/plain; charset=windows-1252","Content-Transfer-Encoding":"7bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1788377,"web_url":"http://patchwork.ozlabs.org/comment/1788377/","msgid":"","list_archive_url":null,"date":"2017-10-17T13:02:12","subject":"Re: [RESEND][PATCH 1/4] of: platform: populate /firmware/ node from\n\tof_platform_default_populate_init()","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring","email":"robh@kernel.org"},"content":"On Thu, Sep 28, 2017 at 5:45 AM, Sudeep Holla wrote:\n> Since \"/firmware\" does not have its own \"compatible\" property as it's\n> just collection of nodes representing firmware interface, it's sub-nodes\n> are not populated during system initialization.\n>\n> Currently different firmware drivers search the /firmware/ node and\n> populate the sub-node devices selectively. Instead we can populate\n> the /firmware/ node during init to avoid more drivers continuing to\n> populate the devices selectively.\n>\n> To generalize the solution this patch populates the /firmware/ node\n> explicitly from of_platform_default_populate_init().\n>\n> Cc: Arnd Bergmann \n> Cc: Rob Herring \n> Signed-off-by: Sudeep Holla \n> ---\n> drivers/of/platform.c | 4 ++++\n> 1 file changed, 4 insertions(+)\n\nAcked-by: Rob Herring \n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=robh@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yGb2f74N0z9sBW\n\tfor ;\n\tWed, 18 Oct 2017 00:02:50 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1757690AbdJQNCf (ORCPT\n\t);\n\tTue, 17 Oct 2017 09:02:35 -0400","from mail.kernel.org ([198.145.29.99]:57350 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1758104AbdJQNCe (ORCPT );\n\tTue, 17 Oct 2017 09:02:34 -0400","from mail-qk0-f179.google.com (mail-qk0-f179.google.com\n\t[209.85.220.179])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id D304021923;\n\tTue, 17 Oct 2017 13:02:33 +0000 (UTC)","by mail-qk0-f179.google.com with SMTP id o187so1856425qke.7;\n\tTue, 17 Oct 2017 06:02:33 -0700 (PDT)","by 10.12.130.134 with HTTP; Tue, 17 Oct 2017 06:02:12 -0700 (PDT)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org D304021923","X-Gm-Message-State":"AMCzsaX0iQ2n2l3QjJpCucbgcvLDrEiyAQ5n0l9db5PUWRq/WGOhs+yI\n\tPTL4TKu9YHddcm2YQvapk3SoMppnldaCoS0NeQ==","X-Google-Smtp-Source":"AOwi7QC/8E5fQSBwGTYyfv30SPP6rk+Vg03GwJAI4rNvttwgEMl5z4l5hGH0lMXVwNpDren+9W9002BZwomGvVBZ7Io=","X-Received":"by 10.55.17.211 with SMTP id 80mr17971107qkr.270.1508245353048; \n\tTue, 17 Oct 2017 06:02:33 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1506595562-10592-2-git-send-email-sudeep.holla@arm.com>","References":"<1506595562-10592-1-git-send-email-sudeep.holla@arm.com>\n\t<1506595562-10592-2-git-send-email-sudeep.holla@arm.com>","From":"Rob Herring ","Date":"Tue, 17 Oct 2017 08:02:12 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [RESEND][PATCH 1/4] of: platform: populate /firmware/ node from\n\tof_platform_default_populate_init()","To":"Sudeep Holla ","Cc":"\"linux-arm-kernel@lists.infradead.org\" \n\t,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"devicetree@vger.kernel.org\" ,\n\tArnd Bergmann , Frank Rowand ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1792648,"web_url":"http://patchwork.ozlabs.org/comment/1792648/","msgid":"<52ed3abb-6b05-89c9-5ab4-31b37ffa1db9@arm.com>","list_archive_url":null,"date":"2017-10-23T15:59:54","subject":"Re: [RESEND][PATCH 1/4] of: platform: populate /firmware/ node from\n\tof_platform_default_populate_init()","submitter":{"id":47836,"url":"http://patchwork.ozlabs.org/api/people/47836/","name":"Sudeep Holla","email":"Sudeep.Holla@arm.com"},"content":"Hi Arnd,\n\nOn 17/10/17 14:02, Rob Herring wrote:\n> On Thu, Sep 28, 2017 at 5:45 AM, Sudeep Holla wrote:\n>> Since \"/firmware\" does not have its own \"compatible\" property as it's\n>> just collection of nodes representing firmware interface, it's sub-nodes\n>> are not populated during system initialization.\n>>\n>> Currently different firmware drivers search the /firmware/ node and\n>> populate the sub-node devices selectively. Instead we can populate\n>> the /firmware/ node during init to avoid more drivers continuing to\n>> populate the devices selectively.\n>>\n>> To generalize the solution this patch populates the /firmware/ node\n>> explicitly from of_platform_default_populate_init().\n>>\n\nYou had concernsin the past and I mentioned that firmware interface to\nuser-space *has* to continue in /sys/firmware, but he platform_device\nmanagement is internal to kernel.\n\nCan we proceed with this change at-least for qcom and meson firmware\nwhich are platform device already ? I can drop optee related changes.","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yLLhW0S6lz9tX8\n\tfor ;\n\tTue, 24 Oct 2017 03:00:11 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932341AbdJWQAJ (ORCPT );\n\tMon, 23 Oct 2017 12:00:09 -0400","from foss.arm.com ([217.140.101.70]:40528 \"EHLO foss.arm.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S932338AbdJWQAI (ORCPT );\n\tMon, 23 Oct 2017 12:00:08 -0400","from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0CB351435;\n\tMon, 23 Oct 2017 09:00:08 -0700 (PDT)","from [10.1.210.28] (e107155-lin.cambridge.arm.com [10.1.210.28])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n\tB15173F25D; Mon, 23 Oct 2017 09:00:05 -0700 (PDT)"],"Cc":"Rob Herring , Sudeep Holla ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"devicetree@vger.kernel.org\" ,\n\tFrank Rowand ","Subject":"Re: [RESEND][PATCH 1/4] of: platform: populate /firmware/ node from\n\tof_platform_default_populate_init()","To":"Arnd Bergmann ","References":"<1506595562-10592-1-git-send-email-sudeep.holla@arm.com>\n\t<1506595562-10592-2-git-send-email-sudeep.holla@arm.com>\n\t","From":"Sudeep Holla ","Organization":"ARM","Message-ID":"<52ed3abb-6b05-89c9-5ab4-31b37ffa1db9@arm.com>","Date":"Mon, 23 Oct 2017 16:59:54 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1828751,"web_url":"http://patchwork.ozlabs.org/comment/1828751/","msgid":"","list_archive_url":null,"date":"2017-12-26T21:26:04","subject":"Re: [RESEND][PATCH 1/4] of: platform: populate /firmware/ node from\n\tof_platform_default_populate_init()","submitter":{"id":68398,"url":"http://patchwork.ozlabs.org/api/people/68398/","name":"Bjorn Andersson","email":"bjorn.andersson@linaro.org"},"content":"On Thu, Sep 28, 2017 at 3:45 AM, Sudeep Holla wrote:\n> Since \"/firmware\" does not have its own \"compatible\" property as it's\n> just collection of nodes representing firmware interface, it's sub-nodes\n> are not populated during system initialization.\n>\n> Currently different firmware drivers search the /firmware/ node and\n> populate the sub-node devices selectively. Instead we can populate\n> the /firmware/ node during init to avoid more drivers continuing to\n> populate the devices selectively.\n>\n> To generalize the solution this patch populates the /firmware/ node\n> explicitly from of_platform_default_populate_init().\n>\n> Cc: Arnd Bergmann \n> Cc: Rob Herring \n\nAcked-by: Bjorn Andersson \nTested-by: Bjorn Andersson \n\n> Signed-off-by: Sudeep Holla \n> ---\n\nAndy, as you picked patch 2/4 into your v4.16 -next branch we no\nlonger probe the qcom_scm device, causing various breakage. Can you\nplease pick this patch as well (it has Rob's ack).\n\nRegards,\nBjorn\n\n> drivers/of/platform.c | 4 ++++\n> 1 file changed, 4 insertions(+)\n>\n> diff --git a/drivers/of/platform.c b/drivers/of/platform.c\n> index ac15d0e3d27d..3a213a6aee89 100644\n> --- a/drivers/of/platform.c\n> +++ b/drivers/of/platform.c\n> @@ -515,6 +515,10 @@ static int __init of_platform_default_populate_init(void)\n> of_platform_device_create(node, NULL, NULL);\n> }\n>\n> + node = of_find_node_by_path(\"/firmware\");\n> + if (node)\n> + of_platform_populate(node, NULL, NULL, NULL);\n> +\n> /* Populate everything else. */\n> of_platform_default_populate(NULL, NULL, NULL);\n>\n> --\n> 2.7.4\n>\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"jjQ0XJEc\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3z5pv40jS9z9s72\n\tfor ;\n\tWed, 27 Dec 2017 08:26:08 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751219AbdLZV0F (ORCPT\n\t);\n\tTue, 26 Dec 2017 16:26:05 -0500","from mail-pl0-f65.google.com ([209.85.160.65]:32868 \"EHLO\n\tmail-pl0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750822AbdLZV0F (ORCPT\n\t); Tue, 26 Dec 2017 16:26:05 -0500","by mail-pl0-f65.google.com with SMTP id 1so16966078plv.0\n\tfor ;\n\tTue, 26 Dec 2017 13:26:04 -0800 (PST)","by 10.100.241.8 with HTTP; Tue, 26 Dec 2017 13:26:04 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=kvQK+EOwrgzcqXGDMBY2Z38hGUPaGIxp7jtRCkFbxnI=;\n\tb=jjQ0XJEcrs+5xuSncwazTkq2bTH+N8UdVoC8qexG4m6a31VSmAjEWwsGLE78O5zpTv\n\tSDRIdgVOOKfQJ4Qrb/BSZKoI/0aUSGXiFF+crD9UMPb6u7h6vFU/reU0lo2LQbweid3G\n\tCLuXFOcp1eBeUYXRvN2PiSmdlT+/CIGc9cWV0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=kvQK+EOwrgzcqXGDMBY2Z38hGUPaGIxp7jtRCkFbxnI=;\n\tb=QQi+5uv5rqQHGnEB6wfSyrKgx6ld3YohHT5YStyzz026hxeV+Hxw637VJomdMfdO0D\n\tmMqGKWKIGlk8f3kiO9kqH8KNJohOBKNyTUOTPWhX04bHuiLwXG4hwRVuGoIzRCHUrM50\n\tf7B1whpNeXX5UrtV6lN0OlVkg7gmmH3/jqN6uwjBmXvYZkRd39JdbUDHE3qnzt54ItLR\n\tJURNZaPT/7GI2UecunVEw4+mT6EqJplgZsQi3X73uRwRVY5hXTV6hazehcVAQyx8TkSV\n\tKPVpKIfa7lHesFjAfHI5T36fzVbFHHpPfpM7FZiy7WmfmWhrq1UtDwRoRzrQbdHv1ZDD\n\t6F0A==","X-Gm-Message-State":"AKGB3mKToJsJ3CjSJ0EhSnZhoCagcjECtSw3JumUoi2VA8/MCjXog4rd\n\tpyjQHMby6GfZvmsP8Xk6KLitoUcdI0/lclBkojkCoQ==","X-Google-Smtp-Source":"ACJfBou9VT2dRc1fMk3IUaJyNpPmqCvci4fUiiEdP1mhZgx0RXA46iPuB0nCR9r3epXWobrNd8/ro9LzhsFjXpPjmQA=","X-Received":"by 10.84.212.151 with SMTP id e23mr26783679pli.449.1514323564551;\n\tTue, 26 Dec 2017 13:26:04 -0800 (PST)","MIME-Version":"1.0","In-Reply-To":"<1506595562-10592-2-git-send-email-sudeep.holla@arm.com>","References":"<1506595562-10592-1-git-send-email-sudeep.holla@arm.com>\n\t<1506595562-10592-2-git-send-email-sudeep.holla@arm.com>","From":"Bjorn Andersson ","Date":"Tue, 26 Dec 2017 13:26:04 -0800","Message-ID":"","Subject":"Re: [RESEND][PATCH 1/4] of: platform: populate /firmware/ node from\n\tof_platform_default_populate_init()","To":"Sudeep Holla , Andy Gross ","Cc":"LAKML ,\n\tlkml ,\n\tdevicetree ,\n\tRob Herring , \n\tArnd Bergmann , Rob Herring ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]