[{"id":1777089,"web_url":"http://patchwork.ozlabs.org/comment/1777089/","msgid":"<20170928151103.ov3o5pn5h7inzzan@flea>","list_archive_url":null,"date":"2017-09-28T15:11:03","subject":"Re: [PATCH v2 1/3] ARM: dts: sun8i: Add basic dtsi file for\n\tAllwinner R40","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"Hi,\n\nOn Thu, Sep 28, 2017 at 09:25:41AM +0000, Icenowy Zheng wrote:\n> +\t\t/*\n> +\t\t * The max-frequency properties in all MMC controller nodes\n> +\t\t * are conservative values proven to work on Banana Pi M2\n> +\t\t * Ultra (the first community available R40 board).\n> +\t\t * As the board doesn't wire MMC3 out, the property is not\n> +\t\t * set in MMC3.\n> +\t\t * TODO: measure the accurate max frequency of the controllers.\n> +\t\t */\n> +\t\tmmc0: mmc@1c0f000 {\n> +\t\t\tcompatible = \"allwinner,sun8i-r40-mmc\",\n> +\t\t\t\t \"allwinner,sun50i-a64-mmc\";\n> +\t\t\treg = <0x01c0f000 0x1000>;\n> +\t\t\tclocks = <&ccu CLK_BUS_MMC0>, <&ccu CLK_MMC0>;\n> +\t\t\tclock-names = \"ahb\", \"mmc\";\n> +\t\t\tresets = <&ccu RST_BUS_MMC0>;\n> +\t\t\treset-names = \"ahb\";\n> +\t\t\tpinctrl-0 = <&mmc0_pins>;\n> +\t\t\tpinctrl-names = \"default\";\n> +\t\t\tinterrupts = ;\n> +\t\t\tmax-frequency = <25000000>;\n> +\t\t\tstatus = \"disabled\";\n> +\t\t\t#address-cells = <1>;\n> +\t\t\t#size-cells = <0>;\n> +\t\t};\n\nSorry if it wasn't really clear, but my point was more than you should\njust drop the max-frequency property\n\nMaxime","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2ynw3FbTz9tX5\n\tfor ;\n\tFri, 29 Sep 2017 01:11:32 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753256AbdI1PLS (ORCPT\n\t);\n\tThu, 28 Sep 2017 11:11:18 -0400","from mail.free-electrons.com ([62.4.15.54]:49439 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753341AbdI1PLP (ORCPT\n\t); Thu, 28 Sep 2017 11:11:15 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid E93EB2085D; Thu, 28 Sep 2017 17:11:12 +0200 (CEST)","from localhost (unknown [195.81.232.10])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id BA043208CD;\n\tThu, 28 Sep 2017 17:11:02 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Thu, 28 Sep 2017 17:11:03 +0200","From":"Maxime Ripard ","To":"Icenowy Zheng ","Cc":"Chen-Yu Tsai , devicetree@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com","Subject":"Re: [PATCH v2 1/3] ARM: dts: sun8i: Add basic dtsi file for\n\tAllwinner R40","Message-ID":"<20170928151103.ov3o5pn5h7inzzan@flea>","References":"<20170928092543.45648-1-icenowy@aosc.io>\n\t<20170928092543.45648-2-icenowy@aosc.io>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"i2udpxaukzgohm6x\"","Content-Disposition":"inline","In-Reply-To":"<20170928092543.45648-2-icenowy@aosc.io>","User-Agent":"NeoMutt/20170914 (1.9.0)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1777093,"web_url":"http://patchwork.ozlabs.org/comment/1777093/","msgid":"<20170928151225.n4pyvn65u6hvpjd7@flea>","list_archive_url":null,"date":"2017-09-28T15:12:25","subject":"Re: [PATCH v2 2/3] ARM: dts: sun8i: Add board dts file for Banana Pi\n\tM2 Ultra","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"On Thu, Sep 28, 2017 at 09:25:42AM +0000, Icenowy Zheng wrote:\n> +&mmc2 {\n> +\tvmmc-supply = <®_dcdc1>;\n> +\tbus-width = <8>;\n> +\tnon-removable;\n> +\tstatus = \"okay\";\n> +};\n\nI guess it's an emmc, it doesn't have a vqmmmc regulator?\n\nLooks good otherwise, thanks!\nMaxime","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2yqB2K8Zz9tX5\n\tfor ;\n\tFri, 29 Sep 2017 01:12:38 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752130AbdI1PMg (ORCPT\n\t);\n\tThu, 28 Sep 2017 11:12:36 -0400","from mail.free-electrons.com ([62.4.15.54]:49518 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751918AbdI1PMg (ORCPT\n\t); Thu, 28 Sep 2017 11:12:36 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 661C9208C5; Thu, 28 Sep 2017 17:12:34 +0200 (CEST)","from localhost (unknown [195.81.232.10])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 4034D207F0;\n\tThu, 28 Sep 2017 17:12:24 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Thu, 28 Sep 2017 17:12:25 +0200","From":"Maxime Ripard ","To":"Icenowy Zheng ","Cc":"Chen-Yu Tsai , devicetree@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com","Subject":"Re: [PATCH v2 2/3] ARM: dts: sun8i: Add board dts file for Banana Pi\n\tM2 Ultra","Message-ID":"<20170928151225.n4pyvn65u6hvpjd7@flea>","References":"<20170928092543.45648-1-icenowy@aosc.io>\n\t<20170928092543.45648-3-icenowy@aosc.io>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"nwsewxqzqtqs36nv\"","Content-Disposition":"inline","In-Reply-To":"<20170928092543.45648-3-icenowy@aosc.io>","User-Agent":"NeoMutt/20170914 (1.9.0)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1777109,"web_url":"http://patchwork.ozlabs.org/comment/1777109/","msgid":"","list_archive_url":null,"date":"2017-09-28T15:38:59","subject":"Re: [PATCH v2 2/3] ARM: dts: sun8i: Add board dts file for Banana Pi\n\tM2 Ultra","submitter":{"id":71295,"url":"http://patchwork.ozlabs.org/api/people/71295/","name":"Icenowy Zheng","email":"icenowy@aosc.io"},"content":"于 2017年9月28日 GMT+08:00 下午11:12:25, Maxime Ripard 写到:\n>On Thu, Sep 28, 2017 at 09:25:42AM +0000, Icenowy Zheng wrote:\n>> +&mmc2 {\n>> +\tvmmc-supply = <®_dcdc1>;\n>> +\tbus-width = <8>;\n>> +\tnon-removable;\n>> +\tstatus = \"okay\";\n>> +};\n>\n>I guess it's an emmc, it doesn't have a vqmmmc regulator?\n\nvqmmc is also 3v3.\n\n>\n>Looks good otherwise, thanks!\n>Maxime\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2zPs5ZQ4z9tXd\n\tfor ;\n\tFri, 29 Sep 2017 01:39:13 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932150AbdI1PjM convert rfc822-to-8bit (ORCPT\n\t);\n\tThu, 28 Sep 2017 11:39:12 -0400","from hermes.aosc.io ([199.195.250.187]:33787 \"EHLO hermes.aosc.io\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S932092AbdI1PjL (ORCPT );\n\tThu, 28 Sep 2017 11:39:11 -0400","from localhost (localhost [127.0.0.1]) (Authenticated sender:\n\ticenowy@aosc.io)\n\tby hermes.aosc.io (Postfix) with ESMTPSA id B634D48649;\n\tThu, 28 Sep 2017 15:39:05 +0000 (UTC)"],"Date":"Thu, 28 Sep 2017 23:38:59 +0800","In-Reply-To":"<20170928151225.n4pyvn65u6hvpjd7@flea>","References":"<20170928092543.45648-1-icenowy@aosc.io>\n\t<20170928092543.45648-3-icenowy@aosc.io>\n\t<20170928151225.n4pyvn65u6hvpjd7@flea>","MIME-Version":"1.0","Content-Type":"text/plain;\n charset=utf-8","Content-Transfer-Encoding":"8BIT","Subject":"Re: [PATCH v2 2/3] ARM: dts: sun8i: Add board dts file for Banana Pi\n\tM2 Ultra","To":"linux-arm-kernel@lists.infradead.org,\n\tMaxime Ripard ","CC":"devicetree@vger.kernel.org, Chen-Yu Tsai ,\n\tlinux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org","From":"Icenowy Zheng ","Message-ID":"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1777455,"web_url":"http://patchwork.ozlabs.org/comment/1777455/","msgid":"<20170929101740.reahjw7wjaspwjld@flea>","list_archive_url":null,"date":"2017-09-29T10:17:40","subject":"Re: [PATCH v2 2/3] ARM: dts: sun8i: Add board dts file for Banana Pi\n\tM2 Ultra","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"On Thu, Sep 28, 2017 at 03:38:59PM +0000, Icenowy Zheng wrote:\n> \n> \n> 于 2017年9月28日 GMT+08:00 下午11:12:25, Maxime Ripard 写到:\n> >On Thu, Sep 28, 2017 at 09:25:42AM +0000, Icenowy Zheng wrote:\n> >> +&mmc2 {\n> >> +\tvmmc-supply = <®_dcdc1>;\n> >> +\tbus-width = <8>;\n> >> +\tnon-removable;\n> >> +\tstatus = \"okay\";\n> >> +};\n> >\n> >I guess it's an emmc, it doesn't have a vqmmmc regulator?\n> \n> vqmmc is also 3v3.\n\nYou should still put it.\n\nThanks!\nMaxime","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y3SDS03Wyz9t2V\n\tfor ;\n\tFri, 29 Sep 2017 20:17:44 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752155AbdI2KRm (ORCPT\n\t);\n\tFri, 29 Sep 2017 06:17:42 -0400","from mail.free-electrons.com ([62.4.15.54]:45494 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752130AbdI2KRl (ORCPT\n\t); Fri, 29 Sep 2017 06:17:41 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid A20CC20978; Fri, 29 Sep 2017 12:17:39 +0200 (CEST)","from localhost (unknown [195.81.232.10])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 8102120927;\n\tFri, 29 Sep 2017 12:17:39 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT\n\tshortcircuit=ham autolearn=disabled version=3.4.0","Date":"Fri, 29 Sep 2017 12:17:40 +0200","From":"Maxime Ripard ","To":"Icenowy Zheng ","Cc":"linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,\n\tChen-Yu Tsai , linux-sunxi@googlegroups.com,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH v2 2/3] ARM: dts: sun8i: Add board dts file for Banana Pi\n\tM2 Ultra","Message-ID":"<20170929101740.reahjw7wjaspwjld@flea>","References":"<20170928092543.45648-1-icenowy@aosc.io>\n\t<20170928092543.45648-3-icenowy@aosc.io>\n\t<20170928151225.n4pyvn65u6hvpjd7@flea>\n\t","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"3l4qncgm5xe7fica\"","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20170914 (1.9.0)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1777466,"web_url":"http://patchwork.ozlabs.org/comment/1777466/","msgid":"<7F10060D-6A37-4417-9E24-1BB007580126@aosc.io>","list_archive_url":null,"date":"2017-09-29T10:25:15","subject":"Re: [PATCH v2 1/3] ARM: dts: sun8i: Add basic dtsi file for\n\tAllwinner R40","submitter":{"id":71295,"url":"http://patchwork.ozlabs.org/api/people/71295/","name":"Icenowy Zheng","email":"icenowy@aosc.io"},"content":"于 2017年9月28日 GMT+08:00 下午11:11:03, Maxime Ripard 写到:\n>Hi,\n>\n>On Thu, Sep 28, 2017 at 09:25:41AM +0000, Icenowy Zheng wrote:\n>> +\t\t/*\n>> +\t\t * The max-frequency properties in all MMC controller nodes\n>> +\t\t * are conservative values proven to work on Banana Pi M2\n>> +\t\t * Ultra (the first community available R40 board).\n>> +\t\t * As the board doesn't wire MMC3 out, the property is not\n>> +\t\t * set in MMC3.\n>> +\t\t * TODO: measure the accurate max frequency of the controllers.\n>> +\t\t */\n>> +\t\tmmc0: mmc@1c0f000 {\n>> +\t\t\tcompatible = \"allwinner,sun8i-r40-mmc\",\n>> +\t\t\t\t \"allwinner,sun50i-a64-mmc\";\n>> +\t\t\treg = <0x01c0f000 0x1000>;\n>> +\t\t\tclocks = <&ccu CLK_BUS_MMC0>, <&ccu CLK_MMC0>;\n>> +\t\t\tclock-names = \"ahb\", \"mmc\";\n>> +\t\t\tresets = <&ccu RST_BUS_MMC0>;\n>> +\t\t\treset-names = \"ahb\";\n>> +\t\t\tpinctrl-0 = <&mmc0_pins>;\n>> +\t\t\tpinctrl-names = \"default\";\n>> +\t\t\tinterrupts = ;\n>> +\t\t\tmax-frequency = <25000000>;\n>> +\t\t\tstatus = \"disabled\";\n>> +\t\t\t#address-cells = <1>;\n>> +\t\t\t#size-cells = <0>;\n>> +\t\t};\n>\n>Sorry if it wasn't really clear, but my point was more than you should\n>just drop the max-frequency property\n\nThen set it in the boards' DTS?\n\n>\n>Maxime\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y3SPR3vn6z9t2V\n\tfor ;\n\tFri, 29 Sep 2017 20:25:31 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751813AbdI2KZ2 convert rfc822-to-8bit (ORCPT\n\t);\n\tFri, 29 Sep 2017 06:25:28 -0400","from hermes.aosc.io ([199.195.250.187]:34069 \"EHLO hermes.aosc.io\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750927AbdI2KZ2 (ORCPT );\n\tFri, 29 Sep 2017 06:25:28 -0400","from localhost (localhost [127.0.0.1]) (Authenticated sender:\n\ticenowy@aosc.io)\n\tby hermes.aosc.io (Postfix) with ESMTPSA id 215BD48904;\n\tFri, 29 Sep 2017 10:25:20 +0000 (UTC)"],"Date":"Fri, 29 Sep 2017 18:25:15 +0800","In-Reply-To":"<20170928151103.ov3o5pn5h7inzzan@flea>","References":"<20170928092543.45648-1-icenowy@aosc.io>\n\t<20170928092543.45648-2-icenowy@aosc.io>\n\t<20170928151103.ov3o5pn5h7inzzan@flea>","MIME-Version":"1.0","Content-Type":"text/plain;\n charset=utf-8","Content-Transfer-Encoding":"8BIT","Subject":"Re: [PATCH v2 1/3] ARM: dts: sun8i: Add basic dtsi file for\n\tAllwinner R40","To":"Maxime Ripard ","CC":"Chen-Yu Tsai , devicetree@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com","From":"Icenowy Zheng ","Message-ID":"<7F10060D-6A37-4417-9E24-1BB007580126@aosc.io>","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1777472,"web_url":"http://patchwork.ozlabs.org/comment/1777472/","msgid":"","list_archive_url":null,"date":"2017-09-29T10:31:53","subject":"Re: [linux-sunxi] Re: [PATCH v2 1/3] ARM: dts: sun8i: Add basic dtsi\n\tfile for Allwinner R40","submitter":{"id":47154,"url":"http://patchwork.ozlabs.org/api/people/47154/","name":"Chen-Yu Tsai","email":"wens@csie.org"},"content":"On Fri, Sep 29, 2017 at 6:25 PM, Icenowy Zheng wrote:\n>\n>\n> 于 2017年9月28日 GMT+08:00 下午11:11:03, Maxime Ripard 写到:\n>>Hi,\n>>\n>>On Thu, Sep 28, 2017 at 09:25:41AM +0000, Icenowy Zheng wrote:\n>>> + /*\n>>> + * The max-frequency properties in all MMC controller nodes\n>>> + * are conservative values proven to work on Banana Pi M2\n>>> + * Ultra (the first community available R40 board).\n>>> + * As the board doesn't wire MMC3 out, the property is not\n>>> + * set in MMC3.\n>>> + * TODO: measure the accurate max frequency of the controllers.\n>>> + */\n>>> + mmc0: mmc@1c0f000 {\n>>> + compatible = \"allwinner,sun8i-r40-mmc\",\n>>> + \"allwinner,sun50i-a64-mmc\";\n>>> + reg = <0x01c0f000 0x1000>;\n>>> + clocks = <&ccu CLK_BUS_MMC0>, <&ccu CLK_MMC0>;\n>>> + clock-names = \"ahb\", \"mmc\";\n>>> + resets = <&ccu RST_BUS_MMC0>;\n>>> + reset-names = \"ahb\";\n>>> + pinctrl-0 = <&mmc0_pins>;\n>>> + pinctrl-names = \"default\";\n>>> + interrupts = ;\n>>> + max-frequency = <25000000>;\n>>> + status = \"disabled\";\n>>> + #address-cells = <1>;\n>>> + #size-cells = <0>;\n>>> + };\n>>\n>>Sorry if it wasn't really clear, but my point was more than you should\n>>just drop the max-frequency property\n>\n> Then set it in the boards' DTS?\n\nWhy do you need to set them in the first place? The higher speeds need\nvoltage control, and the lack of said control means the system won't\nuse them anyway.\n\nmax-frequency would apply better in situations where the board layout\ncan't guarantee proper signal propagation or timing beyond a certain\nfrequency. Or if that particular controller instance is flawed or\nrestricted in some way.\n\n\nChenYu\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y3SYJ6l24z9t2Z\n\tfor ;\n\tFri, 29 Sep 2017 20:32:20 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751994AbdI2KcT convert rfc822-to-8bit (ORCPT\n\t);\n\tFri, 29 Sep 2017 06:32:19 -0400","from smtp.csie.ntu.edu.tw ([140.112.30.61]:41284 \"EHLO\n\tsmtp.csie.ntu.edu.tw\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751852AbdI2KcS (ORCPT\n\t); Fri, 29 Sep 2017 06:32:18 -0400","from mail-wm0-f46.google.com (mail-wm0-f46.google.com\n\t[74.125.82.46])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: b93043)\n\tby smtp.csie.ntu.edu.tw (Postfix) with ESMTPSA id 7A70F20459;\n\tFri, 29 Sep 2017 18:32:16 +0800 (CST)","by mail-wm0-f46.google.com with SMTP id r74so2479139wme.4;\n\tFri, 29 Sep 2017 03:32:16 -0700 (PDT)","by 10.223.176.172 with HTTP; Fri, 29 Sep 2017 03:31:53 -0700 (PDT)"],"X-Gm-Message-State":"AMCzsaXrpEIeWAVDu0gz8ibLlz6O1GSySxEnjvv4wIRxybQAblDuw4ZQ\n\tPgKGRo6yvBJ4tIc/al39LHLsn29t1nQBdKEpW7w=","X-Google-Smtp-Source":"AOwi7QA279wpLODBu1e7f4JYb+esDAGOsUjqqIj1poQ+9SuyHrGFcL+8g1T2ifnKMtPkFNVYDB00GAfETGOBHCgK6J0=","X-Received":"by 10.28.64.212 with SMTP id n203mr1614636wma.15.1506681133650; \n\tFri, 29 Sep 2017 03:32:13 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<7F10060D-6A37-4417-9E24-1BB007580126@aosc.io>","References":"<20170928092543.45648-1-icenowy@aosc.io>\n\t<20170928092543.45648-2-icenowy@aosc.io>\n\t<20170928151103.ov3o5pn5h7inzzan@flea>\n\t<7F10060D-6A37-4417-9E24-1BB007580126@aosc.io>","From":"Chen-Yu Tsai ","Date":"Fri, 29 Sep 2017 18:31:53 +0800","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [linux-sunxi] Re: [PATCH v2 1/3] ARM: dts: sun8i: Add basic dtsi\n\tfile for Allwinner R40","To":"Icenowy Zheng ","Cc":"Maxime Ripard ,\n\tChen-Yu Tsai , devicetree ,\n\tlinux-arm-kernel ,\n\tlinux-kernel ,\n\tlinux-sunxi ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"8BIT","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]