[{"id":1777291,"web_url":"http://patchwork.ozlabs.org/comment/1777291/","msgid":"<20170928212543.sltvd4rgswfowtcd@valkosipuli.retiisi.org.uk>","list_archive_url":null,"date":"2017-09-28T21:25:43","subject":"Re: [PATCH v3 3/5] media: atmel-isc: Enable the clocks during probe","submitter":{"id":1593,"url":"http://patchwork.ozlabs.org/api/people/1593/","name":"Sakari Ailus","email":"sakari.ailus@iki.fi"},"content":"Hi Wenyou,\n\nOn Thu, Sep 28, 2017 at 04:18:26PM +0800, Wenyou Yang wrote:\n> To meet the relationship, enable the HCLOCK and ispck during the\n> device probe, \"isc_pck frequency is less than or equal to isc_ispck,\n> and isc_ispck is greater than or equal to HCLOCK.\"\n> Meanwhile, call the pm_runtime_enable() in the right place.\n> \n> Signed-off-by: Wenyou Yang \n> ---\n> \n> Changes in v3: None\n> Changes in v2: None\n> \n> drivers/media/platform/atmel/atmel-isc.c | 31 +++++++++++++++++++++++++------\n> 1 file changed, 25 insertions(+), 6 deletions(-)\n> \n> diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c\n> index 0b15dc1a3a0b..f092c95587c1 100644\n> --- a/drivers/media/platform/atmel/atmel-isc.c\n> +++ b/drivers/media/platform/atmel/atmel-isc.c\n> @@ -1594,6 +1594,7 @@ static int isc_async_complete(struct v4l2_async_notifier *notifier)\n> \tstruct isc_subdev_entity *sd_entity;\n> \tstruct video_device *vdev = &isc->video_dev;\n> \tstruct vb2_queue *q = &isc->vb2_vidq;\n> +\tstruct device *dev = isc->dev;\n> \tint ret;\n> \n> \tret = v4l2_device_register_subdev_nodes(&isc->v4l2_dev);\n> @@ -1677,6 +1678,10 @@ static int isc_async_complete(struct v4l2_async_notifier *notifier)\n> \t\treturn ret;\n> \t}\n> \n> +\tpm_runtime_set_active(dev);\n> +\tpm_runtime_enable(dev);\n> +\tpm_request_idle(dev);\n\nRemember that the driver's async complete function could never get called.\n\nWhat would be the reason to move it here?\n\n> +\n> \treturn 0;\n> }\n> \n> @@ -1856,25 +1861,37 @@ static int atmel_isc_probe(struct platform_device *pdev)\n> \t\treturn ret;\n> \t}\n> \n> +\tret = clk_prepare_enable(isc->hclock);\n> +\tif (ret) {\n> +\t\tdev_err(dev, \"failed to enable hclock: %d\\n\", ret);\n> +\t\treturn ret;\n> +\t}\n> +\n> \tret = isc_clk_init(isc);\n> \tif (ret) {\n> \t\tdev_err(dev, \"failed to init isc clock: %d\\n\", ret);\n> -\t\tgoto clean_isc_clk;\n> +\t\tgoto unprepare_hclk;\n> \t}\n> \n> \tisc->ispck = isc->isc_clks[ISC_ISPCK].clk;\n> \n> +\tret = clk_prepare_enable(isc->ispck);\n> +\tif (ret) {\n> +\t\tdev_err(dev, \"failed to enable ispck: %d\\n\", ret);\n> +\t\tgoto unprepare_hclk;\n> +\t}\n> +\n> \t/* ispck should be greater or equal to hclock */\n> \tret = clk_set_rate(isc->ispck, clk_get_rate(isc->hclock));\n> \tif (ret) {\n> \t\tdev_err(dev, \"failed to set ispck rate: %d\\n\", ret);\n> -\t\tgoto clean_isc_clk;\n> +\t\tgoto unprepare_clk;\n> \t}\n> \n> \tret = v4l2_device_register(dev, &isc->v4l2_dev);\n> \tif (ret) {\n> \t\tdev_err(dev, \"unable to register v4l2 device.\\n\");\n> -\t\tgoto clean_isc_clk;\n> +\t\tgoto unprepare_clk;\n> \t}\n> \n> \tret = isc_parse_dt(dev, isc);\n> @@ -1907,8 +1924,6 @@ static int atmel_isc_probe(struct platform_device *pdev)\n> \t\t\tbreak;\n> \t}\n> \n> -\tpm_runtime_enable(dev);\n> -\n> \treturn 0;\n> \n> cleanup_subdev:\n> @@ -1917,7 +1932,11 @@ static int atmel_isc_probe(struct platform_device *pdev)\n> unregister_v4l2_device:\n> \tv4l2_device_unregister(&isc->v4l2_dev);\n> \n> -clean_isc_clk:\n> +unprepare_clk:\n> +\tclk_disable_unprepare(isc->ispck);\n> +unprepare_hclk:\n> +\tclk_disable_unprepare(isc->hclock);\n\nI think you're missing clk_disable_unprepare() in the driver's remove\ncallback.\n\n> +\n> \tisc_clk_cleanup(isc);\n> \n> \treturn ret;","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"hMj+Ue9A\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y376K3pByz9t5g\n\tfor ;\n\tFri, 29 Sep 2017 07:26:17 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dxgJy-00029o-1A; Thu, 28 Sep 2017 21:26:14 +0000","from nblzone-211-213.nblnetworks.fi ([83.145.211.213]\n\thelo=hillosipuli.retiisi.org.uk)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dxgJt-000250-FT for linux-arm-kernel@lists.infradead.org;\n\tThu, 28 Sep 2017 21:26:11 +0000","from valkosipuli.localdomain (valkosipuli.retiisi.org.uk\n\t[IPv6:2001:1bc8:1a6:d3d5::80:2])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id B23A6600DF;\n\tFri, 29 Sep 2017 00:25:44 +0300 (EEST)","from sakke by valkosipuli.localdomain with local (Exim 4.89)\n\t(envelope-from )\n\tid 1dxgJU-0007ux-7f; Fri, 29 Sep 2017 00:25:44 +0300"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=JRLoo0GjS47a51/7DW7wGhJEPsL/uGpu+wTj399aeXg=;\n\tb=hMj+Ue9AHi+bOd\n\ttYjDabWZP2EszuNgVFbX7rtTH3mHxQIDxAAfKJh+HAtW+MSbwWasfdyEmQp3lgi0COgxvzZKj2oki\n\tOsp8/rO81F3dF215RHOOQdY8C+uPwfkeT0e28sCOdHYwwELNy7U1kpYXNd/tEJGLlHxyFhnnd5B+l\n\tj9UwKOMxTydp0MnbhD5CERL5vposz03w7PB8CdhtTdH4/Qk5hGZhv1rIxLaeJwX4IhZSj6SBsV8ey\n\tP001aIfWynsp2kYLnrMuhYQLPx0jLwkRFzVpJwnxipoKhYqQ/mwRUNGU2rkVQjaI51gyfUeCYjJEH\n\thojq3HUH/E2wrYPMuhfw==;","Date":"Fri, 29 Sep 2017 00:25:43 +0300","From":"Sakari Ailus ","To":"Wenyou Yang ","Subject":"Re: [PATCH v3 3/5] media: atmel-isc: Enable the clocks during probe","Message-ID":"<20170928212543.sltvd4rgswfowtcd@valkosipuli.retiisi.org.uk>","References":"<20170928081828.20335-1-wenyou.yang@microchip.com>\n\t<20170928081828.20335-4-wenyou.yang@microchip.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170928081828.20335-4-wenyou.yang@microchip.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170928_142609_957768_2B46198B ","X-CRM114-Status":"GOOD ( 16.68 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [83.145.211.213 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level\n\tmail domains are different\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Hans Verkuil , Jonathan Corbet ,\n\tlinux-kernel@vger.kernel.org,\n\tMauro Carvalho Chehab , \n\tlinux-arm-kernel@lists.infradead.org,\n\tLinux Media Mailing List ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1782505,"web_url":"http://patchwork.ozlabs.org/comment/1782505/","msgid":"<7d5bd4ff-f18e-5f0d-9ce1-3f5169be4c14@Microchip.com>","list_archive_url":null,"date":"2017-10-09T05:49:44","subject":"Re: [PATCH v3 3/5] media: atmel-isc: Enable the clocks during probe","submitter":{"id":69532,"url":"http://patchwork.ozlabs.org/api/people/69532/","name":"Wenyou Yang","email":"Wenyou.Yang@microchip.com"},"content":"Hi Sakari,\n\nSorry for late answer, because I was in vacation last week.\n\nOn 2017/9/29 5:25, Sakari Ailus wrote:\n> Hi Wenyou,\n>\n> On Thu, Sep 28, 2017 at 04:18:26PM +0800, Wenyou Yang wrote:\n>> To meet the relationship, enable the HCLOCK and ispck during the\n>> device probe, \"isc_pck frequency is less than or equal to isc_ispck,\n>> and isc_ispck is greater than or equal to HCLOCK.\"\n>> Meanwhile, call the pm_runtime_enable() in the right place.\n>>\n>> Signed-off-by: Wenyou Yang \n>> ---\n>>\n>> Changes in v3: None\n>> Changes in v2: None\n>>\n>> drivers/media/platform/atmel/atmel-isc.c | 31 +++++++++++++++++++++++++------\n>> 1 file changed, 25 insertions(+), 6 deletions(-)\n>>\n>> diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c\n>> index 0b15dc1a3a0b..f092c95587c1 100644\n>> --- a/drivers/media/platform/atmel/atmel-isc.c\n>> +++ b/drivers/media/platform/atmel/atmel-isc.c\n>> @@ -1594,6 +1594,7 @@ static int isc_async_complete(struct v4l2_async_notifier *notifier)\n>> \tstruct isc_subdev_entity *sd_entity;\n>> \tstruct video_device *vdev = &isc->video_dev;\n>> \tstruct vb2_queue *q = &isc->vb2_vidq;\n>> +\tstruct device *dev = isc->dev;\n>> \tint ret;\n>> \n>> \tret = v4l2_device_register_subdev_nodes(&isc->v4l2_dev);\n>> @@ -1677,6 +1678,10 @@ static int isc_async_complete(struct v4l2_async_notifier *notifier)\n>> \t\treturn ret;\n>> \t}\n>> \n>> +\tpm_runtime_set_active(dev);\n>> +\tpm_runtime_enable(dev);\n>> +\tpm_request_idle(dev);\n> Remember that the driver's async complete function could never get called.\n>\n> What would be the reason to move it here?\nThe ISC provides the clock for the sensor, namely, it is the clock \nprovider for the external sensor.\nSo it keeps active to make the sensor probe successfully.\nOtherwise, the sensor, such as 0v7670 fails to probe due to the failure \nto clk_enable().\n>\n>> +\n>> \treturn 0;\n>> }\n>> \n>> @@ -1856,25 +1861,37 @@ static int atmel_isc_probe(struct platform_device *pdev)\n>> \t\treturn ret;\n>> \t}\n>> \n>> +\tret = clk_prepare_enable(isc->hclock);\n>> +\tif (ret) {\n>> +\t\tdev_err(dev, \"failed to enable hclock: %d\\n\", ret);\n>> +\t\treturn ret;\n>> +\t}\n>> +\n>> \tret = isc_clk_init(isc);\n>> \tif (ret) {\n>> \t\tdev_err(dev, \"failed to init isc clock: %d\\n\", ret);\n>> -\t\tgoto clean_isc_clk;\n>> +\t\tgoto unprepare_hclk;\n>> \t}\n>> \n>> \tisc->ispck = isc->isc_clks[ISC_ISPCK].clk;\n>> \n>> +\tret = clk_prepare_enable(isc->ispck);\n>> +\tif (ret) {\n>> +\t\tdev_err(dev, \"failed to enable ispck: %d\\n\", ret);\n>> +\t\tgoto unprepare_hclk;\n>> +\t}\n>> +\n>> \t/* ispck should be greater or equal to hclock */\n>> \tret = clk_set_rate(isc->ispck, clk_get_rate(isc->hclock));\n>> \tif (ret) {\n>> \t\tdev_err(dev, \"failed to set ispck rate: %d\\n\", ret);\n>> -\t\tgoto clean_isc_clk;\n>> +\t\tgoto unprepare_clk;\n>> \t}\n>> \n>> \tret = v4l2_device_register(dev, &isc->v4l2_dev);\n>> \tif (ret) {\n>> \t\tdev_err(dev, \"unable to register v4l2 device.\\n\");\n>> -\t\tgoto clean_isc_clk;\n>> +\t\tgoto unprepare_clk;\n>> \t}\n>> \n>> \tret = isc_parse_dt(dev, isc);\n>> @@ -1907,8 +1924,6 @@ static int atmel_isc_probe(struct platform_device *pdev)\n>> \t\t\tbreak;\n>> \t}\n>> \n>> -\tpm_runtime_enable(dev);\n>> -\n>> \treturn 0;\n>> \n>> cleanup_subdev:\n>> @@ -1917,7 +1932,11 @@ static int atmel_isc_probe(struct platform_device *pdev)\n>> unregister_v4l2_device:\n>> \tv4l2_device_unregister(&isc->v4l2_dev);\n>> \n>> -clean_isc_clk:\n>> +unprepare_clk:\n>> +\tclk_disable_unprepare(isc->ispck);\n>> +unprepare_hclk:\n>> +\tclk_disable_unprepare(isc->hclock);\n> I think you're missing clk_disable_unprepare() in the driver's remove\n> callback.\nWill add in next version.\n>\n>> +\n>> \tisc_clk_cleanup(isc);\n>> \n>> \treturn ret;\n\nBest Regards,\nWenyou Yang","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"O8lHHc3M\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y9TqN1by5z9tXv\n\tfor ;\n\tMon, 9 Oct 2017 16:50:24 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e1QxG-0006RG-Rk; Mon, 09 Oct 2017 05:50:18 +0000","from esa2.microchip.iphmx.com ([68.232.149.84])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e1QxA-00056m-AS for linux-arm-kernel@lists.infradead.org;\n\tMon, 09 Oct 2017 05:50:14 +0000","from exsmtp03.microchip.com (HELO email.microchip.com)\n\t([198.175.253.49])\n\tby esa2.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t08 Oct 2017 22:49:51 -0700","from [10.160.137.105] (10.10.76.4) by chn-sv-exch03.mchp-main.com\n\t(10.10.76.49) with Microsoft SMTP Server id 14.3.352.0;\n\tSun, 8 Oct 2017 22:49:50 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:\n\tReferences:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=L1CbzWzn8XaEbrieiNq9tGgyZYifPm0+UYdlqRtPamk=;\n\tb=O8lHHc3MbnhsP73vKIS8r6mxR\n\t+Q+FTVnTXJo/lDHUlsXhB3/XUykYl2B5az8Q0tts9BCptBZa1kjSss813/3rE+Iq6XY/CDIZIYufD\n\t2qdO5uCjP94ZZz6XY4EJQzy7PssRDdozWFqmnaqMpqpZNZK3etq0G1zFX4WOTHRf/Fxv9ALzlserZ\n\t5UGMcMbduJ9wSXxrPRs3ZQCrVeUsRS37ctR93SlbVdN7G6QBg4wZQ8ZUFFJ3AVdpVZP9fXyY2LWg3\n\tw/M8cYCbLrcoikwUDGO7KanW/00wpxfWyzEq9/jA3NcOy+aghrNZJM3XIFoq4cI24CK47LIinwMAi\n\t8ZvCOxFwQ==;","X-IronPort-AV":"E=Sophos;i=\"5.42,499,1500966000\"; d=\"scan'208\";a=\"7692263\"","Subject":"Re: [PATCH v3 3/5] media: atmel-isc: Enable the clocks during probe","To":"Sakari Ailus ","References":"<20170928081828.20335-1-wenyou.yang@microchip.com>\n\t<20170928081828.20335-4-wenyou.yang@microchip.com>\n\t<20170928212543.sltvd4rgswfowtcd@valkosipuli.retiisi.org.uk>","From":"\"Yang, Wenyou\" ","Message-ID":"<7d5bd4ff-f18e-5f0d-9ce1-3f5169be4c14@Microchip.com>","Date":"Mon, 9 Oct 2017 13:49:44 +0800","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170928212543.sltvd4rgswfowtcd@valkosipuli.retiisi.org.uk>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171008_225012_417873_9C6D5714 ","X-CRM114-Status":"GOOD ( 14.54 )","X-Spam-Score":"-2.6 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.6 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow trust [68.232.149.84 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Mauro Carvalho Chehab ,\n\tJonathan Corbet , linux-kernel@vger.kernel.org,\n\tHans Verkuil , linux-arm-kernel@lists.infradead.org, \n\tLinux Media Mailing List ","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1782576,"web_url":"http://patchwork.ozlabs.org/comment/1782576/","msgid":"<20171009075804.2qr3pbunqzhdz5go@valkosipuli.retiisi.org.uk>","list_archive_url":null,"date":"2017-10-09T07:58:05","subject":"Re: [PATCH v3 3/5] media: atmel-isc: Enable the clocks during probe","submitter":{"id":1593,"url":"http://patchwork.ozlabs.org/api/people/1593/","name":"Sakari Ailus","email":"sakari.ailus@iki.fi"},"content":"Hi\nWenyou,\n\nOn Mon, Oct 09, 2017 at 01:49:44PM +0800, Yang, Wenyou wrote:\n> Hi Sakari,\n> \n> Sorry for late answer, because I was in vacation last week.\n> \n> On 2017/9/29 5:25, Sakari Ailus wrote:\n> > Hi Wenyou,\n> > \n> > On Thu, Sep 28, 2017 at 04:18:26PM +0800, Wenyou Yang wrote:\n> > > To meet the relationship, enable the HCLOCK and ispck during the\n> > > device probe, \"isc_pck frequency is less than or equal to isc_ispck,\n> > > and isc_ispck is greater than or equal to HCLOCK.\"\n> > > Meanwhile, call the pm_runtime_enable() in the right place.\n> > > \n> > > Signed-off-by: Wenyou Yang \n> > > ---\n> > > \n> > > Changes in v3: None\n> > > Changes in v2: None\n> > > \n> > > drivers/media/platform/atmel/atmel-isc.c | 31 +++++++++++++++++++++++++------\n> > > 1 file changed, 25 insertions(+), 6 deletions(-)\n> > > \n> > > diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c\n> > > index 0b15dc1a3a0b..f092c95587c1 100644\n> > > --- a/drivers/media/platform/atmel/atmel-isc.c\n> > > +++ b/drivers/media/platform/atmel/atmel-isc.c\n> > > @@ -1594,6 +1594,7 @@ static int isc_async_complete(struct v4l2_async_notifier *notifier)\n> > > \tstruct isc_subdev_entity *sd_entity;\n> > > \tstruct video_device *vdev = &isc->video_dev;\n> > > \tstruct vb2_queue *q = &isc->vb2_vidq;\n> > > +\tstruct device *dev = isc->dev;\n> > > \tint ret;\n> > > \tret = v4l2_device_register_subdev_nodes(&isc->v4l2_dev);\n> > > @@ -1677,6 +1678,10 @@ static int isc_async_complete(struct v4l2_async_notifier *notifier)\n> > > \t\treturn ret;\n> > > \t}\n> > > +\tpm_runtime_set_active(dev);\n> > > +\tpm_runtime_enable(dev);\n> > > +\tpm_request_idle(dev);\n> > Remember that the driver's async complete function could never get called.\n> > \n> > What would be the reason to move it here?\n> The ISC provides the clock for the sensor, namely, it is the clock provider\n> for the external sensor.\n> So it keeps active to make the sensor probe successfully.\n> Otherwise, the sensor, such as 0v7670 fails to probe due to the failure to\n> clk_enable().\n\nYou'll still need to balance the get and put calls.\n\ncomplete callback is not necessarily called at all or could be called\nmultiple times. Instead, you should probably do pm_runtime_get_sync() when\nthe clock is enabled and put when it's disabled.","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"k8PEQheg\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y9XgZ2wM1z9t5x\n\tfor ;\n\tMon, 9 Oct 2017 18:58:50 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e1SxT-0007Lj-0B; Mon, 09 Oct 2017 07:58:39 +0000","from nblzone-211-213.nblnetworks.fi ([83.145.211.213]\n\thelo=hillosipuli.retiisi.org.uk)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e1SxN-0007EA-22 for linux-arm-kernel@lists.infradead.org;\n\tMon, 09 Oct 2017 07:58:36 +0000","from valkosipuli.localdomain (valkosipuli.retiisi.org.uk\n\t[IPv6:2001:1bc8:1a6:d3d5::80:2])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id D8A54600FF;\n\tMon, 9 Oct 2017 10:58:05 +0300 (EEST)","from sakke by valkosipuli.localdomain with local (Exim 4.89)\n\t(envelope-from )\n\tid 1e1Swv-0002DI-Bd; Mon, 09 Oct 2017 10:58:05 +0300"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=nk1b2qy571Dxp2yWpOgVzkMDsXK3gQ79hAphg7HRrgg=;\n\tb=k8PEQhegcbAiXs\n\t/HUZ84BcA/vGp2qe3/fIhM9MUFVnYPNaIuavrDmO8e5MwubaAfE4ZoDMutU5izfBKb2Tjol4+XPGr\n\tnEwplypoC+ydvjX1t4bcrof3hY+sa6YRBQfyak2W2gcomXfdNNRIoIVGX4x5daQzRZMair/vNvVNH\n\tiOpn7ysaHDYmpSC7vwdN6lH4uVTdvcysdTL2mi6/le12VnN6dmTxQWUGzAg3+Vev0xNSSrQwCCAwX\n\toFoZhDMOQrrJlddhUaZIeQA3CPHqOyhKnnDBfpyCyoIghBq3zfAKXYFLNuB7RSzQbBuO+06gAXPAh\n\tibZP5IxP0um35o1+Kt+w==;","Date":"Mon, 9 Oct 2017 10:58:05 +0300","From":"Sakari Ailus ","To":"\"Yang, Wenyou\" ","Subject":"Re: [PATCH v3 3/5] media: atmel-isc: Enable the clocks during probe","Message-ID":"<20171009075804.2qr3pbunqzhdz5go@valkosipuli.retiisi.org.uk>","References":"<20170928081828.20335-1-wenyou.yang@microchip.com>\n\t<20170928081828.20335-4-wenyou.yang@microchip.com>\n\t<20170928212543.sltvd4rgswfowtcd@valkosipuli.retiisi.org.uk>\n\t<7d5bd4ff-f18e-5f0d-9ce1-3f5169be4c14@Microchip.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<7d5bd4ff-f18e-5f0d-9ce1-3f5169be4c14@Microchip.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171009_005833_406362_0DACC369 ","X-CRM114-Status":"GOOD ( 19.94 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [83.145.211.213 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level\n\tmail domains are different\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Mauro Carvalho Chehab ,\n\tJonathan Corbet , linux-kernel@vger.kernel.org,\n\tHans Verkuil , linux-arm-kernel@lists.infradead.org, \n\tLinux Media Mailing List ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1782676,"web_url":"http://patchwork.ozlabs.org/comment/1782676/","msgid":"<82829609-5c87-538c-2c5d-e99d6c516c60@Microchip.com>","list_archive_url":null,"date":"2017-10-09T10:01:05","subject":"Re: [PATCH v3 3/5] media: atmel-isc: Enable the clocks during probe","submitter":{"id":69532,"url":"http://patchwork.ozlabs.org/api/people/69532/","name":"Wenyou Yang","email":"Wenyou.Yang@microchip.com"},"content":"Hi Sakari,\n\nOn 2017/10/9 15:58, Sakari Ailus wrote:\n> Hi\n> Wenyou,\n>\n> On Mon, Oct 09, 2017 at 01:49:44PM +0800, Yang, Wenyou wrote:\n>> Hi Sakari,\n>>\n>> Sorry for late answer, because I was in vacation last week.\n>>\n>> On 2017/9/29 5:25, Sakari Ailus wrote:\n>>> Hi Wenyou,\n>>>\n>>> On Thu, Sep 28, 2017 at 04:18:26PM +0800, Wenyou Yang wrote:\n>>>> To meet the relationship, enable the HCLOCK and ispck during the\n>>>> device probe, \"isc_pck frequency is less than or equal to isc_ispck,\n>>>> and isc_ispck is greater than or equal to HCLOCK.\"\n>>>> Meanwhile, call the pm_runtime_enable() in the right place.\n>>>>\n>>>> Signed-off-by: Wenyou Yang \n>>>> ---\n>>>>\n>>>> Changes in v3: None\n>>>> Changes in v2: None\n>>>>\n>>>> drivers/media/platform/atmel/atmel-isc.c | 31 +++++++++++++++++++++++++------\n>>>> 1 file changed, 25 insertions(+), 6 deletions(-)\n>>>>\n>>>> diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c\n>>>> index 0b15dc1a3a0b..f092c95587c1 100644\n>>>> --- a/drivers/media/platform/atmel/atmel-isc.c\n>>>> +++ b/drivers/media/platform/atmel/atmel-isc.c\n>>>> @@ -1594,6 +1594,7 @@ static int isc_async_complete(struct v4l2_async_notifier *notifier)\n>>>> \tstruct isc_subdev_entity *sd_entity;\n>>>> \tstruct video_device *vdev = &isc->video_dev;\n>>>> \tstruct vb2_queue *q = &isc->vb2_vidq;\n>>>> +\tstruct device *dev = isc->dev;\n>>>> \tint ret;\n>>>> \tret = v4l2_device_register_subdev_nodes(&isc->v4l2_dev);\n>>>> @@ -1677,6 +1678,10 @@ static int isc_async_complete(struct v4l2_async_notifier *notifier)\n>>>> \t\treturn ret;\n>>>> \t}\n>>>> +\tpm_runtime_set_active(dev);\n>>>> +\tpm_runtime_enable(dev);\n>>>> +\tpm_request_idle(dev);\n>>> Remember that the driver's async complete function could never get called.\n>>>\n>>> What would be the reason to move it here?\n>> The ISC provides the clock for the sensor, namely, it is the clock provider\n>> for the external sensor.\n>> So it keeps active to make the sensor probe successfully.\n>> Otherwise, the sensor, such as 0v7670 fails to probe due to the failure to\n>> clk_enable().\n> You'll still need to balance the get and put calls.\n>\n> complete callback is not necessarily called at all or could be called\n> multiple times. Instead, you should probably do pm_runtime_get_sync() when\n> the clock is enabled and put when it's disabled.\nI will send v4 to update it.\n\nThank you for your advice.\n\nBest Regards,\nWenyou Yang","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"ZrRY4rjs\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y9bQq54H3z9tXx\n\tfor ;\n\tMon, 9 Oct 2017 21:02:59 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e1Uti-0002Se-MW; Mon, 09 Oct 2017 10:02:54 +0000","from esa5.microchip.iphmx.com ([216.71.150.166])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e1Ute-0002Cg-CS for linux-arm-kernel@lists.infradead.org;\n\tMon, 09 Oct 2017 10:02:52 +0000","from exsmtp01.microchip.com (HELO email.microchip.com)\n\t([198.175.253.37])\n\tby esa5.microchip.iphmx.com with ESMTP/TLS/AES128-SHA;\n\t09 Oct 2017 03:01:13 -0700","from [10.160.137.105] (10.10.76.4) by CHN-SV-EXCH01.mchp-main.com\n\t(10.10.76.37) with Microsoft SMTP Server id 14.3.352.0;\n\tMon, 9 Oct 2017 03:01:11 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:\n\tReferences:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=f1+93R+oaaD5c9fhul20ZckApbzycaPJtcCoGEaRpmk=;\n\tb=ZrRY4rjsbTOv3x3eG101I6X9X\n\tT7jFcX/3U7Oq+vG59kyD4+c/TxufTL7UsX8Bn6jQXZn1k3kZmzd5yUby2Jtx3llKNrTdOOizufqAA\n\t43USA/QN6RVJL80Z7QS1jfXDlQ+yUsfKiadq3m3ydtkJbO/9LUur+Nz8U7gZAKgB80Bmd9RHo5+Kc\n\t6nsLYCNUZU13+O4oV81NwhPEZs3c42+Y4mIvDSZ6oakV/uzHUGwf7HFyTPEaSxg3QQNEUcRmHVX0c\n\t+SR2eoNyfmMyz5ITt7JJP8gkOvCC71U4gdIUI5ctM2NfIA4NYNSJglm9HO+4ouQGiyXGsdneAj9MF\n\tU+WySdTeA==;","X-IronPort-AV":"E=Sophos;i=\"5.42,500,1500966000\"; d=\"scan'208\";a=\"5406096\"","Subject":"Re: [PATCH v3 3/5] media: atmel-isc: Enable the clocks during probe","To":"Sakari Ailus ","References":"<20170928081828.20335-1-wenyou.yang@microchip.com>\n\t<20170928081828.20335-4-wenyou.yang@microchip.com>\n\t<20170928212543.sltvd4rgswfowtcd@valkosipuli.retiisi.org.uk>\n\t<7d5bd4ff-f18e-5f0d-9ce1-3f5169be4c14@Microchip.com>\n\t<20171009075804.2qr3pbunqzhdz5go@valkosipuli.retiisi.org.uk>","From":"\"Yang, Wenyou\" ","Message-ID":"<82829609-5c87-538c-2c5d-e99d6c516c60@Microchip.com>","Date":"Mon, 9 Oct 2017 18:01:05 +0800","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20171009075804.2qr3pbunqzhdz5go@valkosipuli.retiisi.org.uk>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171009_030250_460706_5502D4E6 ","X-CRM114-Status":"GOOD ( 14.58 )","X-Spam-Score":"-2.6 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.6 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow trust [216.71.150.166 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Mauro Carvalho Chehab ,\n\tJonathan Corbet , linux-kernel@vger.kernel.org,\n\tHans Verkuil , linux-arm-kernel@lists.infradead.org, \n\tLinux Media Mailing List ","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]