[{"id":1776810,"web_url":"http://patchwork.ozlabs.org/comment/1776810/","msgid":"<20170928071154.GC26066@lemon.lan>","list_archive_url":null,"date":"2017-09-28T07:11:54","subject":"Re: [Qemu-devel] [PATCH v4 5/5] aio: fix assert when remove poll\n\tduring destroy","submitter":{"id":24872,"url":"http://patchwork.ozlabs.org/api/people/24872/","name":"Fam Zheng","email":"famz@redhat.com"},"content":"On Thu, 09/28 10:59, Peter Xu wrote:\n> From: Stefan Hajnoczi \n> \n> After iothread is enabled internally inside QEMU with GMainContext, we\n> may encounter this warning when destroying the iothread:\n> \n> (qemu-system-x86_64:19925): GLib-CRITICAL **: g_source_remove_poll:\n> assertion '!SOURCE_DESTROYED (source)' failed\n> \n> The problem is that g_source_remove_poll() does not allow to remove one\n> source from array if the source is detached from its owner\n> context. (peterx: which IMHO does not make much sense)\n> \n> Fix it on QEMU side by avoid calling g_source_remove_poll() if we know\n> the object is during destruction, and we won't leak anything after all\n> since the array will be gone soon cleanly even with that fd.\n> \n> Signed-off-by: Stefan Hajnoczi \n> [peterx: write the commit message]\n> Signed-off-by: Peter Xu \n> ---\n> util/aio-posix.c | 9 ++++++++-\n> 1 file changed, 8 insertions(+), 1 deletion(-)\n> \n> diff --git a/util/aio-posix.c b/util/aio-posix.c\n> index 2d51239ec6..5946ac09f0 100644\n> --- a/util/aio-posix.c\n> +++ b/util/aio-posix.c\n> @@ -223,7 +223,14 @@ void aio_set_fd_handler(AioContext *ctx,\n> return;\n> }\n> \n> - g_source_remove_poll(&ctx->source, &node->pfd);\n> + /* If the GSource is in the process of being destroyed then\n> + * g_source_remove_poll() causes an assertion failure. Skip\n> + * removal in that case, because glib cleans up its state during\n> + * destruction anyway.\n> + */\n> + if (!g_source_is_destroyed(&ctx->source)) {\n> + g_source_remove_poll(&ctx->source, &node->pfd);\n> + }\n> \n> /* If the lock is held, just mark the node as deleted */\n> if (qemu_lockcnt_count(&ctx->list_lock)) {\n> -- \n> 2.13.5\n> \n\nReviewed-by: Fam Zheng ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2m9V6jFwz9t5x\n\tfor ;\n\tThu, 28 Sep 2017 17:12:46 +1000 (AEST)","from localhost ([::1]:57717 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxT01-0006WF-1u\n\tfor incoming@patchwork.ozlabs.org; Thu, 28 Sep 2017 03:12:45 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59190)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxSzL-0006Px-TW\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 03:12:13 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxSzK-0002II-Tn\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 03:12:03 -0400","from mx1.redhat.com ([209.132.183.28]:50332)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxSzK-0002I4-MF\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 03:12:02 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 66D6CE8AE1;\n\tThu, 28 Sep 2017 07:12:01 +0000 (UTC)","from localhost (ovpn-12-58.pek2.redhat.com [10.72.12.58])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 8EF0E672DF;\n\tThu, 28 Sep 2017 07:11:55 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 66D6CE8AE1","Date":"Thu, 28 Sep 2017 15:11:54 +0800","From":"Fam Zheng ","To":"Peter Xu ","Message-ID":"<20170928071154.GC26066@lemon.lan>","References":"<20170928025958.1420-1-peterx@redhat.com>\n\t<20170928025958.1420-6-peterx@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170928025958.1420-6-peterx@redhat.com>","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tThu, 28 Sep 2017 07:12:01 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 5/5] aio: fix assert when remove poll\n\tduring destroy","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Manos Pitsidianakis , qemu-devel@nongnu.org, \"Dr .\n\tDavid Alan Gilbert\" , Stefan Hajnoczi\n\t, Stefan Hajnoczi ,\n\tPaolo Bonzini , Andreas =?iso-8859-1?q?F=E4rber?=\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776927,"web_url":"http://patchwork.ozlabs.org/comment/1776927/","msgid":"<20170928095935.GB12157@stefanha-x1.localdomain>","list_archive_url":null,"date":"2017-09-28T09:59:35","subject":"Re: [Qemu-devel] [PATCH v4 5/5] aio: fix assert when remove poll\n\tduring destroy","submitter":{"id":17227,"url":"http://patchwork.ozlabs.org/api/people/17227/","name":"Stefan Hajnoczi","email":"stefanha@redhat.com"},"content":"On Thu, Sep 28, 2017 at 10:59:58AM +0800, Peter Xu wrote:\n> From: Stefan Hajnoczi \n> \n> After iothread is enabled internally inside QEMU with GMainContext, we\n> may encounter this warning when destroying the iothread:\n> \n> (qemu-system-x86_64:19925): GLib-CRITICAL **: g_source_remove_poll:\n> assertion '!SOURCE_DESTROYED (source)' failed\n> \n> The problem is that g_source_remove_poll() does not allow to remove one\n> source from array if the source is detached from its owner\n> context. (peterx: which IMHO does not make much sense)\n> \n> Fix it on QEMU side by avoid calling g_source_remove_poll() if we know\n> the object is during destruction, and we won't leak anything after all\n> since the array will be gone soon cleanly even with that fd.\n> \n> Signed-off-by: Stefan Hajnoczi \n> [peterx: write the commit message]\n> Signed-off-by: Peter Xu \n> ---\n> util/aio-posix.c | 9 ++++++++-\n> 1 file changed, 8 insertions(+), 1 deletion(-)\n\nReviewed-by: Stefan Hajnoczi ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=stefanha@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2qtZ4Qpqz9t5Y\n\tfor ;\n\tThu, 28 Sep 2017 20:00:06 +1000 (AEST)","from localhost ([::1]:58236 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxVbu-0002O2-JD\n\tfor incoming@patchwork.ozlabs.org; Thu, 28 Sep 2017 06:00:02 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40121)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxVbc-0002Nw-2L\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 05:59:45 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxVbY-0005Ag-Td\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 05:59:44 -0400","from mx1.redhat.com ([209.132.183.28]:46438)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxVbY-00059P-Nv\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 05:59:40 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B6DF814F220;\n\tThu, 28 Sep 2017 09:59:39 +0000 (UTC)","from localhost (ovpn-117-174.ams2.redhat.com [10.36.117.174])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E57D417A60;\n\tThu, 28 Sep 2017 09:59:36 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B6DF814F220","Date":"Thu, 28 Sep 2017 10:59:35 +0100","From":"Stefan Hajnoczi ","To":"Peter Xu ","Message-ID":"<20170928095935.GB12157@stefanha-x1.localdomain>","References":"<20170928025958.1420-1-peterx@redhat.com>\n\t<20170928025958.1420-6-peterx@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170928025958.1420-6-peterx@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tThu, 28 Sep 2017 09:59:39 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 5/5] aio: fix assert when remove poll\n\tduring destroy","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Fam Zheng , Manos Pitsidianakis , \n\tqemu-devel@nongnu.org, Stefan Hajnoczi , Paolo\n\tBonzini , Andreas =?iso-8859-1?q?F=E4rber?=\n\t, \t\"Dr . David Alan Gilbert\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776940,"web_url":"http://patchwork.ozlabs.org/comment/1776940/","msgid":"<20170928102831.GC12157@stefanha-x1.localdomain>","list_archive_url":null,"date":"2017-09-28T10:28:31","subject":"Re: [Qemu-devel] [PATCH v4 0/5] iothread: allow to create internal\n\tiothreads","submitter":{"id":17227,"url":"http://patchwork.ozlabs.org/api/people/17227/","name":"Stefan Hajnoczi","email":"stefanha@redhat.com"},"content":"On Thu, Sep 28, 2017 at 10:59:53AM +0800, Peter Xu wrote:\n> v4:\n> - fix comment in patch 1 [Fam, Stefan]\n> - add one more patch from Stefan to fix the aio glib warning\n> \n> v3:\n> - pick up r-bs (one missing for Fam's on last patch)\n> - fix patch 1 to create isolated internal container\n> \n> v2:\n> - add one patch to provide object_get_internal_root() [Daniel]\n> - patch 2: use the new object_get_internal_root()\n> - patch 3: fix commit message, \"reentrant\" is wrongly used by me. it\n> should be \"called multiple times\"; move iothread->ctx check into\n> iothread_stop() [Fam]\n> - patch 4: add one paragraph in commit message, mention about the glib\n> issue. [Fam]\n> \n> When trying to support monitor OOB (out-of-band) commands, I found\n> that the monitor IO thread I did looks just like iothread. It would\n> be best if I can use iothread directly. However it seems that it was\n> mostly used by \"-object iothread\" before but not friendly to internal\n> usages. This series tries to export essential functions to do it.\n> \n> Also, I think patch 2 also fixes a bug in iothread_stop().\n> \n> Please review. Thanks.\n> \n> Peter Xu (4):\n> qom: provide root container for internal objs\n> iothread: provide helpers for internal use\n> iothread: export iothread_stop()\n> iothread: delay the context release to finalize\n> \n> Stefan Hajnoczi (1):\n> aio: fix assert when remove poll during destroy\n> \n> include/qom/object.h | 11 +++++++++++\n> include/sysemu/iothread.h | 9 +++++++++\n> iothread.c | 46 ++++++++++++++++++++++++++++++++++++----------\n> qom/object.c | 11 +++++++++++\n> util/aio-posix.c | 9 ++++++++-\n> 5 files changed, 75 insertions(+), 11 deletions(-)\n> \n> -- \n> 2.13.5\n> \n\nThanks, applied to my block tree:\nhttps://github.com/stefanha/qemu/commits/block\n\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=stefanha@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2rX26dzBz9tXj\n\tfor ;\n\tThu, 28 Sep 2017 20:29:06 +1000 (AEST)","from localhost ([::1]:58324 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxW40-0000nc-9x\n\tfor incoming@patchwork.ozlabs.org; Thu, 28 Sep 2017 06:29:04 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46258)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxW3f-0000nX-QZ\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 06:28:44 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxW3b-0003Te-Ej\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 06:28:43 -0400","from mx1.redhat.com ([209.132.183.28]:49032)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxW3b-0003TI-8N\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 06:28:39 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4855CFD751;\n\tThu, 28 Sep 2017 10:28:38 +0000 (UTC)","from localhost (ovpn-117-174.ams2.redhat.com [10.36.117.174])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 666947DB5D;\n\tThu, 28 Sep 2017 10:28:32 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4855CFD751","Date":"Thu, 28 Sep 2017 11:28:31 +0100","From":"Stefan Hajnoczi ","To":"Peter Xu ","Message-ID":"<20170928102831.GC12157@stefanha-x1.localdomain>","References":"<20170928025958.1420-1-peterx@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170928025958.1420-1-peterx@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tThu, 28 Sep 2017 10:28:38 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 0/5] iothread: allow to create internal\n\tiothreads","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Fam Zheng , Manos Pitsidianakis , \n\tqemu-devel@nongnu.org, Stefan Hajnoczi , Paolo\n\tBonzini , Andreas =?iso-8859-1?q?F=E4rber?=\n\t, \t\"Dr . David Alan Gilbert\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]