[{"id":1776618,"web_url":"http://patchwork.ozlabs.org/comment/1776618/","msgid":"<8afc1fd5-5fdd-05d9-cc79-e05f52057c21@redhat.com>","list_archive_url":null,"date":"2017-09-27T21:06:24","subject":"Re: [Qemu-devel] [PATCH v4 0/6] Misc improvements to crypto block\n\tdriver","submitter":{"id":36836,"url":"http://patchwork.ozlabs.org/api/people/36836/","name":"Max Reitz","email":"mreitz@redhat.com"},"content":"On 2017-09-27 14:53, Daniel P. Berrange wrote:\n> This is a followup to\n> \n> v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg00781.html\n> v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg06464.html\n> v3: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg02923.html\n> \n> This collection of patches first improves the performance of the\n> crypto block driver and then does various cleanups to improve ongoing\n> maint work.\n> \n> Changed in v4:\n> \n> - Drop intermediate patch that replaced '512' with a constant (Max)\n> - Use MIN() macro where needed (Max)\n> - Fix bounce buffer size at 1MB instead of varying per sector size (Max)\n> - Convert missing qcrypto_block_encrypt call to sectors in qcow.c (Max)\n> \n> Changed in v3:\n> \n> - Support passthrough of BDRV_REQ_FUA (Eric)\n> - Fix potential truncation of payload offset values (Eric)\n> - Use encryption scheme sector size instead of BDRV_SECTOR_SIZE (Kevin)\n> - Use QEMU_IS_ALIGNED where appropriate (Eric)\n> - Remove unused 'sector_num' variable (Eric)\n> - Fix whitespace alignment (Eric)\n> - Fix math error in qcow conversion (Eric)\n> \n> Daniel P. Berrange (6):\n> block: use 1 MB bounce buffers for crypto instead of 16KB\n> crypto: expose encryption sector size in APIs\n> block: fix data type casting for crypto payload offset\n> block: convert crypto driver to bdrv_co_preadv|pwritev\n> block: convert qcrypto_block_encrypt|decrypt to take bytes offset\n> block: support passthrough of BDRV_REQ_FUA in crypto driver\n> \n> block/crypto.c | 130 ++++++++++++++++++++++++++-----------------------\n> block/qcow.c | 11 +++--\n> block/qcow2-cluster.c | 8 ++-\n> block/qcow2.c | 4 +-\n> crypto/block-luks.c | 18 ++++---\n> crypto/block-qcow.c | 13 +++--\n> crypto/block.c | 26 +++++++---\n> crypto/blockpriv.h | 5 +-\n> include/crypto/block.h | 29 ++++++++---\n> 9 files changed, 148 insertions(+), 96 deletions(-)\n\nThanks; hoping that is OK with you, I've applied this series to my block\nbranch:\n\nhttps://github.com/XanClic/qemu/commits/block\n\nMax","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=mreitz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2Vkl2VzJz9t33\n\tfor ;\n\tThu, 28 Sep 2017 07:07:08 +1000 (AEST)","from localhost ([::1]:56354 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxJXr-0000Y9-8d\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 17:07:03 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37724)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxJXQ-0000WL-Ae\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 17:06:37 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxJXP-00020J-9K\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 17:06:36 -0400","from mx1.redhat.com ([209.132.183.28]:35932)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dxJXK-0001yl-Dt; Wed, 27 Sep 2017 17:06:30 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2901CC0AD247;\n\tWed, 27 Sep 2017 21:06:29 +0000 (UTC)","from dresden.str.redhat.com (unknown [10.40.205.58])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id A3A0D8AC2A;\n\tWed, 27 Sep 2017 21:06:26 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 2901CC0AD247","To":"\"Daniel P. Berrange\" , qemu-devel@nongnu.org","References":"<20170927125340.12360-1-berrange@redhat.com>","From":"Max Reitz ","Message-ID":"<8afc1fd5-5fdd-05d9-cc79-e05f52057c21@redhat.com>","Date":"Wed, 27 Sep 2017 23:06:24 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170927125340.12360-1-berrange@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"8xPNJfhQNa8X392eqGSxQLT39l2S3FvBV\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tWed, 27 Sep 2017 21:06:29 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v4 0/6] Misc improvements to crypto block\n\tdriver","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , Stefan Hajnoczi ,\n\tqemu-block@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776859,"web_url":"http://patchwork.ozlabs.org/comment/1776859/","msgid":"<20170928083041.GD12919@redhat.com>","list_archive_url":null,"date":"2017-09-28T08:30:41","subject":"Re: [Qemu-devel] [PATCH v4 0/6] Misc improvements to crypto block\n\tdriver","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Wed, Sep 27, 2017 at 11:06:24PM +0200, Max Reitz wrote:\n> On 2017-09-27 14:53, Daniel P. Berrange wrote:\n> > This is a followup to\n> > \n> > v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg00781.html\n> > v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg06464.html\n> > v3: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg02923.html\n> > \n> > This collection of patches first improves the performance of the\n> > crypto block driver and then does various cleanups to improve ongoing\n> > maint work.\n> > \n> > Changed in v4:\n> > \n> > - Drop intermediate patch that replaced '512' with a constant (Max)\n> > - Use MIN() macro where needed (Max)\n> > - Fix bounce buffer size at 1MB instead of varying per sector size (Max)\n> > - Convert missing qcrypto_block_encrypt call to sectors in qcow.c (Max)\n> > \n> > Changed in v3:\n> > \n> > - Support passthrough of BDRV_REQ_FUA (Eric)\n> > - Fix potential truncation of payload offset values (Eric)\n> > - Use encryption scheme sector size instead of BDRV_SECTOR_SIZE (Kevin)\n> > - Use QEMU_IS_ALIGNED where appropriate (Eric)\n> > - Remove unused 'sector_num' variable (Eric)\n> > - Fix whitespace alignment (Eric)\n> > - Fix math error in qcow conversion (Eric)\n> > \n> > Daniel P. Berrange (6):\n> > block: use 1 MB bounce buffers for crypto instead of 16KB\n> > crypto: expose encryption sector size in APIs\n> > block: fix data type casting for crypto payload offset\n> > block: convert crypto driver to bdrv_co_preadv|pwritev\n> > block: convert qcrypto_block_encrypt|decrypt to take bytes offset\n> > block: support passthrough of BDRV_REQ_FUA in crypto driver\n> > \n> > block/crypto.c | 130 ++++++++++++++++++++++++++-----------------------\n> > block/qcow.c | 11 +++--\n> > block/qcow2-cluster.c | 8 ++-\n> > block/qcow2.c | 4 +-\n> > crypto/block-luks.c | 18 ++++---\n> > crypto/block-qcow.c | 13 +++--\n> > crypto/block.c | 26 +++++++---\n> > crypto/blockpriv.h | 5 +-\n> > include/crypto/block.h | 29 ++++++++---\n> > 9 files changed, 148 insertions(+), 96 deletions(-)\n> \n> Thanks; hoping that is OK with you, I've applied this series to my block\n> branch:\n> \n> https://github.com/XanClic/qemu/commits/block\n\nYes, that is fine - preferrable to merge via an main block tree since\nit touches qcow2.\n\n\nRegards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2nwN3Nmmz9t3w\n\tfor ;\n\tThu, 28 Sep 2017 18:31:32 +1000 (AEST)","from localhost ([::1]:57956 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxUEE-000257-JW\n\tfor incoming@patchwork.ozlabs.org; Thu, 28 Sep 2017 04:31:30 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49414)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxUDg-00021O-Ch\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 04:30:59 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxUDf-0006CV-60\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 04:30:56 -0400","from mx1.redhat.com ([209.132.183.28]:59876)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dxUDX-00069F-85; Thu, 28 Sep 2017 04:30:47 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3EC2080A75;\n\tThu, 28 Sep 2017 08:30:46 +0000 (UTC)","from redhat.com (unknown [10.33.36.70])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id DD72E171F5;\n\tThu, 28 Sep 2017 08:30:44 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 3EC2080A75","Date":"Thu, 28 Sep 2017 09:30:41 +0100","From":"\"Daniel P. Berrange\" ","To":"Max Reitz ","Message-ID":"<20170928083041.GD12919@redhat.com>","References":"<20170927125340.12360-1-berrange@redhat.com>\n\t<8afc1fd5-5fdd-05d9-cc79-e05f52057c21@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<8afc1fd5-5fdd-05d9-cc79-e05f52057c21@redhat.com>","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tThu, 28 Sep 2017 08:30:46 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 0/6] Misc improvements to crypto block\n\tdriver","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"\"Daniel P. Berrange\" ","Cc":"Kevin Wolf , Stefan Hajnoczi ,\n\tqemu-devel@nongnu.org, qemu-block@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]