[{"id":1784398,"web_url":"http://patchwork.ozlabs.org/comment/1784398/","msgid":"","list_archive_url":null,"date":"2017-10-11T08:35:59","subject":"Re: [PATCH v6 1/2] dt-bindings: gpio: uniphier: add UniPhier GPIO\n\tbinding","submitter":{"id":7055,"url":"http://patchwork.ozlabs.org/api/people/7055/","name":"Linus Walleij","email":"linus.walleij@linaro.org"},"content":"On Wed, Sep 27, 2017 at 4:40 AM, Masahiro Yamada\n wrote:\n\n> This GPIO controller is used on UniPhier SoC family.\n>\n> The vendor specific property \"socionext,interrupt-ranges\" is for\n> specifying interrupt mapping to the parent interrupt controller\n> because the mapping is not contiguous. It works like \"ranges\",\n> but transforms \"interrupts\" instead of \"reg\".\n>\n> Signed-off-by: Masahiro Yamada \n> Acked-by: Rob Herring \n\nPatch applied.\n\n> +- socionext,interrupt-ranges: Specifies an interrupt number mapping between\n> + this GPIO controller and its interrupt parent, in the form of arbitrary\n> + number of triplets.\n(...)\n> + socionext,interrupt-ranges = <0 48 16>, <16 154 5>, <21 217 3>;\n\nStill uncertain about that thing.\n\nBut as it is, you need running code, and we have rough consensus.\n\nSo merging.\n\nIf it turns out to be a bad binding we may need to patch in an alternative\nlater.\n\nYours,\nLinus Walleij","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"YVs3CEXR\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"amtcKOXA\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBnQ538qJz9t3Z\n\tfor ;\n\tWed, 11 Oct 2017 19:36:29 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e2CV7-0002h2-Sj; Wed, 11 Oct 2017 08:36:25 +0000","from mail-it0-x22b.google.com ([2607:f8b0:4001:c0b::22b])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e2CV3-0002Uv-6N for linux-arm-kernel@lists.infradead.org;\n\tWed, 11 Oct 2017 08:36:23 +0000","by mail-it0-x22b.google.com with SMTP id o135so1927464itb.0\n\tfor ;\n\tWed, 11 Oct 2017 01:36:00 -0700 (PDT)","by 10.79.14.140 with HTTP; Wed, 11 Oct 2017 01:35:59 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=Qv6e6bmwAjcyGR3obhGKFkPsgOXBZNxlt9vgVe5b2Ts=;\n\tb=YVs3CEXRRchlfC\n\tewijMCUigSa7hYOTS441WN+dfUOxf/uyP6ywpZm8yf0yU36RIsXW9MSYRoQ3x+eLCvL8bu8NVKNI0\n\tOToUFtQ+6f2ReM8T46gUpRe3b32fpdKTpEtcF/B1AuFKjDlZibxu06XsESvSEyNyy05wVYep7AI0P\n\thcYOmXNTBllAekd0yqku1P4qryv3fBrAfE7jrJp8ZOxLU0SvLtB/bSdQgzNWqbsIV7DPenTZv7/tx\n\tgmmxUPGgz+Rp65XOWA6qSbyrOIW0BjgaHz+ExsAmXtS7/qE1UMNpM+QfuMTdd2q3ehiibGH5Q9KGP\n\tWeRY5ChaDdJnxb237vrg==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=SkCyo2gmXX5hbG9YcCJJnsZX0xF/Jm1poGzhRbL90XM=;\n\tb=amtcKOXAVxRyyF4a5vo0KSKYjp4XmHVr2mRMiBhRyIURFGNh3sEmPRPkdK3eJOSzQu\n\tLdh5Ms1jBgwFTHcnv/i0pR5b7nFBznHISxCJRzKDbN5eNeJnP/wvWUBBqANV85J/coed\n\ti/KLoZSbRUEhv5F4gIgN4SOS2RD1oUMUY0c58="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=SkCyo2gmXX5hbG9YcCJJnsZX0xF/Jm1poGzhRbL90XM=;\n\tb=q9BgFpzHPKzw0tqqy376oR+sJvnPkuJOV6erF5N7Ts+V/UaO4hIJRcP4uzs2tvhwr4\n\t09C9ihj9hC3itf4tJy1s/eyja4zni4BgTcKzeQ/Ul2kQsXgQo6uE1LytbbhpTVGjJnGB\n\t/jYYYMPX2cL+YKiABZgX/nhvGXNoRp141n+FY+dxYDFr4CuCu4EzNWLfTstPBpRlg6nm\n\tMAaMkTzrq29wJdtICkROr5459SGWgE/L2mGAHwtDRYZgxHZ9jssYZ2hvJAn/vRCBwdxd\n\tlzqEkAEETFPpgwxvRK8NM95Q6COPSpo7zf6guQ32cy10Nbiw2TogYwO3OlBfizH5QXRL\n\txnPQ==","X-Gm-Message-State":"AMCzsaXBYE6nvTO5Ezj9Yk0RTjGlRbx+MXPVpNG4Hbalbs3oj9/Stp5U\n\ts5xsDh7gH6mDoim4iDkT7fYdqiqfnivdAqQWrYw/Zw==","X-Google-Smtp-Source":"AOwi7QCYTuB48wbwnhr/FH5f+LOK9hIHcBLPb8gwaaCKy5eOyxttMUaE1s0BIzSmMv0fVw+d5adRQRNPl3/LNmY0DtM=","X-Received":"by 10.36.92.193 with SMTP id q184mr4104136itb.83.1507710960368; \n\tWed, 11 Oct 2017 01:36:00 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1506480022-8995-2-git-send-email-yamada.masahiro@socionext.com>","References":"<1506480022-8995-1-git-send-email-yamada.masahiro@socionext.com>\n\t<1506480022-8995-2-git-send-email-yamada.masahiro@socionext.com>","From":"Linus Walleij ","Date":"Wed, 11 Oct 2017 10:35:59 +0200","Message-ID":"","Subject":"Re: [PATCH v6 1/2] dt-bindings: gpio: uniphier: add UniPhier GPIO\n\tbinding","To":"Masahiro Yamada ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171011_013621_399425_6B310179 ","X-CRM114-Status":"GOOD ( 11.89 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Mark Rutland , Rob Herring ,\n\tJassi Brar ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"linux-gpio@vger.kernel.org\" ,\n\t\"devicetree@vger.kernel.org\" ,\n\tRob Herring ,\n\tMasami Hiramatsu , \n\t\"linux-arm-kernel@lists.infradead.org\"\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1784403,"web_url":"http://patchwork.ozlabs.org/comment/1784403/","msgid":"","list_archive_url":null,"date":"2017-10-11T08:40:58","subject":"Re: [PATCH v6 2/2] gpio: uniphier: add UniPhier GPIO controller\n\tdriver","submitter":{"id":7055,"url":"http://patchwork.ozlabs.org/api/people/7055/","name":"Linus Walleij","email":"linus.walleij@linaro.org"},"content":"On Wed, Sep 27, 2017 at 4:40 AM, Masahiro Yamada\n wrote:\n\n> This GPIO controller is used on UniPhier SoC family.\n>\n> It also serves as an interrupt controller, but interrupt signals are\n> just delivered to the parent irqchip without any latching or OR'ing.\n> This type of hardware can be well described with hierarchy IRQ domain.\n>\n> One unfortunate thing for this device is that the interrupt mapping to\n> the interrupt parent is not contiguous.\n>\n> I asked how DT can describe interrupt mapping between two irqchips [1],\n> but I could not find a good solution (at least in the framework level).\n> In fact, irqchip drivers using hierarchy domain generally hard-code the\n> DT binding of their parent.\n>\n> After tackling on several approaches such as hard-code of hwirqs,\n> irq_domain_push_irq(), I ended up with a vendor specific property.\n> If we come up with a good idea to support this in the framework, we\n> can migrate over to it, but we can live with a driver-level solution\n> for now.\n>\n> [1] https://lkml.org/lkml/2017/7/6/758\n>\n> Signed-off-by: Masahiro Yamada \n\nMostly happy with this.\n\n> @@ -2036,6 +2036,7 @@ F: arch/arm/mm/cache-uniphier.c\n> F: arch/arm64/boot/dts/socionext/\n> F: drivers/bus/uniphier-system-bus.c\n> F: drivers/clk/uniphier/\n> +F: drivers/gpio/gpio-uniphier.c\n\nAlso add an entry for the device tree bindings please.\n\n> +++ b/include/dt-bindings/gpio/uniphier-gpio.h\n> @@ -0,0 +1,18 @@\n> +/*\n> + * Copyright (C) 2017 Socionext Inc.\n> + * Author: Masahiro Yamada \n> + */\n> +\n> +#ifndef _DT_BINDINGS_GPIO_UNIPHIER_H\n> +#define _DT_BINDINGS_GPIO_UNIPHIER_H\n> +\n> +#define UNIPHIER_GPIO_LINES_PER_BANK 8\n> +\n> +#define UNIPHIER_GPIO_IRQ_OFFSET ((UNIPHIER_GPIO_LINES_PER_BANK) * 15)\n> +\n> +#define UNIPHIER_GPIO_PORT(bank, line) \\\n> + ((UNIPHIER_GPIO_LINES_PER_BANK) * (bank) + (line))\n> +\n> +#define UNIPHIER_GPIO_IRQ(n) ((UNIPHIER_GPIO_IRQ_OFFSET) + (n))\n> +\n> +#endif /* _DT_BINDINGS_GPIO_UNIPHIER_H */\n\nI do not understand what some of these things are doing in the\ndevice tree header file.\n\nIt just looks creepingly similar to some of the magic I've seen\nin board files.\n\nIt makes much more sense that the device trees either:\n\n- Use the interrupts as a flat array 0...N across all banks\n\n- Model each bank as a separate GPIO chip\n\nThis is somewhere inbetween, you are modeling it as a single\ngpiochip but still not, becuase the device tree author still need\nto address banking, that is confusing.\n\nYours,\nLinus Walleij","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"Ja7Kcj8G\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"EZU+edcC\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBnWs6LH6z9t3H\n\tfor ;\n\tWed, 11 Oct 2017 19:41:29 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e2CZv-0005Mc-To; Wed, 11 Oct 2017 08:41:23 +0000","from mail-it0-x22a.google.com ([2607:f8b0:4001:c0b::22a])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e2CZs-0005CT-4D for linux-arm-kernel@lists.infradead.org;\n\tWed, 11 Oct 2017 08:41:22 +0000","by mail-it0-x22a.google.com with SMTP id 72so1918982itk.3\n\tfor ;\n\tWed, 11 Oct 2017 01:40:59 -0700 (PDT)","by 10.79.14.140 with HTTP; Wed, 11 Oct 2017 01:40:58 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=Qp5TwHX6fLSB+ak/AkHhHtDSBWO4TGiTkDKW+EOhav4=;\n\tb=Ja7Kcj8GgDvOqU\n\tQmaU8AVjhqAq5/A+FDPK50goVa89Vr8jmepIu5IZXBXZGOb4t8m+YwlLPeKHZAFoLGUItX+g0B1Li\n\twAetJ8n6eC08fMaK2RP+zH6zgoO04h2Ujp2zNezKUHdpPuJAR6CTSCUyVTaqGG4MtvYHjrdAtFFTO\n\tXzjpR7Xgqmf44vvaKox/9Qsg3ui9cwVYKzYnWD137JCOVnkidyZlorQUxxWmkfEaYEJvUbi/ejNM/\n\t6ey/iFbbLJIaOxMrp9+0AWSuVoCMw/4IQZb9llU/CntNrrPXUjJACqtIMKOwzQzyKlyA5qwFDqIhR\n\t/42g0j7JSnMFC1r8hrAA==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=k13pRs5Gvip2qOm3hStA9+jcxWybhsKEcjpG3PmfHc0=;\n\tb=EZU+edcCm4K2OoHW1YZtwTgZST+pLKgdSgIcLGxR/mspXXoFQyT0udwe0uMGLR5Qx4\n\tmTf+Z74K44xQWJxeGtCLr06gsRe9KLZUCbEGDHtRVkLE60KrYL47gZxigVuIHApCKp1G\n\tprZGBRAXSdkBEATOFKMPs1CJuxXn+b+0Qk9es="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=k13pRs5Gvip2qOm3hStA9+jcxWybhsKEcjpG3PmfHc0=;\n\tb=bPhPHtMHpP+y0h1MHDyNF5LkSDgCjeyzc01o83EsWezSzXsRpnlb2o6wngCaZmgGui\n\tS8EEdRUVKVaWsdgQ2OsW5U/0SN8qTbTg86pRPAyFUzI5wsOoBgM9hsfkzjLByFjiC1x6\n\tiCP5gDk5Wzm5mAZ5kFuqTrcB9y3EV56zASxJKerPFVXL+YA48Yj06LQOa5vKHm9MMETV\n\tGTKnGPY/bLd1/38r3j4MCCcYbM0ErGaXLTx7OidGY8To0e9ksXNCAk0VVBPlMO/+fUAg\n\t7aUJHNoE1K00qicVO3YUV9dsU768WNmKJG+UfET7rYC46lD18g+RU/hzOp2Xu1GgLobZ\n\tgXcA==","X-Gm-Message-State":"AMCzsaW7GerdEAlpgzGnHHUA6y70iUmDTTE4zCzXe/aCaOxYS2FZv73C\n\tlUgIuNiO0muKiNL6YKQ7TsBscTVgTyOw4jy667ZILQ==","X-Google-Smtp-Source":"AOwi7QCcnv9AdL3hyGKbVSE1CjpdwoGpvgCpCZ5nuX4jMduPDq40TibmGhHJgcTgYgc6qJE5dI/XZA035dGO/ifT4wI=","X-Received":"by 10.36.160.136 with SMTP id o130mr9505580ite.36.1507711258630; \n\tWed, 11 Oct 2017 01:40:58 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1506480022-8995-3-git-send-email-yamada.masahiro@socionext.com>","References":"<1506480022-8995-1-git-send-email-yamada.masahiro@socionext.com>\n\t<1506480022-8995-3-git-send-email-yamada.masahiro@socionext.com>","From":"Linus Walleij ","Date":"Wed, 11 Oct 2017 10:40:58 +0200","Message-ID":"","Subject":"Re: [PATCH v6 2/2] gpio: uniphier: add UniPhier GPIO controller\n\tdriver","To":"Masahiro Yamada ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171011_014120_244545_B89F5B31 ","X-CRM114-Status":"GOOD ( 20.35 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Mark Rutland , Rob Herring ,\n\tJassi Brar ,\n\tGreg Kroah-Hartman ,\n\tRandy Dunlap ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"linux-gpio@vger.kernel.org\" ,\n\t\"devicetree@vger.kernel.org\" ,\n\tRob Herring ,\n\tMasami Hiramatsu , \n\tMauro Carvalho Chehab ,\n\t\"David S. Miller\" ,\n\t\"linux-arm-kernel@lists.infradead.org\"\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1784407,"web_url":"http://patchwork.ozlabs.org/comment/1784407/","msgid":"","list_archive_url":null,"date":"2017-10-11T08:43:06","subject":"Re: [PATCH v6 1/2] dt-bindings: gpio: uniphier: add UniPhier GPIO\n\tbinding","submitter":{"id":7055,"url":"http://patchwork.ozlabs.org/api/people/7055/","name":"Linus Walleij","email":"linus.walleij@linaro.org"},"content":"On Wed, Oct 11, 2017 at 10:35 AM, Linus Walleij\n wrote:\n> On Wed, Sep 27, 2017 at 4:40 AM, Masahiro Yamada\n> wrote:\n>\n>> This GPIO controller is used on UniPhier SoC family.\n>>\n>> The vendor specific property \"socionext,interrupt-ranges\" is for\n>> specifying interrupt mapping to the parent interrupt controller\n>> because the mapping is not contiguous. It works like \"ranges\",\n>> but transforms \"interrupts\" instead of \"reg\".\n>>\n>> Signed-off-by: Masahiro Yamada \n>> Acked-by: Rob Herring \n>\n> Patch applied.\n>\n>> +- socionext,interrupt-ranges: Specifies an interrupt number mapping between\n>> + this GPIO controller and its interrupt parent, in the form of arbitrary\n>> + number of triplets.\n> (...)\n>> + socionext,interrupt-ranges = <0 48 16>, <16 154 5>, <21 217 3>;\n>\n> Still uncertain about that thing.\n>\n> But as it is, you need running code, and we have rough consensus.\n>\n> So merging.\n>\n> If it turns out to be a bad binding we may need to patch in an alternative\n> later.\n\nSorry I had to take it back out, because the stuff in the\nother patch should also be in this patch rather than in the driver.\n\nPlease move that over here, and if you insist on those macros, also\nuse them in the example so we understand how this is supposed to\nbe used, i.e. also add a consumer node to the bindings example\nif it is gonna use magic macros.\n\nYours,\nLinus Walleij","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"Acd0seVO\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"P6eL6/Tz\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBnZH0Sfcz9t3H\n\tfor ;\n\tWed, 11 Oct 2017 19:43:35 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e2Cbz-0006BR-AQ; Wed, 11 Oct 2017 08:43:31 +0000","from mail-it0-x22b.google.com ([2607:f8b0:4001:c0b::22b])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e2Cbv-00066b-9B for linux-arm-kernel@lists.infradead.org;\n\tWed, 11 Oct 2017 08:43:28 +0000","by mail-it0-x22b.google.com with SMTP id k70so10012332itk.0\n\tfor ;\n\tWed, 11 Oct 2017 01:43:07 -0700 (PDT)","by 10.79.14.140 with HTTP; Wed, 11 Oct 2017 01:43:06 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=jnI0W8koHSytLm+F82v7OIqkbY3KhtZ3sFQ1CG6a7b8=;\n\tb=Acd0seVOV35hgz\n\t4EMHSaU+S+6bJDNKS+aHfiBrpfPGBKooiakZCRyODLIa4J3tN+e61TLf6WETcPdyZqRNMH0E1rPBE\n\tBU4jMOD/tFk+dkueOURjxylR4qYLrsGj/nghbeml1hsG2alEtAf8Hb2it7AUvp1ip7J+lvWz2KgCG\n\trNqh7wvz/zpO3KMRS7xRGltxSdAfyhc0duKP5x2s+wQ1V0byNjJ6m4KbSDz+P9EARcfjtoEqYarb8\n\tOIlHH5KHUmuJXyJsmx5qfG5kJv168uus+WJGt7qMWZkUl+9P4TDx7O55QH+ws/mr9go+mWw2Pee6y\n\thLG9fXWYwRmEFovEC1KQ==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=9ODSiFqwxMjbt9h8yYEepYg5SRquqGraEM4j0tdgPlI=;\n\tb=P6eL6/TzWfCbxqXMzc84g+eSvhFF9JyuEsfRmyr1oACMX+KIqKXx4kjvm9mlMO0DdJ\n\t0/CFoA9nc8t5OdSExJKKj2IcMOxIKbeZ+l31ilMYxWlRl/RVd5KdpdmVWTU5NA3jKPl0\n\tVmnyIRKjqUuZx5vVdvVg/UROmxxOV7pzq7wnY="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=9ODSiFqwxMjbt9h8yYEepYg5SRquqGraEM4j0tdgPlI=;\n\tb=D7kZbmfA2zNC+UTi8hJvfjiuM1WbGjLlaAM8ffQsofdE8077Jlfq2oPQrFqPtj/aEs\n\txfsmYe6TnI2NWhdsKUr8GLNfH4gJJdHYm5cTF4+/0HzhnP6eo+K+IBdJbj2FGEPFc2Hj\n\tCZDAseQdekNepxCIRx/zRmKIkXIgXnvIohYoqTKCQcYp5oOogr/GPfHMiQaCE2MJU4Ep\n\tNRHg7PCl/hhJk+NUnGlNn5M3Udv6uNvOJRVi4ecFLHjWHDyBLMcY4fo0jot2C1eyPWLL\n\tedz8ILvParATTmwOpjeQ983r8Fvbj4X/nHNseWhL0NoqujInBO4sY+vSSleeTtZ1k+A3\n\tC4WQ==","X-Gm-Message-State":"AMCzsaXZEATCxd/qQ0BJdT2AdCjlC8plrGC3x0gxsBV89IDBAPMQu9O9\n\tFH6v2ZmXBHiFJUDrUp6gF79ZxcaiQuNcT2rI0oueJw==","X-Google-Smtp-Source":"AOwi7QDGYoNnKFgr2fqPWC/bUWcTDrVY+kYUgcQVNud5g4NONt2TZkyoKobNmFx/Cw1jpHsrJSlu5HKD5hMvSdUQ0zA=","X-Received":"by 10.36.92.193 with SMTP id q184mr4120365itb.83.1507711386680; \n\tWed, 11 Oct 2017 01:43:06 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1506480022-8995-1-git-send-email-yamada.masahiro@socionext.com>\n\t<1506480022-8995-2-git-send-email-yamada.masahiro@socionext.com>\n\t","From":"Linus Walleij ","Date":"Wed, 11 Oct 2017 10:43:06 +0200","Message-ID":"","Subject":"Re: [PATCH v6 1/2] dt-bindings: gpio: uniphier: add UniPhier GPIO\n\tbinding","To":"Masahiro Yamada ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171011_014327_365403_9BDA7923 ","X-CRM114-Status":"GOOD ( 15.60 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Mark Rutland , Rob Herring ,\n\tJassi Brar ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"linux-gpio@vger.kernel.org\" ,\n\t\"devicetree@vger.kernel.org\" ,\n\tRob Herring ,\n\tMasami Hiramatsu , \n\t\"linux-arm-kernel@lists.infradead.org\"\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1784452,"web_url":"http://patchwork.ozlabs.org/comment/1784452/","msgid":"","list_archive_url":null,"date":"2017-10-11T09:38:48","subject":"Re: [PATCH v6 2/2] gpio: uniphier: add UniPhier GPIO controller\n\tdriver","submitter":{"id":65882,"url":"http://patchwork.ozlabs.org/api/people/65882/","name":"Masahiro Yamada","email":"yamada.masahiro@socionext.com"},"content":"2017-10-11 17:40 GMT+09:00 Linus Walleij :\n\n>\n>> +++ b/include/dt-bindings/gpio/uniphier-gpio.h\n>> @@ -0,0 +1,18 @@\n>> +/*\n>> + * Copyright (C) 2017 Socionext Inc.\n>> + * Author: Masahiro Yamada \n>> + */\n>> +\n>> +#ifndef _DT_BINDINGS_GPIO_UNIPHIER_H\n>> +#define _DT_BINDINGS_GPIO_UNIPHIER_H\n>> +\n>> +#define UNIPHIER_GPIO_LINES_PER_BANK 8\n>> +\n>> +#define UNIPHIER_GPIO_IRQ_OFFSET ((UNIPHIER_GPIO_LINES_PER_BANK) * 15)\n>> +\n>> +#define UNIPHIER_GPIO_PORT(bank, line) \\\n>> + ((UNIPHIER_GPIO_LINES_PER_BANK) * (bank) + (line))\n>> +\n>> +#define UNIPHIER_GPIO_IRQ(n) ((UNIPHIER_GPIO_IRQ_OFFSET) + (n))\n>> +\n>> +#endif /* _DT_BINDINGS_GPIO_UNIPHIER_H */\n>\n> I do not understand what some of these things are doing in the\n> device tree header file.\n> It just looks creepingly similar to some of the magic I've seen\n> in board files.\n\nBecause this hardware design is crazy crap.\n\nOnly the one's place of the GPIO labels is octal.\nThe other places are decimal.\n\n\n\n> It makes much more sense that the device trees either:\n>\n> - Use the interrupts as a flat array 0...N across all banks\n\nI think I did so.\n\nBut, please note only bank 15, 16, 17 can support irq.\n(and bank 15, 16, 17 share the same irq control register)\n\nNo irq support for bank 0-14, 18-31.\n\nNo symmetry in the hardware structure.\n\n\n> - Model each bank as a separate GPIO chip\n\nNo, no, never.\nI had already tried per-bank splitting approach,\nbut it was a horrible disaster.\n\nPlease note there would end up 31 banks if it were split.\n(31 nodes in DT)\n\nWhat is worse, registers from different banks interleave,\nand, in some places, share the same registers.\n\n\n\n> This is somewhere inbetween, you are modeling it as a single\n> gpiochip but still not, becuase the device tree author still need\n> to address banking, that is confusing.\n\nThis is the best solution I found.\n\n\n\nUnfortunately, the hardware specification adopts weird GPIO pin labeling.\nThe ports are named as\n PORT00, PORT01, PORT02, ..., PORT07,\n PORT10, PORT11, PORT12, ..., PORT17,\n PORT20, PORT21, PORT22, ..., PORT27,\n ...\n PORT90, PORT91, PORT92, ..., PORT97,\n PORT100, PORT101, PORT102, ..., PORT107,\n ...\n\n\nNo PORT08, PORT09, ...\nAs I said above, only the one's place is octal.","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"XwsFDx8y\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=nifty.com header.i=@nifty.com\n\theader.b=\"kkLm+BjC\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBprC0275z9s7g\n\tfor ;\n\tWed, 11 Oct 2017 20:40:42 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e2DVH-0003oJ-09; Wed, 11 Oct 2017 09:40:39 +0000","from conssluserg-01.nifty.com ([210.131.2.80])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e2DUr-0002Yn-FC for linux-arm-kernel@lists.infradead.org;\n\tWed, 11 Oct 2017 09:40:15 +0000","from mail-qt0-f174.google.com (mail-qt0-f174.google.com\n\t[209.85.216.174]) (authenticated)\n\tby conssluserg-01.nifty.com with ESMTP id v9B9dTMK031666\n\tfor ;\n\tWed, 11 Oct 2017 18:39:30 +0900","by mail-qt0-f174.google.com with SMTP id 8so3370505qtv.1\n\tfor ;\n\tWed, 11 Oct 2017 02:39:30 -0700 (PDT)","by 10.237.61.199 with HTTP; Wed, 11 Oct 2017 02:38:48 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=KP9u9DD8B9OKKlJDTQPOpp+wx+hwqdDzZHn4veIsSFE=;\n\tb=XwsFDx8yg10/ew\n\t5oPpN4IE8E41tr9mZezpCa5p53DiBsXRVS6fWGoeOg89tTD1bhAC8zBu0fZGZ37P98PfMry/a3tSY\n\tHKwp/bEVTbE4S3DQlf2SIKvfnZlNSNq6c8itvYcoHJ03lRu6OHMy2x7nWHm120WB1QQu8Lc38XJOM\n\t+ENImnUZz88/EuTMnun2HEGmLUFZ9nuqnAsLXkjC9BGzZ8PRThJZqy1/AjCFcjN8G7tgdGa/I9RtJ\n\tn6ilqkfYqb8yulFkoMoFTpNuP2bPQqzd7JHUeCwbOWA4FlM++emjcEG4ozRYQWG8/sE5uRcmzJC+o\n\tJ63gnSOa026NvBxC/jmA==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com;\n\ts=dec2015msa; t=1507714770;\n\tbh=OzTJexCurI+OiXXDJiRm1Is2luFooJh+MOS7k4l/QfI=;\n\th=In-Reply-To:References:From:Date:Subject:To:Cc:From;\n\tb=kkLm+BjC5uX0Sd7YsGtsVCeifEoCy1zI5pXnCQtqqMuLIh4nuvL73GBCHNBzzEwf+\n\tJ3SWemdLLM9TXId2zaWoO7dPOZYYrquHDrB8FbNv+6YEv5RQ30Q4aAOoXcqBL0gj1G\n\tpj+oFXpR1AkxpI14Imh/z0I3eKHFAo3lmO54U0R8sV39vwUL9d0YzACWKzI5ylJ7qN\n\tj0jNNZimnOHpp+VLnHyz3GnTOeVe77JwQAH+N4zcZWBO0ZRUpcLJ8obq8C/IYCVPNs\n\tQweZI4fr2f6R1Hzq5KfNQGg2ahhjotjTtg/wdQzDbbgyt2ChG6jTjzPt6WrwzbJUVH\n\tAxdpdMtuhTX2w=="],"DKIM-Filter":"OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com v9B9dTMK031666","X-Nifty-SrcIP":"[209.85.216.174]","X-Gm-Message-State":"AMCzsaWwDT3hf8s49OEkkOzRZNn4mDpnVvpnZVk3m9NYj4v/Kx1FTTQL\n\tq7GFr/9ohWh5i5BZAEZRJw1gMhxayxKoVcRhFpM=","X-Google-Smtp-Source":"AOwi7QBXpM8jjwnP5xIYqpW8zHWumJvO2Wa9bJ3uADo743SfMUmumuC+wInhH3M4Wp6yKOtq/8zuxR7Bn6eBxQAfoNg=","X-Received":"by 10.55.178.65 with SMTP id b62mr18517397qkf.348.1507714769193; \n\tWed, 11 Oct 2017 02:39:29 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1506480022-8995-1-git-send-email-yamada.masahiro@socionext.com>\n\t<1506480022-8995-3-git-send-email-yamada.masahiro@socionext.com>\n\t","From":"Masahiro Yamada ","Date":"Wed, 11 Oct 2017 18:38:48 +0900","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH v6 2/2] gpio: uniphier: add UniPhier GPIO controller\n\tdriver","To":"Linus Walleij ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171011_024013_771602_26F149FF ","X-CRM114-Status":"GOOD ( 14.47 )","X-Spam-Score":"-0.7 (/)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-0.7 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source\n\t[209.85.216.174 listed in dnsbl.sorbs.net]\n\t0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Mark Rutland , Rob Herring ,\n\tJassi Brar ,\n\tGreg Kroah-Hartman ,\n\tRandy Dunlap ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"linux-gpio@vger.kernel.org\" ,\n\t\"devicetree@vger.kernel.org\" ,\n\tRob Herring ,\n\tMasami Hiramatsu , \n\tMauro Carvalho Chehab ,\n\t\"David S. Miller\" ,\n\t\"linux-arm-kernel@lists.infradead.org\"\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]