[{"id":1775956,"web_url":"http://patchwork.ozlabs.org/comment/1775956/","msgid":"<28fd7053-eb5a-730e-b2db-33df44d6a3b6@gmail.com>","list_archive_url":null,"date":"2017-09-26T23:55:36","subject":"Re: [PATCH net-next 0/5] net: dsa: use generic slave phydev","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 09/26/2017 02:15 PM, Vivien Didelot wrote:\n> DSA currently stores a phy_device pointer in each slave private\n> structure. This requires to implement our own ethtool ksettings\n> accessors and such.\n> \n> This patchset removes the private phy_device in favor of the one\n> provided in the net_device structure, and thus allows us to use the\n> generic phy_ethtool_* functions.\n\nFor this series:\n\nTested-by: Florian Fainelli \n\nOn bcm_sf2 (7445 and 7278) along with the externally attached BCM53125\nswitch that needs the special MDIO read/write divert. We properly attach\nto the right PHY devices in all cases.\n\nAlso tested unbind/bind, working correctly.\n\nThanks!\n\n> \n> Vivien Didelot (5):\n> net: dsa: return -ENODEV is there is no slave PHY\n> net: dsa: use slave device phydev\n> net: dsa: use phy_ethtool_get_link_ksettings\n> net: dsa: use phy_ethtool_set_link_ksettings\n> net: dsa: use phy_ethtool_nway_reset\n> \n> net/dsa/dsa_priv.h | 1 -\n> net/dsa/slave.c | 143 +++++++++++++++++++----------------------------------\n> 2 files changed, 52 insertions(+), 92 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"RPnfS609\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1yWw3F4pz9t4X\n\tfor ;\n\tWed, 27 Sep 2017 09:55:56 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1032742AbdIZXzq (ORCPT );\n\tTue, 26 Sep 2017 19:55:46 -0400","from mail-wr0-f194.google.com ([209.85.128.194]:36201 \"EHLO\n\tmail-wr0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S966844AbdIZXzo (ORCPT\n\t); Tue, 26 Sep 2017 19:55:44 -0400","by mail-wr0-f194.google.com with SMTP id k10so151459wrk.3;\n\tTue, 26 Sep 2017 16:55:44 -0700 (PDT)","from [10.112.156.244] ([192.19.255.250])\n\tby smtp.googlemail.com with ESMTPSA id\n\ti10sm2075918wmf.14.2017.09.26.16.55.38\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 26 Sep 2017 16:55:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=HDkr88kGx++eSrFlxM2oi/hgNz1cC3Oxtm8KkHyTiMg=;\n\tb=RPnfS609tp9wWZ1iHASjnPbEwqUIkED8ANG+Lc0FEiAKLkTy6xESSpzWb5NUUvTX92\n\tEVAl5Zw4yWASRqA7CRiPsnRySRVkTCB4PZ7IwucvZfV3OeqZIxy1vktxEMk1EuSi4vU1\n\tNKq/NVAT4VuNczF9hknG4YIvfp2+8XMCWhwqA+HsAH4S6bfhYe7i3xGJauqE/VsXuu0m\n\tz1fzPe3tJpfduRXB9fHtO57XtzoDubXJrOhgYXcCqfK5Drwu4jvskPmupG5agBPAxfUK\n\t2MshQ5lbwshyJkEG/o+14FeIcqbE3JGj6qMxKg++snsJpFgDmilXudIDWt/ewtS0cPF0\n\tyzoQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=HDkr88kGx++eSrFlxM2oi/hgNz1cC3Oxtm8KkHyTiMg=;\n\tb=ZBmuhHfFfM6v1p6Hwq/AEIAXPo9by/wvvMcf6/2Ibi6diBKAA6emZ2KiY5vdNXeXGk\n\tJqZImo8/8mRh0RZg1BdkseXujWgkWmaanwHupvYLrOIIApniIQO4qqHN58nacLtY8n8r\n\taxJayKZbuR5acOFPrFsy9vD5j+JhGZDwqMXTp8I8fXEMVdkTMguBuoc2r8LaCo0sVp+O\n\tNAO2+IEtLjdzbWdqgDDwM8UJ6+hWeAz53X+uJdCRxbO81fbFI9D6Lw55NsAlm27C6e25\n\tQlxuKxiq0tlVbJtjAys55QsYWMrmqHZkmL6yjJwBdUjQa6pJ9j1fnV36C5hUnxiCFq5g\n\tRKTg==","X-Gm-Message-State":"AHPjjUhHVtTB8ioRGomni1ZYqGcLQQPVBVCNX8t1SPf3Z+AYI4ykrm0E\n\t/9WbYw33LeCOGoLusyTtFT0=","X-Google-Smtp-Source":"AOwi7QDfQQh92QKHPwqPrmaJCO6rmpqzdnch3n1OjEilr2LFOBJb2/oLvveZiCeqVzzr7L5GwONoXw==","X-Received":"by 10.223.138.238 with SMTP id z43mr9846412wrz.83.1506470143498; \n\tTue, 26 Sep 2017 16:55:43 -0700 (PDT)","Subject":"Re: [PATCH net-next 0/5] net: dsa: use generic slave phydev","To":"Vivien Didelot ,\n\tnetdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,\n\t\"David S. Miller\" , Andrew Lunn ","References":"<20170926211535.21273-1-vivien.didelot@savoirfairelinux.com>","From":"Florian Fainelli ","Message-ID":"<28fd7053-eb5a-730e-b2db-33df44d6a3b6@gmail.com>","Date":"Tue, 26 Sep 2017 16:55:36 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170926211535.21273-1-vivien.didelot@savoirfairelinux.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1775999,"web_url":"http://patchwork.ozlabs.org/comment/1775999/","msgid":"<20170926.200651.424252266139986002.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-27T03:06:51","subject":"Re: [PATCH net-next 0/5] net: dsa: use generic slave phydev","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Vivien Didelot \nDate: Tue, 26 Sep 2017 17:15:30 -0400\n\n> DSA currently stores a phy_device pointer in each slave private\n> structure. This requires to implement our own ethtool ksettings\n> accessors and such.\n> \n> This patchset removes the private phy_device in favor of the one\n> provided in the net_device structure, and thus allows us to use the\n> generic phy_ethtool_* functions.\n\nSeries applied, thanks Vivien.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y22mQ5kstz9t3B\n\tfor ;\n\tWed, 27 Sep 2017 13:07:02 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1031585AbdI0DGx (ORCPT );\n\tTue, 26 Sep 2017 23:06:53 -0400","from shards.monkeyblade.net ([184.105.139.130]:46642 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S966992AbdI0DGw (ORCPT\n\t); Tue, 26 Sep 2017 23:06:52 -0400","from localhost (74-93-104-102-Washington.hfc.comcastbusiness.net\n\t[74.93.104.102])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 8F0E2133FDE87;\n\tTue, 26 Sep 2017 20:06:51 -0700 (PDT)"],"Date":"Tue, 26 Sep 2017 20:06:51 -0700 (PDT)","Message-Id":"<20170926.200651.424252266139986002.davem@davemloft.net>","To":"vivien.didelot@savoirfairelinux.com","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tkernel@savoirfairelinux.com, f.fainelli@gmail.com, andrew@lunn.ch","Subject":"Re: [PATCH net-next 0/5] net: dsa: use generic slave phydev","From":"David Miller ","In-Reply-To":"<20170926211535.21273-1-vivien.didelot@savoirfairelinux.com>","References":"<20170926211535.21273-1-vivien.didelot@savoirfairelinux.com>","X-Mailer":"Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 26 Sep 2017 20:06:51 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]