[{"id":1775951,"web_url":"http://patchwork.ozlabs.org/comment/1775951/","msgid":"","list_archive_url":null,"date":"2017-09-26T23:10:59","subject":"Re: [Qemu-devel] [PATCH v1 0/6] s390x/tcg: fix some accesses using\n\tlow address","submitter":{"id":2222,"url":"http://patchwork.ozlabs.org/api/people/2222/","name":"Richard Henderson","email":"rth@twiddle.net"},"content":"On 09/26/2017 11:33 AM, David Hildenbrand wrote:\n> David Hildenbrand (6):\n> s390x/tcg: fix checking for invalid memory check\n> s390x/tcg: add MMU for real addresses\n> s390x/tcg: make lura(g) use the new _real mmu.\n> s390x/tcg: make stora(g) use the new _real mmu\n> s390x/tcg: make testblock use the new _real mmu\n> s390x/tcg: make idte/ipte use the new _real mmu\n\nReviewed-by: Richard Henderson \n\nWatch out for a couple of blank lines left over while deleting stuff.\nE.g.\n\n{\n\n code\n}\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"DrXJtPUa\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1xZ13mhYz9t3x\n\tfor ;\n\tWed, 27 Sep 2017 09:12:41 +1000 (AEST)","from localhost ([::1]:51422 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwz1r-0003nq-Li\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 19:12:39 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51976)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwz0N-0002ij-I2\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 19:11:08 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwz0K-0007e8-Bb\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 19:11:07 -0400","from mail-pf0-x232.google.com ([2607:f8b0:400e:c00::232]:45415)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dwz0K-0007dl-48\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 19:11:04 -0400","by mail-pf0-x232.google.com with SMTP id z84so6286632pfi.2\n\tfor ; Tue, 26 Sep 2017 16:11:04 -0700 (PDT)","from bigtime.twiddle.net ([70.35.39.2])\n\tby smtp.googlemail.com with ESMTPSA id\n\t28sm17897823pfl.14.2017.09.26.16.11.01\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 26 Sep 2017 16:11:01 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=4+D8Z8CePu7N2Z1RB5lHgspE/dmeVQj8oonH23QPDYE=;\n\tb=DrXJtPUa6h87D2RRGpbj+cGHieaU4Q+t9cZNOnzWNqY3lm/ZS+iUuSeG2cPJ8JG4MK\n\tVCOJLqTLcHw0Lhk0P3l4NW4EDXstv8Mc2mOLX2ufJgALVl+BhSSI4nIHcDmcPRwdnetg\n\tD5MUprRVAF7Dvaw6G7RmPsxggY9RusjzshFm827NcGBJZ4ahABbvV8SkFJ8/IUBg3Lmu\n\tNftsPvk/kNW/8QbE/fjxrMXH7dbGYteb5NPlrbURBUlYQYYG/W782/JRwNm+Fre7hD0y\n\t4opJ/9MvikGe0EuMZ1hRNSgikhDv+VK7OeUmH4HDGeu7xcm5PwwFY28Imj7JX/pPj7/2\n\tHAYA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=4+D8Z8CePu7N2Z1RB5lHgspE/dmeVQj8oonH23QPDYE=;\n\tb=XFbc0rFOceag0/2NJx+1WhWwxzitWfEtS2noeonQhFNENYRCFdoHV6mX8hKDJ9pEeK\n\tRi7HLpkOg3Dc69ABj5jTiQIGeRuObmxQiJHKAg7/Du+AMtnrDYNhW7fu6B/BQPHm2URQ\n\txkJlQEZYmRleVoOHySpKus6vkoMc9brrezXHorj2502WGnQJCmi3u1w56apmUHQZLHCM\n\t2bBKVNUq+0sr0ZuwTUWtDIt8Yq67B7SOAfCtdE1+H/By3BpbN8S3gzTWyluI3x0bFUmN\n\tNDbYCBTtrPFe4NEom+umoMK9vswLc2ULjXhObihgWIeUz4eUp7auW3dSwldyE9zFKyoX\n\tq3Yg==","X-Gm-Message-State":"AHPjjUiX87Opmk1e/AUtaKy4/Mc/rklIVp/Zx4BhZaiSi6KwZDYlYQK3\n\tWNlS1Ys3pJC+S3Fb8HMdA8c=","X-Google-Smtp-Source":"AOwi7QDCKCMfOIf6KtR8BvwelU/opaY2nSCG+PABXS795OtxULJbtMgfRYCyNATaXILZEzYtqAERAQ==","X-Received":"by 10.99.186.5 with SMTP id k5mr12290605pgf.31.1506467463040;\n\tTue, 26 Sep 2017 16:11:03 -0700 (PDT)","To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170926183318.12995-1-david@redhat.com>","From":"Richard Henderson ","Message-ID":"","Date":"Tue, 26 Sep 2017 16:10:59 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170926183318.12995-1-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c00::232","Subject":"Re: [Qemu-devel] [PATCH v1 0/6] s390x/tcg: fix some accesses using\n\tlow address","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Christian Borntraeger , thuth@redhat.com,\n\tcohuck@redhat.com, Alexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776093,"web_url":"http://patchwork.ozlabs.org/comment/1776093/","msgid":"<8b408306-1d36-7524-30aa-22aaa0a0eba4@redhat.com>","list_archive_url":null,"date":"2017-09-27T07:38:10","subject":"Re: [Qemu-devel] [PATCH v1 0/6] s390x/tcg: fix some accesses using\n\tlow address","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 27.09.2017 01:10, Richard Henderson wrote:\n> On 09/26/2017 11:33 AM, David Hildenbrand wrote:\n>> David Hildenbrand (6):\n>> s390x/tcg: fix checking for invalid memory check\n>> s390x/tcg: add MMU for real addresses\n>> s390x/tcg: make lura(g) use the new _real mmu.\n>> s390x/tcg: make stora(g) use the new _real mmu\n>> s390x/tcg: make testblock use the new _real mmu\n>> s390x/tcg: make idte/ipte use the new _real mmu\n> \n> Reviewed-by: Richard Henderson \n> \n> Watch out for a couple of blank lines left over while deleting stuff.\n\nYes, the HELPER(lura) hunk in the third patch has a superfluous empty\nline now. Apart from that, the series also looks good to me:\n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y28nz3R8Lz9t4b\n\tfor ;\n\tWed, 27 Sep 2017 17:38:47 +1000 (AEST)","from localhost ([::1]:52633 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dx6vd-0006Ge-Kk\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 03:38:45 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50441)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dx6vH-0006G4-Hj\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 03:38:24 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dx6vD-0008Pm-Ug\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 03:38:23 -0400","from mx1.redhat.com ([209.132.183.28]:48738)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dx6vD-0008Ou-M7\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 03:38:19 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 0658FC07998C;\n\tWed, 27 Sep 2017 07:38:16 +0000 (UTC)","from [10.36.117.38] (ovpn-117-38.ams2.redhat.com [10.36.117.38])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 95B347E8E7;\n\tWed, 27 Sep 2017 07:38:12 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 0658FC07998C","To":"Richard Henderson , David Hildenbrand\n\t, qemu-devel@nongnu.org","References":"<20170926183318.12995-1-david@redhat.com>\n\t","From":"Thomas Huth ","Message-ID":"<8b408306-1d36-7524-30aa-22aaa0a0eba4@redhat.com>","Date":"Wed, 27 Sep 2017 09:38:10 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tWed, 27 Sep 2017 07:38:16 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 0/6] s390x/tcg: fix some accesses using\n\tlow address","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Christian Borntraeger , cohuck@redhat.com,\n\tAlexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776274,"web_url":"http://patchwork.ozlabs.org/comment/1776274/","msgid":"<20170927134910.0ffccb7e.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-27T11:49:10","subject":"Re: [Qemu-devel] [PATCH v1 0/6] s390x/tcg: fix some accesses using\n\tlow address","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Tue, 26 Sep 2017 20:33:12 +0200\nDavid Hildenbrand wrote:\n\n> Conny reported that a guest Linux currently spits out:\n> \"The s390-virtio transport is deprecated. Please switch to a modern host\n> providing virtio-ccw.\"\n> \n> This is strange, because we have no legacy virtio transport in QEMU :)\n> \n> Main problem is, that a page is tested for acccess, and the test does not\n> fail. All memory access variants like stb_phys() will never fail. On\n> invalid memory, they simply do nothing.\n> \n> Linux uses lura for this check. Let's introduce a _real MMU that handles\n> prefixing and can later be used for things like low address protection.\n> \n> The other BUG is that a check for invalid memory is wrong. Therefore,\n> Patch 1 alone makes the guest crash when trying to initialize the\n> virtio transport. Crazy stuff.\n\nIndeed, thanks for hunting this down! No strange messages for me any\nmore :)\n\nFixed up the empty line in lura and applied to s390-next.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2GMY0lp5z9t66\n\tfor ;\n\tWed, 27 Sep 2017 21:49:44 +1000 (AEST)","from localhost ([::1]:54176 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxAqT-0005W5-Je\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 07:49:41 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60347)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxAqA-0005Vo-Kx\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 07:49:23 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxAq5-0008Ai-OQ\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 07:49:22 -0400","from mx1.redhat.com ([209.132.183.28]:36486)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxAq5-0008AJ-Hy\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 07:49:17 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4C580806AF;\n\tWed, 27 Sep 2017 11:49:16 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 0EB9B782BD;\n\tWed, 27 Sep 2017 11:49:12 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4C580806AF","Date":"Wed, 27 Sep 2017 13:49:10 +0200","From":"Cornelia Huck ","To":"David Hildenbrand ","Message-ID":"<20170927134910.0ffccb7e.cohuck@redhat.com>","In-Reply-To":"<20170926183318.12995-1-david@redhat.com>","References":"<20170926183318.12995-1-david@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tWed, 27 Sep 2017 11:49:16 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 0/6] s390x/tcg: fix some accesses using\n\tlow address","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Christian Borntraeger , thuth@redhat.com,\n\tRichard Henderson , qemu-devel@nongnu.org,\n\tAlexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]