[{"id":1787751,"web_url":"http://patchwork.ozlabs.org/comment/1787751/","msgid":"","list_archive_url":null,"date":"2017-10-16T21:19:50","subject":"Re: [PATCH v4 pci 0/2] PCI/MSI: pci-xgene-msi: Enable MSI support in\n\tACPI boot for X-Gene v1","submitter":{"id":71514,"url":"http://patchwork.ozlabs.org/api/people/71514/","name":"Khuong Dinh","email":"kdinh@apm.com"},"content":"Hi Lorenzo,\n Do you have any comments for this patch?\n\nBest regards,\nKhuong Dinh\n\nOn Tue, Sep 26, 2017 at 10:49 AM, Khuong Dinh wrote:\n> This patch set enables ACPI MSI support for X-Gene PCIe v1 hardware\n> and provides the proper MSI driver initialization ordering.\n>\n> Signed-off-by: Khuong Dinh \n> ---\n> v4:\n> - Remove Marc Zyngier ACK in v2\n> - Use acpi_bus_scan on MSI controller handle when MSI device is found\n> - Register ACPI MSI driver when MSI device is found instead of using\n> subsys_initcall\n> - Split ACPI MSI driver support into two patches - one to enable MSI\n> support for X-Gene PCIe v1 hardware, one to enforce MSI driver loaded\n> before PCIe controller driver in ACPI boot mode\n> v3:\n> - Input X-Gene MSI base address for irq_domain_alloc_fwnode\n> - Add a hook to enforce X-Gene MSI be probed prior acpi_bus_scan happens\n> v2:\n> - Verify with BIOS version 3.06.25 and 3.07.09\n> v1:\n> - Initial version\n> ---\n>\n> Khuong Dinh (2):\n> PCI/MSI: pci-xgene-msi: Enable MSI support in ACPI boot for X-Gene v1\n> PCI/MSI: Enforce MSI driver loaded before PCIe in ACPI boot\n>\n> drivers/acpi/Makefile | 2 +-\n> drivers/acpi/acpi_msi.c | 86 ++++++++++++++++++++++++++++++++++++++\n> drivers/acpi/acpi_platform.c | 3 +-\n> drivers/acpi/internal.h | 1 +\n> drivers/acpi/scan.c | 1 +\n> drivers/pci/host/pci-xgene-msi.c | 60 ++++++++++++++++++++++++--\n> include/linux/acpi_msi.h | 37 ++++++++++++++++\n> 7 files changed, 183 insertions(+), 7 deletions(-)\n> create mode 100644 drivers/acpi/acpi_msi.c\n> create mode 100644 include/linux/acpi_msi.h\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=apm.com header.i=@apm.com header.b=\"bFHwGwG5\";\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yGB7p0QTFz9sPk\n\tfor ;\n\tTue, 17 Oct 2017 08:20:54 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1757683AbdJPVTx (ORCPT );\n\tMon, 16 Oct 2017 17:19:53 -0400","from mail-pf0-f180.google.com ([209.85.192.180]:46366 \"EHLO\n\tmail-pf0-f180.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1757678AbdJPVTv (ORCPT\n\t); Mon, 16 Oct 2017 17:19:51 -0400","by mail-pf0-f180.google.com with SMTP id p87so16726736pfj.3\n\tfor ; Mon, 16 Oct 2017 14:19:51 -0700 (PDT)","by 10.100.180.76 with HTTP; Mon, 16 Oct 2017 14:19:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=apm.com; s=apm;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=riJi6sEtreEx/0AYocjPYUcLaBrZsEerGse+G5Dt/aI=;\n\tb=bFHwGwG58uvXNkhxhFIy/QACWa+27NoIz9l+NkHjLQRw/2A1ovAEA2yrMZhTtoROEv\n\t4gYjRRVgmhSupHTOwXb0sigdx7eVw9sz3izjjxOe9XmPhhodqXEXCXPXv+ocSVix/g3h\n\tYdQ/BuOLcxzenhc8V+1KRiAtVnzej6RxdNC/E=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=riJi6sEtreEx/0AYocjPYUcLaBrZsEerGse+G5Dt/aI=;\n\tb=tBomA/2KTwsq29hfTXyf2JUUi27YDPCj8u4bdquQpyhlKIlHuqr+Ms26q/zKCJSsmY\n\tTSLBtad5RsoWyZhyVz1nxRQC1GlLXFWrSRt4D/14lvJerxcEleyt0L6d0GGSuqmpYsA5\n\t+QroEweZEmN1Sh08/1r/JIWjhDYFCIrVZ2UfwmTzvUKvqSW67cV+qTzO7Zej94PSKs88\n\tUAmWr+i8L8CwYN8nRHzQpE5C908aRNtAK/oYvU9PNT5KFwh5UwBFAAjE6WC6BCzeX+7Q\n\tCHnu7XhZXeOlL5/aOhsC0j4rLN1ari+hasBtu5mZizLV36acjXgtql0bRVlN1Wh+OpUu\n\tVxfg==","X-Gm-Message-State":"AMCzsaW5jtzyPSabGz2O4/yYSDkU9vvq9li2+8to2P0uCSYq6Ygl9Wqw\n\tRX9WezLsBw2oBIyczLsigp0HSFwLDHJycBreJb3rjA==","X-Google-Smtp-Source":"AOwi7QAmXMDEvB20b7/o7JXGV4nsYLK1Ld0O2Fh5LvWgHPBE/fsWSVlu9gD8YU4pjpCLtgZImDIj20wno+b4IV9vk9s=","X-Received":"by 10.98.178.22 with SMTP id x22mr9983897pfe.123.1508188790922; \n\tMon, 16 Oct 2017 14:19:50 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1506448161-30961-1-git-send-email-kdinh@apm.com>","References":"<1506448161-30961-1-git-send-email-kdinh@apm.com>","From":"Khuong Dinh ","Date":"Mon, 16 Oct 2017 14:19:50 -0700","Message-ID":"","Subject":"Re: [PATCH v4 pci 0/2] PCI/MSI: pci-xgene-msi: Enable MSI support in\n\tACPI boot for X-Gene v1","To":"Lorenzo Pieralisi ,\n\tMarc Zyngier , msalter@redhat.com,\n\tBjorn Helgaas , linux-pci@vger.kernel.org,\n\tjcm@redhat.com","Cc":"patches , linux-kernel@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, rjw@rjwysocki.net,\n\tKhuong Dinh ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1788415,"web_url":"http://patchwork.ozlabs.org/comment/1788415/","msgid":"<20171017133807.GB948@red-moon>","list_archive_url":null,"date":"2017-10-17T13:38:07","subject":"Re: [PATCH v4 pci 0/2] PCI/MSI: pci-xgene-msi: Enable MSI support in\n\tACPI boot for X-Gene v1","submitter":{"id":5388,"url":"http://patchwork.ozlabs.org/api/people/5388/","name":"Lorenzo Pieralisi","email":"Lorenzo.Pieralisi@arm.com"},"content":"Hi Khuong,\n\nOn Mon, Oct 16, 2017 at 02:19:50PM -0700, Khuong Dinh wrote:\n> Hi Lorenzo,\n> Do you have any comments for this patch?\n\nI'd have some comments but given that there are related issues with ACPI\nprobe ordering that Marc is trying to solve on his side - I will work\nwith him to see if we can accommodate changes that can solve this issue\ntoo.\n\nAgain - I recognize it is a complex problem (that is not even\ncontemplated by the current ACPI specs), we have to try to make\nthe solution as generic as we can to prevent reinventing the wheel\nanytime a sligthly different issue (related to ACPI probe ordering)\ncomes up.\n\nLeave it to me (us) and I will get back to you on this.\n\nThanks,\nLorenzo\n\n> Best regards,\n> Khuong Dinh\n> \n> On Tue, Sep 26, 2017 at 10:49 AM, Khuong Dinh wrote:\n> > This patch set enables ACPI MSI support for X-Gene PCIe v1 hardware\n> > and provides the proper MSI driver initialization ordering.\n> >\n> > Signed-off-by: Khuong Dinh \n> > ---\n> > v4:\n> > - Remove Marc Zyngier ACK in v2\n> > - Use acpi_bus_scan on MSI controller handle when MSI device is found\n> > - Register ACPI MSI driver when MSI device is found instead of using\n> > subsys_initcall\n> > - Split ACPI MSI driver support into two patches - one to enable MSI\n> > support for X-Gene PCIe v1 hardware, one to enforce MSI driver loaded\n> > before PCIe controller driver in ACPI boot mode\n> > v3:\n> > - Input X-Gene MSI base address for irq_domain_alloc_fwnode\n> > - Add a hook to enforce X-Gene MSI be probed prior acpi_bus_scan happens\n> > v2:\n> > - Verify with BIOS version 3.06.25 and 3.07.09\n> > v1:\n> > - Initial version\n> > ---\n> >\n> > Khuong Dinh (2):\n> > PCI/MSI: pci-xgene-msi: Enable MSI support in ACPI boot for X-Gene v1\n> > PCI/MSI: Enforce MSI driver loaded before PCIe in ACPI boot\n> >\n> > drivers/acpi/Makefile | 2 +-\n> > drivers/acpi/acpi_msi.c | 86 ++++++++++++++++++++++++++++++++++++++\n> > drivers/acpi/acpi_platform.c | 3 +-\n> > drivers/acpi/internal.h | 1 +\n> > drivers/acpi/scan.c | 1 +\n> > drivers/pci/host/pci-xgene-msi.c | 60 ++++++++++++++++++++++++--\n> > include/linux/acpi_msi.h | 37 ++++++++++++++++\n> > 7 files changed, 183 insertions(+), 7 deletions(-)\n> > create mode 100644 drivers/acpi/acpi_msi.c\n> > create mode 100644 include/linux/acpi_msi.h\n> >","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yGbqS3hDGz9s8J\n\tfor ;\n\tWed, 18 Oct 2017 00:38:12 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754873AbdJQNiK (ORCPT );\n\tTue, 17 Oct 2017 09:38:10 -0400","from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:47016 \"EHLO\n\tfoss.arm.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1754603AbdJQNiK (ORCPT );\n\tTue, 17 Oct 2017 09:38:10 -0400","from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A8B231529;\n\tTue, 17 Oct 2017 06:38:09 -0700 (PDT)","from red-moon (red-moon.cambridge.arm.com [10.1.206.55])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n\tDB9503F483; Tue, 17 Oct 2017 06:38:07 -0700 (PDT)"],"Date":"Tue, 17 Oct 2017 14:38:07 +0100","From":"Lorenzo Pieralisi ","To":"Khuong Dinh ","Cc":"Marc Zyngier , msalter@redhat.com,\n\tBjorn Helgaas , linux-pci@vger.kernel.org,\n\tjcm@redhat.com, patches ,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\trjw@rjwysocki.net","Subject":"Re: [PATCH v4 pci 0/2] PCI/MSI: pci-xgene-msi: Enable MSI support in\n\tACPI boot for X-Gene v1","Message-ID":"<20171017133807.GB948@red-moon>","References":"<1506448161-30961-1-git-send-email-kdinh@apm.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.5.21 (2010-09-15)","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1788661,"web_url":"http://patchwork.ozlabs.org/comment/1788661/","msgid":"<20171017170529.GC5641@bhelgaas-glaptop.roam.corp.google.com>","list_archive_url":null,"date":"2017-10-17T17:05:29","subject":"Re: [PATCH v4 pci 0/2] PCI/MSI: pci-xgene-msi: Enable MSI support in\n\tACPI boot for X-Gene v1","submitter":{"id":67298,"url":"http://patchwork.ozlabs.org/api/people/67298/","name":"Bjorn Helgaas","email":"helgaas@kernel.org"},"content":"On Tue, Sep 26, 2017 at 11:49:19AM -0600, Khuong Dinh wrote:\n> This patch set enables ACPI MSI support for X-Gene PCIe v1 hardware\n> and provides the proper MSI driver initialization ordering.\n> \n> Signed-off-by: Khuong Dinh \n> ---\n> v4:\n> - Remove Marc Zyngier ACK in v2\n> - Use acpi_bus_scan on MSI controller handle when MSI device is found\n> - Register ACPI MSI driver when MSI device is found instead of using\n> subsys_initcall\n> - Split ACPI MSI driver support into two patches - one to enable MSI\n> support for X-Gene PCIe v1 hardware, one to enforce MSI driver loaded\n> before PCIe controller driver in ACPI boot mode\n> v3:\n> - Input X-Gene MSI base address for irq_domain_alloc_fwnode\n> - Add a hook to enforce X-Gene MSI be probed prior acpi_bus_scan happens\n> v2:\n> - Verify with BIOS version 3.06.25 and 3.07.09\n> v1:\n> - Initial version\n> ---\n> \n> Khuong Dinh (2):\n> PCI/MSI: pci-xgene-msi: Enable MSI support in ACPI boot for X-Gene v1\n> PCI/MSI: Enforce MSI driver loaded before PCIe in ACPI boot\n> \n> drivers/acpi/Makefile | 2 +-\n> drivers/acpi/acpi_msi.c | 86 ++++++++++++++++++++++++++++++++++++++\n> drivers/acpi/acpi_platform.c | 3 +-\n> drivers/acpi/internal.h | 1 +\n> drivers/acpi/scan.c | 1 +\n> drivers/pci/host/pci-xgene-msi.c | 60 ++++++++++++++++++++++++--\n> include/linux/acpi_msi.h | 37 ++++++++++++++++\n> 7 files changed, 183 insertions(+), 7 deletions(-)\n> create mode 100644 drivers/acpi/acpi_msi.c\n> create mode 100644 include/linux/acpi_msi.h\n\nThe changelogs don't really give the nitty-gritty details of the\nproblem, e.g., apparently the host bridge and the MSI controller are\nenumerated as two separate devices and there's an ordering issue with\nbinding drivers to them.\n\nThey should also contrast the X-Gene situation with other systems so we\ncan see why X-Gene has this problem when other systems don't.\n\nI'm not thrilled about all the ACPI code this adds, but I'm guessing\nthere'll be some better solution eventually.\n\nI'm going to mark these as \"changes requested\" even though I haven't\nasked for anything specific to be changed because it sounds like\nLorenzo et al. may have more concrete proposals soon.\n\nAre there currently systems that do not work and need to be fixed\nASAP?\n\nBjorn","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=helgaas@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yGhQj6s7xz9sRW\n\tfor ;\n\tWed, 18 Oct 2017 04:05:33 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S934171AbdJQRFc (ORCPT );\n\tTue, 17 Oct 2017 13:05:32 -0400","from mail.kernel.org ([198.145.29.99]:59448 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S934141AbdJQRFb (ORCPT );\n\tTue, 17 Oct 2017 13:05:31 -0400","from localhost (unknown [69.55.156.165])\n\t(using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits))\n\t(No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id B35FB218B2;\n\tTue, 17 Oct 2017 17:05:30 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org B35FB218B2","Date":"Tue, 17 Oct 2017 12:05:29 -0500","From":"Bjorn Helgaas ","To":"Khuong Dinh ","Cc":"lorenzo.pieralisi@arm.com, marc.zyngier@arm.com,\n\tmsalter@redhat.com, bhelgaas@google.com, linux-pci@vger.kernel.org,\n\tjcm@redhat.com, rjw@rjwysocki.net, patches@apm.com,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org","Subject":"Re: [PATCH v4 pci 0/2] PCI/MSI: pci-xgene-msi: Enable MSI support in\n\tACPI boot for X-Gene v1","Message-ID":"<20171017170529.GC5641@bhelgaas-glaptop.roam.corp.google.com>","References":"<1506448161-30961-1-git-send-email-kdinh@apm.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1506448161-30961-1-git-send-email-kdinh@apm.com>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1789154,"web_url":"http://patchwork.ozlabs.org/comment/1789154/","msgid":"","list_archive_url":null,"date":"2017-10-18T05:45:35","subject":"Re: [PATCH v4 pci 0/2] PCI/MSI: pci-xgene-msi: Enable MSI support in\n\tACPI boot for X-Gene v1","submitter":{"id":71514,"url":"http://patchwork.ozlabs.org/api/people/71514/","name":"Khuong Dinh","email":"kdinh@apm.com"},"content":"Hi Lorenzo,\n\nOn Tue, Oct 17, 2017 at 6:38 AM, Lorenzo Pieralisi\n wrote:\n> Hi Khuong,\n>\n> On Mon, Oct 16, 2017 at 02:19:50PM -0700, Khuong Dinh wrote:\n>> Hi Lorenzo,\n>> Do you have any comments for this patch?\n>\n> I'd have some comments but given that there are related issues with ACPI\n> probe ordering that Marc is trying to solve on his side - I will work\n> with him to see if we can accommodate changes that can solve this issue\n> too.\n>\n> Again - I recognize it is a complex problem (that is not even\n> contemplated by the current ACPI specs), we have to try to make\n> the solution as generic as we can to prevent reinventing the wheel\n> anytime a sligthly different issue (related to ACPI probe ordering)\n> comes up.\n>\n> Leave it to me (us) and I will get back to you on this.\n\nThanks for helping to take care of the generic ACPI probe ordering issue.\nGiven that the patch 'PCI/MSI: pci-xgene-msi: Enable MSI support in ACPI\nboot for X-Gene v1\" adds only the ACPI ID, can you pull in this patch\nindependently from the ACPI probe ordering issue?\n\nBest regards,\nKhuong Dinh\n\n> Thanks,\n> Lorenzo\n>\n>> Best regards,\n>> Khuong Dinh\n>>\n>> On Tue, Sep 26, 2017 at 10:49 AM, Khuong Dinh wrote:\n>> > This patch set enables ACPI MSI support for X-Gene PCIe v1 hardware\n>> > and provides the proper MSI driver initialization ordering.\n>> >\n>> > Signed-off-by: Khuong Dinh \n>> > ---\n>> > v4:\n>> > - Remove Marc Zyngier ACK in v2\n>> > - Use acpi_bus_scan on MSI controller handle when MSI device is found\n>> > - Register ACPI MSI driver when MSI device is found instead of using\n>> > subsys_initcall\n>> > - Split ACPI MSI driver support into two patches - one to enable MSI\n>> > support for X-Gene PCIe v1 hardware, one to enforce MSI driver loaded\n>> > before PCIe controller driver in ACPI boot mode\n>> > v3:\n>> > - Input X-Gene MSI base address for irq_domain_alloc_fwnode\n>> > - Add a hook to enforce X-Gene MSI be probed prior acpi_bus_scan happens\n>> > v2:\n>> > - Verify with BIOS version 3.06.25 and 3.07.09\n>> > v1:\n>> > - Initial version\n>> > ---\n>> >\n>> > Khuong Dinh (2):\n>> > PCI/MSI: pci-xgene-msi: Enable MSI support in ACPI boot for X-Gene v1\n>> > PCI/MSI: Enforce MSI driver loaded before PCIe in ACPI boot\n>> >\n>> > drivers/acpi/Makefile | 2 +-\n>> > drivers/acpi/acpi_msi.c | 86 ++++++++++++++++++++++++++++++++++++++\n>> > drivers/acpi/acpi_platform.c | 3 +-\n>> > drivers/acpi/internal.h | 1 +\n>> > drivers/acpi/scan.c | 1 +\n>> > drivers/pci/host/pci-xgene-msi.c | 60 ++++++++++++++++++++++++--\n>> > include/linux/acpi_msi.h | 37 ++++++++++++++++\n>> > 7 files changed, 183 insertions(+), 7 deletions(-)\n>> > create mode 100644 drivers/acpi/acpi_msi.c\n>> > create mode 100644 include/linux/acpi_msi.h\n>> >","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=apm.com header.i=@apm.com header.b=\"G77kLRCq\";\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yH1Hy36fTz9t3Z\n\tfor ;\n\tWed, 18 Oct 2017 16:45:50 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S966458AbdJRFpk (ORCPT );\n\tWed, 18 Oct 2017 01:45:40 -0400","from mail-pg0-f49.google.com ([74.125.83.49]:46310 \"EHLO\n\tmail-pg0-f49.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S966453AbdJRFph (ORCPT\n\t); Wed, 18 Oct 2017 01:45:37 -0400","by mail-pg0-f49.google.com with SMTP id k7so3375463pga.3\n\tfor ; Tue, 17 Oct 2017 22:45:37 -0700 (PDT)","by 10.100.180.76 with HTTP; Tue, 17 Oct 2017 22:45:35 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=apm.com; s=apm;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=oD8RAE5/EV9oe8E9B4ejujy/n0aGS3DmYPT5t+D2ncM=;\n\tb=G77kLRCqM8FCY+6hrx3KuBJM34IfncVopN1TdwcYSz6aUPHDTfXyg+ywvmbDsj4fUS\n\tiMhq8aH28jfelYjkoC7SY2GQ/GcSjX1ammQcYL4048A991jw8jQRURHK4Ht9FowY00Xv\n\teIurbzMbSCcX1kyh7MpQ2NWXBgOustvBWwMb4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=oD8RAE5/EV9oe8E9B4ejujy/n0aGS3DmYPT5t+D2ncM=;\n\tb=BwrkZFkUPaNck+XU+okFiCp0CkWzZj+ye11X7UuzOhAW0yyWCPJbiHAn3o7Z2TxN2k\n\te/xNfICBIPv3xyYLo1UfJTOIo1b4yfdxz3OK6xvCbp4nark9qRUaAChQu/rbroKH5Hb1\n\tyGvgN6aKlcvicJXafFZf07+IodfZBPEz5pJ5XrU/P9Al0+tj8OqCaAEMdFFYARoek2Uf\n\tkHK+LRc0eTrRUP8lOy3ae4DSSc5XnpyFUxp1EOqlRjrMLp8yiQI9aJQOnlbx74BbOx/f\n\tEiPVJEpnwBALACm8jW5S27/gPKLoSX/Nlnfnv0cne+W1zlo8++ETB57tGoL+haLRJHTl\n\t9X9w==","X-Gm-Message-State":"AMCzsaWhAeRGTFVODv8Vz9Z/HWKJiTRYecYEwGOAqT9A4CSDQC11VRJA\n\tWhp+rAKLETlRKiA7NgoO6iij32f6IBuXAgAD+EUNRQ==","X-Google-Smtp-Source":"AOwi7QAb1eRvsJHZXUU52gf3HMCkbw9HxPsQFQ1ZUQDMTOFK+GewwitqNq4wmaE4oHtECZ34f7DogLy92z5v/vSP8Ls=","X-Received":"by 10.98.7.210 with SMTP id 79mr13625074pfh.252.1508305536221;\n\tTue, 17 Oct 2017 22:45:36 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20171017133807.GB948@red-moon>","References":"<1506448161-30961-1-git-send-email-kdinh@apm.com>\n\t\n\t<20171017133807.GB948@red-moon>","From":"Khuong Dinh ","Date":"Tue, 17 Oct 2017 22:45:35 -0700","Message-ID":"","Subject":"Re: [PATCH v4 pci 0/2] PCI/MSI: pci-xgene-msi: Enable MSI support in\n\tACPI boot for X-Gene v1","To":"Lorenzo Pieralisi ","Cc":"Marc Zyngier , msalter@redhat.com,\n\tBjorn Helgaas , linux-pci@vger.kernel.org,\n\tjcm@redhat.com, patches ,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\trjw@rjwysocki.net","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1789269,"web_url":"http://patchwork.ozlabs.org/comment/1789269/","msgid":"<20171018090716.GA14820@red-moon>","list_archive_url":null,"date":"2017-10-18T09:07:16","subject":"Re: [PATCH v4 pci 0/2] PCI/MSI: pci-xgene-msi: Enable MSI support in\n\tACPI boot for X-Gene v1","submitter":{"id":5388,"url":"http://patchwork.ozlabs.org/api/people/5388/","name":"Lorenzo Pieralisi","email":"Lorenzo.Pieralisi@arm.com"},"content":"On Tue, Oct 17, 2017 at 10:45:35PM -0700, Khuong Dinh wrote:\n> Hi Lorenzo,\n>\n> On Tue, Oct 17, 2017 at 6:38 AM, Lorenzo Pieralisi\n> wrote:\n> > Hi Khuong,\n> >\n> > On Mon, Oct 16, 2017 at 02:19:50PM -0700, Khuong Dinh wrote:\n> >> Hi Lorenzo,\n> >> Do you have any comments for this patch?\n> >\n> > I'd have some comments but given that there are related issues with ACPI\n> > probe ordering that Marc is trying to solve on his side - I will work\n> > with him to see if we can accommodate changes that can solve this issue\n> > too.\n> >\n> > Again - I recognize it is a complex problem (that is not even\n> > contemplated by the current ACPI specs), we have to try to make\n> > the solution as generic as we can to prevent reinventing the wheel\n> > anytime a sligthly different issue (related to ACPI probe ordering)\n> > comes up.\n> >\n> > Leave it to me (us) and I will get back to you on this.\n>\n> Thanks for helping to take care of the generic ACPI probe ordering issue.\n> Given that the patch 'PCI/MSI: pci-xgene-msi: Enable MSI support in ACPI\n> boot for X-Gene v1\" adds only the ACPI ID, can you pull in this patch\n> independently from the ACPI probe ordering issue?\n\nNo. For two reasons:\n\n1) It's Bjorn who decides whether that code can be merged or not, not\n me\n2) That patch sneaks in ACPI MSI support for X-gene v1 that depends\n on kernel link ordering. As soon as it is pulled in the mainline\n it creates a dependency on pseudo-working code that may break\n anytime and as I said many times before I am not willing to rely\n on that.\n\nLorenzo\nIMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=armh.onmicrosoft.com\n\theader.i=@armh.onmicrosoft.com header.b=\"N0J+Ij11\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=Lorenzo.Pieralisi@arm.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yH5ms6Tmlz9t39\n\tfor ;\n\tWed, 18 Oct 2017 20:07:41 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S934238AbdJRJHV (ORCPT );\n\tWed, 18 Oct 2017 05:07:21 -0400","from mail-db5eur01on0081.outbound.protection.outlook.com\n\t([104.47.2.81]:21249\n\t\"EHLO EUR01-DB5-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S932715AbdJRJHQ (ORCPT );\n\tWed, 18 Oct 2017 05:07:16 -0400","from red-moon (217.140.96.140) by\n\tDB6PR08MB2919.eurprd08.prod.outlook.com (2603:10a6:6:25::28) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7;\n\tWed, 18 Oct 2017 09:07:13 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;\n\ts=selector1-arm-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=0IESXTOp5pnO6R18R+HsFMAg05/2UeZL5X4QY1xGyNc=;\n\tb=N0J+Ij113TPMH2OA/f7EMlw14aXCIxO60HwMMNMSjAqUvd1OfI2cc1WGRc+zOjt8+HblPKW58AuXMgaOCLgsulb4RdsCcQXMeo4b6h8hI2UqQW8V4XTX+2BNAN33yV1oLHR65j3+Gu0VH4ePvhKgn3dQ1hDC+nZOVn3iRxMIxFk=","Date":"Wed, 18 Oct 2017 10:07:16 +0100","From":"Lorenzo Pieralisi ","To":"Khuong Dinh ","Cc":"Marc Zyngier , msalter@redhat.com,\n\tBjorn Helgaas , linux-pci@vger.kernel.org,\n\tjcm@redhat.com, patches ,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\trjw@rjwysocki.net","Subject":"Re: [PATCH v4 pci 0/2] PCI/MSI: pci-xgene-msi: Enable MSI support in\n\tACPI boot for X-Gene v1","Message-ID":"<20171018090716.GA14820@red-moon>","References":"<1506448161-30961-1-git-send-email-kdinh@apm.com>\n\t\n\t<20171017133807.GB948@red-moon>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.5.21 (2010-09-15)","X-Originating-IP":"[217.140.96.140]","X-ClientProxiedBy":"AM5P194CA0024.EURP194.PROD.OUTLOOK.COM\n\t(2603:10a6:203:8f::34) To DB6PR08MB2919.eurprd08.prod.outlook.com\n\t(2603:10a6:6:25::28)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"8943431b-f761-4409-7c3d-08d516079fd7","X-MS-Office365-Filtering-HT":"Tenant","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);\n\tSRVR:DB6PR08MB2919; ","X-Microsoft-Exchange-Diagnostics":["1; DB6PR08MB2919;\n\t3:MIYTbFlFw5H/vbu7tNGbRisHDnZ4RJ3M3Y9oHQNestPztO0XyWJkcyOfnp9M5jGHUH7iwyCxpcPqq2rOfexG2HdoetCOQYLOp6kVmXtmKXfSrZM4rGj4RyoNlyN2VKBiG1KGFauDAuU0wP9YvW2PEYUqgvg7oeR2r4qneU88WNd7OJcev0tkWsH3g/o5RFxDHINwGVOKkNMCf3CYRTV9au9B3Y4x832Qn8bakI6UGM0GOLngQtWGRAkuWzyIaEkS;\n\t25:6hNIdTI9iutOmaNTuWjysMNYRS2nS9jF4OKpf2deUUESipAPz65WDTzTd559Sl2T+Uu8bU03oFmKfBhrR669zl5iYOdh7mx9XbRgp5xo0fOvpC+0X2MHpuBWeczJx1Qd9XZ0IY4D78M1wbW3baGMU0fzK1jaE2bhLJ9r71cROT2+ylLOLyFCvy4ESe63xseAu0bW3tR7dOAGjs7Ql/GNFgeq3ZtI6SEkp0WdcKQTMthekBbfXoQqQb9chtgG5qJPUkuUAtWZKjqDP7UsIHfT4VkpDwW+t1ZRkr5oICpUr+k1q8k0svUDpjXk6F1nnAdT0Ux5QzFx7+BAVWGAmVdhKA==;\n\t31:H6hbiZ83mTxkX4eR4/+i/O6AYteN+CRzqnlXoEk1T1upN+3gCQ0hPHHX1Hfr3aMY5jMcHHgKPqsTisMfipvtmAKUbFoW1SGO537T1RfkKomyOhCyC/J+Ydum6ADq0no0RC57ad1xUQXB5vNKlPK23tl/11Unkq4XCtgm97LcWYugbCe803o7ANhtWBmxGRZwK1JPHrGCIB0SL1hgCBvkCCKKXkyV+CsVOnVgvaacCMg=","1; DB6PR08MB2919;\n\t20:q/GnD61g5E+tp2jgIPKJfEKs26GIqtfr9uRjivr6m1zE3evSpocGpqNEDMuHvSq/4SsX/Dkmg4nMxcupEPM9Gur+t3CK83KO8q9EHAyxqJAr5kr75fYAtt6CqI/50sGvF1NlQRSu33oauhuTTolciqqMmdUbvoY0zV+5h/vvYSe7TwEBs4NhaLx3Kpv2IAaBuSj5nI9Rrf3iLLUL3yDKDsBPZd5nBypaE7p7Onk78pSAncyDMJJN7cMS9x+tpfIgI9v3UOhSoNXVRhANx9V6/r2mKH2UoI9hSoEgCo/09jWBtE0zqxKe32P74Yey2Sm+/oouINFW3QZF826HukQ37HJ3RLb6uvH8Tkix0gfjmgxRKk3N8X4a47y2SDzVh7OUKDTwMHZcIds3rFJzu1YMbe/bOQcX2M/OE8hPnTLOcdxIUQZ9BSgGugQvvFj5bXIifg5kRfcWsktFJMNqK3gZac3pV3VrC7prCfJAXoLuOi5+lH0CA7EHzUmC91nj8sCR;\n\t4:mXd/wsrcjD8hcZ0ojzlFV/QZDxV528QXitWBAPXd1qsiQPiPLJUtJdVxTnh2lMoyYePokkTxgg1N4pSs5CMYKD9STKmplEUAPLuylEQXJXf8QviTEAoljNMwwDdG4Xr/ZdxATdpvkY+Bmg9FhQsbndCBRt0gm9C9Y6YuZ3quESWczA9jMU+Wh272FHSLobAgAyNJDfzbbQj1dAirIfP/7noaf9L5WIlKbTEoJXiDKqlm+trqVKrVS4AGE3ibVxkQQ9pQSuihm3DR8gcx9+CxgoHWCSwOeX8UXEcqrA4QAAcZABc+owDpDVpv5+uk+q75kgAQbi/RUCHi8B7NutCF4Q==","1; DB6PR08MB2919;\n\t23:12uYDTMaME6Jsg37SvcwI/fUmFYEN8qLs3VxESDSoZxaIvbQpJHpeE/FTkGzqY7KplmiYCbhoQ3ZLJ/dsr1WFCBJld7fxaBt4rgujiKKNVLkfST5jJGQxdZym1HcIz8WRzzItTK8piAunm66IZe40FT2PCzKu22v2FaYS77TNuAKZdCjEAOo8Dh5pSa6GetnAfk5wDmUAaNCX+FVIX2jki6zooXk8L6qUZPo+wMAK27MRm6smpR60gJg15HVdOTiI/MeUdcfqAX30XTu+EENrvU61NDvYzfI6Y0kMaLC0gU3lnEQoruVNIhZ2v4xl5T65wl8ypz0Z72q1YAkFjlm2/oFLFlFXRTcgM2C9tBXeIP3RiH22QpfJM2rtPQMShTSgRaraG2JAtCLYV/cPoz3I5Vs8/BUz2ui2HqbnPvHXFVRzBCLvIGWUeaUdKqM0PS3gIECXJ0f1c8tyBSXeCrcusF8hIImyZoJSd9V3KeJclUmr6Tjp/hYBJMlLeQobBAo2rFgsLh/QlWst6myCtVvzJHdUyI45fdgUE7snhdTZ8RViAmN2JzNbzNM7nDE3a23LfQz9f2Oy4j0Dk/Onkcesrqh3/D30mrORqyDayWlimL0sm0jHH7TgkJAH9X8+Ft2WG/0BJm/AsK4NwGQZ1aiX0o6nAgtwX99IkPKgYbHBtkQRwOdLNrkxgtCKfPIT7nd9cBm5fwYniFXsQlmckg2RFHya50J8DUwZb5J/Fzx8j9y3ymwud6V0hSUE4Og+JE/2XTqFCePo2iLVcG2sxu8gHXES7hdpqD5nVQD4avpyv4cAGb4rCJOLZbEfUYtMKTde9qyI0kFePeaRfSL1d0v3eA3lWKorKwUqtGLuqI+fi/eaUjhF2ZwbMFff6eZttAWR3JX4PwJZcStDxC/4pO66pld1XbQBUDD6OjTSvZbWGrlwkxeJ+lF6NNwx/LJQt0p9SyiUWgmdhe/SbOB/Bvq26SC24ZN6a5pAUFPgSi7B5M+9oqHomW76H7JSxhDFXs76Qzgx1Kp/RkPXOUPgxHKI3psSEygO9iP8tWFx1hDN2OF/5MGYzED/qlalgQ5u4OPFfSgCX8rFgSzhWCrkbuizJfdAdundlEzF3NnDcu7ZHU6+JMdJXHUbVh3dHT7z3qKWuJfJbtmSUW69Y+0VF4iF8QJyEDsEA1KOLYMlQWq3jNeo25tuDKIaEGsVDqxQkcUzqaiO0TnO9mqJdv6lKtqAxsm9IwvCFiDA/FL+eoZDTc7ZSLjlRo5NORSp671WfOz7yEniXudixo4s5qwtJTConkceqBlj0/gb43NLsszRvc2i45yI1VVC8VlLTnU0CSadtY2wQfn4+gJ2xyg3qjMzy9tR5/BFg/hKKRe9/6T/1qbWkeKhOB+55GTcftNsTpOsYJ483fxZRxTq4KO4WWAvA==","1; DB6PR08MB2919;\n\t6:nOwwuC7Lp3d1IY45W0mPAiagS2MC7r9BHJIlXLIkAqOSubhoDeRfg0hSg/M3VvD6F28E5Y5t6V70WiAiWh1kiJhCrqdgYGXkwtgL/5R9321qmhW/PeX/WKsbiaA7CsnD8gMOULrnFVaCljOW+mUTmcc0kY9VnbXBJqSPHriHGEVyzzRp51MjcZcku/tp0IxoLs5Ex+qEQN44Jk5rEfPjlXbA+ncPg2pHt3jsCY3exKrkszacO3hCcIzqkuhBRA07/QdYyyglu9ClzZ/ADcyQU/4TBRnKKzqfu1JXY7SSsBmDeEs2iBnHmpkuRAePJUIKy46+rIxIEP+yK0aTu5clCw==;\n\t5:pREBJjTe/iEKeq5KmebrWd2aulMymNqlpOSEfsxr12PoHfdH/EUgKaTYFR+3/AdMIuPo6G8MPv2TuM819FQLQLjA0E3WmnZw14Mn/L11K9xwXJItJdm+rVoK6Ysv4JTbOFABNdm5ivFJQebB+LxTxQ==;\n\t24:FiWrP/ec3qzJ7Phr40LnJWJoo0KMjv3gS0HAVNznE6J2SsI4dhGeO7GJ2wSJYBKmQyRoTrNly/C4ethDDCI+pQO4EgOMbHgrlffIjty25jk=;\n\t7:ZQvkQvLXVvk4hd48V3pqndQ8DfZLhnZL6gjUNsNl9qP9l7mhi3KsiwwPocB3k6ULBC9Zvr7SNkVQ0zFyjuOC2nfrvhClEw8SAdJTM7fT09hAHyMYCs6uGllWTQV491Czhg/fcU1SyDYc6QrO1YfgCG2hHZHNY3+LLiVIKsQkcshjAyaNG7F4q3dMkovuuh/95whABjUh2Uz6Rx3y4bkoPZi8XOxe+o3gEYJrqfFmf2M="],"X-MS-TrafficTypeDiagnostic":"DB6PR08MB2919:","X-LD-Processed":"f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr","Content-Transfer-Encoding":"quoted-printable","X-Exchange-Antispam-Report-Test":"UriScan:(180628864354917)(244540007438412); ","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:DB6PR08MB2919; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:DB6PR08MB2919; ","X-Forefront-PRVS":"0464DBBBC4","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(376002)(39860400002)(346002)(377454003)(189002)(24454002)(40434004)(199003)(43544003)(33656002)(5890100001)(25786009)(305945005)(33716001)(6916009)(50466002)(72206003)(8676002)(2950100002)(316002)(8746002)(8936002)(53936002)(6246003)(106356001)(54906003)(58126008)(5660300001)(68736007)(105586002)(83506001)(97736004)(16526018)(1076002)(50986999)(66066001)(101416001)(53546010)(189998001)(54356999)(76176999)(6496005)(229853002)(230783001)(81166006)(2906002)(55016002)(3846002)(86362001)(7736002)(23726003)(6116002)(4326008)(81156014)(47776003)(93886005)(9686003)(478600001)(18370500001)(107986001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR08MB2919; H:red-moon; FPR:;\n\tSPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: arm.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"arm.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"18 Oct 2017 09:07:13.8980\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"f34e5979-57d9-4aaa-ad4d-b122a662184d","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DB6PR08MB2919","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1789287,"web_url":"http://patchwork.ozlabs.org/comment/1789287/","msgid":"<20171018092639.GD14820@red-moon>","list_archive_url":null,"date":"2017-10-18T09:26:39","subject":"Re: [PATCH v4 pci 0/2] PCI/MSI: pci-xgene-msi: Enable MSI support in\n\tACPI boot for X-Gene v1","submitter":{"id":5388,"url":"http://patchwork.ozlabs.org/api/people/5388/","name":"Lorenzo Pieralisi","email":"Lorenzo.Pieralisi@arm.com"},"content":"[removed unintended disclaimer]\n\nOn Tue, Oct 17, 2017 at 10:45:35PM -0700, Khuong Dinh wrote:\n> Hi Lorenzo,\n> \n> On Tue, Oct 17, 2017 at 6:38 AM, Lorenzo Pieralisi\n> wrote:\n> > Hi Khuong,\n> >\n> > On Mon, Oct 16, 2017 at 02:19:50PM -0700, Khuong Dinh wrote:\n> >> Hi Lorenzo,\n> >> Do you have any comments for this patch?\n> >\n> > I'd have some comments but given that there are related issues with ACPI\n> > probe ordering that Marc is trying to solve on his side - I will work\n> > with him to see if we can accommodate changes that can solve this issue\n> > too.\n> >\n> > Again - I recognize it is a complex problem (that is not even\n> > contemplated by the current ACPI specs), we have to try to make\n> > the solution as generic as we can to prevent reinventing the wheel\n> > anytime a sligthly different issue (related to ACPI probe ordering)\n> > comes up.\n> >\n> > Leave it to me (us) and I will get back to you on this.\n> \n> Thanks for helping to take care of the generic ACPI probe ordering issue.\n> Given that the patch 'PCI/MSI: pci-xgene-msi: Enable MSI support in ACPI\n> boot for X-Gene v1\" adds only the ACPI ID, can you pull in this patch\n> independently from the ACPI probe ordering issue?\n\nNo. For two reasons:\n\n1) It's Bjorn who decides whether that code can be merged or not, not me\n2) That patch sneaks in ACPI MSI support for X-gene v1 that depends on\n kernel link ordering. As soon as it is pulled in the mainline it\n creates a dependency on pseudo-working code that may break anytime\n and as I said many times before I am not willing to rely on that.\n\nLorenzo","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yH6C55vh2z9t3Z\n\tfor ;\n\tWed, 18 Oct 2017 20:26:57 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S967157AbdJRJ0k (ORCPT );\n\tWed, 18 Oct 2017 05:26:40 -0400","from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:36466 \"EHLO\n\tfoss.arm.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S965409AbdJRJ0i (ORCPT );\n\tWed, 18 Oct 2017 05:26:38 -0400","from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F10E81435;\n\tWed, 18 Oct 2017 02:26:37 -0700 (PDT)","from red-moon (red-moon.cambridge.arm.com [10.1.206.55])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n\t2FCC43F25D; Wed, 18 Oct 2017 02:26:36 -0700 (PDT)"],"Date":"Wed, 18 Oct 2017 10:26:39 +0100","From":"Lorenzo Pieralisi ","To":"Khuong Dinh ","Cc":"Marc Zyngier , msalter@redhat.com,\n\tBjorn Helgaas , linux-pci@vger.kernel.org,\n\tjcm@redhat.com, patches ,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\trjw@rjwysocki.net","Subject":"Re: [PATCH v4 pci 0/2] PCI/MSI: pci-xgene-msi: Enable MSI support in\n\tACPI boot for X-Gene v1","Message-ID":"<20171018092639.GD14820@red-moon>","References":"<1506448161-30961-1-git-send-email-kdinh@apm.com>\n\t\n\t<20171017133807.GB948@red-moon>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.5.21 (2010-09-15)","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1789991,"web_url":"http://patchwork.ozlabs.org/comment/1789991/","msgid":"","list_archive_url":null,"date":"2017-10-18T21:43:10","subject":"Re: [PATCH v4 pci 0/2] PCI/MSI: pci-xgene-msi: Enable MSI support in\n\tACPI boot for X-Gene v1","submitter":{"id":71514,"url":"http://patchwork.ozlabs.org/api/people/71514/","name":"Khuong Dinh","email":"kdinh@apm.com"},"content":"Hi Lorenzo,\n\n\nOn Wed, Oct 18, 2017 at 2:26 AM, Lorenzo Pieralisi\n wrote:\n> [removed unintended disclaimer]\n>\n> On Tue, Oct 17, 2017 at 10:45:35PM -0700, Khuong Dinh wrote:\n>> Hi Lorenzo,\n>>\n>> On Tue, Oct 17, 2017 at 6:38 AM, Lorenzo Pieralisi\n>> wrote:\n>> > Hi Khuong,\n>> >\n>> > On Mon, Oct 16, 2017 at 02:19:50PM -0700, Khuong Dinh wrote:\n>> >> Hi Lorenzo,\n>> >> Do you have any comments for this patch?\n>> >\n>> > I'd have some comments but given that there are related issues with ACPI\n>> > probe ordering that Marc is trying to solve on his side - I will work\n>> > with him to see if we can accommodate changes that can solve this issue\n>> > too.\n>> >\n>> > Again - I recognize it is a complex problem (that is not even\n>> > contemplated by the current ACPI specs), we have to try to make\n>> > the solution as generic as we can to prevent reinventing the wheel\n>> > anytime a sligthly different issue (related to ACPI probe ordering)\n>> > comes up.\n>> >\n>> > Leave it to me (us) and I will get back to you on this.\n>>\n>> Thanks for helping to take care of the generic ACPI probe ordering issue.\n>> Given that the patch 'PCI/MSI: pci-xgene-msi: Enable MSI support in ACPI\n>> boot for X-Gene v1\" adds only the ACPI ID, can you pull in this patch\n>> independently from the ACPI probe ordering issue?\n>\n> No. For two reasons:\n>\n> 1) It's Bjorn who decides whether that code can be merged or not, not me\n> 2) That patch sneaks in ACPI MSI support for X-gene v1 that depends on\n> kernel link ordering. As soon as it is pulled in the mainline it\n> creates a dependency on pseudo-working code that may break anytime\n> and as I said many times before I am not willing to rely on that.\n\nThanks for your information. I got it.\nI look forward to hearing your updated information about this generic\nACPI probe ordering issue.\n\n\n> Lorenzo","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=apm.com header.i=@apm.com header.b=\"dH6q4MlJ\";\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yHQXt6zH3z9t7D\n\tfor ;\n\tThu, 19 Oct 2017 08:43:26 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751462AbdJRVnM (ORCPT );\n\tWed, 18 Oct 2017 17:43:12 -0400","from mail-pf0-f177.google.com ([209.85.192.177]:51561 \"EHLO\n\tmail-pf0-f177.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751048AbdJRVnL (ORCPT\n\t); Wed, 18 Oct 2017 17:43:11 -0400","by mail-pf0-f177.google.com with SMTP id n14so4912641pfh.8\n\tfor ; Wed, 18 Oct 2017 14:43:11 -0700 (PDT)","by 10.100.180.76 with HTTP; Wed, 18 Oct 2017 14:43:10 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=apm.com; s=apm;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=ryvJ8zFaQOvaHMW9E8qipSpBnhY4eSlrlhZCQ54F04M=;\n\tb=dH6q4MlJWn/1T3MzkhJiAUCTNc7VJqwG8MOa991TEY1Utr3oBkkTaVzCNKRoTXeBH+\n\tr8hwU/27CInBP2FLjOsbiBCMnpgDEtK9fCZ9hvVNQ0RKMb8xOQuv3E7NgHcqjoYp/qNl\n\tD+BvrvJN128d5FrltMBfv7gQTmDqswoT1joy4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=ryvJ8zFaQOvaHMW9E8qipSpBnhY4eSlrlhZCQ54F04M=;\n\tb=CFJFNhfpjsRTTTte2BHMm0dTPD2PwB9dbBbTHp5YuyF6GbflYwl0bUcgMylYQ7F8de\n\tKJNFrSEurvkjL6p6bqRInlAptJ4clUJavC7F4GRk5su3xKz6nxoSEezSImwBC+8xRmjX\n\t5+PKXJPcJvnUYTiGPZy936NytfRAY4yDD+IkQSCOx6SmqiS8Dkpkwxll9T+hZ7H+4aF1\n\tQOG9yF64WVZzKQ1hJPJPT+X0sOjhnNumoHTa0DBlPXuiUdw0J5Y9jsCd8ROB5tIpQy0W\n\tAMqi7gRIwJbULSDnlsJUAJixtLGWbFH5B0he2sGXyUzFGY+kdxc8+meHRDKizsuqbMGX\n\tY0TQ==","X-Gm-Message-State":"AMCzsaWEB9Q8lENHGsrlbyHrXBkg4tfGqhTm+bZhgJXkkS1ZPmxycHbZ\n\tka6IAPokB0KqUbeuh6dyj9Ti6QsH9qCZ833viEGlBw==","X-Google-Smtp-Source":"AOwi7QC13200arTPA1TP+tfxHYrJchfWZF3nlbXQDpYD62iCgTQgg8UDzi3vDu31Sw4DZJNZzNbpumyudT39CyYnncQ=","X-Received":"by 10.98.198.138 with SMTP id x10mr14672801pfk.55.1508362990793; \n\tWed, 18 Oct 2017 14:43:10 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20171018092639.GD14820@red-moon>","References":"<1506448161-30961-1-git-send-email-kdinh@apm.com>\n\t\n\t<20171017133807.GB948@red-moon>\n\t\n\t<20171018092639.GD14820@red-moon>","From":"Khuong Dinh ","Date":"Wed, 18 Oct 2017 14:43:10 -0700","Message-ID":"","Subject":"Re: [PATCH v4 pci 0/2] PCI/MSI: pci-xgene-msi: Enable MSI support in\n\tACPI boot for X-Gene v1","To":"Lorenzo Pieralisi ","Cc":"Marc Zyngier , msalter@redhat.com,\n\tBjorn Helgaas , linux-pci@vger.kernel.org,\n\tjcm@redhat.com, patches ,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\trjw@rjwysocki.net","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}}]