[{"id":1778251,"web_url":"http://patchwork.ozlabs.org/comment/1778251/","msgid":"<6ba4e4da-e7e2-3279-f7dc-3f88f304fb66@redhat.com>","list_archive_url":null,"date":"2017-10-02T10:46:23","subject":"Re: [ovs-dev] [PATCH v2 0/4] Conntrack: add commands to r/w CT\n\tparameters.","submitter":{"id":70482,"url":"http://patchwork.ozlabs.org/api/people/70482/","name":"Kevin Traynor","email":"ktraynor@redhat.com"},"content":"On 09/26/2017 01:35 PM, antonio.fischetti@intel.com wrote:\n> This series adds two new commands to allow read/write of\n> some of the CT configuration parameters. This could be\n> used for maintenance purposes or to find a better tuning\n> of the current setup.\n> \n\nHi Antonio. I don't think that helps people not too familiar with\nconntrack understand why the commands are needed and what cases they\nwill help with. Also, I think there should be some documentation to\nguide the user on when to use the new commands. I'm not making comment\non the usefulness or not of the commands but there's a need to explain\nwhy you are making the changes and guide the user on them.\n\nthanks,\nKevin.\n\n> V2: Reworked based on comments.\n> V1: First implementation.\n> \n> Fischetti, Antonio (4):\n> dpctl: Add a comment to functions retrieving the datapath name.\n> conntrack: add commands to r/w CT parameters.\n> conntrack: r/w upper limit connection value.\n> conntrack: read current nr of connections.\n> \n> lib/conntrack.c | 90 +++++++++++++++++++++++++++++++++++++++++++++\n> lib/conntrack.h | 3 ++\n> lib/ct-dpif.c | 28 ++++++++++++++\n> lib/ct-dpif.h | 2 +\n> lib/dpctl.c | 104 +++++++++++++++++++++++++++++++++++++++++++++++++++-\n> lib/dpif-netdev.c | 19 ++++++++++\n> lib/dpif-netlink.c | 2 +\n> lib/dpif-provider.h | 4 ++\n> 8 files changed, 251 insertions(+), 1 deletion(-)\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ktraynor@redhat.com"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5JkQ6m74z9t4Z\n\tfor ;\n\tMon, 2 Oct 2017 21:46:35 +1100 (AEDT)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 8F86E480;\n\tMon, 2 Oct 2017 10:46:31 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 7A44E2C\n\tfor ; Mon, 2 Oct 2017 10:46:30 +0000 (UTC)","from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id BF04745A\n\tfor ; Mon, 2 Oct 2017 10:46:26 +0000 (UTC)","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 05ED981DFD;\n\tMon, 2 Oct 2017 10:46:26 +0000 (UTC)","from ktraynor.remote.csb (ovpn-117-223.ams2.redhat.com\n\t[10.36.117.223])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 51EAE67591;\n\tMon, 2 Oct 2017 10:46:25 +0000 (UTC)"],"X-Greylist":["domain auto-whitelisted by SQLgrey-1.7.6","Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tMon, 02 Oct 2017 10:46:26 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 05ED981DFD","To":"antonio.fischetti@intel.com, dev@openvswitch.org","References":"<1506429324-10416-1-git-send-email-antonio.fischetti@intel.com>","From":"Kevin Traynor ","Organization":"Red Hat","Message-ID":"<6ba4e4da-e7e2-3279-f7dc-3f88f304fb66@redhat.com>","Date":"Mon, 2 Oct 2017 11:46:23 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<1506429324-10416-1-git-send-email-antonio.fischetti@intel.com>","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Spam-Status":"No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH v2 0/4] Conntrack: add commands to r/w CT\n\tparameters.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1778792,"web_url":"http://patchwork.ozlabs.org/comment/1778792/","msgid":"","list_archive_url":null,"date":"2017-10-03T09:11:21","subject":"Re: [ovs-dev] [PATCH v2 0/4] Conntrack: add commands to r/w CT\n\tparameters.","submitter":{"id":68178,"url":"http://patchwork.ozlabs.org/api/people/68178/","name":"Fischetti, Antonio","email":"antonio.fischetti@intel.com"},"content":"Thanks Kevin, comments inline.\n\n-Antonio\n\n> -----Original Message-----\n> From: Kevin Traynor [mailto:ktraynor@redhat.com]\n> Sent: Monday, October 2, 2017 11:46 AM\n> To: Fischetti, Antonio ; dev@openvswitch.org\n> Subject: Re: [ovs-dev] [PATCH v2 0/4] Conntrack: add commands to r/w CT\n> parameters.\n> \n> On 09/26/2017 01:35 PM, antonio.fischetti@intel.com wrote:\n> > This series adds two new commands to allow read/write of\n> > some of the CT configuration parameters. This could be\n> > used for maintenance purposes or to find a better tuning\n> > of the current setup.\n> >\n> \n> Hi Antonio. I don't think that helps people not too familiar with\n> conntrack understand why the commands are needed and what cases they\n> will help with. \n\n[Antonio]\nI can rephrase it like:\nThis change comes from the consideration that when the CT is enabled \nthe overall performance can be deeply affected, even with simple \nfirewall rules and with stateless protocols like UDP. \nThis implementation adds a basic infrastructure that allows the user \nto adjust the CT configuration parameters at run-time in order to \nfind a better tuning.\nFor example - depending on the traffic profile - the user could decrease \nat run-time the maximum number of tracked connections, so to mitigate \nthe impact on performance.\n\n\n> Also, I think there should be some documentation to\n> guide the user on when to use the new commands. \n\n[Antonio]\nSure, I'll update the dpctl.man and possibly other docs too, like some \nnew doc inside Documentation/howto/ ?\nIf you think other docs should be updated/added please let me know.\n\n> I'm not making comment\n> on the usefulness or not of the commands but there's a need to explain\n> why you are making the changes and guide the user on them.\n> \n> thanks,\n> Kevin.\n> \n> > V2: Reworked based on comments.\n> > V1: First implementation.\n> >\n> > Fischetti, Antonio (4):\n> > dpctl: Add a comment to functions retrieving the datapath name.\n> > conntrack: add commands to r/w CT parameters.\n> > conntrack: r/w upper limit connection value.\n> > conntrack: read current nr of connections.\n> >\n> > lib/conntrack.c | 90 +++++++++++++++++++++++++++++++++++++++++++++\n> > lib/conntrack.h | 3 ++\n> > lib/ct-dpif.c | 28 ++++++++++++++\n> > lib/ct-dpif.h | 2 +\n> > lib/dpctl.c | 104\n> +++++++++++++++++++++++++++++++++++++++++++++++++++-\n> > lib/dpif-netdev.c | 19 ++++++++++\n> > lib/dpif-netlink.c | 2 +\n> > lib/dpif-provider.h | 4 ++\n> > 8 files changed, 251 insertions(+), 1 deletion(-)\n> >","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5tZR1bZdz9t2c\n\tfor ;\n\tTue, 3 Oct 2017 20:11:42 +1100 (AEDT)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 73C61900;\n\tTue, 3 Oct 2017 09:11:39 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 37BD28FF\n\tfor ; Tue, 3 Oct 2017 09:11:38 +0000 (UTC)","from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 61FF9468\n\tfor ; Tue, 3 Oct 2017 09:11:37 +0000 (UTC)","from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Oct 2017 02:11:36 -0700","from irsmsx103.ger.corp.intel.com ([163.33.3.157])\n\tby orsmga003.jf.intel.com with ESMTP; 03 Oct 2017 02:11:23 -0700","from irsmsx101.ger.corp.intel.com ([169.254.1.22]) by\n\tIRSMSX103.ger.corp.intel.com ([169.254.3.49]) with mapi id\n\t14.03.0319.002; Tue, 3 Oct 2017 10:11:22 +0100"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos; i=\"5.42,473,1500966000\"; d=\"scan'208\";\n\ta=\"1020989247\"","From":"\"Fischetti, Antonio\" ","To":"Kevin Traynor , \"dev@openvswitch.org\"\n\t","Thread-Topic":"[ovs-dev] [PATCH v2 0/4] Conntrack: add commands to r/w CT\n\tparameters.","Thread-Index":"AQHTO2u0u59sfjapCki8WVWlWLzuxKLRz1Aw","Date":"Tue, 3 Oct 2017 09:11:21 +0000","Message-ID":"","References":"<1506429324-10416-1-git-send-email-antonio.fischetti@intel.com>\n\t<6ba4e4da-e7e2-3279-f7dc-3f88f304fb66@redhat.com>","In-Reply-To":"<6ba4e4da-e7e2-3279-f7dc-3f88f304fb66@redhat.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-titus-metadata-40":"eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmM5NGJiODctYmQwNS00NWNlLWJjNzAtYTIyMmVmM2Y3NjQ5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Im1qMmh2WUFiQ0wxcEpqVnpxTlhxWGM3cXpodnFrZmptZ3ZUTUV5RllpOEU9In0=","x-ctpclassification":"CTP_IC","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[163.33.239.180]","MIME-Version":"1.0","X-Spam-Status":"No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH v2 0/4] Conntrack: add commands to r/w CT\n\tparameters.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1778818,"web_url":"http://patchwork.ozlabs.org/comment/1778818/","msgid":"","list_archive_url":null,"date":"2017-10-03T10:11:11","subject":"Re: [ovs-dev] [PATCH v2 0/4] Conntrack: add commands to r/w CT\n\tparameters.","submitter":{"id":70482,"url":"http://patchwork.ozlabs.org/api/people/70482/","name":"Kevin Traynor","email":"ktraynor@redhat.com"},"content":"On 10/03/2017 10:11 AM, Fischetti, Antonio wrote:\n> Thanks Kevin, comments inline.\n> \n> -Antonio\n> \n>> -----Original Message-----\n>> From: Kevin Traynor [mailto:ktraynor@redhat.com]\n>> Sent: Monday, October 2, 2017 11:46 AM\n>> To: Fischetti, Antonio ; dev@openvswitch.org\n>> Subject: Re: [ovs-dev] [PATCH v2 0/4] Conntrack: add commands to r/w CT\n>> parameters.\n>>\n>> On 09/26/2017 01:35 PM, antonio.fischetti@intel.com wrote:\n>>> This series adds two new commands to allow read/write of\n>>> some of the CT configuration parameters. This could be\n>>> used for maintenance purposes or to find a better tuning\n>>> of the current setup.\n>>>\n>>\n>> Hi Antonio. I don't think that helps people not too familiar with\n>> conntrack understand why the commands are needed and what cases they\n>> will help with. \n> \n> [Antonio]\n> I can rephrase it like:\n> This change comes from the consideration that when the CT is enabled \n> the overall performance can be deeply affected, even with simple \n> firewall rules and with stateless protocols like UDP. \n> This implementation adds a basic infrastructure that allows the user \n> to adjust the CT configuration parameters at run-time in order to \n> find a better tuning.\n> For example - depending on the traffic profile - the user could decrease \n> at run-time the maximum number of tracked connections, so to mitigate \n> the impact on performance.\n> \n\nSounds much better, thanks.\n\n> \n>> Also, I think there should be some documentation to\n>> guide the user on when to use the new commands. \n> \n> [Antonio]\n> Sure, I'll update the dpctl.man and possibly other docs too, like some \n> new doc inside Documentation/howto/ ?\n> If you think other docs should be updated/added please let me know.\n> \n\nYou could add to the 'performance tuning' section if it's just about\ngetting better performance. I don't really mind where, just that user\nhas enough info to know what they are and why they would use them.\n\nthanks,\nKevin.\n\n>> I'm not making comment\n>> on the usefulness or not of the commands but there's a need to explain\n>> why you are making the changes and guide the user on them.\n>>\n>> thanks,\n>> Kevin.\n>>\n>>> V2: Reworked based on comments.\n>>> V1: First implementation.\n>>>\n>>> Fischetti, Antonio (4):\n>>> dpctl: Add a comment to functions retrieving the datapath name.\n>>> conntrack: add commands to r/w CT parameters.\n>>> conntrack: r/w upper limit connection value.\n>>> conntrack: read current nr of connections.\n>>>\n>>> lib/conntrack.c | 90 +++++++++++++++++++++++++++++++++++++++++++++\n>>> lib/conntrack.h | 3 ++\n>>> lib/ct-dpif.c | 28 ++++++++++++++\n>>> lib/ct-dpif.h | 2 +\n>>> lib/dpctl.c | 104\n>> +++++++++++++++++++++++++++++++++++++++++++++++++++-\n>>> lib/dpif-netdev.c | 19 ++++++++++\n>>> lib/dpif-netlink.c | 2 +\n>>> lib/dpif-provider.h | 4 ++\n>>> 8 files changed, 251 insertions(+), 1 deletion(-)\n>>>\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ktraynor@redhat.com"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5vvF3w0sz9sBZ\n\tfor ;\n\tTue, 3 Oct 2017 21:11:19 +1100 (AEDT)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 2E0E69BA;\n\tTue, 3 Oct 2017 10:11:15 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 5D0B59AF\n\tfor ; Tue, 3 Oct 2017 10:11:14 +0000 (UTC)","from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id C265841D\n\tfor ; Tue, 3 Oct 2017 10:11:13 +0000 (UTC)","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3292A7E43A;\n\tTue, 3 Oct 2017 10:11:13 +0000 (UTC)","from ktraynor.remote.csb (ovpn-117-223.ams2.redhat.com\n\t[10.36.117.223])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 815EF18867;\n\tTue, 3 Oct 2017 10:11:12 +0000 (UTC)"],"X-Greylist":["domain auto-whitelisted by SQLgrey-1.7.6","Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tTue, 03 Oct 2017 10:11:13 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 3292A7E43A","To":"\"Fischetti, Antonio\" ,\n\t\"dev@openvswitch.org\" ","References":"<1506429324-10416-1-git-send-email-antonio.fischetti@intel.com>\n\t<6ba4e4da-e7e2-3279-f7dc-3f88f304fb66@redhat.com>\n\t","From":"Kevin Traynor ","Organization":"Red Hat","Message-ID":"","Date":"Tue, 3 Oct 2017 11:11:11 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Spam-Status":"No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH v2 0/4] Conntrack: add commands to r/w CT\n\tparameters.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1782783,"web_url":"http://patchwork.ozlabs.org/comment/1782783/","msgid":"","list_archive_url":null,"date":"2017-10-09T12:46:05","subject":"Re: [ovs-dev] [PATCH v2 0/4] Conntrack: add commands to r/w CT\n\tparameters.","submitter":{"id":68178,"url":"http://patchwork.ozlabs.org/api/people/68178/","name":"Fischetti, Antonio","email":"antonio.fischetti@intel.com"},"content":"Thanks Kevin, I'll rework a v3.\n\nAntonio\n\n> -----Original Message-----\n> From: Kevin Traynor [mailto:ktraynor@redhat.com]\n> Sent: Tuesday, October 3, 2017 11:11 AM\n> To: Fischetti, Antonio ; dev@openvswitch.org\n> Subject: Re: [ovs-dev] [PATCH v2 0/4] Conntrack: add commands to r/w CT\n> parameters.\n> \n> On 10/03/2017 10:11 AM, Fischetti, Antonio wrote:\n> > Thanks Kevin, comments inline.\n> >\n> > -Antonio\n> >\n> >> -----Original Message-----\n> >> From: Kevin Traynor [mailto:ktraynor@redhat.com]\n> >> Sent: Monday, October 2, 2017 11:46 AM\n> >> To: Fischetti, Antonio ; dev@openvswitch.org\n> >> Subject: Re: [ovs-dev] [PATCH v2 0/4] Conntrack: add commands to r/w CT\n> >> parameters.\n> >>\n> >> On 09/26/2017 01:35 PM, antonio.fischetti@intel.com wrote:\n> >>> This series adds two new commands to allow read/write of\n> >>> some of the CT configuration parameters. This could be\n> >>> used for maintenance purposes or to find a better tuning\n> >>> of the current setup.\n> >>>\n> >>\n> >> Hi Antonio. I don't think that helps people not too familiar with\n> >> conntrack understand why the commands are needed and what cases they\n> >> will help with.\n> >\n> > [Antonio]\n> > I can rephrase it like:\n> > This change comes from the consideration that when the CT is enabled\n> > the overall performance can be deeply affected, even with simple\n> > firewall rules and with stateless protocols like UDP.\n> > This implementation adds a basic infrastructure that allows the user\n> > to adjust the CT configuration parameters at run-time in order to\n> > find a better tuning.\n> > For example - depending on the traffic profile - the user could decrease\n> > at run-time the maximum number of tracked connections, so to mitigate\n> > the impact on performance.\n> >\n> \n> Sounds much better, thanks.\n> \n> >\n> >> Also, I think there should be some documentation to\n> >> guide the user on when to use the new commands.\n> >\n> > [Antonio]\n> > Sure, I'll update the dpctl.man and possibly other docs too, like some\n> > new doc inside Documentation/howto/ ?\n> > If you think other docs should be updated/added please let me know.\n> >\n> \n> You could add to the 'performance tuning' section if it's just about\n> getting better performance. I don't really mind where, just that user\n> has enough info to know what they are and why they would use them.\n> \n> thanks,\n> Kevin.\n> \n> >> I'm not making comment\n> >> on the usefulness or not of the commands but there's a need to explain\n> >> why you are making the changes and guide the user on them.\n> >>\n> >> thanks,\n> >> Kevin.\n> >>\n> >>> V2: Reworked based on comments.\n> >>> V1: First implementation.\n> >>>\n> >>> Fischetti, Antonio (4):\n> >>> dpctl: Add a comment to functions retrieving the datapath name.\n> >>> conntrack: add commands to r/w CT parameters.\n> >>> conntrack: r/w upper limit connection value.\n> >>> conntrack: read current nr of connections.\n> >>>\n> >>> lib/conntrack.c | 90 +++++++++++++++++++++++++++++++++++++++++++++\n> >>> lib/conntrack.h | 3 ++\n> >>> lib/ct-dpif.c | 28 ++++++++++++++\n> >>> lib/ct-dpif.h | 2 +\n> >>> lib/dpctl.c | 104\n> >> +++++++++++++++++++++++++++++++++++++++++++++++++++-\n> >>> lib/dpif-netdev.c | 19 ++++++++++\n> >>> lib/dpif-netlink.c | 2 +\n> >>> lib/dpif-provider.h | 4 ++\n> >>> 8 files changed, 251 insertions(+), 1 deletion(-)\n> >>>\n> >","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y9g3B4Bvkz9t6C\n\tfor ;\n\tMon, 9 Oct 2017 23:46:13 +1100 (AEDT)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id E5DE0AF0;\n\tMon, 9 Oct 2017 12:46:09 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id F1F23AEF\n\tfor ; Mon, 9 Oct 2017 12:46:08 +0000 (UTC)","from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 5F6DE130\n\tfor ; Mon, 9 Oct 2017 12:46:08 +0000 (UTC)","from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t09 Oct 2017 05:46:07 -0700","from irsmsx103.ger.corp.intel.com ([163.33.3.157])\n\tby orsmga004.jf.intel.com with ESMTP; 09 Oct 2017 05:46:06 -0700","from irsmsx101.ger.corp.intel.com ([169.254.1.22]) by\n\tIRSMSX103.ger.corp.intel.com ([169.254.3.49]) with mapi id\n\t14.03.0319.002; Mon, 9 Oct 2017 13:46:05 +0100"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,500,1500966000\"; d=\"scan'208\";a=\"136688152\"","From":"\"Fischetti, Antonio\" ","To":"Kevin Traynor , \"dev@openvswitch.org\"\n\t","Thread-Topic":"[ovs-dev] [PATCH v2 0/4] Conntrack: add commands to r/w CT\n\tparameters.","Thread-Index":"AQHTO2u0u59sfjapCki8WVWlWLzuxKLRz1AwgAAI9ICACannUA==","Date":"Mon, 9 Oct 2017 12:46:05 +0000","Message-ID":"","References":"<1506429324-10416-1-git-send-email-antonio.fischetti@intel.com>\n\t<6ba4e4da-e7e2-3279-f7dc-3f88f304fb66@redhat.com>\n\t\n\t","In-Reply-To":"","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-titus-metadata-40":"eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjQ5NWRlNzktMzEyYy00YmZlLWE2NDItOTVhMjlkNmMyOWNjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjBGVUZNUElydUNVTXU0SkRKNjJPTXViSE81WTdDZVV1NnVmNVdNV0FhRWc9In0=","x-ctpclassification":"CTP_IC","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[163.33.239.181]","MIME-Version":"1.0","X-Spam-Status":"No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH v2 0/4] Conntrack: add commands to r/w CT\n\tparameters.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]