[{"id":1775342,"web_url":"http://patchwork.ozlabs.org/comment/1775342/","msgid":"<1506421025.5626.6.camel@mtksdaap41>","list_archive_url":null,"date":"2017-09-26T10:17:05","subject":"Re: [PATCH v2 05/10] arm: dts: mt7623: update pio, usb and crypto\n\tnodes","submitter":{"id":65023,"url":"http://patchwork.ozlabs.org/api/people/65023/","name":"Yingjoe Chen","email":"yingjoe.chen@mediatek.com"},"content":"On Tue, 2017-09-26 at 10:02 +0800, Ryder Lee wrote:\n> This patch updates pio, usb and crypto nodes to make them be consistent\n> with the binding documents.\n> \n> Signed-off-by: Ryder Lee \n> ---\n> arch/arm/boot/dts/mt7623.dtsi | 52 ++++++++++++++++++++++---------------------\n> 1 file changed, 27 insertions(+), 25 deletions(-)\n> \n> diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi\n> index 381843e..9ec3767 100644\n> --- a/arch/arm/boot/dts/mt7623.dtsi\n> +++ b/arch/arm/boot/dts/mt7623.dtsi\n> @@ -226,21 +226,6 @@\n> \t\t#reset-cells = <1>;\n> \t};\n> \n> -\tpio: pinctrl@10005000 {\n> -\t\tcompatible = \"mediatek,mt7623-pinctrl\",\n> -\t\t\t \"mediatek,mt2701-pinctrl\";\n> -\t\treg = <0 0x1000b000 0 0x1000>;\n> -\t\tmediatek,pctl-regmap = <&syscfg_pctl_a>;\n> -\t\tpins-are-numbered;\n> -\t\tgpio-controller;\n> -\t\t#gpio-cells = <2>;\n> -\t\tinterrupt-controller;\n> -\t\tinterrupt-parent = <&gic>;\n> -\t\t#interrupt-cells = <2>;\n> -\t\tinterrupts = ,\n> -\t\t\t ;\n> -\t};\n> -\n> \tsyscfg_pctl_a: syscfg@10005000 {\n> \t\tcompatible = \"mediatek,mt7623-pctl-a-syscfg\", \"syscon\";\n> \t\treg = <0 0x10005000 0 0x1000>;\n\n\nHi Ryder,\n\npio node is special, it have 2 registers space.\nThe address 10005000 is for PIO, it was accesed through syscfg_pctl_a\nregmap. The other one, 0x1000b000, is for EINT.\n\nSo,I think using address @10005000 is correct.\n\nJoe.C","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"Y2SBVK+E\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1cN605NVz9sPr\n\tfor ;\n\tTue, 26 Sep 2017 20:17:58 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwmw6-00018F-LW; Tue, 26 Sep 2017 10:17:54 +0000","from [210.61.82.184] (helo=mailgw02.mediatek.com)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwmw2-0000p8-DC; Tue, 26 Sep 2017 10:17:52 +0000","from mtkcas06.mediatek.inc [(172.21.101.30)] by\n\tmailgw02.mediatek.com (envelope-from )\n\t(mhqrelay.mediatek.com ESMTP with TLS)\n\twith ESMTP id 2047473813; Tue, 26 Sep 2017 18:17:17 +0800","from mtkcas09.mediatek.inc (172.21.101.178) by\n\tmtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server\n\t(TLS) id 15.0.1210.3; Tue, 26 Sep 2017 18:16:34 +0800","from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc\n\t(172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via\n\tFrontend Transport; Tue, 26 Sep 2017 18:17:37 +0800"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tDate:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=LDx5/vCBkh8OqC+Iw+dDmTvBHleqvOEfxoHX5ncE1TQ=;\n\tb=Y2SBVK+EIoHryp\n\t08CcvM1e3QTKMlxkg6YUzk3N32hj4zTiHFiDIM4kd5IRvJmt9lkp3MgaGEmQP43xBbCfH13VXYZpj\n\tDIp0GQKXbDSb1ZJTUZ7vRkAcy3/5IJuUxnj4A3y4PLCu1nzoF8Vd5rIUKsCxiZVsukDjWmpnmoZ2C\n\twYC63aRtblJn6WIgqK20n1nbYSB8MsZbBpHuvW0B7oLMXvh9XRTzVC/YZ7Kio6DJFCfFLlo5/K7FF\n\tud/WOEgmZN01Wfmx8F394zKeCQSvlWnWGh8GI3VDPcyLsMjRAAmWGILcbvzL8PzuSmnqmBNhKFOen\n\tHU1b4PbZCxS3fnruvopA==;","X-UUID":"6df5dcfc068548d0856a5cfcb45bb222-20170926","Message-ID":"<1506421025.5626.6.camel@mtksdaap41>","Subject":"Re: [PATCH v2 05/10] arm: dts: mt7623: update pio, usb and crypto\n\tnodes","From":"Yingjoe Chen ","To":"Ryder Lee ","Date":"Tue, 26 Sep 2017 18:17:05 +0800","In-Reply-To":"<93734b87262a8305b67e989777dfa1297d66cee4.1506390597.git.ryder.lee@mediatek.com>","References":"\n\t<93734b87262a8305b67e989777dfa1297d66cee4.1506390597.git.ryder.lee@mediatek.com>","X-Mailer":"Evolution 3.2.3-0ubuntu6 ","MIME-Version":"1.0","X-MTK":"N","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170926_031750_723192_5A486067 ","X-CRM114-Status":"GOOD ( 11.92 )","X-Spam-Score":"-1.1 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.1 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.8 RDNS_NONE Delivered to internal network by a host with no rDNS\n\t0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n\tlines","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, Erin Lo ,\n\tlinux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,\n\tMatthias Brugger ,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1776006,"web_url":"http://patchwork.ozlabs.org/comment/1776006/","msgid":"<1506482571.14972.6.camel@mtkswgap22>","list_archive_url":null,"date":"2017-09-27T03:22:51","subject":"Re: [PATCH v2 05/10] arm: dts: mt7623: update pio, usb and crypto\n\tnodes","submitter":{"id":70514,"url":"http://patchwork.ozlabs.org/api/people/70514/","name":"Ryder Lee","email":"ryder.lee@mediatek.com"},"content":"On Tue, 2017-09-26 at 18:17 +0800, Yingjoe Chen wrote:\n> On Tue, 2017-09-26 at 10:02 +0800, Ryder Lee wrote:\n> > This patch updates pio, usb and crypto nodes to make them be consistent\n> > with the binding documents.\n> > \n> > Signed-off-by: Ryder Lee \n> > ---\n> > arch/arm/boot/dts/mt7623.dtsi | 52 ++++++++++++++++++++++---------------------\n> > 1 file changed, 27 insertions(+), 25 deletions(-)\n> > \n> > diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi\n> > index 381843e..9ec3767 100644\n> > --- a/arch/arm/boot/dts/mt7623.dtsi\n> > +++ b/arch/arm/boot/dts/mt7623.dtsi\n> > @@ -226,21 +226,6 @@\n> > \t\t#reset-cells = <1>;\n> > \t};\n> > \n> > -\tpio: pinctrl@10005000 {\n> > -\t\tcompatible = \"mediatek,mt7623-pinctrl\",\n> > -\t\t\t \"mediatek,mt2701-pinctrl\";\n> > -\t\treg = <0 0x1000b000 0 0x1000>;\n> > -\t\tmediatek,pctl-regmap = <&syscfg_pctl_a>;\n> > -\t\tpins-are-numbered;\n> > -\t\tgpio-controller;\n> > -\t\t#gpio-cells = <2>;\n> > -\t\tinterrupt-controller;\n> > -\t\tinterrupt-parent = <&gic>;\n> > -\t\t#interrupt-cells = <2>;\n> > -\t\tinterrupts = ,\n> > -\t\t\t ;\n> > -\t};\n> > -\n> > \tsyscfg_pctl_a: syscfg@10005000 {\n> > \t\tcompatible = \"mediatek,mt7623-pctl-a-syscfg\", \"syscon\";\n> > \t\treg = <0 0x10005000 0 0x1000>;\n> \n> \n> Hi Ryder,\n> \n> pio node is special, it have 2 registers space.\n> The address 10005000 is for PIO, it was accesed through syscfg_pctl_a\n> regmap. The other one, 0x1000b000, is for EINT.\n> \n> So,I think using address @10005000 is correct.\n> \n> Joe.C\n> \n\nThanks for explanation. I'll revert this part to a previous state.\n\n>","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"YpyhmSPz\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y237W3kJFz9t4Z\n\tfor ;\n\tWed, 27 Sep 2017 13:23:34 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dx2wb-0007c0-Om; Wed, 27 Sep 2017 03:23:29 +0000","from [210.61.82.183] (helo=mailgw01.mediatek.com)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dx2wY-0007UB-As; Wed, 27 Sep 2017 03:23:28 +0000","from mtkcas08.mediatek.inc [(172.21.101.126)] by\n\tmailgw01.mediatek.com (envelope-from )\n\t(mhqrelay.mediatek.com ESMTP with TLS)\n\twith ESMTP id 852270863; Wed, 27 Sep 2017 11:22:51 +0800","from mtkcas08.mediatek.inc (172.21.101.126) by\n\tmtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server\n\t(TLS) id 15.0.1210.3; Wed, 27 Sep 2017 11:22:32 +0800","from [172.21.77.33] (172.21.77.33) by mtkcas08.mediatek.inc\n\t(172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via\n\tFrontend Transport; Wed, 27 Sep 2017 11:22:51 +0800"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tDate:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=mO2CtsY9CBqw4PkLdIEVrUw6WkiuecjKumHEAOTBi/Q=;\n\tb=YpyhmSPzWJUi5Q\n\tc9+qscj3/abjj9ikKyukDGD4MhV1H9zS69KRTcHnVXMucyNPRwEc8G9WMD8GlSNxWhUH9yEXjSexc\n\tEuRv8Don8JDsak2EtbNVi78U2zbKObUCKF2lTF0nrrLnEGYYed4LuB6i7xJNSfhSzWvj1YDDwwpVn\n\tS66hU9WW+rZ0TeCxIsFp96V6ynEOMUFzgTsFzZ7tfGiiznmfgvCIUy8tjzsuFZ3i6vOi0IKkdKj8W\n\tYnT3/niMhBqSjQfu9ihutFYg+hwS1hRzmxOtjXxIErgeiX1ISIHD5TJadcTpEVJst+zAFPnGDk5GY\n\tb8Kr2O2Ru+QpetCnf+kg==;","X-UUID":"f54324c93fd04216b410d510d98738e4-20170927","Message-ID":"<1506482571.14972.6.camel@mtkswgap22>","Subject":"Re: [PATCH v2 05/10] arm: dts: mt7623: update pio, usb and crypto\n\tnodes","From":"Ryder Lee ","To":"Yingjoe Chen ","Date":"Wed, 27 Sep 2017 11:22:51 +0800","In-Reply-To":"<1506421025.5626.6.camel@mtksdaap41>","References":"\n\t<93734b87262a8305b67e989777dfa1297d66cee4.1506390597.git.ryder.lee@mediatek.com>\n\t<1506421025.5626.6.camel@mtksdaap41>","X-Mailer":"Evolution 3.2.3-0ubuntu6 ","MIME-Version":"1.0","X-MTK":"N","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170926_202326_533117_6BFE8460 ","X-CRM114-Status":"GOOD ( 14.43 )","X-Spam-Score":"-1.1 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.1 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.8 RDNS_NONE Delivered to internal network by a host with no rDNS\n\t0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n\tlines","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, Erin Lo ,\n\tlinux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,\n\tMatthias Brugger ,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]