[{"id":1775341,"web_url":"http://patchwork.ozlabs.org/comment/1775341/","msgid":"<1506421025.5626.6.camel@mtksdaap41>","list_archive_url":null,"date":"2017-09-26T10:17:05","subject":"Re: [PATCH v2 05/10] arm: dts: mt7623: update pio, usb and crypto\n\tnodes","submitter":{"id":65023,"url":"http://patchwork.ozlabs.org/api/people/65023/","name":"Yingjoe Chen","email":"yingjoe.chen@mediatek.com"},"content":"On Tue, 2017-09-26 at 10:02 +0800, Ryder Lee wrote:\n> This patch updates pio, usb and crypto nodes to make them be consistent\n> with the binding documents.\n> \n> Signed-off-by: Ryder Lee \n> ---\n> arch/arm/boot/dts/mt7623.dtsi | 52 ++++++++++++++++++++++---------------------\n> 1 file changed, 27 insertions(+), 25 deletions(-)\n> \n> diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi\n> index 381843e..9ec3767 100644\n> --- a/arch/arm/boot/dts/mt7623.dtsi\n> +++ b/arch/arm/boot/dts/mt7623.dtsi\n> @@ -226,21 +226,6 @@\n> \t\t#reset-cells = <1>;\n> \t};\n> \n> -\tpio: pinctrl@10005000 {\n> -\t\tcompatible = \"mediatek,mt7623-pinctrl\",\n> -\t\t\t \"mediatek,mt2701-pinctrl\";\n> -\t\treg = <0 0x1000b000 0 0x1000>;\n> -\t\tmediatek,pctl-regmap = <&syscfg_pctl_a>;\n> -\t\tpins-are-numbered;\n> -\t\tgpio-controller;\n> -\t\t#gpio-cells = <2>;\n> -\t\tinterrupt-controller;\n> -\t\tinterrupt-parent = <&gic>;\n> -\t\t#interrupt-cells = <2>;\n> -\t\tinterrupts = ,\n> -\t\t\t ;\n> -\t};\n> -\n> \tsyscfg_pctl_a: syscfg@10005000 {\n> \t\tcompatible = \"mediatek,mt7623-pctl-a-syscfg\", \"syscon\";\n> \t\treg = <0 0x10005000 0 0x1000>;\n\n\nHi Ryder,\n\npio node is special, it have 2 registers space.\nThe address 10005000 is for PIO, it was accesed through syscfg_pctl_a\nregmap. The other one, 0x1000b000, is for EINT.\n\nSo,I think using address @10005000 is correct.\n\nJoe.C\n\n\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1cMf6dmtz9tXf\n\tfor ;\n\tTue, 26 Sep 2017 20:17:34 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S967982AbdIZKRX (ORCPT );\n\tTue, 26 Sep 2017 06:17:23 -0400","from mailgw02.mediatek.com ([210.61.82.184]:16827 \"EHLO\n\tmailgw02.mediatek.com\" rhost-flags-OK-FAIL-OK-FAIL) by\n\tvger.kernel.org with ESMTP id S965430AbdIZKRW (ORCPT\n\t); Tue, 26 Sep 2017 06:17:22 -0400","from mtkcas06.mediatek.inc [(172.21.101.30)] by\n\tmailgw02.mediatek.com (envelope-from )\n\t(mhqrelay.mediatek.com ESMTP with TLS)\n\twith ESMTP id 2047473813; Tue, 26 Sep 2017 18:17:17 +0800","from mtkcas09.mediatek.inc (172.21.101.178) by\n\tmtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server\n\t(TLS) id 15.0.1210.3; Tue, 26 Sep 2017 18:16:34 +0800","from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc\n\t(172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via\n\tFrontend Transport; Tue, 26 Sep 2017 18:17:37 +0800"],"X-UUID":"6df5dcfc068548d0856a5cfcb45bb222-20170926","Message-ID":"<1506421025.5626.6.camel@mtksdaap41>","Subject":"Re: [PATCH v2 05/10] arm: dts: mt7623: update pio, usb and crypto\n\tnodes","From":"Yingjoe Chen ","To":"Ryder Lee ","CC":"Matthias Brugger ,\n\t, Erin Lo ,\n\t, , \n\t","Date":"Tue, 26 Sep 2017 18:17:05 +0800","In-Reply-To":"<93734b87262a8305b67e989777dfa1297d66cee4.1506390597.git.ryder.lee@mediatek.com>","References":"\n\t<93734b87262a8305b67e989777dfa1297d66cee4.1506390597.git.ryder.lee@mediatek.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.2.3-0ubuntu6 ","Content-Transfer-Encoding":"7bit","MIME-Version":"1.0","X-MTK":"N","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1776005,"web_url":"http://patchwork.ozlabs.org/comment/1776005/","msgid":"<1506482571.14972.6.camel@mtkswgap22>","list_archive_url":null,"date":"2017-09-27T03:22:51","subject":"Re: [PATCH v2 05/10] arm: dts: mt7623: update pio, usb and crypto\n\tnodes","submitter":{"id":70514,"url":"http://patchwork.ozlabs.org/api/people/70514/","name":"Ryder Lee","email":"ryder.lee@mediatek.com"},"content":"On Tue, 2017-09-26 at 18:17 +0800, Yingjoe Chen wrote:\n> On Tue, 2017-09-26 at 10:02 +0800, Ryder Lee wrote:\n> > This patch updates pio, usb and crypto nodes to make them be consistent\n> > with the binding documents.\n> > \n> > Signed-off-by: Ryder Lee \n> > ---\n> > arch/arm/boot/dts/mt7623.dtsi | 52 ++++++++++++++++++++++---------------------\n> > 1 file changed, 27 insertions(+), 25 deletions(-)\n> > \n> > diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi\n> > index 381843e..9ec3767 100644\n> > --- a/arch/arm/boot/dts/mt7623.dtsi\n> > +++ b/arch/arm/boot/dts/mt7623.dtsi\n> > @@ -226,21 +226,6 @@\n> > \t\t#reset-cells = <1>;\n> > \t};\n> > \n> > -\tpio: pinctrl@10005000 {\n> > -\t\tcompatible = \"mediatek,mt7623-pinctrl\",\n> > -\t\t\t \"mediatek,mt2701-pinctrl\";\n> > -\t\treg = <0 0x1000b000 0 0x1000>;\n> > -\t\tmediatek,pctl-regmap = <&syscfg_pctl_a>;\n> > -\t\tpins-are-numbered;\n> > -\t\tgpio-controller;\n> > -\t\t#gpio-cells = <2>;\n> > -\t\tinterrupt-controller;\n> > -\t\tinterrupt-parent = <&gic>;\n> > -\t\t#interrupt-cells = <2>;\n> > -\t\tinterrupts = ,\n> > -\t\t\t ;\n> > -\t};\n> > -\n> > \tsyscfg_pctl_a: syscfg@10005000 {\n> > \t\tcompatible = \"mediatek,mt7623-pctl-a-syscfg\", \"syscon\";\n> > \t\treg = <0 0x10005000 0 0x1000>;\n> \n> \n> Hi Ryder,\n> \n> pio node is special, it have 2 registers space.\n> The address 10005000 is for PIO, it was accesed through syscfg_pctl_a\n> regmap. The other one, 0x1000b000, is for EINT.\n> \n> So,I think using address @10005000 is correct.\n> \n> Joe.C\n> \n\nThanks for explanation. I'll revert this part to a previous state.\n\n> \n\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y236w4Jftz9t4Z\n\tfor ;\n\tWed, 27 Sep 2017 13:23:04 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1031700AbdI0DXC (ORCPT\n\t);\n\tTue, 26 Sep 2017 23:23:02 -0400","from mailgw01.mediatek.com ([210.61.82.183]:23805 \"EHLO\n\tmailgw01.mediatek.com\" rhost-flags-OK-FAIL-OK-FAIL) by\n\tvger.kernel.org with ESMTP id S1031289AbdI0DXB (ORCPT\n\t); Tue, 26 Sep 2017 23:23:01 -0400","from mtkcas08.mediatek.inc [(172.21.101.126)] by\n\tmailgw01.mediatek.com (envelope-from )\n\t(mhqrelay.mediatek.com ESMTP with TLS)\n\twith ESMTP id 852270863; Wed, 27 Sep 2017 11:22:51 +0800","from mtkcas08.mediatek.inc (172.21.101.126) by\n\tmtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server\n\t(TLS) id 15.0.1210.3; Wed, 27 Sep 2017 11:22:32 +0800","from [172.21.77.33] (172.21.77.33) by mtkcas08.mediatek.inc\n\t(172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via\n\tFrontend Transport; Wed, 27 Sep 2017 11:22:51 +0800"],"X-UUID":"f54324c93fd04216b410d510d98738e4-20170927","Message-ID":"<1506482571.14972.6.camel@mtkswgap22>","Subject":"Re: [PATCH v2 05/10] arm: dts: mt7623: update pio, usb and crypto\n\tnodes","From":"Ryder Lee ","To":"Yingjoe Chen ","CC":"Matthias Brugger ,\n\t, Erin Lo ,\n\t, , \n\t","Date":"Wed, 27 Sep 2017 11:22:51 +0800","In-Reply-To":"<1506421025.5626.6.camel@mtksdaap41>","References":"\n\t<93734b87262a8305b67e989777dfa1297d66cee4.1506390597.git.ryder.lee@mediatek.com>\n\t<1506421025.5626.6.camel@mtksdaap41>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.2.3-0ubuntu6 ","Content-Transfer-Encoding":"7bit","MIME-Version":"1.0","X-MTK":"N","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]